Build failed in Jenkins: Log4j 2 2.x #3804

2019-01-29 Thread Apache Jenkins Server
See -- [...truncated 1.13 MB...] Uploading:

[jira] [Commented] (LOG4J2-1906) DirectWriteRolloverStrategy not properly creating files

2019-01-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755677#comment-16755677 ] ASF subversion and git services commented on LOG4J2-1906: - Commit

[jira] [Commented] (LOG4J2-1906) DirectWriteRolloverStrategy not properly creating files

2019-01-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755665#comment-16755665 ] ASF subversion and git services commented on LOG4J2-1906: - Commit

[GitHub] qub1n commented on issue #46: '(doc)' make the method RollingFileAppender.RollFile() virtual.

2019-01-29 Thread GitBox
qub1n commented on issue #46: '(doc)' make the method RollingFileAppender.RollFile() virtual. URL: https://github.com/apache/logging-log4net/pull/46#issuecomment-458581571 Is there a reasoning why the pull request is not based onto develop? -> No, it was just the default option on

[GitHub] dpsenner commented on issue #46: '(doc)' make the method RollingFileAppender.RollFile() virtual.

2019-01-29 Thread GitBox
dpsenner commented on issue #46: '(doc)' make the method RollingFileAppender.RollFile() virtual. URL: https://github.com/apache/logging-log4net/pull/46#issuecomment-458578245 I propose to add both oldFile and newFile to the method arguments. Is there a reasoning why the pull request is

[GitHub] qub1n commented on issue #46: '(doc)' make the method RollingFileAppender.RollFile() virtual.

2019-01-29 Thread GitBox
qub1n commented on issue #46: '(doc)' make the method RollingFileAppender.RollFile() virtual. URL: https://github.com/apache/logging-log4net/pull/46#issuecomment-458575271 Yes following empty method would be sufficient. protected virtual void OnFileRolled(string filename){}

[GitHub] dpsenner commented on issue #46: '(doc)' make the method RollingFileAppender.RollFile() virtual.

2019-01-29 Thread GitBox
dpsenner commented on issue #46: '(doc)' make the method RollingFileAppender.RollFile() virtual. URL: https://github.com/apache/logging-log4net/pull/46#issuecomment-458574137 Would it be more appropriate to add an invocation of an emty but virtual PostRollFile method?

[GitHub] qub1n opened a new pull request #46: '(doc)' make the method RollingFileAppender.RollFile() virtual.

2019-01-29 Thread GitBox
qub1n opened a new pull request #46: '(doc)' make the method RollingFileAppender.RollFile() virtual. URL: https://github.com/apache/logging-log4net/pull/46 I need to post process rolled file by archiver and I can hardly achieve it without making this method virtual.

[jira] [Commented] (LOG4J2-2538) A memory appender that can be triggered to dump in-memory logging messages to file

2019-01-29 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755013#comment-16755013 ] Gary Gregory commented on LOG4J2-2538: -- Have you consider using hierarchical loggers or log

[jira] [Commented] (LOG4J2-1906) DirectWriteRolloverStrategy not properly creating files

2019-01-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755012#comment-16755012 ] ASF subversion and git services commented on LOG4J2-1906: - Commit

[jira] [Commented] (LOG4J2-2538) A memory appender that can be triggered to dump in-memory logging messages to file

2019-01-29 Thread Deshui Yu (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754879#comment-16754879 ] Deshui Yu commented on LOG4J2-2538: --- This issue has almost the same idea to LOG4J2-1137 > A memory

[jira] [Updated] (LOG4J2-2538) A memory appender that can be triggered to dump in-memory logging messages to file

2019-01-29 Thread Deshui Yu (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deshui Yu updated LOG4J2-2538: -- Affects Version/s: 2.11.1 > A memory appender that can be triggered to dump in-memory logging

[jira] [Created] (LOG4J2-2538) A memory appender that can be triggered to dump in-memory logging messages to file

2019-01-29 Thread Deshui Yu (JIRA)
Deshui Yu created LOG4J2-2538: - Summary: A memory appender that can be triggered to dump in-memory logging messages to file Key: LOG4J2-2538 URL: https://issues.apache.org/jira/browse/LOG4J2-2538