[CI][UNSTABLE] Logging/log4j/master#200 has test failures

2021-01-07 Thread Mr. Jenkins
BUILD UNSTABLE Build URL https://ci-builds.apache.org/job/Logging/job/log4j/job/master/200/ Project: master Date of build: Thu, 07 Jan 2021 15:51:05 + Build duration: 1 hr 33 min and counting JUnit Tests Name: liquibase.ext.logging.log4j2

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
carterkozak commented on a change in pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#discussion_r553434123 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppenderEventForwarder.java ## @@ -0,0 +1,147 @@ +/* + *

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
carterkozak commented on a change in pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#discussion_r553433626 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppenderEventForwarder.java ## @@ -0,0 +1,146 @@ +/* + *

[GitHub] [logging-log4j2] vy commented on a change in pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
vy commented on a change in pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#discussion_r553432863 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppenderEventForwarder.java ## @@ -0,0 +1,147 @@ +/* + * Licensed to

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
carterkozak commented on a change in pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#discussion_r553432581 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppenderEventForwarder.java ## @@ -0,0 +1,146 @@ +/* + *

[jira] [Commented] (LOG4J2-2995) How to use eventTemplateAdditionalFields in log4j2.yaml

2021-01-07 Thread Michal Stefan (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260606#comment-17260606 ] Michal Stefan commented on LOG4J2-2995: --- Hello [~vy], I see ok thanks for such quick response!

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
carterkozak commented on a change in pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#discussion_r553423896 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppenderEventForwarder.java ## @@ -0,0 +1,147 @@ +/* + *

[GitHub] [logging-log4j2] vy commented on a change in pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
vy commented on a change in pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#discussion_r553422956 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppenderEventForwarder.java ## @@ -0,0 +1,147 @@ +/* + * Licensed to

[jira] [Commented] (LOG4J2-2972) AsyncAppender thread gets killed with ThreadDeath exception

2021-01-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260603#comment-17260603 ] ASF subversion and git services commented on LOG4J2-2972: - Commit

[jira] [Commented] (LOG4J2-2972) AsyncAppender thread gets killed with ThreadDeath exception

2021-01-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260601#comment-17260601 ] ASF subversion and git services commented on LOG4J2-2972: - Commit

[GitHub] [logging-log4j2] vy commented on a change in pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
vy commented on a change in pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#discussion_r553421839 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppenderEventForwarder.java ## @@ -0,0 +1,147 @@ +/* + * Licensed to

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
garydgregory commented on a change in pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#discussion_r553420888 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppenderEventForwarder.java ## @@ -0,0 +1,147 @@ +/* + *

[GitHub] [logging-log4j2] vy commented on a change in pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
vy commented on a change in pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#discussion_r553417392 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppenderEventForwarder.java ## @@ -0,0 +1,147 @@ +/* + * Licensed to

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
carterkozak commented on a change in pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#discussion_r553416530 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppenderEventForwarder.java ## @@ -0,0 +1,147 @@ +/* + *

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
carterkozak commented on a change in pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#discussion_r553412249 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppenderEventForwarder.java ## @@ -0,0 +1,147 @@ +/* + *

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
carterkozak commented on a change in pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#discussion_r553412249 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppenderEventForwarder.java ## @@ -0,0 +1,147 @@ +/* + *

[GitHub] [logging-log4j2] vy commented on pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
vy commented on pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#issuecomment-756195475 > A bit of a challenge to follow the bouncing ball ;-) but I would like to confirm/ask that with the new behavior that flushes events on shutdown, that there is no chance of an

[GitHub] [logging-log4j2] vy commented on a change in pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
vy commented on a change in pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#discussion_r553405665 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppenderEventForwarder.java ## @@ -0,0 +1,147 @@ +/* + * Licensed to

[GitHub] [logging-log4j2] vy commented on a change in pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
vy commented on a change in pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#discussion_r553405665 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppenderEventForwarder.java ## @@ -0,0 +1,147 @@ +/* + * Licensed to

[GitHub] [logging-log4j2] vy commented on a change in pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
vy commented on a change in pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#discussion_r553404772 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppenderEventForwarder.java ## @@ -0,0 +1,147 @@ +/* + * Licensed to

[GitHub] [logging-log4j2] vy commented on a change in pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
vy commented on a change in pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#discussion_r553403880 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppenderEventForwarder.java ## @@ -0,0 +1,147 @@ +/* + * Licensed to

[GitHub] [logging-log4j2] carterkozak edited a comment on pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
carterkozak edited a comment on pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#issuecomment-756187667 One point of clarification, I don't think the `Log4jLogEvent` change results in any different behavior, each event (with the exception of `SHUTDOWN_LOG_EVENT`)

[GitHub] [logging-log4j2] carterkozak commented on pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
carterkozak commented on pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#issuecomment-756187667 One point of clarification, I don't think the `Log4jLogEvent` change results in any different behavior, each event (with the exception of `SHUTDOWN_LOG_EVENT`) is

[jira] [Commented] (LOG4J2-2989) Has Log4j2 a risk of losing logs for streaming towards a remote server when it cannot re-establish a connection towards the server?

2021-01-07 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260572#comment-17260572 ] Matt Sicker commented on LOG4J2-2989: - One current plugin you could use to implement that strategy

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
carterkozak commented on a change in pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#discussion_r553368134 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppenderEventForwarder.java ## @@ -0,0 +1,147 @@ +/* + *

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
carterkozak commented on a change in pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#discussion_r553366996 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppenderEventForwarder.java ## @@ -0,0 +1,147 @@ +/* + *

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
carterkozak commented on a change in pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#discussion_r553364736 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppenderEventForwarder.java ## @@ -0,0 +1,147 @@ +/* + *

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
carterkozak commented on a change in pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#discussion_r553355305 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppenderEventForwarder.java ## @@ -0,0 +1,147 @@ +/* + *

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
carterkozak commented on a change in pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#discussion_r553355305 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppenderEventForwarder.java ## @@ -0,0 +1,147 @@ +/* + *

[GitHub] [logging-log4j2] carterkozak commented on a change in pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
carterkozak commented on a change in pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#discussion_r553354888 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppenderEventForwarder.java ## @@ -0,0 +1,147 @@ +/* + *

[jira] [Commented] (LOG4J2-2994) Setting configuration file path no longer works with Windows OS

2021-01-07 Thread Chen Levy (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260529#comment-17260529 ] Chen Levy commented on LOG4J2-2994: --- In old versions, such as 2.1, setting the configuration file

[GitHub] [logging-log4j2] garydgregory commented on a change in pull request #452: LOG4J2-2972 Respawn AsyncAppender thread on failures.

2021-01-07 Thread GitBox
garydgregory commented on a change in pull request #452: URL: https://github.com/apache/logging-log4j2/pull/452#discussion_r553346306 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AsyncAppenderEventForwarder.java ## @@ -0,0 +1,147 @@ +/* + *

[jira] [Commented] (LOG4J2-2988) SocketAppender is not able to reload key and certs

2021-01-07 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260491#comment-17260491 ] Gary D. Gregory commented on LOG4J2-2988: - Log4j already supports the notion of a "watch

[GitHub] [logging-log4j2] vy commented on pull request #454: LOG4J2-2985 Add eventTemplateRootObjectKey parameter to JsonTemplateLayout.

2021-01-07 Thread GitBox
vy commented on pull request #454: URL: https://github.com/apache/logging-log4j2/pull/454#issuecomment-756053782 Okay, indeed we were on the same page. I share the same concerns. I will try to refactor these bits – given they are internal, the changes should not cause any compatibility

[jira] [Closed] (LOG4J2-2995) How to use eventTemplateAdditionalFields in log4j2.yaml

2021-01-07 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici closed LOG4J2-2995. - Fix Version/s: 2.14.1 3.0.0 Assignee: Volkan Yazici

[jira] [Commented] (LOG4J2-2995) How to use eventTemplateAdditionalFields in log4j2.yaml

2021-01-07 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260413#comment-17260413 ] Volkan Yazici commented on LOG4J2-2995: --- Thanks for the report [~michal.stefan@gmail.com]!

[jira] [Commented] (LOG4J2-2961) JsonTemplateLayout event additional fields are not read from config

2021-01-07 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260409#comment-17260409 ] Volkan Yazici commented on LOG4J2-2961: --- [~dheelus], I will discuss with the rest of the crew on

[jira] [Commented] (LOG4J2-2989) Has Log4j2 a risk of losing logs for streaming towards a remote server when it cannot re-establish a connection towards the server?

2021-01-07 Thread Yi (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260335#comment-17260335 ] Yi commented on LOG4J2-2989: Thank [~rgoers] and [~ggregory] for the replies. Regarding the

[jira] [Comment Edited] (LOG4J2-2988) SocketAppender is not able to reload key and certs

2021-01-07 Thread Yi (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260312#comment-17260312 ] Yi edited comment on LOG4J2-2988 at 1/7/21, 8:32 AM: - Thank you guys for the quick

[jira] [Commented] (LOG4J2-2988) SocketAppender is not able to reload key and certs

2021-01-07 Thread Yi (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260312#comment-17260312 ] Yi commented on LOG4J2-2988: Basically we are able to replace the same file with the renewed keys and