Re: [PR] When using C++20, optionally add in comma for varargs [logging-log4cxx]

2024-02-05 Thread via GitHub
rm5248 merged PR #345: URL: https://github.com/apache/logging-log4cxx/pull/345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] When using C++20, optionally add in comma for varargs [logging-log4cxx]

2024-02-05 Thread via GitHub
rm5248 commented on PR #345: URL: https://github.com/apache/logging-log4cxx/pull/345#issuecomment-1927159573 Unfortunately since this is a C++20 only fix, that build would fail with earlier versions. The optional GCC fix as well (`##__VA_ARGS__`) only works if GNU extensions are

Re: [PR] When using C++20, optionally add in comma for varargs [logging-log4cxx]

2024-02-04 Thread via GitHub
swebb2066 commented on PR #345: URL: https://github.com/apache/logging-log4cxx/pull/345#issuecomment-1926165572 You can now also undo the [changes in