[GitHub] jlahoda opened a new pull request #486: Fixing 'downgrading to 1.8' log messages by producing module bootpath…

2018-04-05 Thread GitBox
jlahoda opened a new pull request #486: Fixing 'downgrading to 1.8' log messages by producing module bootpath… URL: https://github.com/apache/incubator-netbeans/pull/486 … in Maven even when module-info is not present; and propagating the module bootpath as needed in Maven persistence.

[GitHub] Chris2011 commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

2018-04-05 Thread GitBox
Chris2011 commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#issuecomment-378834733 The SOE happens not inside dependencies, it happens here: ```XML net.smth.here my-abc-service

[GitHub] geertjanw commented on issue #482: Better consistency between SaveCookie presence and modified status

2018-04-05 Thread GitBox
geertjanw commented on issue #482: Better consistency between SaveCookie presence and modified status URL: https://github.com/apache/incubator-netbeans/pull/482#issuecomment-378871161 Looks great to me, any reason from anyone not to merge this?

[GitHub] matthiasblaesing commented on issue #466: Change category

2018-04-05 Thread GitBox
matthiasblaesing commented on issue #466: Change category URL: https://github.com/apache/incubator-netbeans/pull/466#issuecomment-378896391 What happens if we add: - SWT based Frontend Application - Swing based Frontend Application - $Toolkit based Frontend Application?

[GitHub] eppleton commented on issue #466: Change category

2018-04-05 Thread GitBox
eppleton commented on issue #466: Change category URL: https://github.com/apache/incubator-netbeans/pull/466#issuecomment-378899552 I’d be OK with “DukeScript Application”. --Toni Von: Geertjan Wielenga Gesendet: Donnerstag, 5.

[GitHub] JaroslavTulach commented on issue #466: Change category

2018-04-05 Thread GitBox
JaroslavTulach commented on issue #466: Change category URL: https://github.com/apache/incubator-netbeans/pull/466#issuecomment-378908050 Yes, I agree that **frontend** is generic. However, in contrary to @matthiasblaesing, I don't think it will cause any confusion. Talk to any **Java

[GitHub] rtaneja1 commented on a change in pull request #471: [NETBEANS-491] Fix issue reporting

2018-04-05 Thread GitBox
rtaneja1 commented on a change in pull request #471: [NETBEANS-491] Fix issue reporting URL: https://github.com/apache/incubator-netbeans/pull/471#discussion_r179392746 ## File path: uihandler/src/org/netbeans/modules/uihandler/UIHandler.java ## @@ -245,8 +249,12 @@

[GitHub] rtaneja1 commented on a change in pull request #471: [NETBEANS-491] Fix issue reporting

2018-04-05 Thread GitBox
rtaneja1 commented on a change in pull request #471: [NETBEANS-491] Fix issue reporting URL: https://github.com/apache/incubator-netbeans/pull/471#discussion_r179414357 ## File path: uihandler/src/org/netbeans/modules/uihandler/UIHandler.java ## @@ -245,8 +249,12 @@

[GitHub] JaroslavTulach commented on issue #466: Change category

2018-04-05 Thread GitBox
JaroslavTulach commented on issue #466: Change category URL: https://github.com/apache/incubator-netbeans/pull/466#issuecomment-378908050 Yes, I agree that **frontend** is generic. However, in contrary to @matthiasblaesing, I don't think it will cause any confusion. Talk to any **Java

[GitHub] JaroslavTulach commented on issue #466: Change category

2018-04-05 Thread GitBox
JaroslavTulach commented on issue #466: Change category URL: https://github.com/apache/incubator-netbeans/pull/466#issuecomment-378908050 Yes, I agree that **frontend** is generic. However, in contrary to @matthiasblaesing, I don't think it will cause any confusion. Talk to any **Java

[GitHub] JaroslavTulach commented on a change in pull request #471: [NETBEANS-491] Fix issue reporting

2018-04-05 Thread GitBox
JaroslavTulach commented on a change in pull request #471: [NETBEANS-491] Fix issue reporting URL: https://github.com/apache/incubator-netbeans/pull/471#discussion_r179374594 ## File path: uihandler/src/org/netbeans/modules/uihandler/UIHandler.java ## @@ -245,8 +249,12 @@

[GitHub] Chris2011 commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

2018-04-05 Thread GitBox
Chris2011 commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#issuecomment-378832009 I know that there is a better way of testing the PR, but I thought only the code inside the

[GitHub] Chris2011 commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

2018-04-05 Thread GitBox
Chris2011 commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#issuecomment-378831802 I only copied the code from the file HyperlinkProviderImpl, is this correct? When I open a project and open

[GitHub] Chris2011 commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

2018-04-05 Thread GitBox
Chris2011 commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#issuecomment-378831844 Did I miss to copy over code? This is an

[GitHub] Chris2011 commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

2018-04-05 Thread GitBox
Chris2011 commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#issuecomment-378831802 I only copied the code from the file HyperlinkProviderImpl, is this correct? When I open a project and open

[GitHub] svatoun commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

2018-04-05 Thread GitBox
svatoun commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#issuecomment-378834220 Apologies - I didn't clone your PR changes into a repository to view it in context, just reviewed a diff; I'll

[GitHub] dukescript commented on issue #466: Change category

2018-04-05 Thread GitBox
dukescript commented on issue #466: Change category URL: https://github.com/apache/incubator-netbeans/pull/466#issuecomment-378861400 I've changed the name to "Java Frontend Application". The PR was initiated because the category and also the title "Java HTML5 Application" was found to

[GitHub] mcdonnell-john commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

2018-04-05 Thread GitBox
mcdonnell-john commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#issuecomment-378833382 Can you send a snippet of the pom file? Specifically the dependency you tried to click. - I can verify

[GitHub] JaroslavTulach commented on a change in pull request #471: [NETBEANS-491] Fix issue reporting

2018-04-05 Thread GitBox
JaroslavTulach commented on a change in pull request #471: [NETBEANS-491] Fix issue reporting URL: https://github.com/apache/incubator-netbeans/pull/471#discussion_r179374594 ## File path: uihandler/src/org/netbeans/modules/uihandler/UIHandler.java ## @@ -245,8 +249,12 @@

[GitHub] eirikbakke commented on issue #437: [NETBEANS-404] Adjust Javadoc font size to editor's zoom level, and avoid all-monospace font

2018-04-05 Thread GitBox
eirikbakke commented on issue #437: [NETBEANS-404] Adjust Javadoc font size to editor's zoom level, and avoid all-monospace font URL: https://github.com/apache/incubator-netbeans/pull/437#issuecomment-378950688 > From the outside it might look as if you are setting an instance attribute,

[GitHub] eirikbakke commented on issue #437: [NETBEANS-404] Adjust Javadoc font size to editor's zoom level, and avoid all-monospace font

2018-04-05 Thread GitBox
eirikbakke commented on issue #437: [NETBEANS-404] Adjust Javadoc font size to editor's zoom level, and avoid all-monospace font URL: https://github.com/apache/incubator-netbeans/pull/437#issuecomment-378950688 > From the outside it might look as if you are setting an instance attribute,

[GitHub] vieiro commented on issue #466: Change category

2018-04-05 Thread GitBox
vieiro commented on issue #466: Change category URL: https://github.com/apache/incubator-netbeans/pull/466#issuecomment-378975246 I love the "html4j" term... This is an automated message from the Apache Git Service. To

[GitHub] matthiasblaesing commented on issue #466: Change category

2018-04-05 Thread GitBox
matthiasblaesing commented on issue #466: Change category URL: https://github.com/apache/incubator-netbeans/pull/466#issuecomment-379000368 @JaroslavTulach I appretiate your view, but a) just because everybody uses a term wrong, we don't need to follow that b) For my colleges

[GitHub] vieiro closed pull request #31: Experiment adding redirections in main .htaccess file

2018-04-05 Thread GitBox
vieiro closed pull request #31: Experiment adding redirections in main .htaccess file URL: https://github.com/apache/incubator-netbeans-website/pull/31 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of