[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #32: Release17.12

sonarcloud[bot] commented on pull request #32: URL: https://github.com/apache/ofbiz-plugins/pull/32#issuecomment-659065038 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #32: Release17.12

sonarcloud[bot] removed a comment on pull request #32: URL: https://github.com/apache/ofbiz-plugins/pull/32#issuecomment-656092289 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=BUG)

[jira] [Commented] (OFBIZ-11881) wrong image name in css. missing map file

[ https://issues.apache.org/jira/browse/OFBIZ-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158647#comment-17158647 ] Alex Bodnaru commented on OFBIZ-11881: -- cool, thank you jacques. prepare for my next few issues ;)

[jira] [Commented] (OFBIZ-11882) rename a few map files

[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158644#comment-17158644 ] Alex Bodnaru commented on OFBIZ-11882: -- thank you Jacques, I'll change the approach asap > rename

[jira] [Commented] (OFBIZ-11882) rename a few map files

[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158637#comment-17158637 ] Jacques Le Roux commented on OFBIZ-11882: - Yes > rename a few map files >

[jira] [Closed] (OFBIZ-11881) wrong image name in css. missing map file

[ https://issues.apache.org/jira/browse/OFBIZ-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11881. --- Fix Version/s: 17.12.05 Resolution: Fixed > wrong image name in css. missing map

[jira] [Closed] (OFBIZ-11890) User Error.ftl everywhere it's not yet used

[ https://issues.apache.org/jira/browse/OFBIZ-11890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11890. --- Fix Version/s: Upcoming Branch Assignee: Jacques Le Roux Resolution:

[jira] [Commented] (OFBIZ-10895) Unknown request [images]; this request does not exist or cannot be called directly.

[ https://issues.apache.org/jira/browse/OFBIZ-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158634#comment-17158634 ] ASF subversion and git services commented on OFBIZ-10895: - Commit

[jira] [Commented] (OFBIZ-11881) wrong image name in css. missing map file

[ https://issues.apache.org/jira/browse/OFBIZ-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158632#comment-17158632 ] Jacques Le Roux commented on OFBIZ-11881: - Actually the {{background-image:url("/d.png")}} thing

[jira] [Commented] (OFBIZ-11251) Use ‘checkstyle’ linting tool

[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158628#comment-17158628 ] Jacques Le Roux commented on OFBIZ-11251: - BTW, what about push in plugins repo? We need to

[jira] [Commented] (OFBIZ-11890) User Error.ftl everywhere it's not yet used

[ https://issues.apache.org/jira/browse/OFBIZ-11890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158621#comment-17158621 ] ASF subversion and git services commented on OFBIZ-11890: - Commit

[jira] [Commented] (OFBIZ-11890) User Error.ftl everywhere it's not yet used

[ https://issues.apache.org/jira/browse/OFBIZ-11890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158619#comment-17158619 ] ASF subversion and git services commented on OFBIZ-11890: - Commit

[jira] [Created] (OFBIZ-11890) User Error.ftl everywhere it's not yet used

Jacques Le Roux created OFBIZ-11890: --- Summary: User Error.ftl everywhere it's not yet used Key: OFBIZ-11890 URL: https://issues.apache.org/jira/browse/OFBIZ-11890 Project: OFBiz Issue

[jira] [Commented] (OFBIZ-11882) rename a few map files

[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158616#comment-17158616 ] Alex Bodnaru commented on OFBIZ-11882: -- pardon me, I didn't understand. will you accept such patch

[jira] [Commented] (OFBIZ-11882) rename a few map files

[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158613#comment-17158613 ] Jacques Le Roux commented on OFBIZ-11882: - OK for Gradle later > rename a few map files >

[jira] [Commented] (OFBIZ-11882) rename a few map files

[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158609#comment-17158609 ] Alex Bodnaru commented on OFBIZ-11882: -- there's a much shorter way to fix for the mean time.

[jira] [Commented] (OFBIZ-11882) rename a few map files

[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158604#comment-17158604 ] Alex Bodnaru commented on OFBIZ-11882: -- though i don't know how to do it with Gradle, the

[jira] [Commented] (OFBIZ-11251) Use ‘checkstyle’ linting tool

[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158581#comment-17158581 ] Jacques Le Roux commented on OFBIZ-11251: - bq. maybe we should add a dummy empty Gradle task

[jira] [Commented] (OFBIZ-11882) rename a few map files

[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158573#comment-17158573 ] Jacques Le Roux commented on OFBIZ-11882: - I understand. My point is to automate this with

[jira] [Commented] (OFBIZ-11882) rename a few map files

[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158486#comment-17158486 ] Alex Bodnaru commented on OFBIZ-11882: -- the map files are provided with the minified css and js.

[jira] [Commented] (OFBIZ-11251) Use ‘checkstyle’ linting tool

[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158246#comment-17158246 ] Aditya Sharma commented on OFBIZ-11251: --- That makes sense. I am only concerned about the pre-push

[jira] [Comment Edited] (OFBIZ-11881) wrong image name in css. missing map file

[ https://issues.apache.org/jira/browse/OFBIZ-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158238#comment-17158238 ] Alex Bodnaru edited comment on OFBIZ-11881 at 7/15/20, 2:54 PM: ok, i'm

[jira] [Commented] (OFBIZ-11881) wrong image name in css. missing map file

[ https://issues.apache.org/jira/browse/OFBIZ-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158238#comment-17158238 ] Alex Bodnaru commented on OFBIZ-11881: -- ok, i'm not against the best practices. i began to explore

[jira] [Commented] (OFBIZ-11881) wrong image name in css. missing map file

[ https://issues.apache.org/jira/browse/OFBIZ-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158231#comment-17158231 ] Jacques Le Roux commented on OFBIZ-11881: - So you did not read (or get, hard to swallow I agree)

[jira] [Commented] (OFBIZ-11881) wrong image name in css. missing map file

[ https://issues.apache.org/jira/browse/OFBIZ-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158222#comment-17158222 ] Jacques Le Roux commented on OFBIZ-11881: - OK, I just answrered to my questions at

[jira] [Commented] (OFBIZ-11882) rename a few map files

[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158220#comment-17158220 ] Jacques Le Roux commented on OFBIZ-11882: - OK, after hastily reading the 1st section of

[jira] [Commented] (OFBIZ-11889) fixes for csp-report subsystem

[ https://issues.apache.org/jira/browse/OFBIZ-11889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158142#comment-17158142 ] Jacques Le Roux commented on OFBIZ-11889: - bq. i'd think it better to be in a configuration

[jira] [Updated] (OFBIZ-11882) rename a few map files

[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Bodnaru updated OFBIZ-11882: - the mainstream policy is to serve 1 combined css file and one combined js file, preferably from a

[jira] [Closed] (OFBIZ-11817) a handful of bug fixes

[ https://issues.apache.org/jira/browse/OFBIZ-11817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11817. --- Resolution: Won't Do > a handful of bug fixes > -- > >

[jira] [Comment Edited] (OFBIZ-11882) rename a few map files

[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158071#comment-17158071 ] Jacques Le Roux edited comment on OFBIZ-11882 at 7/15/20, 10:51 AM:

[jira] [Commented] (OFBIZ-11882) rename a few map files

[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158071#comment-17158071 ] Jacques Le Roux commented on OFBIZ-11882: - There will be 2 methods, the later should replace the

[jira] [Commented] (OFBIZ-11889) fixes for csp-report subsystem

[ https://issues.apache.org/jira/browse/OFBIZ-11889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158064#comment-17158064 ] Alex Bodnaru commented on OFBIZ-11889: -- cool, thanks Jacques > fixes for csp-report subsystem >

[jira] [Commented] (OFBIZ-11817) a handful of bug fixes

[ https://issues.apache.org/jira/browse/OFBIZ-11817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158063#comment-17158063 ] Alex Bodnaru commented on OFBIZ-11817: -- you may close it, since the issues  are getting resolved >

[jira] [Commented] (OFBIZ-11883) added missing map for minified ol js and css

[ https://issues.apache.org/jira/browse/OFBIZ-11883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158055#comment-17158055 ] Alex Bodnaru commented on OFBIZ-11883: -- yes indeed, all my present issues are front end related.

[jira] [Commented] (OFBIZ-11881) wrong image name in css. missing map file

[ https://issues.apache.org/jira/browse/OFBIZ-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158046#comment-17158046 ] Jacques Le Roux commented on OFBIZ-11881: - We crossed on wire, still my questions... > wrong

[jira] [Commented] (OFBIZ-11881) wrong image name in css. missing map file

[ https://issues.apache.org/jira/browse/OFBIZ-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158045#comment-17158045 ] Jacques Le Roux commented on OFBIZ-11881: - Ho wait, I missed that it's from

[jira] [Commented] (OFBIZ-11881) wrong image name in css. missing map file

[ https://issues.apache.org/jira/browse/OFBIZ-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158044#comment-17158044 ] Alex Bodnaru commented on OFBIZ-11881: -- it's about a jQuery plugin. not an ofbiz one > wrong

[jira] [Comment Edited] (OFBIZ-11881) wrong image name in css. missing map file

[ https://issues.apache.org/jira/browse/OFBIZ-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158017#comment-17158017 ] Jacques Le Roux edited comment on OFBIZ-11881 at 7/15/20, 10:11 AM:

[jira] [Issue Comment Deleted] (OFBIZ-11883) added missing map for minified ol js and css

[ https://issues.apache.org/jira/browse/OFBIZ-11883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11883: Comment: was deleted (was: Ho wait, I missed that it's from

[jira] [Commented] (OFBIZ-11883) added missing map for minified ol js and css

[ https://issues.apache.org/jira/browse/OFBIZ-11883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158041#comment-17158041 ] Jacques Le Roux commented on OFBIZ-11883: - Ho wait, I missed that it's from

[jira] [Commented] (OFBIZ-11251) Use ‘checkstyle’ linting tool

[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158037#comment-17158037 ] Jacques Le Roux commented on OFBIZ-11251: - Thanks, Maybe it's not worth it then, R17 will be

[jira] [Commented] (OFBIZ-11251) Use ‘checkstyle’ linting tool

[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158029#comment-17158029 ] Aditya Sharma commented on OFBIZ-11251: --- I am checking if I can create custom task that can check

[jira] [Comment Edited] (OFBIZ-11251) Use ‘checkstyle’ linting tool

[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158025#comment-17158025 ] Aditya Sharma edited comment on OFBIZ-11251 at 7/15/20, 9:44 AM: - Hi

[jira] [Commented] (OFBIZ-11251) Use ‘checkstyle’ linting tool

[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158025#comment-17158025 ] Aditya Sharma commented on OFBIZ-11251: --- Hi Jacques, I tried backporting but got blocked as R17,

[jira] [Commented] (OFBIZ-11251) Use ‘checkstyle’ linting tool

[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158023#comment-17158023 ] Jacques Le Roux commented on OFBIZ-11251: - Hi Aditya, Any reasons to not "backport" to R17? >

[jira] [Updated] (OFBIZ-11883) added missing map for minified ol js and css

[ https://issues.apache.org/jira/browse/OFBIZ-11883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11883: Issue Type: Improvement (was: Bug) > added missing map for minified ol js and css >

[jira] [Comment Edited] (OFBIZ-11881) wrong image name in css. missing map file

[ https://issues.apache.org/jira/browse/OFBIZ-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158017#comment-17158017 ] Jacques Le Roux edited comment on OFBIZ-11881 at 7/15/20, 9:33 AM: ---

[jira] [Updated] (OFBIZ-11882) rename a few map files

[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11882: Issue Type: Improvement (was: Bug) > rename a few map files > -- > >

[jira] [Commented] (OFBIZ-11883) added missing map for minified ol js and css

[ https://issues.apache.org/jira/browse/OFBIZ-11883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158020#comment-17158020 ] Jacques Le Roux commented on OFBIZ-11883: - Alex, Seems your are versed in front end

[jira] [Commented] (OFBIZ-11881) wrong image name in css. missing map file

[ https://issues.apache.org/jira/browse/OFBIZ-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158017#comment-17158017 ] Jacques Le Roux commented on OFBIZ-11881: - Alex, Though [we have some for historical

[jira] [Comment Edited] (OFBIZ-11882) rename a few map files

[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158010#comment-17158010 ] Jacques Le Roux edited comment on OFBIZ-11882 at 7/15/20, 9:26 AM: --- Hi

[jira] [Commented] (OFBIZ-11882) rename a few map files

[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158014#comment-17158014 ] Alex Bodnaru commented on OFBIZ-11882: -- how are the js/css files getting into ofbiz repository?

[jira] [Commented] (OFBIZ-11882) rename a few map files

[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158013#comment-17158013 ] Alex Bodnaru commented on OFBIZ-11882: -- exactly these things were to be learned from a mentor. >

[jira] [Commented] (OFBIZ-11889) fixes for csp-report subsystem

[ https://issues.apache.org/jira/browse/OFBIZ-11889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158012#comment-17158012 ] Jacques Le Roux commented on OFBIZ-11889: - OK, I'll have a look at what we can do here. I really

[jira] [Commented] (OFBIZ-11882) rename a few map files

[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158010#comment-17158010 ] Jacques Le Roux commented on OFBIZ-11882: - Hi Alex, We were using yuicompressor. It was

[jira] [Commented] (OFBIZ-11882) rename a few map files

[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158003#comment-17158003 ] Alex Bodnaru commented on OFBIZ-11882: -- the minifying process may need to be tuned up. > rename a

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #214: Implemented: New service definition attribute "verb" to denote the corresponding HTTP method (OFBIZ-11328)

sonarcloud[bot] removed a comment on pull request #214: URL: https://github.com/apache/ofbiz-framework/pull/214#issuecomment-657920054 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=214=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #214: Implemented: New service definition attribute "verb" to denote the corresponding HTTP method (OFBIZ-11328)

sonarcloud[bot] commented on pull request #214: URL: https://github.com/apache/ofbiz-framework/pull/214#issuecomment-658620356 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=214=false=BUG)

[jira] [Commented] (OFBIZ-11889) fixes for csp-report subsystem

[ https://issues.apache.org/jira/browse/OFBIZ-11889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157926#comment-17157926 ] Alex Bodnaru commented on OFBIZ-11889: -- hi [~jleroux] , i agree to all your comments. though the

[jira] [Commented] (OFBIZ-11882) rename a few map files

[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157916#comment-17157916 ] Alex Bodnaru commented on OFBIZ-11882: -- hello [~jleroux] , the name of the map file is inside the