[GitHub] [ofbiz-framework] ieugen commented on pull request #354: Improved: Upgrade to gradle 7.3 to support jdk 17 (OFBIZ-12400)

2021-12-16 Thread GitBox
ieugen commented on pull request #354: URL: https://github.com/apache/ofbiz-framework/pull/354#issuecomment-996510369 @JacquesLeRoux : Ubuntu 13.10 is ancient and also not supported. If you like to use Linux and Ubuntu please use a LTS version - See https://wiki.ubuntu.com/Releases .

[GitHub] [ofbiz-framework] ieugen edited a comment on pull request #354: Improved: Upgrade to gradle 7.3 to support jdk 17 (OFBIZ-12400)

2021-12-16 Thread GitBox
ieugen edited a comment on pull request #354: URL: https://github.com/apache/ofbiz-framework/pull/354#issuecomment-996506580 PDF's migh work if we install the proper dependencies perhaps. I don't have time for that right now. Windows build failed with error on these same files.

[GitHub] [ofbiz-framework] ieugen commented on pull request #354: Improved: Upgrade to gradle 7.3 to support jdk 17 (OFBIZ-12400)

2021-12-16 Thread GitBox
ieugen commented on pull request #354: URL: https://github.com/apache/ofbiz-framework/pull/354#issuecomment-996506580 PDF's migh work if we install the proper dependencies perhaps. I don't have time for that right now. ``` dec. 17, 2021 9:44:08 A.M.

[GitHub] [ofbiz-framework] ieugen commented on pull request #354: Improved: Upgrade to gradle 7.3 to support jdk 17 (OFBIZ-12400)

2021-12-16 Thread GitBox
ieugen commented on pull request #354: URL: https://github.com/apache/ofbiz-framework/pull/354#issuecomment-996505973 I had to upgrade asciidoctorj to 3.x branch and disabled pdf generation on Windows. I think we can live with that for a time being. AsciidoctorJ with pdf / Jruby has

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #354: Improved: Upgrade to gradle 7.3 to support jdk 17 (OFBIZ-12400)

2021-12-16 Thread GitBox
sonarcloud[bot] removed a comment on pull request #354: URL: https://github.com/apache/ofbiz-framework/pull/354#issuecomment-992208010 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #354: Improved: Upgrade to gradle 7.3 to support jdk 17 (OFBIZ-12400)

2021-12-16 Thread GitBox
sonarcloud[bot] commented on pull request #354: URL: https://github.com/apache/ofbiz-framework/pull/354#issuecomment-996501270 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[jira] [Commented] (OFBIZ-12464) Update Solr and Lucene to address several CVEs (including Log4j)

2021-12-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461186#comment-17461186 ] ASF subversion and git services commented on OFBIZ-12464: - Commit

[jira] [Commented] (OFBIZ-12464) Update Solr and Lucene to address several CVEs (including Log4j)

2021-12-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461185#comment-17461185 ] ASF subversion and git services commented on OFBIZ-12464: - Commit

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #354: Improved: Upgrade to gradle 7.3 to support jdk 17 (OFBIZ-12400)

2021-12-16 Thread GitBox
JacquesLeRoux commented on pull request #354: URL: https://github.com/apache/ofbiz-framework/pull/354#issuecomment-996426376 Hi @ieugen, Could you please try one of the AsciiDoc tasks, like generateReadmeFiles -- This is an automated message from the Apache Git Service. To respond

[GitHub] [ofbiz-framework] ieugen commented on pull request #354: Improved: Upgrade to gradle 7.3 to support jdk 17 (OFBIZ-12400)

2021-12-16 Thread GitBox
ieugen commented on pull request #354: URL: https://github.com/apache/ofbiz-framework/pull/354#issuecomment-996284110 The build work on my machine: ``` Build time: 2021-12-01 15:42:20 UTC Revision:

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #419: Fixed: PriceScreens.xml - incorrect reference in screen (OFBIZ-12465)

2021-12-16 Thread GitBox
sonarcloud[bot] commented on pull request #419: URL: https://github.com/apache/ofbiz-framework/pull/419#issuecomment-996207045 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #419: Fixed: PriceScreens.xml - incorrect reference in screen (OFBIZ-12465)

2021-12-16 Thread GitBox
PierreSmits opened a new pull request #419: URL: https://github.com/apache/ofbiz-framework/pull/419 With commit 92533b5 the reference in screen FindProductPriceRule was not changed when the relating object in PriceForms.xml changed from form to grid. Modified: PriceScreens.xml

[jira] [Created] (OFBIZ-12465) PriceScreens.xml - incorrect reference in screen

2021-12-16 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12465: Summary: PriceScreens.xml - incorrect reference in screen Key: OFBIZ-12465 URL: https://issues.apache.org/jira/browse/OFBIZ-12465 Project: OFBiz Issue Type:

[jira] [Closed] (OFBIZ-12464) Update Solr and Lucene to address several CVEs (including Log4j)

2021-12-16 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12464. --- Fix Version/s: 18.12.04 Resolution: Fixed > Update Solr and Lucene to address

[jira] [Updated] (OFBIZ-12464) Update Solr and Lucene to address several CVEs (including Log4j)

2021-12-16 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-12464: Parent: OFBIZ-1525 Issue Type: Sub-task (was: Bug) > Update Solr and Lucene to

[jira] [Commented] (OFBIZ-12464) Update Solr and Lucene to address several CVEs (including Log4j)

2021-12-16 Thread Michael Brohl (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17460881#comment-17460881 ] Michael Brohl commented on OFBIZ-12464: --- Thanks a lot, Jacques! > Update Solr and Lucene to

[jira] [Assigned] (OFBIZ-12464) Update Solr and Lucene to address several CVEs (including Log4j)

2021-12-16 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-12464: --- Assignee: Jacques Le Roux > Update Solr and Lucene to address several CVEs

[jira] [Commented] (OFBIZ-12464) Update Solr and Lucene to address several CVEs (including Log4j)

2021-12-16 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17460877#comment-17460877 ] Jacques Le Roux commented on OFBIZ-12464: - Hi Michal, yes was doing it, needed two merges... >

[jira] [Commented] (OFBIZ-12464) Update Solr and Lucene to address several CVEs (including Log4j)

2021-12-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17460873#comment-17460873 ] ASF subversion and git services commented on OFBIZ-12464: - Commit

[jira] [Commented] (OFBIZ-12388) Upgrade Solr and Lucene to 8.11

2021-12-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17460872#comment-17460872 ] ASF subversion and git services commented on OFBIZ-12388: - Commit

[jira] [Updated] (OFBIZ-12464) Update Solr and Lucene to address several CVEs (including Log4j)

2021-12-16 Thread Michael Brohl (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-12464: -- Labels: backport-needed (was: ) > Update Solr and Lucene to address several CVEs (including

[jira] [Commented] (OFBIZ-12464) Update Solr and Lucene to address several CVEs (including Log4j)

2021-12-16 Thread Michael Brohl (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17460860#comment-17460860 ] Michael Brohl commented on OFBIZ-12464: --- Thanks Jacques for those quick fixes! Do you intend to

[jira] [Commented] (OFBIZ-12386) Fix some bugs Spotbugs reports

2021-12-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17460838#comment-17460838 ] ASF subversion and git services commented on OFBIZ-12386: - Commit

[jira] [Commented] (OFBIZ-12464) Update Solr and Lucene to address several CVEs (including Log4j)

2021-12-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17460839#comment-17460839 ] ASF subversion and git services commented on OFBIZ-12464: - Commit

[jira] [Created] (OFBIZ-12464) Update Solr and Lucene to address several CVEs (including Log4j)

2021-12-16 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-12464: --- Summary: Update Solr and Lucene to address several CVEs (including Log4j) Key: OFBIZ-12464 URL: https://issues.apache.org/jira/browse/OFBIZ-12464 Project:

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #354: Improved: Upgrade to gradle 7.3 to support jdk 17 (OFBIZ-12400)

2021-12-16 Thread GitBox
JacquesLeRoux commented on pull request #354: URL: https://github.com/apache/ofbiz-framework/pull/354#issuecomment-995941678 Hi Pierre, There is no use of any Asciidoc task in framework only build. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #354: Improved: Upgrade to gradle 7.3 to support jdk 17 (OFBIZ-12400)

2021-12-16 Thread GitBox
PierreSmits commented on pull request #354: URL: https://github.com/apache/ofbiz-framework/pull/354#issuecomment-995914066 Hi Jacques, It seems to me that this has more to do with the asciidoctor stuff, than gradle itself. Won't you agree? And then more particular with the aspect that

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #354: Improved: Upgrade to gradle 7.3 to support jdk 17 (OFBIZ-12400)

2021-12-16 Thread GitBox
JacquesLeRoux commented on pull request #354: URL: https://github.com/apache/ofbiz-framework/pull/354#issuecomment-995903570 Hi @ieugen , I wrote above that > it works on latest Ubuntu for the trunk with Gradle 7.1.1 That's true for the framework only build. But for the

[jira] [Closed] (OFBIZ-1151) Passwords are not salted

2021-12-16 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits closed OFBIZ-1151. --- Assignee: (was: Adam Heath) Resolution: Not A Problem Closing as it is either already

[jira] [Commented] (OFBIZ-12386) Fix some bugs Spotbugs reports

2021-12-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17460653#comment-17460653 ] ASF subversion and git services commented on OFBIZ-12386: - Commit

[jira] [Commented] (OFBIZ-10333) Improve Party

2021-12-16 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17460560#comment-17460560 ] Pierre Smits commented on OFBIZ-10333: -- IMO, action triggers should - as much as possible - be

[jira] [Commented] (OFBIZ-10470) Inconsistent screenlet-title containers

2021-12-16 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17460556#comment-17460556 ] Pierre Smits commented on OFBIZ-10470: -- IMO, ftl templates should only be used for screen elements

[jira] [Updated] (OFBIZ-12450) Price Rules: Price rules configurations are not syncing with eCommerce storefront

2021-12-16 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-12450: - Labels: user-experience (was: ) > Price Rules: Price rules configurations are not syncing with

[jira] [Updated] (OFBIZ-12450) Price Rules: Price rules configurations are not syncing with eCommerce storefront

2021-12-16 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-12450: - Component/s: product/catalog (was: product) > Price Rules: Price rules

[jira] [Created] (OFBIZ-12463) Payment Group Common Decorator

2021-12-16 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12463: Summary: Payment Group Common Decorator Key: OFBIZ-12463 URL: https://issues.apache.org/jira/browse/OFBIZ-12463 Project: OFBiz Issue Type: Improvement

[jira] [Updated] (OFBIZ-12458) Invoice - CommonInvoiceDecorator

2021-12-16 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-12458: - Environment: (was: label for invoice is shown below Invoice menus) > Invoice -

[jira] [Commented] (OFBIZ-12456) Migrate Ofbiz bb 0.8 config to 3.2

2021-12-16 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17460511#comment-17460511 ] Jacques Le Roux commented on OFBIZ-12456: - For more information see

[jira] [Updated] (OFBIZ-12456) Migrate Ofbiz bb 0.8 config to 3.2

2021-12-16 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-12456: Description: This is a clone of INFRA-22279 that says: bq. Migrate all Ofbiz configs from

[jira] (OFBIZ-12456) Migrate Ofbiz bb 0.8 config to 3.2

2021-12-16 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12456 ] Jacques Le Roux deleted comment on OFBIZ-12456: - was (Author: jacques.le.roux): For more information see https://markmail.org/message/z6qfhcb2xnlqs2ji > Migrate Ofbiz bb 0.8 config to

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #418: Improved: Agreement - CommonAgreementDecorator (OFBIZ-12462)

2021-12-16 Thread GitBox
sonarcloud[bot] commented on pull request #418: URL: https://github.com/apache/ofbiz-framework/pull/418#issuecomment-995567640 Kudos, SonarCloud Quality Gate passed! ![Quality Gate

[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #418: Improved: Agreement - CommonAgreementDecorator (OFBIZ-12462)

2021-12-16 Thread GitBox
PierreSmits opened a new pull request #418: URL: https://github.com/apache/ofbiz-framework/pull/418 title of an agreement is shown below its menu(s). Modified: AgreementScreens.xml moved label involving agreement title to pre-body decorator-section -- This is an automated

[jira] [Created] (OFBIZ-12462) Agreement - CommonAgreementDecorator

2021-12-16 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12462: Summary: Agreement - CommonAgreementDecorator Key: OFBIZ-12462 URL: https://issues.apache.org/jira/browse/OFBIZ-12462 Project: OFBiz Issue Type: Improvement