adityasharma7 commented on pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-148402
> @bjugl ,
>
> I'm no longer able to review the js CodeQL analysis (because of npm use).
There were no real issues. I saw for instance that they used things
[
https://issues.apache.org/jira/browse/OFBIZ-12471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-12471:
Attachment: OFBIZ-12471.patch
> Gradle Wrapper is not downloaded with 18.12.03
>
[
https://issues.apache.org/jira/browse/OFBIZ-12471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463958#comment-17463958
]
Jacques Le Roux commented on OFBIZ-12471:
-
Hi David,
Please try this patch:
[
https://issues.apache.org/jira/browse/OFBIZ-12471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463603#comment-17463603
]
Jacques Le Roux edited comment on OFBIZ-12471 at 12/22/21, 4:33 PM:
[
https://issues.apache.org/jira/browse/OFBIZ-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-12473.
---
Fix Version/s: 18.12.05
Resolution: Fixed
> CheckStyleMain Task is Failing in
[
https://issues.apache.org/jira/browse/OFBIZ-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463944#comment-17463944
]
ASF subversion and git services commented on OFBIZ-12473:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-12473:
Summary: CheckStyleMain Task is Failing in 18.12.04 (was: CLONE -
CheckStyleMain Task is
[
https://issues.apache.org/jira/browse/OFBIZ-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits closed OFBIZ-12450.
Fix Version/s: Upcoming Branch
Resolution: Fixed
Thanks to Jacques for his assistance to
[
https://issues.apache.org/jira/browse/OFBIZ-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463885#comment-17463885
]
ASF subversion and git services commented on OFBIZ-12450:
-
Commit
JacquesLeRoux merged pull request #424:
URL: https://github.com/apache/ofbiz-framework/pull/424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/OFBIZ-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463765#comment-17463765
]
ASF subversion and git services commented on OFBIZ-12456:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463743#comment-17463743
]
ASF subversion and git services commented on OFBIZ-12456:
-
Commit
adityasharma7 commented on a change in pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#discussion_r773793559
##
File path: applications/content/widget/CommonScreens.xml
##
@@ -33,6 +33,7 @@ under the License.
adityasharma7 commented on a change in pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#discussion_r773791624
##
File path: themes/common-theme/webapp/common/css/trumbowygCustom.css
##
@@ -0,0 +1,642 @@
+/**
Review comment:
I think we should
[
https://issues.apache.org/jira/browse/OFBIZ-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463682#comment-17463682
]
ASF subversion and git services commented on OFBIZ-12456:
-
Commit
JacquesLeRoux edited a comment on pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-999423161
>We do also sanitize serversided again, right?
Yes inputs are sanitised
--
This is an automated message from the Apache Git Service.
To respond to
JacquesLeRoux edited a comment on pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-999423161
>We do also sanitize serversided again, right?
Java but not js, why?
--
This is an automated message from the Apache Git Service.
To respond to the
JacquesLeRoux commented on pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-999423161
>We do also sanitize serversided again, right?
Java but not js, why?
--
This is an automated message from the Apache Git Service.
To respond to the message,
bjugl edited a comment on pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-999354788
> I'm no longer able to review the js CodeQL analysis (because of npm use).
There were no real issues. I saw for instance that they used things like `\.`
in regexp
JacquesLeRoux edited a comment on pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-998971560
@bjugl ,
I'm no longer able to review the js CodeQL analysis (because of npm use).
There were no real issues. I saw for instance that they used things
bjugl edited a comment on pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-999354788
> I'm no longer able to review the js CodeQL analysis (because of npm use).
There were no real issues. I saw for instance that they used things like `\.`
in regexp
[
https://issues.apache.org/jira/browse/OFBIZ-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463675#comment-17463675
]
ASF subversion and git services commented on OFBIZ-12456:
-
Commit
bjugl commented on a change in pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#discussion_r773682160
##
File path: applications/content/widget/CommonScreens.xml
##
@@ -33,6 +33,7 @@ under the License.
23 matches
Mail list logo