[
https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929742#comment-16929742
]
Aditya Sharma commented on OFBIZ-10725:
---
Thanks Jacques :)
+1 for closing it.
> Refactor boolean
[
https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929732#comment-16929732
]
Jacques Le Roux commented on OFBIZ-10725:
-
If nobody is against I'd like to close this issue in
[
https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929729#comment-16929729
]
Jacques Le Roux commented on OFBIZ-10725:
-
I added a last one in revision: 1866931, was fun but
[
https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929728#comment-16929728
]
Jacques Le Roux commented on OFBIZ-10725:
-
I made some change in r1866929 and then fixed 2 of
[
https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829594#comment-16829594
]
Jacques Le Roux commented on OFBIZ-10725:
-
Thanks Guys,
I intend to do some also...
> Refactor
[
https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829046#comment-16829046
]
Jacques Le Roux commented on OFBIZ-10725:
-
Hi Aditya,
Even if this is not functional and minor,
[
https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745790#comment-16745790
]
Aditya Sharma commented on OFBIZ-10725:
---
Verified and done for all the instances in classes under
[
https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743821#comment-16743821
]
Aditya Sharma commented on OFBIZ-10725:
---
Done for GiftCertificateServices, UtilAccounting and
[
https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732768#comment-16732768
]
Aditya Sharma commented on OFBIZ-10725:
---
Done for all classes directly under
[
https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730268#comment-16730268
]
Aditya Sharma commented on OFBIZ-10725:
---
Done for all classes under
[
https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728930#comment-16728930
]
Aditya Sharma commented on OFBIZ-10725:
---
Improves code in methods:
isPrimaryKey() of GenericEntity
11 matches
Mail list logo