[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods

2019-09-14 Thread Aditya Sharma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929742#comment-16929742 ] Aditya Sharma commented on OFBIZ-10725: --- Thanks Jacques :) +1 for closing it. > Refactor boolean

[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods

2019-09-14 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929732#comment-16929732 ] Jacques Le Roux commented on OFBIZ-10725: - If nobody is against I'd like to close this issue in

[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods

2019-09-14 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929729#comment-16929729 ] Jacques Le Roux commented on OFBIZ-10725: - I added a last one in revision: 1866931, was fun but

[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods

2019-09-14 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929728#comment-16929728 ] Jacques Le Roux commented on OFBIZ-10725: - I made some change in r1866929 and then fixed 2 of

[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods

2019-04-29 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829594#comment-16829594 ] Jacques Le Roux commented on OFBIZ-10725: - Thanks Guys, I intend to do some also... > Refactor

[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods

2019-04-29 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829046#comment-16829046 ] Jacques Le Roux commented on OFBIZ-10725: - Hi Aditya, Even if this is not functional and minor,

[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods

2019-01-17 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745790#comment-16745790 ] Aditya Sharma commented on OFBIZ-10725: --- Verified and done for all the instances in classes under

[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods

2019-01-16 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743821#comment-16743821 ] Aditya Sharma commented on OFBIZ-10725: --- Done for GiftCertificateServices, UtilAccounting and 

[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods

2019-01-03 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732768#comment-16732768 ] Aditya Sharma commented on OFBIZ-10725: --- Done for all classes directly under

[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods

2018-12-28 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730268#comment-16730268 ] Aditya Sharma commented on OFBIZ-10725: --- Done for all classes under

[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods

2018-12-26 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728930#comment-16728930 ] Aditya Sharma commented on OFBIZ-10725: --- Improves code in methods: isPrimaryKey() of GenericEntity