[
https://issues.apache.org/jira/browse/OFBIZ-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725350#comment-15725350
]
Taher Alkhateeb commented on OFBIZ-8337:
Committed latest patch with minor rework in r1772879
>
[
https://issues.apache.org/jira/browse/OFBIZ-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721692#comment-15721692
]
Jacopo Cappellato commented on OFBIZ-8337:
--
I have applied and tested your latest patch and I
[
https://issues.apache.org/jira/browse/OFBIZ-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712847#comment-15712847
]
Taher Alkhateeb commented on OFBIZ-8337:
Work committed in r1772256. Next I'll focus my attention
[
https://issues.apache.org/jira/browse/OFBIZ-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711580#comment-15711580
]
Jacopo Cappellato commented on OFBIZ-8337:
--
Thanks for the insight Taher!
I will have to look
[
https://issues.apache.org/jira/browse/OFBIZ-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711297#comment-15711297
]
Taher Alkhateeb commented on OFBIZ-8337:
Ahhh okay :) coding style, I always forget that space.
[
https://issues.apache.org/jira/browse/OFBIZ-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711291#comment-15711291
]
Nicolas Malin commented on OFBIZ-8337:
--
[wishpering] missing a space between if and ( [wishpering]
[
https://issues.apache.org/jira/browse/OFBIZ-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711260#comment-15711260
]
Taher Alkhateeb commented on OFBIZ-8337:
Hi Nicolas
I hope I'm not going blind :) but Line 432
[
https://issues.apache.org/jira/browse/OFBIZ-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711242#comment-15711242
]
Nicolas Malin commented on OFBIZ-8337:
--
Hi Taher,
It's also good refactoring for me.
I just found a
[
https://issues.apache.org/jira/browse/OFBIZ-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711149#comment-15711149
]
Taher Alkhateeb commented on OFBIZ-8337:
Hi Jacopo,
Sure, I will do some further cleanup and
[
https://issues.apache.org/jira/browse/OFBIZ-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708700#comment-15708700
]
Jacopo Cappellato commented on OFBIZ-8337:
--
[~taher] thanks for your work.
I have reviewed your
[
https://issues.apache.org/jira/browse/OFBIZ-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15701503#comment-15701503
]
Taher Alkhateeb commented on OFBIZ-8337:
Note to self on container startup and defined loaders
||
[
https://issues.apache.org/jira/browse/OFBIZ-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632393#comment-15632393
]
Taher Alkhateeb commented on OFBIZ-8337:
As discussed in
[
https://issues.apache.org/jira/browse/OFBIZ-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15579640#comment-15579640
]
Taher Alkhateeb commented on OFBIZ-8337:
Thank you Jacques, my first patch (modified with some
[
https://issues.apache.org/jira/browse/OFBIZ-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15557680#comment-15557680
]
Jacques Le Roux commented on OFBIZ-8337:
Hi Taher,
Thanks for the details. I reviewed, I like it,
[
https://issues.apache.org/jira/browse/OFBIZ-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549641#comment-15549641
]
Jacques Le Roux commented on OFBIZ-8337:
Was http://svn.apache.org/viewvc?rev=1076529=rev on
[
https://issues.apache.org/jira/browse/OFBIZ-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529091#comment-15529091
]
Taher Alkhateeb commented on OFBIZ-8337:
Thank you, very kind of you Ashish :) I will submit a
[
https://issues.apache.org/jira/browse/OFBIZ-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529082#comment-15529082
]
Ashish Vijaywargiya commented on OFBIZ-8337:
Very good task. Thanks Taher for working on this!
17 matches
Mail list logo