[jira] [Commented] (OFBIZ-10967) Remove link is not working in shopping list

2019-04-28 Thread Ashish Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828893#comment-16828893
 ] 

Ashish Sharma commented on OFBIZ-10967:
---

Hi Jacques,

+1

Thanks for suggestion.

 

> Remove link is not working in shopping list
> ---
>
> Key: OFBIZ-10967
> URL: https://issues.apache.org/jira/browse/OFBIZ-10967
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12, Release Branch 16.11, Release Branch 17.12, Release 
> Branch 18.12
>Reporter: Ashish Sharma
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments: OFBIZ-10967.docx
>
>
> *Step to reproduce*
> 1. Login with valid username and password.
> 2. Navigate to ecommerce.
> 3. Move the product to shopping list.
> 4. Navigate to shopping list section.
> 5. Click on link “Remove"
> *Expected Result:* Product should be removed from shopping list.
> *Actual Result:* Remove link is not working.
> *Screen print attached*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9905) Use "Create" instead of "Create New" on the various screens of all components

2019-04-28 Thread sourabh jain (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828897#comment-16828897
 ] 

sourabh jain commented on OFBIZ-9905:
-

Thank you, Jacques.

> Use "Create" instead of "Create New" on the various screens of all components
> -
>
> Key: OFBIZ-9905
> URL: https://issues.apache.org/jira/browse/OFBIZ-9905
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
> Environment: 
> https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreement
>Reporter: Aayush jain
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9905.patch, OFBIZ-9905.patch, OFBIZ-9905.patch, 
> UI_label .png
>
>
> Following issues found:
> 1. Create Agreement opens an edit agreement window
> 2. Able to Create Agreement without any detail (empty Agreement) 
> Steps:
> 1. Open URL 
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindAgreement
> 2. Navigate to Agreement section
> 3. Click on create Agreement
> 4. Click submit button
> Actual: Agreement id is generated for empty agreement and when create window 
> opens, it's redirection is wrong to edit window
> Expected: Proper redirection should be there (create agreement) and if an 
> agreement is created without any details its of no use.
> Note: Same Issue exist with following screens:
> 1. Billing Account 
> 2. Tax Authority 
> 3. Agreement 
> 4. Fixed Asset 
> 5. Vendor 
> 6. WebSite
> 7. Blog 
> 8. Employment
> 9. Employee Position 
> 10.Performance Review  
> 11.Job Requisition 
> 12. Party Resume



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10950) Having ability to make Configurable options date controlled

2019-04-28 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-10950:


Assignee: Arun Patidar  (was: Mohammed Rehan Khan)

> Having ability to make Configurable options date controlled
> ---
>
> Key: OFBIZ-10950
> URL: https://issues.apache.org/jira/browse/OFBIZ-10950
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Arun Patidar
>Priority: Major
> Attachments: OFBIZ-10950.patch
>
>
> Have the ability to make the Configurable Option Date Controlled while 
> setting up the Configurable Good
> We can add fromDate (not nullable) and thruDate fields to ProductConfigOption 
> entity to achieve that. So while building ProductConfigWrapper object we can 
> filter all those options which are expired. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10952) Add support of applying price rule to the selected options during the configurable product ordering workflow

2019-04-28 Thread Mohammed Rehan Khan (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827833#comment-16827833
 ] 

Mohammed Rehan Khan commented on OFBIZ-10952:
-

[~pritam.kute]
PriceRule on configure product option item is working fine if we add list_price 
for the options product.
Currently, there is only one price type(Default_price) setup for this option 
products. But calculate product price service applies price rule on list_price 
of the product only.  

So if we set up/add list_price for the options product then the functionality 
will be working fine.

--
Thanks !!

> Add support of applying price rule to the selected options during the 
> configurable product ordering workflow
> 
>
> Key: OFBIZ-10952
> URL: https://issues.apache.org/jira/browse/OFBIZ-10952
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Mohammed Rehan Khan
>Priority: Major
>
> Add the support for setting and apply the price rules on a configurable item 
> based on other sets of opted configurable items.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10904) Creating custom Time Period does not show in party time period

2019-04-28 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827874#comment-16827874
 ] 

Jacques Le Roux commented on OFBIZ-10904:
-

Thanks Pawan,

I understood why I did not reproduce. When I entered data initially at  !Image 
006.png! I made a mistake. Then I got to  !Image 007.png! where the is Closed 
field exists. So I guess your patch works (did not try) but I suggest to use 
the 2nd screen in all cases. What do you think?

> Creating custom Time Period does not show in party time period
> --
>
> Key: OFBIZ-10904
> URL: https://issues.apache.org/jira/browse/OFBIZ-10904
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12, Release Branch 16.11, Release Branch 17.12, Release 
> Branch 18.12
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
> Attachments: Image 006.png, Image 007.png, OFBIZ-10904.patch
>
>
> When a new time period is added in screen [1] the result does not show up in 
> [2].
> [1] 
> [https://demo-stable.ofbiz.apache.org/accounting/control/EditCustomTimePeriod]
> [2] 
> [https://demo-stable.ofbiz.apache.org/accounting/control/TimePeriods?organizationPartyId=Company]
> This is due to the fact that the field 'isClosed' is not set. Appropriate 
> values are: Y or N.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10933) Insertion order of ‘LinkedHashMap’ is not preserved by ‘MapContext’

2019-04-28 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827859#comment-16827859
 ] 

Pierre Smits commented on OFBIZ-10933:
--

Should we not heed comments made in the 'move to jdk11' discussion in the dev 
ml, from what I got from it: have it correctly working for jdk8?

> Insertion order of ‘LinkedHashMap’ is not preserved by ‘MapContext’
> ---
>
> Key: OFBIZ-10933
> URL: https://issues.apache.org/jira/browse/OFBIZ-10933
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 18.12
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Major
> Fix For: Trunk, Release Branch 18.12
>
> Attachments: 
> OFBIZ-10933_0001-Improved-Add-UtilMisc-toMap-Supplier-Map-K-V-Object.patch, 
> OFBIZ-10933_0002-Fixed-Ensure-that-MapContext-preserves-insertion-ord.patch
>
>
> Since revision 1837462, when pushing a ‘LinkedHashMap’ inside a ‘MapContext’, 
> the iteration order of the ‘MapContext’ values is not corresponding to the
> insertion order of the embedded ‘LinkedHashMap’ which is important in the 
> ‘ControllerConfig’ case where configuration elements are stored in 
> ‘LinkedHashMap’ objects and the ‘include’ mechanism relies on ‘MapContext’.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10973) Rename custom component for SMS gateway integration

2019-04-28 Thread Rishi Solanki (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-10973:
-

Assignee: (was: vivek singh bisen)

> Rename custom component for SMS gateway integration
> ---
>
> Key: OFBIZ-10973
> URL: https://issues.apache.org/jira/browse/OFBIZ-10973
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Priority: Major
>
> As per the comment by [~jacques.le.roux] on the commit log of the SMS gateway 
> integration:
> {quote}
> "In understand that this component currently uses "msg91 services to send 
> sms".
> But could we not have another name, more explicit, for this component, like 
> sms or sendsms for instance?
> Services tend to disappear or change (Google is the best example). So I'd not 
> associate the name of an open source component to a commercial services  
> provider (with a free SMS quota option). Even if hopefully it will stay as 
> is..."
> {quote}
> Need to rename the custom component and replace all occurrences in code level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10125) Error exporting Product entities

2019-04-28 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10125:

Description: 
Got the following error attempting to export Products using the Export XML tool:


{noformat}
org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
[component://webtools/widget/EntityScreens.xml#xmldsdump]: 
org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
[component://webtools/widget/CommonScreens.xml#CommonImportExportDecorator]: 
org.apache.ofbiz.entity.transaction.GenericTransactionException: The current 
transaction is marked for rollback, not beginning a new transaction and 
aborting current operation; the rollbackOnly was caused by: [1] [xxx] Error 
when writing Product: org.apache.ofbiz.entity.GenericDataSourceException: SQL 
Exception while executing the following:SELECT DISTINCT PRODUCT_ID, 
PRODUCT_TYPE_ID, PRIMARY_PRODUCT_CATEGORY_ID, MANUFACTURER_PARTY_ID, 
FACILITY_ID, INTRODUCTION_DATE, RELEASE_DATE, SUPPORT_DISCONTINUATION_DATE, 
SALES_DISCONTINUATION_DATE, SALES_DISC_WHEN_NOT_AVAIL, INTERNAL_NAME, 
BRAND_NAME, COMMENTS, PRODUCT_NAME, DESCRIPTION, LONG_DESCRIPTION, 
PRICE_DETAIL_TEXT, SMALL_IMAGE_URL, MEDIUM_IMAGE_URL, LARGE_IMAGE_URL, 
DETAIL_IMAGE_URL, ORIGINAL_IMAGE_URL, DETAIL_SCREEN, INVENTORY_MESSAGE, 
INVENTORY_ITEM_TYPE_ID, REQUIRE_INVENTORY, QUANTITY_UOM_ID, QUANTITY_INCLUDED, 
PIECES_INCLUDED, REQUIRE_AMOUNT, FIXED_AMOUNT, AMOUNT_UOM_TYPE_ID, 
WEIGHT_UOM_ID, SHIPPING_WEIGHT, PRODUCT_WEIGHT, HEIGHT_UOM_ID, PRODUCT_HEIGHT, 
SHIPPING_HEIGHT, WIDTH_UOM_ID, PRODUCT_WIDTH, SHIPPING_WIDTH, DEPTH_UOM_ID, 
PRODUCT_DEPTH, SHIPPING_DEPTH, DIAMETER_UOM_ID, PRODUCT_DIAMETER, 
PRODUCT_RATING, RATING_TYPE_ENUM, RETURNABLE, TAXABLE, CHARGE_SHIPPING, 
AUTO_CREATE_KEYWORDS, INCLUDE_IN_PROMOTIONS, IS_VIRTUAL, IS_VARIANT, 
VIRTUAL_VARIANT_METHOD_ENUM, ORIGIN_GEO_ID, REQUIREMENT_METHOD_ENUM_ID, 
BILL_OF_MATERIAL_LEVEL, RESERV_MAX_PERSONS, RESERV2ND_P_P_PERC, 
RESERV_NTH_P_P_PERC, CONFIG_ID, CREATED_DATE, CREATED_BY_USER_LOGIN, 
LAST_MODIFIED_DATE, LAST_MODIFIED_BY_USER_LOGIN, IN_SHIPPING_BOX, 
DEFAULT_SHIPMENT_BOX_TYPE_ID, LOT_ID_FILLED_IN, ORDER_DECIMAL_QUANTITY, 
LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP FROM 
dbo.PRODUCT ORDER BY PRODUCT_ID ASC (The text data type cannot be selected as 
DISTINCT because it is not 
comparable.)org.apache.ofbiz.entity.GenericDataSourceException: SQL Exception 
while executing the following:SELECT DISTINCT PRODUCT_ID, PRODUCT_TYPE_ID, 
PRIMARY_PRODUCT_CATEGORY_ID, MANUFACTURER_PARTY_ID, FACILITY_ID, 
INTRODUCTION_DATE, RELEASE_DATE, SUPPORT_DISCONTINUATION_DATE, 
SALES_DISCONTINUATION_DATE, SALES_DISC_WHEN_NOT_AVAIL, INTERNAL_NAME, 
BRAND_NAME, COMMENTS, PRODUCT_NAME, DESCRIPTION, LONG_DESCRIPTION, 
PRICE_DETAIL_TEXT, SMALL_IMAGE_URL, MEDIUM_IMAGE_URL, LARGE_IMAGE_URL, 
DETAIL_IMAGE_URL, ORIGINAL_IMAGE_URL, DETAIL_SCREEN, INVENTORY_MESSAGE, 
INVENTORY_ITEM_TYPE_ID, REQUIRE_INVENTORY, QUANTITY_UOM_ID, QUANTITY_INCLUDED, 
PIECES_INCLUDED, REQUIRE_AMOUNT, FIXED_AMOUNT, AMOUNT_UOM_TYPE_ID, 
WEIGHT_UOM_ID, SHIPPING_WEIGHT, PRODUCT_WEIGHT, HEIGHT_UOM_ID, PRODUCT_HEIGHT, 
SHIPPING_HEIGHT, WIDTH_UOM_ID, PRODUCT_WIDTH, SHIPPING_WIDTH, DEPTH_UOM_ID, 
PRODUCT_DEPTH, SHIPPING_DEPTH, DIAMETER_UOM_ID, PRODUCT_DIAMETER, 
PRODUCT_RATING, RATING_TYPE_ENUM, RETURNABLE, TAXABLE, CHARGE_SHIPPING, 
AUTO_CREATE_KEYWORDS, INCLUDE_IN_PROMOTIONS, IS_VIRTUAL, IS_VARIANT, 
VIRTUAL_VARIANT_METHOD_ENUM, ORIGIN_GEO_ID, REQUIREMENT_METHOD_ENUM_ID, 
BILL_OF_MATERIAL_LEVEL, RESERV_MAX_PERSONS, RESERV2ND_P_P_PERC, 
RESERV_NTH_P_P_PERC, CONFIG_ID, CREATED_DATE, CREATED_BY_USER_LOGIN, 
LAST_MODIFIED_DATE, LAST_MODIFIED_BY_USER_LOGIN, IN_SHIPPING_BOX, 
DEFAULT_SHIPMENT_BOX_TYPE_ID, LOT_ID_FILLED_IN, ORDER_DECIMAL_QUANTITY, 
LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP FROM 
dbo.PRODUCT ORDER BY PRODUCT_ID ASC (The text data type cannot be selected as 
DISTINCT because it is not comparable.) (SQL Exception while executing the 
following:SELECT DISTINCT PRODUCT_ID, PRODUCT_TYPE_ID, 
PRIMARY_PRODUCT_CATEGORY_ID, MANUFACTURER_PARTY_ID, FACILITY_ID, 
INTRODUCTION_DATE, RELEASE_DATE, SUPPORT_DISCONTINUATION_DATE, 
SALES_DISCONTINUATION_DATE, SALES_DISC_WHEN_NOT_AVAIL, INTERNAL_NAME, 
BRAND_NAME, COMMENTS, PRODUCT_NAME, DESCRIPTION, LONG_DESCRIPTION, 
PRICE_DETAIL_TEXT, SMALL_IMAGE_URL, MEDIUM_IMAGE_URL, LARGE_IMAGE_URL, 
DETAIL_IMAGE_URL, ORIGINAL_IMAGE_URL, DETAIL_SCREEN, INVENTORY_MESSAGE, 
INVENTORY_ITEM_TYPE_ID, REQUIRE_INVENTORY, QUANTITY_UOM_ID, QUANTITY_INCLUDED, 
PIECES_INCLUDED, REQUIRE_AMOUNT, FIXED_AMOUNT, AMOUNT_UOM_TYPE_ID, 
WEIGHT_UOM_ID, SHIPPING_WEIGHT, PRODUCT_WEIGHT, HEIGHT_UOM_ID, PRODUCT_HEIGHT, 
SHIPPING_HEIGHT, WIDTH_UOM_ID, PRODUCT_WIDTH, SHIPPING_WIDTH, DEPTH_UOM_ID, 
PRODUCT_DEPTH, SHIPPING_DEPTH, DIAMETER_UOM_ID, PRODUCT_DIAMETER, 
PRODUCT_RATING, 

[jira] [Closed] (OFBIZ-10950) Having ability to make Configurable options date controlled

2019-04-28 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-10950.


> Having ability to make Configurable options date controlled
> ---
>
> Key: OFBIZ-10950
> URL: https://issues.apache.org/jira/browse/OFBIZ-10950
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Arun Patidar
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10950.patch
>
>
> Have the ability to make the Configurable Option Date Controlled while 
> setting up the Configurable Good
> We can add fromDate (not nullable) and thruDate fields to ProductConfigOption 
> entity to achieve that. So while building ProductConfigWrapper object we can 
> filter all those options which are expired. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10950) Having ability to make Configurable options date controlled

2019-04-28 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar resolved OFBIZ-10950.
--
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed revision 1858305.

Thanks Pritam Kute for reporting and Mohammed Rehan Khan for patch.

> Having ability to make Configurable options date controlled
> ---
>
> Key: OFBIZ-10950
> URL: https://issues.apache.org/jira/browse/OFBIZ-10950
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Arun Patidar
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10950.patch
>
>
> Have the ability to make the Configurable Option Date Controlled while 
> setting up the Configurable Good
> We can add fromDate (not nullable) and thruDate fields to ProductConfigOption 
> entity to achieve that. So while building ProductConfigWrapper object we can 
> filter all those options which are expired. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10125) Error exporting Product entities

2019-04-28 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10125.
---
   Resolution: Cannot Reproduce
 Assignee: Jacques Le Roux
Fix Version/s: 16.11.06

Thanks Pritam,

Timothy, I have tried as well using what will be 16.11.06, ie using the R16 
branch HEAD, and I cold not reproduce as well. So I suggest that if you are 
still interested you try with the last stable release ie 16.11.05 and report if 
you get the same issue. In the meatime I close as "cannot reproduce". Please 
reopen in case...

> Error exporting Product entities
> 
>
> Key: OFBIZ-10125
> URL: https://issues.apache.org/jira/browse/OFBIZ-10125
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 16.11
> Environment: Windows 10 Pro x64. Java 8 152. MS SQL 2017 Linux Docker 
> image.
>Reporter: Timothy Boyden
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 16.11.06
>
>
> Got the following error attempting to export Products using the Export XML 
> tool:
> {noformat}
> org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering 
> screen [component://webtools/widget/EntityScreens.xml#xmldsdump]: 
> org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering 
> screen 
> [component://webtools/widget/CommonScreens.xml#CommonImportExportDecorator]: 
> org.apache.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: [1] [xxx] Error 
> when writing Product: org.apache.ofbiz.entity.GenericDataSourceException: SQL 
> Exception while executing the following:SELECT DISTINCT PRODUCT_ID, 
> PRODUCT_TYPE_ID, PRIMARY_PRODUCT_CATEGORY_ID, MANUFACTURER_PARTY_ID, 
> FACILITY_ID, INTRODUCTION_DATE, RELEASE_DATE, SUPPORT_DISCONTINUATION_DATE, 
> SALES_DISCONTINUATION_DATE, SALES_DISC_WHEN_NOT_AVAIL, INTERNAL_NAME, 
> BRAND_NAME, COMMENTS, PRODUCT_NAME, DESCRIPTION, LONG_DESCRIPTION, 
> PRICE_DETAIL_TEXT, SMALL_IMAGE_URL, MEDIUM_IMAGE_URL, LARGE_IMAGE_URL, 
> DETAIL_IMAGE_URL, ORIGINAL_IMAGE_URL, DETAIL_SCREEN, INVENTORY_MESSAGE, 
> INVENTORY_ITEM_TYPE_ID, REQUIRE_INVENTORY, QUANTITY_UOM_ID, 
> QUANTITY_INCLUDED, PIECES_INCLUDED, REQUIRE_AMOUNT, FIXED_AMOUNT, 
> AMOUNT_UOM_TYPE_ID, WEIGHT_UOM_ID, SHIPPING_WEIGHT, PRODUCT_WEIGHT, 
> HEIGHT_UOM_ID, PRODUCT_HEIGHT, SHIPPING_HEIGHT, WIDTH_UOM_ID, PRODUCT_WIDTH, 
> SHIPPING_WIDTH, DEPTH_UOM_ID, PRODUCT_DEPTH, SHIPPING_DEPTH, DIAMETER_UOM_ID, 
> PRODUCT_DIAMETER, PRODUCT_RATING, RATING_TYPE_ENUM, RETURNABLE, TAXABLE, 
> CHARGE_SHIPPING, AUTO_CREATE_KEYWORDS, INCLUDE_IN_PROMOTIONS, IS_VIRTUAL, 
> IS_VARIANT, VIRTUAL_VARIANT_METHOD_ENUM, ORIGIN_GEO_ID, 
> REQUIREMENT_METHOD_ENUM_ID, BILL_OF_MATERIAL_LEVEL, RESERV_MAX_PERSONS, 
> RESERV2ND_P_P_PERC, RESERV_NTH_P_P_PERC, CONFIG_ID, CREATED_DATE, 
> CREATED_BY_USER_LOGIN, LAST_MODIFIED_DATE, LAST_MODIFIED_BY_USER_LOGIN, 
> IN_SHIPPING_BOX, DEFAULT_SHIPMENT_BOX_TYPE_ID, LOT_ID_FILLED_IN, 
> ORDER_DECIMAL_QUANTITY, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, 
> CREATED_STAMP, CREATED_TX_STAMP FROM dbo.PRODUCT ORDER BY PRODUCT_ID ASC (The 
> text data type cannot be selected as DISTINCT because it is not 
> comparable.)org.apache.ofbiz.entity.GenericDataSourceException: SQL Exception 
> while executing the following:SELECT DISTINCT PRODUCT_ID, PRODUCT_TYPE_ID, 
> PRIMARY_PRODUCT_CATEGORY_ID, MANUFACTURER_PARTY_ID, FACILITY_ID, 
> INTRODUCTION_DATE, RELEASE_DATE, SUPPORT_DISCONTINUATION_DATE, 
> SALES_DISCONTINUATION_DATE, SALES_DISC_WHEN_NOT_AVAIL, INTERNAL_NAME, 
> BRAND_NAME, COMMENTS, PRODUCT_NAME, DESCRIPTION, LONG_DESCRIPTION, 
> PRICE_DETAIL_TEXT, SMALL_IMAGE_URL, MEDIUM_IMAGE_URL, LARGE_IMAGE_URL, 
> DETAIL_IMAGE_URL, ORIGINAL_IMAGE_URL, DETAIL_SCREEN, INVENTORY_MESSAGE, 
> INVENTORY_ITEM_TYPE_ID, REQUIRE_INVENTORY, QUANTITY_UOM_ID, 
> QUANTITY_INCLUDED, PIECES_INCLUDED, REQUIRE_AMOUNT, FIXED_AMOUNT, 
> AMOUNT_UOM_TYPE_ID, WEIGHT_UOM_ID, SHIPPING_WEIGHT, PRODUCT_WEIGHT, 
> HEIGHT_UOM_ID, PRODUCT_HEIGHT, SHIPPING_HEIGHT, WIDTH_UOM_ID, PRODUCT_WIDTH, 
> SHIPPING_WIDTH, DEPTH_UOM_ID, PRODUCT_DEPTH, SHIPPING_DEPTH, DIAMETER_UOM_ID, 
> PRODUCT_DIAMETER, PRODUCT_RATING, RATING_TYPE_ENUM, RETURNABLE, TAXABLE, 
> CHARGE_SHIPPING, AUTO_CREATE_KEYWORDS, INCLUDE_IN_PROMOTIONS, IS_VIRTUAL, 
> IS_VARIANT, VIRTUAL_VARIANT_METHOD_ENUM, ORIGIN_GEO_ID, 
> REQUIREMENT_METHOD_ENUM_ID, BILL_OF_MATERIAL_LEVEL, RESERV_MAX_PERSONS, 
> RESERV2ND_P_P_PERC, RESERV_NTH_P_P_PERC, CONFIG_ID, CREATED_DATE, 
> CREATED_BY_USER_LOGIN, LAST_MODIFIED_DATE, LAST_MODIFIED_BY_USER_LOGIN, 
> IN_SHIPPING_BOX, DEFAULT_SHIPMENT_BOX_TYPE_ID, LOT_ID_FILLED_IN, 
> ORDER_DECIMAL_QUANTITY, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, 

[jira] [Commented] (OFBIZ-10933) Insertion order of ‘LinkedHashMap’ is not preserved by ‘MapContext’

2019-04-28 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827875#comment-16827875
 ] 

Jacques Le Roux commented on OFBIZ-10933:
-

Thanks Mathieu,

Sure that just a test after all, no needs to be nitpicky

> Insertion order of ‘LinkedHashMap’ is not preserved by ‘MapContext’
> ---
>
> Key: OFBIZ-10933
> URL: https://issues.apache.org/jira/browse/OFBIZ-10933
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 18.12
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Major
> Fix For: Trunk, Release Branch 18.12
>
> Attachments: 
> OFBIZ-10933_0001-Improved-Add-UtilMisc-toMap-Supplier-Map-K-V-Object.patch, 
> OFBIZ-10933_0002-Fixed-Ensure-that-MapContext-preserves-insertion-ord.patch
>
>
> Since revision 1837462, when pushing a ‘LinkedHashMap’ inside a ‘MapContext’, 
> the iteration order of the ‘MapContext’ values is not corresponding to the
> insertion order of the embedded ‘LinkedHashMap’ which is important in the 
> ‘ControllerConfig’ case where configuration elements are stored in 
> ‘LinkedHashMap’ objects and the ‘include’ mechanism relies on ‘MapContext’.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10904) Creating custom Time Period does not show in party time period

2019-04-28 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10904:

Attachment: Image 007.png
Image 006.png

> Creating custom Time Period does not show in party time period
> --
>
> Key: OFBIZ-10904
> URL: https://issues.apache.org/jira/browse/OFBIZ-10904
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12, Release Branch 16.11, Release Branch 17.12, Release 
> Branch 18.12
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
> Attachments: Image 006.png, Image 007.png, OFBIZ-10904.patch
>
>
> When a new time period is added in screen [1] the result does not show up in 
> [2].
> [1] 
> [https://demo-stable.ofbiz.apache.org/accounting/control/EditCustomTimePeriod]
> [2] 
> [https://demo-stable.ofbiz.apache.org/accounting/control/TimePeriods?organizationPartyId=Company]
> This is due to the fact that the field 'isClosed' is not set. Appropriate 
> values are: Y or N.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10952) Add support of applying price rule to the selected options during the configurable product ordering workflow

2019-04-28 Thread Arun Patidar (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827836#comment-16827836
 ] 

Arun Patidar commented on OFBIZ-10952:
--

I assume that it is related to price rule not working for config options 
products. If this is case then reason suggested by [~rehan.khan] makes sense.

This was only data related issue. We can close this issue as per above comment.

> Add support of applying price rule to the selected options during the 
> configurable product ordering workflow
> 
>
> Key: OFBIZ-10952
> URL: https://issues.apache.org/jira/browse/OFBIZ-10952
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Mohammed Rehan Khan
>Priority: Major
>
> Add the support for setting and apply the price rules on a configurable item 
> based on other sets of opted configurable items.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10959) Enable entity timestamp fields

2019-04-28 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827856#comment-16827856
 ] 

Pierre Smits commented on OFBIZ-10959:
--

Yesterday the affected version was trimmed down from
 * Trunk
 * Release Branch 18.12
 * Release Branch 17.12

to
 * Trunk

How can our existing adopters *easily* find that this is applicable for their 
version after an upgrade of their old implemented version to a release from 
either branch if these are not referenced?

> Enable entity timestamp fields
> --
>
> Key: OFBIZ-10959
> URL: https://issues.apache.org/jira/browse/OFBIZ-10959
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-10959.patch, OFBIZ-10959.patch
>
>
> MarkMail link for the discussion: 
> [https://markmail.org/thread/x7paa3ulljns6awh]
>  
> While working on a Production environment, I have found that for some reason 
> entity timestamp fields are disabled at Search Results screen in Trunk and 
> the previous release branch. It is available at View Value screen. It was 
> enabled in Release 16.11.
>  
> These fields are helpful for developers to get the idea about when the row in 
> the entity is created/updated. Extremely helpful while working on the 
> Production environment.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10973) Rename custom component for SMS gateway integration

2019-04-28 Thread Rishi Solanki (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827871#comment-16827871
 ] 

Rishi Solanki commented on OFBIZ-10973:
---

[~pritam.kute]

I have committed the base changes in revision 1858279 and 1858307. Please do 
the planned changes as per your plan. Thanks for your contribution.

> Rename custom component for SMS gateway integration
> ---
>
> Key: OFBIZ-10973
> URL: https://issues.apache.org/jira/browse/OFBIZ-10973
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: vivek singh bisen
>Priority: Major
>
> As per the comment by [~jacques.le.roux] on the commit log of the SMS gateway 
> integration:
> {quote}
> "In understand that this component currently uses "msg91 services to send 
> sms".
> But could we not have another name, more explicit, for this component, like 
> sms or sendsms for instance?
> Services tend to disappear or change (Google is the best example). So I'd not 
> associate the name of an open source component to a commercial services  
> provider (with a free SMS quota option). Even if hopefully it will stay as 
> is..."
> {quote}
> Need to rename the custom component and replace all occurrences in code level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10959) Enable entity timestamp fields

2019-04-28 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827881#comment-16827881
 ] 

Jacques Le Roux commented on OFBIZ-10959:
-

+1 for Mathieu suggestions :)

> Enable entity timestamp fields
> --
>
> Key: OFBIZ-10959
> URL: https://issues.apache.org/jira/browse/OFBIZ-10959
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-10959.patch, OFBIZ-10959.patch
>
>
> MarkMail link for the discussion: 
> [https://markmail.org/thread/x7paa3ulljns6awh]
>  
> While working on a Production environment, I have found that for some reason 
> entity timestamp fields are disabled at Search Results screen in Trunk and 
> the previous release branch. It is available at View Value screen. It was 
> enabled in Release 16.11.
>  
> These fields are helpful for developers to get the idea about when the row in 
> the entity is created/updated. Extremely helpful while working on the 
> Production environment.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10967) Remove link is not working in shopping list

2019-04-28 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10967:

Affects Version/s: Release Branch 18.12
   Release Branch 17.12
   Release Branch 13.07
   Release Branch 14.12
   Release Branch 15.12
   Release Branch 16.11
  Component/s: ecommerce

> Remove link is not working in shopping list
> ---
>
> Key: OFBIZ-10967
> URL: https://issues.apache.org/jira/browse/OFBIZ-10967
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12, Release Branch 16.11, Release Branch 17.12, Release 
> Branch 18.12
>Reporter: Ashish Sharma
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-10967.docx
>
>
> *Step to reproduce*
> 1. Login with valid username and password.
> 2. Navigate to ecommerce.
> 3. Move the product to shopping list.
> 4. Navigate to shopping list section.
> 5. Click on link “Remove"
> *Expected Result:* Product should be removed from shopping list.
> *Actual Result:* Remove link is not working.
> *Screen print attached*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10967) Remove link is not working in shopping list

2019-04-28 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-10967:
---

Assignee: Jacques Le Roux

> Remove link is not working in shopping list
> ---
>
> Key: OFBIZ-10967
> URL: https://issues.apache.org/jira/browse/OFBIZ-10967
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ashish Sharma
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-10967.docx
>
>
> *Step to reproduce*
> 1. Login with valid username and password.
> 2. Navigate to ecommerce.
> 3. Move the product to shopping list.
> 4. Navigate to shopping list section.
> 5. Click on link “Remove"
> *Expected Result:* Product should be removed from shopping list.
> *Actual Result:* Remove link is not working.
> *Screen print attached*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10958) Service createProductFeature ignores passed productFeatureId

2019-04-28 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827966#comment-16827966
 ] 

Jacques Le Roux commented on OFBIZ-10958:
-

Thanks Swapnil,

I never looked at it, but I guess that's why INOUT exists ;)

> Service createProductFeature ignores passed productFeatureId
> 
>
> Key: OFBIZ-10958
> URL: https://issues.apache.org/jira/browse/OFBIZ-10958
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Swapnil M Mane
>Priority: Minor
> Fix For: 16.11.06
>
> Attachments: OFBIZ-10958_Fix_createProductFeature.patch
>
>
> Service "createProductFeature" ignores passed productFeatureId caused by 
> overwritten output parameter. If I do following changes, this problem 
> disappears.
>  original:
> {code:xml}
>   default-entity-name="ProductFeature" auth="true">
> Create a ProductFeature record
> 
>  optional="false"/>
> 
> 
> 
> {code}
> Fix:
> {code:xml}
>  default-entity-name="ProductFeature" auth="true"> 
> Create a ProductFeature record 
>  
>  optional="true"/>
>  
>  
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10966) JSON entity data import and export utility

2019-04-28 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827969#comment-16827969
 ] 

Jacques Le Roux commented on OFBIZ-10966:
-

Hi Jayansh,

That sounds like a good idea, looking forward...

> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Jayansh Shinde
>Priority: Minor
>
> Currently, we support import/export entity data in XML format.
>  Nowadays JSON is widely used in industry, we can have support for JSON 
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
> 
> {code}
> {code:java}
> {“Party”: 
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>  
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for 
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>  
> *Import Design*
>  The import service will perform following operations:
>  1.) Validate the input JSON data (I am in process of exploring the way for 
> this)
>  2.) On successful validation, convert JSON to OFBiz's entity model 
> (GenericValue)
>  3.) The GenericValue will be inserted in database by some handler class for 
> e.g we can write JsonDataHandler, it will convert given JSON to 
> List, and finally write it to database (Similar pattern is used 
> in XML import).
>  
> *Export Design*
>  Based on existing XML pattern the writeXmlText method of GenericEntity class 
> write the exported data in XML format. 
>  In the similar way, we can implement writeJsonText to export data in JSON 
> format.
> Please free feel to share your thought.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10959) Enable entity timestamp fields

2019-04-28 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10959:

Priority: Major  (was: Minor)

> Enable entity timestamp fields
> --
>
> Key: OFBIZ-10959
> URL: https://issues.apache.org/jira/browse/OFBIZ-10959
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Pawan Verma
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10959.patch, OFBIZ-10959.patch
>
>
> MarkMail link for the discussion: 
> [https://markmail.org/thread/x7paa3ulljns6awh]
>  
> While working on a Production environment, I have found that for some reason 
> entity timestamp fields are disabled at Search Results screen in Trunk and 
> the previous release branch. It is available at View Value screen. It was 
> enabled in Release 16.11.
>  
> These fields are helpful for developers to get the idea about when the row in 
> the entity is created/updated. Extremely helpful while working on the 
> Production environment.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10959) Enable entity timestamp fields

2019-04-28 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10959:

Affects Version/s: Release Branch 18.12
   Release Branch 17.12
   Issue Type: Bug  (was: Improvement)

Thanks Pierre,

I guess it was when the type changed from bug to improvements. I agree it's a 
bug and should concern (ie be backported to R17 and R18), as the description 
clearly mention it. 

I just changed all that.

> Enable entity timestamp fields
> --
>
> Key: OFBIZ-10959
> URL: https://issues.apache.org/jira/browse/OFBIZ-10959
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Pawan Verma
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-10959.patch, OFBIZ-10959.patch
>
>
> MarkMail link for the discussion: 
> [https://markmail.org/thread/x7paa3ulljns6awh]
>  
> While working on a Production environment, I have found that for some reason 
> entity timestamp fields are disabled at Search Results screen in Trunk and 
> the previous release branch. It is available at View Value screen. It was 
> enabled in Release 16.11.
>  
> These fields are helpful for developers to get the idea about when the row in 
> the entity is created/updated. Extremely helpful while working on the 
> Production environment.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7711) Label not showing properly on 'Add EFT Account' screen of scrum

2019-04-28 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827989#comment-16827989
 ] 

Pierre Smits commented on OFBIZ-7711:
-

This is (part of a systemic flaw). 

Profiles shown in component specific screens should be tailored the context of 
the component and to the parties involved in component processes (in accordance 
to their roles therein). And this should be configurable at operation level, 
not through design. Which is catered for through portal pages and portlets.

I suggest we close this ticket with a 'won't do'

> Label not showing properly on 'Add EFT Account' screen of scrum
> ---
>
> Key: OFBIZ-7711
> URL: https://issues.apache.org/jira/browse/OFBIZ-7711
> Project: OFBiz
>  Issue Type: Improvement
>  Components: scrum
>Affects Versions: Trunk
>Reporter: Chandan Khandelwal
>Priority: Trivial
> Attachments: OFBIZ-7711-Add-New-Check-Account.png, 
> OFBIZ-7711-Add-New-Credit-Card.png, 
> OFBIZ-7711-Add-New-EFT-Account-Scrum-Profile-View.png, 
> OFBIZ-7711-Payment-Method-Block-Scrum-Profile-View.png, OFBIZ-7711.patch
>
>
> Accounting Uilabel resource not added in scrum main decorator.
> URL : 
> https://localhost:8443/scrum/control/editeftaccount?partyId=DemoScrumCompany



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10949) Move display of page title in accounting screens to location above (action) menu(s)

2019-04-28 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10949.
---
   Resolution: Done
Fix Version/s: Upcoming Branch

Thanks Pierre,

Last patch added at revision: 1858329  


> Move display of page title in  accounting screens to location above 
> (action) menu(s)
> ---
>
> Key: OFBIZ-10949
> URL: https://issues.apache.org/jira/browse/OFBIZ-10949
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Trivial
>  Labels: usability
> Fix For: Upcoming Branch
>
> Attachments: Image 005.png, OFBIZ-10949-accounting.patch, 
> OFBIZ-10949.diff, Screen Shot 2019-04-27 at 11.15.55.png
>
>
> See  [1] and [2] and other accounting party screens. 
> Currently the page title of the screen(s) is shown below the (various) 
> menu(s). In order to improve usability the title of the page should be shown 
> the menu(s).
>  # [https://demo-stable.ofbiz.apache.org/accounting/control/AdminMain]
>  # https://demo-trunk.ofbiz.apache.org/accounting/control/AdminMain



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10949) Move display of page title in accounting screens to location above (action) menu(s)

2019-04-28 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827892#comment-16827892
 ] 

Jacques Le Roux commented on OFBIZ-10949:
-

Hi Pierre,

Did you try? because I reproduce each time on both

https://localhost:8443/accounting/control/PartyAccountsSummary
https://localhost:8443/accounting/control/AdminMain

What could I miss?

BTW I wronly applied your patch while committing for OFBIZ-9905. So you can 
test it, at least today, on trunk demo at
https://demo-trunk.ofbiz.apache.org/accounting/control/AdminMain
https://demo-trunk.ofbiz.apache.org/accounting/control/PartyAccountsSummary

HTH

> Move display of page title in  accounting screens to location above 
> (action) menu(s)
> ---
>
> Key: OFBIZ-10949
> URL: https://issues.apache.org/jira/browse/OFBIZ-10949
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: usability
> Attachments: Image 005.png, OFBIZ-10949-accounting.patch, Screen Shot 
> 2019-04-27 at 11.15.55.png
>
>
> See  [1] and [2] and other accounting party screens. 
> Currently the page title of the screen(s) is shown below the (various) 
> menu(s). In order to improve usability the title of the page should be shown 
> the menu(s).
>  # [https://demo-stable.ofbiz.apache.org/accounting/control/AdminMain]
>  # https://demo-trunk.ofbiz.apache.org/accounting/control/AdminMain



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10978) Unable to find any product in Quick Add functionality

2019-04-28 Thread vivek singh bisen (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

vivek singh bisen updated OFBIZ-10978:
--
Attachment: OFBIZ-10978.patch

> Unable to find any product in Quick Add functionality
> -
>
> Key: OFBIZ-10978
> URL: https://issues.apache.org/jira/browse/OFBIZ-10978
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Padmavati Rawat
>Assignee: vivek singh bisen
>Priority: Major
> Attachments: OFBIZ-10978.patch, Quikadd.png
>
>
> Steps:
> 1. Visit the e-commerce page of the trunk.
> 2. Open Quick Add menu from navbar section.
> https://demo-trunk.ofbiz.apache.org/ecommerce/control/quickadd
> 3. Check the Product list on the screen.
> Actual:
> Quick Add screen rendering an error "Error: Product not found" on the screen.
> Not able to find any option to Quick Add.
> Please, refer screenshot:



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7711) Label not showing properly on 'Add EFT Account' screen of scrum

2019-04-28 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827996#comment-16827996
 ] 

Jacques Le Roux commented on OFBIZ-7711:


+1

> Label not showing properly on 'Add EFT Account' screen of scrum
> ---
>
> Key: OFBIZ-7711
> URL: https://issues.apache.org/jira/browse/OFBIZ-7711
> Project: OFBiz
>  Issue Type: Improvement
>  Components: scrum
>Affects Versions: Trunk
>Reporter: Chandan Khandelwal
>Priority: Trivial
> Attachments: OFBIZ-7711-Add-New-Check-Account.png, 
> OFBIZ-7711-Add-New-Credit-Card.png, 
> OFBIZ-7711-Add-New-EFT-Account-Scrum-Profile-View.png, 
> OFBIZ-7711-Payment-Method-Block-Scrum-Profile-View.png, OFBIZ-7711.patch
>
>
> Accounting Uilabel resource not added in scrum main decorator.
> URL : 
> https://localhost:8443/scrum/control/editeftaccount?partyId=DemoScrumCompany



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10967) Remove link is not working in shopping list

2019-04-28 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10967.
---
   Resolution: Fixed
Fix Version/s: 18.12.01
   16.11.06
   17.12.01

Thanks Ashish,

For those who don't use Word, it's a js error: TypeError: 
document.removeFromShoppingList.submit is not a function (barely readeable in 
your  [^OFBIZ-10967.docx]  Ashish. Please don't use Word for such images but a 
png, jpg, etc. thanks)

OFBIZ-7291 [broke 
it|http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ecommerce/template/shoppinglist/EditShoppingList.ftl?r1=1748156=1748155=1748156]
 That can be tested on old demo (R13)

Fixed by using a simple submit field in 
trunk r1858312
R18 r1858313
R17 r1858314
R16 r1858316 (by hand, tested)


> Remove link is not working in shopping list
> ---
>
> Key: OFBIZ-10967
> URL: https://issues.apache.org/jira/browse/OFBIZ-10967
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12, Release Branch 16.11, Release Branch 17.12, Release 
> Branch 18.12
>Reporter: Ashish Sharma
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments: OFBIZ-10967.docx
>
>
> *Step to reproduce*
> 1. Login with valid username and password.
> 2. Navigate to ecommerce.
> 3. Move the product to shopping list.
> 4. Navigate to shopping list section.
> 5. Click on link “Remove"
> *Expected Result:* Product should be removed from shopping list.
> *Actual Result:* Remove link is not working.
> *Screen print attached*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10949) Move display of page title in accounting screens to location above (action) menu(s)

2019-04-28 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827925#comment-16827925
 ] 

Pierre Smits commented on OFBIZ-10949:
--

The attached diff [^OFBIZ-10949.diff] corrects the residual in two other 
screens.

> Move display of page title in  accounting screens to location above 
> (action) menu(s)
> ---
>
> Key: OFBIZ-10949
> URL: https://issues.apache.org/jira/browse/OFBIZ-10949
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: usability
> Attachments: Image 005.png, OFBIZ-10949-accounting.patch, 
> OFBIZ-10949.diff, Screen Shot 2019-04-27 at 11.15.55.png
>
>
> See  [1] and [2] and other accounting party screens. 
> Currently the page title of the screen(s) is shown below the (various) 
> menu(s). In order to improve usability the title of the page should be shown 
> the menu(s).
>  # [https://demo-stable.ofbiz.apache.org/accounting/control/AdminMain]
>  # https://demo-trunk.ofbiz.apache.org/accounting/control/AdminMain



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10973) Rename custom component for SMS gateway integration

2019-04-28 Thread Rishi Solanki (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827871#comment-16827871
 ] 

Rishi Solanki edited comment on OFBIZ-10973 at 4/28/19 11:06 AM:
-

[~pritam.kute]

I have committed the base changes in revision 1858279, 1858307, 1858308, and 
1858311. Please do the planned changes as per your plan. Thanks for your 
contribution.


was (Author: rishisolankii):
[~pritam.kute]

I have committed the base changes in revision 1858279 and 1858307. Please do 
the planned changes as per your plan. Thanks for your contribution.

> Rename custom component for SMS gateway integration
> ---
>
> Key: OFBIZ-10973
> URL: https://issues.apache.org/jira/browse/OFBIZ-10973
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Priority: Major
>
> As per the comment by [~jacques.le.roux] on the commit log of the SMS gateway 
> integration:
> {quote}
> "In understand that this component currently uses "msg91 services to send 
> sms".
> But could we not have another name, more explicit, for this component, like 
> sms or sendsms for instance?
> Services tend to disappear or change (Google is the best example). So I'd not 
> associate the name of an open source component to a commercial services  
> provider (with a free SMS quota option). Even if hopefully it will stay as 
> is..."
> {quote}
> Need to rename the custom component and replace all occurrences in code level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10958) Service createProductFeature ignores passed productFeatureId

2019-04-28 Thread Swapnil M Mane (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil M Mane closed OFBIZ-10958.
--
   Resolution: Fixed
Fix Version/s: 16.11.06

> Service createProductFeature ignores passed productFeatureId
> 
>
> Key: OFBIZ-10958
> URL: https://issues.apache.org/jira/browse/OFBIZ-10958
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Swapnil M Mane
>Priority: Minor
> Fix For: 16.11.06
>
> Attachments: OFBIZ-10958_Fix_createProductFeature.patch
>
>
> Service "createProductFeature" ignores passed productFeatureId caused by 
> overwritten output parameter. If I do following changes, this problem 
> disappears.
>  original:
> {code:xml}
>   default-entity-name="ProductFeature" auth="true">
> Create a ProductFeature record
> 
>  optional="false"/>
> 
> 
> 
> {code}
> Fix:
> {code:xml}
>  default-entity-name="ProductFeature" auth="true"> 
> Create a ProductFeature record 
>  
>  optional="true"/>
>  
>  
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10958) Service createProductFeature ignores passed productFeatureId

2019-04-28 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827962#comment-16827962
 ] 

Swapnil M Mane commented on OFBIZ-10958:


Thank you [~uHeidfeld] for reporting the issue and provide the patch, it is 
highly appreciated!

I have committed your code in 
trunk at rev #1858319
release18.12 at rev #1858320
release17.12 at rev #1858321
release16.11 at rev #1858322


Along with this, I have done some exploration, here are my finding (adding here 
just for informational purpose and future reference)

Here we can't make the changes mentioned below, because, for *optional* field's 
value, invokeCreate method (internally calling isIn and IsOut methods of 
ModelParam) of EntityAutoEngine.java consider the attribute (override) defined 
at last for parameters with the same name.

i.e. for below example, optional value for productFeatureId for mode IN  will 
be false (but it is defined true)

{code}


{code}

Due to this, isSinglePkIn (in invokeCreate method) field got false value, and 
the system will auto-generate the productFeatureId and ignore the user's input.

Similarly, we can't write in this way
{code}


{code}

Because in this case, isSinglePkOut (in invokeCreate method) field got false 
value, and again the system will auto-generate the productFeatureId and ignore 
the user's input.

Thanks!

> Service createProductFeature ignores passed productFeatureId
> 
>
> Key: OFBIZ-10958
> URL: https://issues.apache.org/jira/browse/OFBIZ-10958
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Swapnil M Mane
>Priority: Minor
> Attachments: OFBIZ-10958_Fix_createProductFeature.patch
>
>
> Service "createProductFeature" ignores passed productFeatureId caused by 
> overwritten output parameter. If I do following changes, this problem 
> disappears.
>  original:
> {code:xml}
>   default-entity-name="ProductFeature" auth="true">
> Create a ProductFeature record
> 
>  optional="false"/>
> 
> 
> 
> {code}
> Fix:
> {code:xml}
>  default-entity-name="ProductFeature" auth="true"> 
> Create a ProductFeature record 
>  
>  optional="true"/>
>  
>  
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10958) Service createProductFeature ignores passed productFeatureId

2019-04-28 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827971#comment-16827971
 ] 

Swapnil M Mane commented on OFBIZ-10958:


;) 

> Service createProductFeature ignores passed productFeatureId
> 
>
> Key: OFBIZ-10958
> URL: https://issues.apache.org/jira/browse/OFBIZ-10958
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Swapnil M Mane
>Priority: Minor
> Fix For: 16.11.06
>
> Attachments: OFBIZ-10958_Fix_createProductFeature.patch
>
>
> Service "createProductFeature" ignores passed productFeatureId caused by 
> overwritten output parameter. If I do following changes, this problem 
> disappears.
>  original:
> {code:xml}
>   default-entity-name="ProductFeature" auth="true">
> Create a ProductFeature record
> 
>  optional="false"/>
> 
> 
> 
> {code}
> Fix:
> {code:xml}
>  default-entity-name="ProductFeature" auth="true"> 
> Create a ProductFeature record 
>  
>  optional="true"/>
>  
>  
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10966) JSON entity data import and export utility

2019-04-28 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827975#comment-16827975
 ] 

Swapnil M Mane commented on OFBIZ-10966:


+1 [~jayansh], looking forward on this, thanks!

> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Jayansh Shinde
>Priority: Minor
>
> Currently, we support import/export entity data in XML format.
>  Nowadays JSON is widely used in industry, we can have support for JSON 
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
> 
> {code}
> {code:java}
> {“Party”: 
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>  
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for 
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>  
> *Import Design*
>  The import service will perform following operations:
>  1.) Validate the input JSON data (I am in process of exploring the way for 
> this)
>  2.) On successful validation, convert JSON to OFBiz's entity model 
> (GenericValue)
>  3.) The GenericValue will be inserted in database by some handler class for 
> e.g we can write JsonDataHandler, it will convert given JSON to 
> List, and finally write it to database (Similar pattern is used 
> in XML import).
>  
> *Export Design*
>  Based on existing XML pattern the writeXmlText method of GenericEntity class 
> write the exported data in XML format. 
>  In the similar way, we can implement writeJsonText to export data in JSON 
> format.
> Please free feel to share your thought.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10959) Enable entity timestamp fields

2019-04-28 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827973#comment-16827973
 ] 

Jacques Le Roux edited comment on OFBIZ-10959 at 4/28/19 12:30 PM:
---

Thanks Pierre,

I guess it was when the type changed from bug to improvements. I agree it's a 
bug and should concern (ie be backported to R17 and R18), as the description 
clearly mention it and the discussion even more clearly explains it.

I just changed all that.


was (Author: jacques.le.roux):
Thanks Pierre,

I guess it was when the type changed from bug to improvements. I agree it's a 
bug and should concern (ie be backported to R17 and R18), as the description 
clearly mention it. 

I just changed all that.

> Enable entity timestamp fields
> --
>
> Key: OFBIZ-10959
> URL: https://issues.apache.org/jira/browse/OFBIZ-10959
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Pawan Verma
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10959.patch, OFBIZ-10959.patch
>
>
> MarkMail link for the discussion: 
> [https://markmail.org/thread/x7paa3ulljns6awh]
>  
> While working on a Production environment, I have found that for some reason 
> entity timestamp fields are disabled at Search Results screen in Trunk and 
> the previous release branch. It is available at View Value screen. It was 
> enabled in Release 16.11.
>  
> These fields are helpful for developers to get the idea about when the row in 
> the entity is created/updated. Extremely helpful while working on the 
> Production environment.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10949) Move display of page title in accounting screens to location above (action) menu(s)

2019-04-28 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-10949:
---

Assignee: Jacques Le Roux  (was: Pierre Smits)

> Move display of page title in  accounting screens to location above 
> (action) menu(s)
> ---
>
> Key: OFBIZ-10949
> URL: https://issues.apache.org/jira/browse/OFBIZ-10949
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: usability
> Attachments: Image 005.png, OFBIZ-10949-accounting.patch, 
> OFBIZ-10949.diff, Screen Shot 2019-04-27 at 11.15.55.png
>
>
> See  [1] and [2] and other accounting party screens. 
> Currently the page title of the screen(s) is shown below the (various) 
> menu(s). In order to improve usability the title of the page should be shown 
> the menu(s).
>  # [https://demo-stable.ofbiz.apache.org/accounting/control/AdminMain]
>  # https://demo-trunk.ofbiz.apache.org/accounting/control/AdminMain



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10949) Move display of page title in accounting screens to location above (action) menu(s)

2019-04-28 Thread Pierre Smits (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-10949:
-
Attachment: OFBIZ-10949.diff

> Move display of page title in  accounting screens to location above 
> (action) menu(s)
> ---
>
> Key: OFBIZ-10949
> URL: https://issues.apache.org/jira/browse/OFBIZ-10949
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: usability
> Attachments: Image 005.png, OFBIZ-10949-accounting.patch, 
> OFBIZ-10949.diff, Screen Shot 2019-04-27 at 11.15.55.png
>
>
> See  [1] and [2] and other accounting party screens. 
> Currently the page title of the screen(s) is shown below the (various) 
> menu(s). In order to improve usability the title of the page should be shown 
> the menu(s).
>  # [https://demo-stable.ofbiz.apache.org/accounting/control/AdminMain]
>  # https://demo-trunk.ofbiz.apache.org/accounting/control/AdminMain



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10952) Add support of applying price rule to the selected options during the configurable product ordering workflow

2019-04-28 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827976#comment-16827976
 ] 

Jacques Le Roux edited comment on OFBIZ-10952 at 4/28/19 12:35 PM:
---

Hi Arun,

Wait, don't we miss the data? I mean when loading them in DB.




was (Author: jacques.le.roux):
Hi Arun,

Wait, don't we miss the data?



> Add support of applying price rule to the selected options during the 
> configurable product ordering workflow
> 
>
> Key: OFBIZ-10952
> URL: https://issues.apache.org/jira/browse/OFBIZ-10952
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Mohammed Rehan Khan
>Priority: Major
>
> Add the support for setting and apply the price rules on a configurable item 
> based on other sets of opted configurable items.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10952) Add support of applying price rule to the selected options during the configurable product ordering workflow

2019-04-28 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827976#comment-16827976
 ] 

Jacques Le Roux commented on OFBIZ-10952:
-

Hi Arun,

Wait, don't we miss the data?



> Add support of applying price rule to the selected options during the 
> configurable product ordering workflow
> 
>
> Key: OFBIZ-10952
> URL: https://issues.apache.org/jira/browse/OFBIZ-10952
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Mohammed Rehan Khan
>Priority: Major
>
> Add the support for setting and apply the price rules on a configurable item 
> based on other sets of opted configurable items.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10949) Move display of page title in accounting screens to location above (action) menu(s)

2019-04-28 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10949:

  Priority: Trivial  (was: Major)
Issue Type: Improvement  (was: Bug)

This is not a major bug but a trivial improvement.

> Move display of page title in  accounting screens to location above 
> (action) menu(s)
> ---
>
> Key: OFBIZ-10949
> URL: https://issues.apache.org/jira/browse/OFBIZ-10949
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Trivial
>  Labels: usability
> Attachments: Image 005.png, OFBIZ-10949-accounting.patch, 
> OFBIZ-10949.diff, Screen Shot 2019-04-27 at 11.15.55.png
>
>
> See  [1] and [2] and other accounting party screens. 
> Currently the page title of the screen(s) is shown below the (various) 
> menu(s). In order to improve usability the title of the page should be shown 
> the menu(s).
>  # [https://demo-stable.ofbiz.apache.org/accounting/control/AdminMain]
>  # https://demo-trunk.ofbiz.apache.org/accounting/control/AdminMain



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10978) Unable to find any product in Quick Add functionality

2019-04-28 Thread vivek singh bisen (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827909#comment-16827909
 ] 

vivek singh bisen commented on OFBIZ-10978:
---

Provided patch. Thanks [~pawan.verma] for the guidance. 

Done following:
1) Added  the template for e-commerce quickAdd.ftl.
2) Improved the grid structure of QuickAddSummary screen.

Please have a look and let me know in case of any concerns.
Thanks in advance !!

> Unable to find any product in Quick Add functionality
> -
>
> Key: OFBIZ-10978
> URL: https://issues.apache.org/jira/browse/OFBIZ-10978
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Padmavati Rawat
>Assignee: vivek singh bisen
>Priority: Major
> Attachments: OFBIZ-10978.patch, Quikadd.png
>
>
> Steps:
> 1. Visit the e-commerce page of the trunk.
> 2. Open Quick Add menu from navbar section.
> https://demo-trunk.ofbiz.apache.org/ecommerce/control/quickadd
> 3. Check the Product list on the screen.
> Actual:
> Quick Add screen rendering an error "Error: Product not found" on the screen.
> Not able to find any option to Quick Add.
> Please, refer screenshot:



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10978) Unable to find any product in Quick Add functionality

2019-04-28 Thread Rishi Solanki (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-10978:
-

Assignee: (was: vivek singh bisen)

> Unable to find any product in Quick Add functionality
> -
>
> Key: OFBIZ-10978
> URL: https://issues.apache.org/jira/browse/OFBIZ-10978
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Padmavati Rawat
>Priority: Major
> Attachments: OFBIZ-10978.patch, Quikadd.png
>
>
> Steps:
> 1. Visit the e-commerce page of the trunk.
> 2. Open Quick Add menu from navbar section.
> https://demo-trunk.ofbiz.apache.org/ecommerce/control/quickadd
> 3. Check the Product list on the screen.
> Actual:
> Quick Add screen rendering an error "Error: Product not found" on the screen.
> Not able to find any option to Quick Add.
> Please, refer screenshot:



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10949) Move display of page title in accounting screens to location above (action) menu(s)

2019-04-28 Thread Pierre Smits (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-10949:


Assignee: Pierre Smits  (was: Jacques Le Roux)

> Move display of page title in  accounting screens to location above 
> (action) menu(s)
> ---
>
> Key: OFBIZ-10949
> URL: https://issues.apache.org/jira/browse/OFBIZ-10949
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Trivial
>  Labels: usability
> Fix For: Upcoming Branch
>
> Attachments: Image 005.png, OFBIZ-10949-accounting.patch, 
> OFBIZ-10949.diff, Screen Shot 2019-04-27 at 11.15.55.png
>
>
> See  [1] and [2] and other accounting party screens. 
> Currently the page title of the screen(s) is shown below the (various) 
> menu(s). In order to improve usability the title of the page should be shown 
> the menu(s).
>  # [https://demo-stable.ofbiz.apache.org/accounting/control/AdminMain]
>  # https://demo-trunk.ofbiz.apache.org/accounting/control/AdminMain



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10949) Move display of page title in accounting screens to location above (action) menu(s)

2019-04-28 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827999#comment-16827999
 ] 

Pierre Smits commented on OFBIZ-10949:
--

Thanks Jacques for you assistance as a committer to get this into the repo.

> Move display of page title in  accounting screens to location above 
> (action) menu(s)
> ---
>
> Key: OFBIZ-10949
> URL: https://issues.apache.org/jira/browse/OFBIZ-10949
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Trivial
>  Labels: usability
> Fix For: Upcoming Branch
>
> Attachments: Image 005.png, OFBIZ-10949-accounting.patch, 
> OFBIZ-10949.diff, Screen Shot 2019-04-27 at 11.15.55.png
>
>
> See  [1] and [2] and other accounting party screens. 
> Currently the page title of the screen(s) is shown below the (various) 
> menu(s). In order to improve usability the title of the page should be shown 
> the menu(s).
>  # [https://demo-stable.ofbiz.apache.org/accounting/control/AdminMain]
>  # https://demo-trunk.ofbiz.apache.org/accounting/control/AdminMain



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10990) Improve the SalesInvoiceItemStarSchema

2019-04-28 Thread Swapnil Shah (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828878#comment-16828878
 ] 

Swapnil Shah commented on OFBIZ-10990:
--

How about renaming Country Dimension as 'Geographic(Geo) Dimension' to make it 
more generic and let there be multiple level underneath it to define 
Country/Region/Territory/States/City etc.as per the sales org structuring. 

 

> Improve the SalesInvoiceItemStarSchema
> --
>
> Key: OFBIZ-10990
> URL: https://issues.apache.org/jira/browse/OFBIZ-10990
> Project: OFBiz
>  Issue Type: Improvement
>  Components: bi
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Pierre Smits
>Priority: Major
>  Labels: birt, dwh
>
> The star schema should be improved to include elements from:
>  * Customer dimension
>  * Country dimension
>  * Store dimension
>  * Catalog dimension
>  * Channel dimension



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10990) Improve the SalesInvoiceItemStarSchema

2019-04-28 Thread Swapnil Shah (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828881#comment-16828881
 ] 

Swapnil Shah commented on OFBIZ-10990:
--

Can we also try to add followng more dimensions as well (if not done already): :
 * *Product Dimesion* - Can help in getting the Brand, Style, Assortments, 
Component level info for different views.
 * *Time Dimension* - can help in getting financial/merchandising calendars 
with Years, Season, quarters, weeks , days etc. for different views. 
 * *Supplier Dimension* - can help in getting Supplier, Vendors or any other 
product sourcing agency info for different views.

> Improve the SalesInvoiceItemStarSchema
> --
>
> Key: OFBIZ-10990
> URL: https://issues.apache.org/jira/browse/OFBIZ-10990
> Project: OFBiz
>  Issue Type: Improvement
>  Components: bi
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Pierre Smits
>Priority: Major
>  Labels: birt, dwh
>
> The star schema should be improved to include elements from:
>  * Customer dimension
>  * Country dimension
>  * Store dimension
>  * Catalog dimension
>  * Channel dimension



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-9533) User should be notified with success message on MRP run in manufacturing component

2019-04-28 Thread Humera Khan (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827565#comment-16827565
 ] 

Humera Khan edited comment on OFBIZ-9533 at 4/29/19 3:57 AM:
-

1. We can not return the success message from executeMrp service because it 
will run in async mode.
2. Also, we can not return the success message from MrpExection screen because 
the same screen will render on another request as well.
3. Hence added a new screen to show the success message on MRP run.

Please review the attached patch.


was (Author: humera.khan):
Please review the attached patch.

> User should be notified with success message on MRP run in manufacturing 
> component
> --
>
> Key: OFBIZ-9533
> URL: https://issues.apache.org/jira/browse/OFBIZ-9533
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Humera Khan
>Priority: Trivial
> Attachments: OFBIZ-9533.patch
>
>
> Steps to regenerate:
> 1. Go to Manufacturing component 
> (https://demo-trunk.ofbiz.apache.org/manufacturing/control/main)
> 2. Click on Mrp sub menu 
> (https://demo-trunk.ofbiz.apache.org/manufacturing/control/FindInventoryEventPlan)
> 3. Click on Run Mrp 
> button.(https://demo-trunk.ofbiz.apache.org/manufacturing/control/RunMrp)
> 4. Select Facility/Facility Group and Click Submit button.
> On success, the user should be notified with success message like "Mrp run is 
> scheduled".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10990) Improve the SalesInvoiceItemStarSchema

2019-04-28 Thread Swapnil Shah (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828881#comment-16828881
 ] 

Swapnil Shah edited comment on OFBIZ-10990 at 4/29/19 3:40 AM:
---

Can we try to add followng more dimensions as well (if not done already): :
 * *Product Dimesion* - Can help in getting the Brand, Style, Assortments, 
Component level info for different views.
 * *Time Dimension* - can help in getting financial/merchandising calendars 
with Years, Season, quarters, weeks , days etc. for different views. 
 * *Supplier Dimension* - can help in getting Supplier, Vendors or any other 
product sourcing agency info for different views.


was (Author: swash78):
Can we also try to add followng more dimensions as well (if not done already): :
 * *Product Dimesion* - Can help in getting the Brand, Style, Assortments, 
Component level info for different views.
 * *Time Dimension* - can help in getting financial/merchandising calendars 
with Years, Season, quarters, weeks , days etc. for different views. 
 * *Supplier Dimension* - can help in getting Supplier, Vendors or any other 
product sourcing agency info for different views.

> Improve the SalesInvoiceItemStarSchema
> --
>
> Key: OFBIZ-10990
> URL: https://issues.apache.org/jira/browse/OFBIZ-10990
> Project: OFBiz
>  Issue Type: Improvement
>  Components: bi
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Pierre Smits
>Priority: Major
>  Labels: birt, dwh
>
> The star schema should be improved to include elements from:
>  * Customer dimension
>  * Country dimension
>  * Store dimension
>  * Catalog dimension
>  * Channel dimension



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)