[jira] [Updated] (OFBIZ-11077) Have a service to load records in the pos terminal dimension

2019-06-02 Thread Pierre Smits (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11077:
-
Attachment: OFBIZ-11077-PosTerminalDimService.diff

> Have a service to load records in the pos terminal dimension
> 
>
> Key: OFBIZ-11077
> URL: https://issues.apache.org/jira/browse/OFBIZ-11077
> Project: OFBiz
>  Issue Type: Improvement
>  Components: bi
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: PosTerminalDimension, birt, dwh, initialisation, pos, 
> service
> Attachments: OFBIZ-11077-PosTerminalDimService.diff
>
>
> For dwh initialisation



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9088) Unit test case for service - addProductCategoryToCategory

2019-06-02 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853948#comment-16853948
 ] 

Jacques Le Roux commented on OFBIZ-9088:


Thanks Yash,

We have decided to move from Minilang to Groovy so, as dicussed in OFBIZ-1463 
we are insure about commiting this (stumbled uopn by chance), I'm still 
wondering about that. Because, even if the logic will still be the same it 
would be a pity to lose the work done because the patches don't apply. Anyway 
discussing this in OFBIZ-1463 is better.

> Unit test case for service - addProductCategoryToCategory
> -
>
> Key: OFBIZ-9088
> URL: https://issues.apache.org/jira/browse/OFBIZ-9088
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Attachments: OFBIZ-9088.patch
>
>
> Unit test case for service - addProductCategoryToCategory



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-11087) Have a service to load records in the project task dimension

2019-06-02 Thread Pierre Smits (JIRA)
Pierre Smits created OFBIZ-11087:


 Summary: Have a service to load records in the project task 
dimension
 Key: OFBIZ-11087
 URL: https://issues.apache.org/jira/browse/OFBIZ-11087
 Project: OFBiz
  Issue Type: Improvement
  Components: bi
Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
Reporter: Pierre Smits
Assignee: Pierre Smits


For dwh initialisation




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components

2019-06-02 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853949#comment-16853949
 ] 

Jacques Le Roux commented on OFBIZ-1463:


I'm still wondering about that. Because, even if the logic will still be the 
same it would be a pity to lose the work done because the patches don't apply 
in future. So it's a bit of more work (patching testing and removing when same 
in Groovy exist) but the tests would be there and used and it could be easier 
to move from Minilang to Groovy once the code is in place in the project. What 
do you think? Anyway I'll start a discussion in dev ML!

> JUnit test case for various application components
> --
>
> Key: OFBIZ-1463
> URL: https://issues.apache.org/jira/browse/OFBIZ-1463
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Vikas Mayur
>Priority: Minor
>
> This is an effort to create JUnit test suites for various bussiness processes 
> in Ofbiz.
> It would be good to have such tests in place so that we can test Ofbiz on a 
> certain day.
> These tests are in initial stage, so I would like community members to post 
> there comments so that we can move
> ahead with them to make these test even better.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11086) Have a ProjectTask Dimension

2019-06-02 Thread Pierre Smits (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11086:
-
Description: The component would benefit from a project task dimension for 
future fact tables and star schema view entities.  (was: The component would 
benefit from a store dimension for future fact tables and star schema view 
entities.)

> Have a ProjectTask Dimension
> 
>
> Key: OFBIZ-11086
> URL: https://issues.apache.org/jira/browse/OFBIZ-11086
> Project: OFBiz
>  Issue Type: Improvement
>  Components: bi
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: ProjectTaskDimension, birt, dimension, dwh
>
> The component would benefit from a project task dimension for future fact 
> tables and star schema view entities.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11073) Have a PoSTerminal Dimension

2019-06-02 Thread Pierre Smits (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11073:
-
Attachment: OFBIZ-11073-PosDimension.patch

> Have a PoSTerminal Dimension
> 
>
> Key: OFBIZ-11073
> URL: https://issues.apache.org/jira/browse/OFBIZ-11073
> Project: OFBiz
>  Issue Type: Improvement
>  Components: bi
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: PosTerminalDimension, birt, dimension, dwh
> Attachments: OFBIZ-11073-PosDimension.patch, 
> OFBIZ-11073-PosDimension.patch
>
>
> The component would benefit from a PoS terminal dimension for future fact 
> tables and star schema view entities.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-9433) The Task.leftShift(Closure) method has been deprecated and is scheduled to be removed in Gradle 5.0. Please use Task.doLast(Action) instead.

2019-06-02 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9433.
--
Resolution: Duplicate

This has been done with OFBIZ-9160 and 
http://svn.apache.org/viewvc?view=revision=1776642

> The Task.leftShift(Closure) method has been deprecated and is scheduled to be 
> removed in Gradle 5.0. Please use Task.doLast(Action) instead.
> 
>
> Key: OFBIZ-9433
> URL: https://issues.apache.org/jira/browse/OFBIZ-9433
> Project: OFBiz
>  Issue Type: Improvement
>  Components: Gradle
>Reporter: Michael Brohl
>Priority: Minor
>
> From the buildbot log:
> {code}
> gradle --stacktrace testIntegration
>  in dir /home/buildslave/slave/ofbiz-branch16/build (timeout 1200 secs)
>  watching logfiles {}
>  argv: ['gradle', '--stacktrace', 'testIntegration']
>  environment:
>   HOME=/home/buildslave
>   JAVA_HOME=/home/buildslave/slave/tools/java/latest1.8
>   LANG=en_US
>   LESSCLOSE=/usr/bin/lesspipe %s %s
>   LESSOPEN=| /usr/bin/lesspipe %s
>   LOGNAME=buildslave
>   
> LS_COLORS=rs=0:di=01;34:ln=01;36:mh=00:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=40;31;01:su=37;41:sg=30;43:ca=30;41:tw=30;42:ow=34;42:st=37;44:ex=01;32:*.tar=01;31:*.tgz=01;31:*.arj=01;31:*.taz=01;31:*.lzh=01;31:*.lzma=01;31:*.tlz=01;31:*.txz=01;31:*.zip=01;31:*.z=01;31:*.Z=01;31:*.dz=01;31:*.gz=01;31:*.lz=01;31:*.xz=01;31:*.bz2=01;31:*.bz=01;31:*.tbz=01;31:*.tbz2=01;31:*.tz=01;31:*.deb=01;31:*.rpm=01;31:*.jar=01;31:*.war=01;31:*.ear=01;31:*.sar=01;31:*.rar=01;31:*.ace=01;31:*.zoo=01;31:*.cpio=01;31:*.7z=01;31:*.rz=01;31:*.jpg=01;35:*.jpeg=01;35:*.gif=01;35:*.bmp=01;35:*.pbm=01;35:*.pgm=01;35:*.ppm=01;35:*.tga=01;35:*.xbm=01;35:*.xpm=01;35:*.tif=01;35:*.tiff=01;35:*.png=01;35:*.svg=01;35:*.svgz=01;35:*.mng=01;35:*.pcx=01;35:*.mov=01;35:*.mpg=01;35:*.mpeg=01;35:*.m2v=01;35:*.mkv=01;35:*.webm=01;35:*.ogm=01;35:*.mp4=01;35:*.m4v=01;35:*.mp4v=01;35:*.vob=01;35:*.qt=01;35:*.nuv=01;35:*.wmv=01;35:*.asf=01;35:*.rm=01;35:*.rmvb=01;35:*.flc=01;35:*.avi=01;35:*.fli=01;35:*.flv=01;35:*.gl=01;35:*.dl=01;35:*.xcf=01;35:*.xwd=01;35:*.yuv=01;35:*.cgm=01;35:*.emf=01;35:*.axv=01;35:*.anx=01;35:*.ogv=01;35:*.ogx=01;35:*.aac=00;36:*.au=00;36:*.flac=00;36:*.mid=00;36:*.midi=00;36:*.mka=00;36:*.mp3=00;36:*.mpc=00;36:*.ogg=00;36:*.ra=00;36:*.wav=00;36:*.axa=00;36:*.oga=00;36:*.spx=00;36:*.xspf=00;36:
>   MAIL=/var/mail/buildslave
>   OLDPWD=/home/buildslave
>   
> PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
>   PWD=/home/buildslave/slave/ofbiz-branch16/build
>   SHELL=/bin/bash
>   SHLVL=2
>   SUDO_COMMAND=/bin/su
>   SUDO_GID=1787
>   SUDO_UID=1787
>   SUDO_USER=markt
>   TERM=xterm-256color
>   USER=buildslave
>   USERNAME=root
>   XDG_RUNTIME_DIR=/run/user/1787
>   XDG_SESSION_ID=30
>   _=/usr/bin/buildslave
>  using PTY: False
> The Task.leftShift(Closure) method has been deprecated and is scheduled to be 
> removed in Gradle 5.0. Please use Task.doLast(Action) instead.
>   at org.gradle.api.internal.AbstractTask.leftShift(AbstractTask.java:513)
>   at org.gradle.api.Task$leftShift.call(Unknown Source)
>   at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
>   at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>   at 
> build_cwx1kqy65zxab9x1zjq0es8g8.run(/home/buildslave/slave/ofbiz-branch16/build/build.gradle:330)
>   at 
> org.gradle.groovy.scripts.internal.DefaultScriptRunnerFactory$ScriptRunnerImpl.run(DefaultScriptRunnerFactory.java:90)
>   at 
> org.gradle.configuration.DefaultScriptPluginFactory$ScriptPluginImpl$2.run(DefaultScriptPluginFactory.java:176)
>   at 
> org.gradle.configuration.ProjectScriptTarget.addConfiguration(ProjectScriptTarget.java:77)
>   at 
> org.gradle.configuration.DefaultScriptPluginFactory$ScriptPluginImpl.apply(DefaultScriptPluginFactory.java:181)
>   at 
> org.gradle.configuration.project.BuildScriptProcessor.execute(BuildScriptProcessor.java:39)
>   at 
> org.gradle.configuration.project.BuildScriptProcessor.execute(BuildScriptProcessor.java:26)
>   at 
> org.gradle.configuration.project.ConfigureActionsProjectEvaluator.evaluate(ConfigureActionsProjectEvaluator.java:34)
>   at 
> org.gradle.configuration.project.LifecycleProjectEvaluator.doConfigure(LifecycleProjectEvaluator.java:70)
>   at 
> org.gradle.configuration.project.LifecycleProjectEvaluator.access$000(LifecycleProjectEvaluator.java:33)
>   at 
> 

[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-06-02 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853947#comment-16853947
 ] 

Jacques Le Roux commented on OFBIZ-10145:
-

I had another even simpler idea. Why bother Infra? We can simply copy the 
OFBiz/gradle/wrapper directory in tools/buildbot/gradle/wrapper and in Buildbot 
copy it back to its place, et voilà.

I have closed  INFRA-18530 with more information there, actually copying it 
here:

bq. I forgot that we have Gradle installed in /usr/lib/gradle/ on 
"lares_ubuntu" , "orcus_ubuntu" , "silvanus_ubuntu"  as says INFRA-13202. 
Actually It's about Gradle to 3.2.1, I guess it's the same for Gradle 5.0.

I'll work on 
https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/ofbiz.conf
 soon...

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, 
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11086) Have a ProjectTask Dimension

2019-06-02 Thread Pierre Smits (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11086:
-
Attachment: OFBIZ-11086-ProjectTaskDimension.diff

> Have a ProjectTask Dimension
> 
>
> Key: OFBIZ-11086
> URL: https://issues.apache.org/jira/browse/OFBIZ-11086
> Project: OFBiz
>  Issue Type: Improvement
>  Components: bi
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: ProjectTaskDimension, birt, dimension, dwh
> Attachments: OFBIZ-11086-ProjectTaskDimension.diff
>
>
> The component would benefit from a project task dimension for future fact 
> tables and star schema view entities.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10895) Unknown request [images]; this request does not exist or cannot be called directly.

2019-06-02 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853967#comment-16853967
 ] 

Jacques Le Roux edited comment on OFBIZ-10895 at 6/2/19 1:14 PM:
-

I was wrong doing massive changes w/o close control. 
I decided to revert the r1859576 and r1859807 commits and to backport the revert

The only safe way to go is to not only check the error log for  "Unknown 
request [" but also to look for 404 in access log, not all requests show 
erroneously in error log. This for all the branches including trunk!

Done in
trunk r1860526  
R18 r1860527
R17 r1860528
R16 r1860529





was (Author: jacques.le.roux):
I was wrong doing massive changes w/o close control. 
I decided to revert the r1859576 and r1859807 commits and to backport the revert

The only safe way to go is to not only check the error log for  "Unknown 
request [" but also to look for 404 in access log, not all request show 
erroneously in error log. This for all the branches including trunk!

Done in
trunk r1860526  
R18 r1860527
R17 r1860528
R16 r1860529




> Unknown request [images]; this request does not exist or cannot be called 
> directly.
> ---
>
> Key: OFBIZ-10895
> URL: https://issues.apache.org/jira/browse/OFBIZ-10895
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, themes
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> This error happens in many occasions:
> Inside another request (here LookupProduct)
> {noformat}
> 2019-03-31 12:32:26,215 |jsse-nio-8443-exec-2 |ControlServlet
> |T| [[[LookupProduct(Domain:https://localhost)] Request Begun, 
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet
> |T| [[[images(Domain:https://localhost)] Request Begun, encoding=[UTF-8]- 
> total:0.0,since last(Begin):0.0]]
> 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet
> |E| Error in request handler:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request 
> [images]; this request does not exist or cannot be called directly.
> at 
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:277)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212) 
> [ofbiz.jar:?]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:645) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) 
> [tomcat-embed-websocket-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
>  [ofbiz.jar:?]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
>  [ofbiz.jar:?]
> at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:200)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> 

[jira] [Commented] (OFBIZ-10895) Unknown request [images]; this request does not exist or cannot be called directly.

2019-06-02 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853967#comment-16853967
 ] 

Jacques Le Roux commented on OFBIZ-10895:
-

I was wrong doing massive changes w/o close control. 
I decided to revert the r1859576 and r1859807 commits and to backport the revert

The only safe way to go is to not only check the error log for  "Unknown 
request [" but also to look for 404 in access log, not all request show 
erroneously in error log. This for all the branches including trunk!

Done in
trunk r1860526  
R18 r1860527
R17 r1860528
R16 r1860529




> Unknown request [images]; this request does not exist or cannot be called 
> directly.
> ---
>
> Key: OFBIZ-10895
> URL: https://issues.apache.org/jira/browse/OFBIZ-10895
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, themes
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> This error happens in many occasions:
> Inside another request (here LookupProduct)
> {noformat}
> 2019-03-31 12:32:26,215 |jsse-nio-8443-exec-2 |ControlServlet
> |T| [[[LookupProduct(Domain:https://localhost)] Request Begun, 
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet
> |T| [[[images(Domain:https://localhost)] Request Begun, encoding=[UTF-8]- 
> total:0.0,since last(Begin):0.0]]
> 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet
> |E| Error in request handler:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request 
> [images]; this request does not exist or cannot be called directly.
> at 
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:277)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212) 
> [ofbiz.jar:?]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:645) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) 
> [tomcat-embed-websocket-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
>  [ofbiz.jar:?]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
>  [ofbiz.jar:?]
> at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:200)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139) 
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) 
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
>