[jira] [Commented] (OFBIZ-11960) Use NPM with gradle to get external JS dependencies

2021-05-17 Thread Aditya Sharma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346195#comment-17346195 ] Aditya Sharma commented on OFBIZ-11960: --- Thanks [~pierresmits] for the heads up. I have updated

[GitHub] [ofbiz-framework] adityasharma7 commented on pull request #230: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

2021-05-17 Thread GitBox
adityasharma7 commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842388591 Hi @JacquesLeRoux, This is done now. Initially, I have added only jQuery, jQuery browser, and Validate plugin through npm. As these are the libraries required for

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #239: Added Spanish Translations

2021-05-17 Thread GitBox
PierreSmits commented on pull request #239: URL: https://github.com/apache/ofbiz-framework/pull/239#issuecomment-842225413 This appears good enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #230: WIP: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

2021-05-17 Thread GitBox
sonarcloud[bot] commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842224378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #209: OFBIZ-11446 Improved: Convert ContentPermissionServices.xml mini lang to groovy

2021-05-17 Thread GitBox
PierreSmits commented on pull request #209: URL: https://github.com/apache/ofbiz-framework/pull/209#issuecomment-842201456 Is this still not good enough to merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [ofbiz-framework] PierreSmits edited a comment on pull request #295: Improvement: label OrderAdjustmentType (OFBIZ-12234)

2021-05-17 Thread GitBox
PierreSmits edited a comment on pull request #295: URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842179560 Jaqcues, The pull request is good enough, and can be merged as such. When committed it will create an opportunity for other contributors to

[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #295: Improvement: label OrderAdjustmentType (OFBIZ-12234)

2021-05-17 Thread GitBox
JacquesLeRoux merged pull request #295: URL: https://github.com/apache/ofbiz-framework/pull/295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [ofbiz-framework] adityasharma7 commented on pull request #230: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

2021-05-17 Thread GitBox
adityasharma7 commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842388591 Hi @JacquesLeRoux, This is done now. Initially, I have added only jQuery, jQuery browser, and Validate plugin through npm. As these are the libraries required for

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #283: OFBIZ-11683 Fixed: Humanres tree allows existing OU to be added again

2021-05-17 Thread GitBox
PierreSmits commented on pull request #283: URL: https://github.com/apache/ofbiz-framework/pull/283#issuecomment-842198387 Hi Sebastian, all, We should not regard departments as internal organisations (we should reserve that for fiscal/legal entities, requiring their own CoAs).

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #230: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

2021-05-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842224378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #295: Improvement: label OrderAdjustmentType (OFBIZ-12234)

2021-05-17 Thread GitBox
JacquesLeRoux commented on pull request #295: URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-841796683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #295: Improvement: label OrderAdjustmentType (OFBIZ-12234)

2021-05-17 Thread GitBox
JacquesLeRoux edited a comment on pull request #295: URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-841796683 Hi Pierre, Would you mind adding `TVA` in your forked repo and then update this PR? TIA :) -- This is an automated message from the

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #295: Improvement: label OrderAdjustmentType (OFBIZ-12234)

2021-05-17 Thread GitBox
PierreSmits commented on pull request #295: URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842179560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (OFBIZ-11960) Use NPM with gradle to get external JS dependencies

2021-05-17 Thread Aditya Sharma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-11960: -- Description: As discussed

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #230: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

2021-05-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842224378 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=230=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #230: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

2021-05-17 Thread GitBox
sonarcloud[bot] commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842384525 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=230=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #230: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

2021-05-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842384525 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=230=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #230: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

2021-05-17 Thread GitBox
sonarcloud[bot] commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842389591 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=230=false=BUG)

[GitHub] [ofbiz-framework] PierreSmits edited a comment on pull request #295: Improvement: label OrderAdjustmentType (OFBIZ-12234)

2021-05-17 Thread GitBox
PierreSmits edited a comment on pull request #295: URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842179560 Jaqcues, The pull request is good enough, and can be merged as such. When committed it will create an opportunity for other contributors to

[jira] [Commented] (OFBIZ-11960) Use NPM with gradle to get external JS dependencies

2021-05-17 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346075#comment-17346075 ] Pierre Smits commented on OFBIZ-11960: -- Hi Aditya, What is the rationale behind wanting this in

[jira] [Created] (OFBIZ-12241) Improve EuroCustomer data

2021-05-17 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12241: Summary: Improve EuroCustomer data Key: OFBIZ-12241 URL: https://issues.apache.org/jira/browse/OFBIZ-12241 Project: OFBiz Issue Type: Improvement

[jira] [Assigned] (OFBIZ-12241) Improve EuroCustomer data

2021-05-17 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reassigned OFBIZ-12241: Assignee: Pierre Smits > Improve EuroCustomer data > - > >

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #295: Improvement: label OrderAdjustmentType (OFBIZ-12234)

2021-05-17 Thread GitBox
PierreSmits commented on pull request #295: URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842214368 Yeah. Let's not bother with trivial work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Assigned] (OFBIZ-12233) Plugin not showing in menu due to permission

2021-05-17 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-12233: --- Assignee: Jacques Le Roux > Plugin not showing in menu due to permission >

[jira] [Closed] (OFBIZ-12233) Plugin not showing in menu due to permission

2021-05-17 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12233. --- Fix Version/s: Release Branch 17.12 18.12.01 Resolution: Fixed >

[jira] [Commented] (OFBIZ-12233) Plugin not showing in menu due to permission

2021-05-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346037#comment-17346037 ] ASF subversion and git services commented on OFBIZ-12233: - Commit

[jira] [Commented] (OFBIZ-12233) Plugin not showing in menu due to permission

2021-05-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346036#comment-17346036 ] ASF subversion and git services commented on OFBIZ-12233: - Commit

[jira] [Commented] (OFBIZ-12233) Plugin not showing in menu due to permission

2021-05-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346035#comment-17346035 ] ASF subversion and git services commented on OFBIZ-12233: - Commit

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #295: Improvement: label OrderAdjustmentType (OFBIZ-12234)

2021-05-17 Thread GitBox
JacquesLeRoux commented on pull request #295: URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842213276 Oh, too bad, it's impossible to me to add the change in your forked repo. I can merge/push as is but then I need to redo the trivial work again locally and commit

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #295: Improvement: label OrderAdjustmentType (OFBIZ-12234)

2021-05-17 Thread GitBox
PierreSmits commented on pull request #295: URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842179560 Jaqcues, The pull request is good enough, and can be committed as such. When committed it will create an opportunity for other contributors to enhance

[jira] [Updated] (OFBIZ-12234) Have a entity label for OrderAdjustmentType.description.VAT_TAX

2021-05-17 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-12234: - Fix Version/s: Trunk > Have a entity label for OrderAdjustmentType.description.VAT_TAX >

[jira] [Closed] (OFBIZ-12234) Have a entity label for OrderAdjustmentType.description.VAT_TAX

2021-05-17 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits closed OFBIZ-12234. Resolution: Implemented > Have a entity label for OrderAdjustmentType.description.VAT_TAX >

[jira] [Assigned] (OFBIZ-12234) Have a entity label for OrderAdjustmentType.description.VAT_TAX

2021-05-17 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reassigned OFBIZ-12234: Assignee: Pierre Smits > Have a entity label for OrderAdjustmentType.description.VAT_TAX

[jira] [Commented] (OFBIZ-12233) Plugin not showing in menu due to permission

2021-05-17 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346040#comment-17346040 ] Jacques Le Roux commented on OFBIZ-12233: - I wanted to assign to Gaetan, but it's impossible (no

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #295: Improvement: label OrderAdjustmentType (OFBIZ-12234)

2021-05-17 Thread GitBox
PierreSmits commented on pull request #295: URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842215549 You don't have to do everything yourself, Jacques. Don't deprive other contributors of the opportunity. :smile: -- This is an automated message from the Apache Git

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #230: WIP: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

2021-05-17 Thread GitBox
sonarcloud[bot] commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842224378 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=230=false=BUG)

[jira] [Commented] (OFBIZ-12234) Have a entity label for OrderAdjustmentType.description.VAT_TAX

2021-05-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346093#comment-17346093 ] ASF subversion and git services commented on OFBIZ-12234: - Commit

[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #295: Improvement: label OrderAdjustmentType (OFBIZ-12234)

2021-05-17 Thread GitBox
JacquesLeRoux merged pull request #295: URL: https://github.com/apache/ofbiz-framework/pull/295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Created] (OFBIZ-12240) Correct translation for OrderAdjustmentType is not show in order

2021-05-17 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12240: Summary: Correct translation for OrderAdjustmentType is not show in order Key: OFBIZ-12240 URL: https://issues.apache.org/jira/browse/OFBIZ-12240 Project: OFBiz

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #209: OFBIZ-11446 Improved: Convert ContentPermissionServices.xml mini lang to groovy

2021-05-17 Thread GitBox
PierreSmits commented on pull request #209: URL: https://github.com/apache/ofbiz-framework/pull/209#issuecomment-842201456 Is this still not good enough to merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #239: Added Spanish Translations

2021-05-17 Thread GitBox
PierreSmits commented on pull request #239: URL: https://github.com/apache/ofbiz-framework/pull/239#issuecomment-842225413 This appears good enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #283: OFBIZ-11683 Fixed: Humanres tree allows existing OU to be added again

2021-05-17 Thread GitBox
PierreSmits commented on pull request #283: URL: https://github.com/apache/ofbiz-framework/pull/283#issuecomment-842198387 Hi Sebastian, all, We should not regard departments as internal organisations (we should reserve that for fiscal/legal entities, requiring their own CoAs).

[jira] [Updated] (OFBIZ-12240) Correct translation for OrderAdjustmentType is not shown in order

2021-05-17 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-12240: - Summary: Correct translation for OrderAdjustmentType is not shown in order (was: Correct