[
https://issues.apache.org/jira/browse/OFBIZ-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346195#comment-17346195
]
Aditya Sharma commented on OFBIZ-11960:
---
Thanks [~pierresmits] for the heads up. I have updated
adityasharma7 commented on pull request #230:
URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842388591
Hi @JacquesLeRoux,
This is done now. Initially, I have added only jQuery, jQuery browser, and
Validate plugin through npm. As these are the libraries required for
PierreSmits commented on pull request #239:
URL: https://github.com/apache/ofbiz-framework/pull/239#issuecomment-842225413
This appears good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
sonarcloud[bot] commented on pull request #230:
URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842224378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
PierreSmits commented on pull request #209:
URL: https://github.com/apache/ofbiz-framework/pull/209#issuecomment-842201456
Is this still not good enough to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
PierreSmits edited a comment on pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842179560
Jaqcues,
The pull request is good enough, and can be merged as such.
When committed it will create an opportunity for other contributors to
JacquesLeRoux merged pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
adityasharma7 commented on pull request #230:
URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842388591
Hi @JacquesLeRoux,
This is done now. Initially, I have added only jQuery, jQuery browser, and
Validate plugin through npm. As these are the libraries required for
PierreSmits commented on pull request #283:
URL: https://github.com/apache/ofbiz-framework/pull/283#issuecomment-842198387
Hi Sebastian, all,
We should not regard departments as internal organisations (we should
reserve that for fiscal/legal entities, requiring their own CoAs).
sonarcloud[bot] removed a comment on pull request #230:
URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842224378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
JacquesLeRoux commented on pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-841796683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
JacquesLeRoux edited a comment on pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-841796683
Hi Pierre,
Would you mind adding
`TVA`
in your forked repo and then update this PR? TIA :)
--
This is an automated message from the
PierreSmits commented on pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842179560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/OFBIZ-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Sharma updated OFBIZ-11960:
--
Description:
As discussed
sonarcloud[bot] removed a comment on pull request #230:
URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842224378
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=230=false=BUG)
sonarcloud[bot] commented on pull request #230:
URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842384525
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=230=false=BUG)
sonarcloud[bot] removed a comment on pull request #230:
URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842384525
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=230=false=BUG)
sonarcloud[bot] commented on pull request #230:
URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842389591
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=230=false=BUG)
PierreSmits edited a comment on pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842179560
Jaqcues,
The pull request is good enough, and can be merged as such.
When committed it will create an opportunity for other contributors to
[
https://issues.apache.org/jira/browse/OFBIZ-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346075#comment-17346075
]
Pierre Smits commented on OFBIZ-11960:
--
Hi Aditya,
What is the rationale behind wanting this in
Pierre Smits created OFBIZ-12241:
Summary: Improve EuroCustomer data
Key: OFBIZ-12241
URL: https://issues.apache.org/jira/browse/OFBIZ-12241
Project: OFBiz
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/OFBIZ-12241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits reassigned OFBIZ-12241:
Assignee: Pierre Smits
> Improve EuroCustomer data
> -
>
>
PierreSmits commented on pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842214368
Yeah. Let's not bother with trivial work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reassigned OFBIZ-12233:
---
Assignee: Jacques Le Roux
> Plugin not showing in menu due to permission
>
[
https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-12233.
---
Fix Version/s: Release Branch 17.12
18.12.01
Resolution: Fixed
>
[
https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346037#comment-17346037
]
ASF subversion and git services commented on OFBIZ-12233:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346036#comment-17346036
]
ASF subversion and git services commented on OFBIZ-12233:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346035#comment-17346035
]
ASF subversion and git services commented on OFBIZ-12233:
-
Commit
JacquesLeRoux commented on pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842213276
Oh, too bad, it's impossible to me to add the change in your forked repo. I
can merge/push as is but then I need to redo the trivial work again locally and
commit
PierreSmits commented on pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842179560
Jaqcues,
The pull request is good enough, and can be committed as such.
When committed it will create an opportunity for other contributors to
enhance
[
https://issues.apache.org/jira/browse/OFBIZ-12234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits updated OFBIZ-12234:
-
Fix Version/s: Trunk
> Have a entity label for OrderAdjustmentType.description.VAT_TAX
>
[
https://issues.apache.org/jira/browse/OFBIZ-12234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits closed OFBIZ-12234.
Resolution: Implemented
> Have a entity label for OrderAdjustmentType.description.VAT_TAX
>
[
https://issues.apache.org/jira/browse/OFBIZ-12234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits reassigned OFBIZ-12234:
Assignee: Pierre Smits
> Have a entity label for OrderAdjustmentType.description.VAT_TAX
[
https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346040#comment-17346040
]
Jacques Le Roux commented on OFBIZ-12233:
-
I wanted to assign to Gaetan, but it's impossible (no
PierreSmits commented on pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295#issuecomment-842215549
You don't have to do everything yourself, Jacques. Don't deprive other
contributors of the opportunity. :smile:
--
This is an automated message from the Apache Git
sonarcloud[bot] commented on pull request #230:
URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-842224378
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=230=false=BUG)
[
https://issues.apache.org/jira/browse/OFBIZ-12234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346093#comment-17346093
]
ASF subversion and git services commented on OFBIZ-12234:
-
Commit
JacquesLeRoux merged pull request #295:
URL: https://github.com/apache/ofbiz-framework/pull/295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
Pierre Smits created OFBIZ-12240:
Summary: Correct translation for OrderAdjustmentType is not show
in order
Key: OFBIZ-12240
URL: https://issues.apache.org/jira/browse/OFBIZ-12240
Project: OFBiz
PierreSmits commented on pull request #209:
URL: https://github.com/apache/ofbiz-framework/pull/209#issuecomment-842201456
Is this still not good enough to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
PierreSmits commented on pull request #239:
URL: https://github.com/apache/ofbiz-framework/pull/239#issuecomment-842225413
This appears good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
PierreSmits commented on pull request #283:
URL: https://github.com/apache/ofbiz-framework/pull/283#issuecomment-842198387
Hi Sebastian, all,
We should not regard departments as internal organisations (we should
reserve that for fiscal/legal entities, requiring their own CoAs).
[
https://issues.apache.org/jira/browse/OFBIZ-12240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits updated OFBIZ-12240:
-
Summary: Correct translation for OrderAdjustmentType is not shown in order
(was: Correct
43 matches
Mail list logo