[jira] [Commented] (OFBIZ-8154) The entity description labels are considered not used by the Label Manager

2016-09-15 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495480#comment-15495480
 ] 

Jacques Le Roux commented on OFBIZ-8154:


It's a pity, because of the translations, but the labels starting by 
"HumanResServices.", which dates from pre Apache era, are not used OOTB, so I 
removed them 
.portalPageName. is used by demo data
ProductStoreGroup.productStoreGroupName.NA is used as data by 
ProductTypeData.xml
FormFieldTitle_timesheetPartyId in ProjectMgrUiLabels.xml seems an error. As it 
duplicates the same in AccountingUiLabels.xml, which is accurate, I remove it 
from ProjectMgrUiLabels

Committed at revision: 1760995  

We have now only 1838 (instead of 5237 initially) "Not Used Labels". 
Still to consider: the labels following WorkEffortWorkEffortIdEmpty in the list 
returned by the "Not Used Labels" options

> The entity description labels are considered not used by the Label Manager
> --
>
> Key: OFBIZ-8154
> URL: https://issues.apache.org/jira/browse/OFBIZ-8154
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> As I said in my r1759457 commit comment:
> bq. We have 5237 "Not Used Labels". I wondered if they were all real, I just 
> checked some an indeed, they were not used.  But there are also a huge bunch 
> of *.description.* labels which certainly make sense. I'll remove them from 
> the "Only Not Used Labels" result in another Jira I'll create
> Here is the promised Jira



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7957) RateAmount is not found when the level is 'WorkEffort'

2016-09-15 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495421#comment-15495421
 ] 

Jacques Le Roux commented on OFBIZ-7957:


HI Florian, I did not test your patch, but after review I think it's a good 
idea to proceed this way. Taher suggested SECAs, but I think it was more in a 
general way and I agree with what he said. In this case it's only about 
workeffort-rate-amouts so the domain is "siloed" and it's OK to use services 
called by services.

If nobody disagree I'll commit your patch soon.

> RateAmount is not found when the level is 'WorkEffort'
> --
>
> Key: OFBIZ-7957
> URL: https://issues.apache.org/jira/browse/OFBIZ-7957
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>  Labels: accounting, level, rate, rateAmount, workeffort
> Attachments: OFBIZ-7957.patch
>
>
> When you create a RateAmount, you can determine for which WorkEffort it 
> should apply. But when this RateAmount is retrieved for a specific 
> WorkEffort, it fails to find the good RateAmount.
> The problem comes from the check done to retrieve the RateAmount at a 
> WorkEffort level. This is the used check : 
> {code}
> 
>  from-field="parameters.rateTypeId"/>
>  from-field="parameters.partyId"/>
>  from-field="parameters.workEffortId"/>
>  from-field="parameters.periodTypeId"/>
>  from-field="parameters.rateCurrencyUomId"/>
> 
>  
> {code}
> In this 'entity-and', the partyId is set as a constraint. But it is possible 
> to enable a special RateAmount only for a WorkEffort without regarding the 
> partyId.
> I think we have 2 options here :
> - Remove the partyId constraint but then the retrieving may be less accurate
> - Make the retrieving more accurate by checking first the WorkEffort, then 
> from the retrieved list, check if the partyId matches and finally from this 
> second retrieval, check if the emplPositionTypeId match. At the end, we would 
> have the most accurate RateAmount.
> What do you think of it ?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8114) The "Only Not Used Labels" option of the Label Manager is broken

2016-09-15 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494291#comment-15494291
 ] 

Jacques Le Roux commented on OFBIZ-8114:


This is a pain to backport, even in R15.12, so I'll not

BTW at r1759573 I removed webtools.properties


> The "Only Not Used Labels" option of the Label Manager is broken
> 
>
> Key: OFBIZ-8114
> URL: https://issues.apache.org/jira/browse/OFBIZ-8114
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
>
> This is due to the introduction of ServiceUtil.getResource() at r1757979 for 
> OFBIZ-7912



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7972) Create a (PoC) plugin system for OFBiz based on Gradle

2016-09-15 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493045#comment-15493045
 ] 

Taher Alkhateeb commented on OFBIZ-7972:


First commit in r1760917 with minor modifications and fixing of typos.

> Create a (PoC) plugin system for OFBiz based on Gradle
> --
>
> Key: OFBIZ-7972
> URL: https://issues.apache.org/jira/browse/OFBIZ-7972
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>Priority: Minor
>  Labels: plugin, proof-of-concept, system
> Attachments: OFBIZ-7972.patch, OFBIZ-7972.patch, OFBIZ-7972.patch
>
>
> This JIRA houses the attempt to create a plugin system for OFBiz based on 
> gradle. The plugin system should have the following features:
> - It is independent of the version control system, file system, operating 
> system and any other environment tools surrounding OFBiz. Instead, it should 
> be fully integrated with OFBiz.
> - It should unify the way OFBiz is extended, both for official supported 
> plugins and for third party plugins
> - The plugin system takes advantage of the concept of a "component" in OFBiz 
> and utilize it as the building block for plugins
> - The plugin system supports the concepts of "Repository" and "Dependency 
> Management". If possible, the plugin system will utilize these concepts 
> directly from Gradle instead of writing them from scratch.
> The initial API for the plugin system will be small and expands as needed. 
> The API should include the following gradle tasks:
> - createPlugin: creates a new plugin based on templates and place it in the 
> plugins directory
> - installPlugin: Activate a plugin and run Install. Plugin must exist in 
> /specialpurpose
> - uninstallPlugin: Deactivate a plugin and run its uninstall script
> - publishPlugin: publish a plugin to local maven repository
> - pullPlugin: download a plugin with its dependencies (plugins) from a 
> repository and install them



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state

2016-09-15 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492863#comment-15492863
 ] 

Jacques Le Roux commented on OFBIZ-8156:


SInce there are 2 parts, maybe we could rename this Jira remove and add a link 
to another Jira where the new stuff would be put in. Unfotunately Jira does not 
allow more than 1 level for subtasks. Else we could also have an umbrella 
subtask named disentangle which would group the 2 others.

> Disentangle Fedex solution from current integrated state
> 
>
> Key: OFBIZ-8156
> URL: https://issues.apache.org/jira/browse/OFBIZ-8156
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext, datamodel, order, product, 
> specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Minor
>  Labels: 3rdParty, integration, shipment
> Attachments: OFBIZ-8156-FedexRemoval.patch
>
>
> Disentanglement of the 3rd party shipment integration for FedEx gives the 
> OFBiz adopter more flexibility, reduces the default code base and offers the 
> project more opportunities with respect to attracting product specific 
> contributors, better code and faster release cycles.
> Requirements of the disentangled solution:
> * should not need a separate entity to capture configuration elements
> * configuration should be contained in the component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8156) Disentangle Fedex solution from current integrated state

2016-09-15 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-8156.
---
Resolution: Works for Me
  Assignee: Pierre Smits

> Disentangle Fedex solution from current integrated state
> 
>
> Key: OFBIZ-8156
> URL: https://issues.apache.org/jira/browse/OFBIZ-8156
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext, datamodel, order, product, 
> specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Minor
>  Labels: 3rdParty, integration, shipment
> Attachments: OFBIZ-8156-FedexRemoval.patch
>
>
> Disentanglement of the 3rd party shipment integration for FedEx gives the 
> OFBiz adopter more flexibility, reduces the default code base and offers the 
> project more opportunities with respect to attracting product specific 
> contributors, better code and faster release cycles.
> Requirements of the disentangled solution:
> * should not need a separate entity to capture configuration elements
> * configuration should be contained in the component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state

2016-09-15 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492832#comment-15492832
 ] 

Taher Alkhateeb commented on OFBIZ-8156:


Oh and for completeness, this is an area ripe for good refactoring, we can 
perhaps remove ALL shipment methods outside the framework into specialized 
plugins. So we can move Fedex, USPS, UPS and DHL each as a separate OFBiz 
plugin that hides away the implementation details. This, in my opinion, is a 
much cleaner and more modular approach that allows thriving and even adding 
more shipment methods without complexity at the framework level.

> Disentangle Fedex solution from current integrated state
> 
>
> Key: OFBIZ-8156
> URL: https://issues.apache.org/jira/browse/OFBIZ-8156
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext, datamodel, order, product, 
> specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Minor
>  Labels: 3rdParty, integration, shipment
> Attachments: OFBIZ-8156-FedexRemoval.patch
>
>
> Disentanglement of the 3rd party shipment integration for FedEx gives the 
> OFBiz adopter more flexibility, reduces the default code base and offers the 
> project more opportunities with respect to attracting product specific 
> contributors, better code and faster release cycles.
> Requirements of the disentangled solution:
> * should not need a separate entity to capture configuration elements
> * configuration should be contained in the component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state

2016-09-15 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492834#comment-15492834
 ] 

Pierre Smits commented on OFBIZ-8156:
-

I will help you both with this issue.

> Disentangle Fedex solution from current integrated state
> 
>
> Key: OFBIZ-8156
> URL: https://issues.apache.org/jira/browse/OFBIZ-8156
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext, datamodel, order, product, 
> specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Minor
>  Labels: 3rdParty, integration, shipment
> Attachments: OFBIZ-8156-FedexRemoval.patch
>
>
> Disentanglement of the 3rd party shipment integration for FedEx gives the 
> OFBiz adopter more flexibility, reduces the default code base and offers the 
> project more opportunities with respect to attracting product specific 
> contributors, better code and faster release cycles.
> Requirements of the disentangled solution:
> * should not need a separate entity to capture configuration elements
> * configuration should be contained in the component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state

2016-09-15 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492823#comment-15492823
 ] 

Taher Alkhateeb commented on OFBIZ-8156:


I gave you an explanation below of the meaning of the word, so I won't repeat 
myself here.

Now, with respect to the comments above, what I can see is that the API for 
fedex is deprecated, but the bulk of your patch is removing settings, labels 
and standard services.

In my opinion, this is not a clean approach, and a redesign should be favoured 
over blunt removal. the parts that are deprecated can be removed (I still need 
to study the code, but I think most of it is not related) and other parts need 
to be refactored.

> Disentangle Fedex solution from current integrated state
> 
>
> Key: OFBIZ-8156
> URL: https://issues.apache.org/jira/browse/OFBIZ-8156
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext, datamodel, order, product, 
> specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Minor
>  Labels: 3rdParty, integration, shipment
> Attachments: OFBIZ-8156-FedexRemoval.patch
>
>
> Disentanglement of the 3rd party shipment integration for FedEx gives the 
> OFBiz adopter more flexibility, reduces the default code base and offers the 
> project more opportunities with respect to attracting product specific 
> contributors, better code and faster release cycles.
> Requirements of the disentangled solution:
> * should not need a separate entity to capture configuration elements
> * configuration should be contained in the component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (OFBIZ-8156) Disentangle Fedex solution from current integrated state

2016-09-15 Thread Michael Brohl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-8156:
-
Comment: was deleted

(was: Neither do I.)

> Disentangle Fedex solution from current integrated state
> 
>
> Key: OFBIZ-8156
> URL: https://issues.apache.org/jira/browse/OFBIZ-8156
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext, datamodel, order, product, 
> specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Minor
>  Labels: 3rdParty, integration, shipment
> Attachments: OFBIZ-8156-FedexRemoval.patch
>
>
> Disentanglement of the 3rd party shipment integration for FedEx gives the 
> OFBiz adopter more flexibility, reduces the default code base and offers the 
> project more opportunities with respect to attracting product specific 
> contributors, better code and faster release cycles.
> Requirements of the disentangled solution:
> * should not need a separate entity to capture configuration elements
> * configuration should be contained in the component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state

2016-09-15 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492775#comment-15492775
 ] 

Michael Brohl commented on OFBIZ-8156:
--

Neither do I.

> Disentangle Fedex solution from current integrated state
> 
>
> Key: OFBIZ-8156
> URL: https://issues.apache.org/jira/browse/OFBIZ-8156
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext, datamodel, order, product, 
> specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Minor
>  Labels: 3rdParty, integration, shipment
> Attachments: OFBIZ-8156-FedexRemoval.patch
>
>
> Disentanglement of the 3rd party shipment integration for FedEx gives the 
> OFBiz adopter more flexibility, reduces the default code base and offers the 
> project more opportunities with respect to attracting product specific 
> contributors, better code and faster release cycles.
> Requirements of the disentangled solution:
> * should not need a separate entity to capture configuration elements
> * configuration should be contained in the component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state

2016-09-15 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492776#comment-15492776
 ] 

Michael Brohl commented on OFBIZ-8156:
--

Neither do I.

> Disentangle Fedex solution from current integrated state
> 
>
> Key: OFBIZ-8156
> URL: https://issues.apache.org/jira/browse/OFBIZ-8156
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext, datamodel, order, product, 
> specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Minor
>  Labels: 3rdParty, integration, shipment
> Attachments: OFBIZ-8156-FedexRemoval.patch
>
>
> Disentanglement of the 3rd party shipment integration for FedEx gives the 
> OFBiz adopter more flexibility, reduces the default code base and offers the 
> project more opportunities with respect to attracting product specific 
> contributors, better code and faster release cycles.
> Requirements of the disentangled solution:
> * should not need a separate entity to capture configuration elements
> * configuration should be contained in the component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-8156) Disentangle Fedex solution from current integrated state

2016-09-15 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492727#comment-15492727
 ] 

Pierre Smits edited comment on OFBIZ-8156 at 9/15/16 8:44 AM:
--

Disentangle or remove is the same to me.
And of an even lower priority than the setting of this issue. 

But feel free to scratch that itch yourself. I am not working this issue.


was (Author: pfm.smits):
I am not working this issue.

> Disentangle Fedex solution from current integrated state
> 
>
> Key: OFBIZ-8156
> URL: https://issues.apache.org/jira/browse/OFBIZ-8156
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext, datamodel, order, product, 
> specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Minor
>  Labels: 3rdParty, integration, shipment
> Attachments: OFBIZ-8156-FedexRemoval.patch
>
>
> Disentanglement of the 3rd party shipment integration for FedEx gives the 
> OFBiz adopter more flexibility, reduces the default code base and offers the 
> project more opportunities with respect to attracting product specific 
> contributors, better code and faster release cycles.
> Requirements of the disentangled solution:
> * should not need a separate entity to capture configuration elements
> * configuration should be contained in the component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state

2016-09-15 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492727#comment-15492727
 ] 

Pierre Smits commented on OFBIZ-8156:
-

I am not working this issue.

> Disentangle Fedex solution from current integrated state
> 
>
> Key: OFBIZ-8156
> URL: https://issues.apache.org/jira/browse/OFBIZ-8156
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext, datamodel, order, product, 
> specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Minor
>  Labels: 3rdParty, integration, shipment
> Attachments: OFBIZ-8156-FedexRemoval.patch
>
>
> Disentanglement of the 3rd party shipment integration for FedEx gives the 
> OFBiz adopter more flexibility, reduces the default code base and offers the 
> project more opportunities with respect to attracting product specific 
> contributors, better code and faster release cycles.
> Requirements of the disentangled solution:
> * should not need a separate entity to capture configuration elements
> * configuration should be contained in the component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state

2016-09-15 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492720#comment-15492720
 ] 

Michael Brohl commented on OFBIZ-8156:
--

The issue title and also some of your comments for a 2nd part are a bit 
misleading. I'd recommend to change the issue to "Remove Fedex solution" to 
make this clear. 

I had a look at the past discussions and agree that the non-working solution 
should be removed.

> Disentangle Fedex solution from current integrated state
> 
>
> Key: OFBIZ-8156
> URL: https://issues.apache.org/jira/browse/OFBIZ-8156
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext, datamodel, order, product, 
> specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Minor
>  Labels: 3rdParty, integration, shipment
> Attachments: OFBIZ-8156-FedexRemoval.patch
>
>
> Disentanglement of the 3rd party shipment integration for FedEx gives the 
> OFBiz adopter more flexibility, reduces the default code base and offers the 
> project more opportunities with respect to attracting product specific 
> contributors, better code and faster release cycles.
> Requirements of the disentangled solution:
> * should not need a separate entity to capture configuration elements
> * configuration should be contained in the component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-8156) Disentangle Fedex solution from current integrated state

2016-09-15 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15476061#comment-15476061
 ] 

Pierre Smits edited comment on OFBIZ-8156 at 9/15/16 7:50 AM:
--

There isn't clarity within the project about where to move it too. But the code 
has to get out of where it is now. So this is just a part.

Furthermore, I doubt whether the code is even working. Last insightful 
references in MLs were around 2012 and these weren't compliments, and the 
reactions from community members didn't make me have faith.


was (Author: pfm.smits):
There isn't clarity within the project about where to move it too. But the code 
has to get out of where it is now. So this is just a part.

Furthermore, I doubt whether the code is even working. Last insightful 
references in MLs were around 2012 and these weren't complements, and the 
reactions from community members didn't make me have faith.

> Disentangle Fedex solution from current integrated state
> 
>
> Key: OFBIZ-8156
> URL: https://issues.apache.org/jira/browse/OFBIZ-8156
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext, datamodel, order, product, 
> specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Minor
>  Labels: 3rdParty, integration, shipment
> Attachments: OFBIZ-8156-FedexRemoval.patch
>
>
> Disentanglement of the 3rd party shipment integration for FedEx gives the 
> OFBiz adopter more flexibility, reduces the default code base and offers the 
> project more opportunities with respect to attracting product specific 
> contributors, better code and faster release cycles.
> Requirements of the disentangled solution:
> * should not need a separate entity to capture configuration elements
> * configuration should be contained in the component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7972) Create a (PoC) plugin system for OFBiz based on Gradle

2016-09-15 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492626#comment-15492626
 ] 

Michael Brohl commented on OFBIZ-7972:
--

That would be ok from a developers view, but maybe the users are more familiar 
with something like downloadPlugin and uploadPlugin?

> Create a (PoC) plugin system for OFBiz based on Gradle
> --
>
> Key: OFBIZ-7972
> URL: https://issues.apache.org/jira/browse/OFBIZ-7972
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>Priority: Minor
>  Labels: plugin, proof-of-concept, system
> Attachments: OFBIZ-7972.patch, OFBIZ-7972.patch, OFBIZ-7972.patch
>
>
> This JIRA houses the attempt to create a plugin system for OFBiz based on 
> gradle. The plugin system should have the following features:
> - It is independent of the version control system, file system, operating 
> system and any other environment tools surrounding OFBiz. Instead, it should 
> be fully integrated with OFBiz.
> - It should unify the way OFBiz is extended, both for official supported 
> plugins and for third party plugins
> - The plugin system takes advantage of the concept of a "component" in OFBiz 
> and utilize it as the building block for plugins
> - The plugin system supports the concepts of "Repository" and "Dependency 
> Management". If possible, the plugin system will utilize these concepts 
> directly from Gradle instead of writing them from scratch.
> The initial API for the plugin system will be small and expands as needed. 
> The API should include the following gradle tasks:
> - createPlugin: creates a new plugin based on templates and place it in the 
> plugins directory
> - installPlugin: Activate a plugin and run Install. Plugin must exist in 
> /specialpurpose
> - uninstallPlugin: Deactivate a plugin and run its uninstall script
> - publishPlugin: publish a plugin to local maven repository
> - pullPlugin: download a plugin with its dependencies (plugins) from a 
> repository and install them



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state

2016-09-15 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492623#comment-15492623
 ] 

Michael Brohl commented on OFBIZ-8156:
--

I think we should wait for the 2nd part for the whole picture before taking any 
action here.

> Disentangle Fedex solution from current integrated state
> 
>
> Key: OFBIZ-8156
> URL: https://issues.apache.org/jira/browse/OFBIZ-8156
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext, datamodel, order, product, 
> specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Minor
>  Labels: 3rdParty, integration, shipment
> Attachments: OFBIZ-8156-FedexRemoval.patch
>
>
> Disentanglement of the 3rd party shipment integration for FedEx gives the 
> OFBiz adopter more flexibility, reduces the default code base and offers the 
> project more opportunities with respect to attracting product specific 
> contributors, better code and faster release cycles.
> Requirements of the disentangled solution:
> * should not need a separate entity to capture configuration elements
> * configuration should be contained in the component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6941) Layered-Modal link type doesn't work with parameters

2016-09-15 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492612#comment-15492612
 ] 

Pierre Smits commented on OFBIZ-6941:
-

I am still experiencing this issue in r15.12. Should we reopen? Or create a new 
one?


> Layered-Modal link type doesn't work with parameters
> 
>
> Key: OFBIZ-6941
> URL: https://issues.apache.org/jira/browse/OFBIZ-6941
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Arun Patidar
>  Labels: modalwindow, renderer
> Attachments: Example.png, OFBIZ-6941-Screenshot-1.png
>
>
> When having a link of type layered-modal it should with assocated parameters. 
> However the parameters aren't passed to the modal window.
> Example code:
> {code}
>  link-type="layered-modal"  width="1000" height="400">
> 
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7972) Create a (PoC) plugin system for OFBiz based on Gradle

2016-09-15 Thread Jacopo Cappellato (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492598#comment-15492598
 ] 

Jacopo Cappellato commented on OFBIZ-7972:
--

I like it.
I am looking forward at seeing this code in our repo: after that it will be 
easier to test it and paly with it and gather further feedback and enhancements 
from the community.

> Create a (PoC) plugin system for OFBiz based on Gradle
> --
>
> Key: OFBIZ-7972
> URL: https://issues.apache.org/jira/browse/OFBIZ-7972
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>Priority: Minor
>  Labels: plugin, proof-of-concept, system
> Attachments: OFBIZ-7972.patch, OFBIZ-7972.patch, OFBIZ-7972.patch
>
>
> This JIRA houses the attempt to create a plugin system for OFBiz based on 
> gradle. The plugin system should have the following features:
> - It is independent of the version control system, file system, operating 
> system and any other environment tools surrounding OFBiz. Instead, it should 
> be fully integrated with OFBiz.
> - It should unify the way OFBiz is extended, both for official supported 
> plugins and for third party plugins
> - The plugin system takes advantage of the concept of a "component" in OFBiz 
> and utilize it as the building block for plugins
> - The plugin system supports the concepts of "Repository" and "Dependency 
> Management". If possible, the plugin system will utilize these concepts 
> directly from Gradle instead of writing them from scratch.
> The initial API for the plugin system will be small and expands as needed. 
> The API should include the following gradle tasks:
> - createPlugin: creates a new plugin based on templates and place it in the 
> plugins directory
> - installPlugin: Activate a plugin and run Install. Plugin must exist in 
> /specialpurpose
> - uninstallPlugin: Deactivate a plugin and run its uninstall script
> - publishPlugin: publish a plugin to local maven repository
> - pullPlugin: download a plugin with its dependencies (plugins) from a 
> repository and install them



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state

2016-09-15 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492575#comment-15492575
 ] 

Pierre Smits commented on OFBIZ-8156:
-

Please read the comments provided earlier. 

For an explanation regarding disentanglement see 
http://www.merriam-webster.com/dictionary/disentangle


> Disentangle Fedex solution from current integrated state
> 
>
> Key: OFBIZ-8156
> URL: https://issues.apache.org/jira/browse/OFBIZ-8156
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext, datamodel, order, product, 
> specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Minor
>  Labels: 3rdParty, integration, shipment
> Attachments: OFBIZ-8156-FedexRemoval.patch
>
>
> Disentanglement of the 3rd party shipment integration for FedEx gives the 
> OFBiz adopter more flexibility, reduces the default code base and offers the 
> project more opportunities with respect to attracting product specific 
> contributors, better code and faster release cycles.
> Requirements of the disentangled solution:
> * should not need a separate entity to capture configuration elements
> * configuration should be contained in the component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7972) Create a (PoC) plugin system for OFBiz based on Gradle

2016-09-15 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492497#comment-15492497
 ] 

Taher Alkhateeb commented on OFBIZ-7972:


Hi Folks, I just had a new idea before committing. I would like to rename 
publishPlugin to pushPlugin. This way we have a nice consistent naming i.e. 
pulling from or pushing to a maven Repository. WDYT

> Create a (PoC) plugin system for OFBiz based on Gradle
> --
>
> Key: OFBIZ-7972
> URL: https://issues.apache.org/jira/browse/OFBIZ-7972
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>Priority: Minor
>  Labels: plugin, proof-of-concept, system
> Attachments: OFBIZ-7972.patch, OFBIZ-7972.patch, OFBIZ-7972.patch
>
>
> This JIRA houses the attempt to create a plugin system for OFBiz based on 
> gradle. The plugin system should have the following features:
> - It is independent of the version control system, file system, operating 
> system and any other environment tools surrounding OFBiz. Instead, it should 
> be fully integrated with OFBiz.
> - It should unify the way OFBiz is extended, both for official supported 
> plugins and for third party plugins
> - The plugin system takes advantage of the concept of a "component" in OFBiz 
> and utilize it as the building block for plugins
> - The plugin system supports the concepts of "Repository" and "Dependency 
> Management". If possible, the plugin system will utilize these concepts 
> directly from Gradle instead of writing them from scratch.
> The initial API for the plugin system will be small and expands as needed. 
> The API should include the following gradle tasks:
> - createPlugin: creates a new plugin based on templates and place it in the 
> plugins directory
> - installPlugin: Activate a plugin and run Install. Plugin must exist in 
> /specialpurpose
> - uninstallPlugin: Deactivate a plugin and run its uninstall script
> - publishPlugin: publish a plugin to local maven repository
> - pullPlugin: download a plugin with its dependencies (plugins) from a 
> repository and install them



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)