[jira] [Updated] (OFBIZ-9524) Uploading content to a product email is not working
[
https://issues.apache.org/jira/browse/OFBIZ-9524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Devanshu Vyas updated OFBIZ-9524:
-
Attachment: OFBIZ-9524.patch
Uploaded patch with the fix. The issue was due to a typo in form name in the
javascript function on the button.
> Uploading content to a product email is not working
>
>
> Key: OFBIZ-9524
> URL: https://issues.apache.org/jira/browse/OFBIZ-9524
> Project: OFBiz
> Issue Type: Bug
> Components: scrum
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
> Attachments: OFBIZ-9524.patch
>
>
> The feature to upload content to a product email in SCRUM component is not
> working properly. I followed the below steps:
> * Go to SCRUM main page.
> (https://demo-trunk.ofbiz.apache.org/scrum/control/main)
> * Select a product.
> (https://demo-trunk.ofbiz.apache.org/scrum/control/ViewProduct?productId=DEMO-PRODUCT-1)
> * Click on Communications menu item.
> (https://demo-trunk.ofbiz.apache.org/scrum/control/ProductEmails?productId=DEMO-PRODUCT-1)
> * Click on the (New Email) button.
> (https://demo-trunk.ofbiz.apache.org/scrum/control/NewProductEmail)
> * On the right side panel, upload a file.
> * Click on the (Upload) button.
> The uploaded file is not getting uploaded and giving below error
> {code}
> Uncaught TypeError: Cannot read property 'datetimeStarted' of undefined
> at :1:55
> (anonymous) @ VM427:1
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component
[ https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099519#comment-16099519 ] Taher Alkhateeb commented on OFBIZ-9501: Hi Rishi, I'm not sure but on first impression I think maybe this data should go into CommonData.xml file. This way we nicely layout fundamental data before higher order data. I'm not sure if this breaks anything though > move all data in applications to the datamodel component > > > Key: OFBIZ-9501 > URL: https://issues.apache.org/jira/browse/OFBIZ-9501 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: application, data > Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, > OFBIZ-9501-002.patch, OFBIZ-9501-003.patch > > > As per a community [discussion > thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E] > we decided to move all data (seed, seed-initial, demo) to the datamodel > component. and to also reduce and cleanup this data to ease debugging and > maintenance. > After moving all the data, the directory and file structure would be similar > to the below: > data/ > ├── demo > │ ├── AccountingDemoData.xml > │ ├── CommonDemoData.xml > │ ├── ContentDemoData.xml > │ ├── HumanresDemo.xml > │ ├── ManufacturingDemoData.xml > │ ├── MarketingDemoData.xml > │ ├── OrderDemoData.xml > │ ├── PartyDemoData.xml > │ ├── ProductDemoData.xml > │ ├── ShipmentDemoData.xml > │ └── WorkEffortDemoData.xml > ├── seed > │ ├── AccountingSeedData.xml > │ ├── CommonSeedData.xml > │ ├── ContentSeedData.xml > │ ├── HumanresSeedData.xml > │ ├── ManufacturingSeedData.xml > │ ├── MarketingSeedData.xml > │ ├── OrderSeedData.xml > │ ├── PartySeedData.xml > │ ├── ProductSeedData.xml > │ ├── ShipmentSeedData.xml > │ └── WorkEffortSeedData.xml > └── seed-initial > ├── AccountingSeedInitialData.xml > ├── CommonSeedInitialData.xml > ├── ContentSeedInitialData.xml > ├── HumanresSeedInitialData.xml > ├── ManufacturingSeedInitialData.xml > ├── MarketingSeedInitialData.xml > ├── OrderSeedInitialData.xml > ├── PartySeedInitialData.xml > ├── ProductSeedInitialData.xml > ├── ShipmentSeedInitialData.xml > └── WorkEffortSeedInitialData.xml -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component
[ https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099512#comment-16099512 ] Rishi Solanki commented on OFBIZ-9501: -- [~taher] / All, While working and reviewing the work of moving some seed data to data model component. I observe few entities data is in all components. Below are few names; - StatusType - StatusItem - StatusValidChange - EnumerationType - Enumeration - CustomMethodType - CustomMethod Also observe some data which may belongs to other component and exists as seed data in other component. Below are few entity names wrt Party component data exists in other components; - RoleType - ContactMechType - ContactMechPurposeType - ContactMechTypePurpose My question is how should we handle this while moving the data. I could think of two options; 1) Move the data as is, that means if any data exists in the Party component then we should move that data into PartySeedData.xml (for now considering only seed data and with mindset data must be loaded successfully). Later we can think if some more logical movements required Or may think to keep them as is so that component bifurcation per seed (any) data remains intact. 2) Move the data to relevant component file, for example in the above example we would move all role types in the PartySeedData.xml and in data comment we could mention the role types used for which component. Please share you input on this, if we decide this then we will be able to move the data quickly. > move all data in applications to the datamodel component > > > Key: OFBIZ-9501 > URL: https://issues.apache.org/jira/browse/OFBIZ-9501 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: application, data > Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, > OFBIZ-9501-002.patch, OFBIZ-9501-003.patch > > > As per a community [discussion > thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E] > we decided to move all data (seed, seed-initial, demo) to the datamodel > component. and to also reduce and cleanup this data to ease debugging and > maintenance. > After moving all the data, the directory and file structure would be similar > to the below: > data/ > ├── demo > │ ├── AccountingDemoData.xml > │ ├── CommonDemoData.xml > │ ├── ContentDemoData.xml > │ ├── HumanresDemo.xml > │ ├── ManufacturingDemoData.xml > │ ├── MarketingDemoData.xml > │ ├── OrderDemoData.xml > │ ├── PartyDemoData.xml > │ ├── ProductDemoData.xml > │ ├── ShipmentDemoData.xml > │ └── WorkEffortDemoData.xml > ├── seed > │ ├── AccountingSeedData.xml > │ ├── CommonSeedData.xml > │ ├── ContentSeedData.xml > │ ├── HumanresSeedData.xml > │ ├── ManufacturingSeedData.xml > │ ├── MarketingSeedData.xml > │ ├── OrderSeedData.xml > │ ├── PartySeedData.xml > │ ├── ProductSeedData.xml > │ ├── ShipmentSeedData.xml > │ └── WorkEffortSeedData.xml > └── seed-initial > ├── AccountingSeedInitialData.xml > ├── CommonSeedInitialData.xml > ├── ContentSeedInitialData.xml > ├── HumanresSeedInitialData.xml > ├── ManufacturingSeedInitialData.xml > ├── MarketingSeedInitialData.xml > ├── OrderSeedInitialData.xml > ├── PartySeedInitialData.xml > ├── ProductSeedInitialData.xml > ├── ShipmentSeedInitialData.xml > └── WorkEffortSeedInitialData.xml -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (OFBIZ-9510) Manufacturing : Remove unused imports from groovy files for code optimization.
[ https://issues.apache.org/jira/browse/OFBIZ-9510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pradeep Choudhary reassigned OFBIZ-9510: Assignee: (was: Pradeep Choudhary) > Manufacturing : Remove unused imports from groovy files for code optimization. > -- > > Key: OFBIZ-9510 > URL: https://issues.apache.org/jira/browse/OFBIZ-9510 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Reporter: Suraj Khurana >Priority: Minor > Fix For: 14.12.01, 15.12.01 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9377) fix tag "disable-if-empty" in menus if field has no value
[ https://issues.apache.org/jira/browse/OFBIZ-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16098315#comment-16098315 ] Gaudin Pierre commented on OFBIZ-9377: -- Many thanks Deepak and Humera. > fix tag "disable-if-empty" in menus if field has no value > - > > Key: OFBIZ-9377 > URL: https://issues.apache.org/jira/browse/OFBIZ-9377 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Deepak Dixit >Priority: Minor > Fix For: 16.11.04 > > Attachments: menu-disable-if-empty.patch > > > The purpose of this patch is to correct the behavior of the tag > "disable-if-empty" in menus. Indeed in certain cases it happens that the > value defines in "disable-if-empty" is present in the context but with no > valuee. In this case the menu item is shown while it should be masked. This > patch corrects it by testing if emptie and without value. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9376) Add shipmentId list to quickshippurchaseorder return parameters
[ https://issues.apache.org/jira/browse/OFBIZ-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16098312#comment-16098312 ] Gaudin Pierre commented on OFBIZ-9376: -- Hi Nicolas, I have missed this test ... I'll provide a new patch as soon as possible. Thanks, Pierre > Add shipmentId list to quickshippurchaseorder return parameters > --- > > Key: OFBIZ-9376 > URL: https://issues.apache.org/jira/browse/OFBIZ-9376 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Nicolas Malin >Priority: Minor > Attachments: quickShipPurchaseOrder.patch > > > The method " quickshippurchaseorder " allows to create a reception for every > ship group of a purchasing order. This method works correctly but it does not > return id of the receptions which it creates. The purpose of this patch is to > modify the service so that it returns the list of the receptions which it > creates > To test this patch: > - Create a purchase order with several ships groups > - approve it > - from webtools execute the service " quickshippurchaseorder " with the > parameters: order Id: reference of order facilityId: WebStoreWarehouse > results : > The service returns the parameter shipmentIds -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-9523) Improve groovy DSL : runService call makeValidContext
[
https://issues.apache.org/jira/browse/OFBIZ-9523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin closed OFBIZ-9523.
Resolution: Implemented
Fix Version/s: Upcoming Release
> Improve groovy DSL : runService call makeValidContext
> -
>
> Key: OFBIZ-9523
> URL: https://issues.apache.org/jira/browse/OFBIZ-9523
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9523.patch
>
>
> When you call run service with groovy, you need to be sure that all parametes
> are good for the service call.
> I propose to simplify this dsl with an automatic parameters check so you can
> call directly like that
> {code}
> run service : createProduct, with: context
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9523) Improve groovy DSL : runService call makeValidContext
[
https://issues.apache.org/jira/browse/OFBIZ-9523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16098277#comment-16098277
]
Nicolas Malin commented on OFBIZ-9523:
--
:) yes nice catch,
I commit this on trunk at 1802798
Thanks Jacopo
> Improve groovy DSL : runService call makeValidContext
> -
>
> Key: OFBIZ-9523
> URL: https://issues.apache.org/jira/browse/OFBIZ-9523
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
> Attachments: OFBIZ-9523.patch
>
>
> When you call run service with groovy, you need to be sure that all parametes
> are good for the service call.
> I propose to simplify this dsl with an automatic parameters check so you can
> call directly like that
> {code}
> run service : createProduct, with: context
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-9523) Improve groovy DSL : runService call makeValidContext
[
https://issues.apache.org/jira/browse/OFBIZ-9523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin updated OFBIZ-9523:
-
Description:
When you call run service with groovy, you need to be sure that all parametes
are good for the service call.
I propose to simplify this dsl with an automatic parameters check so you can
call directly like that
{code}
run service : createProduct, with: context
{code}
> Improve groovy DSL : runService call makeValidContext
> -
>
> Key: OFBIZ-9523
> URL: https://issues.apache.org/jira/browse/OFBIZ-9523
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
> Attachments: OFBIZ-9523.patch
>
>
> When you call run service with groovy, you need to be sure that all parametes
> are good for the service call.
> I propose to simplify this dsl with an automatic parameters check so you can
> call directly like that
> {code}
> run service : createProduct, with: context
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-9523) Improve groovy DSL : runService call makeValidContext
[
https://issues.apache.org/jira/browse/OFBIZ-9523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin updated OFBIZ-9523:
-
Environment: (was: When you call run service with groovy, you need to
be sure that all parametes are good for the service call.
I propose to simplify this dsl with an automatic parameters check so you can
call directly like that
{code}
run service : createProduct, with: context
{code})
> Improve groovy DSL : runService call makeValidContext
> -
>
> Key: OFBIZ-9523
> URL: https://issues.apache.org/jira/browse/OFBIZ-9523
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
> Attachments: OFBIZ-9523.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Closed] (OFBIZ-7828) Entity and Service definition
[ https://issues.apache.org/jira/browse/OFBIZ-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki closed OFBIZ-7828. Resolution: Done Fix Version/s: Upcoming Release Change the resolution and added fix version. > Entity and Service definition > - > > Key: OFBIZ-7828 > URL: https://issues.apache.org/jira/browse/OFBIZ-7828 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rishi Solanki > Fix For: Upcoming Release > > > As per discussion on dev list on email thread-: "Entity and Service > definition" Here is the parent task for the same. > TODO's from same thread, review entities/services on following parameters; > 1) Many entity definitions having relationships with view-entities, like > OrderHeader entity maintain relationship with OrderHeaderNoteView and > OrderItemAndShipGroupAssoc. We should remove it, maintain the relationship at > view-entities level if required. Also change the code where this relation is > in use. > 2) Many entities having service implementation exists but they can be simply > convert into entity-auto, that means can use the power OFBiz provides. > 3) As mentioned initially many entities do not have CRUD services exists, we > should implement or use entity-auto for them wherever applicable. Also remove > direct use of delegator for them. > 4) Many entities having from date and thru date, Or status Or Enumeration to > manage the historical data, but services actually remove those entity data. > We should change the service implementation to maintain the historical data. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Reopened] (OFBIZ-7828) Entity and Service definition
[ https://issues.apache.org/jira/browse/OFBIZ-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki reopened OFBIZ-7828: -- Assignee: Rishi Solanki (was: Arun Patidar) > Entity and Service definition > - > > Key: OFBIZ-7828 > URL: https://issues.apache.org/jira/browse/OFBIZ-7828 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Rishi Solanki > > As per discussion on dev list on email thread-: "Entity and Service > definition" Here is the parent task for the same. > TODO's from same thread, review entities/services on following parameters; > 1) Many entity definitions having relationships with view-entities, like > OrderHeader entity maintain relationship with OrderHeaderNoteView and > OrderItemAndShipGroupAssoc. We should remove it, maintain the relationship at > view-entities level if required. Also change the code where this relation is > in use. > 2) Many entities having service implementation exists but they can be simply > convert into entity-auto, that means can use the power OFBiz provides. > 3) As mentioned initially many entities do not have CRUD services exists, we > should implement or use entity-auto for them wherever applicable. Also remove > direct use of delegator for them. > 4) Many entities having from date and thru date, Or status Or Enumeration to > manage the historical data, but services actually remove those entity data. > We should change the service implementation to maintain the historical data. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-9530) Missing action in empty if-statement in accounting.PaymentGatewayServices
[
https://issues.apache.org/jira/browse/OFBIZ-9530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16098217#comment-16098217
]
Kyra Pritzel-Hentley edited comment on OFBIZ-9530 at 7/24/17 11:10 AM:
---
In this patch I implement the above suggested code. If authResult is null then
the error should be logged and the service should return.
was (Author: kyra pritzel-hentley):
In this patch I implement the above suggested code. If authresult is null then
the error should be logged and the service should return.
> Missing action in empty if-statement in accounting.PaymentGatewayServices
> -
>
> Key: OFBIZ-9530
> URL: https://issues.apache.org/jira/browse/OFBIZ-9530
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
>Affects Versions: Trunk
>Reporter: Kyra Pritzel-Hentley
>Priority: Minor
> Attachments: OFBIZ-9530_PaymentGatewayServices_bugfix.patch
>
>
> In the method _processAuthResult_ line 1889 there is an empty if-statement
> for the case that authResult is null. It seems like somebody was planning to
> cover the case but forgot to add code.
> I would suggest to return a service error when the authResult is null since
> otherwise it cannot be determined if the payment is authorized or not.
> {code:java}
> boolean authResultOk = authResult.booleanValue();
>
> if (authResultOk) {
> orderPaymentPreference.set("statusId", "PAYMENT_AUTHORIZED");
> } else {
> orderPaymentPreference.set("statusId", "PAYMENT_DECLINED");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-9530) Missing action in empty if-statement in accounting.PaymentGatewayServices
[
https://issues.apache.org/jira/browse/OFBIZ-9530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kyra Pritzel-Hentley updated OFBIZ-9530:
Attachment: OFBIZ-9530_PaymentGatewayServices_bugfix.patch
In this patch I implement the above suggested code. If authresult is null then
the error should be logged and the service should return.
> Missing action in empty if-statement in accounting.PaymentGatewayServices
> -
>
> Key: OFBIZ-9530
> URL: https://issues.apache.org/jira/browse/OFBIZ-9530
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
>Affects Versions: Trunk
>Reporter: Kyra Pritzel-Hentley
>Priority: Minor
> Attachments: OFBIZ-9530_PaymentGatewayServices_bugfix.patch
>
>
> In the method _processAuthResult_ line 1889 there is an empty if-statement
> for the case that authResult is null. It seems like somebody was planning to
> cover the case but forgot to add code.
> I would suggest to return a service error when the authResult is null since
> otherwise it cannot be determined if the payment is authorized or not.
> {code:java}
> boolean authResultOk = authResult.booleanValue();
>
> if (authResultOk) {
> orderPaymentPreference.set("statusId", "PAYMENT_AUTHORIZED");
> } else {
> orderPaymentPreference.set("statusId", "PAYMENT_DECLINED");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-9530) Missing action in empty if-statement in accounting.PaymentGatewayServices
[
https://issues.apache.org/jira/browse/OFBIZ-9530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kyra Pritzel-Hentley updated OFBIZ-9530:
Description:
In the method _processAuthResult_ there is an empty if-statement for the case
that authResult is null. It seems like somebody was planning to cover the case
but forgot to add code.
I would suggest to return a service error when the authResult is null since
otherwise it cannot be determined if the payment is authorized or not.
{code:java}
boolean authResultOk = authResult.booleanValue();
if (authResultOk) {
orderPaymentPreference.set("statusId", "PAYMENT_AUTHORIZED");
} else {
orderPaymentPreference.set("statusId", "PAYMENT_DECLINED");
}
{code}
> Missing action in empty if-statement in accounting.PaymentGatewayServices
> -
>
> Key: OFBIZ-9530
> URL: https://issues.apache.org/jira/browse/OFBIZ-9530
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
>Affects Versions: Trunk
>Reporter: Kyra Pritzel-Hentley
>Priority: Minor
>
> In the method _processAuthResult_ there is an empty if-statement for the case
> that authResult is null. It seems like somebody was planning to cover the
> case but forgot to add code.
> I would suggest to return a service error when the authResult is null since
> otherwise it cannot be determined if the payment is authorized or not.
> {code:java}
> boolean authResultOk = authResult.booleanValue();
>
> if (authResultOk) {
> orderPaymentPreference.set("statusId", "PAYMENT_AUTHORIZED");
> } else {
> orderPaymentPreference.set("statusId", "PAYMENT_DECLINED");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (OFBIZ-9530) Missing action in empty if-statement in accounting.PaymentGatewayServices
Kyra Pritzel-Hentley created OFBIZ-9530: --- Summary: Missing action in empty if-statement in accounting.PaymentGatewayServices Key: OFBIZ-9530 URL: https://issues.apache.org/jira/browse/OFBIZ-9530 Project: OFBiz Issue Type: Bug Components: accounting Affects Versions: Trunk Reporter: Kyra Pritzel-Hentley Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-9529) [FB] Package org.apache.ofbiz.accounting.payment (Additional Bugs)
Kyra Pritzel-Hentley created OFBIZ-9529: --- Summary: [FB] Package org.apache.ofbiz.accounting.payment (Additional Bugs) Key: OFBIZ-9529 URL: https://issues.apache.org/jira/browse/OFBIZ-9529 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Kyra Pritzel-Hentley Priority: Minor BillingAccountWorker.java:217, SE_NO_SERIALVERSIONID * SnVI: org.apache.ofbiz.accounting.payment.BillingAccountWorker$BillingAccountComparator is Serializable; consider declaring a serialVersionUID This class implements the Serializable interface, but does not define a serialVersionUID field. A change as simple as adding a reference to a .class object will add synthetic fields to the class, which will unfortunately change the implicit serialVersionUID (e.g., adding a reference to String.class will generate a static field class$java$lang$String). Also, different source code to bytecode compilers may use different naming conventions for synthetic variables generated for references to class objects or inner classes. To ensure interoperability of Serializable across versions, consider adding an explicit serialVersionUID. GiftCertificateServices.java:229, DLS_DEAD_LOCAL_STORE * DLS: Dead store to balance in org.apache.ofbiz.accounting.payment.GiftCertificateServices.addFundsToGiftCertificate(DispatchContext, Map) This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction. Often, this indicates an error, because the value computed is never used. Note that Sun's javac compiler often generates dead stores for final local variables. Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these false positives. GiftCertificateServices.java:306, DLS_DEAD_LOCAL_STORE * DLS: Dead store to balance in org.apache.ofbiz.accounting.payment.GiftCertificateServices.redeemGiftCertificate(DispatchContext, Map) This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction. Often, this indicates an error, because the value computed is never used. Note that Sun's javac compiler often generates dead stores for final local variables. Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these false positives. PaymentGatewayServices.java:211, UCF_USELESS_CONTROL_FLOW * UCF: Useless control flow in org.apache.ofbiz.accounting.payment.PaymentGatewayServices.authOrderPaymentPreference(DispatchContext, Map) This method contains a useless control flow statement, where control flow continues onto the same place regardless of whether or not the branch is taken. PaymentGatewayServices.java:1889, UCF_USELESS_CONTROL_FLOW * UCF: Useless control flow in org.apache.ofbiz.accounting.payment.PaymentGatewayServices.processAuthResult(DispatchContext, Map) This method contains a useless control flow statement, where control flow continues onto the same place regardless of whether or not the branch is taken. PaymentGatewayServices.java:3729, DLS_DEAD_LOCAL_STORE * DLS: Dead store to returnItemResponses in org.apache.ofbiz.accounting.payment.PaymentGatewayServices.isReplacementOrder(GenericValue) This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction. Often, this indicates an error, because the value computed is never used. Note that Sun's javac compiler often generates dead stores for final local variables. Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these false positives. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-7828) Entity and Service definition
[ https://issues.apache.org/jira/browse/OFBIZ-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki closed OFBIZ-7828. Resolution: Fixed > Entity and Service definition > - > > Key: OFBIZ-7828 > URL: https://issues.apache.org/jira/browse/OFBIZ-7828 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Arun Patidar > > As per discussion on dev list on email thread-: "Entity and Service > definition" Here is the parent task for the same. > TODO's from same thread, review entities/services on following parameters; > 1) Many entity definitions having relationships with view-entities, like > OrderHeader entity maintain relationship with OrderHeaderNoteView and > OrderItemAndShipGroupAssoc. We should remove it, maintain the relationship at > view-entities level if required. Also change the code where this relation is > in use. > 2) Many entities having service implementation exists but they can be simply > convert into entity-auto, that means can use the power OFBiz provides. > 3) As mentioned initially many entities do not have CRUD services exists, we > should implement or use entity-auto for them wherever applicable. Also remove > direct use of delegator for them. > 4) Many entities having from date and thru date, Or status Or Enumeration to > manage the historical data, but services actually remove those entity data. > We should change the service implementation to maintain the historical data. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-9526) MRP generates duplicate requirements when items are initially under minimum quantity and have with pending approved purchase orders.
[ https://issues.apache.org/jira/browse/OFBIZ-9526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-9526. Resolution: Fixed Fix Version/s: 16.11.04 Fix committed in trunk with rev. 1802766 and in release branch 14.11 with rev. 1802773. > MRP generates duplicate requirements when items are initially under minimum > quantity and have with pending approved purchase orders. > > > Key: OFBIZ-9526 > URL: https://issues.apache.org/jira/browse/OFBIZ-9526 > Project: OFBiz > Issue Type: Bug > Components: manufacturing >Affects Versions: Trunk, 16.11.03 >Reporter: Jacopo Cappellato >Assignee: Jacopo Cappellato > Fix For: 16.11.04 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (OFBIZ-8843) Improvements in CommEventContentAssoc entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar resolved OFBIZ-8843. - Resolution: Fixed Improved patches has been committed at rev: 1802771 and 1802772 Thanks Devanshu for your contribution. > Improvements in CommEventContentAssoc entity definition and services > > > Key: OFBIZ-8843 > URL: https://issues.apache.org/jira/browse/OFBIZ-8843 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Arun Patidar >Priority: Minor > Fix For: Upcoming Release > > Attachments: OFBIZ-8843.patch, OFBIZ-8843.patch, OFBIZ-8843.patch, > OFBIZ-8843_plugins.patch > > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto (services_commevent.xml). Also remove > the existing services from ContentServices.xml. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As existing workflows are implemented to delete the records so use the > delete action for the same. > - Need to convert Update and Delete services. Create can not be converted due > to some conditional code. Keep the existing services names as is. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-9528) [FB] Package org.apache.ofbiz.accounting.thirdparty.eway (Additional Bugs)
Kyra Pritzel-Hentley created OFBIZ-9528: --- Summary: [FB] Package org.apache.ofbiz.accounting.thirdparty.eway (Additional Bugs) Key: OFBIZ-9528 URL: https://issues.apache.org/jira/browse/OFBIZ-9528 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Kyra Pritzel-Hentley Priority: Minor After adjusting the FindBugs configuration, these new bugs have been found: EwayServices.java:99, BX_UNBOXING_IMMEDIATELY_REBOXED * Bx: Boxed value is unboxed and then immediately reboxed in org.apache.ofbiz.accounting.thirdparty.eway.EwayServices.ewayCharge(DispatchContext, Map) A boxed value is unboxed and then immediately reboxed. EwayServices.java:166, BX_UNBOXING_IMMEDIATELY_REBOXED * Bx: Boxed value is unboxed and then immediately reboxed in org.apache.ofbiz.accounting.thirdparty.eway.EwayServices.ewayRefund(DispatchContext, Map) A boxed value is unboxed and then immediately reboxed. EwayServices.java:231, BX_UNBOXING_IMMEDIATELY_REBOXED * Bx: Boxed value is unboxed and then immediately reboxed in org.apache.ofbiz.accounting.thirdparty.eway.EwayServices.ewayRelease(DispatchContext, Map) A boxed value is unboxed and then immediately reboxed. GatewayConnector.java:90, RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE * RCN: Nullcheck of connection at line 90 of value previously dereferenced in org.apache.ofbiz.accounting.thirdparty.eway.GatewayConnector.sendRequest(GatewayRequest) A value is checked here to see whether it is null, but this value can't be null because it was previously dereferenced and if it were null a null pointer exception would have occurred at the earlier dereference. Essentially, this code and the previous dereference disagree as to whether this value is allowed to be null. Either the check is redundant or the previous dereference is erroneous. GatewayConnector.java:96, OS_OPEN_STREAM_EXCEPTION_PATH * OS: org.apache.ofbiz.accounting.thirdparty.eway.GatewayConnector.sendRequest(GatewayRequest) may fail to close stream on exception The method creates an IO stream object, does not assign it to any fields, pass it to other methods, or return it, and does not appear to close it on all possible exception paths out of the method. This may result in a file descriptor leak. It is generally a good idea to use a finally block to ensure that streams are closed. GatewayResponse.java:155, DM_CONVERT_CASE * Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in new org.apache.ofbiz.accounting.thirdparty.eway.GatewayResponse(InputStream, GatewayRequest) A String is being converted to upper or lowercase, using the platform's default encoding. This may result in improper conversions when used with international characters. Use the String.toUpperCase( Locale l ) String.toLowerCase( Locale l ) versions instead. GatewayResponse.java:159, 161, 163, 165, 167, 172, 174, 176 ES_COMPARING_STRINGS_WITH_EQ * ES: Comparison of String objects using == or != in new org.apache.ofbiz.accounting.thirdparty.eway.GatewayResponse(InputStream, GatewayRequest) This code compares java.lang.String objects for reference equality using the == or != operators. Unless both strings are either constants in a source file, or have been interned using the String.intern() method, the same string value may be represented by two different String objects. Consider using the equals(Object) method instead. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9527) [FB] Packages org.apache.ofbiz.accounting.period and org.apache.ofbiz.accounting.tax
[ https://issues.apache.org/jira/browse/OFBIZ-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kyra Pritzel-Hentley updated OFBIZ-9527: Attachment: OFBIZ-9527_org.apache.ofbiz.accounting.period_and_org.apache.ofbiz.accounting.tax_refactoring.patch The patch resolves the above mentioned bugs. In TaxAuthorityServices every possible case sets the variable productCategoryCond, rendering it always not-null. I extracted a method for better readability of the code. The documentation of the new method explicitly states that a non-null value is returned. > [FB] Packages org.apache.ofbiz.accounting.period and > org.apache.ofbiz.accounting.tax > > > Key: OFBIZ-9527 > URL: https://issues.apache.org/jira/browse/OFBIZ-9527 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Kyra Pritzel-Hentley >Priority: Minor > Attachments: > OFBIZ-9527_org.apache.ofbiz.accounting.period_and_org.apache.ofbiz.accounting.tax_refactoring.patch > > > PeriodServices.java:42, MS_SHOULD_BE_FINAL > * MS: org.apache.ofbiz.accounting.period.PeriodServices.module isn't final > but should be > This static field public but not final, and could be changed by malicious > code or by accident from another package. The field could be made final to > avoid this vulnerability. > After adjusting the FindBugs configuration, a new bug has been found in > TaxAuthorityServices: > TaxAuthorityServices.java:350, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE > * RCN: Redundant nullcheck of productCategoryCond, which is known to be > non-null in > org.apache.ofbiz.accounting.tax.TaxAuthorityServices.getTaxAdjustments(Delegator, > GenericValue, GenericValue, String, String, Set, BigDecimal, BigDecimal, > BigDecimal, BigDecimal, BigDecimal) > This method contains a redundant check of a known non-null value against the > constant null. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9527) [FB] Packages org.apache.ofbiz.accounting.period and org.apache.ofbiz.accounting.tax
[ https://issues.apache.org/jira/browse/OFBIZ-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kyra Pritzel-Hentley updated OFBIZ-9527: Flags: Patch > [FB] Packages org.apache.ofbiz.accounting.period and > org.apache.ofbiz.accounting.tax > > > Key: OFBIZ-9527 > URL: https://issues.apache.org/jira/browse/OFBIZ-9527 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Kyra Pritzel-Hentley >Priority: Minor > Attachments: > OFBIZ-9527_org.apache.ofbiz.accounting.period_and_org.apache.ofbiz.accounting.tax_refactoring.patch > > > PeriodServices.java:42, MS_SHOULD_BE_FINAL > * MS: org.apache.ofbiz.accounting.period.PeriodServices.module isn't final > but should be > This static field public but not final, and could be changed by malicious > code or by accident from another package. The field could be made final to > avoid this vulnerability. > After adjusting the FindBugs configuration, a new bug has been found in > TaxAuthorityServices: > TaxAuthorityServices.java:350, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE > * RCN: Redundant nullcheck of productCategoryCond, which is known to be > non-null in > org.apache.ofbiz.accounting.tax.TaxAuthorityServices.getTaxAdjustments(Delegator, > GenericValue, GenericValue, String, String, Set, BigDecimal, BigDecimal, > BigDecimal, BigDecimal, BigDecimal) > This method contains a redundant check of a known non-null value against the > constant null. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-9527) [FB] Packages org.apache.ofbiz.accounting.period and org.apache.ofbiz.accounting.tax
Kyra Pritzel-Hentley created OFBIZ-9527: --- Summary: [FB] Packages org.apache.ofbiz.accounting.period and org.apache.ofbiz.accounting.tax Key: OFBIZ-9527 URL: https://issues.apache.org/jira/browse/OFBIZ-9527 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Kyra Pritzel-Hentley Priority: Minor PeriodServices.java:42, MS_SHOULD_BE_FINAL * MS: org.apache.ofbiz.accounting.period.PeriodServices.module isn't final but should be This static field public but not final, and could be changed by malicious code or by accident from another package. The field could be made final to avoid this vulnerability. After adjusting the FindBugs configuration, a new bug has been found in TaxAuthorityServices: TaxAuthorityServices.java:350, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE * RCN: Redundant nullcheck of productCategoryCond, which is known to be non-null in org.apache.ofbiz.accounting.tax.TaxAuthorityServices.getTaxAdjustments(Delegator, GenericValue, GenericValue, String, String, Set, BigDecimal, BigDecimal, BigDecimal, BigDecimal, BigDecimal) This method contains a redundant check of a known non-null value against the constant null. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9505) [FB] Package org.apache.ofbiz.accounting.ledger
[ https://issues.apache.org/jira/browse/OFBIZ-9505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kyra Pritzel-Hentley updated OFBIZ-9505: Flags: Patch > [FB] Package org.apache.ofbiz.accounting.ledger > --- > > Key: OFBIZ-9505 > URL: https://issues.apache.org/jira/browse/OFBIZ-9505 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Kyra Pritzel-Hentley >Priority: Minor > Attachments: > OFBIZ-9505_org.apache.ofbiz.accounting.ledger_bugfixes.patch > > > The following Bugs were found by the FindBugs Software in the OFBiz codebase > and may need fixing: > GeneralLedgerServices.java:42, DLS_DEAD_LOCAL_STORE > * DLS: Dead store to totalAmountPercentage in > org.apache.ofbiz.accounting.ledger.GeneralLedgerServices.createUpdateCostCenter(DispatchContext, > Map) > This instruction assigns a value to a local variable, but the value is not > read or used in any subsequent instruction. Often, this indicates an error, > because the value computed is never used. > Note that Sun's javac compiler often generates dead stores for final local > variables. Because FindBugs is a bytecode-based tool, there is no easy way to > eliminate these false positives. > GeneralLedgerServices.java:50, WMI_WRONG_MAP_ITERATOR > * WMI: > org.apache.ofbiz.accounting.ledger.GeneralLedgerServices.createUpdateCostCenter(DispatchContext, > Map) makes inefficient use of keySet iterator instead of entrySet iterator > This method accesses the value of a Map entry, using a key that was retrieved > from a keySet iterator. It is more efficient to use an iterator on the > entrySet of the map, to avoid the Map.get(key) lookup. > GeneralLedgerServices.java:73, WMI_WRONG_MAP_ITERATOR > * WMI: > org.apache.ofbiz.accounting.ledger.GeneralLedgerServices.calculateCostCenterTotal(Map) > makes inefficient use of keySet iterator instead of entrySet iterator > This method accesses the value of a Map entry, using a key that was retrieved > from a keySet iterator. It is more efficient to use an iterator on the > entrySet of the map, to avoid the Map.get(key) lookup. > GeneralLedgerServices.java:75, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE > * RCN: Redundant nullcheck of rowValue, which is known to be non-null in > org.apache.ofbiz.accounting.ledger.GeneralLedgerServices.calculateCostCenterTotal(Map) > This method contains a redundant check of a known non-null value against the > constant null. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9505) [FB] Package org.apache.ofbiz.accounting.ledger
[ https://issues.apache.org/jira/browse/OFBIZ-9505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kyra Pritzel-Hentley updated OFBIZ-9505: Attachment: OFBIZ-9505_org.apache.ofbiz.accounting.ledger_bugfixes.patch The patch resolves the found bugs. It made sense to resolve the WMI_WRONG_MAP_ITERATOR bug since the method was iterating over the whole map twice. > [FB] Package org.apache.ofbiz.accounting.ledger > --- > > Key: OFBIZ-9505 > URL: https://issues.apache.org/jira/browse/OFBIZ-9505 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Kyra Pritzel-Hentley >Priority: Minor > Attachments: > OFBIZ-9505_org.apache.ofbiz.accounting.ledger_bugfixes.patch > > > The following Bugs were found by the FindBugs Software in the OFBiz codebase > and may need fixing: > GeneralLedgerServices.java:42, DLS_DEAD_LOCAL_STORE > * DLS: Dead store to totalAmountPercentage in > org.apache.ofbiz.accounting.ledger.GeneralLedgerServices.createUpdateCostCenter(DispatchContext, > Map) > This instruction assigns a value to a local variable, but the value is not > read or used in any subsequent instruction. Often, this indicates an error, > because the value computed is never used. > Note that Sun's javac compiler often generates dead stores for final local > variables. Because FindBugs is a bytecode-based tool, there is no easy way to > eliminate these false positives. > GeneralLedgerServices.java:50, WMI_WRONG_MAP_ITERATOR > * WMI: > org.apache.ofbiz.accounting.ledger.GeneralLedgerServices.createUpdateCostCenter(DispatchContext, > Map) makes inefficient use of keySet iterator instead of entrySet iterator > This method accesses the value of a Map entry, using a key that was retrieved > from a keySet iterator. It is more efficient to use an iterator on the > entrySet of the map, to avoid the Map.get(key) lookup. > GeneralLedgerServices.java:73, WMI_WRONG_MAP_ITERATOR > * WMI: > org.apache.ofbiz.accounting.ledger.GeneralLedgerServices.calculateCostCenterTotal(Map) > makes inefficient use of keySet iterator instead of entrySet iterator > This method accesses the value of a Map entry, using a key that was retrieved > from a keySet iterator. It is more efficient to use an iterator on the > entrySet of the map, to avoid the Map.get(key) lookup. > GeneralLedgerServices.java:75, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE > * RCN: Redundant nullcheck of rowValue, which is known to be non-null in > org.apache.ofbiz.accounting.ledger.GeneralLedgerServices.calculateCostCenterTotal(Map) > This method contains a redundant check of a known non-null value against the > constant null. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9504) [FB] Package org.apache.ofbiz.accounting.finaccount
[ https://issues.apache.org/jira/browse/OFBIZ-9504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kyra Pritzel-Hentley updated OFBIZ-9504: Flags: Patch > [FB] Package org.apache.ofbiz.accounting.finaccount > --- > > Key: OFBIZ-9504 > URL: https://issues.apache.org/jira/browse/OFBIZ-9504 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Kyra Pritzel-Hentley >Priority: Minor > Attachments: > OFBIZ-9504_org.apache.ofbiz.accounting.finaccount_bugfixes.patch > > > The following Bug was found by the FindBugs Software in the OFBiz codebase > and may need fixing: > FinAccountPaymentServices.java:72, > RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE > * RCN: Nullcheck of paymentPref at line 72 of value previously dereferenced > in > org.apache.ofbiz.accounting.finaccount.FinAccountPaymentServices.finAccountPreAuth(DispatchContext, > Map) > A value is checked here to see whether it is null, but this value can't be > null because it was previously dereferenced and if it were null a null > pointer exception would have occurred at the earlier dereference. > Essentially, this code and the previous dereference disagree as to whether > this value is allowed to be null. Either the check is redundant or the > previous dereference is erroneous. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9504) [FB] Package org.apache.ofbiz.accounting.finaccount
[ https://issues.apache.org/jira/browse/OFBIZ-9504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kyra Pritzel-Hentley updated OFBIZ-9504: Description: The following Bug was found by the FindBugs Software in the OFBiz codebase and may need fixing: FinAccountPaymentServices.java:72, RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE * RCN: Nullcheck of paymentPref at line 72 of value previously dereferenced in org.apache.ofbiz.accounting.finaccount.FinAccountPaymentServices.finAccountPreAuth(DispatchContext, Map) A value is checked here to see whether it is null, but this value can't be null because it was previously dereferenced and if it were null a null pointer exception would have occurred at the earlier dereference. Essentially, this code and the previous dereference disagree as to whether this value is allowed to be null. Either the check is redundant or the previous dereference is erroneous. was: FinAccountPaymentServices.java:72, RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE * RCN: Nullcheck of paymentPref at line 72 of value previously dereferenced in org.apache.ofbiz.accounting.finaccount.FinAccountPaymentServices.finAccountPreAuth(DispatchContext, Map) A value is checked here to see whether it is null, but this value can't be null because it was previously dereferenced and if it were null a null pointer exception would have occurred at the earlier dereference. Essentially, this code and the previous dereference disagree as to whether this value is allowed to be null. Either the check is redundant or the previous dereference is erroneous. > [FB] Package org.apache.ofbiz.accounting.finaccount > --- > > Key: OFBIZ-9504 > URL: https://issues.apache.org/jira/browse/OFBIZ-9504 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Kyra Pritzel-Hentley >Priority: Minor > Attachments: > OFBIZ-9504_org.apache.ofbiz.accounting.finaccount_bugfixes.patch > > > The following Bug was found by the FindBugs Software in the OFBiz codebase > and may need fixing: > FinAccountPaymentServices.java:72, > RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE > * RCN: Nullcheck of paymentPref at line 72 of value previously dereferenced > in > org.apache.ofbiz.accounting.finaccount.FinAccountPaymentServices.finAccountPreAuth(DispatchContext, > Map) > A value is checked here to see whether it is null, but this value can't be > null because it was previously dereferenced and if it were null a null > pointer exception would have occurred at the earlier dereference. > Essentially, this code and the previous dereference disagree as to whether > this value is allowed to be null. Either the check is redundant or the > previous dereference is erroneous. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9504) [FB] Package org.apache.ofbiz.accounting.finaccount
[ https://issues.apache.org/jira/browse/OFBIZ-9504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kyra Pritzel-Hentley updated OFBIZ-9504: Attachment: OFBIZ-9504_org.apache.ofbiz.accounting.finaccount_bugfixes.patch This patch resolves the bug. > [FB] Package org.apache.ofbiz.accounting.finaccount > --- > > Key: OFBIZ-9504 > URL: https://issues.apache.org/jira/browse/OFBIZ-9504 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Kyra Pritzel-Hentley >Priority: Minor > Attachments: > OFBIZ-9504_org.apache.ofbiz.accounting.finaccount_bugfixes.patch > > > The following Bug was found by the FindBugs Software in the OFBiz codebase > and may need fixing: > FinAccountPaymentServices.java:72, > RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE > * RCN: Nullcheck of paymentPref at line 72 of value previously dereferenced > in > org.apache.ofbiz.accounting.finaccount.FinAccountPaymentServices.finAccountPreAuth(DispatchContext, > Map) > A value is checked here to see whether it is null, but this value can't be > null because it was previously dereferenced and if it were null a null > pointer exception would have occurred at the earlier dereference. > Essentially, this code and the previous dereference disagree as to whether > this value is allowed to be null. Either the check is redundant or the > previous dereference is erroneous. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-8843) Improvements in CommEventContentAssoc entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-8843: - Attachment: OFBIZ-8843.patch invoke="expire" was missed, so added updated patch for it. > Improvements in CommEventContentAssoc entity definition and services > > > Key: OFBIZ-8843 > URL: https://issues.apache.org/jira/browse/OFBIZ-8843 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Arun Patidar >Priority: Minor > Fix For: Upcoming Release > > Attachments: OFBIZ-8843.patch, OFBIZ-8843.patch, OFBIZ-8843.patch, > OFBIZ-8843_plugins.patch > > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto (services_commevent.xml). Also remove > the existing services from ContentServices.xml. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As existing workflows are implemented to delete the records so use the > delete action for the same. > - Need to convert Update and Delete services. Create can not be converted due > to some conditional code. Keep the existing services names as is. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-8843) Improvements in CommEventContentAssoc entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16098077#comment-16098077 ] Rishi Solanki commented on OFBIZ-8843: -- Thank you Devanshu, what Deepak make us to notice is we should call the invoke="expire" instead of invoke="delete". Please change this and I think all should be okay. Thanks again for your effort and help. > Improvements in CommEventContentAssoc entity definition and services > > > Key: OFBIZ-8843 > URL: https://issues.apache.org/jira/browse/OFBIZ-8843 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Arun Patidar >Priority: Minor > Fix For: Upcoming Release > > Attachments: OFBIZ-8843.patch, OFBIZ-8843.patch, > OFBIZ-8843_plugins.patch > > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto (services_commevent.xml). Also remove > the existing services from ContentServices.xml. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As existing workflows are implemented to delete the records so use the > delete action for the same. > - Need to convert Update and Delete services. Create can not be converted due > to some conditional code. Keep the existing services names as is. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-8843) Improvements in CommEventContentAssoc entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-8843: - Attachment: OFBIZ-8843_plugins.patch OFBIZ-8843.patch Corrected the service name as per the suggestion and updated all references found. Attaching files for the same. > Improvements in CommEventContentAssoc entity definition and services > > > Key: OFBIZ-8843 > URL: https://issues.apache.org/jira/browse/OFBIZ-8843 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Arun Patidar >Priority: Minor > Fix For: Upcoming Release > > Attachments: OFBIZ-8843.patch, OFBIZ-8843.patch, > OFBIZ-8843_plugins.patch > > > Required improvements; > - All is good with entity definition . > - Add crud services using entity-auto (services_commevent.xml). Also remove > the existing services from ContentServices.xml. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As existing workflows are implemented to delete the records so use the > delete action for the same. > - Need to convert Update and Delete services. Create can not be converted due > to some conditional code. Keep the existing services names as is. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-9526) MRP generates duplicate requirements when items are initially under minimum quantity and have with pending approved purchase orders.
Jacopo Cappellato created OFBIZ-9526: Summary: MRP generates duplicate requirements when items are initially under minimum quantity and have with pending approved purchase orders. Key: OFBIZ-9526 URL: https://issues.apache.org/jira/browse/OFBIZ-9526 Project: OFBiz Issue Type: Bug Components: manufacturing Affects Versions: 16.11.03, Trunk Reporter: Jacopo Cappellato Assignee: Jacopo Cappellato -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9525) MRP incorrectly computes quantity already received in open purchase order shipments
[ https://issues.apache.org/jira/browse/OFBIZ-9525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-9525: - Affects Version/s: 16.11.03 > MRP incorrectly computes quantity already received in open purchase order > shipments > --- > > Key: OFBIZ-9525 > URL: https://issues.apache.org/jira/browse/OFBIZ-9525 > Project: OFBiz > Issue Type: Bug > Components: manufacturing >Affects Versions: Trunk, 16.11.03 >Reporter: Jacopo Cappellato >Assignee: Jacopo Cappellato > > The MRP algorithm incorrectly computes the quantity of items partially > received in a purchase shipment because it leverages the > OrderReadHelper.getItemShippedQuantity(...) method that is intended to be > used to count the quantity shipped of a sales order. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-9525) MRP incorrectly computes quantity already received in open purchase order shipments
Jacopo Cappellato created OFBIZ-9525: Summary: MRP incorrectly computes quantity already received in open purchase order shipments Key: OFBIZ-9525 URL: https://issues.apache.org/jira/browse/OFBIZ-9525 Project: OFBiz Issue Type: Bug Components: manufacturing Affects Versions: Trunk Reporter: Jacopo Cappellato Assignee: Jacopo Cappellato The MRP algorithm incorrectly computes the quantity of items partially received in a purchase shipment because it leverages the OrderReadHelper.getItemShippedQuantity(...) method that is intended to be used to count the quantity shipped of a sales order. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9524) Uploading content to a product email is not working
[
https://issues.apache.org/jira/browse/OFBIZ-9524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pranay Pandey updated OFBIZ-9524:
-
Summary: Uploading content to a product email is not working (was:
Uploading content to a product email is now working )
> Uploading content to a product email is not working
>
>
> Key: OFBIZ-9524
> URL: https://issues.apache.org/jira/browse/OFBIZ-9524
> Project: OFBiz
> Issue Type: Bug
> Components: scrum
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>
> The feature to upload content to a product email in SCRUM component is not
> working properly. I followed the below steps:
> * Go to SCRUM main page.
> (https://demo-trunk.ofbiz.apache.org/scrum/control/main)
> * Select a product.
> (https://demo-trunk.ofbiz.apache.org/scrum/control/ViewProduct?productId=DEMO-PRODUCT-1)
> * Click on Communications menu item.
> (https://demo-trunk.ofbiz.apache.org/scrum/control/ProductEmails?productId=DEMO-PRODUCT-1)
> * Click on the (New Email) button.
> (https://demo-trunk.ofbiz.apache.org/scrum/control/NewProductEmail)
> * On the right side panel, upload a file.
> * Click on the (Upload) button.
> The uploaded file is not getting uploaded and giving below error
> {code}
> Uncaught TypeError: Cannot read property 'datetimeStarted' of undefined
> at :1:55
> (anonymous) @ VM427:1
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Reopened] (OFBIZ-8273) Improvements in Lot entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reopened OFBIZ-8273: - > Improvements in Lot entity definition and services > -- > > Key: OFBIZ-8273 > URL: https://issues.apache.org/jira/browse/OFBIZ-8273 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Deepak Dixit >Priority: Minor > Fix For: Upcoming Release > > Attachments: OFBIZ-8273_02.patch, OFBIZ-8273.patch > > > Required improvements; > - All is good with entity definition . > - Add CRUD services using entity-auto. Make sure PK is optional while create > service, so that can be generated from OFBiz sequence generator. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. > Note: Require to change the delegator calls in ProductionRunServices.java and > InventoryServices.xml -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-8273) Improvements in Lot entity definition and services
[ https://issues.apache.org/jira/browse/OFBIZ-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16098003#comment-16098003 ] Deepak Dixit commented on OFBIZ-8273: - Thanks Devanshu for your contribution, Slightly modified patch has been committed at framework trunk at r#1802755 > Improvements in Lot entity definition and services > -- > > Key: OFBIZ-8273 > URL: https://issues.apache.org/jira/browse/OFBIZ-8273 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Rishi Solanki >Assignee: Deepak Dixit >Priority: Minor > Fix For: Upcoming Release > > Attachments: OFBIZ-8273_02.patch, OFBIZ-8273.patch > > > Required improvements; > - All is good with entity definition . > - Add CRUD services using entity-auto. Make sure PK is optional while create > service, so that can be generated from OFBiz sequence generator. > - Do related changes if any occurrence found for direct create/update/delete > of this entity, and replace them with crud services implemented. > - As no status/from date/thru date exists in entity, so nothing needs to be > taken care while deleting the records from service. > Note: Require to change the delegator calls in ProductionRunServices.java and > InventoryServices.xml -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (OFBIZ-9519) User should be notified with success message on Update Quote page
[ https://issues.apache.org/jira/browse/OFBIZ-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranay Pandey reassigned OFBIZ-9519: Assignee: Pranay Pandey (was: Sonal Patwari) > User should be notified with success message on Update Quote page > - > > Key: OFBIZ-9519 > URL: https://issues.apache.org/jira/browse/OFBIZ-9519 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Pranay Pandey >Priority: Minor > Attachments: OFBIZ-9519.patch > > > Steps to regenerate: > 1. Go to Order component (https://localhost:8443/ordermgr/control/main) > 2. Click on Quotes submenu (directing to > https://localhost:8443/ordermgr/control/FindQuote) > 3. Click on Find button. > 4. Click on any quoteId (directing to > https://localhost:8443/ordermgr/control/ViewQuote?quoteId=CQ0001) > 5. Click on Quote link from the submenu > (https://localhost:8443/ordermgr/control/EditQuote?quoteId=CQ0001) > 6. Make changes and Click on Submit button. > No success message. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (OFBIZ-9516) User should be notified with success message on Creating New Routing
[ https://issues.apache.org/jira/browse/OFBIZ-9516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranay Pandey reassigned OFBIZ-9516: Assignee: Pranay Pandey (was: Sonal Patwari) > User should be notified with success message on Creating New Routing > > > Key: OFBIZ-9516 > URL: https://issues.apache.org/jira/browse/OFBIZ-9516 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Pranay Pandey >Priority: Trivial > Attachments: OFBIZ-9516.patch > > > Steps to regenerate: > 1. Go to Manufacturing component > (https://localhost:8443/manufacturing/control/main) > 2. Click on Routing sub menu > (https://localhost:8443/manufacturing/control/FindRouting) > 3. Click on New Routing > button.(https://localhost:8443/manufacturing/control/EditRouting) > 4. Fill required fields and Click Submit button. > 7. On success, the user should be notified with success message. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
