[jira] [Assigned] (OFBIZ-7253) UI issue on web pos for different themes
[ https://issues.apache.org/jira/browse/OFBIZ-7253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yogesh Naroliya reassigned OFBIZ-7253: -- Assignee: Yogesh Naroliya > UI issue on web pos for different themes > > > Key: OFBIZ-7253 > URL: https://issues.apache.org/jira/browse/OFBIZ-7253 > Project: OFBiz > Issue Type: Bug > Components: webpos >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Anurag Chandak >Assignee: Yogesh Naroliya > Fix For: Upcoming Release > > > Steps to regenerate: > - Go to web pos > - Do login with any terminal > - UI of "Cart", "Browse Categories" and "Products from this category" > screenlets are not proper. > NOTE: This issue is found on the Flat Grey theme. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-9624) NullPointerException when calling EntityQuery#getFieldList
[
https://issues.apache.org/jira/browse/OFBIZ-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-9624.
--
Resolution: Fixed
Fix Version/s: 16.11.04
Thanks Tobias,
Your patch is in
trunk r1806220
R16.11 r1806221
Previous releases branches not concerned
> NullPointerException when calling EntityQuery#getFieldList
> --
>
> Key: OFBIZ-9624
> URL: https://issues.apache.org/jira/browse/OFBIZ-9624
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Tobias Laufkötter
>Assignee: Jacques Le Roux
> Fix For: 16.11.04
>
> Attachments: OFBIZ-9624.patch
>
>
> When performing {{EntityQuery#getFieldList}} without specifying {{distinct}}
> a {{NullPointerException}} is thrown, because of the condition {{if
> (this.distinct)}}. It implicitly calls {{this.distinct.booleanValue()}} which
> throws the exception if {{distinct}} is {{null}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (OFBIZ-9624) NullPointerException when calling EntityQuery#getFieldList
[
https://issues.apache.org/jira/browse/OFBIZ-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reassigned OFBIZ-9624:
--
Assignee: Jacques Le Roux
> NullPointerException when calling EntityQuery#getFieldList
> --
>
> Key: OFBIZ-9624
> URL: https://issues.apache.org/jira/browse/OFBIZ-9624
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Tobias Laufkötter
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-9624.patch
>
>
> When performing {{EntityQuery#getFieldList}} without specifying {{distinct}}
> a {{NullPointerException}} is thrown, because of the condition {{if
> (this.distinct)}}. It implicitly calls {{this.distinct.booleanValue()}} which
> throws the exception if {{distinct}} is {{null}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (OFBIZ-9623) Improvements in LabelReferences class
[
https://issues.apache.org/jira/browse/OFBIZ-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reassigned OFBIZ-9623:
--
Assignee: Jacques Le Roux (was: Suraj Khurana)
> Improvements in LabelReferences class
> -
>
> Key: OFBIZ-9623
> URL: https://issues.apache.org/jira/browse/OFBIZ-9623
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Suraj Khurana
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-9623.patch
>
>
> For Java:
> Current support is only for occurrences like "UtilProperties.getMessage(",
> but there are other occurrences such as "uiLabelMap.get(" in java as well.
> Need to add support for same.
> For groovy:
> After some recent improvements for groovy handling, still, there is a
> possibility that someone is using "UtilProperties.getMessage(" in groovy
> files as well, so IMO, that must also be handled.
> For XML forms:
> In XML forms current support in handled for auto-fields-service and
> auto-fields-entity but there are some occurrences of tooltip element of field
> tag as well, that must also be handled.
> For XML Simple Methods:
> Doesn't handle case of property-to-field and default-message elements.
> (Separate ticket created OFBIZ-9606, just adding it here for reference)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142046#comment-16142046 ] Deepak Dixit edited comment on OFBIZ-9138 at 8/25/17 7:06 PM: -- Fixed COMMON theme id display issue, removed the visualThemeSetId from COMMON theme at r#1806216 was (Author: deepak.dixit): Fixed COMMON theme id display issue, removed the visualThemeSetId from COMMON theme. > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142046#comment-16142046 ] Deepak Dixit commented on OFBIZ-9138: - Fixed COMMON theme id display issue, removed the visualThemeSetId from COMMON theme. > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142026#comment-16142026 ] Deepak Dixit commented on OFBIZ-9138: - Need to hide COMMON theme id from set visual theme popup. > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-5776) Move static resources from framework/images to framework/resources webapp
[ https://issues.apache.org/jira/browse/OFBIZ-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142002#comment-16142002 ] Deepak Dixit edited comment on OFBIZ-5776 at 8/25/17 6:39 PM: -- Thanks Nicolas, I think I wrote too short :) Proposal is to move js/css/images from common-theme/webapp/images to common-theme/webapp/common and then will remove the common-theme/webapp/images. So new structure will be as follow common-theme/webapp/common/js common-theme/webapp/common/css common-theme/webapp/common/images So no need to create new webapp in themes/common/ofbiz-component.xml. was (Author: deepak.dixit): Thanks Nicolas, I think I wrote in too short :), We will move js/css/images(realted) from common-theme/webapp/images to common-theme/webapp/common and then will remove the common-theme/webapp/images. So new structure looks like common-theme/webapp/common/js common-theme/webapp/common/css common-theme/webapp/common/images So no need to create new webapp in themes/common/ofbiz-component.xml. > Move static resources from framework/images to framework/resources webapp > - > > Key: OFBIZ-5776 > URL: https://issues.apache.org/jira/browse/OFBIZ-5776 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-5776.patch > > > Move all the static resources form images webapp to resources webapp, as they > all are more related to resources rather then images. > Also we need to rearrange these resources based on their purpose, like > - Move all js related files and plugins under resources/js > - Move all the css related files and plugins under resources/css > - Move all the images related to js and css under resources/images or > resources/img -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-5776) Move static resources from framework/images to framework/resources webapp
[ https://issues.apache.org/jira/browse/OFBIZ-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142002#comment-16142002 ] Deepak Dixit commented on OFBIZ-5776: - Thanks Nicolas, I think I wrote in too short :), We will move js/css/images(realted) from common-theme/webapp/images to common-theme/webapp/common and then will remove the common-theme/webapp/images. So new structure looks like common-theme/webapp/common/js common-theme/webapp/common/css common-theme/webapp/common/images So no need to create new webapp in themes/common/ofbiz-component.xml. > Move static resources from framework/images to framework/resources webapp > - > > Key: OFBIZ-5776 > URL: https://issues.apache.org/jira/browse/OFBIZ-5776 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-5776.patch > > > Move all the static resources form images webapp to resources webapp, as they > all are more related to resources rather then images. > Also we need to rearrange these resources based on their purpose, like > - Move all js related files and plugins under resources/js > - Move all the css related files and plugins under resources/css > - Move all the images related to js and css under resources/images or > resources/img -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141809#comment-16141809 ] Jacques Le Roux commented on OFBIZ-9138: Thanks Nicolas, This is quite an achievement! Just that we have an issue with scrum tests https://ci.apache.org/projects/ofbiz/logs/trunk/html/ I checked locally it's the same. We know the scrum does not always follow the best practices, so it could be that we need to improve the code or even the tests there... > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-9640) [FB] Package org.apache.ofbiz.common.preferences
[
https://issues.apache.org/jira/browse/OFBIZ-9640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141717#comment-16141717
]
Dennis Balkir edited comment on OFBIZ-9640 at 8/25/17 2:56 PM:
---
- Diamond Operators fixed
- Line 90: removed {{userLoginIdArg != null &&}}, because it was unnecessary
was (Author: dennis balkir):
- Diamond Operators fixed
- Line 90: removed {{userLoginIdArg != null && }}, because it was unnecessary
> [FB] Package org.apache.ofbiz.common.preferences
>
>
> Key: OFBIZ-9640
> URL: https://issues.apache.org/jira/browse/OFBIZ-9640
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments:
> OFBIZ-9640_org.apache.ofbiz.common.preferences_bugfixes.patch
>
>
> - PreferenceWorker.java:90, RpC_REPEATED_CONDITIONAL_TEST
> RpC: Repeated conditional test in
> org.apache.ofbiz.common.preferences.PreferenceWorker.checkCopyPermission(DispatchContext,
> Map)
> The code contains a conditional test is performed twice, one right after the
> other (e.g., x == 0 || x == 0). Perhaps the second occurrence is intended to
> be something else (e.g., x == 0 || y == 0).
> - PreferenceWorker.java:90, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
> RCN: Redundant nullcheck of userLoginIdArg, which is known to be non-null in
> org.apache.ofbiz.common.preferences.PreferenceWorker.checkCopyPermission(DispatchContext,
> Map)
> This method contains a redundant check of a known non-null value against the
> constant null.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-9640) [FB] Package org.apache.ofbiz.common.preferences
[
https://issues.apache.org/jira/browse/OFBIZ-9640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Balkir updated OFBIZ-9640:
-
Attachment: OFBIZ-9640_org.apache.ofbiz.common.preferences_bugfixes.patch
- Diamond Operators fixed
- Line 90: removed {{userLoginIdArg != null && }}, because it was unnecessary
> [FB] Package org.apache.ofbiz.common.preferences
>
>
> Key: OFBIZ-9640
> URL: https://issues.apache.org/jira/browse/OFBIZ-9640
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments:
> OFBIZ-9640_org.apache.ofbiz.common.preferences_bugfixes.patch
>
>
> - PreferenceWorker.java:90, RpC_REPEATED_CONDITIONAL_TEST
> RpC: Repeated conditional test in
> org.apache.ofbiz.common.preferences.PreferenceWorker.checkCopyPermission(DispatchContext,
> Map)
> The code contains a conditional test is performed twice, one right after the
> other (e.g., x == 0 || x == 0). Perhaps the second occurrence is intended to
> be something else (e.g., x == 0 || y == 0).
> - PreferenceWorker.java:90, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
> RCN: Redundant nullcheck of userLoginIdArg, which is known to be non-null in
> org.apache.ofbiz.common.preferences.PreferenceWorker.checkCopyPermission(DispatchContext,
> Map)
> This method contains a redundant check of a known non-null value against the
> constant null.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (OFBIZ-9640) [FB] Package org.apache.ofbiz.common.preferences
Dennis Balkir created OFBIZ-9640: Summary: [FB] Package org.apache.ofbiz.common.preferences Key: OFBIZ-9640 URL: https://issues.apache.org/jira/browse/OFBIZ-9640 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Dennis Balkir Priority: Minor - PreferenceWorker.java:90, RpC_REPEATED_CONDITIONAL_TEST RpC: Repeated conditional test in org.apache.ofbiz.common.preferences.PreferenceWorker.checkCopyPermission(DispatchContext, Map) The code contains a conditional test is performed twice, one right after the other (e.g., x == 0 || x == 0). Perhaps the second occurrence is intended to be something else (e.g., x == 0 || y == 0). - PreferenceWorker.java:90, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE RCN: Redundant nullcheck of userLoginIdArg, which is known to be non-null in org.apache.ofbiz.common.preferences.PreferenceWorker.checkCopyPermission(DispatchContext, Map) This method contains a redundant check of a known non-null value against the constant null. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-9639) [FB] Package org.apache.ofbiz.catalina.container
Dennis Balkir created OFBIZ-9639: Summary: [FB] Package org.apache.ofbiz.catalina.container Key: OFBIZ-9639 URL: https://issues.apache.org/jira/browse/OFBIZ-9639 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Dennis Balkir Priority: Minor - CatalinaContainer.java:248, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE RCN: Redundant nullcheck of clusterProps, which is known to be non-null in org.apache.ofbiz.catalina.container.CatalinaContainer.prepareTomcatClustering(Host, ContainerConfig$Configuration$Property) This method contains a redundant check of a known non-null value against the constant null. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9639) [FB] Package org.apache.ofbiz.catalina.container
[
https://issues.apache.org/jira/browse/OFBIZ-9639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Balkir updated OFBIZ-9639:
-
Attachment: OFBIZ-9639_org.apache.ofbiz.catalina_bugfixes.patch
- Diamond Operators fixed
- deleted unnecessary else-blocks
- Line 247: deleted unnecessary nullcheck of {{clusterProps}}
> [FB] Package org.apache.ofbiz.catalina.container
>
>
> Key: OFBIZ-9639
> URL: https://issues.apache.org/jira/browse/OFBIZ-9639
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: OFBIZ-9639_org.apache.ofbiz.catalina_bugfixes.patch
>
>
> - CatalinaContainer.java:248, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
> RCN: Redundant nullcheck of clusterProps, which is known to be non-null in
> org.apache.ofbiz.catalina.container.CatalinaContainer.prepareTomcatClustering(Host,
> ContainerConfig$Configuration$Property)
> This method contains a redundant check of a known non-null value against the
> constant null.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-9638) [FB] Package org.apache.ofbiz.service
[
https://issues.apache.org/jira/browse/OFBIZ-9638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Balkir updated OFBIZ-9638:
-
Attachment: OFBIZ-9638_org.apache.ofbiz.service_bugfixes.patch
- Diamond Operators fixed
- removed unnecessary else
class DispatchContext:
- Line 56: it’s not necessary for the class to implement serialVerisonUID
- Line 62, 63: didn’t change anything, this is intentionally programmed like
this
- Line: 208: removed if phrase, because serviceMap cannot be null at this
point, since getGlobalServiceMap cannot return null
- Line 270: removed if phrase, since serviceMap cannot be null at this point;
it is at least declared as a new HashMap, which is not null
class GeneralServiceException:
- Line 34: couldn’t find the circular dependency, maybe there is none?
- Line 63: didn’t remove the if clause. it seems to be unnecessary, but the
method getNested claims in its javadoc that is returns null, when there is no
nested exception, although the code itself seems not to return null at all.
maybe an old version of the javadoc? maybe a mistake?
class GenericAbstractDispatcher:
- added a catch for RuntimeException
class GenericDispatcherFacory:
- Line 32: made the parameter private
- Line 51: made the inner class static
- other two errors were resolved automatically through the previously made
changes
class GenericResultWaiter:
- Line 29: serialVersionUID doesn’t have to be implemented
- Line 52, 64: seems like this was intended
class ModelParam:
- Line 41: it’s not necessary for the class to implement serialVerisonUID
- implemented a generic equals method, to prevent potential errors
- didn’t implement hashCode, because it is not necessary
- Line 303: it’s not necessary for the class to implement serialVerisonUID
class ModelPermGroup:
- it’s not necessary for the class to implement serialVerisonUID
class ModelPermission:
- it’s not necessary for the class to implement serialVerisonUID
- Line 128: removed
{code:java}
if (permission == null) {
Debug.logError("No ModelService found with the name [" +
permissionServiceName + "]", module);
return false;
{code}
because, permission cannot be null at this point
- Line 146: put null inside the logError instead of failMessage, because
failMessage can only be null at this point; this is easier to read and to
understand
class ModelService:
- Line 85: it’s not necessary for the class to implement serialVerisonUID
- Line 335: added a if phrase, to check if there is a next object, otherwise
will throw a new NoSuchElementException; ignored the circular class dependency
- Line 391: changed the method inheritedParameters() to synchronized
- Line 489: removed if phrase, because params cannot be null at this point
- Line 998: removed if phrase, permission cannot be null at this point
- Line 1005: removed else if; unnecessary, thisService cannot be null at this
point
- Line 1260: removed if phrase, because param cannot be null at this point
- Line 1312: removed implementation of {{documentation}} because now it was
double implemented
- Line 1304: removed if phrase, because outParam cannot be null at this point
class ModelServiceReader:
- Line 60: it’s not necessary for the class to implement serialVerisonUID
- Line 154: removed unnecessary if phrase, because parameter service cannot be
null at this point
- also removed the belonging else phrase, because there was no more if
- Line 111: deleted
{code:java}
if (this.isFromURL) {// utilTimer.timerString("Before getDocumentElement in
file " + readerURL);
} else {// utilTimer.timerString("Before getDocumentElement in " +
handler);
}
{code}
because the code in this section was commented out and the whole part had no
purpose anymore
- Line 442: removed if phrase, because fieldsIter cannot be null at this point
class RunningService:
- Line 59: returned a clone instead of the original object
- Line 63: returned a clone instead of the original object
- Line 72: didn’t implement hashCode() because it seems not to be necessary here
class ServiceContainer:
- Line 38: circular dependency isn’t really an issue
- Line 57: a non static method, which cannot be made static because it is
overridden, writes in a static field. maybe this can be done somehow different,
i will ask this in jira
At line 96, dispatcherFactory is used, but it may not have been initialized at
this point
class ServiceDispatcher:
- Line 73, 76, 77, 78: changed the parameters from protected to private
- Line 102: removed one if phrase, because this if phrase and the own above
(Line 95) check the same
- Line 122: added an if phrase, to prevent {{NullPointerException}}
- Line 426: added default Locale to {{toUpperCase}}
- Line 464: deleted nullcheck, because this if phrase is inside another if
phrase, which already has the same nullcheck after which nothing is changed in
{{errMsg}}
- Line 464: this findbugs-error
[jira] [Created] (OFBIZ-9638) [FB] Package org.apache.ofbiz.service
Dennis Balkir created OFBIZ-9638:
Summary: [FB] Package org.apache.ofbiz.service
Key: OFBIZ-9638
URL: https://issues.apache.org/jira/browse/OFBIZ-9638
Project: OFBiz
Issue Type: Sub-task
Components: framework
Affects Versions: Trunk
Reporter: Dennis Balkir
Priority: Minor
- DispatchContext.java:-1, SE_TRANSIENT_FIELD_NOT_RESTORED
Se: The field org.apache.ofbiz.service.DispatchContext.loader is transient but
isn't set by deserialization
This class contains a field that is updated at multiple places in the class,
thus it seems to be part of the state of the class. However, since the field is
marked as transient and not set in readObject or readResolve, it will contain
the default value in any deserialized instance of the class.
- DispatchContext.java:-1, SE_TRANSIENT_FIELD_NOT_RESTORED
Se: The field org.apache.ofbiz.service.DispatchContext.dispatcher is transient
but isn't set by deserialization
This class contains a field that is updated at multiple places in the class,
thus it seems to be part of the state of the class. However, since the field is
marked as transient and not set in readObject or readResolve, it will contain
the default value in any deserialized instance of the class.
- DispatchContext.java:56, SE_NO_SERIALVERSIONID
SnVI: org.apache.ofbiz.service.DispatchContext is Serializable; consider
declaring a serialVersionUID
This class implements the Serializable interface, but does not define a
serialVersionUID field. A change as simple as adding a reference to a .class
object will add synthetic fields to the class, which will unfortunately change
the implicit serialVersionUID (e.g., adding a reference to String.class will
generate a static field class$java$lang$String). Also, different source code to
bytecode compilers may use different naming conventions for synthetic variables
generated for references to class objects or inner classes. To ensure
interoperability of Serializable across versions, consider adding an explicit
serialVersionUID.
- DispatchContext.java:209, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
RCN: Redundant nullcheck of serviceMap, which is known to be non-null in
org.apache.ofbiz.service.DispatchContext.getModelService(String)
This method contains a redundant check of a known non-null value against the
constant null.
- DispatchContext.java:273, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
RCN: Redundant nullcheck of serviceMap, which is known to be non-null in
org.apache.ofbiz.service.DispatchContext.getGlobalServiceMap()
This method contains a redundant check of a known non-null value against the
constant null.
- GeneralServiceException.java:63, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
RCN: Redundant nullcheck of
org.apache.ofbiz.base.util.GeneralException.getNested(), which is known to be
non-null in org.apache.ofbiz.service.GeneralServiceException.returnError(String)
This method contains a redundant check of a known non-null value against the
constant null.
- GenericAbstractDispatcher.java:86, REC_CATCH_EXCEPTION
REC: Exception is caught when Exception is not thrown in
org.apache.ofbiz.service.GenericAbstractDispatcher.schedule(String, String,
String, Map, long, int, int, int, long, int)
This method uses a try-catch block that catches Exception objects, but
Exception is not thrown within the try block, and RuntimeException is not
explicitly caught. It is a common bug pattern to say try { ... } catch
(Exception e) { something } as a shorthand for catching a number of types of
exception each of whose catch blocks is identical, but this construct also
accidentally catches RuntimeException as well, masking potential bugs.
A better approach is to either explicitly catch the specific exceptions that
are thrown, or to explicitly catch RuntimeException exception, rethrow it, and
then catch all non-Runtime Exceptions, as shown below:
try {
...
} catch (RuntimeException e) {
throw e;
} catch (Exception e) {
... deal with all non-runtime exceptions ...
}
- GenericDispatcherFactory.java:32, MS_PKGPROTECT
MS: org.apache.ofbiz.service.GenericDispatcherFactory.ecasDisabled should be
package protected
A mutable static field could be changed by malicious code or by accident. The
field could be made package protected to avoid this vulnerability.
- GenericDispatcherFactory.java:49, SIC_INNER_SHOULD_BE_STATIC
SIC: Should org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher
be a _static_ inner class?
This class is an inner class, but does not use its embedded reference to the
object which created it. This reference makes the instances of the class
larger, and may keep the reference to the creator object alive longer than
necessary. If possible, the class should be made static.
- GenericDispatcherFactory.java:72, ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD
ST:
[jira] [Updated] (OFBIZ-9637) [FB] Package org.apache.ofbiz.securityext.login
[
https://issues.apache.org/jira/browse/OFBIZ-9637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Balkir updated OFBIZ-9637:
-
Attachment: OFBIZ-9637_org.apache.ofbiz.securityext_bugfixes.patch
- Line 89: added a default Locale to {{toLowerCase}}
- Line 92: added a default Locale to {{toLowerCase}}
- Line 163: added a default Locale to {{toLowerCase}}
- Line 223: added a default Locale to {{toLowerCase}}
- Line 248: added a default Locale to {{toLowerCase}}
- Line 253: removed unnecessary casting from String to Object
- Line 284: deleted unnecessary allocation of null -> if the try is executed
properly, party won’t get allocated with null, it it isn’t executed properly
and the program executes the catch, party is already null since it was declared
as null in line 279
- Line 419: changed the code, so that {{cookies}} is casted to a String properly
- Last error: added an encoder, which prevents vulnerability through using
untrusted parameters to construct a HTTPCookie
> [FB] Package org.apache.ofbiz.securityext.login
> ---
>
> Key: OFBIZ-9637
> URL: https://issues.apache.org/jira/browse/OFBIZ-9637
> Project: OFBiz
> Issue Type: Sub-task
> Components: securityext
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: OFBIZ-9637_org.apache.ofbiz.securityext_bugfixes.patch
>
>
> - LoginEvents.java:88, DM_CONVERT_CASE
> Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in
> org.apache.ofbiz.securityext.login.LoginEvents.saveEntryParams(HttpServletRequest,
> HttpServletResponse)
> A String is being converted to upper or lowercase, using the platform's
> default encoding. This may result in improper conversions when used with
> international characters. Use the
> String.toUpperCase( Locale l )
> String.toLowerCase( Locale l )
> versions instead.
> - LoginEvents.java:162, DM_CONVERT_CASE
> Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in
> org.apache.ofbiz.securityext.login.LoginEvents.showPasswordHint(HttpServletRequest,
> HttpServletResponse)
> A String is being converted to upper or lowercase, using the platform's
> default encoding. This may result in improper conversions when used with
> international characters. Use the
> String.toUpperCase( Locale l )
> String.toLowerCase( Locale l )
> versions instead.
> - LoginEvents.java:222, DM_CONVERT_CASE
> Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in
> org.apache.ofbiz.securityext.login.LoginEvents.emailPassword(HttpServletRequest,
> HttpServletResponse)
> A String is being converted to upper or lowercase, using the platform's
> default encoding. This may result in improper conversions when used with
> international characters. Use the
> String.toUpperCase( Locale l )
> String.toLowerCase( Locale l )
> versions instead.
> - LoginEvents.java:417, DMI_INVOKING_TOSTRING_ON_ARRAY
> USELESS_STRING: Invocation of toString on cookies in
> org.apache.ofbiz.securityext.login.LoginEvents.getUsername(HttpServletRequest)
> The code invokes toString on an array, which will generate a fairly useless
> result such as [C@16f0472. Consider using Arrays.toString to convert the
> array into a readable String that gives the contents of the array. See
> Programming Puzzlers, chapter 3, puzzle 12.
> - LoginEvents.java:437, HRS_REQUEST_PARAMETER_TO_COOKIE
> HRS: HTTP cookie formed from untrusted input in
> org.apache.ofbiz.securityext.login.LoginEvents.setUsername(HttpServletRequest,
> HttpServletResponse)
> This code constructs an HTTP Cookie using an untrusted HTTP parameter. If
> this cookie is added to an HTTP response, it will allow a HTTP response
> splitting vulnerability. See
> http://en.wikipedia.org/wiki/HTTP_response_splitting for more information.
> FindBugs looks only for the most blatant, obvious cases of HTTP response
> splitting. If FindBugs found any, you almost certainly have more
> vulnerabilities that FindBugs doesn't report. If you are concerned about HTTP
> response splitting, you should seriously consider using a commercial static
> analysis or pen-testing tool.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (OFBIZ-9637) [FB] Package org.apache.ofbiz.securityext.login
Dennis Balkir created OFBIZ-9637: Summary: [FB] Package org.apache.ofbiz.securityext.login Key: OFBIZ-9637 URL: https://issues.apache.org/jira/browse/OFBIZ-9637 Project: OFBiz Issue Type: Sub-task Components: securityext Affects Versions: Trunk Reporter: Dennis Balkir Priority: Minor - LoginEvents.java:88, DM_CONVERT_CASE Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.ofbiz.securityext.login.LoginEvents.saveEntryParams(HttpServletRequest, HttpServletResponse) A String is being converted to upper or lowercase, using the platform's default encoding. This may result in improper conversions when used with international characters. Use the String.toUpperCase( Locale l ) String.toLowerCase( Locale l ) versions instead. - LoginEvents.java:162, DM_CONVERT_CASE Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.ofbiz.securityext.login.LoginEvents.showPasswordHint(HttpServletRequest, HttpServletResponse) A String is being converted to upper or lowercase, using the platform's default encoding. This may result in improper conversions when used with international characters. Use the String.toUpperCase( Locale l ) String.toLowerCase( Locale l ) versions instead. - LoginEvents.java:222, DM_CONVERT_CASE Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.ofbiz.securityext.login.LoginEvents.emailPassword(HttpServletRequest, HttpServletResponse) A String is being converted to upper or lowercase, using the platform's default encoding. This may result in improper conversions when used with international characters. Use the String.toUpperCase( Locale l ) String.toLowerCase( Locale l ) versions instead. - LoginEvents.java:417, DMI_INVOKING_TOSTRING_ON_ARRAY USELESS_STRING: Invocation of toString on cookies in org.apache.ofbiz.securityext.login.LoginEvents.getUsername(HttpServletRequest) The code invokes toString on an array, which will generate a fairly useless result such as [C@16f0472. Consider using Arrays.toString to convert the array into a readable String that gives the contents of the array. See Programming Puzzlers, chapter 3, puzzle 12. - LoginEvents.java:437, HRS_REQUEST_PARAMETER_TO_COOKIE HRS: HTTP cookie formed from untrusted input in org.apache.ofbiz.securityext.login.LoginEvents.setUsername(HttpServletRequest, HttpServletResponse) This code constructs an HTTP Cookie using an untrusted HTTP parameter. If this cookie is added to an HTTP response, it will allow a HTTP response splitting vulnerability. See http://en.wikipedia.org/wiki/HTTP_response_splitting for more information. FindBugs looks only for the most blatant, obvious cases of HTTP response splitting. If FindBugs found any, you almost certainly have more vulnerabilities that FindBugs doesn't report. If you are concerned about HTTP response splitting, you should seriously consider using a commercial static analysis or pen-testing tool. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9632) Cannot create new accounting company
[ https://issues.apache.org/jira/browse/OFBIZ-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141670#comment-16141670 ] Santiago José Santana commented on OFBIZ-9632: -- Thanks Sharan, i will try with the new version. > Cannot create new accounting company > > > Key: OFBIZ-9632 > URL: https://issues.apache.org/jira/browse/OFBIZ-9632 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Santiago José Santana >Assignee: Sharan Foga >Priority: Minor > > Hi > In the current 16.11 release you cannot create a new accounting company > manually. When I try I get a blank page. [http://i.imgur.com/B89t9ls.png] > Steps to recreate the error: > 1. Go to Accounting / Organization GL Settings > 2. Click create new accounting company > 3. Select an Organization Party ID > 4. Click create new accounting company > Thanks > Santiago -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-9622) Errors on orderview page
[ https://issues.apache.org/jira/browse/OFBIZ-9622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-9622. > Errors on orderview page > > > Key: OFBIZ-9622 > URL: https://issues.apache.org/jira/browse/OFBIZ-9622 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Nicolas Malin > Fix For: Upcoming Release > > Attachments: screenshot-1.png > > > Steps to regenerate: > 1. Go to Order Component > (https://demo-trunk.ofbiz.apache.org/ordermgr/control/main) > 2. Click on orderlist from > submenu(https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist) > 3. Click on OrderNbr link > (https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=DEMO10090) > Errors on ShippingInformation section and screenrendering error below that. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9622) Errors on orderview page
[ https://issues.apache.org/jira/browse/OFBIZ-9622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141666#comment-16141666 ] Aditya Sharma commented on OFBIZ-9622: -- It's working fine now. Thanks Nicolas. You are doing remarkable work :) > Errors on orderview page > > > Key: OFBIZ-9622 > URL: https://issues.apache.org/jira/browse/OFBIZ-9622 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Nicolas Malin > Fix For: Upcoming Release > > Attachments: screenshot-1.png > > > Steps to regenerate: > 1. Go to Order Component > (https://demo-trunk.ofbiz.apache.org/ordermgr/control/main) > 2. Click on orderlist from > submenu(https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist) > 3. Click on OrderNbr link > (https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=DEMO10090) > Errors on ShippingInformation section and screenrendering error below that. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (OFBIZ-9622) Errors on orderview page
[ https://issues.apache.org/jira/browse/OFBIZ-9622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma resolved OFBIZ-9622. -- Resolution: Fixed > Errors on orderview page > > > Key: OFBIZ-9622 > URL: https://issues.apache.org/jira/browse/OFBIZ-9622 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Nicolas Malin > Fix For: Upcoming Release > > Attachments: screenshot-1.png > > > Steps to regenerate: > 1. Go to Order Component > (https://demo-trunk.ofbiz.apache.org/ordermgr/control/main) > 2. Click on orderlist from > submenu(https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist) > 3. Click on OrderNbr link > (https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=DEMO10090) > Errors on ShippingInformation section and screenrendering error below that. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-9632) Cannot create new accounting company
[ https://issues.apache.org/jira/browse/OFBIZ-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharan Foga closed OFBIZ-9632. -- Resolution: Duplicate Assignee: Sharan Foga Issue already reported in [https://issues.apache.org/jira/browse/OFBIZ-9542] and a fix has been done. > Cannot create new accounting company > > > Key: OFBIZ-9632 > URL: https://issues.apache.org/jira/browse/OFBIZ-9632 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Santiago José Santana >Assignee: Sharan Foga >Priority: Minor > > Hi > In the current 16.11 release you cannot create a new accounting company > manually. When I try I get a blank page. [http://i.imgur.com/B89t9ls.png] > Steps to recreate the error: > 1. Go to Accounting / Organization GL Settings > 2. Click create new accounting company > 3. Select an Organization Party ID > 4. Click create new accounting company > Thanks > Santiago -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-9632) Cannot create new accounting company
[ https://issues.apache.org/jira/browse/OFBIZ-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141654#comment-16141654 ] Sharan Foga edited comment on OFBIZ-9632 at 8/25/17 2:01 PM: - Hi Santiago I reported the same bug [https://issues.apache.org/jira/browse/OFBIZ-9542] and it has been fixed. You many just need to update your version or apply the fix. I will close this as a duplicate. Thanks Sharan was (Author: sharan ): Hi Santiago I reported the same bug [https://issues.apache.org/jira/browse/OFBIZ-9542] and it has been fixed. You many just need to update your version or apply the fix. Thanks Sharan > Cannot create new accounting company > > > Key: OFBIZ-9632 > URL: https://issues.apache.org/jira/browse/OFBIZ-9632 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Santiago José Santana >Priority: Minor > > Hi > In the current 16.11 release you cannot create a new accounting company > manually. When I try I get a blank page. [http://i.imgur.com/B89t9ls.png] > Steps to recreate the error: > 1. Go to Accounting / Organization GL Settings > 2. Click create new accounting company > 3. Select an Organization Party ID > 4. Click create new accounting company > Thanks > Santiago -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9636) Incomplete RoleMember Permission Checks for ROLE_MEMBER in evalRoleMember
[
https://issues.apache.org/jira/browse/OFBIZ-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Balkir updated OFBIZ-9636:
-
Attachment: OFBIZ-9636_incomplete-role-member-evaluation-method.patch
class ModelPermission:
- removed method {{evalRoleMember}}; it was mostly useless, and just returned
false every time is was called (it got changed by jaz in 2009, since then it
doesn’t do anything except returning false, and since it wasn’t used that long
and nobody seemed to need it for 8 years, I decided to remove it and all of its
calls completely)
- removed the case with permissionType {{ROLE_MEMBER}} in {{evalPermission}}
- removed the static parameter {{ROLE_MEMBER}}
class ModelServiceReader:
- removed the part for creating the role-member permissions in
{{createGroupPermissions}}
> Incomplete RoleMember Permission Checks for ROLE_MEMBER in evalRoleMember
> -
>
> Key: OFBIZ-9636
> URL: https://issues.apache.org/jira/browse/OFBIZ-9636
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: OFBIZ-9636_incomplete-role-member-evaluation-method.patch
>
>
> incomplete method {{evalRoleMember(GenericValue userLogin)}} which results in
> this method always and only returning false. This method was last changed by
> jaz in the year 2009.
> I am deleting the method and all of its calls, because it obviously is never
> used, since its last changes are very long ago and since then its kind of
> useless
> PS: you cannot choose package service, when creating new issues
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-9636) Incomplete RoleMember Permission Checks for ROLE_MEMBER in evalRoleMember
[
https://issues.apache.org/jira/browse/OFBIZ-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Balkir updated OFBIZ-9636:
-
Description:
incomplete method {{evalRoleMember(GenericValue userLogin)}} which results in
this method always and only returning false. This method was last changed by
jaz in the year 2009.
I am deleting the method and all of its calls, because it obviously is never
used, since its last changes are very long ago and since then its kind of
useless
PS: you cannot choose package service, when creating new issues
was:
incomplete method {{evalRoleMember(GenericValue userLogin)}} which results in
this method always and only returning false. This method was last changed by
jaz in the year 2009.
I am deleting the method and all of its calls, because it obviously is never
used, since its last changes are very long ago and since then its kind of
useless
> Incomplete RoleMember Permission Checks for ROLE_MEMBER in evalRoleMember
> -
>
> Key: OFBIZ-9636
> URL: https://issues.apache.org/jira/browse/OFBIZ-9636
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: OFBIZ-9636_incomplete-role-member-evaluation-method.patch
>
>
> incomplete method {{evalRoleMember(GenericValue userLogin)}} which results in
> this method always and only returning false. This method was last changed by
> jaz in the year 2009.
> I am deleting the method and all of its calls, because it obviously is never
> used, since its last changes are very long ago and since then its kind of
> useless
> PS: you cannot choose package service, when creating new issues
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-9636) Incomplete RoleMember Permission Checks for ROLE_MEMBER in evalRoleMember
[
https://issues.apache.org/jira/browse/OFBIZ-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Balkir updated OFBIZ-9636:
-
Priority: Minor (was: Major)
> Incomplete RoleMember Permission Checks for ROLE_MEMBER in evalRoleMember
> -
>
> Key: OFBIZ-9636
> URL: https://issues.apache.org/jira/browse/OFBIZ-9636
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
>
> incomplete method {{evalRoleMember(GenericValue userLogin)}} which results in
> this method always and only returning false. This method was last changed by
> jaz in the year 2009.
> I am deleting the method and all of its calls, because it obviously is never
> used, since its last changes are very long ago and since then its kind of
> useless
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9632) Cannot create new accounting company
[ https://issues.apache.org/jira/browse/OFBIZ-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141654#comment-16141654 ] Sharan Foga commented on OFBIZ-9632: Hi Santiago I reported the same bug [https://issues.apache.org/jira/browse/OFBIZ-9542] and it has been fixed. You many just need to update your version or apply the fix. Thanks Sharan > Cannot create new accounting company > > > Key: OFBIZ-9632 > URL: https://issues.apache.org/jira/browse/OFBIZ-9632 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Santiago José Santana >Priority: Minor > > Hi > In the current 16.11 release you cannot create a new accounting company > manually. When I try I get a blank page. [http://i.imgur.com/B89t9ls.png] > Steps to recreate the error: > 1. Go to Accounting / Organization GL Settings > 2. Click create new accounting company > 3. Select an Organization Party ID > 4. Click create new accounting company > Thanks > Santiago -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9635) [FB] Package org.apache.ofbiz.security
[ https://issues.apache.org/jira/browse/OFBIZ-9635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Balkir updated OFBIZ-9635: - Attachment: OFBIZ-9635_org.apache.ofbiz.security_bugfixes.patch - Diamond Operators fixed - Line 90: changed the assigned field to private, since it is a final class and protected is a confusing declaration at this point and the field is only used in this class PS: package security isn't available to choose from, while creating a new sub > [FB] Package org.apache.ofbiz.security > -- > > Key: OFBIZ-9635 > URL: https://issues.apache.org/jira/browse/OFBIZ-9635 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: OFBIZ-9635_org.apache.ofbiz.security_bugfixes.patch > > > SecurityFactory.java:-1, CI_CONFUSED_INHERITANCE, Priorität: Niedrig > CI: Class org.apache.ofbiz.security.SecurityFactory$OFBizSecurity is final > but declares protected field > org.apache.ofbiz.security.SecurityFactory$OFBizSecurity.simpleRoleEntity > This class is declared to be final, but declares fields to be protected. > Since the class is final, it can not be derived from, and the use of > protected is confusing. The access modifier for the field should be changed > to private or public to represent the true use for the field. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-9635) [FB] Package org.apache.ofbiz.security
Dennis Balkir created OFBIZ-9635: Summary: [FB] Package org.apache.ofbiz.security Key: OFBIZ-9635 URL: https://issues.apache.org/jira/browse/OFBIZ-9635 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Dennis Balkir Priority: Minor SecurityFactory.java:-1, CI_CONFUSED_INHERITANCE, Priorität: Niedrig CI: Class org.apache.ofbiz.security.SecurityFactory$OFBizSecurity is final but declares protected field org.apache.ofbiz.security.SecurityFactory$OFBizSecurity.simpleRoleEntity This class is declared to be final, but declares fields to be protected. Since the class is final, it can not be derived from, and the use of protected is confusing. The access modifier for the field should be changed to private or public to represent the true use for the field. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-9634) [FB] Package org.apache.ofbiz.common.uom
[
https://issues.apache.org/jira/browse/OFBIZ-9634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141619#comment-16141619
]
Dennis Balkir edited comment on OFBIZ-9634 at 8/25/17 1:35 PM:
---
- Diamond Operators fixed
- Line 70: changes not necessary
- Line 107: deleted {{= new LinkedHashMap<>()}} because it is not necessary at
this point
was (Author: dennis balkir):
- Diamond Operators fixed
- Line 70: changes not necessary
- Line 107: deleted {{ = new LinkedHashMap<>()}} because it is not necessary at
this point
> [FB] Package org.apache.ofbiz.common.uom
>
>
> Key: OFBIZ-9634
> URL: https://issues.apache.org/jira/browse/OFBIZ-9634
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: OFBIZ-9634_org.apache.ofbiz.common.uom_bugfixes.patch
>
>
> - UomWorker.java:70, PZLA_PREFER_ZERO_LENGTH_ARRAYS
> PZLA: Should org.apache.ofbiz.common.uom.UomWorker.uomTimeToCalTime(String)
> return a zero length array rather than null?
> It is often a better design to return a length zero array rather than a null
> reference to indicate that there are no results (i.e., an empty list of
> results). This way, no explicit check for null is needed by clients of the
> method.
> On the other hand, using null to indicate "there is no answer to this
> question" is probably appropriate. For example, File.listFiles() returns an
> empty list if given a directory containing no files, and returns null if the
> file is not a directory.
> - UomWorker.java:107, DLS_DEAD_LOCAL_STORE
> DLS: Dead store to svcOutMap in
> org.apache.ofbiz.common.uom.UomWorker.convertUom(BigDecimal, String, String,
> LocalDispatcher)
> This instruction assigns a value to a local variable, but the value is not
> read or used in any subsequent instruction. Often, this indicates an error,
> because the value computed is never used.
> Note that Sun's javac compiler often generates dead stores for final local
> variables. Because FindBugs is a bytecode-based tool, there is no easy way to
> eliminate these false positives.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (OFBIZ-9633) [FB] Package org.apache.ofbiz.common.qrcode
Dennis Balkir created OFBIZ-9633: Summary: [FB] Package org.apache.ofbiz.common.qrcode Key: OFBIZ-9633 URL: https://issues.apache.org/jira/browse/OFBIZ-9633 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Dennis Balkir Priority: Minor - QRCodeEvents.java:76, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE RCN: Redundant nullcheck of mimeType, which is known to be non-null in org.apache.ofbiz.common.qrcode.QRCodeEvents.serveQRCodeImage(HttpServletRequest, HttpServletResponse) This method contains a redundant check of a known non-null value against the constant null. - QRCodeServices.java:77, MS_PKGPROTECT MS: org.apache.ofbiz.common.qrcode.QRCodeServices.FORMAT_NAMES should be package protected A mutable static field could be changed by malicious code or by accident. The field could be made package protected to avoid this vulnerability. - QRCodeServices.java:79, MS_MUTABLE_COLLECTION_PKGPROTECT Field is a mutable collection which should be package protected A mutable collection instance is assigned to a final static field, thus can be changed by malicious code or by accident from another package. The field could be made package protected to avoid this vulnerability. Alternatively you may wrap this field into Collections.unmodifiableSet/List/Map/etc. to avoid this vulnerability. - QRCodeServices.java:93, MS_SHOULD_BE_REFACTORED_TO_BE_FINAL MS: org.apache.ofbiz.common.qrcode.QRCodeServices.defaultLogoImage isn't final but should be refactored to be so This static field public but not final, and could be changed by malicious code or by accident from another package. The field could be made final to avoid this vulnerability. However, the static initializer contains more than one write to the field, so doing so will require some refactoring. - QRCodeServices.java:252, DM_CONVERT_CASE Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.ofbiz.common.qrcode.QRCodeServices.toBufferedImage(BitMatrix, String) A String is being converted to upper or lowercase, using the platform's default encoding. This may result in improper conversions when used with international characters. Use the String.toUpperCase( Locale l ) String.toLowerCase( Locale l ) versions instead. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-9632) Cannot create new accounting company
Santiago José Santana created OFBIZ-9632: Summary: Cannot create new accounting company Key: OFBIZ-9632 URL: https://issues.apache.org/jira/browse/OFBIZ-9632 Project: OFBiz Issue Type: Bug Affects Versions: Release Branch 16.11 Reporter: Santiago José Santana Priority: Minor Hi In the current 16.11 release you cannot create a new accounting company manually. When I try I get a blank page. [http://i.imgur.com/B89t9ls.png] Steps to recreate the error: 1. Go to Accounting / Organization GL Settings 2. Click create new accounting company 3. Select an Organization Party ID 4. Click create new accounting company Thanks Santiago -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9631) [FB] Package org.apache.ofbiz.common.period
[ https://issues.apache.org/jira/browse/OFBIZ-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Balkir updated OFBIZ-9631: - Attachment: OFBIZ-9631_org.apache.ofbiz.common.period_bugfixes.patch - changed the parameter to final and private, to prevent possible vulnerability through external code changing > [FB] Package org.apache.ofbiz.common.period > --- > > Key: OFBIZ-9631 > URL: https://issues.apache.org/jira/browse/OFBIZ-9631 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: OFBIZ-9631_org.apache.ofbiz.common.period_bugfixes.patch > > > - PeriodWorker.java:34, MS_SHOULD_BE_FINAL > MS: org.apache.ofbiz.common.period.PeriodWorker.module isn't final but should > be > This static field public but not final, and could be changed by malicious > code or by accident from another package. The field could be made final to > avoid this vulnerability. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-9631) [FB] Package org.apache.ofbiz.common.period
Dennis Balkir created OFBIZ-9631: Summary: [FB] Package org.apache.ofbiz.common.period Key: OFBIZ-9631 URL: https://issues.apache.org/jira/browse/OFBIZ-9631 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Dennis Balkir Priority: Minor - PeriodWorker.java:34, MS_SHOULD_BE_FINAL MS: org.apache.ofbiz.common.period.PeriodWorker.module isn't final but should be This static field public but not final, and could be changed by malicious code or by accident from another package. The field could be made final to avoid this vulnerability. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9630) [FB] Package org.apache.ofbiz.common.login
[
https://issues.apache.org/jira/browse/OFBIZ-9630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Balkir updated OFBIZ-9630:
-
Attachment: OFBIZ-9630_org.apache.ofbiz.common.login_bugfixes.patch
- Diamond Operators fixed
- removed unnecessary else
- Line 117: added a default Locale to {{toLowerCase}}
- Line 568: {{resultMap}} is used in the lines after its declaration
- Line 659: null was written into {{result}}. that was intended, but this way
it’s easier to read
- Line 670, 671, 672: added a default Locale to {{toLowerCase}}
- Line 731: added a default Locale to {{toLowerCase}}
- Line 912: removed {{userLogin != null && currentPassword != null && }}
because both parameters cannot be null at this point
- Line 939: removed {{ && userLogin != null}} because the parameter cannot be
null at this point
- Line 984: removed {{messageMap = UtilMisc.toMap("passwordPatternMessage",
errMsg);}} as it’s never used anymore
- Line 995: removed {{userLogin != null && }} because the parameter cannot be
null at this point
- Line 998: added default Locale to {{toUpperCase}}
> [FB] Package org.apache.ofbiz.common.login
> --
>
> Key: OFBIZ-9630
> URL: https://issues.apache.org/jira/browse/OFBIZ-9630
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: OFBIZ-9630_org.apache.ofbiz.common.login_bugfixes.patch
>
>
> - LoginServices.java:118, DM_CONVERT_CASE
> Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in
> org.apache.ofbiz.common.login.LoginServices.userLogin(DispatchContext, Map)
> A String is being converted to upper or lowercase, using the platform's
> default encoding. This may result in improper conversions when used with
> international characters. Use the
> String.toUpperCase( Locale l )
> String.toLowerCase( Locale l )
> versions instead.
> - LoginServices.java:161, DLS_DEAD_LOCAL_STORE
> DLS: Dead store to loginDisableMinutes in
> org.apache.ofbiz.common.login.LoginServices.userLogin(DispatchContext, Map)
> This instruction assigns a value to a local variable, but the value is not
> read or used in any subsequent instruction. Often, this indicates an error,
> because the value computed is never used.
> Note that Sun's javac compiler often generates dead stores for final local
> variables. Because FindBugs is a bytecode-based tool, there is no easy way to
> eliminate these false positives.
> - LoginServices.java:569, DLS_DEAD_LOCAL_STORE
> DLS: Dead store to resultMap in
> org.apache.ofbiz.common.login.LoginServices.createUserLogin(DispatchContext,
> Map)
> This instruction assigns a value to a local variable, but the value is not
> read or used in any subsequent instruction. Often, this indicates an error,
> because the value computed is never used.
> Note that Sun's javac compiler often generates dead stores for final local
> variables. Because FindBugs is a bytecode-based tool, there is no easy way to
> eliminate these false positives.
> - LoginServices.java:661, NP_LOAD_OF_KNOWN_NULL_VALUE
> NP: Load of known null value in
> org.apache.ofbiz.common.login.LoginServices.updatePassword(DispatchContext,
> Map)
> The variable referenced at this point is known to be null due to an earlier
> check against null. Although this is valid, it might be a mistake (perhaps
> you intended to refer to a different variable, or perhaps the earlier check
> to see if the variable is null should have been a check to see if it was
> non-null).
> - LoginServices.java:671, DM_CONVERT_CASE
> Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in
> org.apache.ofbiz.common.login.LoginServices.updatePassword(DispatchContext,
> Map)
> A String is being converted to upper or lowercase, using the platform's
> default encoding. This may result in improper conversions when used with
> international characters. Use the
> String.toUpperCase( Locale l )
> String.toLowerCase( Locale l )
> versions instead.
> - LoginServices.java:733, DM_CONVERT_CASE
> Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in
> org.apache.ofbiz.common.login.LoginServices.updateUserLoginId(DispatchContext,
> Map)
> A String is being converted to upper or lowercase, using the platform's
> default encoding. This may result in improper conversions when used with
> international characters. Use the
> String.toUpperCase( Locale l )
> String.toLowerCase( Locale l )
> versions instead.
> - LoginServices.java:906, RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE
> RCN: Nullcheck of userLogin at line 915 of value previously dereferenced in
> org.apache.ofbiz.common.login.LoginServices.checkNewPassword(GenericValue,
> String, String, String, String, List, boolean, Locale)
> A value is
[jira] [Created] (OFBIZ-9630) [FB] Package org.apache.ofbiz.common.login
Dennis Balkir created OFBIZ-9630: Summary: [FB] Package org.apache.ofbiz.common.login Key: OFBIZ-9630 URL: https://issues.apache.org/jira/browse/OFBIZ-9630 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Dennis Balkir Priority: Minor - LoginServices.java:118, DM_CONVERT_CASE Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.ofbiz.common.login.LoginServices.userLogin(DispatchContext, Map) A String is being converted to upper or lowercase, using the platform's default encoding. This may result in improper conversions when used with international characters. Use the String.toUpperCase( Locale l ) String.toLowerCase( Locale l ) versions instead. - LoginServices.java:161, DLS_DEAD_LOCAL_STORE DLS: Dead store to loginDisableMinutes in org.apache.ofbiz.common.login.LoginServices.userLogin(DispatchContext, Map) This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction. Often, this indicates an error, because the value computed is never used. Note that Sun's javac compiler often generates dead stores for final local variables. Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these false positives. - LoginServices.java:569, DLS_DEAD_LOCAL_STORE DLS: Dead store to resultMap in org.apache.ofbiz.common.login.LoginServices.createUserLogin(DispatchContext, Map) This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction. Often, this indicates an error, because the value computed is never used. Note that Sun's javac compiler often generates dead stores for final local variables. Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these false positives. - LoginServices.java:661, NP_LOAD_OF_KNOWN_NULL_VALUE NP: Load of known null value in org.apache.ofbiz.common.login.LoginServices.updatePassword(DispatchContext, Map) The variable referenced at this point is known to be null due to an earlier check against null. Although this is valid, it might be a mistake (perhaps you intended to refer to a different variable, or perhaps the earlier check to see if the variable is null should have been a check to see if it was non-null). - LoginServices.java:671, DM_CONVERT_CASE Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.ofbiz.common.login.LoginServices.updatePassword(DispatchContext, Map) A String is being converted to upper or lowercase, using the platform's default encoding. This may result in improper conversions when used with international characters. Use the String.toUpperCase( Locale l ) String.toLowerCase( Locale l ) versions instead. - LoginServices.java:733, DM_CONVERT_CASE Dm: Use of non-localized String.toUpperCase() or String.toLowerCase() in org.apache.ofbiz.common.login.LoginServices.updateUserLoginId(DispatchContext, Map) A String is being converted to upper or lowercase, using the platform's default encoding. This may result in improper conversions when used with international characters. Use the String.toUpperCase( Locale l ) String.toLowerCase( Locale l ) versions instead. - LoginServices.java:906, RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE RCN: Nullcheck of userLogin at line 915 of value previously dereferenced in org.apache.ofbiz.common.login.LoginServices.checkNewPassword(GenericValue, String, String, String, String, List, boolean, Locale) A value is checked here to see whether it is null, but this value can't be null because it was previously dereferenced and if it were null a null pointer exception would have occurred at the earlier dereference. Essentially, this code and the previous dereference disagree as to whether this value is allowed to be null. Either the check is redundant or the previous dereference is erroneous. - LoginServices.java:915, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE RCN: Redundant nullcheck of currentPassword, which is known to be non-null in org.apache.ofbiz.common.login.LoginServices.checkNewPassword(GenericValue, String, String, String, String, List, boolean, Locale) This method contains a redundant check of a known non-null value against the constant null. - LoginServices.java:988, DLS_DEAD_LOCAL_STORE DLS: Dead store to messageMap in org.apache.ofbiz.common.login.LoginServices.checkNewPassword(GenericValue, String, String, String, String, List, boolean, Locale) This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction. Often, this indicates an error, because the value computed is never used. Note that Sun's javac compiler often generates dead stores for final local variables. Because FindBugs is a bytecode-based tool, there is no
[jira] [Updated] (OFBIZ-9629) [FB] Package org.apache.ofbiz.common.image
[
https://issues.apache.org/jira/browse/OFBIZ-9629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Balkir updated OFBIZ-9629:
-
Attachment: OFBIZ-9629_org.apache.ofbiz.common.image_bugfixes.patch
- Diamond Operators fixed
- Line 119: removed {{toString}} because {{get(„height“)}} returns a string
- Line 124: removed the {{toString}} because {{get(„width“)}} returns a string
> [FB] Package org.apache.ofbiz.common.image
> --
>
> Key: OFBIZ-9629
> URL: https://issues.apache.org/jira/browse/OFBIZ-9629
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: OFBIZ-9629_org.apache.ofbiz.common.image_bugfixes.patch
>
>
> - ImageTransform.java:119, DM_STRING_TOSTRING
> Dm: org.apache.ofbiz.common.image.ImageTransform.scaleImage(BufferedImage,
> double, double, Map, String, Locale) invokes toString() method on a String
> Calling String.toString() is just a redundant operation. Just use the String.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (OFBIZ-9629) [FB] Package org.apache.ofbiz.common.image
Dennis Balkir created OFBIZ-9629: Summary: [FB] Package org.apache.ofbiz.common.image Key: OFBIZ-9629 URL: https://issues.apache.org/jira/browse/OFBIZ-9629 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Dennis Balkir Priority: Minor - ImageTransform.java:119, DM_STRING_TOSTRING Dm: org.apache.ofbiz.common.image.ImageTransform.scaleImage(BufferedImage, double, double, Map, String, Locale) invokes toString() method on a String Calling String.toString() is just a redundant operation. Just use the String. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-9622) Errors on orderview page
[ https://issues.apache.org/jira/browse/OFBIZ-9622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-9622. Resolution: Fixed Fix Version/s: Upcoming Release > Errors on orderview page > > > Key: OFBIZ-9622 > URL: https://issues.apache.org/jira/browse/OFBIZ-9622 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Nicolas Malin > Fix For: Upcoming Release > > Attachments: screenshot-1.png > > > Steps to regenerate: > 1. Go to Order Component > (https://demo-trunk.ofbiz.apache.org/ordermgr/control/main) > 2. Click on orderlist from > submenu(https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist) > 3. Click on OrderNbr link > (https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=DEMO10090) > Errors on ShippingInformation section and screenrendering error below that. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9622) Errors on orderview page
[ https://issues.apache.org/jira/browse/OFBIZ-9622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141461#comment-16141461 ] Aditya Sharma commented on OFBIZ-9622: -- Hi Nicolas, Yes, it is rectified now. Thanks :) > Errors on orderview page > > > Key: OFBIZ-9622 > URL: https://issues.apache.org/jira/browse/OFBIZ-9622 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Nicolas Malin > Attachments: screenshot-1.png > > > Steps to regenerate: > 1. Go to Order Component > (https://demo-trunk.ofbiz.apache.org/ordermgr/control/main) > 2. Click on orderlist from > submenu(https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist) > 3. Click on OrderNbr link > (https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=DEMO10090) > Errors on ShippingInformation section and screenrendering error below that. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9622) Errors on orderview page
[ https://issues.apache.org/jira/browse/OFBIZ-9622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141452#comment-16141452 ] Nicolas Malin commented on OFBIZ-9622: -- Hello, I finished the trunk perturbation, can you update your ofbiz 1806151 and confirm or infirm this error ? Thanks > Errors on orderview page > > > Key: OFBIZ-9622 > URL: https://issues.apache.org/jira/browse/OFBIZ-9622 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Nicolas Malin > Attachments: screenshot-1.png > > > Steps to regenerate: > 1. Go to Order Component > (https://demo-trunk.ofbiz.apache.org/ordermgr/control/main) > 2. Click on orderlist from > submenu(https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist) > 3. Click on OrderNbr link > (https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=DEMO10090) > Errors on ShippingInformation section and screenrendering error below that. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (OFBIZ-9622) Errors on orderview page
[ https://issues.apache.org/jira/browse/OFBIZ-9622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-9622: Assignee: Nicolas Malin > Errors on orderview page > > > Key: OFBIZ-9622 > URL: https://issues.apache.org/jira/browse/OFBIZ-9622 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Nicolas Malin > Attachments: screenshot-1.png > > > Steps to regenerate: > 1. Go to Order Component > (https://demo-trunk.ofbiz.apache.org/ordermgr/control/main) > 2. Click on orderlist from > submenu(https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist) > 3. Click on OrderNbr link > (https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=DEMO10090) > Errors on ShippingInformation section and screenrendering error below that. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141450#comment-16141450 ] Nicolas Malin commented on OFBIZ-9138: -- Ok I finalized the commits serie : 1806134 : load VisualTheme and ModelTheme on different session and context 1806137, 180614[0-9] : Migrate themes, common screens, handler to exploit values from the theme definition 1806150 : migrate all other screen and scripts to exploit values from the theme definition 180615 : improve error message and announce the commit end :) > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-9625) Improvements in work effort calendar
Suraj Khurana created OFBIZ-9625: Summary: Improvements in work effort calendar Key: OFBIZ-9625 URL: https://issues.apache.org/jira/browse/OFBIZ-9625 Project: OFBiz Issue Type: Improvement Components: workeffort Affects Versions: Trunk Reporter: Suraj Khurana As per communication on dev list: Current implementation is we are using enumeration for calendar types and user can't add new calendar types as per own requirements (like holiday calendar, training calendar, meeting calendar etc.) Instead of using an enumeration for that, we can use work effort of type CALENDAR and associate it with calendar events as work effort assoc. Benefits: * User can create a personalized calendar. * Same event can be associated with multiple calendars. * Enumerations are hard-coded as of now, after this, the method to fetch calendar events will become generic and this improves the beauty of code base and it is not so good as of now. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141410#comment-16141410 ] Nicolas Malin commented on OFBIZ-9138: -- Sure Deepak, I continue the work I think it will be correct it > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9623) Improvements in LabelReferences class
[
https://issues.apache.org/jira/browse/OFBIZ-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Suraj Khurana updated OFBIZ-9623:
-
Attachment: OFBIZ-9623.patch
Here is the proposed patch which covers all the mentioned scenarios.
> Improvements in LabelReferences class
> -
>
> Key: OFBIZ-9623
> URL: https://issues.apache.org/jira/browse/OFBIZ-9623
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
> Attachments: OFBIZ-9623.patch
>
>
> For Java:
> Current support is only for occurrences like "UtilProperties.getMessage(",
> but there are other occurrences such as "uiLabelMap.get(" in java as well.
> Need to add support for same.
> For groovy:
> After some recent improvements for groovy handling, still, there is a
> possibility that someone is using "UtilProperties.getMessage(" in groovy
> files as well, so IMO, that must also be handled.
> For XML forms:
> In XML forms current support in handled for auto-fields-service and
> auto-fields-entity but there are some occurrences of tooltip element of field
> tag as well, that must also be handled.
> For XML Simple Methods:
> Doesn't handle case of property-to-field and default-message elements.
> (Separate ticket created OFBIZ-9606, just adding it here for reference)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9624) NullPointerException when calling EntityQuery#getFieldList
[
https://issues.apache.org/jira/browse/OFBIZ-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141370#comment-16141370
]
Tobias Laufkötter commented on OFBIZ-9624:
--
The attached patch simply wraps {{this.distinct}} in
{{Boolean.TRUE.equals(this.distinct)}}.
> NullPointerException when calling EntityQuery#getFieldList
> --
>
> Key: OFBIZ-9624
> URL: https://issues.apache.org/jira/browse/OFBIZ-9624
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Tobias Laufkötter
> Attachments: OFBIZ-9624.patch
>
>
> When performing {{EntityQuery#getFieldList}} without specifying {{distinct}}
> a {{NullPointerException}} is thrown, because of the condition {{if
> (this.distinct)}}. It implicitly calls {{this.distinct.booleanValue()}} which
> throws the exception if {{distinct}} is {{null}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-9624) NullPointerException when calling EntityQuery#getFieldList
[
https://issues.apache.org/jira/browse/OFBIZ-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tobias Laufkötter updated OFBIZ-9624:
-
Attachment: OFBIZ-9624.patch
> NullPointerException when calling EntityQuery#getFieldList
> --
>
> Key: OFBIZ-9624
> URL: https://issues.apache.org/jira/browse/OFBIZ-9624
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Tobias Laufkötter
> Attachments: OFBIZ-9624.patch
>
>
> When performing {{EntityQuery#getFieldList}} without specifying {{distinct}}
> a {{NullPointerException}} is thrown, because of the condition {{if
> (this.distinct)}}. It implicitly calls {{this.distinct.booleanValue()}} which
> throws the exception if {{distinct}} is {{null}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (OFBIZ-9624) NullPointerException when calling EntityQuery#getFieldList
Tobias Laufkötter created OFBIZ-9624:
Summary: NullPointerException when calling EntityQuery#getFieldList
Key: OFBIZ-9624
URL: https://issues.apache.org/jira/browse/OFBIZ-9624
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: Trunk
Reporter: Tobias Laufkötter
When performing {{EntityQuery#getFieldList}} without specifying {{distinct}} a
{{NullPointerException}} is thrown, because of the condition {{if
(this.distinct)}}. It implicitly calls {{this.distinct.booleanValue()}} which
throws the exception if {{distinct}} is {{null}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[
https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141369#comment-16141369
]
Deepak Dixit commented on OFBIZ-9138:
-
Hi [~soledad],
Please have a look at OFBIZ-9622, I think this is broken due to recent change.
{quote}
2017-08-25 12:01:17,506 |jsse-nio-8443-exec-4 |ModelScreenWidget |W| In
decorator-section-include could not find sections object in the context, not
rendering section with name [pre-body]
2017-08-25 12:01:17,513 |jsse-nio-8443-exec-4 |ModelScreen |E| Error rendering
screen component://common-theme/widget/CommonScreens.xml#GlobalDecorator:
java.lang.NullPointerException. Rolling back transaction.
{quote}
> Create a common theme
> -
>
> Key: OFBIZ-9138
> URL: https://issues.apache.org/jira/browse/OFBIZ-9138
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
> Attachments: common-theme-macro.svg, common-theme-screen.svg
>
>
> A first task to UI Improvement would be create a common that receive the
> existent code.
> The benefice would be have a framework/common who list all screens that
> available for theme surcharge, so without technology information (css/html or
> something like that)
> Different task to do :
> * move all ftl template from framework/common to themes/common
> * move framework/images to themes/common (this directory contains unlogical
> element for theme but will be manage at a second time)
> * move default macro ftl template from framework/widget to themes/common
> After the realization on this task, all current themes call theme/common for
> html rendering instead of framework/common, framework/images and
> framework/widget. Just pave the way for the next
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Closed] (OFBIZ-7439) Required field indicator (*) is missing on Project Manager -> My Task Screen
[ https://issues.apache.org/jira/browse/OFBIZ-7439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Rai closed OFBIZ-7439. Resolution: Not A Problem As per the discussions over the dev ML, we concluded that this is not a problem. Hence, closing it. > Required field indicator (*) is missing on Project Manager -> My Task Screen > > > Key: OFBIZ-7439 > URL: https://issues.apache.org/jira/browse/OFBIZ-7439 > Project: OFBiz > Issue Type: Sub-task > Components: projectmgr >Affects Versions: Trunk >Reporter: Deepak Nigam >Assignee: Rohit Rai >Priority: Trivial > > Required field indicator (*) is missing for field 'Parent Phase' on screen > Project Manager -> My Task Screen -> Add a new task to one of my projects . -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-7439) Required field indicator (*) is missing on Project Manager -> My Task Screen
[ https://issues.apache.org/jira/browse/OFBIZ-7439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141346#comment-16141346 ] Rohit Rai commented on OFBIZ-7439: -- Sure, Jacques. Thanks :) > Required field indicator (*) is missing on Project Manager -> My Task Screen > > > Key: OFBIZ-7439 > URL: https://issues.apache.org/jira/browse/OFBIZ-7439 > Project: OFBiz > Issue Type: Sub-task > Components: projectmgr >Affects Versions: Trunk >Reporter: Deepak Nigam >Assignee: Rohit Rai >Priority: Trivial > > Required field indicator (*) is missing for field 'Parent Phase' on screen > Project Manager -> My Task Screen -> Add a new task to one of my projects . -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141341#comment-16141341 ] Jacques Le Roux commented on OFBIZ-9138: Oops forgot that step, no issues with it :) > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141324#comment-16141324 ] Nicolas Malin commented on OFBIZ-9138: -- Hi Jacques, do you have already the problem after a "./gradlew loadAll" ? > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
