[jira] [Commented] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351283#comment-16351283 ] James Yong commented on OFBIZ-10164: Hi all, Okay. The splitter can be implemented as a separate theme. So there is also no need for a splitter tag in the widget. Will close this issue since the current approach is incorrect. Thanks all for the explanation. Regards, James > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, > horizontal.png, vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. > Update on 20180128: > 1) The patch comes with an example where you can view the splitter at > https://localhost:8443/catalog/control/main > 2) No need to add square brackets when defining sizes. > 3) parentId attribute is removed, -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous
[
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350719#comment-16350719
]
Jacques Le Roux commented on OFBIZ-5157:
Thanks Michael
> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 12.04
>Reporter: Mirko Vogelsmeier
>Assignee: Dennis Balkir
>Priority: Major
> Fix For: Release Branch 12.04
>
> Attachments: OFBIZ-5157-CodeCleanup.patch,
> OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following
> security error occures:
> {code}
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en)
> created in 0.031s with 4 properties
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
> [java] exception report
> --
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Error in simple-method [Create a ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java] stack trace
> ---
> [java] java.lang.Exception: Error in simple-method [Create a
> ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
> [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous
[
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl reassigned OFBIZ-5157:
Assignee: Dennis Balkir (was: Jacques Le Roux)
> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 12.04
>Reporter: Mirko Vogelsmeier
>Assignee: Dennis Balkir
>Priority: Major
> Fix For: Release Branch 12.04
>
> Attachments: OFBIZ-5157-CodeCleanup.patch,
> OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following
> security error occures:
> {code}
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en)
> created in 0.031s with 4 properties
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
> [java] exception report
> --
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Error in simple-method [Create a ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java] stack trace
> ---
> [java] java.lang.Exception: Error in simple-method [Create a
> ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
> [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous
[
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350647#comment-16350647
]
Michael Brohl commented on OFBIZ-5157:
--
Dennis was not assigned to the contributors role, I just assigned him.
> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 12.04
>Reporter: Mirko Vogelsmeier
>Assignee: Dennis Balkir
>Priority: Major
> Fix For: Release Branch 12.04
>
> Attachments: OFBIZ-5157-CodeCleanup.patch,
> OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following
> security error occures:
> {code}
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en)
> created in 0.031s with 4 properties
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
> [java] exception report
> --
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Error in simple-method [Create a ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java] stack trace
> ---
> [java] java.lang.Exception: Error in simple-method [Create a
> ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
> [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10196) Set security object on groovy context
[
https://issues.apache.org/jira/browse/OFBIZ-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350637#comment-16350637
]
Jacques Le Roux commented on OFBIZ-10196:
-
+1 Good idea Dennis
> Set security object on groovy context
> -
>
> Key: OFBIZ-10196
> URL: https://issues.apache.org/jira/browse/OFBIZ-10196
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: 10196.patch
>
>
> In a groovy service to call the security object you need to do :
> {code}Security security = dispatcher.dispatchContext.security{code}
> For simplification, I set the security object in groovy context like
> dispatcher and delegator
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous
[
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350633#comment-16350633
]
Jacques Le Roux commented on OFBIZ-5157:
Not sure why, anyway I know you are on it ;)
> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 12.04
>Reporter: Mirko Vogelsmeier
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Release Branch 12.04
>
> Attachments: OFBIZ-5157-CodeCleanup.patch,
> OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following
> security error occures:
> {code}
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en)
> created in 0.031s with 4 properties
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
> [java] exception report
> --
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Error in simple-method [Create a ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java] stack trace
> ---
> [java] java.lang.Exception: Error in simple-method [Create a
> ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
> [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous
[
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350570#comment-16350570
]
Dennis Balkir commented on OFBIZ-5157:
--
It doesn't look like I can assign myself to this..
> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 12.04
>Reporter: Mirko Vogelsmeier
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Release Branch 12.04
>
> Attachments: OFBIZ-5157-CodeCleanup.patch,
> OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following
> security error occures:
> {code}
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en)
> created in 0.031s with 4 properties
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
> [java] exception report
> --
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Error in simple-method [Create a ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java] stack trace
> ---
> [java] java.lang.Exception: Error in simple-method [Create a
> ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
> [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous
[
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350563#comment-16350563
]
Jacques Le Roux commented on OFBIZ-5157:
BTW, I think you can
> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 12.04
>Reporter: Mirko Vogelsmeier
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Release Branch 12.04
>
> Attachments: OFBIZ-5157-CodeCleanup.patch,
> OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following
> security error occures:
> {code}
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en)
> created in 0.031s with 4 properties
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
> [java] exception report
> --
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Error in simple-method [Create a ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java] stack trace
> ---
> [java] java.lang.Exception: Error in simple-method [Create a
> ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
> [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml
[
https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-10146.
---
Resolution: Implemented
Fix Version/s: Upcoming Branch
Thanks Dennis,
Your patch is in trunk at revision: 1822978
> Removing of loadBestSellingCategory and all related methods in
> CategoryServices.xml
> ---
>
> Key: OFBIZ-10146
> URL: https://issues.apache.org/jira/browse/OFBIZ-10146
> Project: OFBiz
> Issue Type: Improvement
> Components: product
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10146.patch, OFBIZ-10146.patch
>
>
> While doing some conversions from MiniLang to Groovy, I stumbled across these
> methods:
> {{loadBestSellingCategory}}
> {{RemoveProductFromBestSellCategory}}
> {{AddProductToBestSellCategory}}
> {{FindCategoryChild}}
> {{FindBestSellingProduct}}
> These are all in {{CategoryServices.xml}}.
> I started realizing, that the simple-method {{loadBestSellingCategory}}
> doesn't work right (there are some logical failures in it) and while fixing
> it,
> I searched for places where this is used, but couldn't find any.
> I started looking deeper into it and found that all of these methods are
> never used anywhere in OFBiz, neither are the services which are declared for
> this methods.
> This is why I propose to remove them; they have no real use, since they don't
> work properly, and also are never used.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml
[
https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350552#comment-16350552
]
Jacques Le Roux commented on OFBIZ-10146:
-
Thank you both, I apply and commit...
> Removing of loadBestSellingCategory and all related methods in
> CategoryServices.xml
> ---
>
> Key: OFBIZ-10146
> URL: https://issues.apache.org/jira/browse/OFBIZ-10146
> Project: OFBiz
> Issue Type: Improvement
> Components: product
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-10146.patch, OFBIZ-10146.patch
>
>
> While doing some conversions from MiniLang to Groovy, I stumbled across these
> methods:
> {{loadBestSellingCategory}}
> {{RemoveProductFromBestSellCategory}}
> {{AddProductToBestSellCategory}}
> {{FindCategoryChild}}
> {{FindBestSellingProduct}}
> These are all in {{CategoryServices.xml}}.
> I started realizing, that the simple-method {{loadBestSellingCategory}}
> doesn't work right (there are some logical failures in it) and while fixing
> it,
> I searched for places where this is used, but couldn't find any.
> I started looking deeper into it and found that all of these methods are
> never used anywhere in OFBiz, neither are the services which are declared for
> this methods.
> This is why I propose to remove them; they have no real use, since they don't
> work properly, and also are never used.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous
[
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350549#comment-16350549
]
Jacques Le Roux commented on OFBIZ-5157:
OK clear, I can't assign you but that's no pb
> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 12.04
>Reporter: Mirko Vogelsmeier
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Release Branch 12.04
>
> Attachments: OFBIZ-5157-CodeCleanup.patch,
> OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following
> security error occures:
> {code}
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en)
> created in 0.031s with 4 properties
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
> [java] exception report
> --
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Error in simple-method [Create a ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java] stack trace
> ---
> [java] java.lang.Exception: Error in simple-method [Create a
> ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
> [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10196) Set security object on groovy context
[
https://issues.apache.org/jira/browse/OFBIZ-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350540#comment-16350540
]
Dennis Balkir commented on OFBIZ-10196:
---
I know, this is closed, but I would propose to put the security property in the
groovy-descriptor file too. This way eclipse knows that this exists and it
won't look like it isn't known what security is.
For further explanation see the patch provided.
Thanks!
> Set security object on groovy context
> -
>
> Key: OFBIZ-10196
> URL: https://issues.apache.org/jira/browse/OFBIZ-10196
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: 10196.patch
>
>
> In a groovy service to call the security object you need to do :
> {code}Security security = dispatcher.dispatchContext.security{code}
> For simplification, I set the security object in groovy context like
> dispatcher and delegator
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10196) Set security object on groovy context
[
https://issues.apache.org/jira/browse/OFBIZ-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Balkir updated OFBIZ-10196:
--
Attachment: 10196.patch
> Set security object on groovy context
> -
>
> Key: OFBIZ-10196
> URL: https://issues.apache.org/jira/browse/OFBIZ-10196
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: 10196.patch
>
>
> In a groovy service to call the security object you need to do :
> {code}Security security = dispatcher.dispatchContext.security{code}
> For simplification, I set the security object in groovy context like
> dispatcher and delegator
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-9993) Convert CommonPermissionServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-9993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350519#comment-16350519 ] Dennis Balkir commented on OFBIZ-9993: -- Hi Nicolas, actually I got this too. I tested the services on the web-page via service-engine, in which they work fine, but it seems like there still is a mistake in my conversion, I am sorry for that! I currently am trying to fix it, I will upload a new patch asap > Convert CommonPermissionServices.xml mini lang to groovy > > > Key: OFBIZ-9993 > URL: https://issues.apache.org/jira/browse/OFBIZ-9993 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Nicolas Malin >Priority: Minor > Attachments: > OFBIZ-9993_org.apache.ofbiz.common.permission.CommonPermissionServices_convert.patch, > > OFBIZ-9993_org.apache.ofbiz.common.permission.CommonPermissionServices_convert.patch > > > Migration of the CommonPermissionServices.xml to Groovy -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml
[
https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350491#comment-16350491
]
Nicolas Malin commented on OFBIZ-10146:
---
My fault, with the issue OFBIZ-10031 these services has been deleted from
CatalogServices.xml in the patch. I restore them but sure with few padding :)
> Removing of loadBestSellingCategory and all related methods in
> CategoryServices.xml
> ---
>
> Key: OFBIZ-10146
> URL: https://issues.apache.org/jira/browse/OFBIZ-10146
> Project: OFBiz
> Issue Type: Improvement
> Components: product
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-10146.patch
>
>
> While doing some conversions from MiniLang to Groovy, I stumbled across these
> methods:
> {{loadBestSellingCategory}}
> {{RemoveProductFromBestSellCategory}}
> {{AddProductToBestSellCategory}}
> {{FindCategoryChild}}
> {{FindBestSellingProduct}}
> These are all in {{CategoryServices.xml}}.
> I started realizing, that the simple-method {{loadBestSellingCategory}}
> doesn't work right (there are some logical failures in it) and while fixing
> it,
> I searched for places where this is used, but couldn't find any.
> I started looking deeper into it and found that all of these methods are
> never used anywhere in OFBiz, neither are the services which are declared for
> this methods.
> This is why I propose to remove them; they have no real use, since they don't
> work properly, and also are never used.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml
[
https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350495#comment-16350495
]
Dennis Balkir commented on OFBIZ-10146:
---
I just added a new patch, this should work with the current trunk
> Removing of loadBestSellingCategory and all related methods in
> CategoryServices.xml
> ---
>
> Key: OFBIZ-10146
> URL: https://issues.apache.org/jira/browse/OFBIZ-10146
> Project: OFBiz
> Issue Type: Improvement
> Components: product
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-10146.patch, OFBIZ-10146.patch
>
>
> While doing some conversions from MiniLang to Groovy, I stumbled across these
> methods:
> {{loadBestSellingCategory}}
> {{RemoveProductFromBestSellCategory}}
> {{AddProductToBestSellCategory}}
> {{FindCategoryChild}}
> {{FindBestSellingProduct}}
> These are all in {{CategoryServices.xml}}.
> I started realizing, that the simple-method {{loadBestSellingCategory}}
> doesn't work right (there are some logical failures in it) and while fixing
> it,
> I searched for places where this is used, but couldn't find any.
> I started looking deeper into it and found that all of these methods are
> never used anywhere in OFBiz, neither are the services which are declared for
> this methods.
> This is why I propose to remove them; they have no real use, since they don't
> work properly, and also are never used.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml
[
https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Balkir updated OFBIZ-10146:
--
Attachment: OFBIZ-10146.patch
> Removing of loadBestSellingCategory and all related methods in
> CategoryServices.xml
> ---
>
> Key: OFBIZ-10146
> URL: https://issues.apache.org/jira/browse/OFBIZ-10146
> Project: OFBiz
> Issue Type: Improvement
> Components: product
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-10146.patch, OFBIZ-10146.patch
>
>
> While doing some conversions from MiniLang to Groovy, I stumbled across these
> methods:
> {{loadBestSellingCategory}}
> {{RemoveProductFromBestSellCategory}}
> {{AddProductToBestSellCategory}}
> {{FindCategoryChild}}
> {{FindBestSellingProduct}}
> These are all in {{CategoryServices.xml}}.
> I started realizing, that the simple-method {{loadBestSellingCategory}}
> doesn't work right (there are some logical failures in it) and while fixing
> it,
> I searched for places where this is used, but couldn't find any.
> I started looking deeper into it and found that all of these methods are
> never used anywhere in OFBiz, neither are the services which are declared for
> this methods.
> This is why I propose to remove them; they have no real use, since they don't
> work properly, and also are never used.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous
[
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350487#comment-16350487
]
Dennis Balkir commented on OFBIZ-5157:
--
Hi Jacques, I can do that as soon as I have some free time.
I think you can leave this open for me
> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 12.04
>Reporter: Mirko Vogelsmeier
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Release Branch 12.04
>
> Attachments: OFBIZ-5157-CodeCleanup.patch,
> OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following
> security error occures:
> {code}
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en)
> created in 0.031s with 4 properties
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
> [java] exception report
> --
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Error in simple-method [Create a ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java] stack trace
> ---
> [java] java.lang.Exception: Error in simple-method [Create a
> ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
> [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml
[
https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350449#comment-16350449
]
Dennis Balkir commented on OFBIZ-10146:
---
Hi [~jacques.le.roux], I'll take a look.
This may be the case, because the .xml-file was changed yesterday due to my
groovy-conversion of this services-file
> Removing of loadBestSellingCategory and all related methods in
> CategoryServices.xml
> ---
>
> Key: OFBIZ-10146
> URL: https://issues.apache.org/jira/browse/OFBIZ-10146
> Project: OFBiz
> Issue Type: Improvement
> Components: product
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-10146.patch
>
>
> While doing some conversions from MiniLang to Groovy, I stumbled across these
> methods:
> {{loadBestSellingCategory}}
> {{RemoveProductFromBestSellCategory}}
> {{AddProductToBestSellCategory}}
> {{FindCategoryChild}}
> {{FindBestSellingProduct}}
> These are all in {{CategoryServices.xml}}.
> I started realizing, that the simple-method {{loadBestSellingCategory}}
> doesn't work right (there are some logical failures in it) and while fixing
> it,
> I searched for places where this is used, but couldn't find any.
> I started looking deeper into it and found that all of these methods are
> never used anywhere in OFBiz, neither are the services which are declared for
> this methods.
> This is why I propose to remove them; they have no real use, since they don't
> work properly, and also are never used.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml
[
https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350429#comment-16350429
]
Jacques Le Roux commented on OFBIZ-10146:
-
OK the patch does not completely apply, it seems benign, I'll look at it ASAP...
> Removing of loadBestSellingCategory and all related methods in
> CategoryServices.xml
> ---
>
> Key: OFBIZ-10146
> URL: https://issues.apache.org/jira/browse/OFBIZ-10146
> Project: OFBiz
> Issue Type: Improvement
> Components: product
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-10146.patch
>
>
> While doing some conversions from MiniLang to Groovy, I stumbled across these
> methods:
> {{loadBestSellingCategory}}
> {{RemoveProductFromBestSellCategory}}
> {{AddProductToBestSellCategory}}
> {{FindCategoryChild}}
> {{FindBestSellingProduct}}
> These are all in {{CategoryServices.xml}}.
> I started realizing, that the simple-method {{loadBestSellingCategory}}
> doesn't work right (there are some logical failures in it) and while fixing
> it,
> I searched for places where this is used, but couldn't find any.
> I started looking deeper into it and found that all of these methods are
> never used anywhere in OFBiz, neither are the services which are declared for
> this methods.
> This is why I propose to remove them; they have no real use, since they don't
> work properly, and also are never used.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml
[
https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reassigned OFBIZ-10146:
---
Assignee: Jacques Le Roux
> Removing of loadBestSellingCategory and all related methods in
> CategoryServices.xml
> ---
>
> Key: OFBIZ-10146
> URL: https://issues.apache.org/jira/browse/OFBIZ-10146
> Project: OFBiz
> Issue Type: Improvement
> Components: product
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-10146.patch
>
>
> While doing some conversions from MiniLang to Groovy, I stumbled across these
> methods:
> {{loadBestSellingCategory}}
> {{RemoveProductFromBestSellCategory}}
> {{AddProductToBestSellCategory}}
> {{FindCategoryChild}}
> {{FindBestSellingProduct}}
> These are all in {{CategoryServices.xml}}.
> I started realizing, that the simple-method {{loadBestSellingCategory}}
> doesn't work right (there are some logical failures in it) and while fixing
> it,
> I searched for places where this is used, but couldn't find any.
> I started looking deeper into it and found that all of these methods are
> never used anywhere in OFBiz, neither are the services which are declared for
> this methods.
> This is why I propose to remove them; they have no real use, since they don't
> work properly, and also are never used.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10188) Add new FileUtil methods for zip management
[ https://issues.apache.org/jira/browse/OFBIZ-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350421#comment-16350421 ] Jacques Le Roux commented on OFBIZ-10188: - Thanks Gil, I guess you agree about using EntityUtilProperties? > Add new FileUtil methods for zip management > --- > > Key: OFBIZ-10188 > URL: https://issues.apache.org/jira/browse/OFBIZ-10188 > Project: OFBiz > Issue Type: New Feature >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10188.patch, OFBIZ_10188.patch > > > Add new FileUtil methods for zip management. > Add zipFileStream method that will zip FileStream to a zipped one. > Add unzipFileToFolder method to unzip a given archive to a given Folder -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous
[
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350129#comment-16350129
]
Dennis Balkir commented on OFBIZ-5157:
--
[~jacques.le.roux] I see, this was not really a good patch
I didn't know that, I just wondered where it went, as I couldn't find it.
Thanks for the explanation!
> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 12.04
>Reporter: Mirko Vogelsmeier
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Release Branch 12.04
>
> Attachments: OFBIZ-5157-CodeCleanup.patch,
> OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following
> security error occures:
> {code}
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en)
> created in 0.031s with 4 properties
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
> [java] exception report
> --
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Error in simple-method [Create a ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java] stack trace
> ---
> [java] java.lang.Exception: Error in simple-method [Create a
> ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
> [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10031) Convert CategoryServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350115#comment-16350115 ] Dennis Balkir commented on OFBIZ-10031: --- Hi Nicolas, I reviewed the changes you made and I think it's better this way. I didn't know some of the things you changed could be so simple, that's good to know for future conversions. In my opinion this can be closed. Thanks for helping and reviewing! > Convert CategoryServices.xml mini lang to groovy > > > Key: OFBIZ-10031 > URL: https://issues.apache.org/jira/browse/OFBIZ-10031 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Nicolas Malin >Priority: Minor > Attachments: > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch, > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch > > > Migration of the CategoryServices.xml to Groovy -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10188) Add new FileUtil methods for zip management
[
https://issues.apache.org/jira/browse/OFBIZ-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350029#comment-16350029
]
Gil Portenseigne edited comment on OFBIZ-10188 at 2/2/18 9:29 AM:
--
zos.setLevel(9) can be rewritten to
zos.setLevel(Deflater.{color:#9876aa}BEST_COMPRESSION{color}){color:#cc7832};
That will be clearer :), and the choice was made to optimize the size of data.
No strong opinion here either.
Ok for the new byte[8192], thanks for the link, i did some search about this
and agree with you increasing the size of the buffer !
was (Author: gil portenseigne):
zos.setLevel(9) can be rewritten to
zos.setLevel(Deflater.{color:#9876aa}BEST_COMPRESSION{color}){color:#cc7832};
{color:#33}That will be clearer :), and the choice was made to optimize the
size of data. No strong opinion here either.{color}{color}
{color:#cc7832}{color:#33}Ok for the new byte[8192], thanks for the link, i
did some search about this and agree with you increasing the size of the buffer
!{color}{color}
{color:#cc7832} {color}
> Add new FileUtil methods for zip management
> ---
>
> Key: OFBIZ-10188
> URL: https://issues.apache.org/jira/browse/OFBIZ-10188
> Project: OFBiz
> Issue Type: New Feature
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10188.patch, OFBIZ_10188.patch
>
>
> Add new FileUtil methods for zip management.
> Add zipFileStream method that will zip FileStream to a zipped one.
> Add unzipFileToFolder method to unzip a given archive to a given Folder
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10188) Add new FileUtil methods for zip management
[
https://issues.apache.org/jira/browse/OFBIZ-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350029#comment-16350029
]
Gil Portenseigne commented on OFBIZ-10188:
--
zos.setLevel(9) can be rewritten to
zos.setLevel(Deflater.{color:#9876aa}BEST_COMPRESSION{color}){color:#cc7832};
{color:#33}That will be clearer :), and the choice was made to optimize the
size of data. No strong opinion here either.{color}{color}
{color:#cc7832}{color:#33}Ok for the new byte[8192], thanks for the link, i
did some search about this and agree with you increasing the size of the buffer
!{color}{color}
{color:#cc7832} {color}
> Add new FileUtil methods for zip management
> ---
>
> Key: OFBIZ-10188
> URL: https://issues.apache.org/jira/browse/OFBIZ-10188
> Project: OFBiz
> Issue Type: New Feature
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10188.patch, OFBIZ_10188.patch
>
>
> Add new FileUtil methods for zip management.
> Add zipFileStream method that will zip FileStream to a zipped one.
> Add unzipFileToFolder method to unzip a given archive to a given Folder
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-8411) popup image takes full width of browser window for ecommerce multiflex theme
[ https://issues.apache.org/jira/browse/OFBIZ-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-8411. -- Thanks Arun, closing > popup image takes full width of browser window for ecommerce multiflex theme > > > Key: OFBIZ-8411 > URL: https://issues.apache.org/jira/browse/OFBIZ-8411 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk, 16.11.04 >Reporter: Wai >Assignee: Arun Patidar >Priority: Major > Fix For: 17.12.01, 16.11.05 > > Attachments: OFBIZ-8411.patch > > > go to https://localhost:8443/catalog/control/FindProductStore > select multiflex theme > go to ecommerce > hover mouse over an image. > notice that the width of popup image take width of browser window -- This message was sent by Atlassian JIRA (v7.6.3#76005)
