[jira] [Commented] (OFBIZ-10351) Tree View of Call Graph for Services and Simple Methods

2018-04-28 Thread James Yong (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457622#comment-16457622
 ] 

James Yong commented on OFBIZ-10351:


Hi Taher,

Thank you for the review.

In framework/service/config/service.properties, we have a new property i.e. 
showServiceCallGraph, to control whether to print the tree view in the system 
console.

To test, we will access OFBiz throughout the browser and observe the system 
console.

Note that the async services are not included in the tree view.

> Tree View of Call Graph for Services and Simple Methods
> ---
>
> Key: OFBIZ-10351
> URL: https://issues.apache.org/jira/browse/OFBIZ-10351
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10351.patch, OFBIZ-10351.patch
>
>
> Option to log a tree view of services and simple methods, and events that are 
> called in a request. 
> Some discussion at 
> https://lists.apache.org/thread.html/079455a596056334265ecbd410b4de13b6e61e1449ac258af5e9679b@%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10387) Error on eCommerce Request Return Screen

2018-04-28 Thread Ratnesh Upadhyay (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457613#comment-16457613
 ] 

Ratnesh Upadhyay commented on OFBIZ-10387:
--

Soon, I'll provide patch to fix the reported issue.

> Error on eCommerce Request Return Screen
> 
>
> Key: OFBIZ-10387
> URL: https://issues.apache.org/jira/browse/OFBIZ-10387
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Ratnesh Upadhyay
>Priority: Major
> Attachments: RequestReturn.png
>
>
> While browsing eCommerce application noticed following error on return 
> request screen.
> {code:java}
> An error has occurred when reading existing sub-variable "orderAdjustmentId"; 
> see cause exception! The type of the containing value was: 
> extended_hash+method+string (org.apache.ofbiz.entity.GenericValue wrapped 
> into f.e.b.MapModel)  FTL stack trace ("~" means nesting-related): - 
> Failed at: #if !orderItem.orderAdjustmentId?has_... [in template 
> "component://ecommerce/template/order/RequestReturn.ftl" at line 60, column 
> 15]  An error has occurred when reading existing sub-variable 
> "orderAdjustmentId"; see cause exception! The type of the containing value 
> was: extended_hash+method+string (org.apache.ofbiz.entity.GenericValue 
> wrapped into f.e.b.MapModel)  FTL stack trace ("~" means 
> nesting-related): - Failed at: #if !orderItem.orderAdjustmentId?has_... [in 
> template "component://ecommerce/template/order/RequestReturn.ftl" at line 60, 
> column 15]  An error has occurred when reading existing sub-variable 
> "orderAdjustmentId"; see cause exception! The type of the containing value 
> was: extended_hash+method+string (org.apache.ofbiz.entity.GenericValue 
> wrapped into f.e.b.MapModel)  FTL stack trace ("~" means 
> nesting-related): - Failed at: #if !orderItem.orderAdjustmentId?has_... [in 
> template "component://ecommerce/template/order/RequestReturn.ftl" at line 60, 
> column 15] 
> }
> {code}
> Steps to replicate reported issue:
> prerequisite : You should have completed order for demo customer in system.
> 1. login to eCommerce application with DemoCustomer.
> 2. Click upon Order History link displaying in top navigation bar.
> 3. Click upon View button displaying against orders under order history 
> section.
> 4. Click upon Request Return link to initiate return.
> 5. You will see the reported error in Return Items section.
> Please refer attached screenshot for further reference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10387) Error on eCommerce Request Return Screen

2018-04-28 Thread Ratnesh Upadhyay (JIRA)
Ratnesh Upadhyay created OFBIZ-10387:


 Summary: Error on eCommerce Request Return Screen
 Key: OFBIZ-10387
 URL: https://issues.apache.org/jira/browse/OFBIZ-10387
 Project: OFBiz
  Issue Type: Bug
  Components: ecommerce
Affects Versions: Trunk
Reporter: Ratnesh Upadhyay
Assignee: Ratnesh Upadhyay
 Attachments: RequestReturn.png

While browsing eCommerce application noticed following error on return request 
screen.

{code:java}
An error has occurred when reading existing sub-variable "orderAdjustmentId"; 
see cause exception! The type of the containing value was: 
extended_hash+method+string (org.apache.ofbiz.entity.GenericValue wrapped into 
f.e.b.MapModel)  FTL stack trace ("~" means nesting-related): - Failed at: 
#if !orderItem.orderAdjustmentId?has_... [in template 
"component://ecommerce/template/order/RequestReturn.ftl" at line 60, column 15] 
 An error has occurred when reading existing sub-variable 
"orderAdjustmentId"; see cause exception! The type of the containing value was: 
extended_hash+method+string (org.apache.ofbiz.entity.GenericValue wrapped into 
f.e.b.MapModel)  FTL stack trace ("~" means nesting-related): - Failed at: 
#if !orderItem.orderAdjustmentId?has_... [in template 
"component://ecommerce/template/order/RequestReturn.ftl" at line 60, column 15] 
 An error has occurred when reading existing sub-variable 
"orderAdjustmentId"; see cause exception! The type of the containing value was: 
extended_hash+method+string (org.apache.ofbiz.entity.GenericValue wrapped into 
f.e.b.MapModel)  FTL stack trace ("~" means nesting-related): - Failed at: 
#if !orderItem.orderAdjustmentId?has_... [in template 
"component://ecommerce/template/order/RequestReturn.ftl" at line 60, column 15] 

}
{code}

Steps to replicate reported issue:
prerequisite : You should have completed order for demo customer in system.
1. login to eCommerce application with DemoCustomer.
2. Click upon Order History link displaying in top navigation bar.
3. Click upon View button displaying against orders under order history section.
4. Click upon Request Return link to initiate return.
5. You will see the reported error in Return Items section.

Please refer attached screenshot for further reference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10312) UI Label Issue on WebPos screen

2018-04-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki updated OFBIZ-10312:
--
Fix Version/s: Upcoming Branch

> UI Label Issue on WebPos screen
> ---
>
> Key: OFBIZ-10312
> URL: https://issues.apache.org/jira/browse/OFBIZ-10312
> Project: OFBiz
>  Issue Type: Improvement
>  Components: webpos
> Environment: https://demo-trunk.ofbiz.apache.org/webpos/control/Login
>Reporter: Archana Asthana
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10312.patch, UIlabel.png
>
>
> Steps to regenerate: 
> Open [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
> Check the UI label below the keyboard shortcuts
> Expected: The UI lable should be clear and legible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10312) UI Label Issue on WebPos screen

2018-04-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki closed OFBIZ-10312.
-

> UI Label Issue on WebPos screen
> ---
>
> Key: OFBIZ-10312
> URL: https://issues.apache.org/jira/browse/OFBIZ-10312
> Project: OFBiz
>  Issue Type: Improvement
>  Components: webpos
> Environment: https://demo-trunk.ofbiz.apache.org/webpos/control/Login
>Reporter: Archana Asthana
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10312.patch, UIlabel.png
>
>
> Steps to regenerate: 
> Open [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
> Check the UI label below the keyboard shortcuts
> Expected: The UI lable should be clear and legible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-04-28 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457607#comment-16457607
 ] 

Jacques Le Roux commented on OFBIZ-10221:
-

+1 Nicolas, the risk is low (it"s only UI AFAIK - no reviews yet) so backport 
is OK with me

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221-product.template.Main.patch, 
> OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10312) UI Label Issue on WebPos screen

2018-04-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-10312:
-

Resolution: Fixed
  Assignee: Rishi Solanki  (was: Pawan Verma)

Thanks [~archana.asthana] for reporting the issue and [~pawan.verma] for 
providing fix.

Your work has been committed in revision 1830451.

> UI Label Issue on WebPos screen
> ---
>
> Key: OFBIZ-10312
> URL: https://issues.apache.org/jira/browse/OFBIZ-10312
> Project: OFBiz
>  Issue Type: Improvement
>  Components: webpos
> Environment: https://demo-trunk.ofbiz.apache.org/webpos/control/Login
>Reporter: Archana Asthana
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-10312.patch, UIlabel.png
>
>
> Steps to regenerate: 
> Open [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
> Check the UI label below the keyboard shortcuts
> Expected: The UI lable should be clear and legible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10282) Remove empty field values from xml data files so that it will not override existing data with empty values

2018-04-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-10282:
-

Assignee: Rishi Solanki  (was: Arun Patidar)

> Remove empty field values from xml data files so that it will not override 
> existing data with empty values
> --
>
> Key: OFBIZ-10282
> URL: https://issues.apache.org/jira/browse/OFBIZ-10282
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-10282-plugins.patch, OFBIZ-10282.patch
>
>
> Remove empty systemPropertyValue field values from SystemProperty xml data 
> files.
> Current system overrides  value with empty value if it is mentioned in XML 
> data tag. So need to remove empty field values to override data on the 
> existing instance. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10351) Tree View of Call Graph for Services and Simple Methods

2018-04-28 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457598#comment-16457598
 ] 

Taher Alkhateeb commented on OFBIZ-10351:
-

Hi James,

Thank you for your work on this. How can I test this PoC?

> Tree View of Call Graph for Services and Simple Methods
> ---
>
> Key: OFBIZ-10351
> URL: https://issues.apache.org/jira/browse/OFBIZ-10351
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10351.patch, OFBIZ-10351.patch
>
>
> Option to log a tree view of services and simple methods, and events that are 
> called in a request. 
> Some discussion at 
> https://lists.apache.org/thread.html/079455a596056334265ecbd410b4de13b6e61e1449ac258af5e9679b@%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10282) Remove empty field values from xml data files so that it will not override existing data with empty values

2018-04-28 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457597#comment-16457597
 ] 

Rishi Solanki commented on OFBIZ-10282:
---

[~suraj.khurana] : Patch looks good to me, [~jacques.le.roux] [~arunpati] could 
you please confirm if I can go ahead and commit the changes. Thanks!

> Remove empty field values from xml data files so that it will not override 
> existing data with empty values
> --
>
> Key: OFBIZ-10282
> URL: https://issues.apache.org/jira/browse/OFBIZ-10282
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
> Attachments: OFBIZ-10282-plugins.patch, OFBIZ-10282.patch
>
>
> Remove empty systemPropertyValue field values from SystemProperty xml data 
> files.
> Current system overrides  value with empty value if it is mentioned in XML 
> data tag. So need to remove empty field values to override data on the 
> existing instance. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10189) Invoice in status approved - cancel

2018-04-28 Thread Akash Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-10189.
--

> Invoice in status approved - cancel
> ---
>
> Key: OFBIZ-10189
> URL: https://issues.apache.org/jira/browse/OFBIZ-10189
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Reporter: Ingo Wolfmayr
>Assignee: Akash Jain
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: ofbiz.patch
>
>
> When I create an invoice and set it to status "INVOICE_APPROVED" it is not 
> possible to cancel the invoice as the status change is not available. If I 
> change the status to "INVOICE_READY" it is again possible to cancel the 
> invoice. I think in most of the business cases this won't make sense. I 
> therefore would like to suggest to change it: if invoice in status 
> "INVOICE_APPROVED" it can be cancelled. 
>  # Create invoice (sales invoice)
>  # Set status to "INVOICE_APPROVED": available status changes: INVOICE_SEND, 
> INVOICE_READY 3. Set status to "INVOICE_READY": available status changes: 
> INVOICE_PAID, INVOICE_CANCELLED, INVOICE_PAIDOFF



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10189) Invoice in status approved - cancel

2018-04-28 Thread Akash Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain resolved OFBIZ-10189.

   Resolution: Fixed
Fix Version/s: Upcoming Branch

> Invoice in status approved - cancel
> ---
>
> Key: OFBIZ-10189
> URL: https://issues.apache.org/jira/browse/OFBIZ-10189
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Reporter: Ingo Wolfmayr
>Assignee: Akash Jain
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: ofbiz.patch
>
>
> When I create an invoice and set it to status "INVOICE_APPROVED" it is not 
> possible to cancel the invoice as the status change is not available. If I 
> change the status to "INVOICE_READY" it is again possible to cancel the 
> invoice. I think in most of the business cases this won't make sense. I 
> therefore would like to suggest to change it: if invoice in status 
> "INVOICE_APPROVED" it can be cancelled. 
>  # Create invoice (sales invoice)
>  # Set status to "INVOICE_APPROVED": available status changes: INVOICE_SEND, 
> INVOICE_READY 3. Set status to "INVOICE_READY": available status changes: 
> INVOICE_PAID, INVOICE_CANCELLED, INVOICE_PAIDOFF



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10189) Invoice in status approved - cancel

2018-04-28 Thread Akash Jain (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457573#comment-16457573
 ] 

Akash Jain commented on OFBIZ-10189:


This has been fixed on ofbiz-framework trunk at r#1830449

Thanks, Ingo Wolfmayr for your contribution.

> Invoice in status approved - cancel
> ---
>
> Key: OFBIZ-10189
> URL: https://issues.apache.org/jira/browse/OFBIZ-10189
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Reporter: Ingo Wolfmayr
>Assignee: Akash Jain
>Priority: Trivial
> Attachments: ofbiz.patch
>
>
> When I create an invoice and set it to status "INVOICE_APPROVED" it is not 
> possible to cancel the invoice as the status change is not available. If I 
> change the status to "INVOICE_READY" it is again possible to cancel the 
> invoice. I think in most of the business cases this won't make sense. I 
> therefore would like to suggest to change it: if invoice in status 
> "INVOICE_APPROVED" it can be cancelled. 
>  # Create invoice (sales invoice)
>  # Set status to "INVOICE_APPROVED": available status changes: INVOICE_SEND, 
> INVOICE_READY 3. Set status to "INVOICE_READY": available status changes: 
> INVOICE_PAID, INVOICE_CANCELLED, INVOICE_PAIDOFF



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10316) Fields going outside

2018-04-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki closed OFBIZ-10316.
-

> Fields going outside
> 
>
> Key: OFBIZ-10316
> URL: https://issues.apache.org/jira/browse/OFBIZ-10316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: webpos
> Environment:  
> [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
>Reporter: Padmavati Rawat
>Assignee: Rishi Solanki
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: FieldsUI.png, OFBIZ-10316.patch
>
>
> *Steps to regenerate: *
> Open [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
> Search customer through search by.
> Select a customer from the list through a checkbox.
> Check the First name and Address line 2 fields in the update modal.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10316) Fields going outside

2018-04-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki updated OFBIZ-10316:
--
Fix Version/s: Upcoming Branch

> Fields going outside
> 
>
> Key: OFBIZ-10316
> URL: https://issues.apache.org/jira/browse/OFBIZ-10316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: webpos
> Environment:  
> [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
>Reporter: Padmavati Rawat
>Assignee: Rishi Solanki
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: FieldsUI.png, OFBIZ-10316.patch
>
>
> *Steps to regenerate: *
> Open [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
> Search customer through search by.
> Select a customer from the list through a checkbox.
> Check the First name and Address line 2 fields in the update modal.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10316) Fields going outside

2018-04-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki resolved OFBIZ-10316.
---
Resolution: Fixed

Thanks [~padma.rawat] for reporting the issue and [~pawan.verma] for providing 
fix.

Your work has been committed in revision 1830448.

> Fields going outside
> 
>
> Key: OFBIZ-10316
> URL: https://issues.apache.org/jira/browse/OFBIZ-10316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: webpos
> Environment:  
> [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
>Reporter: Padmavati Rawat
>Assignee: Rishi Solanki
>Priority: Minor
> Attachments: FieldsUI.png, OFBIZ-10316.patch
>
>
> *Steps to regenerate: *
> Open [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
> Search customer through search by.
> Select a customer from the list through a checkbox.
> Check the First name and Address line 2 fields in the update modal.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9987) Enable drop ship PO if 'Drop-ship Only' property is set at Product Store level.

2018-04-28 Thread Akash Jain (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457556#comment-16457556
 ] 

Akash Jain commented on OFBIZ-9987:
---

Hello Ankit, dropship functionality available at ProductStore and Product level 
only. It's not available at the Facility level. Need to update patch 
accordingly.

Note: We can definitely enhance this feature for Facility as well. 

> Enable drop ship PO if 'Drop-ship Only' property is set at Product Store 
> level.
> ---
>
> Key: OFBIZ-9987
> URL: https://issues.apache.org/jira/browse/OFBIZ-9987
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Ankit Joshi
>Assignee: Akash Jain
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-9987.patch
>
>
> Current:
> For drop shipment process, cart method 'createDropShipGroups' only check 
> requirementMethodEnumId at Facility Level and Product level. Also, found the 
> unhandled case of not considering requirementMethodEnumId at Product Level if 
> this property found at Facility level.
> Expected : 
> RequirementMethodEnumId should be decided in the order of property set at 
> ProductStore -> Facility -> Product.
> Check and enable drop ship PO if 'Drop-ship Only' property is set at Store 
> level. Also, this property should be checked and override at Facility level 
> if exists to consider the case when Facility does not allow drop ship Order. 
> Finally, it should be checked at Product level to consider the case when 
> Store and Facility allow for drop ship but the product does not.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page

2018-04-28 Thread Archana Asthana (JIRA)
Archana Asthana created OFBIZ-10386:
---

 Summary: Empty field is reflecting on Contact list section on 
Profile Page
 Key: OFBIZ-10386
 URL: https://issues.apache.org/jira/browse/OFBIZ-10386
 Project: OFBiz
  Issue Type: Bug
 Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile
Reporter: Archana Asthana
 Attachments: EmptyFields.png

Steps to generate: 

Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile

On the profile page, Go down to Contact list
Empty fields are displaying before Verify Subscription button

Expected: The field should have some specifications to be filled up

Image is attached for reference



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page

2018-04-28 Thread Archana Asthana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Archana Asthana updated OFBIZ-10386:

Attachment: EmptyFields.png

> Empty field is reflecting on Contact list section on Profile Page
> -
>
> Key: OFBIZ-10386
> URL: https://issues.apache.org/jira/browse/OFBIZ-10386
> Project: OFBiz
>  Issue Type: Bug
> Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile
>Reporter: Archana Asthana
>Priority: Major
> Attachments: EmptyFields.png
>
>
> Steps to generate: 
> Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile
> On the profile page, Go down to Contact list
> Empty fields are displaying before Verify Subscription button
> Expected: The field should have some specifications to be filled up
> Image is attached for reference



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10316) Fields going outside

2018-04-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-10316:
-

Assignee: Rishi Solanki  (was: Pawan Verma)

> Fields going outside
> 
>
> Key: OFBIZ-10316
> URL: https://issues.apache.org/jira/browse/OFBIZ-10316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: webpos
> Environment:  
> [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
>Reporter: Padmavati Rawat
>Assignee: Rishi Solanki
>Priority: Minor
> Attachments: FieldsUI.png, OFBIZ-10316.patch
>
>
> *Steps to regenerate: *
> Open [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
> Search customer through search by.
> Select a customer from the list through a checkbox.
> Check the First name and Address line 2 fields in the update modal.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10380) Convert facility party related services from simple to entity-auto

2018-04-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki closed OFBIZ-10380.
-

> Convert facility party related services from simple to entity-auto
> --
>
> Key: OFBIZ-10380
> URL: https://issues.apache.org/jira/browse/OFBIZ-10380
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Suraj Khurana
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10380.patch
>
>
> There is nothing extra in these services and they can be made to entity-auto



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10380) Convert facility party related services from simple to entity-auto

2018-04-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki resolved OFBIZ-10380.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Thanks [~suraj.khurana] for reporting the issue and providing fix for the same.

Your patch has been committed in revision 1830429.

> Convert facility party related services from simple to entity-auto
> --
>
> Key: OFBIZ-10380
> URL: https://issues.apache.org/jira/browse/OFBIZ-10380
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Suraj Khurana
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10380.patch
>
>
> There is nothing extra in these services and they can be made to entity-auto



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10379) Exception handling for Add a new Party Role at createInvoiceRole

2018-04-28 Thread Suraj Khurana (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457551#comment-16457551
 ] 

Suraj Khurana commented on OFBIZ-10379:
---

There is a discussion regarding this. 
You can refer it https://markmail.org/message/rx3qgoup2rm4xafu

> Exception handling for Add a new Party Role at createInvoiceRole
> 
>
> Key: OFBIZ-10379
> URL: https://issues.apache.org/jira/browse/OFBIZ-10379
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/ap/control/createInvoiceRole
>Reporter: Aayush jain
>Priority: Minor
> Attachments: Error.png
>
>
> Steps:
> 1. Open URL https://demo-trunk.ofbiz.apache.org/ap/control/createInvoiceRole
> 2. Add a party Id which does not assigned as a role for accounts
> 3. Enter Percentage
> 4. Click on submit button
> Actual Result: 
> Throwing an exception error for the invalid case, Kindly refer attachment for 
> the same
> Expected Result:
> We must handle exceptions with a proper error message, I don't think this is 
> working fine, It should be correct with proper message.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10380) Convert facility party related services from simple to entity-auto

2018-04-28 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki reassigned OFBIZ-10380:
-

Assignee: Rishi Solanki  (was: Suraj Khurana)

> Convert facility party related services from simple to entity-auto
> --
>
> Key: OFBIZ-10380
> URL: https://issues.apache.org/jira/browse/OFBIZ-10380
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Suraj Khurana
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-10380.patch
>
>
> There is nothing extra in these services and they can be made to entity-auto



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10385) Cart summary section distroted

2018-04-28 Thread Padmavati Rawat (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Padmavati Rawat updated OFBIZ-10385:

Attachment: CartSummaryDistroted.png

> Cart summary section distroted
> --
>
> Key: OFBIZ-10385
> URL: https://issues.apache.org/jira/browse/OFBIZ-10385
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
>Reporter: Padmavati Rawat
>Priority: Major
> Attachments: CartSummaryDistroted.png
>
>
> Steps 
> Navigate to the storefront. 
> https://demo-trunk.ofbiz.apache.org/ecomseo/additeme 
> Add items to the cart.
> Check the cart summary section.
> Actual:
> Cart summary section getting distorted on adding items to the cart.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10385) Cart summary section distroted

2018-04-28 Thread Padmavati Rawat (JIRA)
Padmavati Rawat created OFBIZ-10385:
---

 Summary: Cart summary section distroted
 Key: OFBIZ-10385
 URL: https://issues.apache.org/jira/browse/OFBIZ-10385
 Project: OFBiz
  Issue Type: Improvement
  Components: ecommerce
Reporter: Padmavati Rawat


Steps 
Navigate to the storefront. 
https://demo-trunk.ofbiz.apache.org/ecomseo/additeme 
Add items to the cart.
Check the cart summary section.
Actual:
Cart summary section getting distorted on adding items to the cart.




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10372) Calculate estimated shipment delivery time

2018-04-28 Thread Swapnil Shah (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457491#comment-16457491
 ] 

Swapnil Shah edited comment on OFBIZ-10372 at 4/28/18 9:35 AM:
---

As we are dealing it on Time dimension, it would be worthwhile to make it honor 
the working (or holiday) calendars at shipper's or shipping carrier's or for 
that matter even at receiver's end. For instance many a times there may be 
fixed working days/hours to dispatch the goods from shipper's end or to pick up 
the shipments at carrier's end or to receive the goods at receiver's end. In 
such cases promising Est. Delivery Date (EDD) merely based on lead time may not 
be so accurate. 

Currently one of possible ways to manage calendars could be using 
CustomTimePeriod, if that is true then 'ShipmentTimeEstimate' can be extended 
by adding the 'customTimePeriodId' and enahance the code to honor it as well 
while deriving EDD.


was (Author: swash78):
As we are dealing it on Time dimension, it would be worthwhile to make it honor 
the working (or holiday) calendars at shipper's or shipping carrier's or for 
that matter even at receiver's end. For instance many a times there may be 
fixed working days/hours to dispatch the goods from shipper's end or to pick up 
the shipments at carrier's end or to receive the goods at receiver's end. In 
such cases promising Est. Delivery Date (EDD) merely based on lead time may not 
be so accurate. 

Currently one of possible ways to manage calendars could be using 
CustomTimePeriod, if that is trun then 'ShipmentTimeEstimate' can be extended 
by adding the 'customTimePeriodId' and enahance the code to honor it as well 
while deriving EDD.

> Calculate estimated shipment delivery time
> --
>
> Key: OFBIZ-10372
> URL: https://issues.apache.org/jira/browse/OFBIZ-10372
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
>  Labels: order, shipment, time
> Attachments: OFBIZ-10372.patch
>
>
> Currently when you pass an order in ofbiz you can select the shipment method 
> to delivery finish good and obtains an amount cost but you have nothing to 
> indicate how the delivration will during.
>  We have a good example with ship by plane or boat and for road the time is 
> different between the Portugal to Spain and Portugal to Slovenia.
> With this information, we can planned the estimated delivery date with the 
> estimated date to produce finish good and the time to delivery them
> To fill this gap, we introduce a new entity ShipmentTimeEstimate modelled as 
> ShipmentCostEstimate to define the estimated time for a shipment method, a 
> carrier and two geo location:
> {code:java}
>      package-name="org.apache.ofbiz.shipment.shipment"
>     title="Shipment Time Estimation Entity">
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     ...
> {code}
> We have two asks related to this issue on users 
> [1|https://lists.apache.org/thread.html/de58aa36744804c28eccef6fc7ebc8f0311f65b0dc6b17f1fa5234d4@%3Cuser.ofbiz.apache.org%3E]
>  
> [2|https://lists.apache.org/thread.html/1d79dd9f42fc256e5986271e9e0447bde2980bf0310c4b5f04a35e9f@%3Cuser.ofbiz.apache.org%3E]
>  
>  The first patch made in collaboration with Leila Mekika lays bricks to 
> implement this idea
>  All remark and suggest are welcome to continue it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10372) Calculate estimated shipment delivery time

2018-04-28 Thread Swapnil Shah (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah updated OFBIZ-10372:
-
Summary: Calculate estimated shipment delivery time  (was: Caculate 
estimated shipment delivery time)

> Calculate estimated shipment delivery time
> --
>
> Key: OFBIZ-10372
> URL: https://issues.apache.org/jira/browse/OFBIZ-10372
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
>  Labels: order, shipment, time
> Attachments: OFBIZ-10372.patch
>
>
> Currently when you pass an order in ofbiz you can select the shipment method 
> to delivery finish good and obtains an amount cost but you have nothing to 
> indicate how the delivration will during.
>  We have a good example with ship by plane or boat and for road the time is 
> different between the Portugal to Spain and Portugal to Slovenia.
> With this information, we can planned the estimated delivery date with the 
> estimated date to produce finish good and the time to delivery them
> To fill this gap, we introduce a new entity ShipmentTimeEstimate modelled as 
> ShipmentCostEstimate to define the estimated time for a shipment method, a 
> carrier and two geo location:
> {code:java}
>      package-name="org.apache.ofbiz.shipment.shipment"
>     title="Shipment Time Estimation Entity">
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     ...
> {code}
> We have two asks related to this issue on users 
> [1|https://lists.apache.org/thread.html/de58aa36744804c28eccef6fc7ebc8f0311f65b0dc6b17f1fa5234d4@%3Cuser.ofbiz.apache.org%3E]
>  
> [2|https://lists.apache.org/thread.html/1d79dd9f42fc256e5986271e9e0447bde2980bf0310c4b5f04a35e9f@%3Cuser.ofbiz.apache.org%3E]
>  
>  The first patch made in collaboration with Leila Mekika lays bricks to 
> implement this idea
>  All remark and suggest are welcome to continue it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10372) Caculate estimated shipment delivery time

2018-04-28 Thread Swapnil Shah (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457491#comment-16457491
 ] 

Swapnil Shah commented on OFBIZ-10372:
--

As we are dealing it on Time dimension, it would be worthwhile to make it honor 
the working (or holiday) calendars at shipper's or shipping carrier's or for 
that matter even at receiver's end. For instance many a times there may be 
fixed working days/hours to dispatch the goods from shipper's end or to pick up 
the shipments at carrier's end or to receive the goods at receiver's end. In 
such cases promising Est. Delivery Date (EDD) merely based on lead time may not 
be so accurate. 

Currently one of possible ways to manage calendars could be using 
CustomTimePeriod, if that is trun then 'ShipmentTimeEstimate' can be extended 
by adding the 'customTimePeriodId' and enahance the code to honor it as well 
while deriving EDD.

> Caculate estimated shipment delivery time
> -
>
> Key: OFBIZ-10372
> URL: https://issues.apache.org/jira/browse/OFBIZ-10372
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
>  Labels: order, shipment, time
> Attachments: OFBIZ-10372.patch
>
>
> Currently when you pass an order in ofbiz you can select the shipment method 
> to delivery finish good and obtains an amount cost but you have nothing to 
> indicate how the delivration will during.
>  We have a good example with ship by plane or boat and for road the time is 
> different between the Portugal to Spain and Portugal to Slovenia.
> With this information, we can planned the estimated delivery date with the 
> estimated date to produce finish good and the time to delivery them
> To fill this gap, we introduce a new entity ShipmentTimeEstimate modelled as 
> ShipmentCostEstimate to define the estimated time for a shipment method, a 
> carrier and two geo location:
> {code:java}
>      package-name="org.apache.ofbiz.shipment.shipment"
>     title="Shipment Time Estimation Entity">
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     ...
> {code}
> We have two asks related to this issue on users 
> [1|https://lists.apache.org/thread.html/de58aa36744804c28eccef6fc7ebc8f0311f65b0dc6b17f1fa5234d4@%3Cuser.ofbiz.apache.org%3E]
>  
> [2|https://lists.apache.org/thread.html/1d79dd9f42fc256e5986271e9e0447bde2980bf0310c4b5f04a35e9f@%3Cuser.ofbiz.apache.org%3E]
>  
>  The first patch made in collaboration with Leila Mekika lays bricks to 
> implement this idea
>  All remark and suggest are welcome to continue it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10376) Remove hard coded values from removePromotion

2018-04-28 Thread Nicolas Malin (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin reassigned OFBIZ-10376:
-

Assignee: Nicolas Malin

> Remove hard coded values from removePromotion
> -
>
> Key: OFBIZ-10376
> URL: https://issues.apache.org/jira/browse/OFBIZ-10376
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Shikha Jaiswal
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-10376.patch
>
>
> In removePromotion, values used to fetch data from ProductPromoAction are 
> hard coded. Need to remove these hard-coded values.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7741) Address scope peculiarities within search/find functionality of projectmgr

2018-04-28 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-7741:

Affects Version/s: 16.11.05
   17.12.01
   Trunk
   16.11.04

> Address scope peculiarities within search/find functionality of projectmgr
> --
>
> Key: OFBIZ-7741
> URL: https://issues.apache.org/jira/browse/OFBIZ-7741
> Project: OFBiz
>  Issue Type: Improvement
>  Components: projectmgr
>Affects Versions: Trunk, 17.12.01, 16.11.04, 16.11.05
>Reporter: Pierre Smits
>Priority: Critical
> Attachments: projectmgr-projectsearch-admin.png, 
> projectmgr-summary-admin.png
>
>
> Currently the search/find functions in the projectmgr component also 
> retrieves projects a user is not a participant in. This is especially 
> critical regarding projects with scope 'WES_PRIVATE - private' or 
> 'WES_CONFIDENTIAL - confidential'.
> These project may only be search for/found by users that are exlicit 
> participants of the projects. This over ruless the generic permissions of 
> 'PROJECTMGR_ADMIN' or 'PROJECTMGR_VIEW'.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7741) Address scope peculiarities within search/find functionality of projectmgr

2018-04-28 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457484#comment-16457484
 ] 

Pierre Smits commented on OFBIZ-7741:
-

See attached screenshot 'projectmgr-projectsearch-admin.png' showing that a 
project with scopeEnumId = "WES_CONFIDENTIAL" is visibility to a party not 
assigned to the project (see screenshot 'projectmgr-summary-admin.png').

Having confidential project visible to parties outside of the scope (parties 
assigned) defies the definition of confidential. 

> Address scope peculiarities within search/find functionality of projectmgr
> --
>
> Key: OFBIZ-7741
> URL: https://issues.apache.org/jira/browse/OFBIZ-7741
> Project: OFBiz
>  Issue Type: Improvement
>  Components: projectmgr
>Reporter: Pierre Smits
>Priority: Critical
> Attachments: projectmgr-projectsearch-admin.png, 
> projectmgr-summary-admin.png
>
>
> Currently the search/find functions in the projectmgr component also 
> retrieves projects a user is not a participant in. This is especially 
> critical regarding projects with scope 'WES_PRIVATE - private' or 
> 'WES_CONFIDENTIAL - confidential'.
> These project may only be search for/found by users that are exlicit 
> participants of the projects. This over ruless the generic permissions of 
> 'PROJECTMGR_ADMIN' or 'PROJECTMGR_VIEW'.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7741) Address scope peculiarities within search/find functionality of projectmgr

2018-04-28 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-7741:

Attachment: projectmgr-summary-admin.png

> Address scope peculiarities within search/find functionality of projectmgr
> --
>
> Key: OFBIZ-7741
> URL: https://issues.apache.org/jira/browse/OFBIZ-7741
> Project: OFBiz
>  Issue Type: Improvement
>  Components: projectmgr
>Reporter: Pierre Smits
>Priority: Critical
> Attachments: projectmgr-projectsearch-admin.png, 
> projectmgr-summary-admin.png
>
>
> Currently the search/find functions in the projectmgr component also 
> retrieves projects a user is not a participant in. This is especially 
> critical regarding projects with scope 'WES_PRIVATE - private' or 
> 'WES_CONFIDENTIAL - confidential'.
> These project may only be search for/found by users that are exlicit 
> participants of the projects. This over ruless the generic permissions of 
> 'PROJECTMGR_ADMIN' or 'PROJECTMGR_VIEW'.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9909) Marketing campaigns are not listed out within the given date range in Reports section

2018-04-28 Thread Ankit Joshi (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankit Joshi reassigned OFBIZ-9909:
--

Assignee: Ankit Joshi

> Marketing campaigns are not listed out within the given date range in Reports 
> section
> -
>
> Key: OFBIZ-9909
> URL: https://issues.apache.org/jira/browse/OFBIZ-9909
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
> Environment: demo-trunk.ofbiz.apache.org
>Reporter: Rubia Elza Joshep
>Assignee: Ankit Joshi
>Priority: Major
>
> Steps-
> 1) Open URL 
> https://demo-trunk.ofbiz.apache.org/marketing/control/MarketingCampaignReport
> 2) In marketing component, click "Reports'
> 3) Navigate to marketing campaign report, set the from date and through date 
> and click on "Run Marketing Campaign Report"
> Expected: All the marketing campaign should be listed out within the given 
> date range
> Actual: Marketing campaigns are not listed out within the given date range



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7741) Address scope peculiarities within search/find functionality of projectmgr

2018-04-28 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-7741:

Attachment: projectmgr-projectsearch-admin.png

> Address scope peculiarities within search/find functionality of projectmgr
> --
>
> Key: OFBIZ-7741
> URL: https://issues.apache.org/jira/browse/OFBIZ-7741
> Project: OFBiz
>  Issue Type: Improvement
>  Components: projectmgr
>Reporter: Pierre Smits
>Priority: Critical
> Attachments: projectmgr-projectsearch-admin.png
>
>
> Currently the search/find functions in the projectmgr component also 
> retrieves projects a user is not a participant in. This is especially 
> critical regarding projects with scope 'WES_PRIVATE - private' or 
> 'WES_CONFIDENTIAL - confidential'.
> These project may only be search for/found by users that are exlicit 
> participants of the projects. This over ruless the generic permissions of 
> 'PROJECTMGR_ADMIN' or 'PROJECTMGR_VIEW'.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10380) Convert facility party related services from simple to entity-auto

2018-04-28 Thread Suraj Khurana (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457478#comment-16457478
 ] 

Suraj Khurana commented on OFBIZ-10380:
---

Here is the patch with proper fix. Please have a look.

> Convert facility party related services from simple to entity-auto
> --
>
> Key: OFBIZ-10380
> URL: https://issues.apache.org/jira/browse/OFBIZ-10380
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10380.patch
>
>
> There is nothing extra in these services and they can be made to entity-auto



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10380) Convert facility party related services from simple to entity-auto

2018-04-28 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-10380:
--
Attachment: OFBIZ-10380.patch

> Convert facility party related services from simple to entity-auto
> --
>
> Key: OFBIZ-10380
> URL: https://issues.apache.org/jira/browse/OFBIZ-10380
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10380.patch
>
>
> There is nothing extra in these services and they can be made to entity-auto



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10384) Removing unused code

2018-04-28 Thread Swapnil M Mane (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil M Mane updated OFBIZ-10384:
---
Attachment: OFBIZ-10384.patch

> Removing unused code 
> -
>
> Key: OFBIZ-10384
> URL: https://issues.apache.org/jira/browse/OFBIZ-10384
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Swapnil M Mane
>Assignee: Swapnil M Mane
>Priority: Trivial
> Attachments: OFBIZ-10384.patch
>
>
> Just browsing through code found, we can remove unused code from 
> applications/order/groovyScripts/entry/CheckInits.groovy file



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10384) Removing unused code

2018-04-28 Thread Swapnil M Mane (JIRA)
Swapnil M Mane created OFBIZ-10384:
--

 Summary: Removing unused code 
 Key: OFBIZ-10384
 URL: https://issues.apache.org/jira/browse/OFBIZ-10384
 Project: OFBiz
  Issue Type: Improvement
Reporter: Swapnil M Mane
Assignee: Swapnil M Mane


Just browsing through code found, we can remove unused code from 
applications/order/groovyScripts/entry/CheckInits.groovy file



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10383) Fields are going outside the Item block

2018-04-28 Thread Archana Asthana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Archana Asthana updated OFBIZ-10383:

Attachment: AddDefaultToCart.png

> Fields are going outside the Item block
> ---
>
> Key: OFBIZ-10383
> URL: https://issues.apache.org/jira/browse/OFBIZ-10383
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/ecomseo/category/Gizmos-BEST-SELL-1.html
>Reporter: Archana Asthana
>Priority: Major
> Attachments: AddDefaultToCart.png
>
>
> Steps to generate: 
>  # Open 
> [https://demo-trunk.ofbiz.apache.org/ecomseo/category/Gizmos-BEST-SELL-1.html]
>  # Check the Items displayed. 
>  # Add Default Button bar is reflecting out of the field.
> Expected: The Button bar should reflect within the Item Block
> Image is attached for reference
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10383) Fields are going outside the Item block

2018-04-28 Thread Archana Asthana (JIRA)
Archana Asthana created OFBIZ-10383:
---

 Summary: Fields are going outside the Item block
 Key: OFBIZ-10383
 URL: https://issues.apache.org/jira/browse/OFBIZ-10383
 Project: OFBiz
  Issue Type: Bug
 Environment: 
https://demo-trunk.ofbiz.apache.org/ecomseo/category/Gizmos-BEST-SELL-1.html
Reporter: Archana Asthana


Steps to generate: 
 # Open 
[https://demo-trunk.ofbiz.apache.org/ecomseo/category/Gizmos-BEST-SELL-1.html]
 # Check the Items displayed. 
 # Add Default Button bar is reflecting out of the field.

Expected: The Button bar should reflect within the Item Block

Image is attached for reference

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10379) Exception handling for Add a new Party Role at createInvoiceRole

2018-04-28 Thread Pawan Verma (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457461#comment-16457461
 ] 

Pawan Verma commented on OFBIZ-10379:
-

There might be two solutions to resolve this error.
 # Run ensurePartyRole service to ensure role for party.
 # Display a proper error message to add role to party first.

Waiting for other's opinion on this than we can fix this. 

> Exception handling for Add a new Party Role at createInvoiceRole
> 
>
> Key: OFBIZ-10379
> URL: https://issues.apache.org/jira/browse/OFBIZ-10379
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/ap/control/createInvoiceRole
>Reporter: Aayush jain
>Priority: Minor
> Attachments: Error.png
>
>
> Steps:
> 1. Open URL https://demo-trunk.ofbiz.apache.org/ap/control/createInvoiceRole
> 2. Add a party Id which does not assigned as a role for accounts
> 3. Enter Percentage
> 4. Click on submit button
> Actual Result: 
> Throwing an exception error for the invalid case, Kindly refer attachment for 
> the same
> Expected Result:
> We must handle exceptions with a proper error message, I don't think this is 
> working fine, It should be correct with proper message.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10382) Scope of project is not shown

2018-04-28 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-10382:
-
Attachment: projectmgr-projectsearch-DemoEmployee1.png

> Scope of project is not shown
> -
>
> Key: OFBIZ-10382
> URL: https://issues.apache.org/jira/browse/OFBIZ-10382
> Project: OFBiz
>  Issue Type: Improvement
>  Components: projectmgr
>Affects Versions: Trunk, 17.12.01, 16.11.04, 16.11.05
>Reporter: Pierre Smits
>Priority: Minor
> Attachments: projectmgr-main-DemoEmployee1.png, 
> projectmgr-projectsearch-DemoEmployee1.png, projectmgr-summary-admin.png
>
>
> Currently the scope of a project is not shown in the main overview, the 
> projectmgr search/find function for projects, and the  project summary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10382) Scope of project is not shown

2018-04-28 Thread Pierre Smits (JIRA)
Pierre Smits created OFBIZ-10382:


 Summary: Scope of project is not shown
 Key: OFBIZ-10382
 URL: https://issues.apache.org/jira/browse/OFBIZ-10382
 Project: OFBiz
  Issue Type: Improvement
  Components: projectmgr
Affects Versions: 16.11.04, Trunk, 17.12.01, 16.11.05
Reporter: Pierre Smits
 Attachments: projectmgr-main-DemoEmployee1.png, 
projectmgr-summary-admin.png

Currently the scope of a project is not shown in the main overview, the 
projectmgr search/find function for projects, and the  project summary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10382) Scope of project is not shown

2018-04-28 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-10382:
-
Attachment: projectmgr-main-DemoEmployee1.png

> Scope of project is not shown
> -
>
> Key: OFBIZ-10382
> URL: https://issues.apache.org/jira/browse/OFBIZ-10382
> Project: OFBiz
>  Issue Type: Improvement
>  Components: projectmgr
>Affects Versions: Trunk, 17.12.01, 16.11.04, 16.11.05
>Reporter: Pierre Smits
>Priority: Minor
> Attachments: projectmgr-main-DemoEmployee1.png, 
> projectmgr-summary-admin.png
>
>
> Currently the scope of a project is not shown in the main overview, the 
> projectmgr search/find function for projects, and the  project summary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10382) Scope of project is not shown

2018-04-28 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-10382:
-
Attachment: projectmgr-summary-admin.png

> Scope of project is not shown
> -
>
> Key: OFBIZ-10382
> URL: https://issues.apache.org/jira/browse/OFBIZ-10382
> Project: OFBiz
>  Issue Type: Improvement
>  Components: projectmgr
>Affects Versions: Trunk, 17.12.01, 16.11.04, 16.11.05
>Reporter: Pierre Smits
>Priority: Minor
> Attachments: projectmgr-main-DemoEmployee1.png, 
> projectmgr-summary-admin.png
>
>
> Currently the scope of a project is not shown in the main overview, the 
> projectmgr search/find function for projects, and the  project summary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10282) Remove empty field values from xml data files so that it will not override existing data with empty values

2018-04-28 Thread Suraj Khurana (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457455#comment-16457455
 ] 

Suraj Khurana commented on OFBIZ-10282:
---

Attached patch in which we have removed all empty data fields from data files.
Please have a look.

> Remove empty field values from xml data files so that it will not override 
> existing data with empty values
> --
>
> Key: OFBIZ-10282
> URL: https://issues.apache.org/jira/browse/OFBIZ-10282
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
> Attachments: OFBIZ-10282-plugins.patch, OFBIZ-10282.patch
>
>
> Remove empty systemPropertyValue field values from SystemProperty xml data 
> files.
> Current system overrides  value with empty value if it is mentioned in XML 
> data tag. So need to remove empty field values to override data on the 
> existing instance. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10282) Remove empty field values from xml data files so that it will not override existing data with empty values

2018-04-28 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-10282:
--
Attachment: OFBIZ-10282-plugins.patch
OFBIZ-10282.patch

> Remove empty field values from xml data files so that it will not override 
> existing data with empty values
> --
>
> Key: OFBIZ-10282
> URL: https://issues.apache.org/jira/browse/OFBIZ-10282
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
> Attachments: OFBIZ-10282-plugins.patch, OFBIZ-10282.patch
>
>
> Remove empty systemPropertyValue field values from SystemProperty xml data 
> files.
> Current system overrides  value with empty value if it is mentioned in XML 
> data tag. So need to remove empty field values to override data on the 
> existing instance. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10374) Existing BILLING_LOCATION record of party should expire while creating a new one

2018-04-28 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-10374:
--
Issue Type: Bug  (was: Improvement)

> Existing BILLING_LOCATION record of party should expire while creating a new 
> one
> 
>
> Key: OFBIZ-10374
> URL: https://issues.apache.org/jira/browse/OFBIZ-10374
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-10374.patch
>
>
> In createUpdateBillingAddress service, it is not handled properly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10374) Existing BILLING_LOCATION record of party should expire while creating a new one

2018-04-28 Thread Suraj Khurana (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457451#comment-16457451
 ] 

Suraj Khurana commented on OFBIZ-10374:
---

Attached path with proper fix. Please have a look.

Thanks !!!

> Existing BILLING_LOCATION record of party should expire while creating a new 
> one
> 
>
> Key: OFBIZ-10374
> URL: https://issues.apache.org/jira/browse/OFBIZ-10374
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-10374.patch
>
>
> In createUpdateBillingAddress service, it is not handled properly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10374) Existing BILLING_LOCATION record of party should expire while creating a new one

2018-04-28 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-10374:
--
Attachment: OFBIZ-10374.patch

> Existing BILLING_LOCATION record of party should expire while creating a new 
> one
> 
>
> Key: OFBIZ-10374
> URL: https://issues.apache.org/jira/browse/OFBIZ-10374
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-10374.patch
>
>
> In createUpdateBillingAddress service, it is not handled properly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7713) Introduce a quick way for adding Sales Price agreements with customers for any specific product from Catalog

2018-04-28 Thread Mohammad Kathawala (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457450#comment-16457450
 ] 

Mohammad Kathawala commented on OFBIZ-7713:
---

[~swash78] , I think we should keep the 'PartyId To' empty only. There can be 
multiple product stores and multiple internal organizations in the system. I 
have added patch for showing now time stamp in from date field. I think we can 
close this task after committing the recent patch.

 

Thanks.

> Introduce a quick way for adding Sales Price agreements with customers for 
> any specific product from Catalog
> 
>
> Key: OFBIZ-7713
> URL: https://issues.apache.org/jira/browse/OFBIZ-7713
> Project: OFBiz
>  Issue Type: New Feature
>  Components: product
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Mohammad Kathawala
>Priority: Major
> Attachments: OFBIZ-7713.patch, OFBIZ-7713.patch, SPA.png
>
>
> Currently new pricing agreements creation takes user to Accounting app where 
> it is quite an long and arduous process. And many a times a catalog or sales 
> manager doesn't have accounting permission in case quick pricing agreement 
> needs to be placed with customer for specific product(s).
> We can provide a quick option from Catalog >> Product >> Agreement screen 
> over "Sales" section that could unfold as follows:
> # Have a 'Create Price Agreement' link/button on the Sales Panel and hitting 
> this link could ask user to enter following very basic parameters:
> #- Party Id From
> #- Party Id To (Default it to product store's owner party id)
> #- From Date (default it to show as now() timestamp)
> #- Through Date
> #- Description
> #- Price
> #- Currency
> # Upon successful submission of above details system should create Agreement 
> and Agreement Item between customer and organization by passing following 
> default values:
> #- Role Type Id From = 'Customer'
> #- Role Type Id To = 'Internal Organization'
> #- Agreement Type Id = 'Sales'
> #- Agreement Item Type Id = 'Pricing'
> #- Product Id= ''
> Please refer to attached screenshot for reference placeholder



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10381) Issue with Update Currency UOM at Edit Invoice

2018-04-28 Thread Priya Sharma (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Priya Sharma reassigned OFBIZ-10381:


Assignee: Priya Sharma

> Issue with Update Currency UOM at Edit Invoice
> --
>
> Key: OFBIZ-10381
> URL: https://issues.apache.org/jira/browse/OFBIZ-10381
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/ap/control/invoiceOverview?invoiceId=demo10001
>Reporter: Aayush jain
>Assignee: Priya Sharma
>Priority: Minor
> Attachments: UOM_issue.png
>
>
> Steps:
> 1. Open URL 
> https://demo-trunk.ofbiz.apache.org/ap/control/editInvoice?invoiceId=demo10001
> 2. Navigate to report section
> 3. Navigate to Edit Invoice and change the currency for USD and INR
> 4. Click on Update button
> 5. Again Navigate to reports section and click on invoice id which was updated
> 6. Navigate to Items section and check for UOM and Unit price
> Actual Result:
> UOM is still displayed as USD and unit price changes to Indian rupees
> Expected Result:
> It should work as per currency, UOM and Price should be displayed properly 
> i.e for Indian rupee INR and Rupee symbol 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7713) Introduce a quick way for adding Sales Price agreements with customers for any specific product from Catalog

2018-04-28 Thread Mohammad Kathawala (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohammad Kathawala updated OFBIZ-7713:
--
Attachment: OFBIZ-7713.patch

> Introduce a quick way for adding Sales Price agreements with customers for 
> any specific product from Catalog
> 
>
> Key: OFBIZ-7713
> URL: https://issues.apache.org/jira/browse/OFBIZ-7713
> Project: OFBiz
>  Issue Type: New Feature
>  Components: product
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Mohammad Kathawala
>Priority: Major
> Attachments: OFBIZ-7713.patch, OFBIZ-7713.patch, SPA.png
>
>
> Currently new pricing agreements creation takes user to Accounting app where 
> it is quite an long and arduous process. And many a times a catalog or sales 
> manager doesn't have accounting permission in case quick pricing agreement 
> needs to be placed with customer for specific product(s).
> We can provide a quick option from Catalog >> Product >> Agreement screen 
> over "Sales" section that could unfold as follows:
> # Have a 'Create Price Agreement' link/button on the Sales Panel and hitting 
> this link could ask user to enter following very basic parameters:
> #- Party Id From
> #- Party Id To (Default it to product store's owner party id)
> #- From Date (default it to show as now() timestamp)
> #- Through Date
> #- Description
> #- Price
> #- Currency
> # Upon successful submission of above details system should create Agreement 
> and Agreement Item between customer and organization by passing following 
> default values:
> #- Role Type Id From = 'Customer'
> #- Role Type Id To = 'Internal Organization'
> #- Agreement Type Id = 'Sales'
> #- Agreement Item Type Id = 'Pricing'
> #- Product Id= ''
> Please refer to attached screenshot for reference placeholder



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7741) Address scope peculiarities within search/find functionality of projectmgr

2018-04-28 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457442#comment-16457442
 ] 

Pierre Smits commented on OFBIZ-7741:
-

Hello [~mleila],

I experienced this issue almost 2 years ago. It might have been resolved since 
then.

Best regards,

Pierre

> Address scope peculiarities within search/find functionality of projectmgr
> --
>
> Key: OFBIZ-7741
> URL: https://issues.apache.org/jira/browse/OFBIZ-7741
> Project: OFBiz
>  Issue Type: Improvement
>  Components: projectmgr
>Reporter: Pierre Smits
>Priority: Critical
>
> Currently the search/find functions in the projectmgr component also 
> retrieves projects a user is not a participant in. This is especially 
> critical regarding projects with scope 'WES_PRIVATE - private' or 
> 'WES_CONFIDENTIAL - confidential'.
> These project may only be search for/found by users that are exlicit 
> participants of the projects. This over ruless the generic permissions of 
> 'PROJECTMGR_ADMIN' or 'PROJECTMGR_VIEW'.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10331) Improve Order

2018-04-28 Thread Nicolas Malin (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457426#comment-16457426
 ] 

Nicolas Malin commented on OFBIZ-10331:
---

Hi Dennis, I checked some patches and I have a issue with 
[^OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch] with display the form 
 !Sélection_156.png!

I didn't know if it the waiting result.

A little problem for with patch 
OFBIZ-10221_order.template.order.FindOrders.patch
{code:java}
poveglia$ patch -p1 < 
~/Téléchargements/OFBIZ-10221_order.template.order.FindOrders.patch
patching file applications/order/template/order/FindOrders.ftl
patch:  malformed patch at line 434: 
{code}
and patch OFBiz-10221_order.template.order.OrderInfo.patch
{code:java}
poveglia$ svn info
Révision : 1830238

poveglia$ patch -p1 < 
~/Téléchargements/OFBiz-10221_order.template.order.OrderInfo.patch
patching file applications/order/template/order/OrderInfo.ftl
Hunk #1 succeeded at 96 (offset -4 lines).
...

Hunk #8 succeeded at 223 (offset -4 lines).
Hunk #9 FAILED at 236.
Hunk #10 FAILED at 253.
Hunk #11 FAILED at 270.
Hunk #12 succeeded at 285 (offset -5 lines).
3 out of 12 hunks FAILED -- saving rejects to file 
applications/order/template/order/OrderInfo.ftl.rej{code}
I will continue the review later for other patches

thanks for your thorough work

> Improve Order
> -
>
> Key: OFBIZ-10331
> URL: https://issues.apache.org/jira/browse/OFBIZ-10331
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, 
> OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, 
> OFBIZ-10221_common-theme.template.includes.GenericLink.patch, 
> OFBIZ-10221_order.template.entry.CheckInits.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, 
> OFBIZ-10221_order.template.entry.OrderAgreements.patch, 
> OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, 
> OFBIZ-10221_order.template.entry.OrderShortcuts.patch, 
> OFBIZ-10221_order.template.entry.cart.ShowCart.patch, 
> OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, 
> OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, 
> OFBIZ-10221_order.template.order.FindOrders.patch, 
> OFBIZ-10221_order.template.order.OrderList.patch, 
> OFBIZ-10221_order.template.order.OrderStats.patch, 
> OFBiz-10221_order.template.order.OrderContactInfo.patch, 
> OFBiz-10221_order.template.order.OrderInfo.patch, 
> OFBiz-10221_order.template.order.OrderItems.patch, 
> OFBiz-10221_order.template.order.OrderPaymentInfo.patch, 
> OFBiz-10221_order.template.order.OrderShippingInfo.patch, Sélection_156.png
>
>
> All improvements for layout and structure for the Order-Application



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10331) Improve Order

2018-04-28 Thread Nicolas Malin (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin updated OFBIZ-10331:
--
Attachment: Sélection_156.png

> Improve Order
> -
>
> Key: OFBIZ-10331
> URL: https://issues.apache.org/jira/browse/OFBIZ-10331
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, 
> OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, 
> OFBIZ-10221_common-theme.template.includes.GenericLink.patch, 
> OFBIZ-10221_order.template.entry.CheckInits.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, 
> OFBIZ-10221_order.template.entry.OrderAgreements.patch, 
> OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, 
> OFBIZ-10221_order.template.entry.OrderShortcuts.patch, 
> OFBIZ-10221_order.template.entry.cart.ShowCart.patch, 
> OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, 
> OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, 
> OFBIZ-10221_order.template.order.FindOrders.patch, 
> OFBIZ-10221_order.template.order.OrderList.patch, 
> OFBIZ-10221_order.template.order.OrderStats.patch, 
> OFBiz-10221_order.template.order.OrderContactInfo.patch, 
> OFBiz-10221_order.template.order.OrderInfo.patch, 
> OFBiz-10221_order.template.order.OrderItems.patch, 
> OFBiz-10221_order.template.order.OrderPaymentInfo.patch, 
> OFBiz-10221_order.template.order.OrderShippingInfo.patch, Sélection_156.png
>
>
> All improvements for layout and structure for the Order-Application



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10381) Issue with Update Currency UOM at Edit Invoice

2018-04-28 Thread Aayush jain (JIRA)
Aayush jain created OFBIZ-10381:
---

 Summary: Issue with Update Currency UOM at Edit Invoice
 Key: OFBIZ-10381
 URL: https://issues.apache.org/jira/browse/OFBIZ-10381
 Project: OFBiz
  Issue Type: Bug
 Environment: 
https://demo-trunk.ofbiz.apache.org/ap/control/invoiceOverview?invoiceId=demo10001
Reporter: Aayush jain
 Attachments: UOM_issue.png

Steps:
1. Open URL 
https://demo-trunk.ofbiz.apache.org/ap/control/editInvoice?invoiceId=demo10001
2. Navigate to report section
3. Navigate to Edit Invoice and change the currency for USD and INR
4. Click on Update button
5. Again Navigate to reports section and click on invoice id which was updated
6. Navigate to Items section and check for UOM and Unit price

Actual Result:
UOM is still displayed as USD and unit price changes to Indian rupees

Expected Result:
It should work as per currency, UOM and Price should be displayed properly i.e 
for Indian rupee INR and Rupee symbol 




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10380) Convert facility party related services from simple to entity-auto

2018-04-28 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-10380:
--
Issue Type: Sub-task  (was: Improvement)
Parent: OFBIZ-8408

> Convert facility party related services from simple to entity-auto
> --
>
> Key: OFBIZ-10380
> URL: https://issues.apache.org/jira/browse/OFBIZ-10380
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
>
> There is nothing extra in these services and they can be made to entity-auto



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10380) Convert facility party related services from simple to entity-auto

2018-04-28 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-10380:
-

 Summary: Convert facility party related services from simple to 
entity-auto
 Key: OFBIZ-10380
 URL: https://issues.apache.org/jira/browse/OFBIZ-10380
 Project: OFBiz
  Issue Type: Improvement
Reporter: Suraj Khurana
Assignee: Suraj Khurana


There is nothing extra in these services and they can be made to entity-auto



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10376) Remove hard coded values from removePromotion

2018-04-28 Thread Shikha Jaiswal (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shikha Jaiswal reassigned OFBIZ-10376:
--

Assignee: (was: Shikha Jaiswal)

> Remove hard coded values from removePromotion
> -
>
> Key: OFBIZ-10376
> URL: https://issues.apache.org/jira/browse/OFBIZ-10376
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Shikha Jaiswal
>Priority: Minor
> Attachments: OFBIZ-10376.patch
>
>
> In removePromotion, values used to fetch data from ProductPromoAction are 
> hard coded. Need to remove these hard-coded values.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)