[jira] [Commented] (OFBIZ-10471) setLocaleFromBrowser should only called once by session
[ https://issues.apache.org/jira/browse/OFBIZ-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539586#comment-16539586 ] Deepak Dixit commented on OFBIZ-10471: -- I think it might be due to the following reason: auth is true for setLocaleFromBrowser, as on login page userLogin is null and system save the setLocaleFromBrowser and redirect to checklogin, after login system execute setLocaleFromBrowser request and serve its response. So it's more related to OFBIZ-10460 > setLocaleFromBrowser should only called once by session > --- > > Key: OFBIZ-10471 > URL: https://issues.apache.org/jira/browse/OFBIZ-10471 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: Screen Shot 2018-07-11 at 11.03.02 AM.png > > > As Deepak mentioned in r1816537, currenlty setLocaleFromBrowser is called > each time a page is refreshed. > We can use > [sessionStorage|https://developer.mozilla.org/en-US/docs/Web/API/Window/sessionStorage] > to have it called only once by session -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10471) setLocaleFromBrowser should only called once by session
[ https://issues.apache.org/jira/browse/OFBIZ-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539585#comment-16539585 ] Deepak Dixit commented on OFBIZ-10471: -- Hi Jacques, I am getting a blank page after login from webtools, I am able to generate it locally but its random I am not sure if its related to OFBIZ-10460 or current ticket. Please refer attached screenshot. > setLocaleFromBrowser should only called once by session > --- > > Key: OFBIZ-10471 > URL: https://issues.apache.org/jira/browse/OFBIZ-10471 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: Screen Shot 2018-07-11 at 11.03.02 AM.png > > > As Deepak mentioned in r1816537, currenlty setLocaleFromBrowser is called > each time a page is refreshed. > We can use > [sessionStorage|https://developer.mozilla.org/en-US/docs/Web/API/Window/sessionStorage] > to have it called only once by session -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10471) setLocaleFromBrowser should only called once by session
[ https://issues.apache.org/jira/browse/OFBIZ-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-10471: - Attachment: Screen Shot 2018-07-11 at 11.03.02 AM.png > setLocaleFromBrowser should only called once by session > --- > > Key: OFBIZ-10471 > URL: https://issues.apache.org/jira/browse/OFBIZ-10471 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: Screen Shot 2018-07-11 at 11.03.02 AM.png > > > As Deepak mentioned in r1816537, currenlty setLocaleFromBrowser is called > each time a page is refreshed. > We can use > [sessionStorage|https://developer.mozilla.org/en-US/docs/Web/API/Window/sessionStorage] > to have it called only once by session -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539559#comment-16539559 ] Jacques Le Roux commented on OFBIZ-7598: HI Suraj, Dennis, Dennis, if by "there is more than one, " in bq. The results only start to show if there is more than one, otherwise the table shows up without content, but just the header. you mean "there is more than one page" then the problem is fixed with the last patch. Else please let me know more about it, thanks. > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: Image 002.png, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.png > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10470) Inconsistent screenlet-title containers
[
https://issues.apache.org/jira/browse/OFBIZ-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539245#comment-16539245
]
Jacques Le Roux commented on OFBIZ-10470:
-
Hi Dennis,
I did not get deep in this, but I believe that again it's because a FTL
template (OrderListByDate.ftl ) is used in the link you provided. I strongly
believe we will never get where we want as long as we will use FTL templates in
backend in places where widget forms could be used.
The beauty of form widget is it generates HTML code, so it's consistent by
design ;)
> Inconsistent screenlet-title containers
> ---
>
> Key: OFBIZ-10470
> URL: https://issues.apache.org/jira/browse/OFBIZ-10470
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Dennis Balkir
>Priority: Minor
>
> Through the OFBiz-Backend there is some inconsistency in the use of
> screenlet-titles.
> The title is normally nested inside this:
> {code:html}
>
>
>
> {code}
> But the title itself differs throughout the. backend quite often.
> As far as I have seen, there are 3 main kinds of title:
> # {code:html}
>
>
> Title
> {code}
> # {code:html}
>
>
> Title
> {code}
> # {code:html}
>
>
>
> Title
> {code}
> All three variants can be found right here:
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderentry
> ({{li}} is used in the {{left}}-container, {{h3}} is used for "Create Sales
> Order" and {{div}} is used for the other screenlets)
> Wouldn't it be better to limit this to one kind of container, and maybe style
> the differences (if wanted) through classes?
> Or maybe two containers, which then can be styled differently?
> The way it is now, with most of them looking the same anyway, it seems rather
> confusing than useful
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10470) Inconsistent screenlet-title containers
[
https://issues.apache.org/jira/browse/OFBIZ-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539245#comment-16539245
]
Jacques Le Roux edited comment on OFBIZ-10470 at 7/10/18 9:20 PM:
--
Hi Dennis,
I did not get deep in this so I could be wrong. I believe that again it's
because a FTL template (OrderListByDate.ftl ) is used in the link you provided.
I strongly believe we will never get where we want as long as we will use FTL
templates in backend in places where widget forms could be used.
The beauty of form widget is it generates HTML code, so it's consistent by
design ;)
was (Author: jacques.le.roux):
Hi Dennis,
I did not get deep in this, but I believe that again it's because a FTL
template (OrderListByDate.ftl ) is used in the link you provided. I strongly
believe we will never get where we want as long as we will use FTL templates in
backend in places where widget forms could be used.
The beauty of form widget is it generates HTML code, so it's consistent by
design ;)
> Inconsistent screenlet-title containers
> ---
>
> Key: OFBIZ-10470
> URL: https://issues.apache.org/jira/browse/OFBIZ-10470
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Dennis Balkir
>Priority: Minor
>
> Through the OFBiz-Backend there is some inconsistency in the use of
> screenlet-titles.
> The title is normally nested inside this:
> {code:html}
>
>
>
> {code}
> But the title itself differs throughout the. backend quite often.
> As far as I have seen, there are 3 main kinds of title:
> # {code:html}
>
>
> Title
> {code}
> # {code:html}
>
>
> Title
> {code}
> # {code:html}
>
>
>
> Title
> {code}
> All three variants can be found right here:
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderentry
> ({{li}} is used in the {{left}}-container, {{h3}} is used for "Create Sales
> Order" and {{div}} is used for the other screenlets)
> Wouldn't it be better to limit this to one kind of container, and maybe style
> the differences (if wanted) through classes?
> Or maybe two containers, which then can be styled differently?
> The way it is now, with most of them looking the same anyway, it seems rather
> confusing than useful
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10464) Improve Accounting -AP
[ https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539227#comment-16539227 ] Jacques Le Roux edited comment on OFBIZ-10464 at 7/10/18 9:15 PM: -- Dennis, I don't see much difference in UI (did not look at the HTML source), but I used only the default theme. Maybe it's more relevant with another? Also what about AR? Same issue no? was (Author: jacques.le.roux): Dennis, I don't see much difference, but I used only the default theme. Maybe it's more relevant with another? Also what about AR? Same issue no? > Improve Accounting -AP > -- > > Key: OFBIZ-10464 > URL: https://issues.apache.org/jira/browse/OFBIZ-10464 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: accounting-ap_main-page.patch > > > I found some structural differences while looking on accounting-ap -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10464) Improve Accounting -AP
[ https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539229#comment-16539229 ] Jacques Le Roux commented on OFBIZ-10464: - Pierre, As we like to say, feel free to improve the portal thing :) > Improve Accounting -AP > -- > > Key: OFBIZ-10464 > URL: https://issues.apache.org/jira/browse/OFBIZ-10464 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: accounting-ap_main-page.patch > > > I found some structural differences while looking on accounting-ap -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10464) Improve Accounting -AP
[ https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539227#comment-16539227 ] Jacques Le Roux commented on OFBIZ-10464: - Dennis, I don't see much difference, but I used only the default theme. Maybe it's more relevant with another? Also what about AR? Same issue no? > Improve Accounting -AP > -- > > Key: OFBIZ-10464 > URL: https://issues.apache.org/jira/browse/OFBIZ-10464 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: accounting-ap_main-page.patch > > > I found some structural differences while looking on accounting-ap -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10464) Improve Accounting -AP
[ https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539222#comment-16539222 ] Jacques Le Roux commented on OFBIZ-10464: - Hi Dennis, You wrote: bq. Most of the times, the main screens just include .ftl files Which is a pity. For instance you improved catalog/control/main with r1829700 for OFBIZ-10221. But then the fields are no longer aligned. So I have created OFBIZ-10454. We should only use form widgets in the backend to easily keep things concistent. Unfortunately we have a ton of legacy to change. Anyway, thanks for your good work :) > Improve Accounting -AP > -- > > Key: OFBIZ-10464 > URL: https://issues.apache.org/jira/browse/OFBIZ-10464 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: accounting-ap_main-page.patch > > > I found some structural differences while looking on accounting-ap -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10458) GetLocaleList call can provide duplicate results
[
https://issues.apache.org/jira/browse/OFBIZ-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539169#comment-16539169
]
Gil Portenseigne commented on OFBIZ-10458:
--
Hi [~mthl], i just committed the improvment of using .with groovy notation :
trunk r1835599
> GetLocaleList call can provide duplicate results
>
>
> Key: OFBIZ-10458
> URL: https://issues.apache.org/jira/browse/OFBIZ-10458
> Project: OFBiz
> Issue Type: Bug
>Reporter: Mathieu Lirzin
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: 17.12.01, 16.11.05
>
> Attachments: OFBIZ-10458_0001-Add-failing-tests.patch,
> OFBIZ-10458_0002-Fix-duplicates-bug.patch, OFBIZ-10458_0003-Refactor.patch
>
>
> This is not a huge issue but I detected an issue with the {{GetLocaleList}}
> script which when providing both a {{localeString}} and {{localeName}} can
> provide duplicate results.
> Here is a set of 3 patches that should be applied in order:
> - the first one is adding some tests with a failing one which identifies the
> bug
> - the second one resolves the bug
> - the third one refactors the code to use a more functional style
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-10363) Improve Dutch UiLabels
[ https://issues.apache.org/jira/browse/OFBIZ-10363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-10363. - Resolution: Implemented Assignee: Nicolas Malin Hi pierre, I loaded it at revision 1835592 on trunk > Improve Dutch UiLabels > -- > > Key: OFBIZ-10363 > URL: https://issues.apache.org/jira/browse/OFBIZ-10363 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Nicolas Malin >Priority: Minor > Attachments: ofbiz-10363-AccountingUiLabels.xml.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10472) Rename the misnamed setUserLocale.js to setUserTimeZone.js
Jacques Le Roux created OFBIZ-10472: --- Summary: Rename the misnamed setUserLocale.js to setUserTimeZone.js Key: OFBIZ-10472 URL: https://issues.apache.org/jira/browse/OFBIZ-10472 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Because this anme is confusing as it's only about handling user timezone. It was done with OFBIZ-9264 and improved/fixed since -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10093) Replace ELRTE plugin with TinyMCE.
[ https://issues.apache.org/jira/browse/OFBIZ-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539016#comment-16539016 ] Jacques Le Roux commented on OFBIZ-10093: - Thanks for the headsup Pierre, I agree Pierre, Aditya, could you please double-check and do as Pierre suggested? TIA :) > Replace ELRTE plugin with TinyMCE. > -- > > Key: OFBIZ-10093 > URL: https://issues.apache.org/jira/browse/OFBIZ-10093 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Major > > As there is no support for elrte since elrte-1.3 > https://github.com/Studio-42/elRTE it is to be replaced with some other good > editor like TinyMCE: > * 171 releases (latest 14 days ago) > * Good community support of 171 contributors > * Licence - GNU LESSER GENERAL PUBLIC LICENSE Version 2.1, February 1999 > Links for reference: > https://github.com/tinymce/tinymce. > https://www.tinymce.com/download/ > https://www.tinymce.com/docs/configure/localization/ > https://www.tinymce.com/download/language-packages/ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10212) Open ecommerce by default on user default language
[ https://issues.apache.org/jira/browse/OFBIZ-10212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539008#comment-16539008 ] Jacques Le Roux commented on OFBIZ-10212: - My comment above does not make any sense, setUserLocale.js is misnamed and is actually only related to timezone :/ > Open ecommerce by default on user default language > --- > > Key: OFBIZ-10212 > URL: https://issues.apache.org/jira/browse/OFBIZ-10212 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > > By default the ecommerce always open in English. It should open in the user > default language like it happens for backend applications. > I'm not sure but I wonder if the webpos has not the same problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10471) setLocaleFromBrowser should only called once by session
[ https://issues.apache.org/jira/browse/OFBIZ-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10471. --- Resolution: Implemented Done at revision 1835585. > setLocaleFromBrowser should only called once by session > --- > > Key: OFBIZ-10471 > URL: https://issues.apache.org/jira/browse/OFBIZ-10471 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > As Deepak mentioned in r1816537, currenlty setLocaleFromBrowser is called > each time a page is refreshed. > We can use > [sessionStorage|https://developer.mozilla.org/en-US/docs/Web/API/Window/sessionStorage] > to have it called only once by session -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10471) setLocaleFromBrowser should only called once by session
Jacques Le Roux created OFBIZ-10471: --- Summary: setLocaleFromBrowser should only called once by session Key: OFBIZ-10471 URL: https://issues.apache.org/jira/browse/OFBIZ-10471 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Fix For: Upcoming Branch As Deepak mentioned in r1816537, currenlty setLocaleFromBrowser is called each time a page is refreshed. We can use [sessionStorage|https://developer.mozilla.org/en-US/docs/Web/API/Window/sessionStorage] to have it called only once by session -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10467) Using "buttontext" styling for the index of service engine
[ https://issues.apache.org/jira/browse/OFBIZ-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538848#comment-16538848 ] Jacques Le Roux commented on OFBIZ-10467: - +1 > Using "buttontext" styling for the index of service engine > -- > > Key: OFBIZ-10467 > URL: https://issues.apache.org/jira/browse/OFBIZ-10467 > Project: OFBiz > Issue Type: Improvement > Components: framework/webtools >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Aditya Sharma >Priority: Minor > Attachments: buttons1.png, buttons2.png, buttons3.png, buttons4.png, > image-2018-07-09-16-13-01-707.png, service-engine_buttons.patch > > > To give OFBiz a more equal look, the style "buttontext" can be added for the > alphabetical index of the service engine main page. > This makes the buttons look alike with the ones that are already there for > the entity engine main page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538759#comment-16538759 ] Jacques Le Roux commented on OFBIZ-10145: - Do we want this as a blocker for the next release? > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Major > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper.sh > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10439) Entity Maintenance / FindGeneric result list misses first data set
[ https://issues.apache.org/jira/browse/OFBIZ-10439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10439. - Resolution: Duplicate > Entity Maintenance / FindGeneric result list misses first data set > -- > > Key: OFBIZ-10439 > URL: https://issues.apache.org/jira/browse/OFBIZ-10439 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Michael Brohl >Priority: Major > > Steps to reproduce on the demo instance for trunk: > # [https://demo-trunk.ofbiz.apache.org/webtools/control/EntitySQLProcessor:] > select * from ORDER_HEADER -> shows 6 rows > # > [https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=OrderHeader=Y] > -> shows 5 rows, the first one with orderId DEMO10090 is missing > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10439) Entity Maintenance / FindGeneric result list misses first data set
[ https://issues.apache.org/jira/browse/OFBIZ-10439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538471#comment-16538471 ] Michael Brohl commented on OFBIZ-10439: --- In fact OFBIZ-10456 is a duplicate of this issue, but since it is fixed there I will close as duplicate. > Entity Maintenance / FindGeneric result list misses first data set > -- > > Key: OFBIZ-10439 > URL: https://issues.apache.org/jira/browse/OFBIZ-10439 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Michael Brohl >Priority: Major > > Steps to reproduce on the demo instance for trunk: > # [https://demo-trunk.ofbiz.apache.org/webtools/control/EntitySQLProcessor:] > select * from ORDER_HEADER -> shows 6 rows > # > [https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=OrderHeader=Y] > -> shows 5 rows, the first one with orderId DEMO10090 is missing > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10466) UI issue on blog screens on storefront
[
https://issues.apache.org/jira/browse/OFBIZ-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Sharma reassigned OFBIZ-10466:
-
Assignee: Aditya Sharma (was: Pritam Kute)
> UI issue on blog screens on storefront
> --
>
> Key: OFBIZ-10466
> URL: https://issues.apache.org/jira/browse/OFBIZ-10466
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Aditya Sharma
>Priority: Minor
> Fix For: Trunk, Upcoming Branch
>
> Attachments: OFBIZ-10466.patch
>
>
>
> This issue is because of the CSS rule written for in [this
> commit|https://ofbiz.markmail.org/message/sgyeuxqvjviijb2k?q=implemented+blog+rss+feed+list:org%2Eapache%2Eofbiz%2Ecommits=1].
> {code:java}
> .bloghr {
> border: 0.1em solid #99;
> color: white;
> background: #1C334D;
> padding: 4px;
> height: 13px;
> }
> {code}
> Increasing height property in the above rule will fix the UI of the blog
> header on all blog related screens.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10467) Using "buttontext" styling for the index of service engine
[ https://issues.apache.org/jira/browse/OFBIZ-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538447#comment-16538447 ] Aditya Sharma commented on OFBIZ-10467: --- I'll wait for a day and commit if nobody sees a problem with it. > Using "buttontext" styling for the index of service engine > -- > > Key: OFBIZ-10467 > URL: https://issues.apache.org/jira/browse/OFBIZ-10467 > Project: OFBiz > Issue Type: Improvement > Components: framework/webtools >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Aditya Sharma >Priority: Minor > Attachments: buttons1.png, buttons2.png, buttons3.png, buttons4.png, > image-2018-07-09-16-13-01-707.png, service-engine_buttons.patch > > > To give OFBiz a more equal look, the style "buttontext" can be added for the > alphabetical index of the service engine main page. > This makes the buttons look alike with the ones that are already there for > the entity engine main page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10467) Using "buttontext" styling for the index of service engine
[ https://issues.apache.org/jira/browse/OFBIZ-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538424#comment-16538424 ] Aditya Sharma commented on OFBIZ-10467: --- Sure Pierre :) > Using "buttontext" styling for the index of service engine > -- > > Key: OFBIZ-10467 > URL: https://issues.apache.org/jira/browse/OFBIZ-10467 > Project: OFBiz > Issue Type: Improvement > Components: framework/webtools >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Aditya Sharma >Priority: Minor > Attachments: buttons1.png, buttons2.png, buttons3.png, buttons4.png, > image-2018-07-09-16-13-01-707.png, service-engine_buttons.patch > > > To give OFBiz a more equal look, the style "buttontext" can be added for the > alphabetical index of the service engine main page. > This makes the buttons look alike with the ones that are already there for > the entity engine main page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10439) Entity Maintenance / FindGeneric result list misses first data set
[ https://issues.apache.org/jira/browse/OFBIZ-10439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538418#comment-16538418 ] Suraj Khurana commented on OFBIZ-10439: --- Hello, Seems like this issue is fixed. IMO, it is a duplicate of OFBIZ-10456 > Entity Maintenance / FindGeneric result list misses first data set > -- > > Key: OFBIZ-10439 > URL: https://issues.apache.org/jira/browse/OFBIZ-10439 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Michael Brohl >Priority: Major > > Steps to reproduce on the demo instance for trunk: > # [https://demo-trunk.ofbiz.apache.org/webtools/control/EntitySQLProcessor:] > select * from ORDER_HEADER -> shows 6 rows > # > [https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=OrderHeader=Y] > -> shows 5 rows, the first one with orderId DEMO10090 is missing > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10439) Entity Maintenance / FindGeneric result list misses first data set
[ https://issues.apache.org/jira/browse/OFBIZ-10439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538411#comment-16538411 ] Aman Agrawal commented on OFBIZ-10439: -- Hi [~mbrohl], I ran the steps mentioned above and found that in both cases 5 records are listed. So, can you please share more details on this? > Entity Maintenance / FindGeneric result list misses first data set > -- > > Key: OFBIZ-10439 > URL: https://issues.apache.org/jira/browse/OFBIZ-10439 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Michael Brohl >Priority: Major > > Steps to reproduce on the demo instance for trunk: > # [https://demo-trunk.ofbiz.apache.org/webtools/control/EntitySQLProcessor:] > select * from ORDER_HEADER -> shows 6 rows > # > [https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=OrderHeader=Y] > -> shows 5 rows, the first one with orderId DEMO10090 is missing > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10442) Blank field appears in drop-down where the fields are not pre-populated
[ https://issues.apache.org/jira/browse/OFBIZ-10442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar closed OFBIZ-10442. > Blank field appears in drop-down where the fields are not pre-populated > --- > > Key: OFBIZ-10442 > URL: https://issues.apache.org/jira/browse/OFBIZ-10442 > Project: OFBiz > Issue Type: Bug > Environment: > https://demo-trunk.ofbiz.apache.org/catalog/control/FindSubscription >Reporter: Archana Asthana >Assignee: Arun Patidar >Priority: Major > Attachments: Highlighter.png, PopulatedHighlighter.png > > > Steps to regenerate: > 1. Open https://demo-trunk.ofbiz.apache.org/catalog/control/FindSubscription > 2. On Find Subscription screen, check all the dropdowns one by one. > Actual: > The highlighter in the drop-down is not consistent. > If the fields are prepopulated, they are highlighted in blue. > If the field is not prepopulated the blank field is highlighted in the > drop-down. > Check Subscription Resource ID, Subscription Type, and Automatic Extend > Images are attached for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10442) Blank field appears in drop-down where the fields are not pre-populated
[ https://issues.apache.org/jira/browse/OFBIZ-10442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar reassigned OFBIZ-10442: Assignee: Arun Patidar > Blank field appears in drop-down where the fields are not pre-populated > --- > > Key: OFBIZ-10442 > URL: https://issues.apache.org/jira/browse/OFBIZ-10442 > Project: OFBiz > Issue Type: Bug > Environment: > https://demo-trunk.ofbiz.apache.org/catalog/control/FindSubscription >Reporter: Archana Asthana >Assignee: Arun Patidar >Priority: Major > Attachments: Highlighter.png, PopulatedHighlighter.png > > > Steps to regenerate: > 1. Open https://demo-trunk.ofbiz.apache.org/catalog/control/FindSubscription > 2. On Find Subscription screen, check all the dropdowns one by one. > Actual: > The highlighter in the drop-down is not consistent. > If the fields are prepopulated, they are highlighted in blue. > If the field is not prepopulated the blank field is highlighted in the > drop-down. > Check Subscription Resource ID, Subscription Type, and Automatic Extend > Images are attached for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10442) Blank field appears in drop-down where the fields are not pre-populated
[ https://issues.apache.org/jira/browse/OFBIZ-10442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538404#comment-16538404 ] Aman Agrawal commented on OFBIZ-10442: -- Hi Archana, This is the default behavior of select box. If a value is selected then that value is highlighted otherwise blank or default option is highlighted. So, IMO this is not a valid issue. > Blank field appears in drop-down where the fields are not pre-populated > --- > > Key: OFBIZ-10442 > URL: https://issues.apache.org/jira/browse/OFBIZ-10442 > Project: OFBiz > Issue Type: Bug > Environment: > https://demo-trunk.ofbiz.apache.org/catalog/control/FindSubscription >Reporter: Archana Asthana >Priority: Major > Attachments: Highlighter.png, PopulatedHighlighter.png > > > Steps to regenerate: > 1. Open https://demo-trunk.ofbiz.apache.org/catalog/control/FindSubscription > 2. On Find Subscription screen, check all the dropdowns one by one. > Actual: > The highlighter in the drop-down is not consistent. > If the fields are prepopulated, they are highlighted in blue. > If the field is not prepopulated the blank field is highlighted in the > drop-down. > Check Subscription Resource ID, Subscription Type, and Automatic Extend > Images are attached for reference. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10441) Exception Error renders while removing the Shipment Method
[ https://issues.apache.org/jira/browse/OFBIZ-10441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-10441. - > Exception Error renders while removing the Shipment Method > -- > > Key: OFBIZ-10441 > URL: https://issues.apache.org/jira/browse/OFBIZ-10441 > Project: OFBiz > Issue Type: Bug > Environment: Open > https://demo-trunk.ofbiz.apache.org/catalog/control/deleteShipmentMethodType >Reporter: Archana Asthana >Assignee: Arun Patidar >Priority: Major > Attachments: ShipmentMethodRemovalError.png > > > Steps to Regenerate: > 1. Open > https://demo-trunk.ofbiz.apache.org/catalog/control/deleteShipmentMethodType > 2. Select any Shipment Method Type ID > 3. Click Remove button > Actual: > Exception Error is rendered on the screen. > Image is attached for reference -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OFBIZ-10441) Exception Error renders while removing the Shipment Method
[ https://issues.apache.org/jira/browse/OFBIZ-10441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar resolved OFBIZ-10441. -- Resolution: Not A Problem +1 [~aman.agrawal] This screen is to manage(add/update) the Shipment Method type records. 'Remove' option will useful during business setup. Once a business start we cannot remove. So this is not a valid issue. Closing ticket. > Exception Error renders while removing the Shipment Method > -- > > Key: OFBIZ-10441 > URL: https://issues.apache.org/jira/browse/OFBIZ-10441 > Project: OFBiz > Issue Type: Bug > Environment: Open > https://demo-trunk.ofbiz.apache.org/catalog/control/deleteShipmentMethodType >Reporter: Archana Asthana >Assignee: Arun Patidar >Priority: Major > Attachments: ShipmentMethodRemovalError.png > > > Steps to Regenerate: > 1. Open > https://demo-trunk.ofbiz.apache.org/catalog/control/deleteShipmentMethodType > 2. Select any Shipment Method Type ID > 3. Click Remove button > Actual: > Exception Error is rendered on the screen. > Image is attached for reference -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10441) Exception Error renders while removing the Shipment Method
[ https://issues.apache.org/jira/browse/OFBIZ-10441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar reassigned OFBIZ-10441: Assignee: Arun Patidar > Exception Error renders while removing the Shipment Method > -- > > Key: OFBIZ-10441 > URL: https://issues.apache.org/jira/browse/OFBIZ-10441 > Project: OFBiz > Issue Type: Bug > Environment: Open > https://demo-trunk.ofbiz.apache.org/catalog/control/deleteShipmentMethodType >Reporter: Archana Asthana >Assignee: Arun Patidar >Priority: Major > Attachments: ShipmentMethodRemovalError.png > > > Steps to Regenerate: > 1. Open > https://demo-trunk.ofbiz.apache.org/catalog/control/deleteShipmentMethodType > 2. Select any Shipment Method Type ID > 3. Click Remove button > Actual: > Exception Error is rendered on the screen. > Image is attached for reference -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10441) Exception Error renders while removing the Shipment Method
[ https://issues.apache.org/jira/browse/OFBIZ-10441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538392#comment-16538392 ] Aman Agrawal commented on OFBIZ-10441: -- Hi Archana, This is a type data. After creating a new shipment method type data, it is possible to delete it. But, once you start using the shipment method data, the system doesn't allow us to delete the data. So, IMO this is not a valid issue. > Exception Error renders while removing the Shipment Method > -- > > Key: OFBIZ-10441 > URL: https://issues.apache.org/jira/browse/OFBIZ-10441 > Project: OFBiz > Issue Type: Bug > Environment: Open > https://demo-trunk.ofbiz.apache.org/catalog/control/deleteShipmentMethodType >Reporter: Archana Asthana >Priority: Major > Attachments: ShipmentMethodRemovalError.png > > > Steps to Regenerate: > 1. Open > https://demo-trunk.ofbiz.apache.org/catalog/control/deleteShipmentMethodType > 2. Select any Shipment Method Type ID > 3. Click Remove button > Actual: > Exception Error is rendered on the screen. > Image is attached for reference -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10470) Inconsistent screenlet-title containers
[
https://issues.apache.org/jira/browse/OFBIZ-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538389#comment-16538389
]
Dennis Balkir commented on OFBIZ-10470:
---
Hi Aditya,
I forgot to describe the way to get there sorry.
If you follow the link I provided, then click on continue in the slaes order
screenlet.
After that, just click on order entry again, there should be more screenlets
now.
You will notice that the screenlet title "Create Sales Order" is done with an
{{h3}}, the screenlet titles for all screenlets inside the left container are
done with {{li}} and the other screenlet titles are done with {{div}}.
On the page you linked here this is shown:
{code:html}
screenlet-title-bar:
Screenlet Title
Screenlet Title
| Menu Item
{code}
So there is one missing in it, since there are 3 different kinds if titles in
use around OFBiz.
The main question would be, it at least one of them could be removed and
replaced by another one, or maybe two can be removed and replaced, since this
would create a more equal coding style all over OFBiz
> Inconsistent screenlet-title containers
> ---
>
> Key: OFBIZ-10470
> URL: https://issues.apache.org/jira/browse/OFBIZ-10470
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Dennis Balkir
>Priority: Minor
>
> Through the OFBiz-Backend there is some inconsistency in the use of
> screenlet-titles.
> The title is normally nested inside this:
> {code:html}
>
>
>
> {code}
> But the title itself differs throughout the. backend quite often.
> As far as I have seen, there are 3 main kinds of title:
> # {code:html}
>
>
> Title
> {code}
> # {code:html}
>
>
> Title
> {code}
> # {code:html}
>
>
>
> Title
> {code}
> All three variants can be found right here:
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderentry
> ({{li}} is used in the {{left}}-container, {{h3}} is used for "Create Sales
> Order" and {{div}} is used for the other screenlets)
> Wouldn't it be better to limit this to one kind of container, and maybe style
> the differences (if wanted) through classes?
> Or maybe two containers, which then can be styled differently?
> The way it is now, with most of them looking the same anyway, it seems rather
> confusing than useful
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10470) Inconsistent screenlet-title containers
[
https://issues.apache.org/jira/browse/OFBIZ-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538379#comment-16538379
]
Aditya Sharma commented on OFBIZ-10470:
---
Hi Dennis,
I couldn't get all the 3 variants on orderentry page.
Here is a [link|https://cwiki.apache.org/confluence/x/lQFk] that might help
somewhat.
Maybe I have missed something, but I couldn't find any other link describing
the markup pattern. So if we proceed I suggest also updating it if it doesn't
exist anywhere else. I feel such information might make it quite easy for
someone creating a new theme.
> Inconsistent screenlet-title containers
> ---
>
> Key: OFBIZ-10470
> URL: https://issues.apache.org/jira/browse/OFBIZ-10470
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Dennis Balkir
>Priority: Minor
>
> Through the OFBiz-Backend there is some inconsistency in the use of
> screenlet-titles.
> The title is normally nested inside this:
> {code:html}
>
>
>
> {code}
> But the title itself differs throughout the. backend quite often.
> As far as I have seen, there are 3 main kinds of title:
> # {code:html}
>
>
> Title
> {code}
> # {code:html}
>
>
> Title
> {code}
> # {code:html}
>
>
>
> Title
> {code}
> All three variants can be found right here:
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderentry
> ({{li}} is used in the {{left}}-container, {{h3}} is used for "Create Sales
> Order" and {{div}} is used for the other screenlets)
> Wouldn't it be better to limit this to one kind of container, and maybe style
> the differences (if wanted) through classes?
> Or maybe two containers, which then can be styled differently?
> The way it is now, with most of them looking the same anyway, it seems rather
> confusing than useful
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10331) Improve Order
[ https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538378#comment-16538378 ] Dennis Balkir commented on OFBIZ-10331: --- I noticed another mistake, somehow one closing div container went missing. I uploaded a new patch for OrderEntryTabBar, which is slightly bigger too, since I already formatted it correctly and it shows the change of position for now more indented lines of code. I hope this is still understandable > Improve Order > - > > Key: OFBIZ-10331 > URL: https://issues.apache.org/jira/browse/OFBIZ-10331 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221_common-theme.template.includes.GenericLink.patch, > OFBIZ-10221_order.template.entry.CheckInits.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, > OFBIZ-10221_order.template.entry.OrderAgreements.patch, > OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, > OFBIZ-10221_order.template.entry.OrderShortcuts.patch, > OFBIZ-10221_order.template.entry.cart.ShowCart.patch, > OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, > OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, > OFBIZ-10221_order.template.order.FindOrders.patch, > OFBIZ-10221_order.template.order.OrderList.patch, > OFBIZ-10221_order.template.order.OrderStats.patch, > OFBIZ-10331_order.template.entry.cart.PromoCode.patch, > OFBiz-10221_order.template.order.OrderContactInfo.patch, > OFBiz-10221_order.template.order.OrderInfo.patch, > OFBiz-10221_order.template.order.OrderItems.patch, > OFBiz-10221_order.template.order.OrderPaymentInfo.patch, > OFBiz-10221_order.template.order.OrderShippingInfo.patch, Sélection_156.png > > > All improvements for layout and structure for the Order-Application -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10331) Improve Order
[ https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Balkir updated OFBIZ-10331: -- Attachment: (was: OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch) > Improve Order > - > > Key: OFBIZ-10331 > URL: https://issues.apache.org/jira/browse/OFBIZ-10331 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221_common-theme.template.includes.GenericLink.patch, > OFBIZ-10221_order.template.entry.CheckInits.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, > OFBIZ-10221_order.template.entry.OrderAgreements.patch, > OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, > OFBIZ-10221_order.template.entry.OrderShortcuts.patch, > OFBIZ-10221_order.template.entry.cart.ShowCart.patch, > OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, > OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, > OFBIZ-10221_order.template.order.FindOrders.patch, > OFBIZ-10221_order.template.order.OrderList.patch, > OFBIZ-10221_order.template.order.OrderStats.patch, > OFBIZ-10331_order.template.entry.cart.PromoCode.patch, > OFBiz-10221_order.template.order.OrderContactInfo.patch, > OFBiz-10221_order.template.order.OrderInfo.patch, > OFBiz-10221_order.template.order.OrderItems.patch, > OFBiz-10221_order.template.order.OrderPaymentInfo.patch, > OFBiz-10221_order.template.order.OrderShippingInfo.patch, Sélection_156.png > > > All improvements for layout and structure for the Order-Application -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10331) Improve Order
[ https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Balkir updated OFBIZ-10331: -- Attachment: OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch > Improve Order > - > > Key: OFBIZ-10331 > URL: https://issues.apache.org/jira/browse/OFBIZ-10331 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221_common-theme.template.includes.GenericLink.patch, > OFBIZ-10221_order.template.entry.CheckInits.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, > OFBIZ-10221_order.template.entry.OrderAgreements.patch, > OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, > OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, > OFBIZ-10221_order.template.entry.OrderShortcuts.patch, > OFBIZ-10221_order.template.entry.cart.ShowCart.patch, > OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, > OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, > OFBIZ-10221_order.template.order.FindOrders.patch, > OFBIZ-10221_order.template.order.OrderList.patch, > OFBIZ-10221_order.template.order.OrderStats.patch, > OFBIZ-10331_order.template.entry.cart.PromoCode.patch, > OFBiz-10221_order.template.order.OrderContactInfo.patch, > OFBiz-10221_order.template.order.OrderInfo.patch, > OFBiz-10221_order.template.order.OrderItems.patch, > OFBiz-10221_order.template.order.OrderPaymentInfo.patch, > OFBiz-10221_order.template.order.OrderShippingInfo.patch, Sélection_156.png > > > All improvements for layout and structure for the Order-Application -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10331) Improve Order
[ https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Balkir updated OFBIZ-10331: -- Attachment: OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch > Improve Order > - > > Key: OFBIZ-10331 > URL: https://issues.apache.org/jira/browse/OFBIZ-10331 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221_common-theme.template.includes.GenericLink.patch, > OFBIZ-10221_order.template.entry.CheckInits.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, > OFBIZ-10221_order.template.entry.OrderAgreements.patch, > OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, > OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, > OFBIZ-10221_order.template.entry.OrderShortcuts.patch, > OFBIZ-10221_order.template.entry.cart.ShowCart.patch, > OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, > OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, > OFBIZ-10221_order.template.order.FindOrders.patch, > OFBIZ-10221_order.template.order.OrderList.patch, > OFBIZ-10221_order.template.order.OrderStats.patch, > OFBIZ-10331_order.template.entry.cart.PromoCode.patch, > OFBiz-10221_order.template.order.OrderContactInfo.patch, > OFBiz-10221_order.template.order.OrderInfo.patch, > OFBiz-10221_order.template.order.OrderItems.patch, > OFBiz-10221_order.template.order.OrderPaymentInfo.patch, > OFBiz-10221_order.template.order.OrderShippingInfo.patch, Sélection_156.png > > > All improvements for layout and structure for the Order-Application -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10331) Improve Order
[ https://issues.apache.org/jira/browse/OFBIZ-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Balkir updated OFBIZ-10331: -- Attachment: (was: OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch) > Improve Order > - > > Key: OFBIZ-10331 > URL: https://issues.apache.org/jira/browse/OFBIZ-10331 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, > OFBIZ-10221_common-theme.template.includes.GenericLink.patch, > OFBIZ-10221_order.template.entry.CheckInits.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog.patch, > OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, > OFBIZ-10221_order.template.entry.OrderAgreements.patch, > OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, > OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, > OFBIZ-10221_order.template.entry.OrderShortcuts.patch, > OFBIZ-10221_order.template.entry.cart.ShowCart.patch, > OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, > OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, > OFBIZ-10221_order.template.order.FindOrders.patch, > OFBIZ-10221_order.template.order.OrderList.patch, > OFBIZ-10221_order.template.order.OrderStats.patch, > OFBIZ-10331_order.template.entry.cart.PromoCode.patch, > OFBiz-10221_order.template.order.OrderContactInfo.patch, > OFBiz-10221_order.template.order.OrderInfo.patch, > OFBiz-10221_order.template.order.OrderItems.patch, > OFBiz-10221_order.template.order.OrderPaymentInfo.patch, > OFBiz-10221_order.template.order.OrderShippingInfo.patch, Sélection_156.png > > > All improvements for layout and structure for the Order-Application -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10467) Using "buttontext" styling for the index of service engine
[ https://issues.apache.org/jira/browse/OFBIZ-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538325#comment-16538325 ] Pierre Smits commented on OFBIZ-10467: -- HI [~aditya.sharma], Indeed theme specific adjustments can be implemented on a by case basis, and warrant separate ticket(s). > Using "buttontext" styling for the index of service engine > -- > > Key: OFBIZ-10467 > URL: https://issues.apache.org/jira/browse/OFBIZ-10467 > Project: OFBiz > Issue Type: Improvement > Components: framework/webtools >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Aditya Sharma >Priority: Minor > Attachments: buttons1.png, buttons2.png, buttons3.png, buttons4.png, > image-2018-07-09-16-13-01-707.png, service-engine_buttons.patch > > > To give OFBiz a more equal look, the style "buttontext" can be added for the > alphabetical index of the service engine main page. > This makes the buttons look alike with the ones that are already there for > the entity engine main page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10467) Using "buttontext" styling for the index of service engine
[ https://issues.apache.org/jira/browse/OFBIZ-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538322#comment-16538322 ] Dennis Balkir commented on OFBIZ-10467: --- That seems like a good idea with minimal effort and it should fix it for every theme. +1 from me > Using "buttontext" styling for the index of service engine > -- > > Key: OFBIZ-10467 > URL: https://issues.apache.org/jira/browse/OFBIZ-10467 > Project: OFBiz > Issue Type: Improvement > Components: framework/webtools >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Aditya Sharma >Priority: Minor > Attachments: buttons1.png, buttons2.png, buttons3.png, buttons4.png, > image-2018-07-09-16-13-01-707.png, service-engine_buttons.patch > > > To give OFBiz a more equal look, the style "buttontext" can be added for the > alphabetical index of the service engine main page. > This makes the buttons look alike with the ones that are already there for > the entity engine main page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10467) Using "buttontext" styling for the index of service engine
[
https://issues.apache.org/jira/browse/OFBIZ-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538318#comment-16538318
]
Aditya Sharma edited comment on OFBIZ-10467 at 7/10/18 9:38 AM:
Thanks [~pfm.smits] I do found those discussions on OFBIZ-8293 and
[https://markmail.org/message/vtauqtjbq7juojav].
Though, I feel instead of leaving the wrong behaviour in the Tomahawk theme
which is still in use & may be used by the users on demo instances. I suggest
to apply your patch and override the upper case styling with a more specific
rule in Tomahawk theme to minimize the impact.
We can add a new rule for Tomahawk
{code:java}
.button-bar > a.buttontext {
text-transform:none!important;
}{code}
WDYT?
was (Author: aditya.sharma):
Thanks [~pfm.smits] I do found those discussions on OFBIZ-8293 and
[https://markmail.org/message/vtauqtjbq7juojav|[https://markmail.org/message/vtauqtjbq7juojav].]
Though, I feel instead of leaving the wrong behaviour in the Tomahawk theme
which is still in use & may be used by the users on demo instances. I suggest
to apply your patch and override the upper case styling with a more specific
rule in Tomahawk theme to minimize the impact.
We can add a new rule for Tomahawk
{code:java}
.button-bar > a.buttontext {
text-transform:none!important;
}{code}
WDYT?
> Using "buttontext" styling for the index of service engine
> --
>
> Key: OFBIZ-10467
> URL: https://issues.apache.org/jira/browse/OFBIZ-10467
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Aditya Sharma
>Priority: Minor
> Attachments: buttons1.png, buttons2.png, buttons3.png, buttons4.png,
> image-2018-07-09-16-13-01-707.png, service-engine_buttons.patch
>
>
> To give OFBiz a more equal look, the style "buttontext" can be added for the
> alphabetical index of the service engine main page.
> This makes the buttons look alike with the ones that are already there for
> the entity engine main page.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10093) Replace ELRTE plugin with TinyMCE.
[ https://issues.apache.org/jira/browse/OFBIZ-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538316#comment-16538316 ] Pierre Smits commented on OFBIZ-10093: -- This ticket should not be a sub-task of OFBIZ-9978, as the upgrade has been completed and now can't be closed of this. It is better to make this an improvement ticket and link it to OFBIZ-9978 (if needed). > Replace ELRTE plugin with TinyMCE. > -- > > Key: OFBIZ-10093 > URL: https://issues.apache.org/jira/browse/OFBIZ-10093 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Major > > As there is no support for elrte since elrte-1.3 > https://github.com/Studio-42/elRTE it is to be replaced with some other good > editor like TinyMCE: > * 171 releases (latest 14 days ago) > * Good community support of 171 contributors > * Licence - GNU LESSER GENERAL PUBLIC LICENSE Version 2.1, February 1999 > Links for reference: > https://github.com/tinymce/tinymce. > https://www.tinymce.com/download/ > https://www.tinymce.com/docs/configure/localization/ > https://www.tinymce.com/download/language-packages/ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538300#comment-16538300 ] Pierre Smits commented on OFBIZ-10145: -- I like this solution. It will minimize manual actions. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Major > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper.sh > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10464) Improve Accounting -AP
[
https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538295#comment-16538295
]
Dennis Balkir commented on OFBIZ-10464:
---
Hi [~pfm.smits],
that's right, but I made the changes while looking at the other main pages from
other applications, from which none seem to use this portal page logic.
Most of the times, the main screens just include .ftl files, but for example
humanres' main page includes the screen to show just like I did:
{code:xml}
{code}
This was the reason I changed the pages like I did.
> Improve Accounting -AP
> --
>
> Key: OFBIZ-10464
> URL: https://issues.apache.org/jira/browse/OFBIZ-10464
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: accounting-ap_main-page.patch
>
>
> I found some structural differences while looking on accounting-ap -> main.
> While all the other screenlets on such pages are nested inside the
> surrounding div-containers, these ones are actually inside a table, which
> then is inside the normally surrounding divs.
>
> This makes styling for new themes difficult and should be changed, since it
> is an exception in the normally used structure.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10467) Using "buttontext" styling for the index of service engine
[ https://issues.apache.org/jira/browse/OFBIZ-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538271#comment-16538271 ] Dennis Balkir commented on OFBIZ-10467: --- If this is the case, then maybe we should just go with the changes from the patch, since they work fine in all other themes than Tomahawk > Using "buttontext" styling for the index of service engine > -- > > Key: OFBIZ-10467 > URL: https://issues.apache.org/jira/browse/OFBIZ-10467 > Project: OFBiz > Issue Type: Improvement > Components: framework/webtools >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Aditya Sharma >Priority: Minor > Attachments: buttons1.png, buttons2.png, buttons3.png, buttons4.png, > image-2018-07-09-16-13-01-707.png, service-engine_buttons.patch > > > To give OFBiz a more equal look, the style "buttontext" can be added for the > alphabetical index of the service engine main page. > This makes the buttons look alike with the ones that are already there for > the entity engine main page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10467) Using "buttontext" styling for the index of service engine
[ https://issues.apache.org/jira/browse/OFBIZ-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538253#comment-16538253 ] Pierre Smits commented on OFBIZ-10467: -- I surmise a style guide would help. But did we not decide in recent past to favour a different theme than Tomahawk? If so, then like all the other theme, Tomahawk style fixes should be of lesser importance. > Using "buttontext" styling for the index of service engine > -- > > Key: OFBIZ-10467 > URL: https://issues.apache.org/jira/browse/OFBIZ-10467 > Project: OFBiz > Issue Type: Improvement > Components: framework/webtools >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Aditya Sharma >Priority: Minor > Attachments: buttons1.png, buttons2.png, buttons3.png, buttons4.png, > image-2018-07-09-16-13-01-707.png, service-engine_buttons.patch > > > To give OFBiz a more equal look, the style "buttontext" can be added for the > alphabetical index of the service engine main page. > This makes the buttons look alike with the ones that are already there for > the entity engine main page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10464) Improve Accounting -AP
[ https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538221#comment-16538221 ] Pierre Smits commented on OFBIZ-10464: -- Hi [~Dennis Balkir], It seems that the problem lies in how portal pages are handled by the rendering engine. Would it not be better to fix that, instead of removing that functionality and replacing it with hard-coded screen definitions? > Improve Accounting -AP > -- > > Key: OFBIZ-10464 > URL: https://issues.apache.org/jira/browse/OFBIZ-10464 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: accounting-ap_main-page.patch > > > I found some structural differences while looking on accounting-ap -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
