[jira] [Commented] (OFBIZ-9978) Upgrade jQuery 1.11.0 to jQuery 3.2.1

2019-01-10 Thread Aditya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740127#comment-16740127
 ] 

Aditya Sharma commented on OFBIZ-9978:
--

Removed unused jQuery MockJax Plugin.

Thanks Michael Brohl and Jacques Le Roux for the 
[discussion|https://markmail.org/message/2pdf2qrtko3xrxke] on dev mailing list.

Done for trunk at r1851013 and R18.12 at r1851014

> Upgrade jQuery 1.11.0 to jQuery 3.2.1
> -
>
> Key: OFBIZ-9978
> URL: https://issues.apache.org/jira/browse/OFBIZ-9978
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Image 001.png, Image 002.png, Image 003.png, Image 
> 007.png, OFBIZ-9978.patch, OFBIZ-9978.patch, OFBIZ-9978.patch, 
> OFBIZ-9978.patch, OFBIZ-9978.patch, OFBIZ-9978.patch, 
> OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, 
> OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, 
> OFBIZ-9978_plugins.patch, OFBIZ-9978_pluginswithReadmore2.2.0.patch, 
> OFBIZ-9978withReadmore2.2.0.patch, Readmore.tar.gz, Screenshot-2017-11-26 
> OFBiz Example .png, images.tar.gz, jquery-jgrowl.tar.gz
>
>
> Migration Steps:
> 1. Upgrade JQuery 1.11.0 to 3.2.1
>   * Remove JQuery 1.x & JQuery migrate 1.x
>   * Add JQuery 3.2.1 & JQuery migrate 3.0.0
>   * Rectify any broken code and plugin
> 2. Upgrade all the JQuery plugins to latest
> 3. Remove JQuery migrate 3.0.0 & rectify any broken code



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework

2019-01-10 Thread Gil Portenseigne (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740107#comment-16740107
 ] 

Gil Portenseigne commented on OFBIZ-10607:
--

Since it is an improvement and not a bugfix, no need to backport it IMO. But if 
done, it is not problematic :)

> ‘EntityOperator#getId()’ is not used in the framework
> -
>
> Key: OFBIZ-10607
> URL: https://issues.apache.org/jira/browse/OFBIZ-10607
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch
>
>
> While reading some code with [~gil portenseigne] we found that 
> ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added 
> in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of 
> additional operators for extensions.”.
> If this code is still useful outside of the framework, OFBiz should provide a 
> test demonstrated its purpose and describing how to use it. Otherwise we 
> should simply delete it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework

2019-01-10 Thread Mathieu Lirzin (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740099#comment-16740099
 ] 

Mathieu Lirzin commented on OFBIZ-10607:


Thanks Michael for reviewing and applying this patch,

Can you explain the issue with the patch I submitted? did it fail to apply with 
the metadata?  I am using {{git format-patch --no-prefix}} to generate my 
patches which is a common practice in a lot of Free Software communities (Linux 
Kernel/most GNU packages). I am willing to adapt the format of my patches. I 
just want to understand what is the issue you are facing which is not obvious 
for me.

> ‘EntityOperator#getId()’ is not used in the framework
> -
>
> Key: OFBIZ-10607
> URL: https://issues.apache.org/jira/browse/OFBIZ-10607
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch
>
>
> While reading some code with [~gil portenseigne] we found that 
> ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added 
> in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of 
> additional operators for extensions.”.
> If this code is still useful outside of the framework, OFBiz should provide a 
> test demonstrated its purpose and describing how to use it. Otherwise we 
> should simply delete it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10118) Update multifex theme as per new markup

2019-01-10 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740084#comment-16740084
 ] 

Deepak Dixit commented on OFBIZ-10118:
--

Thanks Ayushi, Parakh and Nitish for your contribution.

This has bee done at 
ofbiz plaugins trunk at r#1851009
R18.12 plugisn at r#1851010

Keeping this task open as we need backport this to 17.12 as well. 

> Update multifex theme as per new markup
> ---
>
> Key: OFBIZ-10118
> URL: https://issues.apache.org/jira/browse/OFBIZ-10118
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Reporter: Deepak Dixit
>Assignee: Parakh Maheshwari
>Priority: Major
> Attachments: OFBIZ-10118_Body.patch, OFBIZ-10118_Footer.patch, 
> OFBIZ-10118_HEADER.patch
>
>
> As we are updating UX of ecommerce site, this breaks the multifex them of 
> ecommerce.
> Need to update css rule of multiflex theme as per new markup. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10500) Tax calculation incorrect when creating orders

2019-01-10 Thread Ankush Upadhyay (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Upadhyay updated OFBIZ-10500:

Attachment: Stores.png

> Tax calculation incorrect when creating orders
> --
>
> Key: OFBIZ-10500
> URL: https://issues.apache.org/jira/browse/OFBIZ-10500
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 16.11
> Environment: OpenJDK 1.8.0_151 64bit on Ubuntu 16.04
>Reporter: Frank Herrman
>Assignee: Ankush Upadhyay
>Priority: Major
> Attachments: Invoice.png, Schermafbeelding 2018-07-30 om 
> 10.15.51.png, Schermafbeelding 2018-07-30 om 10.16.16.png, Stores.png, VAT.png
>
>
> After a 
> [discussion|https://lists.apache.org/thread.html/adf568edad92255340697f78ea4f34a07e328cc1689b8fb73e16fa53@%3Cuser.ofbiz.apache.org%3E]
>  on the user mailinglist we concluded there seems to be an issue with the tax 
> calculations.
> *Steps to reproduce*
>  * Create a tax authority for a specific country (e.g. The Netherlands in my 
> case)
>  * Set sales tax rate of 21% for your store with this Tax Authority
>  * Create a product and enter a price either including or excluding taxes and 
> set the corresponding flag for tax included y/n.
>  * Go to the order manager and order entry. Fill in the details, select the 
> product and go to the review page. It now shows the incorrect sales tax and 
> price.
> Let's say we have a product of 20 euro incl. taxes. With 21% that comes down 
> to 3.47 euro of taxes and a price of 16.53 euro. Instead Ofbiz shows a price 
> of 20 euro excl. taxes and adds 4.20 euros in taxes.
> *What I tried*
> Changing the price to price excl. VAT and set the flag to 'N' and visa versa. 
> Both gave the same error. 
> *Possible solution*
> I digged into the code and ended up in the file:
> {{ applications/order/groovyScripts/entry/OrderReadHelper.java}}
> The function in line 2401
> {code:java}
> public static BigDecimal getOrderItemSubTotal(GenericValue orderItem, 
> List adjustments, boolean forTax, boolean forShipping){code}
> returns the price of one item there. It uses this piece of code:
> {code:java}
> orderItem.getBigDecimal("unitPrice");{code}
> The line item is always the price including taxes. When I adjust this price 
> (by dividing it by 1.21) I do get the correct price in the review page. I do 
> not, however, get the right tax amount. This is calculated elsewhere and 
> still using the 20 euro price I guess. Anyway, it does show I was in the 
> right spot.
> I'm not familiar enough with Ofbiz to create a full patch, but I think the 
> easiest way to go is to add another column to order items where the value 
> excl. taxes is stored which can be used in places where needed. This does not 
> affect the whole system. On the other hand I'm not sure where the order items 
> are stored, since when you are on the review page it is not stored in 
> database yet. Probably just in the session? Should make things even easier.
> The attachments show an example. I have stored a product of 20 euro 
> (screenshot directly taken from the database tool) and I have set-up a tax 
> exempt in this case for a customer which shows 4.20 euro sales tax. If I turn 
> off the tax exempt the grand total becomes 24.20 euros, so it is not related 
> to the exempt.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10782) Replace jQuery-Timepicker-Addon with flatpickr.js

2019-01-10 Thread Aditya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740069#comment-16740069
 ] 

Aditya Sharma commented on OFBIZ-10782:
---

Thanks Jacques :-)

I will start after OFBIZ-9848.

> Replace jQuery-Timepicker-Addon with flatpickr.js
> -
>
> Key: OFBIZ-10782
> URL: https://issues.apache.org/jira/browse/OFBIZ-10782
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk, Release Branch 18.12
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
>
> [jQuery-Timepicker-Addon|https://github.com/trentrichardson/jQuery-Timepicker-Addon]
>  seems to be a dead end now. Refer 
> [#955|https://github.com/trentrichardson/jQuery-Timepicker-Addon/issues/955]
> As suggested in  
> [#955|https://github.com/trentrichardson/jQuery-Timepicker-Addon/issues/955].
> [Flatpickr|https://github.com/flatpickr/flatpickr] seems a better 
> proposition. MIT license with a community of 158 contributors and 123 
> releases. A lightweight, powerful javascript datetimepicker with no 
> dependencies.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10500) Tax calculation incorrect when creating orders

2019-01-10 Thread Ankush Upadhyay (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Upadhyay updated OFBIZ-10500:

Attachment: OrderReview.png

> Tax calculation incorrect when creating orders
> --
>
> Key: OFBIZ-10500
> URL: https://issues.apache.org/jira/browse/OFBIZ-10500
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 16.11
> Environment: OpenJDK 1.8.0_151 64bit on Ubuntu 16.04
>Reporter: Frank Herrman
>Assignee: Ankush Upadhyay
>Priority: Major
> Attachments: Invoice.png, OrderReview.png, Schermafbeelding 
> 2018-07-30 om 10.15.51.png, Schermafbeelding 2018-07-30 om 10.16.16.png, 
> Shipping.png, Stores.png, VAT.png
>
>
> After a 
> [discussion|https://lists.apache.org/thread.html/adf568edad92255340697f78ea4f34a07e328cc1689b8fb73e16fa53@%3Cuser.ofbiz.apache.org%3E]
>  on the user mailinglist we concluded there seems to be an issue with the tax 
> calculations.
> *Steps to reproduce*
>  * Create a tax authority for a specific country (e.g. The Netherlands in my 
> case)
>  * Set sales tax rate of 21% for your store with this Tax Authority
>  * Create a product and enter a price either including or excluding taxes and 
> set the corresponding flag for tax included y/n.
>  * Go to the order manager and order entry. Fill in the details, select the 
> product and go to the review page. It now shows the incorrect sales tax and 
> price.
> Let's say we have a product of 20 euro incl. taxes. With 21% that comes down 
> to 3.47 euro of taxes and a price of 16.53 euro. Instead Ofbiz shows a price 
> of 20 euro excl. taxes and adds 4.20 euros in taxes.
> *What I tried*
> Changing the price to price excl. VAT and set the flag to 'N' and visa versa. 
> Both gave the same error. 
> *Possible solution*
> I digged into the code and ended up in the file:
> {{ applications/order/groovyScripts/entry/OrderReadHelper.java}}
> The function in line 2401
> {code:java}
> public static BigDecimal getOrderItemSubTotal(GenericValue orderItem, 
> List adjustments, boolean forTax, boolean forShipping){code}
> returns the price of one item there. It uses this piece of code:
> {code:java}
> orderItem.getBigDecimal("unitPrice");{code}
> The line item is always the price including taxes. When I adjust this price 
> (by dividing it by 1.21) I do get the correct price in the review page. I do 
> not, however, get the right tax amount. This is calculated elsewhere and 
> still using the 20 euro price I guess. Anyway, it does show I was in the 
> right spot.
> I'm not familiar enough with Ofbiz to create a full patch, but I think the 
> easiest way to go is to add another column to order items where the value 
> excl. taxes is stored which can be used in places where needed. This does not 
> affect the whole system. On the other hand I'm not sure where the order items 
> are stored, since when you are on the review page it is not stored in 
> database yet. Probably just in the session? Should make things even easier.
> The attachments show an example. I have stored a product of 20 euro 
> (screenshot directly taken from the database tool) and I have set-up a tax 
> exempt in this case for a customer which shows 4.20 euro sales tax. If I turn 
> off the tax exempt the grand total becomes 24.20 euros, so it is not related 
> to the exempt.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10500) Tax calculation incorrect when creating orders

2019-01-10 Thread Ankush Upadhyay (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Upadhyay updated OFBIZ-10500:

Attachment: Shipping.png

> Tax calculation incorrect when creating orders
> --
>
> Key: OFBIZ-10500
> URL: https://issues.apache.org/jira/browse/OFBIZ-10500
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 16.11
> Environment: OpenJDK 1.8.0_151 64bit on Ubuntu 16.04
>Reporter: Frank Herrman
>Assignee: Ankush Upadhyay
>Priority: Major
> Attachments: Invoice.png, OrderReview.png, Schermafbeelding 
> 2018-07-30 om 10.15.51.png, Schermafbeelding 2018-07-30 om 10.16.16.png, 
> Shipping.png, Stores.png, VAT.png
>
>
> After a 
> [discussion|https://lists.apache.org/thread.html/adf568edad92255340697f78ea4f34a07e328cc1689b8fb73e16fa53@%3Cuser.ofbiz.apache.org%3E]
>  on the user mailinglist we concluded there seems to be an issue with the tax 
> calculations.
> *Steps to reproduce*
>  * Create a tax authority for a specific country (e.g. The Netherlands in my 
> case)
>  * Set sales tax rate of 21% for your store with this Tax Authority
>  * Create a product and enter a price either including or excluding taxes and 
> set the corresponding flag for tax included y/n.
>  * Go to the order manager and order entry. Fill in the details, select the 
> product and go to the review page. It now shows the incorrect sales tax and 
> price.
> Let's say we have a product of 20 euro incl. taxes. With 21% that comes down 
> to 3.47 euro of taxes and a price of 16.53 euro. Instead Ofbiz shows a price 
> of 20 euro excl. taxes and adds 4.20 euros in taxes.
> *What I tried*
> Changing the price to price excl. VAT and set the flag to 'N' and visa versa. 
> Both gave the same error. 
> *Possible solution*
> I digged into the code and ended up in the file:
> {{ applications/order/groovyScripts/entry/OrderReadHelper.java}}
> The function in line 2401
> {code:java}
> public static BigDecimal getOrderItemSubTotal(GenericValue orderItem, 
> List adjustments, boolean forTax, boolean forShipping){code}
> returns the price of one item there. It uses this piece of code:
> {code:java}
> orderItem.getBigDecimal("unitPrice");{code}
> The line item is always the price including taxes. When I adjust this price 
> (by dividing it by 1.21) I do get the correct price in the review page. I do 
> not, however, get the right tax amount. This is calculated elsewhere and 
> still using the 20 euro price I guess. Anyway, it does show I was in the 
> right spot.
> I'm not familiar enough with Ofbiz to create a full patch, but I think the 
> easiest way to go is to add another column to order items where the value 
> excl. taxes is stored which can be used in places where needed. This does not 
> affect the whole system. On the other hand I'm not sure where the order items 
> are stored, since when you are on the review page it is not stored in 
> database yet. Probably just in the session? Should make things even easier.
> The attachments show an example. I have stored a product of 20 euro 
> (screenshot directly taken from the database tool) and I have set-up a tax 
> exempt in this case for a customer which shows 4.20 euro sales tax. If I turn 
> off the tax exempt the grand total becomes 24.20 euros, so it is not related 
> to the exempt.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10500) Tax calculation incorrect when creating orders

2019-01-10 Thread Ankush Upadhyay (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740072#comment-16740072
 ] 

Ankush Upadhyay commented on OFBIZ-10500:
-

[~FrankH],

Sorry for late reply.

I also did check with turned on the show prices including tax option in store 
setting but still getting same result I posted in my previous comment.

Here are the steps with attached screenshots:
 # Load data I posted in my previous comment.
 #  From Stores, turned on the *Show prices with VAT tax included* flag 
including Vat Tax Auth Geo ID and Vat Tax Auth Party ID.
 # Now place order for demo customer and selected currency as EUR and shipping 
address as *Surinamestraat 27, 2585 GJ Den Haag, Netherlands*

After these steps still I can see expected results that attached in previous 
screenshot.

 

Please reviewed attached screenshots and let me know If I am missing something.

> Tax calculation incorrect when creating orders
> --
>
> Key: OFBIZ-10500
> URL: https://issues.apache.org/jira/browse/OFBIZ-10500
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 16.11
> Environment: OpenJDK 1.8.0_151 64bit on Ubuntu 16.04
>Reporter: Frank Herrman
>Assignee: Ankush Upadhyay
>Priority: Major
> Attachments: Invoice.png, Schermafbeelding 2018-07-30 om 
> 10.15.51.png, Schermafbeelding 2018-07-30 om 10.16.16.png, VAT.png
>
>
> After a 
> [discussion|https://lists.apache.org/thread.html/adf568edad92255340697f78ea4f34a07e328cc1689b8fb73e16fa53@%3Cuser.ofbiz.apache.org%3E]
>  on the user mailinglist we concluded there seems to be an issue with the tax 
> calculations.
> *Steps to reproduce*
>  * Create a tax authority for a specific country (e.g. The Netherlands in my 
> case)
>  * Set sales tax rate of 21% for your store with this Tax Authority
>  * Create a product and enter a price either including or excluding taxes and 
> set the corresponding flag for tax included y/n.
>  * Go to the order manager and order entry. Fill in the details, select the 
> product and go to the review page. It now shows the incorrect sales tax and 
> price.
> Let's say we have a product of 20 euro incl. taxes. With 21% that comes down 
> to 3.47 euro of taxes and a price of 16.53 euro. Instead Ofbiz shows a price 
> of 20 euro excl. taxes and adds 4.20 euros in taxes.
> *What I tried*
> Changing the price to price excl. VAT and set the flag to 'N' and visa versa. 
> Both gave the same error. 
> *Possible solution*
> I digged into the code and ended up in the file:
> {{ applications/order/groovyScripts/entry/OrderReadHelper.java}}
> The function in line 2401
> {code:java}
> public static BigDecimal getOrderItemSubTotal(GenericValue orderItem, 
> List adjustments, boolean forTax, boolean forShipping){code}
> returns the price of one item there. It uses this piece of code:
> {code:java}
> orderItem.getBigDecimal("unitPrice");{code}
> The line item is always the price including taxes. When I adjust this price 
> (by dividing it by 1.21) I do get the correct price in the review page. I do 
> not, however, get the right tax amount. This is calculated elsewhere and 
> still using the 20 euro price I guess. Anyway, it does show I was in the 
> right spot.
> I'm not familiar enough with Ofbiz to create a full patch, but I think the 
> easiest way to go is to add another column to order items where the value 
> excl. taxes is stored which can be used in places where needed. This does not 
> affect the whole system. On the other hand I'm not sure where the order items 
> are stored, since when you are on the review page it is not stored in 
> database yet. Probably just in the session? Should make things even easier.
> The attachments show an example. I have stored a product of 20 euro 
> (screenshot directly taken from the database tool) and I have set-up a tax 
> exempt in this case for a customer which shows 4.20 euro sales tax. If I turn 
> off the tax exempt the grand total becomes 24.20 euros, so it is not related 
> to the exempt.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10787) Page dropdown list on categorydetail page broken

2019-01-10 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-10787.

   Resolution: Fixed
Fix Version/s: 16.11.06

> Page dropdown list on categorydetail page broken
> 
>
> Key: OFBIZ-10787
> URL: https://issues.apache.org/jira/browse/OFBIZ-10787
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Sebastian Wachinger
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: 16.11.06
>
>
> The page dropdown list on the {{categorydetail}} page is not populated and 
> only offers to select the current page:
> [stable demo|https://demo-stable.ofbiz.apache.org/ecommerce/gismos-100-c] / 
> [trunk 
> demo|https://demo-trunk.ofbiz.apache.org/ecomseo/category/gismos-100.html]
> Affected are pages 1 and 2, it actually works perfectly from page 3 upwards 
> (in my local installation).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10787) Page dropdown list on categorydetail page broken

2019-01-10 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740070#comment-16740070
 ] 

Deepak Dixit commented on OFBIZ-10787:
--

Thanks Sebastian Wachinger for reporting the issue.

This has been fixed at
ofbiz plugins trunk at r#1851002
R18.12 plugins trunk at r#1851004
R17.12 plugins trunk at r#1851003
R16.11 at r#1851005
This issue exists for ordermgr/CategoryDetail.ftl as well, this has been fixed 
at
ofbiz framework trunk at r#1851006
R18.12 framework trunk at r#1851007
R18.12 framework trunk at r#1851008
 

> Page dropdown list on categorydetail page broken
> 
>
> Key: OFBIZ-10787
> URL: https://issues.apache.org/jira/browse/OFBIZ-10787
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Sebastian Wachinger
>Assignee: Deepak Dixit
>Priority: Minor
>
> The page dropdown list on the {{categorydetail}} page is not populated and 
> only offers to select the current page:
> [stable demo|https://demo-stable.ofbiz.apache.org/ecommerce/gismos-100-c] / 
> [trunk 
> demo|https://demo-trunk.ofbiz.apache.org/ecomseo/category/gismos-100.html]
> Affected are pages 1 and 2, it actually works perfectly from page 3 upwards 
> (in my local installation).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9848) Replace Inline js with External js in renderDateTimeField macro

2019-01-10 Thread Aditya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740068#comment-16740068
 ] 

Aditya Sharma commented on OFBIZ-9848:
--

Attached a patch. I will commit asap.

> Replace Inline js with External js in renderDateTimeField macro
> ---
>
> Key: OFBIZ-9848
> URL: https://issues.apache.org/jira/browse/OFBIZ-9848
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
> Attachments: OFBIZ-9848.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10787) Page dropdown list on categorydetail page broken

2019-01-10 Thread Deepak Dixit (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reassigned OFBIZ-10787:


Assignee: Deepak Dixit

> Page dropdown list on categorydetail page broken
> 
>
> Key: OFBIZ-10787
> URL: https://issues.apache.org/jira/browse/OFBIZ-10787
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Sebastian Wachinger
>Assignee: Deepak Dixit
>Priority: Minor
>
> The page dropdown list on the {{categorydetail}} page is not populated and 
> only offers to select the current page:
> [stable demo|https://demo-stable.ofbiz.apache.org/ecommerce/gismos-100-c] / 
> [trunk 
> demo|https://demo-trunk.ofbiz.apache.org/ecomseo/category/gismos-100.html]
> Affected are pages 1 and 2, it actually works perfectly from page 3 upwards 
> (in my local installation).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9848) Replace Inline js with External js in renderDateTimeField macro

2019-01-10 Thread Aditya Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-9848:
-
Attachment: OFBIZ-9848.patch

> Replace Inline js with External js in renderDateTimeField macro
> ---
>
> Key: OFBIZ-9848
> URL: https://issues.apache.org/jira/browse/OFBIZ-9848
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
> Attachments: OFBIZ-9848.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9848) Replace Inline js with External js in renderDateTimeField macro

2019-01-10 Thread Aditya Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma reassigned OFBIZ-9848:


Assignee: Aditya Sharma  (was: Aishwary Shrivastava)

> Replace Inline js with External js in renderDateTimeField macro
> ---
>
> Key: OFBIZ-9848
> URL: https://issues.apache.org/jira/browse/OFBIZ-9848
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10787) Page dropdown list on categorydetail page broken

2019-01-10 Thread Sebastian Wachinger (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebastian Wachinger updated OFBIZ-10787:

Description: 
The page dropdown list on the {{categorydetail}} page is not populated and only 
offers to select the current page:
[stable demo|https://demo-stable.ofbiz.apache.org/ecommerce/gismos-100-c] / 
[trunk 
demo|https://demo-trunk.ofbiz.apache.org/ecomseo/category/gismos-100.html]
Affected are pages 1 and 2, it actually works perfectly from page 3 upwards (in 
my local installation).

  was:
The page dropdown list on the {{categorydetail}} page is not populated and only 
offers to select the current page:
[stable demo|https://demo-stable.ofbiz.apache.org/ecommerce/gismos-100-c] / 
[trunk 
demo|https://demo-trunk.ofbiz.apache.org/ecomseo/category/gismos-100.html]
Affected are pages 1 and 2, it actually works perfectly from page 3 upwards (in 
my local installation), but then still there are no entries for pages 1 and 2 
in the dropdown list.


> Page dropdown list on categorydetail page broken
> 
>
> Key: OFBIZ-10787
> URL: https://issues.apache.org/jira/browse/OFBIZ-10787
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Sebastian Wachinger
>Priority: Minor
>
> The page dropdown list on the {{categorydetail}} page is not populated and 
> only offers to select the current page:
> [stable demo|https://demo-stable.ofbiz.apache.org/ecommerce/gismos-100-c] / 
> [trunk 
> demo|https://demo-trunk.ofbiz.apache.org/ecomseo/category/gismos-100.html]
> Affected are pages 1 and 2, it actually works perfectly from page 3 upwards 
> (in my local installation).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10787) Page dropdown list on categorydetail page broken

2019-01-10 Thread Sebastian Wachinger (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebastian Wachinger updated OFBIZ-10787:

Description: 
The page dropdown list on the {{categorydetail}} page is not populated and only 
offers to select the current page:
[stable demo|https://demo-stable.ofbiz.apache.org/ecommerce/gismos-100-c] / 
[trunk 
demo|https://demo-trunk.ofbiz.apache.org/ecomseo/category/gismos-100.html]
Affected are pages 1 and 2, it actually works perfectly from page 3 upwards (in 
my local installation), but then still there are no entries for pages 1 and 2 
in the dropdown list.

  was:
The page dropdown list on the {{categorydetail}} page is not populated and only 
offers to select the current page:
[stable demo|https://demo-stable.ofbiz.apache.org/ecommerce/gismos-100-c] / 
[trunk 
demo|https://demo-trunk.ofbiz.apache.org/ecomseo/category/gismos-100.html]
Affected are pages 1 and 2, it actually works perfectly from page 3 upwards.


> Page dropdown list on categorydetail page broken
> 
>
> Key: OFBIZ-10787
> URL: https://issues.apache.org/jira/browse/OFBIZ-10787
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Sebastian Wachinger
>Priority: Minor
>
> The page dropdown list on the {{categorydetail}} page is not populated and 
> only offers to select the current page:
> [stable demo|https://demo-stable.ofbiz.apache.org/ecommerce/gismos-100-c] / 
> [trunk 
> demo|https://demo-trunk.ofbiz.apache.org/ecomseo/category/gismos-100.html]
> Affected are pages 1 and 2, it actually works perfectly from page 3 upwards 
> (in my local installation), but then still there are no entries for pages 1 
> and 2 in the dropdown list.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10787) Page dropdown list on categorydetail page broken

2019-01-10 Thread Sebastian Wachinger (JIRA)
Sebastian Wachinger created OFBIZ-10787:
---

 Summary: Page dropdown list on categorydetail page broken
 Key: OFBIZ-10787
 URL: https://issues.apache.org/jira/browse/OFBIZ-10787
 Project: OFBiz
  Issue Type: Bug
  Components: ecommerce
Affects Versions: Release Branch 16.11, Trunk
Reporter: Sebastian Wachinger


The page dropdown list on the {{categorydetail}} page is not populated and only 
offers to select the current page:
[stable demo|https://demo-stable.ofbiz.apache.org/ecommerce/gismos-100-c] / 
[trunk 
demo|https://demo-trunk.ofbiz.apache.org/ecomseo/category/gismos-100.html]
Affected are pages 1 and 2, it actually works perfectly from page 3 upwards.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10784) Translations es-CL in AccountingUiLabels

2019-01-10 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739615#comment-16739615
 ] 

Jacques Le Roux commented on OFBIZ-10784:
-

Thanks Jonathan,

I see that you duplicated some spain labels like
Asignar pago a esta factura
or
Propiedades aritméticas para factura de servicios no configurada 
apropiadamente. No es posible proceder.

Please remove those. They don't add information since it's already contained in 
the spain version, thanks

> Translations es-CL in AccountingUiLabels
> 
>
> Key: OFBIZ-10784
> URL: https://issues.apache.org/jira/browse/OFBIZ-10784
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Jonathan
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: accounting
> Attachments: AccountingUiLabels_modified.patch
>
>
> Added all translation es-CL  (Chile) in AccountingUiLAbels



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10476) Fix / Remove Compdoc?

2019-01-10 Thread Dennis Balkir (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739614#comment-16739614
 ] 

Dennis Balkir commented on OFBIZ-10476:
---

I will provide a patch for this asap, thanks

> Fix / Remove Compdoc?
> -
>
> Key: OFBIZ-10476
> URL: https://issues.apache.org/jira/browse/OFBIZ-10476
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Major
>
> While creating a theme and looking for not correctly styled elements I came 
> across "some" not functional links and buttons in Compdoc.
> This module seems not to be finished or working properly, because most of the 
> times, the buttons inside the appbar produce errors or just empty pages.
> Even when searching for existing elements and then clicking on them to 
> examine or edit them will mostly create an error (example: go to compdoc, 
> search for template child, click edit on some random found element -> error).
> Sometimes the menu which is included inside the appbar, mostly the menu 
> called "tree", need the contentId for the buttons to work.
> Including this menu while creating a new entry will result in every button 
> not working and throwing an error, except the edit button, which will produce 
> a completely empty page.
> Those things appear all over the module, trying some button or clicking some 
> link resulted in an error screen more than it resulted in something actually 
> working.
> This should either be fixed or removed, if this doesn't has a real purpose at 
> all.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10322) Add Asciidoc template for plugin creation task

2019-01-10 Thread Michael Brohl (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739592#comment-16739592
 ] 

Michael Brohl edited comment on OFBIZ-10322 at 1/10/19 4:46 PM:


Hi Ulrich, thanks for your patch.

Please check the implementation, I think that the files must be added to the 
build.gradle createPlugin task in order to be populated with a newly created 
plugin.


was (Author: mbrohl):
Hi Ulrich, thanks for your patch.

Please check the implementation, I think that the files must be added to the 
build.gradle createPlugin task in order to be populated with the newly created 
plugin.

> Add Asciidoc template for plugin creation task
> --
>
> Key: OFBIZ-10322
> URL: https://issues.apache.org/jira/browse/OFBIZ-10322
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Trivial
> Attachments: OFBIZ-10322_README_HELP_Stubs.patch
>
>
> Create a README.adoc stub and help file stub in the new format under 
> framework/resources/templates and use in the plugin creation task.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework

2019-01-10 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739594#comment-16739594
 ] 

Jacques Le Roux commented on OFBIZ-10607:
-

We could since we should not expect any regression (unused code). But is it 
worth it?

> ‘EntityOperator#getId()’ is not used in the framework
> -
>
> Key: OFBIZ-10607
> URL: https://issues.apache.org/jira/browse/OFBIZ-10607
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch
>
>
> While reading some code with [~gil portenseigne] we found that 
> ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added 
> in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of 
> additional operators for extensions.”.
> If this code is still useful outside of the framework, OFBiz should provide a 
> test demonstrated its purpose and describing how to use it. Otherwise we 
> should simply delete it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10476) Fix / Remove Compdoc?

2019-01-10 Thread Michael Brohl (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739578#comment-16739578
 ] 

Michael Brohl commented on OFBIZ-10476:
---

[~Dennis Balkir],

I think you can move on and provide a patch to remove the compdoc functionality.

> Fix / Remove Compdoc?
> -
>
> Key: OFBIZ-10476
> URL: https://issues.apache.org/jira/browse/OFBIZ-10476
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Major
>
> While creating a theme and looking for not correctly styled elements I came 
> across "some" not functional links and buttons in Compdoc.
> This module seems not to be finished or working properly, because most of the 
> times, the buttons inside the appbar produce errors or just empty pages.
> Even when searching for existing elements and then clicking on them to 
> examine or edit them will mostly create an error (example: go to compdoc, 
> search for template child, click edit on some random found element -> error).
> Sometimes the menu which is included inside the appbar, mostly the menu 
> called "tree", need the contentId for the buttons to work.
> Including this menu while creating a new entry will result in every button 
> not working and throwing an error, except the edit button, which will produce 
> a completely empty page.
> Those things appear all over the module, trying some button or clicking some 
> link resulted in an error screen more than it resulted in something actually 
> working.
> This should either be fixed or removed, if this doesn't has a real purpose at 
> all.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework

2019-01-10 Thread Michael Brohl (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reopened OFBIZ-10607:
---

> ‘EntityOperator#getId()’ is not used in the framework
> -
>
> Key: OFBIZ-10607
> URL: https://issues.apache.org/jira/browse/OFBIZ-10607
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch
>
>
> While reading some code with [~gil portenseigne] we found that 
> ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added 
> in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of 
> additional operators for extensions.”.
> If this code is still useful outside of the framework, OFBiz should provide a 
> test demonstrated its purpose and describing how to use it. Otherwise we 
> should simply delete it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework

2019-01-10 Thread Michael Brohl (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739575#comment-16739575
 ] 

Michael Brohl commented on OFBIZ-10607:
---

Not sure if we should backport it to 17.12/18.12 too?

> ‘EntityOperator#getId()’ is not used in the framework
> -
>
> Key: OFBIZ-10607
> URL: https://issues.apache.org/jira/browse/OFBIZ-10607
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch
>
>
> While reading some code with [~gil portenseigne] we found that 
> ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added 
> in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of 
> additional operators for extensions.”.
> If this code is still useful outside of the framework, OFBiz should provide a 
> test demonstrated its purpose and describing how to use it. Otherwise we 
> should simply delete it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework

2019-01-10 Thread Michael Brohl (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-10607.
-
Resolution: Implemented

Thanks Mathieu,

your modified patch is in trunk r1850958.

Please try to provide clean patches without additional text or else, it makes 
things easier.

> ‘EntityOperator#getId()’ is not used in the framework
> -
>
> Key: OFBIZ-10607
> URL: https://issues.apache.org/jira/browse/OFBIZ-10607
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch
>
>
> While reading some code with [~gil portenseigne] we found that 
> ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added 
> in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of 
> additional operators for extensions.”.
> If this code is still useful outside of the framework, OFBiz should provide a 
> test demonstrated its purpose and describing how to use it. Otherwise we 
> should simply delete it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10765) Failed registration for virtual hosts with similar mount points

2019-01-10 Thread Michael Brohl (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-10765.
-
   Resolution: Fixed
Fix Version/s: 18.12.01
   17.12.01

This is fixed in

trunk r1850953

release 17.12 r1850955

release 18.12 r1850954

> Failed registration for virtual hosts with similar mount points
> ---
>
> Key: OFBIZ-10765
> URL: https://issues.apache.org/jira/browse/OFBIZ-10765
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Blocker
> Fix For: 17.12.01, 18.12.01
>
> Attachments: 
> OFBIZ-10765_failed_registration_for_similar_mount_points.patch
>
>
> The registration of webapps with virtual hosts using similar mount points 
> does not work.
> Example
> The following webapps should be registered (virtual host/ mount point)
>  * host1/webcontent
>  * host2/webcontent
> During registration, the name of the context is implicitly set through the 
> setPath(...) method in org.apache.catalina.core.StandardContext if not 
> already set. In the above example, the name will be set as "/webcontent".
> Wenn the context is added, it is checked if a child under the name is already 
> registered and the addition will be refused.
> The solution would be to explicitly set the name from the webappInfo.name 
> before the path is set. I will provide a patch for it.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10786) Wrong German translation in PartyUiLabels

2019-01-10 Thread Michael Brohl (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-10786:
--
Affects Version/s: 18.12.01
   16.11.06
   17.12.01

> Wrong German translation in PartyUiLabels
> -
>
> Key: OFBIZ-10786
> URL: https://issues.apache.org/jira/browse/OFBIZ-10786
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk, 17.12.01, 16.11.06, 18.12.01
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Trivial
> Attachments: PartyUiLabels.patch
>
>
> There was a wrong german translation in PartyUiLabels. Just did a quick fix



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10786) Wrong German translation in PartyUiLabels

2019-01-10 Thread Michael Brohl (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-10786.
-
   Resolution: Fixed
Fix Version/s: 18.12.01
   16.11.06
   17.12.01

Thanks Dennis,

your patch is in

trunk r1850948

release16.11 r1850952

release 17.12 r1850949

release 18.12 r1850951

> Wrong German translation in PartyUiLabels
> -
>
> Key: OFBIZ-10786
> URL: https://issues.apache.org/jira/browse/OFBIZ-10786
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk, 17.12.01, 16.11.06, 18.12.01
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Trivial
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments: PartyUiLabels.patch
>
>
> There was a wrong german translation in PartyUiLabels. Just did a quick fix



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10784) Translations es-CL in AccountingUiLabels

2019-01-10 Thread Jonathan (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739536#comment-16739536
 ] 

Jonathan commented on OFBIZ-10784:
--

Jacques

I have already uploaded the patch with the indicated modifications.

> Translations es-CL in AccountingUiLabels
> 
>
> Key: OFBIZ-10784
> URL: https://issues.apache.org/jira/browse/OFBIZ-10784
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Jonathan
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: accounting
> Attachments: AccountingUiLabels_modified.patch
>
>
> Added all translation es-CL  (Chile) in AccountingUiLAbels



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10786) Wrong German translation in PartyUiLabels

2019-01-10 Thread Michael Brohl (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-10786:
--
Summary: Wrong German translation in PartyUiLabels  (was: Wrong translation 
in PartyUiLabels)

> Wrong German translation in PartyUiLabels
> -
>
> Key: OFBIZ-10786
> URL: https://issues.apache.org/jira/browse/OFBIZ-10786
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Trivial
> Attachments: PartyUiLabels.patch
>
>
> There was a wrong german translation in PartyUiLabels. Just did a quick fix



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10784) Translations es-CL in AccountingUiLabels

2019-01-10 Thread Jonathan (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan updated OFBIZ-10784:
-
Attachment: AccountingUiLabels_modified.patch

> Translations es-CL in AccountingUiLabels
> 
>
> Key: OFBIZ-10784
> URL: https://issues.apache.org/jira/browse/OFBIZ-10784
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Jonathan
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: accounting
> Attachments: AccountingUiLabels_modified.patch
>
>
> Added all translation es-CL  (Chile) in AccountingUiLAbels



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10786) Wrong translation in PartyUiLabels

2019-01-10 Thread Michael Brohl (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reassigned OFBIZ-10786:
-

Assignee: Michael Brohl

> Wrong translation in PartyUiLabels
> --
>
> Key: OFBIZ-10786
> URL: https://issues.apache.org/jira/browse/OFBIZ-10786
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Trivial
> Attachments: PartyUiLabels.patch
>
>
> There was a wrong german translation in PartyUiLabels. Just did a quick fix



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10786) Wrong translation in PartyUiLabels

2019-01-10 Thread Dennis Balkir (JIRA)
Dennis Balkir created OFBIZ-10786:
-

 Summary: Wrong translation in PartyUiLabels
 Key: OFBIZ-10786
 URL: https://issues.apache.org/jira/browse/OFBIZ-10786
 Project: OFBiz
  Issue Type: Improvement
  Components: party
Affects Versions: Trunk
Reporter: Dennis Balkir
 Attachments: PartyUiLabels.patch

There was a wrong german translation in PartyUiLabels. Just did a quick fix



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10784) Translations es-CL in AccountingUiLabels

2019-01-10 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739444#comment-16739444
 ] 

Jacques Le Roux commented on OFBIZ-10784:
-

Thanks Jonathan,

That's a big file, please replace tabs to 4 spaces in your file, thanks

> Translations es-CL in AccountingUiLabels
> 
>
> Key: OFBIZ-10784
> URL: https://issues.apache.org/jira/browse/OFBIZ-10784
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Jonathan
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: accounting
> Attachments: AccountingUiLabels.patch
>
>
> Added all translation es-CL  (Chile) in AccountingUiLAbels



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10784) Translations es-CL in AccountingUiLabels

2019-01-10 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-10784:
---

Assignee: Jacques Le Roux

> Translations es-CL in AccountingUiLabels
> 
>
> Key: OFBIZ-10784
> URL: https://issues.apache.org/jira/browse/OFBIZ-10784
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Jonathan
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: accounting
> Attachments: AccountingUiLabels.patch
>
>
> Added all translation es-CL  (Chile) in AccountingUiLAbels



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10780) Remove 'Common' identifier from Labels in Common Component

2019-01-10 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739425#comment-16739425
 ] 

Jacques Le Roux commented on OFBIZ-10780:
-

Same here

> Remove 'Common' identifier from Labels in Common Component
> --
>
> Key: OFBIZ-10780
> URL: https://issues.apache.org/jira/browse/OFBIZ-10780
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Minor
>
> Remove the descriptive 'Common' from labels and titles.
> There are:
>  * 780 such occurrences in CommonUiLabelMap.xml (see 
> [https://github.com/PierreSmits/ofbiz-framework/commit/618769b888a89c2ad8fa2d4ee0a1e874bedafa63]
>  )



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10764) Hip chat to Slack Migration

2019-01-10 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739424#comment-16739424
 ] 

Jacques Le Roux commented on OFBIZ-10764:
-

Thanks Swapnil,

At 1st glance (the stuff is slow) it sounds good to me :)

> Hip chat to Slack Migration
> ---
>
> Key: OFBIZ-10764
> URL: https://issues.apache.org/jira/browse/OFBIZ-10764
> Project: OFBiz
>  Issue Type: Improvement
>  Components: site
>Reporter: Pierre Smits
>Assignee: Swapnil M Mane
>Priority: Major
> Attachments: Slack on OFBiz site.png
>
>
> The hip chat channel is going to be abandoned by INFRA. As a replacement the 
> team has made Slack available.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10776) Change 'uiLabelMap' requirement in Framework code

2019-01-10 Thread Gil Portenseigne (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739401#comment-16739401
 ] 

Gil Portenseigne commented on OFBIZ-10776:
--

Same opinion 178kb, is not much regarding the changes that are induced

> Change 'uiLabelMap' requirement in Framework code
> -
>
> Key: OFBIZ-10776
> URL: https://issues.apache.org/jira/browse/OFBIZ-10776
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Minor
>
> Reducing byte size of  'uiLabelMap' from code elements in Framework will lead 
> to significant saves in widgets, templates and functions downstream.
> See 
> https://github.com/PierreSmits/ofbiz-framework/commit/438e9c45eede9c7036ba9e658036085908dce09d



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10784) Translations es-CL in AccountingUiLabels

2019-01-10 Thread Jonathan (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739374#comment-16739374
 ] 

Jonathan commented on OFBIZ-10784:
--

This is the Chilean Spanish translation of the accounting component

> Translations es-CL in AccountingUiLabels
> 
>
> Key: OFBIZ-10784
> URL: https://issues.apache.org/jira/browse/OFBIZ-10784
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Jonathan
>Priority: Minor
>  Labels: accounting
> Attachments: AccountingUiLabels.patch
>
>
> Added all translation es-CL  (Chile) in AccountingUiLAbels



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10781) Remove 'FormFieldTitle_' from labels and references in Accounting

2019-01-10 Thread Michael Brohl (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-10781:
--
Priority: Minor  (was: Major)

> Remove 'FormFieldTitle_' from labels and references in Accounting
> -
>
> Key: OFBIZ-10781
> URL: https://issues.apache.org/jira/browse/OFBIZ-10781
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10780) Remove 'Common' identifier from Labels in Common Component

2019-01-10 Thread Michael Brohl (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739355#comment-16739355
 ] 

Michael Brohl commented on OFBIZ-10780:
---

I find it useful to have the "Common" prefix to quickly see that the label is 
from the common component and not from a specialized application and won't 
change that.

What do others think?

> Remove 'Common' identifier from Labels in Common Component
> --
>
> Key: OFBIZ-10780
> URL: https://issues.apache.org/jira/browse/OFBIZ-10780
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Minor
>
> Remove the descriptive 'Common' from labels and titles.
> There are:
>  * 780 such occurrences in CommonUiLabelMap.xml (see 
> [https://github.com/PierreSmits/ofbiz-framework/commit/618769b888a89c2ad8fa2d4ee0a1e874bedafa63]
>  )



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10779) Remove 'duplicate' labels

2019-01-10 Thread Michael Brohl (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-10779:
--
Priority: Minor  (was: Major)

> Remove 'duplicate' labels
> -
>
> Key: OFBIZ-10779
> URL: https://issues.apache.org/jira/browse/OFBIZ-10779
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10778) Remove 'Accounting' from title definitions and labels in Accounting

2019-01-10 Thread Michael Brohl (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-10778:
--
Priority: Minor  (was: Major)

> Remove 'Accounting' from title definitions and labels in Accounting
> ---
>
> Key: OFBIZ-10778
> URL: https://issues.apache.org/jira/browse/OFBIZ-10778
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10780) Remove 'Common' identifier from Labels in Common Component

2019-01-10 Thread Michael Brohl (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-10780:
--
Priority: Minor  (was: Major)

> Remove 'Common' identifier from Labels in Common Component
> --
>
> Key: OFBIZ-10780
> URL: https://issues.apache.org/jira/browse/OFBIZ-10780
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Minor
>
> Remove the descriptive 'Common' from labels and titles.
> There are:
>  * 780 such occurrences in CommonUiLabelMap.xml (see 
> [https://github.com/PierreSmits/ofbiz-framework/commit/618769b888a89c2ad8fa2d4ee0a1e874bedafa63]
>  )



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10774) Remove 'FormFieldTitle_' requirement in FrameWork code

2019-01-10 Thread Michael Brohl (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-10774:
--
Priority: Minor  (was: Major)

> Remove 'FormFieldTitle_' requirement in FrameWork code
> --
>
> Key: OFBIZ-10774
> URL: https://issues.apache.org/jira/browse/OFBIZ-10774
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Reporter: Pierre Smits
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10775) Remove 'PageTitle' from label and occurrences

2019-01-10 Thread Michael Brohl (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-10775:
--
Priority: Minor  (was: Major)

> Remove 'PageTitle' from label and  occurrences
> -
>
> Key: OFBIZ-10775
> URL: https://issues.apache.org/jira/browse/OFBIZ-10775
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Minor
>
> This also include occurrences in screenlet, label and other widgets and 
> templates



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10764) Hip chat to Slack Migration

2019-01-10 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739230#comment-16739230
 ] 

Swapnil M Mane edited comment on OFBIZ-10764 at 1/10/19 9:47 AM:
-

Done at revision 1850929 and 1850931, thanks!


was (Author: swapnilmmane):
Done at revision 1850929, thanks!

> Hip chat to Slack Migration
> ---
>
> Key: OFBIZ-10764
> URL: https://issues.apache.org/jira/browse/OFBIZ-10764
> Project: OFBiz
>  Issue Type: Improvement
>  Components: site
>Reporter: Pierre Smits
>Assignee: Swapnil M Mane
>Priority: Major
> Attachments: Slack on OFBiz site.png
>
>
> The hip chat channel is going to be abandoned by INFRA. As a replacement the 
> team has made Slack available.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10776) Change 'uiLabelMap' requirement in Framework code

2019-01-10 Thread Michael Brohl (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739232#comment-16739232
 ] 

Michael Brohl commented on OFBIZ-10776:
---

I agree, the effect is minimal and I would prefer better readability over it.

> Change 'uiLabelMap' requirement in Framework code
> -
>
> Key: OFBIZ-10776
> URL: https://issues.apache.org/jira/browse/OFBIZ-10776
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Minor
>
> Reducing byte size of  'uiLabelMap' from code elements in Framework will lead 
> to significant saves in widgets, templates and functions downstream.
> See 
> https://github.com/PierreSmits/ofbiz-framework/commit/438e9c45eede9c7036ba9e658036085908dce09d



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (OFBIZ-9677) In packing, only use reservations with stock on hand

2019-01-10 Thread Michael Brohl (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reopened OFBIZ-9677:
--

Reopened to clarify backporting.

> In packing, only use reservations with stock on hand
> 
>
> Key: OFBIZ-9677
> URL: https://issues.apache.org/jira/browse/OFBIZ-9677
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Paul Foxworthy
>Assignee: Paul Foxworthy
>Priority: Major
>  Labels: pack, reservation
> Fix For: Trunk
>
> Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, 
> OFBIZ-9677_PackingIgnoreBackorderReservations.patch
>
>
> During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the 
> order item. Some reservations are for back ordered items not on hand. These 
> reservations should not be used during packing, but they are.
> The attached patch fixes this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10764) Hip chat to Slack Migration

2019-01-10 Thread Swapnil M Mane (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil M Mane reassigned OFBIZ-10764:
--

Assignee: Swapnil M Mane  (was: Jacques Le Roux)

> Hip chat to Slack Migration
> ---
>
> Key: OFBIZ-10764
> URL: https://issues.apache.org/jira/browse/OFBIZ-10764
> Project: OFBiz
>  Issue Type: Improvement
>  Components: site
>Reporter: Pierre Smits
>Assignee: Swapnil M Mane
>Priority: Major
> Attachments: Slack on OFBiz site.png
>
>
> The hip chat channel is going to be abandoned by INFRA. As a replacement the 
> team has made Slack available.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10764) Hip chat to Slack Migration

2019-01-10 Thread Swapnil M Mane (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil M Mane closed OFBIZ-10764.
--
Resolution: Done

> Hip chat to Slack Migration
> ---
>
> Key: OFBIZ-10764
> URL: https://issues.apache.org/jira/browse/OFBIZ-10764
> Project: OFBiz
>  Issue Type: Improvement
>  Components: site
>Reporter: Pierre Smits
>Assignee: Swapnil M Mane
>Priority: Major
> Attachments: Slack on OFBiz site.png
>
>
> The hip chat channel is going to be abandoned by INFRA. As a replacement the 
> team has made Slack available.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10764) Hip chat to Slack Migration

2019-01-10 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739230#comment-16739230
 ] 

Swapnil M Mane commented on OFBIZ-10764:


Done at revision 1850929, thanks!

> Hip chat to Slack Migration
> ---
>
> Key: OFBIZ-10764
> URL: https://issues.apache.org/jira/browse/OFBIZ-10764
> Project: OFBiz
>  Issue Type: Improvement
>  Components: site
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Slack on OFBiz site.png
>
>
> The hip chat channel is going to be abandoned by INFRA. As a replacement the 
> team has made Slack available.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9677) In packing, only use reservations with stock on hand

2019-01-10 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739224#comment-16739224
 ] 

Jacques Le Roux commented on OFBIZ-9677:


Hi Paul,

Any reasons why you did not backport?

> In packing, only use reservations with stock on hand
> 
>
> Key: OFBIZ-9677
> URL: https://issues.apache.org/jira/browse/OFBIZ-9677
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Paul Foxworthy
>Assignee: Paul Foxworthy
>Priority: Major
>  Labels: pack, reservation
> Fix For: Trunk
>
> Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, 
> OFBIZ-9677_PackingIgnoreBackorderReservations.patch
>
>
> During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the 
> order item. Some reservations are for back ordered items not on hand. These 
> reservations should not be used during packing, but they are.
> The attached patch fixes this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10673) Unable to add additional product images from catalog

2019-01-10 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739222#comment-16739222
 ] 

Jacques Le Roux commented on OFBIZ-10673:
-

Thanks Deepak

> Unable to add additional product images from catalog
> 
>
> Key: OFBIZ-10673
> URL: https://issues.apache.org/jira/browse/OFBIZ-10673
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Rohit Koushal
>Assignee: Deepak Dixit
>Priority: Major
> Fix For: 16.11.06
>
> Attachments: OFBIZ-10673.patch, screenshot-1.png
>
>
> Unable to add additional product images from screen: Catalog > Products > 
> Content
> below is the screen for reference.
>  !screenshot-1.png! 
> Server logs:
> {code:java}
> 2018-11-24 18:40:52,454 |sse-nio-8443-exec-11 |CallService   
> |E| ERROR: Could not complete the Method to upload multiple Additional View 
> images for product 
> [file:/home/rohit/sandbox/ofbiz-framework/applications/product/minilang/product/product/ProductContentServices.xml#uploadProductAdditionalViewImages]
>  process [problem invoking the [addAdditionalViewForProduct] service with the 
> map named [addAdditionalViewForProductMap] containing 
> [{userLogin=[GenericEntity:UserLogin][createdStamp,2018-11-24 
> 11:21:56.719(java.sql.Timestamp)][createdTxStamp,2018-11-24 
> 11:21:56.716(java.sql.Timestamp)][currentPassword,{SHA}47b56994cbc2b6d10aa1be30f70165adb305a41a(java.lang.String)][disabledBy,null()][disabledDateTime,null()][enabled,Y(java.lang.String)][externalAuthId,null()][hasLoggedOut,N(java.lang.String)][isSystem,null()][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,Asia/Calcutta(java.lang.String)][lastUpdatedStamp,2018-11-24
>  14:59:33.347(java.sql.Timestamp)][lastUpdatedTxStamp,2018-11-24 
> 14:59:33.291(java.sql.Timestamp)][partyId,admin(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,0(java.lang.Long)][userLdapDn,null()][userLoginId,admin(java.lang.String)],
>  visualTheme=visual-theme-id:RAINBOWSTONE_SAPHIR, display-name: Rainbow Stone 
> - Sapphire, description: , screenshots: 
> [/rainbowstone/images/themeSaphir.png], productId=GZ-1000, 
> _uploadedFile_contentType=image/png, 
> timeZone=sun.util.calendar.ZoneInfo[id="Asia/Calcutta",offset=1980,dstSavings=0,useDaylight=false,transitions=6,lastRule=null],
>  locale=en_US, productContentTypeId=ADDITIONAL_IMAGE_1, 
> uploadedFile=java.nio.HeapByteBuffer[pos=0 lim=1174673 cap=1174673], 
> _uploadedFile_fileName=Screenshot from 2018-10-23 09:02:57.png}]: Service 
> [addAdditionalViewForProduct] target threw an unexpected exception (null)]
> org.apache.ofbiz.service.GenericServiceException: Service 
> [addAdditionalViewForProduct] target threw an unexpected exception (null)
> at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:115)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:415)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:103)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.method.callops.CallService.exec(CallService.java:217)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.method.ifops.IfNotEmpty.exec(IfNotEmpty.java:61) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310) 
> [ofbiz.jar:?]
> at org.apache.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:457) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:274) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:293)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:415)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>  [ofbiz.jar:?]