[jira] [Updated] (OFBIZ-11304) Install a Checkstyle pre-commit on every committer machine
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11304: Description: The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by the check gradle task. It's "hard" to exactly know from where lint errors come among all still present. I think we should rely on a Checkstyle pre-commit hook like https://gist.github.com/davetron5000/37350 to complement tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when a lint error is present in the commit. Every committer would have it installed locally and the problem would be gone with some committers good will. I started a discussion about it at https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 was: The ofbizTrunkFrameworkPlugins build fail when a lint error is detected by the Check gradle task. It's "hard" to exactly know from where they come. I think we should rely on a Checkstyle pre-commit hook: https://gist.github.com/davetron5000/37350 to complement tasks.checkstyleMain.maxErrors Every committer would have it installed locally and the problem would be gone \o/ > Install a Checkstyle pre-commit on every committer machine > -- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11304) Install a Checkstyle pre-commit on every committer machine
Jacques Le Roux created OFBIZ-11304: --- Summary: Install a Checkstyle pre-commit on every committer machine Key: OFBIZ-11304 URL: https://issues.apache.org/jira/browse/OFBIZ-11304 Project: OFBiz Issue Type: Sub-task Affects Versions: Trunk Reporter: Jacques Le Roux Fix For: Upcoming Branch The ofbizTrunkFrameworkPlugins build fail when a lint error is detected by the Check gradle task. It's "hard" to exactly know from where they come. I think we should rely on a Checkstyle pre-commit hook: https://gist.github.com/davetron5000/37350 to complement tasks.checkstyleMain.maxErrors Every committer would have it installed locally and the problem would be gone \o/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11271) Add a ‘CONTRIBUTING.adoc’ file
[
https://issues.apache.org/jira/browse/OFBIZ-11271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986134#comment-16986134
]
Jacques Le Roux commented on OFBIZ-11271:
-
Yes I think so.
> Add a ‘CONTRIBUTING.adoc’ file
> --
>
> Key: OFBIZ-11271
> URL: https://issues.apache.org/jira/browse/OFBIZ-11271
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
>
> Contributing guidelines are currently defined in
> [Confluence|https://cwiki.apache.org/confluence/display/OFBIZ/Apache+OFBiz+Contribution+and+Development]
> which is far from the code and not easily editable locally. It would be
> better to have a {{CONTRIBUTING.adoc}} file inside the framework repository.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11302) Remove redundant ofbizDebug task type
[ https://issues.apache.org/jira/browse/OFBIZ-11302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985990#comment-16985990 ] Mathieu Lirzin commented on OFBIZ-11302: Indeed [~jleroux], a discussion on the mailing list might be a good idea. Feel free to send an email in that direction, I will revert if necessary. Unless I am mistaken the behavior is strictly equivalent. > Remove redundant ofbizDebug task type > - > > Key: OFBIZ-11302 > URL: https://issues.apache.org/jira/browse/OFBIZ-11302 > Project: OFBiz > Issue Type: Improvement > Components: Gradle >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11303) Reference to obsolete workflow component
[ https://issues.apache.org/jira/browse/OFBIZ-11303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985981#comment-16985981 ] Jacques Le Roux commented on OFBIZ-11303: - Yes we discussed that already, but I don't think it's graved in stone, we can have some flexibility here, nothing depends on it. Actually we are discussing about moving https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices to .adoc and while doing so prune and simplify it: OFBIZ-11271 OFBIZ-11301 > Reference to obsolete workflow component > > > Key: OFBIZ-11303 > URL: https://issues.apache.org/jira/browse/OFBIZ-11303 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > > HI Mathieu, > I changed to improvement as it's not really a bug and you did not backport*, > also put the component. > * That's a good way to decide if it's really a bug. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11302) Remove redundant ofbizDebug task type
[ https://issues.apache.org/jira/browse/OFBIZ-11302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985970#comment-16985970 ] Jacques Le Roux edited comment on OFBIZ-11302 at 12/2/19 11:18 AM: --- I have no problem with this change, it's easy to remember. Just that we could have a short discussion on dev ML before ;). I like the idea of having syntax sugar to easy remember commands :) Like ofbizDebug, ofbizBackground, BTW ofbizDebug still appears when you run "gradlew tasks". And don't we lose the "" part? was (Author: jacques.le.roux): I have no problem with this change, it's easy to remember. Just that we could have a short discussion on dev ML before. I like the idea of having syntax sugar to easy remember commands :) > Remove redundant ofbizDebug task type > - > > Key: OFBIZ-11302 > URL: https://issues.apache.org/jira/browse/OFBIZ-11302 > Project: OFBiz > Issue Type: Improvement > Components: Gradle >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11303) Reference to obsolete workflow component
[ https://issues.apache.org/jira/browse/OFBIZ-11303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985974#comment-16985974 ] Pierre Smits commented on OFBIZ-11303: -- Removing code, like adding code, is the same difference. The type of the ticket determines the resolution (as per convention established long ago). > Reference to obsolete workflow component > > > Key: OFBIZ-11303 > URL: https://issues.apache.org/jira/browse/OFBIZ-11303 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > > HI Mathieu, > I changed to improvement as it's not really a bug and you did not backport*, > also put the component. > * That's a good way to decide if it's really a bug. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11302) Remove redundant ofbizDebug task type
[ https://issues.apache.org/jira/browse/OFBIZ-11302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985970#comment-16985970 ] Jacques Le Roux commented on OFBIZ-11302: - I have no problem with this change, it's easy to remember. Just that we could have a short discussion on dev ML before. I like the idea of having syntax sugar to easy remember commands :) > Remove redundant ofbizDebug task type > - > > Key: OFBIZ-11302 > URL: https://issues.apache.org/jira/browse/OFBIZ-11302 > Project: OFBiz > Issue Type: Improvement > Components: Gradle >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11302) Remove redundant ofbizDebug task type
[ https://issues.apache.org/jira/browse/OFBIZ-11302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11302. --- Resolution: Resolved Was my bad when closing again, as I said Resolved fits with me here > Remove redundant ofbizDebug task type > - > > Key: OFBIZ-11302 > URL: https://issues.apache.org/jira/browse/OFBIZ-11302 > Project: OFBiz > Issue Type: Improvement > Components: Gradle >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (OFBIZ-11302) Remove redundant ofbizDebug task type
[ https://issues.apache.org/jira/browse/OFBIZ-11302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-11302: - > Remove redundant ofbizDebug task type > - > > Key: OFBIZ-11302 > URL: https://issues.apache.org/jira/browse/OFBIZ-11302 > Project: OFBiz > Issue Type: Improvement > Components: Gradle >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11303) Reference to obsolete workflow component
[ https://issues.apache.org/jira/browse/OFBIZ-11303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985946#comment-16985946 ] Pierre Smits commented on OFBIZ-11303: -- Tickets of type 'improvements' don't get the resolution 'Fixed'. Bugs get fixed, tasks get done and improvements get implemented. > Reference to obsolete workflow component > > > Key: OFBIZ-11303 > URL: https://issues.apache.org/jira/browse/OFBIZ-11303 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > > HI Mathieu, > I changed to improvement as it's not really a bug and you did not backport*, > also put the component. > * That's a good way to decide if it's really a bug. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11302) Remove redundant ofbizDebug task type
[ https://issues.apache.org/jira/browse/OFBIZ-11302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985945#comment-16985945 ] Pierre Smits commented on OFBIZ-11302: -- Tickets of type 'improvements' don't get the resolution 'Fixed'. Bugs get fixed, tasks get done and improvements get implemented. > Remove redundant ofbizDebug task type > - > > Key: OFBIZ-11302 > URL: https://issues.apache.org/jira/browse/OFBIZ-11302 > Project: OFBiz > Issue Type: Improvement > Components: Gradle >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11302) Remove redundant ofbizDebug task type
[ https://issues.apache.org/jira/browse/OFBIZ-11302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11302. --- Resolution: Fixed I reopened to change the Resolution to done or implemented as it's an improvement, but finally resolved is OK with me: makes more sense here. > Remove redundant ofbizDebug task type > - > > Key: OFBIZ-11302 > URL: https://issues.apache.org/jira/browse/OFBIZ-11302 > Project: OFBiz > Issue Type: Improvement > Components: Gradle >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (OFBIZ-11302) Remove redundant ofbizDebug task type
[ https://issues.apache.org/jira/browse/OFBIZ-11302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-11302: - > Remove redundant ofbizDebug task type > - > > Key: OFBIZ-11302 > URL: https://issues.apache.org/jira/browse/OFBIZ-11302 > Project: OFBiz > Issue Type: Improvement > Components: Gradle >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11302) Remove redundant ofbizDebug task type
[ https://issues.apache.org/jira/browse/OFBIZ-11302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11302: Component/s: Gradle > Remove redundant ofbizDebug task type > - > > Key: OFBIZ-11302 > URL: https://issues.apache.org/jira/browse/OFBIZ-11302 > Project: OFBiz > Issue Type: Improvement > Components: Gradle >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11278) SeoContextFilter.java is not able to handle query strings
[ https://issues.apache.org/jira/browse/OFBIZ-11278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985927#comment-16985927 ] Jacques Le Roux commented on OFBIZ-11278: - Last commit was a little abuse in this Jira (not a bug), but it's OK with me. > SeoContextFilter.java is not able to handle query strings > - > > Key: OFBIZ-11278 > URL: https://issues.apache.org/jira/browse/OFBIZ-11278 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, product >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 18.12.01 > > > While working on OFBIZ-9804 I was confronted with misc. issues. One of them > was that SeoContextFilter.java was not handling query strings. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11303) Reference to obsolete workflow component
[ https://issues.apache.org/jira/browse/OFBIZ-11303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11303. --- Resolution: Done > Reference to obsolete workflow component > > > Key: OFBIZ-11303 > URL: https://issues.apache.org/jira/browse/OFBIZ-11303 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > > HI Mathieu, > I changed to improvement as it's not really a bug and you did not backport*, > also put the component. > * That's a good way to decide if it's really a bug. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11278) SeoContextFilter.java is not able to handle query strings
[ https://issues.apache.org/jira/browse/OFBIZ-11278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11278. --- Resolution: Fixed > SeoContextFilter.java is not able to handle query strings > - > > Key: OFBIZ-11278 > URL: https://issues.apache.org/jira/browse/OFBIZ-11278 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, product >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 18.12.01 > > > While working on OFBIZ-9804 I was confronted with misc. issues. One of them > was that SeoContextFilter.java was not handling query strings. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (OFBIZ-11278) SeoContextFilter.java is not able to handle query strings
[ https://issues.apache.org/jira/browse/OFBIZ-11278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-11278: - > SeoContextFilter.java is not able to handle query strings > - > > Key: OFBIZ-11278 > URL: https://issues.apache.org/jira/browse/OFBIZ-11278 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, product >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 18.12.01 > > > While working on OFBIZ-9804 I was confronted with misc. issues. One of them > was that SeoContextFilter.java was not handling query strings. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11303) Reference to obsolete workflow component
[ https://issues.apache.org/jira/browse/OFBIZ-11303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11303: Component/s: order Description: HI Mathieu, I changed to improvement as it's not really a bug and you did not backport*, also put the component. * That's a good way to decide if it's really a bug. Issue Type: Improvement (was: Bug) > Reference to obsolete workflow component > > > Key: OFBIZ-11303 > URL: https://issues.apache.org/jira/browse/OFBIZ-11303 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > > HI Mathieu, > I changed to improvement as it's not really a bug and you did not backport*, > also put the component. > * That's a good way to decide if it's really a bug. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (OFBIZ-11303) Reference to obsolete workflow component
[ https://issues.apache.org/jira/browse/OFBIZ-11303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-11303: - > Reference to obsolete workflow component > > > Key: OFBIZ-11303 > URL: https://issues.apache.org/jira/browse/OFBIZ-11303 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > > HI Mathieu, > I changed to improvement as it's not really a bug and you did not backport*, > also put the component. > * That's a good way to decide if it's really a bug. -- This message was sent by Atlassian Jira (v8.3.4#803005)
