[jira] [Updated] (OFBIZ-11607) Enhance Groovy and Simple Event Handler to support transaction timout
[ https://issues.apache.org/jira/browse/OFBIZ-11607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11607: Description: When we call an event (java, groovy or simple), and if it takes a too long time we got a transaction timeout error. Support to set a non-default transaction-timeout for an event is already added in OFBIZ-8160. JavaEventHandler is already enhanced to honor that transaction timeout. This effort is to enhance GroovyEventHandler and SimpleEventHandler to consider the transaction timeout set via event tag of the controller entry if provided otherwise it will work with the default transaction timeout. was: When we call an event (java, groovy or simple), and if it takes a too long time we got a transaction timeout error. Support to set a non-default transaction-timeout for an event is already added in [OFBIZ-8160|https://issues.apache.org/jira/browse/OFBIZ-8160]. JavaEventHandler is already enhanced to honor that transaction timeout. This effort is to enhance GroovyEventHandler and SimpleEventHandler to consider the transaction timeout set via event tag of the controller entry if provided otherwise it will work with the default transaction timeout. > Enhance Groovy and Simple Event Handler to support transaction timout > - > > Key: OFBIZ-11607 > URL: https://issues.apache.org/jira/browse/OFBIZ-11607 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Ravi Lodhi >Priority: Minor > > When we call an event (java, groovy or simple), and if it takes a too long > time we got a transaction timeout error. Support to set a non-default > transaction-timeout for an event is already added in OFBIZ-8160. > JavaEventHandler is already enhanced to honor that transaction timeout. This > effort is to enhance GroovyEventHandler and SimpleEventHandler to consider > the transaction timeout set via event tag of the controller entry if provided > otherwise it will work with the default transaction timeout. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10366) Proper User friendly message should visible at Create Inventory Transfer screen
[ https://issues.apache.org/jira/browse/OFBIZ-10366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-10366: Component/s: hhfacility > Proper User friendly message should visible at Create Inventory Transfer > screen > --- > > Key: OFBIZ-10366 > URL: https://issues.apache.org/jira/browse/OFBIZ-10366 > Project: OFBiz > Issue Type: Improvement > Components: hhfacility >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10366.patch, OFBIZ-10366.png > > > Steps to regenerate: > # Go to facility component. > # Select any facility. > # Click on Inventory Xfers. > # Now click on Inventory Transfer to create new Inventory Transfer. > # Now add any product id and submit > # At "Quantity To Transfer" field add quantity more than ATP. > # See the error message. PFA for error message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-10366) Proper User friendly message should visible at Create Inventory Transfer screen
[ https://issues.apache.org/jira/browse/OFBIZ-10366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-10366. --- Fix Version/s: Upcoming Branch Resolution: Implemented This has been done at db2c301. Thanks: Ritesh Kumar for your contribution and Pierre Smits for the review. > Proper User friendly message should visible at Create Inventory Transfer > screen > --- > > Key: OFBIZ-10366 > URL: https://issues.apache.org/jira/browse/OFBIZ-10366 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10366.patch, OFBIZ-10366.png > > > Steps to regenerate: > # Go to facility component. > # Select any facility. > # Click on Inventory Xfers. > # Now click on Inventory Transfer to create new Inventory Transfer. > # Now add any product id and submit > # At "Quantity To Transfer" field add quantity more than ATP. > # See the error message. PFA for error message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10366) Proper User friendly message should visible at Create Inventory Transfer screen
[ https://issues.apache.org/jira/browse/OFBIZ-10366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092304#comment-17092304 ] ASF subversion and git services commented on OFBIZ-10366: - Commit db2c301c7e2029321a28a9e7ca5cd97e2ab036a6 in ofbiz-framework's branch refs/heads/trunk from Pawan Verma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=db2c301 ] Improved: Proper User friendly message should visible at Create Inventory Transfer screen (OFBIZ-10366) Thanks: Ritesh Kumar for your contribution and Pierre Smits for the review. > Proper User friendly message should visible at Create Inventory Transfer > screen > --- > > Key: OFBIZ-10366 > URL: https://issues.apache.org/jira/browse/OFBIZ-10366 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-10366.patch, OFBIZ-10366.png > > > Steps to regenerate: > # Go to facility component. > # Select any facility. > # Click on Inventory Xfers. > # Now click on Inventory Transfer to create new Inventory Transfer. > # Now add any product id and submit > # At "Quantity To Transfer" field add quantity more than ATP. > # See the error message. PFA for error message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10366) Proper User friendly message should visible at Create Inventory Transfer screen
[ https://issues.apache.org/jira/browse/OFBIZ-10366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-10366: --- Assignee: Pawan Verma (was: Ritesh Kumar) > Proper User friendly message should visible at Create Inventory Transfer > screen > --- > > Key: OFBIZ-10366 > URL: https://issues.apache.org/jira/browse/OFBIZ-10366 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-10366.patch, OFBIZ-10366.png > > > Steps to regenerate: > # Go to facility component. > # Select any facility. > # Click on Inventory Xfers. > # Now click on Inventory Transfer to create new Inventory Transfer. > # Now add any product id and submit > # At "Quantity To Transfer" field add quantity more than ATP. > # See the error message. PFA for error message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #76: Fixed: EntityQuery queryCount is throwing error with distinct method
sonarcloud[bot] commented on pull request #76: URL: https://github.com/apache/ofbiz-framework/pull/76#issuecomment-619413398 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=76) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=76=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=76=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #76: Fixed: EntityQuery queryCount is throwing error with distinct method
sonarcloud[bot] removed a comment on pull request #76: URL: https://github.com/apache/ofbiz-framework/pull/76#issuecomment-619337053 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=76) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=76=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=76=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] verma-pawan commented on a change in pull request #76: Fixed: EntityQuery queryCount is throwing error with distinct method
verma-pawan commented on a change in pull request #76:
URL: https://github.com/apache/ofbiz-framework/pull/76#discussion_r415105478
##
File path:
framework/entity/src/main/java/org/apache/ofbiz/entity/GenericDelegator.java
##
@@ -1625,8 +1625,8 @@ public EntityListIterator
findListIteratorByCondition(DynamicViewEntity dynamicV
* @see
org.apache.ofbiz.entity.Delegator#findCountByCondition(java.lang.String,
org.apache.ofbiz.entity.condition.EntityCondition,
org.apache.ofbiz.entity.condition.EntityCondition,
org.apache.ofbiz.entity.util.EntityFindOptions)
*/
@Override
-public long findCountByCondition(String entityName, EntityCondition
whereEntityCondition,
-EntityCondition havingEntityCondition, EntityFindOptions
findOptions) throws GenericEntityException {
+public long findCountByCondition(String entityName, EntityCondition
whereEntityCondition, Set fieldsToSelect
Review comment:
@dixitdeepak Done, please have look!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [ofbiz-framework] verma-pawan commented on a change in pull request #76: Fixed: EntityQuery queryCount is throwing error with distinct method
verma-pawan commented on a change in pull request #76:
URL: https://github.com/apache/ofbiz-framework/pull/76#discussion_r415097884
##
File path:
framework/entity/src/main/java/org/apache/ofbiz/entity/GenericDelegator.java
##
@@ -1625,8 +1625,8 @@ public EntityListIterator
findListIteratorByCondition(DynamicViewEntity dynamicV
* @see
org.apache.ofbiz.entity.Delegator#findCountByCondition(java.lang.String,
org.apache.ofbiz.entity.condition.EntityCondition,
org.apache.ofbiz.entity.condition.EntityCondition,
org.apache.ofbiz.entity.util.EntityFindOptions)
*/
@Override
-public long findCountByCondition(String entityName, EntityCondition
whereEntityCondition,
-EntityCondition havingEntityCondition, EntityFindOptions
findOptions) throws GenericEntityException {
+public long findCountByCondition(String entityName, EntityCondition
whereEntityCondition, Set fieldsToSelect
Review comment:
Thanks, @dixitdeepak totally agree. It slips off from my mind, on it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (OFBIZ-11519) Convert testCreateFixedAssetMaint test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092285#comment-17092285 ] Rohit Hukkeri commented on OFBIZ-11519: --- Hello [~pawan], Please find the attached patch for testCreateFixedAssetMaintTest test Thanks! > Convert testCreateFixedAssetMaint test from XML to Groovy > - > > Key: OFBIZ-11519 > URL: https://issues.apache.org/jira/browse/OFBIZ-11519 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Rohit Hukkeri >Priority: Minor > Attachments: OFBIZ-11519.patch > > > Convert testCreateFixedAssetMaint test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11519) Convert testCreateFixedAssetMaint test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Hukkeri updated OFBIZ-11519: -- Attachment: OFBIZ-11519.patch > Convert testCreateFixedAssetMaint test from XML to Groovy > - > > Key: OFBIZ-11519 > URL: https://issues.apache.org/jira/browse/OFBIZ-11519 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Rohit Hukkeri >Priority: Minor > Attachments: OFBIZ-11519.patch > > > Convert testCreateFixedAssetMaint test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10366) Proper User friendly message should visible at Create Inventory Transfer screen
[ https://issues.apache.org/jira/browse/OFBIZ-10366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092253#comment-17092253 ] Ritesh Kumar commented on OFBIZ-10366: -- Hi [~pawan], I did miss the ui label change, I have updated the patch. > Proper User friendly message should visible at Create Inventory Transfer > screen > --- > > Key: OFBIZ-10366 > URL: https://issues.apache.org/jira/browse/OFBIZ-10366 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Ritesh Kumar >Priority: Minor > Attachments: OFBIZ-10366.patch, OFBIZ-10366.png > > > Steps to regenerate: > # Go to facility component. > # Select any facility. > # Click on Inventory Xfers. > # Now click on Inventory Transfer to create new Inventory Transfer. > # Now add any product id and submit > # At "Quantity To Transfer" field add quantity more than ATP. > # See the error message. PFA for error message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10366) Proper User friendly message should visible at Create Inventory Transfer screen
[ https://issues.apache.org/jira/browse/OFBIZ-10366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritesh Kumar updated OFBIZ-10366: - Attachment: OFBIZ-10366.patch > Proper User friendly message should visible at Create Inventory Transfer > screen > --- > > Key: OFBIZ-10366 > URL: https://issues.apache.org/jira/browse/OFBIZ-10366 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Ritesh Kumar >Priority: Minor > Attachments: OFBIZ-10366.patch, OFBIZ-10366.png > > > Steps to regenerate: > # Go to facility component. > # Select any facility. > # Click on Inventory Xfers. > # Now click on Inventory Transfer to create new Inventory Transfer. > # Now add any product id and submit > # At "Quantity To Transfer" field add quantity more than ATP. > # See the error message. PFA for error message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10366) Proper User friendly message should visible at Create Inventory Transfer screen
[ https://issues.apache.org/jira/browse/OFBIZ-10366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritesh Kumar updated OFBIZ-10366: - Attachment: (was: OFBIZ-10366.patch) > Proper User friendly message should visible at Create Inventory Transfer > screen > --- > > Key: OFBIZ-10366 > URL: https://issues.apache.org/jira/browse/OFBIZ-10366 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Ritesh Kumar >Priority: Minor > Attachments: OFBIZ-10366.patch, OFBIZ-10366.png > > > Steps to regenerate: > # Go to facility component. > # Select any facility. > # Click on Inventory Xfers. > # Now click on Inventory Transfer to create new Inventory Transfer. > # Now add any product id and submit > # At "Quantity To Transfer" field add quantity more than ATP. > # See the error message. PFA for error message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11517) Convert testCancelFixedAssetStdCost test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Hukkeri updated OFBIZ-11517: -- Attachment: OFBIZ-11517.patch > Convert testCancelFixedAssetStdCost test from XML to Groovy > --- > > Key: OFBIZ-11517 > URL: https://issues.apache.org/jira/browse/OFBIZ-11517 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Rohit Hukkeri >Priority: Minor > Attachments: OFBIZ-11517.patch > > > Convert testCancelFixedAssetStdCost test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11517) Convert testCancelFixedAssetStdCost test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Hukkeri updated OFBIZ-11517: -- Attachment: (was: OFBIZ-11517.patch) > Convert testCancelFixedAssetStdCost test from XML to Groovy > --- > > Key: OFBIZ-11517 > URL: https://issues.apache.org/jira/browse/OFBIZ-11517 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Rohit Hukkeri >Priority: Minor > Attachments: OFBIZ-11517.patch > > > Convert testCancelFixedAssetStdCost test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] dixitdeepak commented on a change in pull request #76: Fixed: EntityQuery queryCount is throwing error with distinct method
dixitdeepak commented on a change in pull request #76:
URL: https://github.com/apache/ofbiz-framework/pull/76#discussion_r415071220
##
File path:
framework/entity/src/main/java/org/apache/ofbiz/entity/GenericDelegator.java
##
@@ -1625,8 +1625,8 @@ public EntityListIterator
findListIteratorByCondition(DynamicViewEntity dynamicV
* @see
org.apache.ofbiz.entity.Delegator#findCountByCondition(java.lang.String,
org.apache.ofbiz.entity.condition.EntityCondition,
org.apache.ofbiz.entity.condition.EntityCondition,
org.apache.ofbiz.entity.util.EntityFindOptions)
*/
@Override
-public long findCountByCondition(String entityName, EntityCondition
whereEntityCondition,
-EntityCondition havingEntityCondition, EntityFindOptions
findOptions) throws GenericEntityException {
+public long findCountByCondition(String entityName, EntityCondition
whereEntityCondition, Set fieldsToSelect
Review comment:
@verma-pawan I think we need to keep the existing method signature as
well, and can pass null as fieldsToSelect to maintain backward compatibility.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (OFBIZ-7735) OFBIZ-7471: Improve all the service level error messages for missing required field for party component
[ https://issues.apache.org/jira/browse/OFBIZ-7735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-7735: - Affects Version/s: Trunk > OFBIZ-7471: Improve all the service level error messages for missing required > field for party component > --- > > Key: OFBIZ-7735 > URL: https://issues.apache.org/jira/browse/OFBIZ-7735 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: 16.11.01, Trunk >Reporter: Ratnesh Upadhyay >Assignee: Suraj Khurana >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7735.patch, OFBIZ-7735.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-7735) OFBIZ-7471: Improve all the service level error messages for missing required field for party component
[ https://issues.apache.org/jira/browse/OFBIZ-7735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-7735. Fix Version/s: Upcoming Branch Resolution: Implemented Thanks Ratnesh Upadhyay for reporting and Kirti Arora for providing the updated patch. > OFBIZ-7471: Improve all the service level error messages for missing required > field for party component > --- > > Key: OFBIZ-7735 > URL: https://issues.apache.org/jira/browse/OFBIZ-7735 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: 16.11.01 >Reporter: Ratnesh Upadhyay >Assignee: Suraj Khurana >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7735.patch, OFBIZ-7735.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-7735) OFBIZ-7471: Improve all the service level error messages for missing required field for party component
[ https://issues.apache.org/jira/browse/OFBIZ-7735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092235#comment-17092235 ] Suraj Khurana commented on OFBIZ-7735: -- Hello team, I have checked, few entries have already been updated/modified, applied patch manually. > OFBIZ-7471: Improve all the service level error messages for missing required > field for party component > --- > > Key: OFBIZ-7735 > URL: https://issues.apache.org/jira/browse/OFBIZ-7735 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: 16.11.01 >Reporter: Ratnesh Upadhyay >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-7735.patch, OFBIZ-7735.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-7735) OFBIZ-7471: Improve all the service level error messages for missing required field for party component
[ https://issues.apache.org/jira/browse/OFBIZ-7735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092234#comment-17092234 ] ASF subversion and git services commented on OFBIZ-7735: Commit d21bb752f0b1e1691f67b3205fbcb84ddaccf28e in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d21bb75 ] Improved: All the service level error messages for missing required field for party component. (OFBIZ-7735) Thanks Ratnesh Upadhyay for reporting and Kirti Arora for providing the updated patch. > OFBIZ-7471: Improve all the service level error messages for missing required > field for party component > --- > > Key: OFBIZ-7735 > URL: https://issues.apache.org/jira/browse/OFBIZ-7735 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: 16.11.01 >Reporter: Ratnesh Upadhyay >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-7735.patch, OFBIZ-7735.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11490) Convert createPaymentAndPaymentGroupForInvoices service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sourabh Punyani reassigned OFBIZ-11490: --- Assignee: Sourabh Punyani (was: Devanshu Vyas) > Convert createPaymentAndPaymentGroupForInvoices service from mini-lang to > groovy DSL > > > Key: OFBIZ-11490 > URL: https://issues.apache.org/jira/browse/OFBIZ-11490 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Sourabh Punyani >Priority: Minor > > Convert the createPaymentAndPaymentGroupForInvoices service code from > mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11145) Add Party Content does not create new content
[ https://issues.apache.org/jira/browse/OFBIZ-11145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11145. --- Resolution: Not A Problem Yes, I have already created OFBIZ-11582 for that, closing here > Add Party Content does not create new content > - > > Key: OFBIZ-11145 > URL: https://issues.apache.org/jira/browse/OFBIZ-11145 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Rahul Chohal >Priority: Major > > Steps to regenerate: > # Login into Partymgr component. > # Select any party and go to Party Content tab > # Under form *Add Party Content,* fill details and try to create content > This works on demo-stable.ofbiz.apache.org but not on > demo-trunk.ofbiz.apache.org. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-7739) OFBIZ-7471: Improve all the service level error messages for missing required field for catalog component
[ https://issues.apache.org/jira/browse/OFBIZ-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-7739: - Affects Version/s: Trunk > OFBIZ-7471: Improve all the service level error messages for missing required > field for catalog component > - > > Key: OFBIZ-7739 > URL: https://issues.apache.org/jira/browse/OFBIZ-7739 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: 16.11.01, Trunk >Reporter: Ratnesh Upadhyay >Assignee: Suraj Khurana >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7739.patch, OFBIZ-7739.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-7739) OFBIZ-7471: Improve all the service level error messages for missing required field for catalog component
[ https://issues.apache.org/jira/browse/OFBIZ-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-7739. Fix Version/s: Upcoming Branch Resolution: Implemented Thanks Ratnesh Upadhyay for reporting, reviewing the updated patch and Sega for initial patch. > OFBIZ-7471: Improve all the service level error messages for missing required > field for catalog component > - > > Key: OFBIZ-7739 > URL: https://issues.apache.org/jira/browse/OFBIZ-7739 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: 16.11.01 >Reporter: Ratnesh Upadhyay >Assignee: Suraj Khurana >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7739.patch, OFBIZ-7739.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-7739) OFBIZ-7471: Improve all the service level error messages for missing required field for catalog component
[ https://issues.apache.org/jira/browse/OFBIZ-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092200#comment-17092200 ] ASF subversion and git services commented on OFBIZ-7739: Commit 757551a8fd4c8e3478f984465c18780c94d3ee29 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=757551a ] Improved: All the service level error messages for missing required field for catalog component. (OFBIZ-7739) Thanks Ratnesh Upadhyay for reporting, reviewing the updated patch and Sega for initial patch. > OFBIZ-7471: Improve all the service level error messages for missing required > field for catalog component > - > > Key: OFBIZ-7739 > URL: https://issues.apache.org/jira/browse/OFBIZ-7739 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: 16.11.01 >Reporter: Ratnesh Upadhyay >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-7739.patch, OFBIZ-7739.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11608) Added Item does not exist in the cart when anonymous user revisits the eCommerce store
[ https://issues.apache.org/jira/browse/OFBIZ-11608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pradeep Choudhary reassigned OFBIZ-11608: - Assignee: (was: Pradeep Choudhary) > Added Item does not exist in the cart when anonymous user revisits the > eCommerce store > -- > > Key: OFBIZ-11608 > URL: https://issues.apache.org/jira/browse/OFBIZ-11608 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Release Branch 16.11, Trunk > Environment: [link title|http://example.com] >Reporter: Pradeep Choudhary >Priority: Minor > > Steps to regenerate: > 1. Set the 'autoSaveCart' field to 'Y' in product_store entity (for Store > 9000). > 2. Open Firefox browser, as it deletes the cookies as soon as the user closes > the browser application. (To reproduce it on chrome, need to disable setting > for 'Continue running background apps when Google Chrome is closed') > 3. Visit the [eCommerce store|https://localhost:8443/ecommerce/control/main] > 4. Add items to the cart without logging in (as an anonymous user) > 5. Close the browser application. > 6. Revisit the eCommerce store. > Actual: > Shopping Cart is showing empty. > Expected: > Previously added items should persist in the item for the anonymous user > also. > Note: > It is working fine, if the user logged In to the application, add items to > cart, closes the application. Revisits the store, previously added items > persist in the cart. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Issue Comment Deleted] (OFBIZ-11608) Added Item does not exist in the cart when anonymous user revisits the eCommerce store
[ https://issues.apache.org/jira/browse/OFBIZ-11608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pradeep Choudhary updated OFBIZ-11608: -- Comment: was deleted (was: We have added user login check into 'restoreAutoSaveList' event to fix the authorization error, which is thrown while restoring autoSaveListId for anonymous user. It restricts to restore autoSaveListId only for logged in user. Need to fix authorization issue at the service level instead of restricting it in the event.) > Added Item does not exist in the cart when anonymous user revisits the > eCommerce store > -- > > Key: OFBIZ-11608 > URL: https://issues.apache.org/jira/browse/OFBIZ-11608 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Release Branch 16.11, Trunk > Environment: [link title|http://example.com] >Reporter: Pradeep Choudhary >Assignee: Pradeep Choudhary >Priority: Minor > > Steps to regenerate: > 1. Set the 'autoSaveCart' field to 'Y' in product_store entity (for Store > 9000). > 2. Open Firefox browser, as it deletes the cookies as soon as the user closes > the browser application. (To reproduce it on chrome, need to disable setting > for 'Continue running background apps when Google Chrome is closed') > 3. Visit the [eCommerce store|https://localhost:8443/ecommerce/control/main] > 4. Add items to the cart without logging in (as an anonymous user) > 5. Close the browser application. > 6. Revisit the eCommerce store. > Actual: > Shopping Cart is showing empty. > Expected: > Previously added items should persist in the item for the anonymous user > also. > Note: > It is working fine, if the user logged In to the application, add items to > cart, closes the application. Revisits the store, previously added items > persist in the cart. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11550) Convert testUpdateFixedAssetMeter test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092190#comment-17092190 ] Aishwary Shrivastava commented on OFBIZ-11550: -- Attached the patch for the testUpdateFixedAssetMeter test Thanks! > Convert testUpdateFixedAssetMeter test from XML to Groovy > - > > Key: OFBIZ-11550 > URL: https://issues.apache.org/jira/browse/OFBIZ-11550 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Aishwary Shrivastava >Priority: Minor > Attachments: OFBIZ-11550.patch > > > Convert testUpdateFixedAssetMeter test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11550) Convert testUpdateFixedAssetMeter test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aishwary Shrivastava updated OFBIZ-11550: - Attachment: OFBIZ-11550.patch > Convert testUpdateFixedAssetMeter test from XML to Groovy > - > > Key: OFBIZ-11550 > URL: https://issues.apache.org/jira/browse/OFBIZ-11550 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Aishwary Shrivastava >Priority: Minor > Attachments: OFBIZ-11550.patch > > > Convert testUpdateFixedAssetMeter test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-7739) OFBIZ-7471: Improve all the service level error messages for missing required field for catalog component
[ https://issues.apache.org/jira/browse/OFBIZ-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092187#comment-17092187 ] Ratnesh Upadhyay edited comment on OFBIZ-7739 at 4/25/20, 11:44 AM: I quickly reviewed the patch and it looks good to me, thanks [~surajk] for the enhancement and patch for changes. was (Author: upadhyay.ratnesh): I quickly reviewed the patch and it looks to me, thanks [~surajk] for the enhancement and patch for changes. > OFBIZ-7471: Improve all the service level error messages for missing required > field for catalog component > - > > Key: OFBIZ-7739 > URL: https://issues.apache.org/jira/browse/OFBIZ-7739 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: 16.11.01 >Reporter: Ratnesh Upadhyay >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-7739.patch, OFBIZ-7739.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10532) Default value flags not working for configurable and variant products at the time of order entry
[ https://issues.apache.org/jira/browse/OFBIZ-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pradeep Choudhary reassigned OFBIZ-10532: - Assignee: (was: Pradeep Choudhary) > Default value flags not working for configurable and variant products at the > time of order entry > > > Key: OFBIZ-10532 > URL: https://issues.apache.org/jira/browse/OFBIZ-10532 > Project: OFBiz > Issue Type: New Feature > Components: order >Affects Versions: Trunk >Reporter: Deepak Nigam >Priority: Major > > On adding configurable/variant products to the cart, default value flags i.e. > 'Use as default desired delivery date for next entry' and 'Use as default > comment for next entry' are not working. Flags are working fine for simple > products. Below are the steps to regenerate the issue: > 1) Log in to 'ordermgr' with credentials admin/ofbiz. > 2) Click on the 'Order Entry' menu. > 3) In the 'Sales Order' section enter the values and click on the 'Continue' > link. > 4) Leave the fields on the next page as it is and click on the 'Continue' > link. > 5) Select any configurable product (e.g. pizza) or variant (e.g. WG-9943) and > enter quantity. > 6) Enter the 'Desired Delivery Date' and click on the adjacent checkbox 'Use > as default desired delivery date for next entry'. > 7) Enter the 'Comment' and click on the adjacent checkbox 'Use as default > comment for next entry'. > 8) Click on the 'Add To Cart' button. You will be landed on the next screen > for selecting the variant or configuring the product. > 9) After configuration click on 'Add To Cart' button again. > Item will be added to cart but the default values will not be available for > the next entry. This feature is working fine for the simple products like > Tiny Gizmo (Tiny Gizmo). > Most probably values are not getting persisted on the second screen for > variants and configurable products and it is causing the issue. > > > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-9552) Unable to change facility Id in Facility lookup under Inventory Transfer section
[ https://issues.apache.org/jira/browse/OFBIZ-9552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pradeep Choudhary reassigned OFBIZ-9552: Assignee: (was: Pradeep Choudhary) > Unable to change facility Id in Facility lookup under Inventory Transfer > section > > > Key: OFBIZ-9552 > URL: https://issues.apache.org/jira/browse/OFBIZ-9552 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Renuka Srishti >Priority: Major > > 1. Go to Facility component. > 2. Select facility Id and click on submit button. > 3. Here you can see "InventoryXfers" label, click on it. > 4. Now you will redirect to > [https://demo-trunk.ofbiz.apache.org/facility/control/FindFacilityTransfers?facilityId=WebStoreWarehouse] > 5. Click on "Inventory Transfer" button. You will redirect to > [https://demo-trunk.ofbiz.apache.org/facility/control/TransferInventoryItem?facilityId=WebStoreWarehouse] > 6. Here enter inventory item id in the input box which is labeled as > inventory item id and press enter. > 7. Now you will "Inventory Transfer" section. Here click on "To Location" > look up. > First time look up will show "facility Id" label and if you want to change > the facility Id, after one-time search you can't change it. You need to > reopen the look up. > The proposed solution: Facility Id label should remain there after clicking > on Find button in Facility Lookup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11608) Added Item does not exist in the cart when anonymous user revisits the eCommerce store
[ https://issues.apache.org/jira/browse/OFBIZ-11608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pradeep Choudhary updated OFBIZ-11608: -- Summary: Added Item does not exist in the cart when anonymous user revisits the eCommerce store (was: Added Item does not exist in the cart if user (Anonymous user) revisits the eCommerce store) > Added Item does not exist in the cart when anonymous user revisits the > eCommerce store > -- > > Key: OFBIZ-11608 > URL: https://issues.apache.org/jira/browse/OFBIZ-11608 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Release Branch 16.11, Trunk > Environment: [link title|http://example.com] >Reporter: Pradeep Choudhary >Assignee: Pradeep Choudhary >Priority: Minor > > Steps to regenerate: > 1. Set the 'autoSaveCart' field to 'Y' in product_store entity (for Store > 9000). > 2. Open Firefox browser, as it deletes the cookies as soon as the user closes > the browser application. (To reproduce it on chrome, need to disable setting > for 'Continue running background apps when Google Chrome is closed') > 3. Visit the [eCommerce store|https://localhost:8443/ecommerce/control/main] > 4. Add items to the cart without logging in (as an anonymous user) > 5. Close the browser application. > 6. Revisit the eCommerce store. > Actual: > Shopping Cart is showing empty. > Expected: > Previously added items should persist in the item for the anonymous user > also. > Note: > It is working fine, if the user logged In to the application, add items to > cart, closes the application. Revisits the store, previously added items > persist in the cart. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11491) Convert createPaymentAndApplicationForParty service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sourabh Punyani updated OFBIZ-11491: Attachment: OFBIZ-11491.patch > Convert createPaymentAndApplicationForParty service from mini-lang to groovy > DSL > > > Key: OFBIZ-11491 > URL: https://issues.apache.org/jira/browse/OFBIZ-11491 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Sourabh Punyani >Priority: Minor > Attachments: OFBIZ-11491.patch > > > Convert the createPaymentAndApplicationForParty service code from mini-lang > to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11491) Convert createPaymentAndApplicationForParty service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092188#comment-17092188 ] Sourabh Punyani commented on OFBIZ-11491: - Hello Devanshu, I have added a patch (OFBIZ-11491.patch) for the same. Please verify. > Convert createPaymentAndApplicationForParty service from mini-lang to groovy > DSL > > > Key: OFBIZ-11491 > URL: https://issues.apache.org/jira/browse/OFBIZ-11491 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Sourabh Punyani >Priority: Minor > Attachments: OFBIZ-11491.patch > > > Convert the createPaymentAndApplicationForParty service code from mini-lang > to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11608) Added Item does not exist in the cart if user (Anonymous user) revisits the eCommerce store
[ https://issues.apache.org/jira/browse/OFBIZ-11608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pradeep Choudhary reassigned OFBIZ-11608: - Assignee: Pradeep Choudhary > Added Item does not exist in the cart if user (Anonymous user) revisits the > eCommerce store > --- > > Key: OFBIZ-11608 > URL: https://issues.apache.org/jira/browse/OFBIZ-11608 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Release Branch 16.11, Trunk > Environment: [link title|http://example.com] >Reporter: Pradeep Choudhary >Assignee: Pradeep Choudhary >Priority: Minor > > Steps to regenerate: > 1. Set the 'autoSaveCart' field to 'Y' in product_store entity (for Store > 9000). > 2. Open Firefox browser, as it deletes the cookies as soon as the user closes > the browser application. (To reproduce it on chrome, need to disable setting > for 'Continue running background apps when Google Chrome is closed') > 3. Visit the [eCommerce store|https://localhost:8443/ecommerce/control/main] > 4. Add items to the cart without logging in (as an anonymous user) > 5. Close the browser application. > 6. Revisit the eCommerce store. > Actual: > Shopping Cart is showing empty. > Expected: > Previously added items should persist in the item for the anonymous user > also. > Note: > It is working fine, if the user logged In to the application, add items to > cart, closes the application. Revisits the store, previously added items > persist in the cart. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-7739) OFBIZ-7471: Improve all the service level error messages for missing required field for catalog component
[ https://issues.apache.org/jira/browse/OFBIZ-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092187#comment-17092187 ] Ratnesh Upadhyay edited comment on OFBIZ-7739 at 4/25/20, 11:32 AM: I quickly reviewed the patch and it looks to me, thanks [~surajk] for the enhancement and patch for changes. was (Author: upadhyay.ratnesh): I quickly reviewed the patch and it looks to me, thanks [~surajk] for making all these changes. > OFBIZ-7471: Improve all the service level error messages for missing required > field for catalog component > - > > Key: OFBIZ-7739 > URL: https://issues.apache.org/jira/browse/OFBIZ-7739 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: 16.11.01 >Reporter: Ratnesh Upadhyay >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-7739.patch, OFBIZ-7739.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-7739) OFBIZ-7471: Improve all the service level error messages for missing required field for catalog component
[ https://issues.apache.org/jira/browse/OFBIZ-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092187#comment-17092187 ] Ratnesh Upadhyay commented on OFBIZ-7739: - I quickly reviewed the patch and it looks to me, thanks [~surajk] for making all these changes. > OFBIZ-7471: Improve all the service level error messages for missing required > field for catalog component > - > > Key: OFBIZ-7739 > URL: https://issues.apache.org/jira/browse/OFBIZ-7739 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: 16.11.01 >Reporter: Ratnesh Upadhyay >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-7739.patch, OFBIZ-7739.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11550) Convert testUpdateFixedAssetMeter test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aishwary Shrivastava reassigned OFBIZ-11550: Assignee: Aishwary Shrivastava > Convert testUpdateFixedAssetMeter test from XML to Groovy > - > > Key: OFBIZ-11550 > URL: https://issues.apache.org/jira/browse/OFBIZ-11550 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Aishwary Shrivastava >Priority: Minor > > Convert testUpdateFixedAssetMeter test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11573) Incorrect column alias in EntitySQLProcessor for sql query working with mysql
[ https://issues.apache.org/jira/browse/OFBIZ-11573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092186#comment-17092186 ] Pawan Verma commented on OFBIZ-11573: - If nobody has any objections, I'll commit it in a week. Thanks! > Incorrect column alias in EntitySQLProcessor for sql query working with mysql > -- > > Key: OFBIZ-11573 > URL: https://issues.apache.org/jira/browse/OFBIZ-11573 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Major > Attachments: EntitySQLProcessor.png, OFBIZ-11573.patch > > > Steps to reproduce: > # Go to EntitySQLProcessor. > # Try simple SQL query: SELECT PARTY_ID AS customerPartyId FROM PARTY > # See the column alias in the result, it should be the provided one. > # See screenshot for more details. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11356) FindOrders.ftl: paginateOrderList does not find orders on next page
[
https://issues.apache.org/jira/browse/OFBIZ-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankit Joshi reassigned OFBIZ-11356:
---
Assignee: Ankit Joshi
> FindOrders.ftl: paginateOrderList does not find orders on next page
> ---
>
> Key: OFBIZ-11356
> URL: https://issues.apache.org/jira/browse/OFBIZ-11356
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Michael Brohl
>Assignee: Ankit Joshi
>Priority: Critical
>
> Steps to reproduce
> # go to [https://localhost:8443/ordermgr/control/findorders]
> # click "Search" -> 4 entries are displayed
> # got to [https://localhost:8443/ordermgr/control/searchorders?viewSize=1]
> to manipulate the viewSize
> # click "Search" again -> 1 entry is displayed
> # click "Next" (javascript:paginateOrderList('1','1','Y') is triggered
> correctly)
> # the result shows no entries
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11608) Added Item does not exist in the cart if user (Anonymous user) revisits the eCommerce store
[ https://issues.apache.org/jira/browse/OFBIZ-11608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092183#comment-17092183 ] Pradeep Choudhary commented on OFBIZ-11608: --- We have added user login check into 'restoreAutoSaveList' event to fix the authorization error, which is thrown while restoring autoSaveListId for anonymous user. It restricts to restore autoSaveListId only for logged in user. Need to fix authorization issue at the service level instead of restricting it in the event. > Added Item does not exist in the cart if user (Anonymous user) revisits the > eCommerce store > --- > > Key: OFBIZ-11608 > URL: https://issues.apache.org/jira/browse/OFBIZ-11608 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Release Branch 16.11, Trunk > Environment: [link title|http://example.com] >Reporter: Pradeep Choudhary >Priority: Minor > > Steps to regenerate: > 1. Set the 'autoSaveCart' field to 'Y' in product_store entity (for Store > 9000). > 2. Open Firefox browser, as it deletes the cookies as soon as the user closes > the browser application. (To reproduce it on chrome, need to disable setting > for 'Continue running background apps when Google Chrome is closed') > 3. Visit the [eCommerce store|https://localhost:8443/ecommerce/control/main] > 4. Add items to the cart without logging in (as an anonymous user) > 5. Close the browser application. > 6. Revisit the eCommerce store. > Actual: > Shopping Cart is showing empty. > Expected: > Previously added items should persist in the item for the anonymous user > also. > Note: > It is working fine, if the user logged In to the application, add items to > cart, closes the application. Revisits the store, previously added items > persist in the cart. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11608) Added Item does not exist in the cart if user (Anonymous user) revisits the eCommerce store
Pradeep Choudhary created OFBIZ-11608: - Summary: Added Item does not exist in the cart if user (Anonymous user) revisits the eCommerce store Key: OFBIZ-11608 URL: https://issues.apache.org/jira/browse/OFBIZ-11608 Project: OFBiz Issue Type: Improvement Affects Versions: Trunk, Release Branch 16.11 Environment: [link title|http://example.com] Reporter: Pradeep Choudhary Steps to regenerate: 1. Set the 'autoSaveCart' field to 'Y' in product_store entity (for Store 9000). 2. Open Firefox browser, as it deletes the cookies as soon as the user closes the browser application. (To reproduce it on chrome, need to disable setting for 'Continue running background apps when Google Chrome is closed') 3. Visit the [eCommerce store|https://localhost:8443/ecommerce/control/main] 4. Add items to the cart without logging in (as an anonymous user) 5. Close the browser application. 6. Revisit the eCommerce store. Actual: Shopping Cart is showing empty. Expected: Previously added items should persist in the item for the anonymous user also. Note: It is working fine, if the user logged In to the application, add items to cart, closes the application. Revisits the store, previously added items persist in the cart. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11606) Compound-widget not works with condition
[ https://issues.apache.org/jira/browse/OFBIZ-11606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-11606: --- Attachment: OFBIZ-11606_0002-Fixed-getGridFromLocation-not-found-grid-in-a-compou.patch > Compound-widget not works with condition > > > Key: OFBIZ-11606 > URL: https://issues.apache.org/jira/browse/OFBIZ-11606 > Project: OFBiz > Issue Type: Bug > Components: framework/widget >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: Framework, widget > Fix For: Trunk > > Attachments: > OFBIZ-11606_0001-Fixed-Model-Condition-read-the-name-s-nodes-without-.patch, > OFBIZ-11606_0002-Fixed-getGridFromLocation-not-found-grid-in-a-compou.patch > > > After starting to use a Compound-widget.xml file to group all the xml > definitions (controler - menu - screen - form) of a functional resource, I > have found bugs > # # if a form (or grid) has the same name as the screen, the form is not found > > For Bug 1, message is "Condition element not supported with name: xs:if-empty" > After looking commit done when compound-widget have been "create" (xsd, > ExampleCompoundWidgets.xml, autocompletion available, ...) I noticed that a > lot of Element.getNodeName() have been change to > xxxElement.getLocalName() before testing on name. > So on the first patch I have changed all the getNodeName() by getLocalName() > in the ModelXxxxCondition.java, and now there is no more the bug, conditions > works > > For Bug 2. after studyng WidgetFactory no how screens are search and retrieve > and compare to FormFactory and GridFactory, I noticed that > getXxxx*s*FromLocation exist in the three but getXxxxFromLocation (without > 's') use the previous method only for screen, and it's in these methods that > for compoud-widget file root element is node of the file. > So I have done on FormFactory and GridFactory the same thing that for screen. > > Clearly, framework and java are not my expertise, so patch provide are only > done with logical copy-paste, so they need review. > For testing I have tested the file I'm currently done (ExampleWidget.xml) and > running some UI tests to check other screen always works. > Of course, if it's necessary to generate same patch for other branch, I can > do it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11606) Compound-widget not works with condition
[ https://issues.apache.org/jira/browse/OFBIZ-11606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-11606: --- Attachment: (was: OFBIZ-11606_0002-Fixed-getGridFromLocation-not-found-grid-in-a-compou.patch) > Compound-widget not works with condition > > > Key: OFBIZ-11606 > URL: https://issues.apache.org/jira/browse/OFBIZ-11606 > Project: OFBiz > Issue Type: Bug > Components: framework/widget >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: Framework, widget > Fix For: Trunk > > Attachments: > OFBIZ-11606_0001-Fixed-Model-Condition-read-the-name-s-nodes-without-.patch, > OFBIZ-11606_0002-Fixed-getGridFromLocation-not-found-grid-in-a-compou.patch > > > After starting to use a Compound-widget.xml file to group all the xml > definitions (controler - menu - screen - form) of a functional resource, I > have found bugs > # # if a form (or grid) has the same name as the screen, the form is not found > > For Bug 1, message is "Condition element not supported with name: xs:if-empty" > After looking commit done when compound-widget have been "create" (xsd, > ExampleCompoundWidgets.xml, autocompletion available, ...) I noticed that a > lot of Element.getNodeName() have been change to > xxxElement.getLocalName() before testing on name. > So on the first patch I have changed all the getNodeName() by getLocalName() > in the ModelXxxxCondition.java, and now there is no more the bug, conditions > works > > For Bug 2. after studyng WidgetFactory no how screens are search and retrieve > and compare to FormFactory and GridFactory, I noticed that > getXxxx*s*FromLocation exist in the three but getXxxxFromLocation (without > 's') use the previous method only for screen, and it's in these methods that > for compoud-widget file root element is node of the file. > So I have done on FormFactory and GridFactory the same thing that for screen. > > Clearly, framework and java are not my expertise, so patch provide are only > done with logical copy-paste, so they need review. > For testing I have tested the file I'm currently done (ExampleWidget.xml) and > running some UI tests to check other screen always works. > Of course, if it's necessary to generate same patch for other branch, I can > do it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11517) Convert testCancelFixedAssetStdCost test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Hukkeri updated OFBIZ-11517: -- Attachment: (was: OFBIZ-11517.patch) > Convert testCancelFixedAssetStdCost test from XML to Groovy > --- > > Key: OFBIZ-11517 > URL: https://issues.apache.org/jira/browse/OFBIZ-11517 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Rohit Hukkeri >Priority: Minor > Attachments: OFBIZ-11517.patch > > > Convert testCancelFixedAssetStdCost test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11517) Convert testCancelFixedAssetStdCost test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Hukkeri updated OFBIZ-11517: -- Attachment: OFBIZ-11517.patch > Convert testCancelFixedAssetStdCost test from XML to Groovy > --- > > Key: OFBIZ-11517 > URL: https://issues.apache.org/jira/browse/OFBIZ-11517 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Rohit Hukkeri >Priority: Minor > Attachments: OFBIZ-11517.patch > > > Convert testCancelFixedAssetStdCost test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11517) Convert testCancelFixedAssetStdCost test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092170#comment-17092170 ] Rohit Hukkeri commented on OFBIZ-11517: --- Hello [~pawan] , I am attaching the patch for the testCancelFixedAssetStdCost test Thanks! > Convert testCancelFixedAssetStdCost test from XML to Groovy > --- > > Key: OFBIZ-11517 > URL: https://issues.apache.org/jira/browse/OFBIZ-11517 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Rohit Hukkeri >Priority: Minor > Attachments: OFBIZ-11517.patch > > > Convert testCancelFixedAssetStdCost test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11517) Convert testCancelFixedAssetStdCost test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Hukkeri updated OFBIZ-11517: -- Attachment: OFBIZ-11517.patch > Convert testCancelFixedAssetStdCost test from XML to Groovy > --- > > Key: OFBIZ-11517 > URL: https://issues.apache.org/jira/browse/OFBIZ-11517 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Rohit Hukkeri >Priority: Minor > Attachments: OFBIZ-11517.patch > > > Convert testCancelFixedAssetStdCost test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11489) Convert cancelPaymentBatch service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirti Arora reassigned OFBIZ-11489: --- Assignee: Kirti Arora (was: Devanshu Vyas) > Convert cancelPaymentBatch service from mini-lang to groovy DSL > --- > > Key: OFBIZ-11489 > URL: https://issues.apache.org/jira/browse/OFBIZ-11489 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Kirti Arora >Priority: Minor > > Convert the cancelPaymentBatch service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11605) Unable to change Order Status
[ https://issues.apache.org/jira/browse/OFBIZ-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rahul Marjiwe updated OFBIZ-11605: -- Attachment: OFBIZ-11605.patch > Unable to change Order Status > -- > > Key: OFBIZ-11605 > URL: https://issues.apache.org/jira/browse/OFBIZ-11605 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Rahul Marjiwe >Assignee: Rahul Marjiwe >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-11605.patch > > > Step to generate: > # Go to the order manager and select the order entry menu. > # select the supplier for a purchase order and click on continue. > # In Create Purchase Order screen add any product Id, quantity, and click > on add to order. > # Click on Finalize order and continue. > # On Purchase Order : Order Entry Ship-To Settings click on continue. > # For order notes and additional party-id click on continue. > # In order-confirmation screen click on Create Order button. > # In orderview screen click on approve order button. > Actual: it is rendering the error message after click on approve order > button. > Expected: Change order status created to approve. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11369) Convert findAssocContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092166#comment-17092166 ] Devanshu Vyas commented on OFBIZ-11369: --- [~prakhar.kumar], I did a review of your patch and the first thing I noticed is that the validations on the service input parameters were removed. I think they should remain as is. > Convert findAssocContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11369 > URL: https://issues.apache.org/jira/browse/OFBIZ-11369 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Prakhar Kumar >Priority: Minor > Attachments: OFBIZ-11369.patch > > > Convert findAssocContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11485) Convert getInvoicePaymentInfoList service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma reassigned OFBIZ-11485: Assignee: Priya Sharma (was: Devanshu Vyas) > Convert getInvoicePaymentInfoList service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11485 > URL: https://issues.apache.org/jira/browse/OFBIZ-11485 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > > Convert the getInvoicePaymentInfoList service code from mini-lang to groovy > DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11607) Enhance Groovy and Simple Event Handler to support transaction timout
[ https://issues.apache.org/jira/browse/OFBIZ-11607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi reassigned OFBIZ-11607: -- Assignee: (was: Ravi Lodhi) > Enhance Groovy and Simple Event Handler to support transaction timout > - > > Key: OFBIZ-11607 > URL: https://issues.apache.org/jira/browse/OFBIZ-11607 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Ravi Lodhi >Priority: Minor > > When we call an event (java, groovy or simple), and if it takes a too long > time we got a transaction timeout error. Support to set a non-default > transaction-timeout for an event is already added in > [OFBIZ-8160|https://issues.apache.org/jira/browse/OFBIZ-8160]. > JavaEventHandler is already enhanced to honor that transaction timeout. This > effort is to enhance GroovyEventHandler and SimpleEventHandler to consider > the transaction timeout set via event tag of the controller entry if provided > otherwise it will work with the default transaction timeout. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11607) Enhance Groovy and Simple Event Handler to support transaction timout
[ https://issues.apache.org/jira/browse/OFBIZ-11607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-11607: --- Affects Version/s: (was: 17.12.02) (was: 16.11.07) (was: 18.12.01) > Enhance Groovy and Simple Event Handler to support transaction timout > - > > Key: OFBIZ-11607 > URL: https://issues.apache.org/jira/browse/OFBIZ-11607 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi >Priority: Minor > > When we call an event (java, groovy or simple), and if it takes a too long > time we got a transaction timeout error. Support to set a non-default > transaction-timeout for an event is already added in > [OFBIZ-8160|https://issues.apache.org/jira/browse/OFBIZ-8160]. > JavaEventHandler is already enhanced to honor that transaction timeout. This > effort is to enhance GroovyEventHandler and SimpleEventHandler to consider > the transaction timeout set via event tag of the controller entry if provided > otherwise it will work with the default transaction timeout. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11607) Enhance Groovy and Simple Event Handler to support transaction timout
[ https://issues.apache.org/jira/browse/OFBIZ-11607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092159#comment-17092159 ] Ravi Lodhi commented on OFBIZ-11607: Here is the PR for trunk- [https://github.com/apache/ofbiz-framework/pull/77] > Enhance Groovy and Simple Event Handler to support transaction timout > - > > Key: OFBIZ-11607 > URL: https://issues.apache.org/jira/browse/OFBIZ-11607 > Project: OFBiz > Issue Type: Improvement >Affects Versions: 16.11.07, 18.12.01, 17.12.02, Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi >Priority: Minor > > When we call an event (java, groovy or simple), and if it takes a too long > time we got a transaction timeout error. Support to set a non-default > transaction-timeout for an event is already added in > [OFBIZ-8160|https://issues.apache.org/jira/browse/OFBIZ-8160]. > JavaEventHandler is already enhanced to honor that transaction timeout. This > effort is to enhance GroovyEventHandler and SimpleEventHandler to consider > the transaction timeout set via event tag of the controller entry if provided > otherwise it will work with the default transaction timeout. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #77: Improved: Added support to consider non-default transaction timeout for Groovy and Simple event handlers.(OFBIZ-11607)
sonarcloud[bot] commented on pull request #77: URL: https://github.com/apache/ofbiz-framework/pull/77#issuecomment-619351189 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=77=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=77=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=77=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=77=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=77=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=77=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=77=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=77=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=77=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=77=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=77=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=77) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=77=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] ravilodhi opened a new pull request #77: Improved: Added support to consider non-default transaction timeout for Groovy and Simple event handlers.(OFBIZ-11607)
ravilodhi opened a new pull request #77: URL: https://github.com/apache/ofbiz-framework/pull/77 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (OFBIZ-11547) Convert testUpdateFixedAssetRegistration test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anushi Gupta reassigned OFBIZ-11547: Assignee: Anushi Gupta > Convert testUpdateFixedAssetRegistration test from XML to Groovy > > > Key: OFBIZ-11547 > URL: https://issues.apache.org/jira/browse/OFBIZ-11547 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Anushi Gupta >Priority: Minor > > Convert testUpdateFixedAssetRegistration test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11546) Convert testCreateFixedAssetRegistration test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anushi Gupta reassigned OFBIZ-11546: Assignee: Anushi Gupta > Convert testCreateFixedAssetRegistration test from XML to Groovy > > > Key: OFBIZ-11546 > URL: https://issues.apache.org/jira/browse/OFBIZ-11546 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Anushi Gupta >Priority: Minor > > Convert testCreateFixedAssetRegistration test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11607) Enhance Groovy and Simple Event Handler to support transaction timout
Ravi Lodhi created OFBIZ-11607: -- Summary: Enhance Groovy and Simple Event Handler to support transaction timout Key: OFBIZ-11607 URL: https://issues.apache.org/jira/browse/OFBIZ-11607 Project: OFBiz Issue Type: Improvement Affects Versions: Trunk, 17.12.02, 16.11.07, 18.12.01 Reporter: Ravi Lodhi Assignee: Ravi Lodhi When we call an event (java, groovy or simple), and if it takes a too long time we got a transaction timeout error. Support to set a non-default transaction-timeout for an event is already added in [OFBIZ-8160|https://issues.apache.org/jira/browse/OFBIZ-8160]. JavaEventHandler is already enhanced to honor that transaction timeout. This effort is to enhance GroovyEventHandler and SimpleEventHandler to consider the transaction timeout set via event tag of the controller entry if provided otherwise it will work with the default transaction timeout. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11520) Convert testCreateFixedAssetMeter test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Hukkeri reassigned OFBIZ-11520: - Assignee: Rohit Hukkeri > Convert testCreateFixedAssetMeter test from XML to Groovy > - > > Key: OFBIZ-11520 > URL: https://issues.apache.org/jira/browse/OFBIZ-11520 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Rohit Hukkeri >Priority: Minor > > Convert testCreateFixedAssetMeter test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11519) Convert testCreateFixedAssetMaint test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Hukkeri reassigned OFBIZ-11519: - Assignee: Rohit Hukkeri > Convert testCreateFixedAssetMaint test from XML to Groovy > - > > Key: OFBIZ-11519 > URL: https://issues.apache.org/jira/browse/OFBIZ-11519 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Rohit Hukkeri >Priority: Minor > > Convert testCreateFixedAssetMaint test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11517) Convert testCancelFixedAssetStdCost test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Hukkeri reassigned OFBIZ-11517: - Assignee: Rohit Hukkeri > Convert testCancelFixedAssetStdCost test from XML to Groovy > --- > > Key: OFBIZ-11517 > URL: https://issues.apache.org/jira/browse/OFBIZ-11517 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Rohit Hukkeri >Priority: Minor > > Convert testCancelFixedAssetStdCost test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11568) Convert testExpirePartyRate test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rushikesh Mawal reassigned OFBIZ-11568: --- Assignee: Rushikesh Mawal > Convert testExpirePartyRate test from XML to Groovy > --- > > Key: OFBIZ-11568 > URL: https://issues.apache.org/jira/browse/OFBIZ-11568 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Rushikesh Mawal >Priority: Major > > Convert testExpirePartyRate test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11480) Convert updatePayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092140#comment-17092140 ] Priya Sharma commented on OFBIZ-11480: -- Hello All, I have added a patch for the groovy implementation of this service. The patch contains the following changes: * removed the minilang implementation of the service * added the groovy implementation, keeping the logic just same * updated the service definition could someone please review it? > Convert updatePayment service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11480 > URL: https://issues.apache.org/jira/browse/OFBIZ-11480 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11480.patch > > > Convert the updatePayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11480) Convert updatePayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma updated OFBIZ-11480: - Attachment: OFBIZ-11480.patch > Convert updatePayment service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11480 > URL: https://issues.apache.org/jira/browse/OFBIZ-11480 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11480.patch > > > Convert the updatePayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-7739) OFBIZ-7471: Improve all the service level error messages for missing required field for catalog component
[ https://issues.apache.org/jira/browse/OFBIZ-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-7739: - Attachment: OFBIZ-7739.patch > OFBIZ-7471: Improve all the service level error messages for missing required > field for catalog component > - > > Key: OFBIZ-7739 > URL: https://issues.apache.org/jira/browse/OFBIZ-7739 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: 16.11.01 >Reporter: Ratnesh Upadhyay >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-7739.patch, OFBIZ-7739.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-7739) OFBIZ-7471: Improve all the service level error messages for missing required field for catalog component
[ https://issues.apache.org/jira/browse/OFBIZ-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092138#comment-17092138 ] Suraj Khurana commented on OFBIZ-7739: -- I checked and some of the fixes from this patch are already committed in codebase in other efforts. Few remaining enhancements are remaining and I have added patch for the same. > OFBIZ-7471: Improve all the service level error messages for missing required > field for catalog component > - > > Key: OFBIZ-7739 > URL: https://issues.apache.org/jira/browse/OFBIZ-7739 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: 16.11.01 >Reporter: Ratnesh Upadhyay >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-7739.patch, OFBIZ-7739.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11369) Convert findAssocContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092137#comment-17092137 ] Mridul Pathak commented on OFBIZ-11369: --- Hi [~prakhar.kumar], Please use iterator for mapKeys as in original simple method. IN operator could end up giving performance issues for heavily populated ContentAssoc entity. > Convert findAssocContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11369 > URL: https://issues.apache.org/jira/browse/OFBIZ-11369 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Prakhar Kumar >Priority: Minor > Attachments: OFBIZ-11369.patch > > > Convert findAssocContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11371) Convert updateEmailContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anushi Gupta updated OFBIZ-11371: - Attachment: OFBIZ-11371.patch > Convert updateEmailContent service from mini-lang to groovy DSL > --- > > Key: OFBIZ-11371 > URL: https://issues.apache.org/jira/browse/OFBIZ-11371 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11371.patch, OFBIZ-11371.patch > > > Convert updateEmailContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11371) Convert updateEmailContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092130#comment-17092130 ] Anushi Gupta commented on OFBIZ-11371: -- Hii, [~pawan] Thanks for your input. Updated the patch > Convert updateEmailContent service from mini-lang to groovy DSL > --- > > Key: OFBIZ-11371 > URL: https://issues.apache.org/jira/browse/OFBIZ-11371 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11371.patch, OFBIZ-11371.patch > > > Convert updateEmailContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11371) Convert updateEmailContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092130#comment-17092130 ] Anushi Gupta edited comment on OFBIZ-11371 at 4/25/20, 8:29 AM: Hi [~pawan] Thanks for your input. Updated the patch was (Author: anushi.gupta10): Hii, [~pawan] Thanks for your input. Updated the patch > Convert updateEmailContent service from mini-lang to groovy DSL > --- > > Key: OFBIZ-11371 > URL: https://issues.apache.org/jira/browse/OFBIZ-11371 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11371.patch, OFBIZ-11371.patch > > > Convert updateEmailContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-7739) OFBIZ-7471: Improve all the service level error messages for missing required field for catalog component
[ https://issues.apache.org/jira/browse/OFBIZ-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-7739: Assignee: Suraj Khurana > OFBIZ-7471: Improve all the service level error messages for missing required > field for catalog component > - > > Key: OFBIZ-7739 > URL: https://issues.apache.org/jira/browse/OFBIZ-7739 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: 16.11.01 >Reporter: Ratnesh Upadhyay >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-7739.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-9909) Marketing campaigns are not listed out within the given date range in Reports section
[ https://issues.apache.org/jira/browse/OFBIZ-9909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-9909: Assignee: Suraj Khurana > Marketing campaigns are not listed out within the given date range in Reports > section > - > > Key: OFBIZ-9909 > URL: https://issues.apache.org/jira/browse/OFBIZ-9909 > Project: OFBiz > Issue Type: Bug > Components: marketing > Environment: demo-trunk.ofbiz.apache.org >Reporter: Rubia Elza Joshep >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-9909.patch > > > Steps- > 1) Open URL > https://demo-trunk.ofbiz.apache.org/marketing/control/MarketingCampaignReport > 2) In marketing component, click "Reports' > 3) Navigate to marketing campaign report, set the from date and through date > and click on "Run Marketing Campaign Report" > Expected: All the marketing campaign should be listed out within the given > date range > Actual: Marketing campaigns are not listed out within the given date range -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-7471) Improve all the service level error messages for missing required field
[
https://issues.apache.org/jira/browse/OFBIZ-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Suraj Khurana reassigned OFBIZ-7471:
Assignee: Suraj Khurana (was: Divesh Dutta)
> Improve all the service level error messages for missing required field
> ---
>
> Key: OFBIZ-7471
> URL: https://issues.apache.org/jira/browse/OFBIZ-7471
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: 16.11.01, Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: ErrorMsgReturnedByServiceEngine.png, ImprovedUFMsgs.png
>
>
> Currently when a user submits a form with missing required fields, for
> instance creating a contactMech (Postal Address) from party profile screen.
> Here, in such scenarios the service engine returns missing field error
> message as:
> {code}
> The Following Errors Occurred:
> The following required parameter is missing:
> [createPartyPostalAddress.city]
> The following required parameter is missing:
> [createPartyPostalAddress.address1]
> The following required parameter is missing:
> [createPartyPostalAddress.postalCode]
> {code}
> Such error messages can be improved across the application by making it more
> user friendly like:
> {code}
> Required Field Missing : Address Line 1.
> Required Field Missing : City.
> Required Field Missing : Postal Code.
> {code}
> I'll review similar scenarios across the application.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11562) Convert testExpireRateAmount test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shivanand Chhatre reassigned OFBIZ-11562: - Assignee: Shivanand Chhatre > Convert testExpireRateAmount test from XML to Groovy > > > Key: OFBIZ-11562 > URL: https://issues.apache.org/jira/browse/OFBIZ-11562 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Shivanand Chhatre >Priority: Minor > > Convert testExpireRateAmount test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11606) Compound-widget not works with condition
[ https://issues.apache.org/jira/browse/OFBIZ-11606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz reassigned OFBIZ-11606: -- Assignee: (was: Olivier Heintz) > Compound-widget not works with condition > > > Key: OFBIZ-11606 > URL: https://issues.apache.org/jira/browse/OFBIZ-11606 > Project: OFBiz > Issue Type: Bug > Components: framework/widget >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: Framework, widget > Fix For: Trunk > > Attachments: > OFBIZ-11606_0001-Fixed-Model-Condition-read-the-name-s-nodes-without-.patch, > OFBIZ-11606_0002-Fixed-getGridFromLocation-not-found-grid-in-a-compou.patch > > > After starting to use a Compound-widget.xml file to group all the xml > definitions (controler - menu - screen - form) of a functional resource, I > have found bugs > # # if a form (or grid) has the same name as the screen, the form is not found > > For Bug 1, message is "Condition element not supported with name: xs:if-empty" > After looking commit done when compound-widget have been "create" (xsd, > ExampleCompoundWidgets.xml, autocompletion available, ...) I noticed that a > lot of Element.getNodeName() have been change to > xxxElement.getLocalName() before testing on name. > So on the first patch I have changed all the getNodeName() by getLocalName() > in the ModelXxxxCondition.java, and now there is no more the bug, conditions > works > > For Bug 2. after studyng WidgetFactory no how screens are search and retrieve > and compare to FormFactory and GridFactory, I noticed that > getXxxx*s*FromLocation exist in the three but getXxxxFromLocation (without > 's') use the previous method only for screen, and it's in these methods that > for compoud-widget file root element is node of the file. > So I have done on FormFactory and GridFactory the same thing that for screen. > > Clearly, framework and java are not my expertise, so patch provide are only > done with logical copy-paste, so they need review. > For testing I have tested the file I'm currently done (ExampleWidget.xml) and > running some UI tests to check other screen always works. > Of course, if it's necessary to generate same patch for other branch, I can > do it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11606) Compound-widget not works with condition
[
https://issues.apache.org/jira/browse/OFBIZ-11606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092120#comment-17092120
]
Olivier Heintz commented on OFBIZ-11606:
Patch have been generate by {{git format-patch}}, so to apply them do {{git
am}} _patch_name_
> Compound-widget not works with condition
>
>
> Key: OFBIZ-11606
> URL: https://issues.apache.org/jira/browse/OFBIZ-11606
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Minor
> Labels: Framework, widget
> Fix For: Trunk
>
> Attachments:
> OFBIZ-11606_0001-Fixed-Model-Condition-read-the-name-s-nodes-without-.patch,
> OFBIZ-11606_0002-Fixed-getGridFromLocation-not-found-grid-in-a-compou.patch
>
>
> After starting to use a Compound-widget.xml file to group all the xml
> definitions (controler - menu - screen - form) of a functional resource, I
> have found bugs
> # # if a form (or grid) has the same name as the screen, the form is not found
>
> For Bug 1, message is "Condition element not supported with name: xs:if-empty"
> After looking commit done when compound-widget have been "create" (xsd,
> ExampleCompoundWidgets.xml, autocompletion available, ...) I noticed that a
> lot of Element.getNodeName() have been change to
> xxxElement.getLocalName() before testing on name.
> So on the first patch I have changed all the getNodeName() by getLocalName()
> in the ModelXxxxCondition.java, and now there is no more the bug, conditions
> works
>
> For Bug 2. after studyng WidgetFactory no how screens are search and retrieve
> and compare to FormFactory and GridFactory, I noticed that
> getXxxx*s*FromLocation exist in the three but getXxxxFromLocation (without
> 's') use the previous method only for screen, and it's in these methods that
> for compoud-widget file root element is node of the file.
> So I have done on FormFactory and GridFactory the same thing that for screen.
>
> Clearly, framework and java are not my expertise, so patch provide are only
> done with logical copy-paste, so they need review.
> For testing I have tested the file I'm currently done (ExampleWidget.xml) and
> running some UI tests to check other screen always works.
> Of course, if it's necessary to generate same patch for other branch, I can
> do it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11606) Compound-widget not works with condition
[ https://issues.apache.org/jira/browse/OFBIZ-11606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-11606: --- Attachment: OFBIZ-11606_0001-Fixed-Model-Condition-read-the-name-s-nodes-without-.patch OFBIZ-11606_0002-Fixed-getGridFromLocation-not-found-grid-in-a-compou.patch > Compound-widget not works with condition > > > Key: OFBIZ-11606 > URL: https://issues.apache.org/jira/browse/OFBIZ-11606 > Project: OFBiz > Issue Type: Bug > Components: framework/widget >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Olivier Heintz >Priority: Minor > Labels: Framework, widget > Fix For: Trunk > > Attachments: > OFBIZ-11606_0001-Fixed-Model-Condition-read-the-name-s-nodes-without-.patch, > OFBIZ-11606_0002-Fixed-getGridFromLocation-not-found-grid-in-a-compou.patch > > > After starting to use a Compound-widget.xml file to group all the xml > definitions (controler - menu - screen - form) of a functional resource, I > have found bugs > # # if a form (or grid) has the same name as the screen, the form is not found > > For Bug 1, message is "Condition element not supported with name: xs:if-empty" > After looking commit done when compound-widget have been "create" (xsd, > ExampleCompoundWidgets.xml, autocompletion available, ...) I noticed that a > lot of Element.getNodeName() have been change to > xxxElement.getLocalName() before testing on name. > So on the first patch I have changed all the getNodeName() by getLocalName() > in the ModelXxxxCondition.java, and now there is no more the bug, conditions > works > > For Bug 2. after studyng WidgetFactory no how screens are search and retrieve > and compare to FormFactory and GridFactory, I noticed that > getXxxx*s*FromLocation exist in the three but getXxxxFromLocation (without > 's') use the previous method only for screen, and it's in these methods that > for compoud-widget file root element is node of the file. > So I have done on FormFactory and GridFactory the same thing that for screen. > > Clearly, framework and java are not my expertise, so patch provide are only > done with logical copy-paste, so they need review. > For testing I have tested the file I'm currently done (ExampleWidget.xml) and > running some UI tests to check other screen always works. > Of course, if it's necessary to generate same patch for other branch, I can > do it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11488) Convert getPaymentRunningTotal service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092117#comment-17092117 ] Nitish Mishra commented on OFBIZ-11488: --- [~devanshu.vyas], Thanks for the review. I have done the changes and updated the patch. > Convert getPaymentRunningTotal service from mini-lang to groovy DSL > --- > > Key: OFBIZ-11488 > URL: https://issues.apache.org/jira/browse/OFBIZ-11488 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Priority: Minor > Attachments: OFBIZ-11488.patch > > > Convert the getPaymentRunningTotal service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11488) Convert getPaymentRunningTotal service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitish Mishra updated OFBIZ-11488: -- Attachment: (was: OFBIZ-11488.patch) > Convert getPaymentRunningTotal service from mini-lang to groovy DSL > --- > > Key: OFBIZ-11488 > URL: https://issues.apache.org/jira/browse/OFBIZ-11488 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Priority: Minor > Attachments: OFBIZ-11488.patch > > > Convert the getPaymentRunningTotal service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11488) Convert getPaymentRunningTotal service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitish Mishra updated OFBIZ-11488: -- Attachment: OFBIZ-11488.patch > Convert getPaymentRunningTotal service from mini-lang to groovy DSL > --- > > Key: OFBIZ-11488 > URL: https://issues.apache.org/jira/browse/OFBIZ-11488 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Priority: Minor > Attachments: OFBIZ-11488.patch > > > Convert the getPaymentRunningTotal service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11488) Convert getPaymentRunningTotal service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092116#comment-17092116 ] Devanshu Vyas commented on OFBIZ-11488: --- [~nitish.mishra], I did a cursory review of your patch and you have forgotten to remove the simple-method implementation of the service in this patch. > Convert getPaymentRunningTotal service from mini-lang to groovy DSL > --- > > Key: OFBIZ-11488 > URL: https://issues.apache.org/jira/browse/OFBIZ-11488 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Priority: Minor > Attachments: OFBIZ-11488.patch > > > Convert the getPaymentRunningTotal service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #76: Fixed: EntityQuery queryCount is throwing error with distinct method
sonarcloud[bot] commented on pull request #76: URL: https://github.com/apache/ofbiz-framework/pull/76#issuecomment-619337053 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=76=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=76) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=76=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=76=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11294) EntityQuery queryCount is throwing error with distinct method
[
https://issues.apache.org/jira/browse/OFBIZ-11294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092115#comment-17092115
]
Pawan Verma commented on OFBIZ-11294:
-
I've tried to fix it in PR: [https://github.com/apache/ofbiz-framework/pull/76]
Please review and let me your your thoughts. Thanks!
> EntityQuery queryCount is throwing error with distinct method
> -
>
> Key: OFBIZ-11294
> URL: https://issues.apache.org/jira/browse/OFBIZ-11294
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release
> Branch 17.12, Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Major
>
> We have a bug/missing support for distinct when used with queryCount method
> of EntityQuery.
> Below is the more detail
> {code:java}
> EntityCondition cond = EntityCondition.makeCondition(UtilMisc.toList(
> EntityCondition.makeCondition("locationSeqId", "00test123"),
> EntityCondition.makeCondition("facilityId", EntityOperator.EQUALS,
> "10070"),
> EntityCondition.makeCondition("quantityOnHandTotal",
> EntityOperator.GREATER_THAN, BigDecimal.ZERO)),
> EntityOperator.AND);{code}
> *Case 1:* queryList().size() with distinct
> {code:java}
> int productAtLocation =
> EntityQuery.use(delegator).select("productId").from("InventoryItem")
> .where(cond).maxRows(2).distinct().queryList().size();{code}
> Result Query: SELECT DISTINCT PRODUCT_ID FROM INVENTORY_ITEM WHERE
> ((LOCATION_SEQ_ID = ? AND FACILITY_ID = ? AND QUANTITY_ON_HAND_TOTAL > ?))
> Result: This case works well.
> *Case 2:* queryCount without distinct
> {code:java}
> Long testCount =
> EntityQuery.use(delegator).select("productId").from("InventoryItem")
> .where(cond).maxRows(2).queryCount();{code}
> Result Query: SELECT COUNT(1) FROM INVENTORY_ITEM WHERE ((LOCATION_SEQ_ID =
> ? AND FACILITY_ID = ? AND QUANTITY_ON_HAND_TOTAL > ?))
> Result: This case also works well
> *Case 3:* queryCount with distinct
> {code:java}
> Long testCount =
> EntityQuery.use(delegator).select("productId").from("InventoryItem")
> .where(cond).maxRows(2).queryCount();{code}
> Result Query: SELECT COUNT(DISTINCT *) FROM INVENTORY_ITEM WHERE
> ((LOCATION_SEQ_ID = ? AND FACILITY_ID = ? AND QUANTITY_ON_HAND_TOTAL > ?))
> Result: This case throw an error
> org.apache.ofbiz.entity.GenericDataSourceException: SQL Exception while
> executing the following:SELECT COUNT(DISTINCT *) FROM OFBIZ.INVENTORY_ITEM
> (Syntax error: Encountered "*" at line 1, column 23.)
>
> *Below is the research I have done for the issue:*
> In EntityQuery.queryCount(), return method is
> delegator.findCountByCondition(). This method doesn't have support for
> fieldsToSelect.
> When we reach till GenericDAO.selectCountByCondition() at line 949,
> returning method is setting *null* for selectFields.
> And at the implementation of selectCountByCondition, at line 994 we have a
> check for selectFields, that's why we are having *COUNT(DISTINCT *)* in our
> query.
>
> *To test this, I have used a simple way:*
> Just include below code at any groovy file and run it:
> {code:java}
> testCount = select("productId").from("InventoryItem").distinct().queryCount()
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [ofbiz-framework] verma-pawan opened a new pull request #76: Fixed: EntityQuery queryCount is throwing error with distinct method
verma-pawan opened a new pull request #76: URL: https://github.com/apache/ofbiz-framework/pull/76 (OFBIZ-11294) Added missing support for selectFields in queryCount and all the subsequent methods. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (OFBIZ-11488) Convert getPaymentRunningTotal service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitish Mishra reassigned OFBIZ-11488: - Assignee: (was: Nitish Mishra) > Convert getPaymentRunningTotal service from mini-lang to groovy DSL > --- > > Key: OFBIZ-11488 > URL: https://issues.apache.org/jira/browse/OFBIZ-11488 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Priority: Minor > Attachments: OFBIZ-11488.patch > > > Convert the getPaymentRunningTotal service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11488) Convert getPaymentRunningTotal service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092112#comment-17092112 ] Nitish Mishra commented on OFBIZ-11488: --- I have converted the service *getPaymentRunningTotal* from mini-lang to groocy DSL. Added the patch on the ticket. > Convert getPaymentRunningTotal service from mini-lang to groovy DSL > --- > > Key: OFBIZ-11488 > URL: https://issues.apache.org/jira/browse/OFBIZ-11488 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Nitish Mishra >Priority: Minor > Attachments: OFBIZ-11488.patch > > > Convert the getPaymentRunningTotal service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11488) Convert getPaymentRunningTotal service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitish Mishra updated OFBIZ-11488: -- Attachment: OFBIZ-11488.patch > Convert getPaymentRunningTotal service from mini-lang to groovy DSL > --- > > Key: OFBIZ-11488 > URL: https://issues.apache.org/jira/browse/OFBIZ-11488 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Nitish Mishra >Priority: Minor > Attachments: OFBIZ-11488.patch > > > Convert the getPaymentRunningTotal service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11606) Compound-widget not works with condition
Olivier Heintz created OFBIZ-11606: -- Summary: Compound-widget not works with condition Key: OFBIZ-11606 URL: https://issues.apache.org/jira/browse/OFBIZ-11606 Project: OFBiz Issue Type: Bug Components: framework/widget Affects Versions: Trunk Reporter: Olivier Heintz Assignee: Olivier Heintz Fix For: Trunk After starting to use a Compound-widget.xml file to group all the xml definitions (controler - menu - screen - form) of a functional resource, I have found bugs #
[jira] [Commented] (OFBIZ-11145) Add Party Content does not create new content
[
https://issues.apache.org/jira/browse/OFBIZ-11145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092109#comment-17092109
]
Pawan Verma commented on OFBIZ-11145:
-
I tried to test it on the latest trunk and it works well when uploaded a
file(I've tried it with small one). Without file we get a console error:
{color:#de350b}org.apache.ofbiz.entity.transaction.GenericTransactionException:
Roll back error, could not commit transaction, was rolled back instead because
of: Error in simple-method [Attach an uploaded file to a data resource as
LOCAL_FILE
[file:/home/pawan/ofbiz_dev/trunk/applications/content/minilang/data/DataServices.xml#saveLocalFileDataResource]]:
; [No uploaded content found in context] {color}
> Add Party Content does not create new content
> -
>
> Key: OFBIZ-11145
> URL: https://issues.apache.org/jira/browse/OFBIZ-11145
> Project: OFBiz
> Issue Type: Bug
> Components: party
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Rahul Chohal
>Priority: Major
>
> Steps to regenerate:
> # Login into Partymgr component.
> # Select any party and go to Party Content tab
> # Under form *Add Party Content,* fill details and try to create content
> This works on demo-stable.ofbiz.apache.org but not on
> demo-trunk.ofbiz.apache.org.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11443) Convert FixedAssetMaintServices.xml to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092095#comment-17092095 ] Rohit Koushal commented on OFBIZ-11443: --- Here is the patch in which FixedAssetMaintServices minilang is converted into its respective groovy logic. [^OFBIZ-11443.patch] > Convert FixedAssetMaintServices.xml to groovy > - > > Key: OFBIZ-11443 > URL: https://issues.apache.org/jira/browse/OFBIZ-11443 > Project: OFBiz > Issue Type: Sub-task > Components: assetmaint >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Rohit Koushal >Priority: Major > Labels: refactoring > Attachments: OFBIZ-11443.patch > > > Convert from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11443) Convert FixedAssetMaintServices.xml to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-11443: -- Attachment: OFBIZ-11443.patch > Convert FixedAssetMaintServices.xml to groovy > - > > Key: OFBIZ-11443 > URL: https://issues.apache.org/jira/browse/OFBIZ-11443 > Project: OFBiz > Issue Type: Sub-task > Components: assetmaint >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Rohit Koushal >Priority: Major > Labels: refactoring > Attachments: OFBIZ-11443.patch > > > Convert from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11513) Convert testCreateFinAccountTrans test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11513. --- Fix Version/s: Upcoming Branch Resolution: Implemented Thanks, [~rohit.hukkeri]! > Convert testCreateFinAccountTrans test from XML to Groovy > - > > Key: OFBIZ-11513 > URL: https://issues.apache.org/jira/browse/OFBIZ-11513 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > > Convert testCreateFinAccountTrans test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11515) Convert testCreateFinAccountAuth test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11515. --- Fix Version/s: Upcoming Branch Resolution: Implemented Thanks, [~rohit.hukkeri]! > Convert testCreateFinAccountAuth test from XML to Groovy > > > Key: OFBIZ-11515 > URL: https://issues.apache.org/jira/browse/OFBIZ-11515 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > > Convert testCreateFinAccountAuth test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11516) Convert setFinAccountTransStatus test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11516. --- Fix Version/s: Upcoming Branch Resolution: Implemented Thanks, [~rohit.hukkeri]! > Convert setFinAccountTransStatus test from XML to Groovy > > > Key: OFBIZ-11516 > URL: https://issues.apache.org/jira/browse/OFBIZ-11516 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > > Convert setFinAccountTransStatus test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11514) Convert testCreateFinAccountStatus test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11514. --- Fix Version/s: Upcoming Branch Resolution: Implemented Thanks, [~rohit.hukkeri]! > Convert testCreateFinAccountStatus test from XML to Groovy > -- > > Key: OFBIZ-11514 > URL: https://issues.apache.org/jira/browse/OFBIZ-11514 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > > Convert testCreateFinAccountStatus test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11512) Convert testDeleteFinAccountRole test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11512. --- Fix Version/s: Upcoming Branch Resolution: Implemented Thanks, [~rohit.hukkeri]! > Convert testDeleteFinAccountRole test from XML to Groovy > > > Key: OFBIZ-11512 > URL: https://issues.apache.org/jira/browse/OFBIZ-11512 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > > Convert testDeleteFinAccountRole test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
