[jira] [Assigned] (OFBIZ-11537) Convert testCancelInvoice test from XML to Groovy

2020-05-23 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-11537:
---

Assignee: Pawan Verma  (was: Praveen Sharma)

> Convert testCancelInvoice test from XML to Groovy
> -
>
> Key: OFBIZ-11537
> URL: https://issues.apache.org/jira/browse/OFBIZ-11537
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11537.patch
>
>
> Convert testCancelInvoice test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11736) RuntimeException in getPartyNameForDate service

2020-05-23 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma closed OFBIZ-11736.
---
Fix Version/s: Upcoming Branch
   Resolution: Fixed

> RuntimeException in getPartyNameForDate service
> ---
>
> Key: OFBIZ-11736
> URL: https://issues.apache.org/jira/browse/OFBIZ-11736
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Major
> Fix For: Upcoming Branch
>
>
> We are getting this error on FindORder and findInvoice screen:
> Error running Groovy method [getPartyNameForDate] in Groovy file 
> [component://party/groovyScripts/party/PartyServices.groovy]: (The field name 
> (or key) [gender] is not valid for entity [PartyNameHistory].) (Error running 
> Groovy method [getPartyNameForDate] in Groovy file



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11736) RuntimeException in getPartyNameForDate service

2020-05-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114910#comment-17114910
 ] 

ASF subversion and git services commented on OFBIZ-11736:
-

Commit 3f9e37797ac19932ab1c5fa836e6d9819096c868 in ofbiz-framework's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3f9e377 ]

Fixed: RuntimeException in getPartyNameForDate service for 
partyNameHistory.gender field(OFBIZ-11736)

The reason for this issue is code is trying to get the gender of person from 
partyNameHistory record and gender is not a field in partyNameHistory entity. 
During conversion we minimized duplicate code which caused that issue.

I've added a check to avoid checking gender in partyNameHistory record.


> RuntimeException in getPartyNameForDate service
> ---
>
> Key: OFBIZ-11736
> URL: https://issues.apache.org/jira/browse/OFBIZ-11736
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Major
>
> We are getting this error on FindORder and findInvoice screen:
> Error running Groovy method [getPartyNameForDate] in Groovy file 
> [component://party/groovyScripts/party/PartyServices.groovy]: (The field name 
> (or key) [gender] is not valid for entity [PartyNameHistory].) (Error running 
> Groovy method [getPartyNameForDate] in Groovy file



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11736) RuntimeException in getPartyNameForDate service

2020-05-23 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114906#comment-17114906
 ] 

Pawan Verma commented on OFBIZ-11736:
-

This is a valid issue since the conversion of PartyService from XML to Groovy.

In Groovy code we are fetching gender from *PartyNameHistory* entity and that 
entity doesn't have gender as a field.

In XML it was person.gender

The conversion was done under OFBIZ-11361.

> RuntimeException in getPartyNameForDate service
> ---
>
> Key: OFBIZ-11736
> URL: https://issues.apache.org/jira/browse/OFBIZ-11736
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Major
>
> We are getting this error on FindORder and findInvoice screen:
> Error running Groovy method [getPartyNameForDate] in Groovy file 
> [component://party/groovyScripts/party/PartyServices.groovy]: (The field name 
> (or key) [gender] is not valid for entity [PartyNameHistory].) (Error running 
> Groovy method [getPartyNameForDate] in Groovy file



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11736) RuntimeException in getPartyNameForDate service

2020-05-23 Thread Pawan Verma (Jira)
Pawan Verma created OFBIZ-11736:
---

 Summary: RuntimeException in getPartyNameForDate service
 Key: OFBIZ-11736
 URL: https://issues.apache.org/jira/browse/OFBIZ-11736
 Project: OFBiz
  Issue Type: Bug
  Components: party
Affects Versions: Trunk
Reporter: Pawan Verma
Assignee: Pawan Verma


We are getting this error on FindORder and findInvoice screen:

Error running Groovy method [getPartyNameForDate] in Groovy file 
[component://party/groovyScripts/party/PartyServices.groovy]: (The field name 
(or key) [gender] is not valid for entity [PartyNameHistory].) (Error running 
Groovy method [getPartyNameForDate] in Groovy file



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10985) UI issue on View Order page

2020-05-23 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma updated OFBIZ-10985:

Affects Version/s: (was: Release Branch 18.12)
   (was: Release Branch 17.12)

> UI issue on View Order page
> ---
>
> Key: OFBIZ-10985
> URL: https://issues.apache.org/jira/browse/OFBIZ-10985
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Rashi Dhagat
>Assignee: Pawan Verma
>Priority: Trivial
> Attachments: OFBIZ-10985.patch, ViewOrderPage.jpg
>
>
> Steps to regenerate:
>  # Open URL [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main]
>  # Click on any order in Approved status
> Actual:
>  # In Contact Information section, admin (username) is a button
>  # "Send confirmation email" button in brackets
> Expected: 
>  # Username should not be a button
>  # The button should not be in brackets.
> Please refer attachment for same.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-10985) UI issue on View Order page

2020-05-23 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-10985:
---

Assignee: Pawan Verma  (was: Aishwary Shrivastava)

> UI issue on View Order page
> ---
>
> Key: OFBIZ-10985
> URL: https://issues.apache.org/jira/browse/OFBIZ-10985
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Rashi Dhagat
>Assignee: Pawan Verma
>Priority: Trivial
> Attachments: OFBIZ-10985.patch, ViewOrderPage.jpg
>
>
> Steps to regenerate:
>  # Open URL [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main]
>  # Click on any order in Approved status
> Actual:
>  # In Contact Information section, admin (username) is a button
>  # "Send confirmation email" button in brackets
> Expected: 
>  # Username should not be a button
>  # The button should not be in brackets.
> Please refer attachment for same.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11727) Warning message should be shown when added back date with card details

2020-05-23 Thread Pritam Kute (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114810#comment-17114810
 ] 

Pritam Kute commented on OFBIZ-11727:
-

[~Dikpal.Kanungo] While fixing this issue, I found that list of states was not 
getting populated when we select the country in the drop-down while adding 
shipping and billing address on single page checkout screen. I am covering the 
fix of the issue in the same patch.

> Warning message should be shown when added back date with card details
> --
>
> Key: OFBIZ-11727
> URL: https://issues.apache.org/jira/browse/OFBIZ-11727
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Dikpal Kanungo
>Assignee: Pritam Kute
>Priority: Minor
> Attachments: Back date should not be selected.png
>
>
>  
> Steps to regenerate:
> 1. Navigate to : [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]
> 2. Add products to cart  and proceed with 'Single page checkout'
> 3. In step 4 for the checkout process at Billing and shipping form, try 
> adding a back date for the in reference to card details 
> 4. It will not prompt the user for adding an expiry date, and the page will 
> just refresh again and again 
>  
> Expected: User should be notified of adding an expired date. 
>  
> Reference: 
> !Back date should not be selected.png!
>  
> Let me know if you need any further help with the same.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11727) Warning message should be shown when added back date with card details

2020-05-23 Thread Pritam Kute (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute reassigned OFBIZ-11727:
---

Assignee: Pritam Kute

> Warning message should be shown when added back date with card details
> --
>
> Key: OFBIZ-11727
> URL: https://issues.apache.org/jira/browse/OFBIZ-11727
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Dikpal Kanungo
>Assignee: Pritam Kute
>Priority: Minor
> Attachments: Back date should not be selected.png
>
>
>  
> Steps to regenerate:
> 1. Navigate to : [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]
> 2. Add products to cart  and proceed with 'Single page checkout'
> 3. In step 4 for the checkout process at Billing and shipping form, try 
> adding a back date for the in reference to card details 
> 4. It will not prompt the user for adding an expiry date, and the page will 
> just refresh again and again 
>  
> Expected: User should be notified of adding an expired date. 
>  
> Reference: 
> !Back date should not be selected.png!
>  
> Let me know if you need any further help with the same.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11215) Email password is not working

2020-05-23 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114797#comment-17114797
 ] 

Pierre Smits commented on OFBIZ-11215:
--

Thanks for the addendum, [~pawan]

> Email password is not working
> -
>
> Key: OFBIZ-11215
> URL: https://issues.apache.org/jira/browse/OFBIZ-11215
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 16.11, 17.12.03
>Reporter: Rashi Dhagat
>Assignee: Michael Brohl
>Priority: Major
>  Labels: backport-needed
> Fix For: 18.12.01
>
>
> Steps to regenerate:
>  # User should be on the login page 
> [https://demo-stable.ofbiz.apache.org/ecommerce/control/login]
>  # Enter username
>  # Click on email password
> Actual: Email is not received.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11215) Email password is not working

2020-05-23 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114795#comment-17114795
 ] 

Pawan Verma edited comment on OFBIZ-11215 at 5/23/20, 2:42 PM:
---

[~rashi.dhagat]

Adding an email to a username or party set the to-email for the reset password 
functionality. For the mailing system to work properly, we need to do 
from-email configuration in SystemProperty entity, which is not done in the 
demo instance that's why no email is firing from the instance. I think I am 
able to clear your doubt about the email isn't firing.

I've tested it locally with configuration, we are getting an email from the 
Email password functionality.

I found that we can have some improvement in the email that is being fired but 
that should be a part of the new ticket.

I think we are safe to close this ticket. Thoughts?

 


was (Author: pawan.verma):
[~rashi.dhagat]

Adding an email to a username or party set the to-email for the reset password 
functionality. For the mailing system to work properly, we need to do 
from-email configuration in SystemProperty entity, which is not done in the 
demo instance that's why no email is firing from the instance. I think I am 
able to clear your doubt about the email isn't firing.

I've tested it locally with configuration, we are getting an email from the 
Email password functionality.

I found that we can have some improvement in the email that is being fired but 
that should be a part of the new ticket.

I think we are the same to close this ticket.

 

> Email password is not working
> -
>
> Key: OFBIZ-11215
> URL: https://issues.apache.org/jira/browse/OFBIZ-11215
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 16.11, 17.12.03
>Reporter: Rashi Dhagat
>Assignee: Michael Brohl
>Priority: Major
>  Labels: backport-needed
> Fix For: 18.12.01
>
>
> Steps to regenerate:
>  # User should be on the login page 
> [https://demo-stable.ofbiz.apache.org/ecommerce/control/login]
>  # Enter username
>  # Click on email password
> Actual: Email is not received.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11215) Email password is not working

2020-05-23 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114795#comment-17114795
 ] 

Pawan Verma commented on OFBIZ-11215:
-

[~rashi.dhagat]

Adding an email to a username or party set the to-email for the reset password 
functionality. For the mailing system to work properly, we need to do 
from-email configuration in SystemProperty entity, which is not done in the 
demo instance that's why no email is firing from the instance. I think I am 
able to clear your doubt about the email isn't firing.

I've tested it locally with configuration, we are getting an email from the 
Email password functionality.

I found that we can have some improvement in the email that is being fired but 
that should be a part of the new ticket.

I think we are the same to close this ticket.

 

> Email password is not working
> -
>
> Key: OFBIZ-11215
> URL: https://issues.apache.org/jira/browse/OFBIZ-11215
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 16.11, 17.12.03
>Reporter: Rashi Dhagat
>Assignee: Michael Brohl
>Priority: Major
>  Labels: backport-needed
> Fix For: 18.12.01
>
>
> Steps to regenerate:
>  # User should be on the login page 
> [https://demo-stable.ofbiz.apache.org/ecommerce/control/login]
>  # Enter username
>  # Click on email password
> Actual: Email is not received.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11489) Convert cancelPaymentBatch service from mini-lang to groovy DSL

2020-05-23 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114793#comment-17114793
 ] 

Pawan Verma commented on OFBIZ-11489:
-

Hello [~kirti.arora]

Thanks for the great work. I've reviewed your patch. I think you missed to 
include the removal of XML service implementation. Also, Could you please 
handle the service error response?

TIA

> Convert cancelPaymentBatch service from mini-lang to groovy DSL
> ---
>
> Key: OFBIZ-11489
> URL: https://issues.apache.org/jira/browse/OFBIZ-11489
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Kirti Arora
>Priority: Minor
> Attachments: OFBIZ-11489.patch
>
>
> Convert the cancelPaymentBatch service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11733) Improvement in Purchases by Product Report

2020-05-23 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-11733:
---

Assignee: Pawan Verma  (was: Chandan Khandelwal)

> Improvement in Purchases by Product Report
> --
>
> Key: OFBIZ-11733
> URL: https://issues.apache.org/jira/browse/OFBIZ-11733
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Chandan Khandelwal
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11733
>
>
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/OrderPurchaseReportOptions]
> >> Generate Purchases by Product Report
> The status description should be used in report instead of OFBiz ID.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11735) Product link on Order confirmation page is not responding

2020-05-23 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11735:
-
Component/s: ecommerce

> Product link on Order confirmation page is not responding
> -
>
> Key: OFBIZ-11735
> URL: https://issues.apache.org/jira/browse/OFBIZ-11735
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: 17.12.03
>Reporter: Rashi Dhagat
>Priority: Minor
> Attachments: ProductlinkNotresponding.webm
>
>
> Steps to regenerate:
> 1. Open [https://demo-stable.ofbiz.apache.org/ecommerce/control/main]
> 2. Login
> 3. Add item to Cart
> 4. Checkout
> 5. Click on the product name in Order Items section
> Actual:  Page timeout error when click on product name link but working for 
> other links.
> Please refer the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11735) Product link on Order confirmation page is not responding

2020-05-23 Thread Rashi Dhagat (Jira)
Rashi Dhagat created OFBIZ-11735:


 Summary: Product link on Order confirmation page is not responding
 Key: OFBIZ-11735
 URL: https://issues.apache.org/jira/browse/OFBIZ-11735
 Project: OFBiz
  Issue Type: Bug
Affects Versions: 17.12.03
Reporter: Rashi Dhagat
 Attachments: ProductlinkNotresponding.webm

Steps to regenerate:
1. Open [https://demo-stable.ofbiz.apache.org/ecommerce/control/main]

2. Login

3. Add item to Cart

4. Checkout

5. Click on the product name in Order Items section
Actual:  Page timeout error when click on product name link but working for 
other links.
Please refer the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11489) Convert cancelPaymentBatch service from mini-lang to groovy DSL

2020-05-23 Thread Kirti Arora (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114772#comment-17114772
 ] 

Kirti Arora commented on OFBIZ-11489:
-

Hello [~devanshu.vyas] ,

I have added a patch ( [^OFBIZ-11489.patch]) for the same.

Please verify.

Thanks!

> Convert cancelPaymentBatch service from mini-lang to groovy DSL
> ---
>
> Key: OFBIZ-11489
> URL: https://issues.apache.org/jira/browse/OFBIZ-11489
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Kirti Arora
>Priority: Minor
> Attachments: OFBIZ-11489.patch
>
>
> Convert the cancelPaymentBatch service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] Olivier-Heintz commented on pull request #58: OFBIZ-11574 Datamodel_change migration to asciidoc

2020-05-23 Thread GitBox


Olivier-Heintz commented on pull request #58:
URL: https://github.com/apache/ofbiz-framework/pull/58#issuecomment-633056425


   if you want I can do a rebase
   say me.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Comment Edited] (OFBIZ-10379) Exception handling for Add a new Party Role at createInvoiceRole

2020-05-23 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114762#comment-17114762
 ] 

Pierre Smits edited comment on OFBIZ-10379 at 5/23/20, 1:33 PM:


There is consensus that the AP and AR web apps should be removed from the main 
menu, and thus such functions related to AP invoices should not appear anymore. 
See OFBIZ-10552.

IMO, we don't need to pursue this after 2 years anymore.
 


was (Author: pfm.smits):
There is consensus that the AP and AR web apps should be removed from the main 
menu, and thus such functions related to AP invoices should not appear anymore. 
See OFBIZ-10552



 

> Exception handling for Add a new Party Role at createInvoiceRole
> 
>
> Key: OFBIZ-10379
> URL: https://issues.apache.org/jira/browse/OFBIZ-10379
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/ap/control/createInvoiceRole
>Reporter: Aayush jain
>Assignee: Pierre Smits
>Priority: Minor
> Attachments: Error.png, OFBIZ-10379.patch
>
>
> Steps:
> 1. Open URL https://demo-trunk.ofbiz.apache.org/ap/control/createInvoiceRole
> 2. Add a party Id which does not assigned as a role for accounts
> 3. Enter Percentage
> 4. Click on submit button
> Actual Result: 
> Throwing an exception error for the invalid case, Kindly refer attachment for 
> the same
> Expected Result:
> We must handle exceptions with a proper error message, I don't think this is 
> working fine, It should be correct with proper message.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10379) Exception handling for Add a new Party Role at createInvoiceRole

2020-05-23 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114762#comment-17114762
 ] 

Pierre Smits commented on OFBIZ-10379:
--

There is consensus that the AP and AR web apps should be removed from the main 
menu, and thus such functions related to AP invoices should not appear anymore. 
See OFBIZ-10552



 

> Exception handling for Add a new Party Role at createInvoiceRole
> 
>
> Key: OFBIZ-10379
> URL: https://issues.apache.org/jira/browse/OFBIZ-10379
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/ap/control/createInvoiceRole
>Reporter: Aayush jain
>Priority: Minor
> Attachments: Error.png, OFBIZ-10379.patch
>
>
> Steps:
> 1. Open URL https://demo-trunk.ofbiz.apache.org/ap/control/createInvoiceRole
> 2. Add a party Id which does not assigned as a role for accounts
> 3. Enter Percentage
> 4. Click on submit button
> Actual Result: 
> Throwing an exception error for the invalid case, Kindly refer attachment for 
> the same
> Expected Result:
> We must handle exceptions with a proper error message, I don't think this is 
> working fine, It should be correct with proper message.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-10379) Exception handling for Add a new Party Role at createInvoiceRole

2020-05-23 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-10379:


Assignee: Pierre Smits

> Exception handling for Add a new Party Role at createInvoiceRole
> 
>
> Key: OFBIZ-10379
> URL: https://issues.apache.org/jira/browse/OFBIZ-10379
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/ap/control/createInvoiceRole
>Reporter: Aayush jain
>Assignee: Pierre Smits
>Priority: Minor
> Attachments: Error.png, OFBIZ-10379.patch
>
>
> Steps:
> 1. Open URL https://demo-trunk.ofbiz.apache.org/ap/control/createInvoiceRole
> 2. Add a party Id which does not assigned as a role for accounts
> 3. Enter Percentage
> 4. Click on submit button
> Actual Result: 
> Throwing an exception error for the invalid case, Kindly refer attachment for 
> the same
> Expected Result:
> We must handle exceptions with a proper error message, I don't think this is 
> working fine, It should be correct with proper message.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-10155) Error on ordermgr component for locale ar - Arabic

2020-05-23 Thread Vaibhav Hood (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vaibhav Hood reassigned OFBIZ-10155:


Assignee: Vaibhav Hood

> Error on ordermgr component for locale ar - Arabic 
> ---
>
> Key: OFBIZ-10155
> URL: https://issues.apache.org/jira/browse/OFBIZ-10155
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: 17.12.01, Trunk
>Reporter: Aditya Sharma
>Assignee: Vaibhav Hood
>Priority: Minor
> Attachments: ErrorAr.png
>
>
> Steps to regenerate:
> 1. Login to Order Manager 
> (https://demo-trunk.ofbiz.apache.org/ordermgr/control/main)
> 2. Click on change language link 
> (https://demo-trunk.ofbiz.apache.org/ordermgr/control/ListLocales)
> 3. Change locale to ar -  العربية 
> (https://demo-trunk.ofbiz.apache.org/ordermgr/control/setSessionLocale?newLocale=ar)
> {quote}ERROR rendering error page [/error/error.jsp], but here is the error 
> text: java.lang.RuntimeException: Error rendering widgets section [] in 
> screen named [GlobalDecorator]: freemarker.core.ParseException: Syntax error 
> in template 
> "org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer@296cd5b8_1000" in 
> line 1, column 185: Lexical error: encountered "\u0627" (1575), after 
> "\"\u0645\u062f\u064a\u0631 \u0623\u0645\u0631 
> \u0627\u0644\u0628\u064a\u0639\\".{quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11489) Convert cancelPaymentBatch service from mini-lang to groovy DSL

2020-05-23 Thread Kirti Arora (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirti Arora updated OFBIZ-11489:

Attachment: OFBIZ-11489.patch

> Convert cancelPaymentBatch service from mini-lang to groovy DSL
> ---
>
> Key: OFBIZ-11489
> URL: https://issues.apache.org/jira/browse/OFBIZ-11489
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Kirti Arora
>Priority: Minor
> Attachments: OFBIZ-11489.patch
>
>
> Convert the cancelPaymentBatch service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] adityasharma7 commented on pull request #58: OFBIZ-11574 Datamodel_change migration to asciidoc

2020-05-23 Thread GitBox


adityasharma7 commented on pull request #58:
URL: https://github.com/apache/ofbiz-framework/pull/58#issuecomment-633053920


   Hi @Olivier-Heintz,
   Thank you for your efforts towards this migration!
   If it is done, I think we should resolve conflicts and merge them.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-10379) Exception handling for Add a new Party Role at createInvoiceRole

2020-05-23 Thread Devanshu Vyas (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114753#comment-17114753
 ] 

Devanshu Vyas commented on OFBIZ-10379:
---

I verified the patch is working properly and it can be committed.

> Exception handling for Add a new Party Role at createInvoiceRole
> 
>
> Key: OFBIZ-10379
> URL: https://issues.apache.org/jira/browse/OFBIZ-10379
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/ap/control/createInvoiceRole
>Reporter: Aayush jain
>Priority: Minor
> Attachments: Error.png, OFBIZ-10379.patch
>
>
> Steps:
> 1. Open URL https://demo-trunk.ofbiz.apache.org/ap/control/createInvoiceRole
> 2. Add a party Id which does not assigned as a role for accounts
> 3. Enter Percentage
> 4. Click on submit button
> Actual Result: 
> Throwing an exception error for the invalid case, Kindly refer attachment for 
> the same
> Expected Result:
> We must handle exceptions with a proper error message, I don't think this is 
> working fine, It should be correct with proper message.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11365) Convert setContentStatus service from mini-lang to groovy DSL

2020-05-23 Thread Mridul Pathak (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mridul Pathak closed OFBIZ-11365.
-
Fix Version/s: Upcoming Branch
   Resolution: Fixed

> Convert setContentStatus service from mini-lang to groovy DSL
> -
>
> Key: OFBIZ-11365
> URL: https://issues.apache.org/jira/browse/OFBIZ-11365
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Mridul Pathak
>Priority: Minor
>  Labels: patch-available
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11365.patch, OFBIZ-11365.patch, OFBIZ-11365.patch
>
>
> Convert the setContentStatus service code from mini lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11204) Remove unwanted error log by `ServiceSemaphore` waiting process

2020-05-23 Thread Ravi Lodhi (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114744#comment-17114744
 ] 

Ravi Lodhi commented on OFBIZ-11204:


Hello Team,

I tried to test the mentioned fix by backporting to release17.12 and 
release18.12 branch and found that the error still appears. 

To test the changes I have created a test service with the *semaphore* 
attribute set to *wait* in the service definition. I called this service 
asynchronously from a loop to create a large number of  JobSandbox records (I 
called that service 100,000 times in a loop). Once the async jobs start 
executing I closely watched the console logs.

Though the frequency was low, still that error (Failure in create operation for 
entity ServiceSemaphore) comes during the execution.

> Remove unwanted error log by `ServiceSemaphore` waiting process
> ---
>
> Key: OFBIZ-11204
> URL: https://issues.apache.org/jira/browse/OFBIZ-11204
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11204.patch, OFBIZ-11204.patch
>
>
> When a lot of semaphore configured service instances are running in a short 
> period, multiple errors of this type are logged :
> {code:none}
> // | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |GenericDelegator  |E| Failure in create operation for entity 
> [ServiceSemaphore]: org.apache.ofbiz.entity.GenericEntityException: Error 
> while inserting: [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lockThread,OFBiz-JobQueue-2(java.lang.String)][lockTime,2019-09-19
>  
> 16:47:44.676(java.sql.Timestamp)][lockedByInstanceId,emb-ofbiz-prd-technical-asg-20171209-01-eu-west-1b(java.lang.String)][serviceName,xxx(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO 
> public.SERVICE_SEMAPHORE (SERVICE_NAME, LOCKED_BY_INSTANCE_ID, LOCK_THREAD, 
> LOCK_TIME, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, 
> CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?) (ERROR: duplicate key value 
> violates unique constraint "pk_service_semaphore"   Detail: Key 
> (service_name)=(xxx) already exists.)). Rolling back transaction. 
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>  |
> | 2019-09-19 14:47:44.000 | 2019-09-19 

[jira] [Commented] (OFBIZ-11365) Convert setContentStatus service from mini-lang to groovy DSL

2020-05-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114742#comment-17114742
 ] 

ASF subversion and git services commented on OFBIZ-11365:
-

Commit f9a05c8e30f5f7f593e53a6591b990b2760ffbd1 in ofbiz-framework's branch 
refs/heads/trunk from Mridul Pathak
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f9a05c8 ]

Improved: Convert setContentStatus service from mini-lang to groovy 
DSL(OFBIZ-11365). Thanks Devanshu Vyas for the contribution.


> Convert setContentStatus service from mini-lang to groovy DSL
> -
>
> Key: OFBIZ-11365
> URL: https://issues.apache.org/jira/browse/OFBIZ-11365
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Mridul Pathak
>Priority: Minor
>  Labels: patch-available
> Attachments: OFBIZ-11365.patch, OFBIZ-11365.patch, OFBIZ-11365.patch
>
>
> Convert the setContentStatus service code from mini lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-4880) ajaxSubmitRequestUpdateAreas JavaScript function should be able to update content-messages

2020-05-23 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-4880.
--
Resolution: Won't Do

Thanks Aditya for the reminder, closing

> ajaxSubmitRequestUpdateAreas JavaScript function should be able to update 
> content-messages
> --
>
> Key: OFBIZ-4880
> URL: https://issues.apache.org/jira/browse/OFBIZ-4880
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
> Environment: Ubuntu 10.04
>Reporter: Chatree Srichart
>Assignee: Aditya Sharma
>Priority: Major
>  Labels: ajax
> Attachments: ajaxSubmitRequestUpdateAreas.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Hi all,
> In the selectall.js file, the ajaxSubmitRequestUpdateAreas function should 
> check the response data if it contains an error message, or not. It then 
> should update the content-message content if it found an error message like 
> the ajaxSubmitFormUpdateAreas function.
> Regards,
> Chatree Srichart



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10888) Multiple promotions are getting applied in sequence.

2020-05-23 Thread Lalit Dashora (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114736#comment-17114736
 ] 

Lalit Dashora commented on OFBIZ-10888:
---

Hi,

I have replicated the issue but I didn't find any way to apply only one 
promotion. 
Created a promotion where if cart subtotal is greater then 1000 then system 
will give 50% discount
and also created another promotion if cart subtotal is less than 800 then 
system will give 10% discount.

Now the cart total is 1536 so 50% discount decreased cart value to 768 but 
second promotion automatically applied i.e additional 10% discount also applied 
76.8 is also discount so the cart total now became 691.2.
I didn't find any alternate way to stop this. I am looking into code so that 
promotion can be applied in isolation.

Thanks!

> Multiple promotions are getting applied in sequence.
> 
>
> Key: OFBIZ-10888
> URL: https://issues.apache.org/jira/browse/OFBIZ-10888
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Lalit Dashora
>Assignee: Lalit Dashora
>Priority: Major
>
> Created 2 different promotions '50% discount on shopping above Rs. 1000' and 
> '10% discount on shopping between Rs. 400-700'
> Added the product of Rs. 1000 so the total discount will be Rs. 500 
> Now the total amount falls in the range of second promotion and again 10% 
> discount is getting applied.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11480) Convert updatePayment service from mini-lang to groovy DSL

2020-05-23 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-11480.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

Minor modified patch loaded into trunk.

> Convert updatePayment service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11480
> URL: https://issues.apache.org/jira/browse/OFBIZ-11480
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11480.patch
>
>
> Convert the updatePayment service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-4880) ajaxSubmitRequestUpdateAreas JavaScript function should be able to update content-messages

2020-05-23 Thread Aditya Sharma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma reassigned OFBIZ-4880:


Assignee: Aditya Sharma

> ajaxSubmitRequestUpdateAreas JavaScript function should be able to update 
> content-messages
> --
>
> Key: OFBIZ-4880
> URL: https://issues.apache.org/jira/browse/OFBIZ-4880
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
> Environment: Ubuntu 10.04
>Reporter: Chatree Srichart
>Assignee: Aditya Sharma
>Priority: Major
>  Labels: ajax
> Attachments: ajaxSubmitRequestUpdateAreas.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Hi all,
> In the selectall.js file, the ajaxSubmitRequestUpdateAreas function should 
> check the response data if it contains an error message, or not. It then 
> should update the content-message content if it found an error message like 
> the ajaxSubmitFormUpdateAreas function.
> Regards,
> Chatree Srichart



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11480) Convert updatePayment service from mini-lang to groovy DSL

2020-05-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114731#comment-17114731
 ] 

ASF subversion and git services commented on OFBIZ-11480:
-

Commit 15bcc92dd1ba3a3f62f7695f39ce5ffb87e18d44 in ofbiz-framework's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=15bcc92 ]

Improved: Converted updatePayment service from mini-lang to groovy.
(OFBIZ-11480)
Thanks Devanshu Vyas for reporting and Priya Sharma for the patch.


> Convert updatePayment service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11480
> URL: https://issues.apache.org/jira/browse/OFBIZ-11480
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-11480.patch
>
>
> Convert the updatePayment service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-4880) ajaxSubmitRequestUpdateAreas JavaScript function should be able to update content-messages

2020-05-23 Thread Aditya Sharma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114730#comment-17114730
 ] 

Aditya Sharma commented on OFBIZ-4880:
--

Thank you [~chatree] for your effort!

It seems that ajaxSubmitRequestUpdateAreas function is no longer used, so even 
if I try to apply this patch I won't be able to test it. 
I think we can close this ticket.  

> ajaxSubmitRequestUpdateAreas JavaScript function should be able to update 
> content-messages
> --
>
> Key: OFBIZ-4880
> URL: https://issues.apache.org/jira/browse/OFBIZ-4880
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
> Environment: Ubuntu 10.04
>Reporter: Chatree Srichart
>Priority: Major
>  Labels: ajax
> Attachments: ajaxSubmitRequestUpdateAreas.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Hi all,
> In the selectall.js file, the ajaxSubmitRequestUpdateAreas function should 
> check the response data if it contains an error message, or not. It then 
> should update the content-message content if it found an error message like 
> the ajaxSubmitFormUpdateAreas function.
> Regards,
> Chatree Srichart



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-10890) Requesthandler exception is showing after clicking cancel/done button on editPerson screen

2020-05-23 Thread Aditya Sharma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma closed OFBIZ-10890.
-
Fix Version/s: 18.12.01
   Resolution: Fixed

Thanks Minal Phalak for reporting and providing the patch

> Requesthandler exception is showing after clicking cancel/done button on 
> editPerson screen
> --
>
> Key: OFBIZ-10890
> URL: https://issues.apache.org/jira/browse/OFBIZ-10890
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Release Branch 18.12, Trunk
>Reporter: Phalak Minal Yuvraj
>Assignee: Aditya Sharma
>Priority: Major
> Fix For: 18.12.01
>
> Attachments: OFBIZ-10890.patch
>
>
> Steps to regenerate:
> 1) Open [https://demo-trunk.ofbiz.apache.org/partymgr/control/main]
> 2) Create new customer
> 3) Update Personal Information
> 4) Now click on Cancel/Done
> Actual: Error is occurring while clicking on cancel/done button.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10891) Send me this every month link is not working in order items section.

2020-05-23 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-10891:
-
Affects Version/s: (was: Release Branch 17.12)
   17.12.03

> Send me this every month link is not working in order items section.
> 
>
> Key: OFBIZ-10891
> URL: https://issues.apache.org/jira/browse/OFBIZ-10891
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>Reporter: Ashish Sharma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-10891-Reopen.png, OFBIZ-10891.patch, 
> OFBIZ-10891.png
>
>
> *Steps to Reproduce*
> 1. Login with valid username and password.
> 2. Navigate to ecommerce.
> 3. Place a order.
> 4. Navigate to order history and click on view link.
> 5. Click on link “send me this every month” in order items section.
> *Actual Result:* Error message is displayed.
> *Screen print attached*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11401) getEntityRefData service has a weird issue

2020-05-23 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114725#comment-17114725
 ] 

Pierre Smits commented on OFBIZ-11401:
--

Also a good argument to replace the error with a warning.

> getEntityRefData service has a weird issue
> --
>
> Key: OFBIZ-11401
> URL: https://issues.apache.org/jira/browse/OFBIZ-11401
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
>
> It's reproductible on trunk demo though only visible in log, UI shows no issue
> Here is the log on trunk demo
> {noformat}
> 2020-02-21 21:11:56,445 |ajp-nio-8009-exec-2  |WebToolsServices  
> |E| null
> java.util.MissingResourceException: Can't find resource for bundle 
> org.apache.ofbiz.base.util.UtilProperties$UtilResourceBundle, key 
> FieldDescription.WorkEffortType.createdTxStamp
>   at java.util.ResourceBundle.getObject(ResourceBundle.java:450) 
> ~[?:1.8.0_242]
>   at java.util.ResourceBundle.getObject(ResourceBundle.java:444) 
> ~[?:1.8.0_242]
>   at java.util.ResourceBundle.getString(ResourceBundle.java:407) 
> ~[?:1.8.0_242]
>   at 
> org.apache.ofbiz.webtools.WebToolsServices.getEntityRefData(WebToolsServices.java:685)
>  [main/:?]
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_242]
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_242]
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_242]
>   at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_242]
>   at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
>  [main/:?]
>   [...]
>   at 
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
>  [tomcat-util-9.0.29.jar:9.0.29]
>   at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242]
> 2020-02-21 21:11:56,445 |ajp-nio-8009-exec-2  |WebToolsServices  
> |E| null
> java.util.MissingResourceException: Can't find resource for bundle 
> org.apache.ofbiz.base.util.UtilProperties$UtilResourceBundle, key 
> FieldDescription.createdTxStamp
>   at java.util.ResourceBundle.getObject(ResourceBundle.java:450) 
> ~[?:1.8.0_242]
>   at java.util.ResourceBundle.getObject(ResourceBundle.java:444) 
> ~[?:1.8.0_242]
>   at java.util.ResourceBundle.getString(ResourceBundle.java:407) 
> ~[?:1.8.0_242]
>   at 
> org.apache.ofbiz.webtools.WebToolsServices.getEntityRefData(WebToolsServices.java:695)
>  [main/:?]
>   [...]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  [?:1.8.0_242]
>   at 
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
>  [tomcat-util-9.0.29.jar:9.0.29]
>   at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242]
> 2020-02-21 21:11:56,445 |ajp-nio-8009-exec-2  |ServiceDispatcher 
> |T| Sync service [webtools/getEntityRefData] finished in [5760] milliseconds
>   at 
> org.apache.ofbiz.webtools.WebToolsServices.getEntityRefData(WebToolsServices.java:685)
>  [main/:?]
> {noformat}
> So it repeats almost "ad ib" and eventually stops after 5+ seconds there.
> I guess R17 and R18 are also affected, R16 is OK.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11497) Convert checkAndCreateBatchForValidPayments service from mini-lang to groovy DSL

2020-05-23 Thread Sourabh Punyani (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sourabh Punyani updated OFBIZ-11497:

Attachment: OFBIZ-11497.patch

> Convert checkAndCreateBatchForValidPayments service from mini-lang to groovy 
> DSL
> 
>
> Key: OFBIZ-11497
> URL: https://issues.apache.org/jira/browse/OFBIZ-11497
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Sourabh Punyani
>Priority: Minor
> Attachments: OFBIZ-11497.patch
>
>
> Convert the checkAndCreateBatchForValidPayments service code from mini-lang 
> to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10890) Requesthandler exception is showing after clicking cancel/done button on editPerson screen

2020-05-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114721#comment-17114721
 ] 

ASF subversion and git services commented on OFBIZ-10890:
-

Commit 9925fad92a9868af44be05c4c6d3b95ea4e04ec6 in ofbiz-framework's branch 
refs/heads/release18.12 from Aditya Sharma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9925fad ]

Fixed: Requesthandler exception is showing after clicking cancel/done button on 
editPerson screen
(OFBIZ-10890)
Set the value of missing parameter.
Thanks Minal Phalak for reporting and providing the patch


> Requesthandler exception is showing after clicking cancel/done button on 
> editPerson screen
> --
>
> Key: OFBIZ-10890
> URL: https://issues.apache.org/jira/browse/OFBIZ-10890
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Release Branch 18.12, Trunk
>Reporter: Phalak Minal Yuvraj
>Assignee: Aditya Sharma
>Priority: Major
> Attachments: OFBIZ-10890.patch
>
>
> Steps to regenerate:
> 1) Open [https://demo-trunk.ofbiz.apache.org/partymgr/control/main]
> 2) Create new customer
> 3) Update Personal Information
> 4) Now click on Cancel/Done
> Actual: Error is occurring while clicking on cancel/done button.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11734) View Image button on order view page fails to render the image

2020-05-23 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114722#comment-17114722
 ] 

Pierre Smits commented on OFBIZ-11734:
--

Of course we can. But I would wait a minimal amount of hours (72h is the going 
rate) whether anyone from the community comes forward with arguments to keep it 
in. And if not, just take that as lazy consensus.

> View Image button on order view page fails to render the image
> --
>
> Key: OFBIZ-11734
> URL: https://issues.apache.org/jira/browse/OFBIZ-11734
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: 17.12.03, Trunk
>Reporter: Arpit Mor
>Priority: Minor
> Attachments: NoImage.mp4
>
>
> Pre-requisite:
>  * At least one order should exist in the system
> Steps to regenerate:
>  # Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist]
>  # Click on any order number
>  # Navigate to order item section of the page
>  # Click on view image button for any product
> Actual: A new tab is opened but the image is not displayed. Please refer 
> attachment: NoImage.mp4
> [^NoImage.mp4]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11497) Convert checkAndCreateBatchForValidPayments service from mini-lang to groovy DSL

2020-05-23 Thread Sourabh Punyani (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114723#comment-17114723
 ] 

Sourabh Punyani commented on OFBIZ-11497:
-

Hello Devanshu,

I have added a patch (OFBIZ-11497.patch) for the same.

Please verify.

> Convert checkAndCreateBatchForValidPayments service from mini-lang to groovy 
> DSL
> 
>
> Key: OFBIZ-11497
> URL: https://issues.apache.org/jira/browse/OFBIZ-11497
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Sourabh Punyani
>Priority: Minor
> Attachments: OFBIZ-11497.patch
>
>
> Convert the checkAndCreateBatchForValidPayments service code from mini-lang 
> to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10890) Requesthandler exception is showing after clicking cancel/done button on editPerson screen

2020-05-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114719#comment-17114719
 ] 

ASF subversion and git services commented on OFBIZ-10890:
-

Commit ebd7992dac78c710574eaf8adc1862869e3478fa in ofbiz-framework's branch 
refs/heads/trunk from Aditya Sharma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ebd7992 ]

Fixed: Requesthandler exception is showing after clicking cancel/done button on 
editPerson screen
(OFBIZ-10890)
Set the value of missing parameter.
Thanks Minal Phalak for reporting and providing the patch


> Requesthandler exception is showing after clicking cancel/done button on 
> editPerson screen
> --
>
> Key: OFBIZ-10890
> URL: https://issues.apache.org/jira/browse/OFBIZ-10890
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Release Branch 18.12, Trunk
>Reporter: Phalak Minal Yuvraj
>Assignee: Aditya Sharma
>Priority: Major
> Attachments: OFBIZ-10890.patch
>
>
> Steps to regenerate:
> 1) Open [https://demo-trunk.ofbiz.apache.org/partymgr/control/main]
> 2) Create new customer
> 3) Update Personal Information
> 4) Now click on Cancel/Done
> Actual: Error is occurring while clicking on cancel/done button.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11485) Convert getInvoicePaymentInfoList service from mini-lang to groovy DSL

2020-05-23 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-11485:
-

Assignee: Suraj Khurana  (was: Priya Sharma)

> Convert getInvoicePaymentInfoList service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11485
> URL: https://issues.apache.org/jira/browse/OFBIZ-11485
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
>
> Convert the getInvoicePaymentInfoList service code from mini-lang to groovy 
> DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-10854) Recalculate cart link is not working in shopping cart page

2020-05-23 Thread Ashish Sharma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Sharma closed OFBIZ-10854.
-
Resolution: Cannot Reproduce

> Recalculate cart link is not working in shopping cart page
> --
>
> Key: OFBIZ-10854
> URL: https://issues.apache.org/jira/browse/OFBIZ-10854
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ashish Sharma
>Assignee: Ashish Kumar Pandey
>Priority: Minor
> Attachments: Ofbiz-10854.docx
>
>
> *Step to reproduce*
> Login with valid username and password.
> Navigate to ecommerce.
> Select a product and add to cart.
> Update the quantity field.
> Click on recalculate cart.
> *Expected result:* Order price should be updated.
> *Actual result:* Order price is not changing.
> *Screen print attached*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10890) Requesthandler exception is showing after clicking cancel/done button on editPerson screen

2020-05-23 Thread Aditya Sharma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-10890:
--
   Sprint: OFBiz Community Day (May 2020)
Affects Version/s: Release Branch 18.12

> Requesthandler exception is showing after clicking cancel/done button on 
> editPerson screen
> --
>
> Key: OFBIZ-10890
> URL: https://issues.apache.org/jira/browse/OFBIZ-10890
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Release Branch 18.12, Trunk
>Reporter: Phalak Minal Yuvraj
>Assignee: Aditya Sharma
>Priority: Major
> Attachments: OFBIZ-10890.patch
>
>
> Steps to regenerate:
> 1) Open [https://demo-trunk.ofbiz.apache.org/partymgr/control/main]
> 2) Create new customer
> 3) Update Personal Information
> 4) Now click on Cancel/Done
> Actual: Error is occurring while clicking on cancel/done button.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11294) EntityQuery queryCount is throwing error with distinct method

2020-05-23 Thread Amit Gadaley (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114708#comment-17114708
 ] 

Amit Gadaley commented on OFBIZ-11294:
--

Hello [~pawan],

 

I have faced the same issue and this solution looks good to me.

I have tested it and it is working fine for me.

> EntityQuery queryCount is throwing error with distinct method
> -
>
> Key: OFBIZ-11294
> URL: https://issues.apache.org/jira/browse/OFBIZ-11294
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Major
>
> We have a bug/missing support for distinct when used with queryCount method 
> of EntityQuery.
> Below is the more detail
> {code:java}
> EntityCondition cond = EntityCondition.makeCondition(UtilMisc.toList(
>        EntityCondition.makeCondition("locationSeqId", "00test123"),
>        EntityCondition.makeCondition("facilityId", EntityOperator.EQUALS, 
> "10070"),
>        EntityCondition.makeCondition("quantityOnHandTotal", 
> EntityOperator.GREATER_THAN, BigDecimal.ZERO)),
>        EntityOperator.AND);{code}
> *Case 1:* queryList().size() with distinct
> {code:java}
> int productAtLocation = 
> EntityQuery.use(delegator).select("productId").from("InventoryItem")
>        .where(cond).maxRows(2).distinct().queryList().size();{code}
> Result Query: SELECT DISTINCT PRODUCT_ID FROM INVENTORY_ITEM WHERE 
> ((LOCATION_SEQ_ID = ? AND FACILITY_ID = ? AND QUANTITY_ON_HAND_TOTAL > ?))
>  Result: This case works well.
> *Case 2:* queryCount without distinct
> {code:java}
> Long testCount = 
> EntityQuery.use(delegator).select("productId").from("InventoryItem")
>        .where(cond).maxRows(2).queryCount();{code}
> Result Query: SELECT COUNT(1)  FROM INVENTORY_ITEM WHERE ((LOCATION_SEQ_ID = 
> ? AND FACILITY_ID = ? AND QUANTITY_ON_HAND_TOTAL > ?))
> Result: This case also works well
> *Case 3:*  queryCount with distinct
> {code:java}
> Long testCount = 
> EntityQuery.use(delegator).select("productId").from("InventoryItem")
>        .where(cond).maxRows(2).queryCount();{code}
> Result Query: SELECT COUNT(DISTINCT *)  FROM INVENTORY_ITEM WHERE 
> ((LOCATION_SEQ_ID = ? AND FACILITY_ID = ? AND QUANTITY_ON_HAND_TOTAL > ?))
> Result: This case throw an error
>  org.apache.ofbiz.entity.GenericDataSourceException: SQL Exception while 
> executing the following:SELECT COUNT(DISTINCT *) FROM OFBIZ.INVENTORY_ITEM 
> (Syntax error: Encountered "*" at line 1, column 23.)
>  
> *Below is the research I have done for the issue:*
> In EntityQuery.queryCount(), return method is 
> delegator.findCountByCondition(). This method doesn't have support for 
> fieldsToSelect.
>  When we reach till GenericDAO.selectCountByCondition() at line 949, 
> returning method is setting *null* for selectFields.
>  And at the implementation of selectCountByCondition, at line 994 we have a 
> check for selectFields, that's why we are having *COUNT(DISTINCT *)* in our 
> query.
>  
> *To test this, I have used a simple way:*
>  Just include below code at any groovy file and run it:
> {code:java}
> testCount = select("productId").from("InventoryItem").distinct().queryCount()
> {code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10891) Send me this every month link is not working in order items section.

2020-05-23 Thread Amit Gadaley (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114707#comment-17114707
 ] 

Amit Gadaley commented on OFBIZ-10891:
--

Hello [~pawan],

 

This issue exists on release branch as well.

> Send me this every month link is not working in order items section.
> 
>
> Key: OFBIZ-10891
> URL: https://issues.apache.org/jira/browse/OFBIZ-10891
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Ashish Sharma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-10891-Reopen.png, OFBIZ-10891.patch, 
> OFBIZ-10891.png
>
>
> *Steps to Reproduce*
> 1. Login with valid username and password.
> 2. Navigate to ecommerce.
> 3. Place a order.
> 4. Navigate to order history and click on view link.
> 5. Click on link “send me this every month” in order items section.
> *Actual Result:* Error message is displayed.
> *Screen print attached*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10891) Send me this every month link is not working in order items section.

2020-05-23 Thread Amit Gadaley (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amit Gadaley updated OFBIZ-10891:
-
Affects Version/s: Release Branch 18.12

> Send me this every month link is not working in order items section.
> 
>
> Key: OFBIZ-10891
> URL: https://issues.apache.org/jira/browse/OFBIZ-10891
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 18.12, Trunk
>Reporter: Ashish Sharma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-10891-Reopen.png, OFBIZ-10891.patch, 
> OFBIZ-10891.png
>
>
> *Steps to Reproduce*
> 1. Login with valid username and password.
> 2. Navigate to ecommerce.
> 3. Place a order.
> 4. Navigate to order history and click on view link.
> 5. Click on link “send me this every month” in order items section.
> *Actual Result:* Error message is displayed.
> *Screen print attached*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10891) Send me this every month link is not working in order items section.

2020-05-23 Thread Amit Gadaley (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amit Gadaley updated OFBIZ-10891:
-
Affects Version/s: Release Branch 17.12

> Send me this every month link is not working in order items section.
> 
>
> Key: OFBIZ-10891
> URL: https://issues.apache.org/jira/browse/OFBIZ-10891
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Ashish Sharma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-10891-Reopen.png, OFBIZ-10891.patch, 
> OFBIZ-10891.png
>
>
> *Steps to Reproduce*
> 1. Login with valid username and password.
> 2. Navigate to ecommerce.
> 3. Place a order.
> 4. Navigate to order history and click on view link.
> 5. Click on link “send me this every month” in order items section.
> *Actual Result:* Error message is displayed.
> *Screen print attached*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11365) Convert setContentStatus service from mini-lang to groovy DSL

2020-05-23 Thread Mridul Pathak (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mridul Pathak reassigned OFBIZ-11365:
-

Assignee: Mridul Pathak  (was: Devanshu Vyas)

> Convert setContentStatus service from mini-lang to groovy DSL
> -
>
> Key: OFBIZ-11365
> URL: https://issues.apache.org/jira/browse/OFBIZ-11365
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Mridul Pathak
>Priority: Minor
>  Labels: patch-available
> Attachments: OFBIZ-11365.patch, OFBIZ-11365.patch, OFBIZ-11365.patch
>
>
> Convert the setContentStatus service code from mini lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11480) Convert updatePayment service from mini-lang to groovy DSL

2020-05-23 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-11480:
-

Assignee: Suraj Khurana  (was: Priya Sharma)

> Convert updatePayment service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11480
> URL: https://issues.apache.org/jira/browse/OFBIZ-11480
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-11480.patch
>
>
> Convert the updatePayment service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-7737) OFBIZ-7471: Improve all the service level error messages for missing required field for accounting component

2020-05-23 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114704#comment-17114704
 ] 

Suraj Khurana commented on OFBIZ-7737:
--

Hello team,

Any updates on this?

> OFBIZ-7471: Improve all the service level error messages for missing required 
> field for accounting component
> 
>
> Key: OFBIZ-7737
> URL: https://issues.apache.org/jira/browse/OFBIZ-7737
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: 16.11.01
>Reporter: Ratnesh Upadhyay
>Assignee: Pallavi Goyal
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-8716) Improve all the service level error messages for missing required field for humanares component

2020-05-23 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-8716.

Fix Version/s: Upcoming Branch
   Resolution: Implemented

Committed slightly modified patch on trunk.

> Improve all the service level error messages for missing required field for 
> humanares component
> ---
>
> Key: OFBIZ-8716
> URL: https://issues.apache.org/jira/browse/OFBIZ-8716
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Affects Versions: 16.11.01
>Reporter: Jagpreet Kaur
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8716.patch, OFBIZ-8716.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-8716) Improve all the service level error messages for missing required field for humanares component

2020-05-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-8716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114702#comment-17114702
 ] 

ASF subversion and git services commented on OFBIZ-8716:


Commit 59d465bfd86a302bbc8540693d42b1cb45927354 in ofbiz-framework's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=59d465b ]

Improved: All the service level error messages for missing required field for 
humanares component.
(OFBIZ-8716)
Thanks Jagpreet for reporting and Prasheel for providing the initial patch


> Improve all the service level error messages for missing required field for 
> humanares component
> ---
>
> Key: OFBIZ-8716
> URL: https://issues.apache.org/jira/browse/OFBIZ-8716
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Affects Versions: 16.11.01
>Reporter: Jagpreet Kaur
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-8716.patch, OFBIZ-8716.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10854) Recalculate cart link is not working in shopping cart page

2020-05-23 Thread Ashish Sharma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114701#comment-17114701
 ] 

Ashish Sharma commented on OFBIZ-10854:
---

Issue no more exist. Its working fine now. 

> Recalculate cart link is not working in shopping cart page
> --
>
> Key: OFBIZ-10854
> URL: https://issues.apache.org/jira/browse/OFBIZ-10854
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ashish Sharma
>Assignee: Ashish Kumar Pandey
>Priority: Minor
> Attachments: Ofbiz-10854.docx
>
>
> *Step to reproduce*
> Login with valid username and password.
> Navigate to ecommerce.
> Select a product and add to cart.
> Update the quantity field.
> Click on recalculate cart.
> *Expected result:* Order price should be updated.
> *Actual result:* Order price is not changing.
> *Screen print attached*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11497) Convert checkAndCreateBatchForValidPayments service from mini-lang to groovy DSL

2020-05-23 Thread Sourabh Punyani (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sourabh Punyani reassigned OFBIZ-11497:
---

Assignee: Sourabh Punyani  (was: Devanshu Vyas)

> Convert checkAndCreateBatchForValidPayments service from mini-lang to groovy 
> DSL
> 
>
> Key: OFBIZ-11497
> URL: https://issues.apache.org/jira/browse/OFBIZ-11497
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Sourabh Punyani
>Priority: Minor
>
> Convert the checkAndCreateBatchForValidPayments service code from mini-lang 
> to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11734) View Image button on order view page fails to render the image

2020-05-23 Thread Arpit Mor (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Mor reassigned OFBIZ-11734:
-

Assignee: (was: Saurabh Dixit)

> View Image button on order view page fails to render the image
> --
>
> Key: OFBIZ-11734
> URL: https://issues.apache.org/jira/browse/OFBIZ-11734
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: 17.12.03, Trunk
>Reporter: Arpit Mor
>Priority: Minor
> Attachments: NoImage.mp4
>
>
> Pre-requisite:
>  * At least one order should exist in the system
> Steps to regenerate:
>  # Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist]
>  # Click on any order number
>  # Navigate to order item section of the page
>  # Click on view image button for any product
> Actual: A new tab is opened but the image is not displayed. Please refer 
> attachment: NoImage.mp4
> [^NoImage.mp4]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11734) View Image button on order view page fails to render the image

2020-05-23 Thread Arpit Mor (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114698#comment-17114698
 ] 

Arpit Mor commented on OFBIZ-11734:
---

Hi, [~pierresmits]

If it is not needed on order entry screen then can we remove the view image 
button?

> View Image button on order view page fails to render the image
> --
>
> Key: OFBIZ-11734
> URL: https://issues.apache.org/jira/browse/OFBIZ-11734
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: 17.12.03, Trunk
>Reporter: Arpit Mor
>Assignee: Saurabh Dixit
>Priority: Minor
> Attachments: NoImage.mp4
>
>
> Pre-requisite:
>  * At least one order should exist in the system
> Steps to regenerate:
>  # Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist]
>  # Click on any order number
>  # Navigate to order item section of the page
>  # Click on view image button for any product
> Actual: A new tab is opened but the image is not displayed. Please refer 
> attachment: NoImage.mp4
> [^NoImage.mp4]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11401) getEntityRefData service has a weird issue

2020-05-23 Thread Ankush Upadhyay (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114697#comment-17114697
 ] 

Ankush Upadhyay commented on OFBIZ-11401:
-

One more point I want to add, the exception printing taking extra time that 
increase total execution time of service. On my local with existing error logs 
it is taking 6-7 seconds and without it, 2-3 seconds that is almost half time.

> getEntityRefData service has a weird issue
> --
>
> Key: OFBIZ-11401
> URL: https://issues.apache.org/jira/browse/OFBIZ-11401
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
>
> It's reproductible on trunk demo though only visible in log, UI shows no issue
> Here is the log on trunk demo
> {noformat}
> 2020-02-21 21:11:56,445 |ajp-nio-8009-exec-2  |WebToolsServices  
> |E| null
> java.util.MissingResourceException: Can't find resource for bundle 
> org.apache.ofbiz.base.util.UtilProperties$UtilResourceBundle, key 
> FieldDescription.WorkEffortType.createdTxStamp
>   at java.util.ResourceBundle.getObject(ResourceBundle.java:450) 
> ~[?:1.8.0_242]
>   at java.util.ResourceBundle.getObject(ResourceBundle.java:444) 
> ~[?:1.8.0_242]
>   at java.util.ResourceBundle.getString(ResourceBundle.java:407) 
> ~[?:1.8.0_242]
>   at 
> org.apache.ofbiz.webtools.WebToolsServices.getEntityRefData(WebToolsServices.java:685)
>  [main/:?]
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_242]
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_242]
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_242]
>   at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_242]
>   at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
>  [main/:?]
>   [...]
>   at 
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
>  [tomcat-util-9.0.29.jar:9.0.29]
>   at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242]
> 2020-02-21 21:11:56,445 |ajp-nio-8009-exec-2  |WebToolsServices  
> |E| null
> java.util.MissingResourceException: Can't find resource for bundle 
> org.apache.ofbiz.base.util.UtilProperties$UtilResourceBundle, key 
> FieldDescription.createdTxStamp
>   at java.util.ResourceBundle.getObject(ResourceBundle.java:450) 
> ~[?:1.8.0_242]
>   at java.util.ResourceBundle.getObject(ResourceBundle.java:444) 
> ~[?:1.8.0_242]
>   at java.util.ResourceBundle.getString(ResourceBundle.java:407) 
> ~[?:1.8.0_242]
>   at 
> org.apache.ofbiz.webtools.WebToolsServices.getEntityRefData(WebToolsServices.java:695)
>  [main/:?]
>   [...]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  [?:1.8.0_242]
>   at 
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
>  [tomcat-util-9.0.29.jar:9.0.29]
>   at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242]
> 2020-02-21 21:11:56,445 |ajp-nio-8009-exec-2  |ServiceDispatcher 
> |T| Sync service [webtools/getEntityRefData] finished in [5760] milliseconds
>   at 
> org.apache.ofbiz.webtools.WebToolsServices.getEntityRefData(WebToolsServices.java:685)
>  [main/:?]
> {noformat}
> So it repeats almost "ad ib" and eventually stops after 5+ seconds there.
> I guess R17 and R18 are also affected, R16 is OK.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11561) Convert testUpdateRateAmount test from XML to Groovy

2020-05-23 Thread Anushi Gupta (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114695#comment-17114695
 ] 

Anushi Gupta commented on OFBIZ-11561:
--

Provided the patch

This can be tested using

./gradlew "ofbiz --test component=accounting --test suitename=ratetests"

Thanks.

> Convert testUpdateRateAmount test from XML to Groovy
> 
>
> Key: OFBIZ-11561
> URL: https://issues.apache.org/jira/browse/OFBIZ-11561
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Anushi Gupta
>Priority: Minor
> Attachments: OFBIZ-11561.patch
>
>
> Convert testUpdateRateAmount test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11561) Convert testUpdateRateAmount test from XML to Groovy

2020-05-23 Thread Anushi Gupta (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anushi Gupta updated OFBIZ-11561:
-
Attachment: OFBIZ-11561.patch

> Convert testUpdateRateAmount test from XML to Groovy
> 
>
> Key: OFBIZ-11561
> URL: https://issues.apache.org/jira/browse/OFBIZ-11561
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Anushi Gupta
>Priority: Minor
> Attachments: OFBIZ-11561.patch
>
>
> Convert testUpdateRateAmount test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11734) View Image button on order view page fails to render the image

2020-05-23 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114694#comment-17114694
 ] 

Pierre Smits commented on OFBIZ-11734:
--

Is that truly need in the order entry screen?

There is already a link to the product in the catalog, where the image can be 
viewed.

> View Image button on order view page fails to render the image
> --
>
> Key: OFBIZ-11734
> URL: https://issues.apache.org/jira/browse/OFBIZ-11734
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: 17.12.03, Trunk
>Reporter: Arpit Mor
>Assignee: Saurabh Dixit
>Priority: Minor
> Attachments: NoImage.mp4
>
>
> Pre-requisite:
>  * At least one order should exist in the system
> Steps to regenerate:
>  # Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist]
>  # Click on any order number
>  # Navigate to order item section of the page
>  # Click on view image button for any product
> Actual: A new tab is opened but the image is not displayed. Please refer 
> attachment: NoImage.mp4
> [^NoImage.mp4]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11734) View Image button on order view page fails to render the image

2020-05-23 Thread Arpit Mor (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Mor reassigned OFBIZ-11734:
-

Assignee: Saurabh Dixit

> View Image button on order view page fails to render the image
> --
>
> Key: OFBIZ-11734
> URL: https://issues.apache.org/jira/browse/OFBIZ-11734
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: 17.12.03, Trunk
>Reporter: Arpit Mor
>Assignee: Saurabh Dixit
>Priority: Minor
> Attachments: NoImage.mp4
>
>
> Pre-requisite:
>  * At least one order should exist in the system
> Steps to regenerate:
>  # Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist]
>  # Click on any order number
>  # Navigate to order item section of the page
>  # Click on view image button for any product
> Actual: A new tab is opened but the image is not displayed. Please refer 
> attachment: NoImage.mp4
> [^NoImage.mp4]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11356) FindOrders.ftl: paginateOrderList does not find orders on next page

2020-05-23 Thread Aditya Sharma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-11356:
--
Sprint: OFBiz Community Day (May 2020)

> FindOrders.ftl: paginateOrderList does not find orders on next page
> ---
>
> Key: OFBIZ-11356
> URL: https://issues.apache.org/jira/browse/OFBIZ-11356
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Michael Brohl
>Assignee: Aditya Sharma
>Priority: Critical
> Fix For: 18.12.01, 17.12.04
>
> Attachments: OFBIZ-11356.patch
>
>
> Steps to reproduce
>  # go to [https://localhost:8443/ordermgr/control/findorders]
>  # click "Search" -> 4 entries are displayed
>  # got to [https://localhost:8443/ordermgr/control/searchorders?viewSize=1] 
> to manipulate the viewSize
>  # click "Search" again -> 1 entry is displayed
>  # click "Next" (javascript:paginateOrderList('1','1','Y') is triggered 
> correctly)
>  # the result shows no entries



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11356) FindOrders.ftl: paginateOrderList does not find orders on next page

2020-05-23 Thread Aditya Sharma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma closed OFBIZ-11356.
-
Fix Version/s: 17.12.04
   18.12.01
   Resolution: Fixed

This has been committed.
Thanks Michael Brohl for reporting the issue and Ankit Joshi for the patch.
Thanks [~pierresmits] for sharing the concern, I think it seems to me that it 
is not related to OFBIZ-6705, hence closing.

> FindOrders.ftl: paginateOrderList does not find orders on next page
> ---
>
> Key: OFBIZ-11356
> URL: https://issues.apache.org/jira/browse/OFBIZ-11356
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Michael Brohl
>Assignee: Aditya Sharma
>Priority: Critical
> Fix For: 18.12.01, 17.12.04
>
> Attachments: OFBIZ-11356.patch
>
>
> Steps to reproduce
>  # go to [https://localhost:8443/ordermgr/control/findorders]
>  # click "Search" -> 4 entries are displayed
>  # got to [https://localhost:8443/ordermgr/control/searchorders?viewSize=1] 
> to manipulate the viewSize
>  # click "Search" again -> 1 entry is displayed
>  # click "Next" (javascript:paginateOrderList('1','1','Y') is triggered 
> correctly)
>  # the result shows no entries



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11734) View Image button on order view page fails to render the image

2020-05-23 Thread Arpit Mor (Jira)
Arpit Mor created OFBIZ-11734:
-

 Summary: View Image button on order view page fails to render the 
image
 Key: OFBIZ-11734
 URL: https://issues.apache.org/jira/browse/OFBIZ-11734
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Trunk, 17.12.03
Reporter: Arpit Mor
 Attachments: NoImage.mp4

Pre-requisite:
 * At least one order should exist in the system

Steps to regenerate:
 # Navigate to URL: 
[https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist]
 # Click on any order number
 # Navigate to order item section of the page
 # Click on view image button for any product

Actual: A new tab is opened but the image is not displayed. Please refer 
attachment: NoImage.mp4

[^NoImage.mp4]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11356) FindOrders.ftl: paginateOrderList does not find orders on next page

2020-05-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114689#comment-17114689
 ] 

ASF subversion and git services commented on OFBIZ-11356:
-

Commit cbeffa91f0e6b755aa9de2ae919dde6acd07a536 in ofbiz-framework's branch 
refs/heads/release17.12 from Aditya Sharma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=cbeffa9 ]

Fixed: paginateOrderList does not find orders on next page specific to 
FindOrders.ftl
(OFBIZ-11356)
Adding the missing showAll flag in the paginateOrder form because of which the 
orders were not shown while submitting the next button.
Thanks Michael Brohl for reporting the issue and Ankit Joshi for providing the 
patch


> FindOrders.ftl: paginateOrderList does not find orders on next page
> ---
>
> Key: OFBIZ-11356
> URL: https://issues.apache.org/jira/browse/OFBIZ-11356
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Michael Brohl
>Assignee: Aditya Sharma
>Priority: Critical
> Attachments: OFBIZ-11356.patch
>
>
> Steps to reproduce
>  # go to [https://localhost:8443/ordermgr/control/findorders]
>  # click "Search" -> 4 entries are displayed
>  # got to [https://localhost:8443/ordermgr/control/searchorders?viewSize=1] 
> to manipulate the viewSize
>  # click "Search" again -> 1 entry is displayed
>  # click "Next" (javascript:paginateOrderList('1','1','Y') is triggered 
> correctly)
>  # the result shows no entries



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #159: Improved: Converted the setPaymentStatus service from XML to groovy DSL. [OFBIZ-11482]

2020-05-23 Thread GitBox


sonarcloud[bot] commented on pull request #159:
URL: https://github.com/apache/ofbiz-framework/pull/159#issuecomment-633026359


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=159=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=159=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=159=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=159=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=159=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=159=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=159=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=159=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=159=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=159=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=159=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=159)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=159=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=159=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-11482) Convert setPaymentStatus service from mini-lang to groovy DSL

2020-05-23 Thread Devanshu Vyas (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114688#comment-17114688
 ] 

Devanshu Vyas commented on OFBIZ-11482:
---

I have created a pull request for the ticket.

[https://github.com/apache/ofbiz-framework/pull/159]

> Convert setPaymentStatus service from mini-lang to groovy DSL
> -
>
> Key: OFBIZ-11482
> URL: https://issues.apache.org/jira/browse/OFBIZ-11482
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Devanshu Vyas
>Priority: Minor
>
> Convert the setPaymentStatus service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] vyasdevanshu opened a new pull request #159: Improved: Converted the setPaymentStatus service from XML to groovy DSL. [OFBIZ-11482]

2020-05-23 Thread GitBox


vyasdevanshu opened a new pull request #159:
URL: https://github.com/apache/ofbiz-framework/pull/159


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-11356) FindOrders.ftl: paginateOrderList does not find orders on next page

2020-05-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114687#comment-17114687
 ] 

ASF subversion and git services commented on OFBIZ-11356:
-

Commit 754414d1581094ced2c9310d7d989d0485413722 in ofbiz-framework's branch 
refs/heads/release18.12 from Aditya Sharma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=754414d ]

Fixed: paginateOrderList does not find orders on next page specific to 
FindOrders.ftl
(OFBIZ-11356)
Adding the missing showAll flag in the paginateOrder form because of which the 
orders were not shown while submitting the next button.
Thanks Michael Brohl for reporting the issue and Ankit Joshi for providing the 
patch


> FindOrders.ftl: paginateOrderList does not find orders on next page
> ---
>
> Key: OFBIZ-11356
> URL: https://issues.apache.org/jira/browse/OFBIZ-11356
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Michael Brohl
>Assignee: Aditya Sharma
>Priority: Critical
> Attachments: OFBIZ-11356.patch
>
>
> Steps to reproduce
>  # go to [https://localhost:8443/ordermgr/control/findorders]
>  # click "Search" -> 4 entries are displayed
>  # got to [https://localhost:8443/ordermgr/control/searchorders?viewSize=1] 
> to manipulate the viewSize
>  # click "Search" again -> 1 entry is displayed
>  # click "Next" (javascript:paginateOrderList('1','1','Y') is triggered 
> correctly)
>  # the result shows no entries



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11401) getEntityRefData service has a weird issue

2020-05-23 Thread Ankush Upadhyay (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114681#comment-17114681
 ] 

Ankush Upadhyay edited comment on OFBIZ-11401 at 5/23/20, 10:49 AM:


[~pierresmits], Yes you got it correctly, this is the case of missing entity 
labels.

 

[~pierresmits], [~jleroux]

I tried to print the list of entities for them the exception is getting printed 
on service run.

Here are the list:

[FinAccountTransType, FinAccountType, FixedAssetIdentType, 
FixedAssetProductType, FixedAssetStdCostType, FixedAssetType, InvoiceItemType, 
InvoiceType, AcctgTransType, GlAccountClass, GlAccountType, GlFiscalType, 
GlResourceType, ProductAverageCostType, PaymentMethodType, PaymentType, 
RateType, TaxAuthorityAssocType, TaxAuthorityRateType, DataSource, Enumeration, 
EnumerationType, CountryAddressFormat, Geo, GeoAssocType, GeoPoint, GeoType, 
CustomMethod, PortalPage, CustomScreen, StatusItem, StatusType, 
StatusValidChange, VisualTheme, Uom, UomGroup, UomType, Content, 
ContentAssocPredicate, ContentAssocType, ContentOperation, ContentPurposeType, 
ContentType, CharacterSet, DataCategory, DataResourceType, DataTemplateType, 
MetaDataPredicate, MimeType, MimeTypeHtmlTemplate, DocumentType, 
SurveyApplType, SurveyQuestionType, WebSiteContentType, ExampleItem, 
ExampleStatus, ExampleType, ExampleFeature, ExampleFeatureAppl, 
ExampleFeatureApplType, EmplLeaveReasonType, EmplLeaveType, MrpEventType, 
TechDataCalendar, TechDataCalendarWeek, ContactListType, SegmentGroupType, 
TrackingCodeType, OrderAdjustmentType, OrderBlacklistType, OrderContentType, 
OrderItemType, OrderType, QuoteType, CustRequestResolution, CustRequestType, 
RequirementType, WorkReqFulfType, ReturnAdjustmentType, ReturnReason, 
ReturnType, ShoppingListType, AgreementItemType, AgreementType, TermType, 
CommunicationEventPrpTyp, CommunicationEventType, ContactMechPurposeType, 
ContactMechType, PartyClassificationType, PartyContentType, 
PartyIdentificationType, PartyRelationshipType, PartyType, RoleType, 
ProdCatalog, ProdCatalogCategory, ProdCatalogCategoryType, 
ProdCatalogInvFacility, ProdCatalogRole, ProductAndCategoryMember, 
ProductCategory, ProductCategoryAndMember, ProductCategoryAttribute, 
ProductCategoryContent, ProductCategoryContentAndInfo, 
ProductCategoryContentType, ProductCategoryGlAccount, ProductCategoryLink, 
ProductCategoryMember, ProductCategoryMemberAndRole, ProductCategoryRole, 
ProductCategoryRollup, ProductCategoryRollupAndChild, 
ProductCategoryRollupAndRole, ProductCategoryType, ProductCategoryTypeAttr, 
ConfigOptionProductOption, ProdConfItemContent, ProdConfItemContentType, 
ProductConfig, ProductConfigAndProduct, ProductConfigConfig, ProductConfigItem, 
ProductConfigOption, ProductConfigOptionIactn, ProductConfigProduct, 
ProductConfigStats, CostComponent, CostComponentAttribute, CostComponentCalc, 
CostComponentType, CostComponentTypeAttr, ProductCostComponentCalc, Container, 
ContainerAndGeoPoint, ContainerGeoPoint, ContainerType, Facility, 
FacilityAndContactMech, FacilityAssocType, FacilityAttribute, FacilityCalendar, 
FacilityCalendarType, FacilityCarrierShipment, FacilityContactMech, 
FacilityContactMechPurpose, FacilityContent, FacilityContentDetail, 
FacilityGroup, FacilityGroupMember, FacilityGroupRole, FacilityGroupRollup, 
FacilityGroupType, FacilityLocation, FacilityLocationAndGeoPoint, 
FacilityLocationGeoPoint, FacilityParty, FacilityType, FacilityTypeAttr, 
ProductFacility, ProductFacilityAndPostalAddress, ProductFacilityAssoc, 
ProductFacilityLocation, ProductFacilityLocationQuantityTest, 
ProductFacilityLocationView, ProdFeaGrpAppAndProdFeaApp, ProductFeature, 
ProductFeatureAndAppl, ProductFeatureAppl, ProductFeatureApplAttr, 
ProductFeatureApplType, ProductFeatureCatGrpAppl, ProductFeatureCategory, 
ProductFeatureCategoryAppl, ProductFeatureDataResource, ProductFeatureGroup, 
ProductFeatureGroupAndAppl, ProductFeatureGroupAppl, ProductFeatureIactn, 
ProductFeatureIactnType, ProductFeatureType, BalanceInventoryItemsView, 
InventoryItem, InventoryItemAndDetail, InventoryItemAndLocation, 
InventoryItemAttribute, InventoryItemDetail, InventoryItemDetailForSum, 
InventoryItemDetailSummary, InventoryItemLabel, InventoryItemLabelAppl, 
InventoryItemLabelType, InventoryItemStatus, InventoryItemStatusForCount, 
InventoryItemTempRes, InventoryItemType, InventoryItemTypeAttr, 
InventoryItemVariance, InventoryTransfer, Lot, PhysicalInventory, 
PhysicalInventoryAndVariance, VarianceReason, ProductFeaturePrice, 
ProductPaymentMethodType, ProductPrice, ProductPriceAction, 
ProductPriceActionType, ProductPriceAutoNotice, ProductPriceChange, 
ProductPriceCond, ProductPricePurpose, ProductPriceRule, ProductPriceType, 
QuantityBreak, QuantityBreakType, SaleType, GoodIdentification, 
GoodIdentificationAndProduct, GoodIdentificationType, Product, ProductAndAssoc, 
ProductAndPriceView, 

[jira] [Commented] (OFBIZ-11356) FindOrders.ftl: paginateOrderList does not find orders on next page

2020-05-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114685#comment-17114685
 ] 

ASF subversion and git services commented on OFBIZ-11356:
-

Commit 3a2a9df44b28b052c19efe905d2f84c781e87f96 in ofbiz-framework's branch 
refs/heads/trunk from Aditya Sharma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3a2a9df ]

Fixed: paginateOrderList does not find orders on next page specific to 
FindOrders.ftl
(OFBIZ-11356)
Adding the missing showAll flag in the paginateOrder form because of which the 
orders were not shown while submitting the next button.
Thanks Michael Brohl for reporting the issue and Ankit Joshi for providing the 
patch


> FindOrders.ftl: paginateOrderList does not find orders on next page
> ---
>
> Key: OFBIZ-11356
> URL: https://issues.apache.org/jira/browse/OFBIZ-11356
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Michael Brohl
>Assignee: Aditya Sharma
>Priority: Critical
> Attachments: OFBIZ-11356.patch
>
>
> Steps to reproduce
>  # go to [https://localhost:8443/ordermgr/control/findorders]
>  # click "Search" -> 4 entries are displayed
>  # got to [https://localhost:8443/ordermgr/control/searchorders?viewSize=1] 
> to manipulate the viewSize
>  # click "Search" again -> 1 entry is displayed
>  # click "Next" (javascript:paginateOrderList('1','1','Y') is triggered 
> correctly)
>  # the result shows no entries



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11401) getEntityRefData service has a weird issue

2020-05-23 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114684#comment-17114684
 ] 

Pierre Smits commented on OFBIZ-11401:
--

IMO, a warning in the log is way better than an error...

A potential adopter may look at a warning and say: 'ok, it's there but it is 
manageable'. Whereas when seeing the error (or being told by influencers) he 
may conclude not to opt for OFBiz, because 'of all the errors'.

> getEntityRefData service has a weird issue
> --
>
> Key: OFBIZ-11401
> URL: https://issues.apache.org/jira/browse/OFBIZ-11401
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
>
> It's reproductible on trunk demo though only visible in log, UI shows no issue
> Here is the log on trunk demo
> {noformat}
> 2020-02-21 21:11:56,445 |ajp-nio-8009-exec-2  |WebToolsServices  
> |E| null
> java.util.MissingResourceException: Can't find resource for bundle 
> org.apache.ofbiz.base.util.UtilProperties$UtilResourceBundle, key 
> FieldDescription.WorkEffortType.createdTxStamp
>   at java.util.ResourceBundle.getObject(ResourceBundle.java:450) 
> ~[?:1.8.0_242]
>   at java.util.ResourceBundle.getObject(ResourceBundle.java:444) 
> ~[?:1.8.0_242]
>   at java.util.ResourceBundle.getString(ResourceBundle.java:407) 
> ~[?:1.8.0_242]
>   at 
> org.apache.ofbiz.webtools.WebToolsServices.getEntityRefData(WebToolsServices.java:685)
>  [main/:?]
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_242]
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_242]
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_242]
>   at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_242]
>   at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
>  [main/:?]
>   [...]
>   at 
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
>  [tomcat-util-9.0.29.jar:9.0.29]
>   at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242]
> 2020-02-21 21:11:56,445 |ajp-nio-8009-exec-2  |WebToolsServices  
> |E| null
> java.util.MissingResourceException: Can't find resource for bundle 
> org.apache.ofbiz.base.util.UtilProperties$UtilResourceBundle, key 
> FieldDescription.createdTxStamp
>   at java.util.ResourceBundle.getObject(ResourceBundle.java:450) 
> ~[?:1.8.0_242]
>   at java.util.ResourceBundle.getObject(ResourceBundle.java:444) 
> ~[?:1.8.0_242]
>   at java.util.ResourceBundle.getString(ResourceBundle.java:407) 
> ~[?:1.8.0_242]
>   at 
> org.apache.ofbiz.webtools.WebToolsServices.getEntityRefData(WebToolsServices.java:695)
>  [main/:?]
>   [...]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  [?:1.8.0_242]
>   at 
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
>  [tomcat-util-9.0.29.jar:9.0.29]
>   at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242]
> 2020-02-21 21:11:56,445 |ajp-nio-8009-exec-2  |ServiceDispatcher 
> |T| Sync service [webtools/getEntityRefData] finished in [5760] milliseconds
>   at 
> org.apache.ofbiz.webtools.WebToolsServices.getEntityRefData(WebToolsServices.java:685)
>  [main/:?]
> {noformat}
> So it repeats almost "ad ib" and eventually stops after 5+ seconds there.
> I guess R17 and R18 are also affected, R16 is OK.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11401) getEntityRefData service has a weird issue

2020-05-23 Thread Ankush Upadhyay (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114681#comment-17114681
 ] 

Ankush Upadhyay edited comment on OFBIZ-11401 at 5/23/20, 10:46 AM:


[~pierresmits], Yes you got it correctly, this is the case of missing entity 
labels.

 

[~pierresmits], [~jleroux]

I tried to print the list of entities for them the exception is getting printed 
on service run.

Here are the list:

[FinAccountTransType, FinAccountType, FixedAssetIdentType, 
FixedAssetProductType, FixedAssetStdCostType, FixedAssetType, InvoiceItemType, 
InvoiceType, AcctgTransType, GlAccountClass, GlAccountType, GlFiscalType, 
GlResourceType, ProductAverageCostType, PaymentMethodType, PaymentType, 
RateType, TaxAuthorityAssocType, TaxAuthorityRateType, DataSource, Enumeration, 
EnumerationType, CountryAddressFormat, Geo, GeoAssocType, GeoPoint, GeoType, 
CustomMethod, PortalPage, CustomScreen, StatusItem, StatusType, 
StatusValidChange, VisualTheme, Uom, UomGroup, UomType, Content, 
ContentAssocPredicate, ContentAssocType, ContentOperation, ContentPurposeType, 
ContentType, CharacterSet, DataCategory, DataResourceType, DataTemplateType, 
MetaDataPredicate, MimeType, MimeTypeHtmlTemplate, DocumentType, 
SurveyApplType, SurveyQuestionType, WebSiteContentType, ExampleItem, 
ExampleStatus, ExampleType, ExampleFeature, ExampleFeatureAppl, 
ExampleFeatureApplType, EmplLeaveReasonType, EmplLeaveType, MrpEventType, 
TechDataCalendar, TechDataCalendarWeek, ContactListType, SegmentGroupType, 
TrackingCodeType, OrderAdjustmentType, OrderBlacklistType, OrderContentType, 
OrderItemType, OrderType, QuoteType, CustRequestResolution, CustRequestType, 
RequirementType, WorkReqFulfType, ReturnAdjustmentType, ReturnReason, 
ReturnType, ShoppingListType, AgreementItemType, AgreementType, TermType, 
CommunicationEventPrpTyp, CommunicationEventType, ContactMechPurposeType, 
ContactMechType, PartyClassificationType, PartyContentType, 
PartyIdentificationType, PartyRelationshipType, PartyType, RoleType, 
ProdCatalog, ProdCatalogCategory, ProdCatalogCategoryType, 
ProdCatalogInvFacility, ProdCatalogRole, ProductAndCategoryMember, 
ProductCategory, ProductCategoryAndMember, ProductCategoryAttribute, 
ProductCategoryContent, ProductCategoryContentAndInfo, 
ProductCategoryContentType, ProductCategoryGlAccount, ProductCategoryLink, 
ProductCategoryMember, ProductCategoryMemberAndRole, ProductCategoryRole, 
ProductCategoryRollup, ProductCategoryRollupAndChild, 
ProductCategoryRollupAndRole, ProductCategoryType, ProductCategoryTypeAttr, 
ConfigOptionProductOption, ProdConfItemContent, ProdConfItemContentType, 
ProductConfig, ProductConfigAndProduct, ProductConfigConfig, ProductConfigItem, 
ProductConfigOption, ProductConfigOptionIactn, ProductConfigProduct, 
ProductConfigStats, CostComponent, CostComponentAttribute, CostComponentCalc, 
CostComponentType, CostComponentTypeAttr, ProductCostComponentCalc, Container, 
ContainerAndGeoPoint, ContainerGeoPoint, ContainerType, Facility, 
FacilityAndContactMech, FacilityAssocType, FacilityAttribute, FacilityCalendar, 
FacilityCalendarType, FacilityCarrierShipment, FacilityContactMech, 
FacilityContactMechPurpose, FacilityContent, FacilityContentDetail, 
FacilityGroup, FacilityGroupMember, FacilityGroupRole, FacilityGroupRollup, 
FacilityGroupType, FacilityLocation, FacilityLocationAndGeoPoint, 
FacilityLocationGeoPoint, FacilityParty, FacilityType, FacilityTypeAttr, 
ProductFacility, ProductFacilityAndPostalAddress, ProductFacilityAssoc, 
ProductFacilityLocation, ProductFacilityLocationQuantityTest, 
ProductFacilityLocationView, ProdFeaGrpAppAndProdFeaApp, ProductFeature, 
ProductFeatureAndAppl, ProductFeatureAppl, ProductFeatureApplAttr, 
ProductFeatureApplType, ProductFeatureCatGrpAppl, ProductFeatureCategory, 
ProductFeatureCategoryAppl, ProductFeatureDataResource, ProductFeatureGroup, 
ProductFeatureGroupAndAppl, ProductFeatureGroupAppl, ProductFeatureIactn, 
ProductFeatureIactnType, ProductFeatureType, BalanceInventoryItemsView, 
InventoryItem, InventoryItemAndDetail, InventoryItemAndLocation, 
InventoryItemAttribute, InventoryItemDetail, InventoryItemDetailForSum, 
InventoryItemDetailSummary, InventoryItemLabel, InventoryItemLabelAppl, 
InventoryItemLabelType, InventoryItemStatus, InventoryItemStatusForCount, 
InventoryItemTempRes, InventoryItemType, InventoryItemTypeAttr, 
InventoryItemVariance, InventoryTransfer, Lot, PhysicalInventory, 
PhysicalInventoryAndVariance, VarianceReason, ProductFeaturePrice, 
ProductPaymentMethodType, ProductPrice, ProductPriceAction, 
ProductPriceActionType, ProductPriceAutoNotice, ProductPriceChange, 
ProductPriceCond, ProductPricePurpose, ProductPriceRule, ProductPriceType, 
QuantityBreak, QuantityBreakType, SaleType, GoodIdentification, 
GoodIdentificationAndProduct, GoodIdentificationType, Product, ProductAndAssoc, 
ProductAndPriceView, 

[jira] [Commented] (OFBIZ-11679) OFBiz - Shopify integration plugin

2020-05-23 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114683#comment-17114683
 ] 

Pawan Verma commented on OFBIZ-11679:
-

Hey Guys,

Thanks for this great new feature, it would really add value.

I would like to suggest that we should first work on the design document for 
this task, that might contain
-- data model changes
-- screen-flow
-- business-logic and etc.

My point here is it is easy to provide feedback and suggestion in the design 
phase instead of after implementation to avoid unnecessary development changes.

We have an example for the design task: 
https://issues.apache.org/jira/browse/OFBIZ-10365

HTH!

> OFBiz - Shopify integration plugin
> --
>
> Key: OFBIZ-11679
> URL: https://issues.apache.org/jira/browse/OFBIZ-11679
> Project: OFBiz
>  Issue Type: New Feature
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
>
> Here is the reference of ML discussion: 
> [https://markmail.org/thread/pktfygbz44a7z5kk]
> This integration can be used to provide Order and Fulfillment Management to 
> the orders placed via Shopify store.
> We are taking reference from available Magento plugin and planning to built 
> the same features as MVP. As an MVP, minimal features to implement are:
> – Import locations
> – Import products
> – Import pending orders
> – Create fulfillment on Shopify ie push shipment details and tracking code to 
> Shopify
> After MVP, we will further move with other features like:
> – Edit Order
> – Order Cancellation
> – Returns
> Reference Shopify API documents:
> [https://shopify.dev/docs/admin-api/rest/reference|https://shopify.dev/docs/admin-api/rest/reference]
> We are planning to manage all the configurations in SystemProperty.
> Thanks [~surajk] and [~ritesh.kumar] for discussing things.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11401) getEntityRefData service has a weird issue

2020-05-23 Thread Ankush Upadhyay (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114681#comment-17114681
 ] 

Ankush Upadhyay edited comment on OFBIZ-11401 at 5/23/20, 10:43 AM:


[~pierresmits], Yes you got it correctly, this is the case of missing entity 
labels.

 

[~pierresmits], [~jleroux]

I tried to print the list of entities for them the exception is getting printed 
on service run.

Here are the list:

[FinAccountTransType, FinAccountType, FixedAssetIdentType, 
FixedAssetProductType, FixedAssetStdCostType, FixedAssetType, InvoiceItemType, 
InvoiceType, AcctgTransType, GlAccountClass, GlAccountType, GlFiscalType, 
GlResourceType, ProductAverageCostType, PaymentMethodType, PaymentType, 
RateType, TaxAuthorityAssocType, TaxAuthorityRateType, DataSource, Enumeration, 
EnumerationType, CountryAddressFormat, Geo, GeoAssocType, GeoPoint, GeoType, 
CustomMethod, PortalPage, CustomScreen, StatusItem, StatusType, 
StatusValidChange, VisualTheme, Uom, UomGroup, UomType, Content, 
ContentAssocPredicate, ContentAssocType, ContentOperation, ContentPurposeType, 
ContentType, CharacterSet, DataCategory, DataResourceType, DataTemplateType, 
MetaDataPredicate, MimeType, MimeTypeHtmlTemplate, DocumentType, 
SurveyApplType, SurveyQuestionType, WebSiteContentType, ExampleItem, 
ExampleStatus, ExampleType, ExampleFeature, ExampleFeatureAppl, 
ExampleFeatureApplType, EmplLeaveReasonType, EmplLeaveType, MrpEventType, 
TechDataCalendar, TechDataCalendarWeek, ContactListType, SegmentGroupType, 
TrackingCodeType, OrderAdjustmentType, OrderBlacklistType, OrderContentType, 
OrderItemType, OrderType, QuoteType, CustRequestResolution, CustRequestType, 
RequirementType, WorkReqFulfType, ReturnAdjustmentType, ReturnReason, 
ReturnType, ShoppingListType, AgreementItemType, AgreementType, TermType, 
CommunicationEventPrpTyp, CommunicationEventType, ContactMechPurposeType, 
ContactMechType, PartyClassificationType, PartyContentType, 
PartyIdentificationType, PartyRelationshipType, PartyType, RoleType, 
ProdCatalog, ProdCatalogCategory, ProdCatalogCategoryType, 
ProdCatalogInvFacility, ProdCatalogRole, ProductAndCategoryMember, 
ProductCategory, ProductCategoryAndMember, ProductCategoryAttribute, 
ProductCategoryContent, ProductCategoryContentAndInfo, 
ProductCategoryContentType, ProductCategoryGlAccount, ProductCategoryLink, 
ProductCategoryMember, ProductCategoryMemberAndRole, ProductCategoryRole, 
ProductCategoryRollup, ProductCategoryRollupAndChild, 
ProductCategoryRollupAndRole, ProductCategoryType, ProductCategoryTypeAttr, 
ConfigOptionProductOption, ProdConfItemContent, ProdConfItemContentType, 
ProductConfig, ProductConfigAndProduct, ProductConfigConfig, ProductConfigItem, 
ProductConfigOption, ProductConfigOptionIactn, ProductConfigProduct, 
ProductConfigStats, CostComponent, CostComponentAttribute, CostComponentCalc, 
CostComponentType, CostComponentTypeAttr, ProductCostComponentCalc, Container, 
ContainerAndGeoPoint, ContainerGeoPoint, ContainerType, Facility, 
FacilityAndContactMech, FacilityAssocType, FacilityAttribute, FacilityCalendar, 
FacilityCalendarType, FacilityCarrierShipment, FacilityContactMech, 
FacilityContactMechPurpose, FacilityContent, FacilityContentDetail, 
FacilityGroup, FacilityGroupMember, FacilityGroupRole, FacilityGroupRollup, 
FacilityGroupType, FacilityLocation, FacilityLocationAndGeoPoint, 
FacilityLocationGeoPoint, FacilityParty, FacilityType, FacilityTypeAttr, 
ProductFacility, ProductFacilityAndPostalAddress, ProductFacilityAssoc, 
ProductFacilityLocation, ProductFacilityLocationQuantityTest, 
ProductFacilityLocationView, ProdFeaGrpAppAndProdFeaApp, ProductFeature, 
ProductFeatureAndAppl, ProductFeatureAppl, ProductFeatureApplAttr, 
ProductFeatureApplType, ProductFeatureCatGrpAppl, ProductFeatureCategory, 
ProductFeatureCategoryAppl, ProductFeatureDataResource, ProductFeatureGroup, 
ProductFeatureGroupAndAppl, ProductFeatureGroupAppl, ProductFeatureIactn, 
ProductFeatureIactnType, ProductFeatureType, BalanceInventoryItemsView, 
InventoryItem, InventoryItemAndDetail, InventoryItemAndLocation, 
InventoryItemAttribute, InventoryItemDetail, InventoryItemDetailForSum, 
InventoryItemDetailSummary, InventoryItemLabel, InventoryItemLabelAppl, 
InventoryItemLabelType, InventoryItemStatus, InventoryItemStatusForCount, 
InventoryItemTempRes, InventoryItemType, InventoryItemTypeAttr, 
InventoryItemVariance, InventoryTransfer, Lot, PhysicalInventory, 
PhysicalInventoryAndVariance, VarianceReason, ProductFeaturePrice, 
ProductPaymentMethodType, ProductPrice, ProductPriceAction, 
ProductPriceActionType, ProductPriceAutoNotice, ProductPriceChange, 
ProductPriceCond, ProductPricePurpose, ProductPriceRule, ProductPriceType, 
QuantityBreak, QuantityBreakType, SaleType, GoodIdentification, 
GoodIdentificationAndProduct, GoodIdentificationType, Product, ProductAndAssoc, 
ProductAndPriceView, 

[jira] [Commented] (OFBIZ-11401) getEntityRefData service has a weird issue

2020-05-23 Thread Ankush Upadhyay (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114681#comment-17114681
 ] 

Ankush Upadhyay commented on OFBIZ-11401:
-

[~pierresmits], Yes you got it correctly, this is the case of missing entity 
labels.

I tried to print the list of entities for them the exception is getting printed 
on service run.

Here are the list:

[FinAccountTransType, FinAccountType, FixedAssetIdentType, 
FixedAssetProductType, FixedAssetStdCostType, FixedAssetType, InvoiceItemType, 
InvoiceType, AcctgTransType, GlAccountClass, GlAccountType, GlFiscalType, 
GlResourceType, ProductAverageCostType, PaymentMethodType, PaymentType, 
RateType, TaxAuthorityAssocType, TaxAuthorityRateType, DataSource, Enumeration, 
EnumerationType, CountryAddressFormat, Geo, GeoAssocType, GeoPoint, GeoType, 
CustomMethod, PortalPage, CustomScreen, StatusItem, StatusType, 
StatusValidChange, VisualTheme, Uom, UomGroup, UomType, Content, 
ContentAssocPredicate, ContentAssocType, ContentOperation, ContentPurposeType, 
ContentType, CharacterSet, DataCategory, DataResourceType, DataTemplateType, 
MetaDataPredicate, MimeType, MimeTypeHtmlTemplate, DocumentType, 
SurveyApplType, SurveyQuestionType, WebSiteContentType, ExampleItem, 
ExampleStatus, ExampleType, ExampleFeature, ExampleFeatureAppl, 
ExampleFeatureApplType, EmplLeaveReasonType, EmplLeaveType, MrpEventType, 
TechDataCalendar, TechDataCalendarWeek, ContactListType, SegmentGroupType, 
TrackingCodeType, OrderAdjustmentType, OrderBlacklistType, OrderContentType, 
OrderItemType, OrderType, QuoteType, CustRequestResolution, CustRequestType, 
RequirementType, WorkReqFulfType, ReturnAdjustmentType, ReturnReason, 
ReturnType, ShoppingListType, AgreementItemType, AgreementType, TermType, 
CommunicationEventPrpTyp, CommunicationEventType, ContactMechPurposeType, 
ContactMechType, PartyClassificationType, PartyContentType, 
PartyIdentificationType, PartyRelationshipType, PartyType, RoleType, 
ProdCatalog, ProdCatalogCategory, ProdCatalogCategoryType, 
ProdCatalogInvFacility, ProdCatalogRole, ProductAndCategoryMember, 
ProductCategory, ProductCategoryAndMember, ProductCategoryAttribute, 
ProductCategoryContent, ProductCategoryContentAndInfo, 
ProductCategoryContentType, ProductCategoryGlAccount, ProductCategoryLink, 
ProductCategoryMember, ProductCategoryMemberAndRole, ProductCategoryRole, 
ProductCategoryRollup, ProductCategoryRollupAndChild, 
ProductCategoryRollupAndRole, ProductCategoryType, ProductCategoryTypeAttr, 
ConfigOptionProductOption, ProdConfItemContent, ProdConfItemContentType, 
ProductConfig, ProductConfigAndProduct, ProductConfigConfig, ProductConfigItem, 
ProductConfigOption, ProductConfigOptionIactn, ProductConfigProduct, 
ProductConfigStats, CostComponent, CostComponentAttribute, CostComponentCalc, 
CostComponentType, CostComponentTypeAttr, ProductCostComponentCalc, Container, 
ContainerAndGeoPoint, ContainerGeoPoint, ContainerType, Facility, 
FacilityAndContactMech, FacilityAssocType, FacilityAttribute, FacilityCalendar, 
FacilityCalendarType, FacilityCarrierShipment, FacilityContactMech, 
FacilityContactMechPurpose, FacilityContent, FacilityContentDetail, 
FacilityGroup, FacilityGroupMember, FacilityGroupRole, FacilityGroupRollup, 
FacilityGroupType, FacilityLocation, FacilityLocationAndGeoPoint, 
FacilityLocationGeoPoint, FacilityParty, FacilityType, FacilityTypeAttr, 
ProductFacility, ProductFacilityAndPostalAddress, ProductFacilityAssoc, 
ProductFacilityLocation, ProductFacilityLocationQuantityTest, 
ProductFacilityLocationView, ProdFeaGrpAppAndProdFeaApp, ProductFeature, 
ProductFeatureAndAppl, ProductFeatureAppl, ProductFeatureApplAttr, 
ProductFeatureApplType, ProductFeatureCatGrpAppl, ProductFeatureCategory, 
ProductFeatureCategoryAppl, ProductFeatureDataResource, ProductFeatureGroup, 
ProductFeatureGroupAndAppl, ProductFeatureGroupAppl, ProductFeatureIactn, 
ProductFeatureIactnType, ProductFeatureType, BalanceInventoryItemsView, 
InventoryItem, InventoryItemAndDetail, InventoryItemAndLocation, 
InventoryItemAttribute, InventoryItemDetail, InventoryItemDetailForSum, 
InventoryItemDetailSummary, InventoryItemLabel, InventoryItemLabelAppl, 
InventoryItemLabelType, InventoryItemStatus, InventoryItemStatusForCount, 
InventoryItemTempRes, InventoryItemType, InventoryItemTypeAttr, 
InventoryItemVariance, InventoryTransfer, Lot, PhysicalInventory, 
PhysicalInventoryAndVariance, VarianceReason, ProductFeaturePrice, 
ProductPaymentMethodType, ProductPrice, ProductPriceAction, 
ProductPriceActionType, ProductPriceAutoNotice, ProductPriceChange, 
ProductPriceCond, ProductPricePurpose, ProductPriceRule, ProductPriceType, 
QuantityBreak, QuantityBreakType, SaleType, GoodIdentification, 
GoodIdentificationAndProduct, GoodIdentificationType, Product, ProductAndAssoc, 
ProductAndPriceView, ProductAssoc, ProductAssocType, ProductAttribute, 
ProductCalculatedInfo, 

[jira] [Assigned] (OFBIZ-11733) Improvement in Purchases by Product Report

2020-05-23 Thread Chandan Khandelwal (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chandan Khandelwal reassigned OFBIZ-11733:
--

Assignee: Chandan Khandelwal

> Improvement in Purchases by Product Report
> --
>
> Key: OFBIZ-11733
> URL: https://issues.apache.org/jira/browse/OFBIZ-11733
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Chandan Khandelwal
>Assignee: Chandan Khandelwal
>Priority: Minor
> Attachments: OFBIZ-11733
>
>
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/OrderPurchaseReportOptions]
> >> Generate Purchases by Product Report
> The status description should be used in report instead of OFBiz ID.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11733) Improvement in Purchases by Product Report

2020-05-23 Thread Chandan Khandelwal (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chandan Khandelwal reassigned OFBIZ-11733:
--

Assignee: (was: Chandan Khandelwal)

> Improvement in Purchases by Product Report
> --
>
> Key: OFBIZ-11733
> URL: https://issues.apache.org/jira/browse/OFBIZ-11733
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Chandan Khandelwal
>Priority: Minor
> Attachments: OFBIZ-11733
>
>
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/OrderPurchaseReportOptions]
> >> Generate Purchases by Product Report
> The status description should be used in report instead of OFBiz ID.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11733) Improvement in Purchases by Product Report

2020-05-23 Thread Chandan Khandelwal (Jira)
Chandan Khandelwal created OFBIZ-11733:
--

 Summary: Improvement in Purchases by Product Report
 Key: OFBIZ-11733
 URL: https://issues.apache.org/jira/browse/OFBIZ-11733
 Project: OFBiz
  Issue Type: Improvement
  Components: order
Affects Versions: Trunk
Reporter: Chandan Khandelwal
Assignee: Chandan Khandelwal
 Attachments: OFBIZ-11733

[https://demo-trunk.ofbiz.apache.org/ordermgr/control/OrderPurchaseReportOptions]

>> Generate Purchases by Product Report

The status description should be used in report instead of OFBiz ID.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11481) Convert createPaymentApplication service from mini-lang to groovy DSL

2020-05-23 Thread Priya Sharma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114680#comment-17114680
 ] 

Priya Sharma commented on OFBIZ-11481:
--

Hello all, 
I have created a PR for this task.

I have tried to keep the basic functionality and the logic as is, except the 
following -
 * simplified the logic to set the amount applied, if not set and either one of 
billingAccountId or taxAuthGeoId is available (line 200)

{code:java}










{code}
 * also eliminated the re-fetching of payment to set the paymentTypeId on the 
result, as we have already fetch it. (line 209)

{code:java}


{code}
Please review and provide your feedback.

> Convert createPaymentApplication service from mini-lang to groovy DSL
> -
>
> Key: OFBIZ-11481
> URL: https://issues.apache.org/jira/browse/OFBIZ-11481
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Priya Sharma
>Priority: Minor
>
> Convert the createPaymentApplication service code from mini-lang to groovy 
> DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11733) Improvement in Purchases by Product Report

2020-05-23 Thread Chandan Khandelwal (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chandan Khandelwal updated OFBIZ-11733:
---
Attachment: OFBIZ-11733

> Improvement in Purchases by Product Report
> --
>
> Key: OFBIZ-11733
> URL: https://issues.apache.org/jira/browse/OFBIZ-11733
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Chandan Khandelwal
>Assignee: Chandan Khandelwal
>Priority: Minor
> Attachments: OFBIZ-11733
>
>
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/OrderPurchaseReportOptions]
> >> Generate Purchases by Product Report
> The status description should be used in report instead of OFBiz ID.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #158: [Improved] Convert createPaymentApplication service from mini-lang to groovy DSL (OFBIZ-11481)

2020-05-23 Thread GitBox


sonarcloud[bot] commented on pull request #158:
URL: https://github.com/apache/ofbiz-framework/pull/158#issuecomment-633023787


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=158)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=158=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=158=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (OFBIZ-11732) Rendering issue on findorders page

2020-05-23 Thread Arpit Mor (Jira)
Arpit Mor created OFBIZ-11732:
-

 Summary: Rendering issue on findorders page
 Key: OFBIZ-11732
 URL: https://issues.apache.org/jira/browse/OFBIZ-11732
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Trunk
Reporter: Arpit Mor
 Attachments: RenderingIssue.png

Steps to regenerate:
 # Navigate to URL: 
[https://demo-trunk.ofbiz.apache.org/ordermgr/control/findorders]
 # Click on find button

Actual: Rendering issue on pages. Please refer attachment: RenderingIssue.jpg

!RenderingIssue.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10985) UI issue on View Order page

2020-05-23 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-10985:
-
Component/s: order

> UI issue on View Order page
> ---
>
> Key: OFBIZ-10985
> URL: https://issues.apache.org/jira/browse/OFBIZ-10985
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Rashi Dhagat
>Assignee: Aishwary Shrivastava
>Priority: Trivial
> Attachments: OFBIZ-10985.patch, ViewOrderPage.jpg
>
>
> Steps to regenerate:
>  # Open URL [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main]
>  # Click on any order in Approved status
> Actual:
>  # In Contact Information section, admin (username) is a button
>  # "Send confirmation email" button in brackets
> Expected: 
>  # Username should not be a button
>  # The button should not be in brackets.
> Please refer attachment for same.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11401) getEntityRefData service has a weird issue

2020-05-23 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114677#comment-17114677
 ] 

Pierre Smits commented on OFBIZ-11401:
--

While I did my cursory assessment, I found that quite a few are lacking the 
*default-resource-name*. Which may be valid in some cases. 

Nevertheless, IMO, we should have it in play as much as possible, even though 
the messages of missing label records appear in the log. It is a reminder of 
the task ahead to improve the appeal of OFBiz. And it might be an laborious 
task to have these entity labels come into play (even if we only focus on en as 
the language).

> getEntityRefData service has a weird issue
> --
>
> Key: OFBIZ-11401
> URL: https://issues.apache.org/jira/browse/OFBIZ-11401
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
>
> It's reproductible on trunk demo though only visible in log, UI shows no issue
> Here is the log on trunk demo
> {noformat}
> 2020-02-21 21:11:56,445 |ajp-nio-8009-exec-2  |WebToolsServices  
> |E| null
> java.util.MissingResourceException: Can't find resource for bundle 
> org.apache.ofbiz.base.util.UtilProperties$UtilResourceBundle, key 
> FieldDescription.WorkEffortType.createdTxStamp
>   at java.util.ResourceBundle.getObject(ResourceBundle.java:450) 
> ~[?:1.8.0_242]
>   at java.util.ResourceBundle.getObject(ResourceBundle.java:444) 
> ~[?:1.8.0_242]
>   at java.util.ResourceBundle.getString(ResourceBundle.java:407) 
> ~[?:1.8.0_242]
>   at 
> org.apache.ofbiz.webtools.WebToolsServices.getEntityRefData(WebToolsServices.java:685)
>  [main/:?]
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_242]
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_242]
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_242]
>   at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_242]
>   at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
>  [main/:?]
>   [...]
>   at 
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
>  [tomcat-util-9.0.29.jar:9.0.29]
>   at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242]
> 2020-02-21 21:11:56,445 |ajp-nio-8009-exec-2  |WebToolsServices  
> |E| null
> java.util.MissingResourceException: Can't find resource for bundle 
> org.apache.ofbiz.base.util.UtilProperties$UtilResourceBundle, key 
> FieldDescription.createdTxStamp
>   at java.util.ResourceBundle.getObject(ResourceBundle.java:450) 
> ~[?:1.8.0_242]
>   at java.util.ResourceBundle.getObject(ResourceBundle.java:444) 
> ~[?:1.8.0_242]
>   at java.util.ResourceBundle.getString(ResourceBundle.java:407) 
> ~[?:1.8.0_242]
>   at 
> org.apache.ofbiz.webtools.WebToolsServices.getEntityRefData(WebToolsServices.java:695)
>  [main/:?]
>   [...]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  [?:1.8.0_242]
>   at 
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
>  [tomcat-util-9.0.29.jar:9.0.29]
>   at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242]
> 2020-02-21 21:11:56,445 |ajp-nio-8009-exec-2  |ServiceDispatcher 
> |T| Sync service [webtools/getEntityRefData] finished in [5760] milliseconds
>   at 
> org.apache.ofbiz.webtools.WebToolsServices.getEntityRefData(WebToolsServices.java:685)
>  [main/:?]
> {noformat}
> So it repeats almost "ad ib" and eventually stops after 5+ seconds there.
> I guess R17 and R18 are also affected, R16 is OK.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] priyasharma1 opened a new pull request #158: [Improved] Convert createPaymentApplication service from mini-lang to groovy DSL (OFBIZ-11481)

2020-05-23 Thread GitBox


priyasharma1 opened a new pull request #158:
URL: https://github.com/apache/ofbiz-framework/pull/158


   
   (OFBIZ-11481)
   
   Done the following:
   - removed mini-lang version of the service
   - added groovy version
   - updated the service definition



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (OFBIZ-11491) Convert createPaymentAndApplicationForParty service from mini-lang to groovy DSL

2020-05-23 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-11491.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> Convert createPaymentAndApplicationForParty service from mini-lang to groovy 
> DSL
> 
>
> Key: OFBIZ-11491
> URL: https://issues.apache.org/jira/browse/OFBIZ-11491
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11491.patch, OFBIZ-11491.patch
>
>
> Convert the createPaymentAndApplicationForParty service code from mini-lang 
> to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11491) Convert createPaymentAndApplicationForParty service from mini-lang to groovy DSL

2020-05-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114673#comment-17114673
 ] 

ASF subversion and git services commented on OFBIZ-11491:
-

Commit 9e194b0e9ae0ada8ef2f0078f4dc6b71ecc922c6 in ofbiz-framework's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9e194b0 ]

Improved: Converted createPaymentAndApplicationForParty service from mini-lang 
to groovy
(OFBIZ-11491)
Thanks Devanshu Vyas for reporting and Sourabh Punyani for providing the patch.


> Convert createPaymentAndApplicationForParty service from mini-lang to groovy 
> DSL
> 
>
> Key: OFBIZ-11491
> URL: https://issues.apache.org/jira/browse/OFBIZ-11491
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-11491.patch, OFBIZ-11491.patch
>
>
> Convert the createPaymentAndApplicationForParty service code from mini-lang 
> to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10985) UI issue on View Order page

2020-05-23 Thread Aishwary Shrivastava (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114674#comment-17114674
 ] 

Aishwary Shrivastava commented on OFBIZ-10985:
--

Made username a link, instead of a button, and removed brackets from the "Send 
confirmation email" button, in the uploaded OFBIZ-10985.patch.

 

> UI issue on View Order page
> ---
>
> Key: OFBIZ-10985
> URL: https://issues.apache.org/jira/browse/OFBIZ-10985
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Rashi Dhagat
>Assignee: Aishwary Shrivastava
>Priority: Trivial
> Attachments: OFBIZ-10985.patch, ViewOrderPage.jpg
>
>
> Steps to regenerate:
>  # Open URL [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main]
>  # Click on any order in Approved status
> Actual:
>  # In Contact Information section, admin (username) is a button
>  # "Send confirmation email" button in brackets
> Expected: 
>  # Username should not be a button
>  # The button should not be in brackets.
> Please refer attachment for same.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-6675) EntityUtilProperties should have getProperties function

2020-05-23 Thread Pradeep Choudhary (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114670#comment-17114670
 ] 

Pradeep Choudhary commented on OFBIZ-6675:
--

Thanks [~surajk] and [~pierresmits]

> EntityUtilProperties should have getProperties function
> ---
>
> Key: OFBIZ-6675
> URL: https://issues.apache.org/jira/browse/OFBIZ-6675
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>
> UtilProperties has functions to get all properties, given a particular 
> resource, called getProperties.
> EntityUtilProperties should have the same kind to retrieve the same from 
> SystemProperty records, with fall-back to UtilProperties.getProperties.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10985) UI issue on View Order page

2020-05-23 Thread Aishwary Shrivastava (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aishwary Shrivastava updated OFBIZ-10985:
-
Attachment: OFBIZ-10985.patch

> UI issue on View Order page
> ---
>
> Key: OFBIZ-10985
> URL: https://issues.apache.org/jira/browse/OFBIZ-10985
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Rashi Dhagat
>Assignee: Aishwary Shrivastava
>Priority: Trivial
> Attachments: OFBIZ-10985.patch, ViewOrderPage.jpg
>
>
> Steps to regenerate:
>  # Open URL [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main]
>  # Click on any order in Approved status
> Actual:
>  # In Contact Information section, admin (username) is a button
>  # "Send confirmation email" button in brackets
> Expected: 
>  # Username should not be a button
>  # The button should not be in brackets.
> Please refer attachment for same.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-10985) UI issue on View Order page

2020-05-23 Thread Aishwary Shrivastava (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aishwary Shrivastava reassigned OFBIZ-10985:


Assignee: Aishwary Shrivastava  (was: Garima jain)

> UI issue on View Order page
> ---
>
> Key: OFBIZ-10985
> URL: https://issues.apache.org/jira/browse/OFBIZ-10985
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Rashi Dhagat
>Assignee: Aishwary Shrivastava
>Priority: Trivial
> Attachments: ViewOrderPage.jpg
>
>
> Steps to regenerate:
>  # Open URL [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main]
>  # Click on any order in Approved status
> Actual:
>  # In Contact Information section, admin (username) is a button
>  # "Send confirmation email" button in brackets
> Expected: 
>  # Username should not be a button
>  # The button should not be in brackets.
> Please refer attachment for same.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11728) Create new component, data configuration and connection request

2020-05-23 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114666#comment-17114666
 ] 

Pierre Smits commented on OFBIZ-11728:
--

I guess back then contributors weren't that aware of using the SystemProperty 
entity to store configurations for components inner workings. Since then a lot 
of improvements related to the entity have been implemented. 

We should not follow the path, we had back then, for 3rd Party Solution 
Integrations anymore.  A hint how we can work with such 3rd Party Integrations, 
can be found in 2 integration components I did regarding 3rd Fintech solutions 
Adyen and MultiSafepay. See links.

> Create new component, data configuration and connection request
> ---
>
> Key: OFBIZ-11728
> URL: https://issues.apache.org/jira/browse/OFBIZ-11728
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Shikha Jaiswal
>Assignee: Shikha Jaiswal
>Priority: Major
>
> We will be doing following tasks in this ticket:
> # Create a new component named *shopify*
> # Basic configuration data setup
> # Implement a method for HTTP connection request with Shopify
> To store configuration details we will create entity *ShopifyConfig*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11356) FindOrders.ftl: paginateOrderList does not find orders on next page

2020-05-23 Thread Aditya Sharma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma reassigned OFBIZ-11356:
-

Assignee: Aditya Sharma

> FindOrders.ftl: paginateOrderList does not find orders on next page
> ---
>
> Key: OFBIZ-11356
> URL: https://issues.apache.org/jira/browse/OFBIZ-11356
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Michael Brohl
>Assignee: Aditya Sharma
>Priority: Critical
> Attachments: OFBIZ-11356.patch
>
>
> Steps to reproduce
>  # go to [https://localhost:8443/ordermgr/control/findorders]
>  # click "Search" -> 4 entries are displayed
>  # got to [https://localhost:8443/ordermgr/control/searchorders?viewSize=1] 
> to manipulate the viewSize
>  # click "Search" again -> 1 entry is displayed
>  # click "Next" (javascript:paginateOrderList('1','1','Y') is triggered 
> correctly)
>  # the result shows no entries



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-6675) EntityUtilProperties should have getProperties function

2020-05-23 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-6675.
---
Resolution: Implemented

Closing, as implemented under ticket OFBIZ-7112 in 2018.

Thanks [~pradeep.choudhary1994] for collaborating to get this issue resolved 
(and taking the time to investigate).

> EntityUtilProperties should have getProperties function
> ---
>
> Key: OFBIZ-6675
> URL: https://issues.apache.org/jira/browse/OFBIZ-6675
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>
> UtilProperties has functions to get all properties, given a particular 
> resource, called getProperties.
> EntityUtilProperties should have the same kind to retrieve the same from 
> SystemProperty records, with fall-back to UtilProperties.getProperties.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11401) getEntityRefData service has a weird issue

2020-05-23 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114660#comment-17114660
 ] 

Jacques Le Roux commented on OFBIZ-11401:
-

You are mostly right Pierre,

I did a cursory survey and found also other entities in Content, like Content, 
ContentOperation, CharacterSet, DataCategory, etc.

There are others like TechDataCalendarWeek,  ProductGeo, ProductStore, 
WorkEffortAssocTypeAttr, Enumeration, Geo, GeoPoint, StatusValidChange, 
CustomScreen, SecurityGroup. But it's mostly types, yes.

> getEntityRefData service has a weird issue
> --
>
> Key: OFBIZ-11401
> URL: https://issues.apache.org/jira/browse/OFBIZ-11401
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
>
> It's reproductible on trunk demo though only visible in log, UI shows no issue
> Here is the log on trunk demo
> {noformat}
> 2020-02-21 21:11:56,445 |ajp-nio-8009-exec-2  |WebToolsServices  
> |E| null
> java.util.MissingResourceException: Can't find resource for bundle 
> org.apache.ofbiz.base.util.UtilProperties$UtilResourceBundle, key 
> FieldDescription.WorkEffortType.createdTxStamp
>   at java.util.ResourceBundle.getObject(ResourceBundle.java:450) 
> ~[?:1.8.0_242]
>   at java.util.ResourceBundle.getObject(ResourceBundle.java:444) 
> ~[?:1.8.0_242]
>   at java.util.ResourceBundle.getString(ResourceBundle.java:407) 
> ~[?:1.8.0_242]
>   at 
> org.apache.ofbiz.webtools.WebToolsServices.getEntityRefData(WebToolsServices.java:685)
>  [main/:?]
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_242]
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_242]
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_242]
>   at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_242]
>   at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
>  [main/:?]
>   [...]
>   at 
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
>  [tomcat-util-9.0.29.jar:9.0.29]
>   at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242]
> 2020-02-21 21:11:56,445 |ajp-nio-8009-exec-2  |WebToolsServices  
> |E| null
> java.util.MissingResourceException: Can't find resource for bundle 
> org.apache.ofbiz.base.util.UtilProperties$UtilResourceBundle, key 
> FieldDescription.createdTxStamp
>   at java.util.ResourceBundle.getObject(ResourceBundle.java:450) 
> ~[?:1.8.0_242]
>   at java.util.ResourceBundle.getObject(ResourceBundle.java:444) 
> ~[?:1.8.0_242]
>   at java.util.ResourceBundle.getString(ResourceBundle.java:407) 
> ~[?:1.8.0_242]
>   at 
> org.apache.ofbiz.webtools.WebToolsServices.getEntityRefData(WebToolsServices.java:695)
>  [main/:?]
>   [...]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  [?:1.8.0_242]
>   at 
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
>  [tomcat-util-9.0.29.jar:9.0.29]
>   at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242]
> 2020-02-21 21:11:56,445 |ajp-nio-8009-exec-2  |ServiceDispatcher 
> |T| Sync service [webtools/getEntityRefData] finished in [5760] milliseconds
>   at 
> org.apache.ofbiz.webtools.WebToolsServices.getEntityRefData(WebToolsServices.java:685)
>  [main/:?]
> {noformat}
> So it repeats almost "ad ib" and eventually stops after 5+ seconds there.
> I guess R17 and R18 are also affected, R16 is OK.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11491) Convert createPaymentAndApplicationForParty service from mini-lang to groovy DSL

2020-05-23 Thread Sourabh Punyani (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114659#comment-17114659
 ] 

Sourabh Punyani commented on OFBIZ-11491:
-

Hello [~surajk],

The patch you have provided looks fine to me. Thanks for updating it.

> Convert createPaymentAndApplicationForParty service from mini-lang to groovy 
> DSL
> 
>
> Key: OFBIZ-11491
> URL: https://issues.apache.org/jira/browse/OFBIZ-11491
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-11491.patch, OFBIZ-11491.patch
>
>
> Convert the createPaymentAndApplicationForParty service code from mini-lang 
> to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-6675) EntityUtilProperties should have getProperties function

2020-05-23 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-6675:
---

Assignee: Pierre Smits

> EntityUtilProperties should have getProperties function
> ---
>
> Key: OFBIZ-6675
> URL: https://issues.apache.org/jira/browse/OFBIZ-6675
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>
> UtilProperties has functions to get all properties, given a particular 
> resource, called getProperties.
> EntityUtilProperties should have the same kind to retrieve the same from 
> SystemProperty records, with fall-back to UtilProperties.getProperties.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


  1   2   >