[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #31: small style related fixes.

sonarcloud[bot] removed a comment on pull request #31: URL: https://github.com/apache/ofbiz-plugins/pull/31#issuecomment-646145695 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=31=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #31: small style related fixes.

sonarcloud[bot] commented on pull request #31: URL: https://github.com/apache/ofbiz-plugins/pull/31#issuecomment-646449546 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=31=false=BUG)

[GitHub] [ofbiz-plugins] alexbodn closed pull request #31: small style related fixes.

alexbodn closed pull request #31: URL: https://github.com/apache/ofbiz-plugins/pull/31 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #30: a plugin to log csp errors reported by the browsers.

sonarcloud[bot] removed a comment on pull request #30: URL: https://github.com/apache/ofbiz-plugins/pull/30#issuecomment-645892617 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=30=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #30: a plugin to log csp errors reported by the browsers.

sonarcloud[bot] commented on pull request #30: URL: https://github.com/apache/ofbiz-plugins/pull/30#issuecomment-646442295 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=30=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #31: small style related fixes.

sonarcloud[bot] commented on pull request #31: URL: https://github.com/apache/ofbiz-plugins/pull/31#issuecomment-646145695 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=31=false=BUG)

[GitHub] [ofbiz-plugins] alexbodn opened a new pull request #31: small style related fixes.

alexbodn opened a new pull request #31: URL: https://github.com/apache/ofbiz-plugins/pull/31 renaming the map files for minified js and css files. Improved: Implemented: Documented: Completed: Reverted: Fixed: (OFBIZ-) Explanation Thanks:

[jira] [Closed] (OFBIZ-11401) getEntityRefData service has a weird issue

[ https://issues.apache.org/jira/browse/OFBIZ-11401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11401. --- Fix Version/s: 17.12.04 18.12.01 Resolution: Fixed >

[jira] [Commented] (OFBIZ-11803) showHelp not working

[ https://issues.apache.org/jira/browse/OFBIZ-11803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139514#comment-17139514 ] James Yong commented on OFBIZ-11803: Applied a fix to the trunk. Hope it is ok. > showHelp not

[jira] [Updated] (OFBIZ-11836) IDOR vulnerability in the order processing feature

[ https://issues.apache.org/jira/browse/OFBIZ-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11836: Description: Harshit Shukla [mailto:harshit.sh...@gmail.com]reported this IDOR

[GitHub] [ofbiz-plugins] JacquesLeRoux commented on pull request #30: a plugin to log csp errors reported by the browsers.

JacquesLeRoux commented on pull request #30: URL: https://github.com/apache/ofbiz-plugins/pull/30#issuecomment-646084242 Hi Alex, This looks promising even if I don't like the idea of put in "unsafe-inline". BTW please follow our [commit comment

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #205: set xmlns to many WEB-INF/web.xml files.

JacquesLeRoux commented on pull request #205: URL: https://github.com/apache/ofbiz-framework/pull/205#issuecomment-646082633 Hi Alex, We had this already several times: https://issues.apache.org/jira/browse/OFBIZ-6807 https://issues.apache.org/jira/browse/OFBIZ-11235

[jira] [Updated] (OFBIZ-11825) Use a .asf.yaml file for more information in OFBiz GitHub repos

[ https://issues.apache.org/jira/browse/OFBIZ-11825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11825: Description: This follows INFRA-20424 where Gavin explained me: {quote}Descriptions and

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #205: set xmlns to many WEB-INF/web.xml files.

sonarcloud[bot] commented on pull request #205: URL: https://github.com/apache/ofbiz-framework/pull/205#issuecomment-646063051 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=205=false=BUG)

[GitHub] [ofbiz-framework] alexbodn opened a new pull request #205: set xmlns to many WEB-INF/web.xml files.

alexbodn opened a new pull request #205: URL: https://github.com/apache/ofbiz-framework/pull/205 lack of it gave parsing errors using openjdk-8. i don't have other vendor's java. Improved: Implemented: Documented: Completed: Reverted: Fixed: (OFBIZ-)

[jira] [Commented] (OFBIZ-11803) showHelp not working

[ https://issues.apache.org/jira/browse/OFBIZ-11803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139427#comment-17139427 ] Olivier Heintz commented on OFBIZ-11803: # on

[jira] [Commented] (OFBIZ-11827) Merge identical catch blocks in single catch block

[ https://issues.apache.org/jira/browse/OFBIZ-11827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139423#comment-17139423 ] Jacques Le Roux commented on OFBIZ-11827: - I'm reviewing this one step by step... > Merge

[jira] [Created] (OFBIZ-11836) IDOR vulnerability in the order processing feature

Jacques Le Roux created OFBIZ-11836: --- Summary: IDOR vulnerability in the order processing feature Key: OFBIZ-11836 URL: https://issues.apache.org/jira/browse/OFBIZ-11836 Project: OFBiz

[jira] [Commented] (OFBIZ-11829) Replace for-loop with forEach loop

[ https://issues.apache.org/jira/browse/OFBIZ-11829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139406#comment-17139406 ] Jacques Le Roux commented on OFBIZ-11829: - Cursory review OK, compilation OK, -101 (26735 to

[jira] [Commented] (OFBIZ-11803) showHelp not working

[ https://issues.apache.org/jira/browse/OFBIZ-11803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139404#comment-17139404 ] James Yong commented on OFBIZ-11803: Can you provide the steps on how you got the error? > showHelp

[jira] [Comment Edited] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)

[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139169#comment-17139169 ] Jacques Le Roux edited comment on OFBIZ-11304 at 6/18/20, 12:24 PM:

[jira] [Assigned] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)

[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11304: --- Assignee: Aditya Sharma (was: Jacques Le Roux) > Install a Checkstyle pre-push

[jira] [Commented] (OFBIZ-11835) Replace single method call lambda with method reference

[ https://issues.apache.org/jira/browse/OFBIZ-11835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139388#comment-17139388 ] Jacques Le Roux commented on OFBIZ-11835: - +1 I personally prefer method references syntax than

[jira] [Commented] (OFBIZ-11835) Replace single method call lambda with method reference

[ https://issues.apache.org/jira/browse/OFBIZ-11835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139358#comment-17139358 ] Pawan Verma commented on OFBIZ-11835: - Attached patch for this improvement. > Replace single method

[jira] [Updated] (OFBIZ-11835) Replace single method call lambda with method reference

[ https://issues.apache.org/jira/browse/OFBIZ-11835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11835: Attachment: OFBIZ-11835.patch > Replace single method call lambda with method reference >

[jira] [Created] (OFBIZ-11835) Replace single method call lambda with method reference

Pawan Verma created OFBIZ-11835: --- Summary: Replace single method call lambda with method reference Key: OFBIZ-11835 URL: https://issues.apache.org/jira/browse/OFBIZ-11835 Project: OFBiz Issue

[jira] [Commented] (OFBIZ-11829) Replace for-loop with forEach loop

[ https://issues.apache.org/jira/browse/OFBIZ-11829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139345#comment-17139345 ] Pawan Verma commented on OFBIZ-11829: - Attached patches for this improvement.  > Replace for-loop

[jira] [Updated] (OFBIZ-11829) Replace for-loop with forEach loop

[ https://issues.apache.org/jira/browse/OFBIZ-11829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11829: Attachment: OFBIZ-11829-plugins.patch OFBIZ-11829.patch > Replace for-loop with

[jira] [Commented] (OFBIZ-11833) Replace anonymous types with lambda expressions

[ https://issues.apache.org/jira/browse/OFBIZ-11833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139335#comment-17139335 ] Pawan Verma commented on OFBIZ-11833: - Attached patches for this improvement.  > Replace anonymous

[jira] [Updated] (OFBIZ-11833) Replace anonymous types with lambda expressions

[ https://issues.apache.org/jira/browse/OFBIZ-11833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11833: Attachment: OFBIZ-11833-plugins.patch OFBIZ-11833.patch > Replace anonymous types

[jira] [Updated] (OFBIZ-11830) Replace Collection.sort() with List.sort()

[ https://issues.apache.org/jira/browse/OFBIZ-11830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11830: Attachment: OFBIZ-11830-plugins.patch OFBIZ-11830.patch > Replace

[jira] [Commented] (OFBIZ-11830) Replace Collection.sort() with List.sort()

[ https://issues.apache.org/jira/browse/OFBIZ-11830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139329#comment-17139329 ] Pawan Verma commented on OFBIZ-11830: - Attached patches for this improvement.  > Replace

[jira] [Updated] (OFBIZ-11828) Replace explicit type argument with diamond operator

[ https://issues.apache.org/jira/browse/OFBIZ-11828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11828: Attachment: OFBIZ-11828-plugins.patch OFBIZ-11828.patch > Replace explicit type

[jira] [Commented] (OFBIZ-11828) Replace explicit type argument with diamond operator

[ https://issues.apache.org/jira/browse/OFBIZ-11828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139281#comment-17139281 ] Pawan Verma commented on OFBIZ-11828: - Attached patches for this improvement.  > Replace explicit

[jira] [Closed] (OFBIZ-11834) Change resource with RESOURCE in framework

[ https://issues.apache.org/jira/browse/OFBIZ-11834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11834. --- Fix Version/s: (was: Trunk) Upcoming Branch Resolution: Implemented

[jira] [Commented] (OFBIZ-11834) Change resource with RESOURCE in framework

[ https://issues.apache.org/jira/browse/OFBIZ-11834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139252#comment-17139252 ] Suraj Khurana commented on OFBIZ-11834: --- Yes, good to go. > Change resource with RESOURCE in

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #30: a plugin to log csp errors reported by the browsers.

sonarcloud[bot] commented on pull request #30: URL: https://github.com/apache/ofbiz-plugins/pull/30#issuecomment-645892617 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=30=false=BUG)

[GitHub] [ofbiz-plugins] alexbodn opened a new pull request #30: a plugin to log csp errors reported by the browsers.

alexbodn opened a new pull request #30: URL: https://github.com/apache/ofbiz-plugins/pull/30 it complements the report-only csp header, and a patch will be submited to the framework to point to this url. this code should rather be implemented in the framework, since the csp header

[GitHub] [ofbiz-framework] alexbodn opened a new pull request #204: added a report uri and unsafe-inline to the csp header.

alexbodn opened a new pull request #204: URL: https://github.com/apache/ofbiz-framework/pull/204 i understand the policy is against unsafe-inline, but as a matter of fact there are as lot of inline js/css, and part of the js is adding additional remote js. the report uri is

[jira] [Comment Edited] (OFBIZ-11803) showHelp not working

[ https://issues.apache.org/jira/browse/OFBIZ-11803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139209#comment-17139209 ] Olivier Heintz edited comment on OFBIZ-11803 at 6/18/20, 8:23 AM: -- Hi,

[jira] [Reopened] (OFBIZ-11803) showHelp not working

[ https://issues.apache.org/jira/browse/OFBIZ-11803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz reopened OFBIZ-11803: Hi, Index Tree is not working/show. There is an js error {quote}TypeError:

[jira] [Commented] (OFBIZ-11834) Change resource with RESOURCE in framework

[ https://issues.apache.org/jira/browse/OFBIZ-11834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139182#comment-17139182 ] Jacques Le Roux commented on OFBIZ-11834: - Thanks Suraj, I guess we are ready to commit now,

[jira] [Commented] (OFBIZ-11752) CLONE - Check embedded Javascript libs vulnerabilities using retire.js

[ https://issues.apache.org/jira/browse/OFBIZ-11752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139172#comment-17139172 ] Aditya Sharma commented on OFBIZ-11752: --- Thanks Olivier! > CLONE - Check embedded Javascript libs

[jira] [Assigned] (OFBIZ-11401) getEntityRefData service has a weird issue

[ https://issues.apache.org/jira/browse/OFBIZ-11401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11401: --- Assignee: Jacques Le Roux > getEntityRefData service has a weird issue >

[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)

[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139169#comment-17139169 ] Aditya Sharma commented on OFBIZ-11304: --- Awesome. Thank you Jacques! >> I have still to see how

[jira] [Updated] (OFBIZ-11834) Change resource with RESOURCE in framework

[ https://issues.apache.org/jira/browse/OFBIZ-11834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11834: Attachment: OFBIZ-11834.patch > Change resource with RESOURCE in framework >

[jira] [Commented] (OFBIZ-11834) Change resource with RESOURCE in framework

[ https://issues.apache.org/jira/browse/OFBIZ-11834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139134#comment-17139134 ] Pawan Verma commented on OFBIZ-11834: - Removed in [^OFBIZ-11834.patch] > Change resource with

[jira] [Commented] (OFBIZ-11834) Change resource with RESOURCE in framework

[ https://issues.apache.org/jira/browse/OFBIZ-11834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139128#comment-17139128 ] Suraj Khurana commented on OFBIZ-11834: --- Thanks Pawan, On a cursory review, apart from below

[jira] [Updated] (OFBIZ-11834) Change resource with RESOURCE in framework

[ https://issues.apache.org/jira/browse/OFBIZ-11834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11834: Attachment: OFBIZ-11834.patch > Change resource with RESOURCE in framework >

[jira] [Commented] (OFBIZ-11834) Change resource with RESOURCE in framework

[ https://issues.apache.org/jira/browse/OFBIZ-11834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139123#comment-17139123 ] Pawan Verma commented on OFBIZ-11834: - Attaching a new patch, I haven't found anything in