[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748410#comment-17748410 ] Deepak Dixit commented on OFBIZ-12813: -- Hi [~jleroux], [~wpaetzold] ofbiz-plugins still have the old groovyScripts folder structure, we need to update them as well. > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Wiebke Paetzold >Priority: Major > Fix For: Upcoming Branch > > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] mbrohl closed pull request #642: Improved: Persist OrderItemAttribute of ShoppingCartItem (OFBIZ-12828)
mbrohl closed pull request #642: Improved: Persist OrderItemAttribute of ShoppingCartItem (OFBIZ-12828) URL: https://github.com/apache/ofbiz-framework/pull/642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12836) Resource leaks in EntitySQLProcessor.groovy
[ https://issues.apache.org/jira/browse/OFBIZ-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748298#comment-17748298 ] Jacques Le Roux commented on OFBIZ-12836: - Beware that as noted Wiebke in OFBIZ-12813 bq. Regarding ticket OFBIZ-12836: Since the ticket is about a patch, the references in the patch can be changed here after the groovy restructuring and the patch can be applied without errors. The groovy class is then located at: framework/webtools/src/main/groovy/org/apache/ofbiz/entity/EntitySQLProcessor.groovy > Resource leaks in EntitySQLProcessor.groovy > --- > > Key: OFBIZ-12836 > URL: https://issues.apache.org/jira/browse/OFBIZ-12836 > Project: OFBiz > Issue Type: Bug > Components: webtools >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Minor > Attachments: EntitySQLProcessor-1.groovy, > EntitySQLProcessor-2.groovy, EntitySQLProcessor.groovy, > Fixed__Resource_leaks_in_EntitySQLProcessor_groovy-1.patch, > Fixed__Resource_leaks_in_EntitySQLProcessor_groovy-2.patch, > Fixed__Resource_leaks_in_EntitySQLProcessor_groovy-3.patch, > Fixed__Resource_leaks_in_EntitySQLProcessor_groovy.patch > > > In framework/webtools/groovyScripts/entity/EntitySQLProcessor.groovy at line > 35 > [https://github.com/apache/ofbiz-framework/blob/e080f0bfa657b8b6ffd4cbf5629e0c648440b5f0/framework/webtools/groovyScripts/entity/EntitySQLProcessor.groovy#L35] > > it creates an SQLProcessor. SQLProcessor has a Close method and implements > AutoCloseable, but we're not using try-with-resources, nor directly calling > the Close method. > > Similarly, > > [https://github.com/apache/ofbiz-framework/blob/e080f0bfa657b8b6ffd4cbf5629e0c648440b5f0/framework/webtools/groovyScripts/entity/EntitySQLProcessor.groovy#L38] > > obtains a java.sql.Resultset, which will be closed when everything works, but > would leak if there was an exception. Again, we should be using > try-with-resources. > > Note that according to > > [https://docs.oracle.com/en/java/javase/20/docs/api/java.sql/java/sql/ResultSet.html#close()] > > "Calling the method close on a ResultSet object that is already closed is a > no-op.", if you obtain a ResultSet from the SQLProcessor and directly close > that ResultSet, it's not a problem when the SQLProcessor.close also attempts > to close the ResultSet. > > The problem is minor, most of the time. The groovy script is in the webtools, > so used for developer tinkering and not production use. > > When you're doing a SELECT, the script is closing the ResultSet, so the > important resources are cleaned up (assuming no exception occurred). > > However, if you are doing INSERT, UPDATE or DELETE, the script creates a > prepared statement that is not closed, so there's a resource leak. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12828) Persist OrderItemAttributes of ShoppingCartItem in new entity ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList)
[ https://issues.apache.org/jira/browse/OFBIZ-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748297#comment-17748297 ] Jacques Le Roux commented on OFBIZ-12828: - OK, as soon as a groovy file is modifed, and especially moved, in trunk it will be more hand work to backport to backport. So I think we should indeed quickly think about creating a 23.xx (23.08?) release. Else if will be soon a nightmare to backport fixes. > Persist OrderItemAttributes of ShoppingCartItem in new entity > ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList) > - > > Key: OFBIZ-12828 > URL: https://issues.apache.org/jira/browse/OFBIZ-12828 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Pascal Zoschke >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > > Currently, the information about the attributes of the order item is not > saved and therefore cannot be retrieved later in the shopping cart > (autoSaveList). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12828) Persist OrderItemAttributes of ShoppingCartItem in new entity ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList)
[ https://issues.apache.org/jira/browse/OFBIZ-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748295#comment-17748295 ] Jacques Le Roux commented on OFBIZ-12828: - It should even be backported to 18.12. We are not yet sure that we will not release 18.12.09 as we did 18.12.08. We are not even sure we will not finally use 22.01. I'll have a look to see if it's easy to backport or not. > Persist OrderItemAttributes of ShoppingCartItem in new entity > ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList) > - > > Key: OFBIZ-12828 > URL: https://issues.apache.org/jira/browse/OFBIZ-12828 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Pascal Zoschke >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > > Currently, the information about the attributes of the order item is not > saved and therefore cannot be retrieved later in the shopping cart > (autoSaveList). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12828) Persist OrderItemAttributes of ShoppingCartItem in new entity ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList)
[ https://issues.apache.org/jira/browse/OFBIZ-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748252#comment-17748252 ] Michael Brohl commented on OFBIZ-12828: --- You are right, this should normally be backported to 22.01. On the other hand, we were discussing to drop 22.01 in favor of a 23.x release and 18.x should be discontinued also. Not sure if it's worth the work? > Persist OrderItemAttributes of ShoppingCartItem in new entity > ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList) > - > > Key: OFBIZ-12828 > URL: https://issues.apache.org/jira/browse/OFBIZ-12828 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Pascal Zoschke >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > > Currently, the information about the attributes of the order item is not > saved and therefore cannot be retrieved later in the shopping cart > (autoSaveList). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12828) Persist OrderItemAttributes of ShoppingCartItem in new entity ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList)
[ https://issues.apache.org/jira/browse/OFBIZ-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748246#comment-17748246 ] Jacques Le Roux commented on OFBIZ-12828: - Hi Michael, If it's a bug why not backporting? > Persist OrderItemAttributes of ShoppingCartItem in new entity > ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList) > - > > Key: OFBIZ-12828 > URL: https://issues.apache.org/jira/browse/OFBIZ-12828 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Pascal Zoschke >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > > Currently, the information about the attributes of the order item is not > saved and therefore cannot be retrieved later in the shopping cart > (autoSaveList). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748238#comment-17748238 ] ASF subversion and git services commented on OFBIZ-12813: - Commit 7480f09f988fb57382ef268cafa236bc2f0d46fa in ofbiz-plugins's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=7480f09f9 ] Fixed: Refactor groovy folder structure and add package declaration (OFBIZ-12813) The ecommerce-notification-tests failed (actually JUNIT testSendOrderConfirmation) This fixes it. > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Wiebke Paetzold >Priority: Major > Fix For: Upcoming Branch > > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12174) Convert InventoryServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-12174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-12174. - Fix Version/s: Upcoming Branch Resolution: Implemented Thanks [~sberg] and [~cshan] ! > Convert InventoryServices.xml mini lang to groovy > - > > Key: OFBIZ-12174 > URL: https://issues.apache.org/jira/browse/OFBIZ-12174 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk, Upcoming Branch >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Minor > Fix For: Upcoming Branch > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12174) Convert InventoryServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-12174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748229#comment-17748229 ] ASF subversion and git services commented on OFBIZ-12174: - Commit 634842436167a4c399d2d98162ad211f3a4fcc45 in ofbiz-framework's branch refs/heads/trunk from Cheng Hu Shan [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6348424361 ] Fixed: Convert InventoryServices.xml mini lang to groovy (OFBIZ-12174) > Convert InventoryServices.xml mini lang to groovy > - > > Key: OFBIZ-12174 > URL: https://issues.apache.org/jira/browse/OFBIZ-12174 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk, Upcoming Branch >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] mbrohl merged pull request #664: Fixed: Convert InventoryServices.xml mini lang to groovy (OFBIZ-12174)
mbrohl merged PR #664: URL: https://github.com/apache/ofbiz-framework/pull/664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (OFBIZ-9403) DataResourceWorker: New method getMimeTypeFromFileName(...) with extracted (refactored) code from getMimeType(...) method
[ https://issues.apache.org/jira/browse/OFBIZ-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-9403. Fix Version/s: Upcoming Branch Resolution: Implemented Thanks [~mbecker] and [~cshan] ! > DataResourceWorker: New method getMimeTypeFromFileName(...) with extracted > (refactored) code from getMimeType(...) method > - > > Key: OFBIZ-9403 > URL: https://issues.apache.org/jira/browse/OFBIZ-9403 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Trunk, Upcoming Branch >Reporter: Martin Becker >Assignee: Chenghu Shan >Priority: Trivial > Fix For: Upcoming Branch > > Attachments: OFBIZ-9403_DataResourceWorker_GetMimeType.patch, > OFBIZ-9403_DataResourceWorker_GetMimeType_with_defaultMimeTypeId.patch > > > The method DataResourceWorker.getMimeType(GenericValue) has been refactored > into two separate methods. The new additional method > getMimeTypeFromFileName(Delegator,Filename) solely focuses on getting the > MimeType from the file extension and is invoked by getMimeType(GenericValue) > if needed. getMimeType returns the type if possible via the data resource. > This results in cleaner code with the responsibility of both methods clearly > defined by the methods names. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-9403) DataResourceWorker: New method getMimeTypeFromFileName(...) with extracted (refactored) code from getMimeType(...) method
[ https://issues.apache.org/jira/browse/OFBIZ-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748226#comment-17748226 ] ASF subversion and git services commented on OFBIZ-9403: Commit e87b1994836ca88c3ba04fadef33f7bb8e828511 in ofbiz-framework's branch refs/heads/trunk from Cheng Hu Shan [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e87b199483 ] Improved: Refactored DataResourceWorker getMimeType (OFBIZ-9403) > DataResourceWorker: New method getMimeTypeFromFileName(...) with extracted > (refactored) code from getMimeType(...) method > - > > Key: OFBIZ-9403 > URL: https://issues.apache.org/jira/browse/OFBIZ-9403 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Trunk, Upcoming Branch >Reporter: Martin Becker >Assignee: Chenghu Shan >Priority: Trivial > Attachments: OFBIZ-9403_DataResourceWorker_GetMimeType.patch, > OFBIZ-9403_DataResourceWorker_GetMimeType_with_defaultMimeTypeId.patch > > > The method DataResourceWorker.getMimeType(GenericValue) has been refactored > into two separate methods. The new additional method > getMimeTypeFromFileName(Delegator,Filename) solely focuses on getting the > MimeType from the file extension and is invoked by getMimeType(GenericValue) > if needed. getMimeType returns the type if possible via the data resource. > This results in cleaner code with the responsibility of both methods clearly > defined by the methods names. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] mbrohl merged pull request #663: Improved: Refactored DataResourceWorker getMimeType (OFBIZ-9403)
mbrohl merged PR #663: URL: https://github.com/apache/ofbiz-framework/pull/663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (OFBIZ-12802) Extending calculateProductPrice (custom) Service and ShoppingCart / OrderItem to deliver/hold an individual discountRate value
[ https://issues.apache.org/jira/browse/OFBIZ-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-12802: - Assignee: Michael Brohl > Extending calculateProductPrice (custom) Service and ShoppingCart / OrderItem > to deliver/hold an individual discountRate value > -- > > Key: OFBIZ-12802 > URL: https://issues.apache.org/jira/browse/OFBIZ-12802 > Project: OFBiz > Issue Type: New Feature >Reporter: Adrian Wolf >Assignee: Michael Brohl >Priority: Minor > > Background is the communication of an individually (informally) calculated > discount rate from the price calculation to the OrderItem, with easy access > to it (because of this not via the orderItemPriceInfos substructure). > > Extending ProductPrice.calculateProductPrice Service (all in > PriceServices.java and services_pricepromo.xml): > * Addition of additional context information "productStoreGroupId" and > "partyId" to the call parameters of a "customMethodName" price-calc-service > * Obtaining the fields discountRate and listPrice from calling a > "customMethodName" price-calc-service > * discountRate as Result Field > * Retaining the bypassing of the OFBiz Standard PriceRules based on the > presence of a ListPrice (only that it can now also come from the > "customMethodName", therefore slightly changed decision logic) > Extending ShoppingCart/Item, OrderItem Entity: > * Transport original discount rate from custom price calculation over cart > to order to have the correct rate instead of back-calculating it from > unitPrice and unitListPrice -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] mbrohl commented on pull request #655: Implemented: Extending calculateProductPrice (custom) Service and ShoppingCart / OrderItem to deliver/hold an individual discountRate
mbrohl commented on PR #655: URL: https://github.com/apache/ofbiz-framework/pull/655#issuecomment-1653894859 Looks good to me. Any objections to merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12802) Extending calculateProductPrice (custom) Service and ShoppingCart / OrderItem to deliver/hold an individual discountRate value
[ https://issues.apache.org/jira/browse/OFBIZ-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748225#comment-17748225 ] Michael Brohl commented on OFBIZ-12802: --- Looks good to me. Any objections to merge? > Extending calculateProductPrice (custom) Service and ShoppingCart / OrderItem > to deliver/hold an individual discountRate value > -- > > Key: OFBIZ-12802 > URL: https://issues.apache.org/jira/browse/OFBIZ-12802 > Project: OFBiz > Issue Type: New Feature >Reporter: Adrian Wolf >Assignee: Michael Brohl >Priority: Minor > > Background is the communication of an individually (informally) calculated > discount rate from the price calculation to the OrderItem, with easy access > to it (because of this not via the orderItemPriceInfos substructure). > > Extending ProductPrice.calculateProductPrice Service (all in > PriceServices.java and services_pricepromo.xml): > * Addition of additional context information "productStoreGroupId" and > "partyId" to the call parameters of a "customMethodName" price-calc-service > * Obtaining the fields discountRate and listPrice from calling a > "customMethodName" price-calc-service > * discountRate as Result Field > * Retaining the bypassing of the OFBiz Standard PriceRules based on the > presence of a ListPrice (only that it can now also come from the > "customMethodName", therefore slightly changed decision logic) > Extending ShoppingCart/Item, OrderItem Entity: > * Transport original discount rate from custom price calculation over cart > to order to have the correct rate instead of back-calculating it from > unitPrice and unitListPrice -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] mbrohl commented on pull request #660: Fixed: Convert InventoryServices.xml mini lang to groovy (OFBIZ-12174)
mbrohl commented on PR #660: URL: https://github.com/apache/ofbiz-framework/pull/660#issuecomment-1653892055 Closed in favor of #664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] mbrohl closed pull request #660: Fixed: Convert InventoryServices.xml mini lang to groovy (OFBIZ-12174)
mbrohl closed pull request #660: Fixed: Convert InventoryServices.xml mini lang to groovy (OFBIZ-12174) URL: https://github.com/apache/ofbiz-framework/pull/660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (OFBIZ-12828) Persist OrderItemAttributes of ShoppingCartItem in new entity ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList)
[ https://issues.apache.org/jira/browse/OFBIZ-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-12828. - Fix Version/s: Upcoming Branch Resolution: Fixed Thanks [~pzoschke] and [~sberg] for your work! > Persist OrderItemAttributes of ShoppingCartItem in new entity > ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList) > - > > Key: OFBIZ-12828 > URL: https://issues.apache.org/jira/browse/OFBIZ-12828 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Pascal Zoschke >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > > Currently, the information about the attributes of the order item is not > saved and therefore cannot be retrieved later in the shopping cart > (autoSaveList). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12828) Persist OrderItemAttributes of ShoppingCartItem in new entity ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList)
[ https://issues.apache.org/jira/browse/OFBIZ-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748220#comment-17748220 ] ASF subversion and git services commented on OFBIZ-12828: - Commit 3d349c48708723e99220858cc45b8f392ec50eaf in ofbiz-framework's branch refs/heads/trunk from Sebastian Berg [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3d349c4870 ] Fixed: Persist OrderItemAttribute of ShoppingCartItem (OFBIZ-12828) Fix introduced so that OrderItemAttributes are persisted inside ShoppingCartItemAttributes from now on. Checkstyle ParameterNumber needed to be increased by one > Persist OrderItemAttributes of ShoppingCartItem in new entity > ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList) > - > > Key: OFBIZ-12828 > URL: https://issues.apache.org/jira/browse/OFBIZ-12828 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Pascal Zoschke >Assignee: Pascal Zoschke >Priority: Minor > > Currently, the information about the attributes of the order item is not > saved and therefore cannot be retrieved later in the shopping cart > (autoSaveList). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OFBIZ-12828) Persist OrderItemAttributes of ShoppingCartItem in new entity ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList)
[ https://issues.apache.org/jira/browse/OFBIZ-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-12828: - Assignee: Michael Brohl (was: Pascal Zoschke) > Persist OrderItemAttributes of ShoppingCartItem in new entity > ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList) > - > > Key: OFBIZ-12828 > URL: https://issues.apache.org/jira/browse/OFBIZ-12828 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Pascal Zoschke >Assignee: Michael Brohl >Priority: Minor > > Currently, the information about the attributes of the order item is not > saved and therefore cannot be retrieved later in the shopping cart > (autoSaveList). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] mbrohl merged pull request #662: Fixed: Persist OrderItemAttribute of ShoppingCartItem (OFBIZ-12828)
mbrohl merged PR #662: URL: https://github.com/apache/ofbiz-framework/pull/662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #663: Improved: Refactored DataResourceWorker getMimeType (OFBIZ-9403)
sonarcloud[bot] commented on PR #663: URL: https://github.com/apache/ofbiz-framework/pull/663#issuecomment-1653843442 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=663) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=663=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=663=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=663=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=663=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=663=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=663=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=663=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=663=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=663=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=663=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=663=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=663=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=663) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=663=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #664: Fixed: Convert InventoryServices.xml mini lang to groovy (OFBIZ-12174)
sonarcloud[bot] commented on PR #664: URL: https://github.com/apache/ofbiz-framework/pull/664#issuecomment-1653843373 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=664) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=664=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=664=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=664=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=664=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=664=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=664=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=664=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=664=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=664=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=664=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=664=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=664=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=664) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=664=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12174) Convert InventoryServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-12174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748190#comment-17748190 ] Chenghu Shan commented on OFBIZ-12174: -- Added a pull request for the latest fix that does not conflict with the recent groovy changes. (#664) > Convert InventoryServices.xml mini lang to groovy > - > > Key: OFBIZ-12174 > URL: https://issues.apache.org/jira/browse/OFBIZ-12174 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk, Upcoming Branch >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] cshan-ecomify opened a new pull request, #664: Fixed: Convert InventoryServices.xml mini lang to groovy (OFBIZ-12174)
cshan-ecomify opened a new pull request, #664: URL: https://github.com/apache/ofbiz-framework/pull/664 Fixed: Convert InventoryServices.xml mini lang to groovy (OFBIZ-12174) Thanks: SebastianEcomify -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-9403) DataResourceWorker: New method getMimeTypeFromFileName(...) with extracted (refactored) code from getMimeType(...) method
[ https://issues.apache.org/jira/browse/OFBIZ-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748182#comment-17748182 ] Chenghu Shan commented on OFBIZ-9403: - [~mbrohl] I created a new pull request. The method getMimeType that does not use a fallback now uses content.property defaultMimeType as fallback instead. Notice that the defaultMimeType there is text/html instead of octet-stream. > DataResourceWorker: New method getMimeTypeFromFileName(...) with extracted > (refactored) code from getMimeType(...) method > - > > Key: OFBIZ-9403 > URL: https://issues.apache.org/jira/browse/OFBIZ-9403 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Trunk, Upcoming Branch >Reporter: Martin Becker >Assignee: Chenghu Shan >Priority: Trivial > Attachments: OFBIZ-9403_DataResourceWorker_GetMimeType.patch, > OFBIZ-9403_DataResourceWorker_GetMimeType_with_defaultMimeTypeId.patch > > > The method DataResourceWorker.getMimeType(GenericValue) has been refactored > into two separate methods. The new additional method > getMimeTypeFromFileName(Delegator,Filename) solely focuses on getting the > MimeType from the file extension and is invoked by getMimeType(GenericValue) > if needed. getMimeType returns the type if possible via the data resource. > This results in cleaner code with the responsibility of both methods clearly > defined by the methods names. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #662: Fixed: Persist OrderItemAttribute of ShoppingCartItem (OFBIZ-12828)
sonarcloud[bot] commented on PR #662: URL: https://github.com/apache/ofbiz-framework/pull/662#issuecomment-1653740981 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=662) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=662=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=662=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=662=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=662=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=662=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=662=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=662=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=662=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=662=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=662=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=662=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=662=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=662) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=662=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=662=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] cshan-ecomify closed pull request #644: Improved: DataResourceWorker: New method getMimeType(...) (OFBIZ-9403)
cshan-ecomify closed pull request #644: Improved: DataResourceWorker: New method getMimeType(...) (OFBIZ-9403) URL: https://github.com/apache/ofbiz-framework/pull/644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (OFBIZ-9403) DataResourceWorker: New method getMimeTypeFromFileName(...) with extracted (refactored) code from getMimeType(...) method
[ https://issues.apache.org/jira/browse/OFBIZ-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chenghu Shan reassigned OFBIZ-9403: --- Assignee: Chenghu Shan (was: Michael Brohl) > DataResourceWorker: New method getMimeTypeFromFileName(...) with extracted > (refactored) code from getMimeType(...) method > - > > Key: OFBIZ-9403 > URL: https://issues.apache.org/jira/browse/OFBIZ-9403 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Trunk, Upcoming Branch >Reporter: Martin Becker >Assignee: Chenghu Shan >Priority: Trivial > Attachments: OFBIZ-9403_DataResourceWorker_GetMimeType.patch, > OFBIZ-9403_DataResourceWorker_GetMimeType_with_defaultMimeTypeId.patch > > > The method DataResourceWorker.getMimeType(GenericValue) has been refactored > into two separate methods. The new additional method > getMimeTypeFromFileName(Delegator,Filename) solely focuses on getting the > MimeType from the file extension and is invoked by getMimeType(GenericValue) > if needed. getMimeType returns the type if possible via the data resource. > This results in cleaner code with the responsibility of both methods clearly > defined by the methods names. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] cshan-ecomify opened a new pull request, #663: Improved: Refactored DataResourceWorker getMimeType (OFBIZ-9403)
cshan-ecomify opened a new pull request, #663: URL: https://github.com/apache/ofbiz-framework/pull/663 Improved: Refactored DataResourceWorker getMimeType (OFBIZ-9403) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] SebastianEcomify closed pull request #661: Improved: Persist OrderItemAttribute of ShoppingCartItem (OFBIZ-12828)
SebastianEcomify closed pull request #661: Improved: Persist OrderItemAttribute of ShoppingCartItem (OFBIZ-12828) URL: https://github.com/apache/ofbiz-framework/pull/661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] SebastianEcomify opened a new pull request, #662: Fixed: Persist OrderItemAttribute of ShoppingCartItem (OFBIZ-12828)
SebastianEcomify opened a new pull request, #662: URL: https://github.com/apache/ofbiz-framework/pull/662 Fixed: Persist OrderItemAttribute of ShoppingCartItem (OFBIZ-12828) Fix introduced so that OrderItemAttributes are persisted inside ShoppingCartItemAttributes from now on. Checkstyle ParameterNumber needed to be increased by one Thanks: Pascal Zoschke for providing the initial fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12828) Persist OrderItemAttributes of ShoppingCartItem in new entity ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList)
[ https://issues.apache.org/jira/browse/OFBIZ-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748169#comment-17748169 ] Michael Brohl commented on OFBIZ-12828: --- I think this should be classified as a bug because data is lost after retrieving a persisted ShoppingCart. > Persist OrderItemAttributes of ShoppingCartItem in new entity > ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList) > - > > Key: OFBIZ-12828 > URL: https://issues.apache.org/jira/browse/OFBIZ-12828 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Pascal Zoschke >Assignee: Pascal Zoschke >Priority: Minor > > Currently, the information about the attributes of the order item is not > saved and therefore cannot be retrieved later in the shopping cart > (autoSaveList). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12828) Persist OrderItemAttributes of ShoppingCartItem in new entity ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList)
[ https://issues.apache.org/jira/browse/OFBIZ-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-12828: -- Component/s: order Issue Type: Bug (was: Improvement) > Persist OrderItemAttributes of ShoppingCartItem in new entity > ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList) > - > > Key: OFBIZ-12828 > URL: https://issues.apache.org/jira/browse/OFBIZ-12828 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Pascal Zoschke >Assignee: Pascal Zoschke >Priority: Minor > > Currently, the information about the attributes of the order item is not > saved and therefore cannot be retrieved later in the shopping cart > (autoSaveList). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12828) Persist OrderItemAttributes of ShoppingCartItem in new entity ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList)
[ https://issues.apache.org/jira/browse/OFBIZ-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748166#comment-17748166 ] Sebastian Berg commented on OFBIZ-12828: Hi, I provided a new PR to account for the moved groovy Files so the PR should work without conflicts now. Thanks Pascal Zoschke for providing the initial Patch. > Persist OrderItemAttributes of ShoppingCartItem in new entity > ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList) > - > > Key: OFBIZ-12828 > URL: https://issues.apache.org/jira/browse/OFBIZ-12828 > Project: OFBiz > Issue Type: Improvement >Reporter: Pascal Zoschke >Assignee: Pascal Zoschke >Priority: Minor > > Currently, the information about the attributes of the order item is not > saved and therefore cannot be retrieved later in the shopping cart > (autoSaveList). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #660: Fixed: Convert InventoryServices.xml mini lang to groovy (OFBIZ-12174)
sonarcloud[bot] commented on PR #660: URL: https://github.com/apache/ofbiz-framework/pull/660#issuecomment-1653625836 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=660) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=660=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=660=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=660=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=660=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=660=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=660=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=660=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=660=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=660=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=660=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=660=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=660=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=660) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=660=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] SebastianEcomify opened a new pull request, #661: Improved: Persist OrderItemAttribute of ShoppingCartItem (OFBIZ-12828)
SebastianEcomify opened a new pull request, #661: URL: https://github.com/apache/ofbiz-framework/pull/661 Improved: Persist OrderItemAttribute of ShoppingCartItem (OFBIZ-12828) Improvement introduced so that OrderItemAttributes are persisted inside ShoppingCartItemAttributes from now on. Thanks: Pascal Zoschke for providing the Patch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wiebke Paetzold closed OFBIZ-12813. --- Fix Version/s: Upcoming Branch Resolution: Fixed > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Wiebke Paetzold >Priority: Major > Fix For: Upcoming Branch > > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748162#comment-17748162 ] Wiebke Paetzold commented on OFBIZ-12813: - Thanks [~jleroux] and [~deepak] for reviewing :) > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Wiebke Paetzold >Priority: Major > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748146#comment-17748146 ] ASF subversion and git services commented on OFBIZ-12813: - Commit cd078dc75142a5d5f5fe4adb992cee2398937077 in ofbiz-framework's branch refs/heads/trunk from Wiebke Pätzold [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=cd078dc751 ] Improved: Renames folder return to orderReturn (OFBIZ-12813) This is a preprocessing step for the package declaration in groovy scripts since return is not allowed in package declaration > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Wiebke Paetzold >Priority: Major > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748150#comment-17748150 ] ASF subversion and git services commented on OFBIZ-12813: - Commit 9d748e881cf2e7e5360675bf9499b23ea0f02a96 in ofbiz-framework's branch refs/heads/trunk from Cheng Hu Shan [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9d748e881c ] Improved: Groovy tests are no longer automatically added to gradle test sourceSet (OFBIZ-12813) > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Wiebke Paetzold >Priority: Major > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748145#comment-17748145 ] ASF subversion and git services commented on OFBIZ-12813: - Commit 9303de5e88da6a80fe4a3a1ef75fad181619ff0a in ofbiz-framework's branch refs/heads/trunk from Wiebke Pätzold [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9303de5e88 ] Improved: Renames some groovy scripts (OFBIZ-12813) This is a preprocessing step for the package declaration in groovy scripts since there should no duplicated classes > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Wiebke Paetzold >Priority: Major > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748144#comment-17748144 ] ASF subversion and git services commented on OFBIZ-12813: - Commit 0cbdbee7cd9db01f6b37de2576d6661b7e9fb421 in ofbiz-framework's branch refs/heads/trunk from Wiebke Pätzold [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0cbdbee7cd ] Improved: Moves imports under the license header (OFBIZ-12813) > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Wiebke Paetzold >Priority: Major > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748148#comment-17748148 ] ASF subversion and git services commented on OFBIZ-12813: - Commit 23fc31f78158bd8bee84fc67c968dcf7224d3882 in ofbiz-framework's branch refs/heads/trunk from Wiebke Pätzold [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=23fc31f781 ] Fixed: Fixes a reference for GetLocaleList.groovy (OFBIZ-12813) > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Wiebke Paetzold >Priority: Major > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748149#comment-17748149 ] ASF subversion and git services commented on OFBIZ-12813: - Commit c7eeb0b70eb56952fb8d51ab2f1487e0f26eb8ea in ofbiz-framework's branch refs/heads/trunk from Wiebke Pätzold [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c7eeb0b70e ] Improved: Renames some groovy scripts to avoid duplicate classes (OFBIZ-12813) > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Wiebke Paetzold >Priority: Major > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748147#comment-17748147 ] ASF subversion and git services commented on OFBIZ-12813: - Commit 7c3e32d9f98ec21609acd07ec4de5cb512a3f9b1 in ofbiz-framework's branch refs/heads/trunk from Wiebke Pätzold [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7c3e32d9f9 ] Improved: Moves groovy scripts to src and adds a package declaration to all of them (OFBIZ-12813) > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Wiebke Paetzold >Priority: Major > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] wpaetzold merged pull request #653: Improved: Refactoring groovy folder structure and package declaration (OFBIZ-12813)
wpaetzold merged PR #653: URL: https://github.com/apache/ofbiz-framework/pull/653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] mbrohl commented on pull request #660: Fixed: Convert InventoryServices.xml mini lang to groovy (OFBIZ-12174)
mbrohl commented on PR #660: URL: https://github.com/apache/ofbiz-framework/pull/660#issuecomment-1653574583 Should be applied after https://github.com/apache/ofbiz-framework/pull/653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] SebastianEcomify opened a new pull request, #660: Fixed: Convert InventoryServices.xml mini lang to groovy (OFBIZ-12174)
SebastianEcomify opened a new pull request, #660: URL: https://github.com/apache/ofbiz-framework/pull/660 Fixed: Convert InventoryServices.xml mini lang to groovy (OFBIZ-12174) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11434) Forum Articles do not respond to pagination
[
https://issues.apache.org/jira/browse/OFBIZ-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748132#comment-17748132
]
Michael Brohl commented on OFBIZ-11434:
---
Thanks, [~jleroux] !
> Forum Articles do not respond to pagination
> ---
>
> Key: OFBIZ-11434
> URL: https://issues.apache.org/jira/browse/OFBIZ-11434
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk, 22.01.01, Upcoming Branch
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Minor
> Labels: backport-needed
> Fix For: 22.01.01, 18.12.09
>
> Attachments: OFBIZ-11434.patch
>
>
> Neither the view-size nor the view-index have any effect on the shown
> articles in the forum.
> To reproduce:
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message" 21 times
> # Try using the pagination
> Should be: The view should be limited to 20 items on the first page, if the
> view-size is 20. The second page should only display the 21st entry.
> Is: The list always shows all 21 entries.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (OFBIZ-11434) Forum Articles do not respond to pagination
[
https://issues.apache.org/jira/browse/OFBIZ-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-11434.
---
Fix Version/s: 22.01.01
18.12.09
(was: Upcoming Branch)
Resolution: Fixed
Done, closing
> Forum Articles do not respond to pagination
> ---
>
> Key: OFBIZ-11434
> URL: https://issues.apache.org/jira/browse/OFBIZ-11434
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk, 22.01.01, Upcoming Branch
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Minor
> Labels: backport-needed
> Fix For: 22.01.01, 18.12.09
>
> Attachments: OFBIZ-11434.patch
>
>
> Neither the view-size nor the view-index have any effect on the shown
> articles in the forum.
> To reproduce:
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message" 21 times
> # Try using the pagination
> Should be: The view should be limited to 20 items on the first page, if the
> view-size is 20. The second page should only display the 21st entry.
> Is: The list always shows all 21 entries.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11434) Forum Articles do not respond to pagination
[
https://issues.apache.org/jira/browse/OFBIZ-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748124#comment-17748124
]
ASF subversion and git services commented on OFBIZ-11434:
-
Commit bcd4e43390db53eeb9e9858e005703e4f28b2cef in ofbiz-plugins's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=bcd4e4339 ]
Fixed: Makes Forum Articles respond to pagination controls (OFBIZ-11434) (#76)
Fixes a checkstyle issue
> Forum Articles do not respond to pagination
> ---
>
> Key: OFBIZ-11434
> URL: https://issues.apache.org/jira/browse/OFBIZ-11434
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk, 22.01.01, Upcoming Branch
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Minor
> Labels: backport-needed
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11434.patch
>
>
> Neither the view-size nor the view-index have any effect on the shown
> articles in the forum.
> To reproduce:
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message" 21 times
> # Try using the pagination
> Should be: The view should be limited to 20 items on the first page, if the
> view-size is 20. The second page should only display the 21st entry.
> Is: The list always shows all 21 entries.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11434) Forum Articles do not respond to pagination
[
https://issues.apache.org/jira/browse/OFBIZ-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748123#comment-17748123
]
ASF subversion and git services commented on OFBIZ-11434:
-
Commit c82a3d80299ca4c37387b74bbae5ca69d1a9d759 in ofbiz-plugins's branch
refs/heads/release18.12 from cshan-ecomify
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=c82a3d802 ]
Fixed: Makes Forum Articles respond to pagination controls (OFBIZ-11434) (#76)
* Fixed: Makes Forum Articles respond to pagination controls (OFBIZ-11434)
* Improved: Removed commented out code (OFBIZ-11434)
Conflict handled by hand ecommerce/template/forum/ForumPaging.ftl
> Forum Articles do not respond to pagination
> ---
>
> Key: OFBIZ-11434
> URL: https://issues.apache.org/jira/browse/OFBIZ-11434
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk, 22.01.01, Upcoming Branch
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Minor
> Labels: backport-needed
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11434.patch
>
>
> Neither the view-size nor the view-index have any effect on the shown
> articles in the forum.
> To reproduce:
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message" 21 times
> # Try using the pagination
> Should be: The view should be limited to 20 items on the first page, if the
> view-size is 20. The second page should only display the 21st entry.
> Is: The list always shows all 21 entries.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11434) Forum Articles do not respond to pagination
[
https://issues.apache.org/jira/browse/OFBIZ-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748127#comment-17748127
]
ASF subversion and git services commented on OFBIZ-11434:
-
Commit 92482873670d5c0bded888919c5eec5ebaceb367 in ofbiz-plugins's branch
refs/heads/release22.01 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=924828736 ]
Fixed: Makes Forum Articles respond to pagination controls (OFBIZ-11434) (#76)
Fixes a checkstyle issue
> Forum Articles do not respond to pagination
> ---
>
> Key: OFBIZ-11434
> URL: https://issues.apache.org/jira/browse/OFBIZ-11434
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk, 22.01.01, Upcoming Branch
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Minor
> Labels: backport-needed
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11434.patch
>
>
> Neither the view-size nor the view-index have any effect on the shown
> articles in the forum.
> To reproduce:
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message" 21 times
> # Try using the pagination
> Should be: The view should be limited to 20 items on the first page, if the
> view-size is 20. The second page should only display the 21st entry.
> Is: The list always shows all 21 entries.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11434) Forum Articles do not respond to pagination
[
https://issues.apache.org/jira/browse/OFBIZ-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748128#comment-17748128
]
ASF subversion and git services commented on OFBIZ-11434:
-
Commit ddebed1dc971ea6713b205e1260ecf6e1445704b in ofbiz-plugins's branch
refs/heads/release22.01 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=ddebed1dc ]
Fixed: Makes Forum Articles respond to pagination controls (OFBIZ-11434) (#76)
Definitely fixes a checkstyle issue (was not awake before and the plugins
branch has not
safeguard like the framework, I mean the Git pre-push hook )
> Forum Articles do not respond to pagination
> ---
>
> Key: OFBIZ-11434
> URL: https://issues.apache.org/jira/browse/OFBIZ-11434
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk, 22.01.01, Upcoming Branch
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Minor
> Labels: backport-needed
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11434.patch
>
>
> Neither the view-size nor the view-index have any effect on the shown
> articles in the forum.
> To reproduce:
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message" 21 times
> # Try using the pagination
> Should be: The view should be limited to 20 items on the first page, if the
> view-size is 20. The second page should only display the 21st entry.
> Is: The list always shows all 21 entries.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11434) Forum Articles do not respond to pagination
[
https://issues.apache.org/jira/browse/OFBIZ-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748125#comment-17748125
]
ASF subversion and git services commented on OFBIZ-11434:
-
Commit fd4a24d7eb94d6248c27b375dcf1ad9698beeac1 in ofbiz-plugins's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=fd4a24d7e ]
Fixed: Makes Forum Articles respond to pagination controls (OFBIZ-11434) (#76)
Definitely fixes a checkstyle issue (was not awake before and the plugins
branch has not
safeguard like the framework, I mean the Git pre-push hook )
> Forum Articles do not respond to pagination
> ---
>
> Key: OFBIZ-11434
> URL: https://issues.apache.org/jira/browse/OFBIZ-11434
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk, 22.01.01, Upcoming Branch
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Minor
> Labels: backport-needed
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11434.patch
>
>
> Neither the view-size nor the view-index have any effect on the shown
> articles in the forum.
> To reproduce:
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message" 21 times
> # Try using the pagination
> Should be: The view should be limited to 20 items on the first page, if the
> view-size is 20. The second page should only display the 21st entry.
> Is: The list always shows all 21 entries.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11434) Forum Articles do not respond to pagination
[
https://issues.apache.org/jira/browse/OFBIZ-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748126#comment-17748126
]
ASF subversion and git services commented on OFBIZ-11434:
-
Commit aae4237d92d8ca6389e447e070aba47f8551487b in ofbiz-plugins's branch
refs/heads/release22.01 from cshan-ecomify
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=aae4237d9 ]
Fixed: Makes Forum Articles respond to pagination controls (OFBIZ-11434) (#76)
* Fixed: Makes Forum Articles respond to pagination controls (OFBIZ-11434)
* Improved: Removed commented out code (OFBIZ-11434)
> Forum Articles do not respond to pagination
> ---
>
> Key: OFBIZ-11434
> URL: https://issues.apache.org/jira/browse/OFBIZ-11434
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk, 22.01.01, Upcoming Branch
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Minor
> Labels: backport-needed
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11434.patch
>
>
> Neither the view-size nor the view-index have any effect on the shown
> articles in the forum.
> To reproduce:
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message" 21 times
> # Try using the pagination
> Should be: The view should be limited to 20 items on the first page, if the
> view-size is 20. The second page should only display the 21st entry.
> Is: The list always shows all 21 entries.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-9403) DataResourceWorker: New method getMimeTypeFromFileName(...) with extracted (refactored) code from getMimeType(...) method
[ https://issues.apache.org/jira/browse/OFBIZ-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748111#comment-17748111 ] Michael Brohl commented on OFBIZ-9403: -- [~cshan] I think we should take the defaultMimeType from applications/content/config/content.properties instead of a hard coded one, can you please change it accordingly? > DataResourceWorker: New method getMimeTypeFromFileName(...) with extracted > (refactored) code from getMimeType(...) method > - > > Key: OFBIZ-9403 > URL: https://issues.apache.org/jira/browse/OFBIZ-9403 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Trunk, Upcoming Branch >Reporter: Martin Becker >Assignee: Michael Brohl >Priority: Trivial > Attachments: OFBIZ-9403_DataResourceWorker_GetMimeType.patch, > OFBIZ-9403_DataResourceWorker_GetMimeType_with_defaultMimeTypeId.patch > > > The method DataResourceWorker.getMimeType(GenericValue) has been refactored > into two separate methods. The new additional method > getMimeTypeFromFileName(Delegator,Filename) solely focuses on getting the > MimeType from the file extension and is invoked by getMimeType(GenericValue) > if needed. getMimeType returns the type if possible via the data resource. > This results in cleaner code with the responsibility of both methods clearly > defined by the methods names. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] mbrohl commented on pull request #644: Improved: DataResourceWorker: New method getMimeType(...) (OFBIZ-9403)
mbrohl commented on PR #644: URL: https://github.com/apache/ofbiz-framework/pull/644#issuecomment-1653453910 @cshan-ecomify I think we should take the defaultMimeType from applications/content/config/content.properties instead of a hard coded one, can you please change it accordingly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11434) Forum Articles do not respond to pagination
[
https://issues.apache.org/jira/browse/OFBIZ-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748110#comment-17748110
]
Jacques Le Roux commented on OFBIZ-11434:
-
Hi Michael,
We need 1st to backport, at least to 22.01. I'll check that...
> Forum Articles do not respond to pagination
> ---
>
> Key: OFBIZ-11434
> URL: https://issues.apache.org/jira/browse/OFBIZ-11434
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk, 22.01.01, Upcoming Branch
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Minor
> Labels: backport-needed
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11434.patch
>
>
> Neither the view-size nor the view-index have any effect on the shown
> articles in the forum.
> To reproduce:
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message" 21 times
> # Try using the pagination
> Should be: The view should be limited to 20 items on the first page, if the
> view-size is 20. The second page should only display the 21st entry.
> Is: The list always shows all 21 entries.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11434) Forum Articles do not respond to pagination
[
https://issues.apache.org/jira/browse/OFBIZ-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748106#comment-17748106
]
Michael Brohl commented on OFBIZ-11434:
---
[~jleroux] shouldn't this be closed already?
> Forum Articles do not respond to pagination
> ---
>
> Key: OFBIZ-11434
> URL: https://issues.apache.org/jira/browse/OFBIZ-11434
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk, 22.01.01, Upcoming Branch
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Minor
> Labels: backport-needed
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11434.patch
>
>
> Neither the view-size nor the view-index have any effect on the shown
> articles in the forum.
> To reproduce:
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message" 21 times
> # Try using the pagination
> Should be: The view should be limited to 20 items on the first page, if the
> view-size is 20. The second page should only display the 21st entry.
> Is: The list always shows all 21 entries.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [ofbiz-framework] mbrohl commented on a diff in pull request #592: Improved: Improvement to createPartyRelationship service (OFBIZ-12765)
mbrohl commented on code in PR #592:
URL: https://github.com/apache/ofbiz-framework/pull/592#discussion_r1276148465
##
applications/party/groovyScripts/party/PartyServices.groovy:
##
@@ -427,13 +427,49 @@ def createPartyRelationship() {
partyIdTo: parameters.partyIdTo,
roleTypeIdFrom: parameters.roleTypeIdFrom,
roleTypeIdTo: parameters.roleTypeIdTo)
-.filterByDate()
.queryList()
-if (!partyRels) {
-GenericValue partyRelationship = makeValue('PartyRelationship',
parameters)
-partyRelationship.create()
+
+if (partyRels) {
+// checks for conflicts with existing unlimited valid entries
+for (GenericValue partyRel : partyRels) {
+if (!partyRel.thruDate) {
+if (parameters.fromDate.after(partyRel.fromDate))
+return success()
+}
+}
+
+// checks if there are any conflicts with the time periods of the
entries
+if (!parameters.thruDate) {
+for(GenericValue partyRel : partyRels) {
+if ((parameters.fromDate.before(partyRel.fromDate)) ||
(parameters.fromDate.before(partyRel.thruDate))) {
+return success()
+}
+}
+} else {
+EntityCondition partyCond =
Review Comment:
@dixitdeepak are you ok with the change after my explanation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (OFBIZ-12830) Reduction of recurring INFO logs
[ https://issues.apache.org/jira/browse/OFBIZ-12830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-12830: - Assignee: Michael Brohl (was: Chenghu Shan) > Reduction of recurring INFO logs > > > Key: OFBIZ-12830 > URL: https://issues.apache.org/jira/browse/OFBIZ-12830 > Project: OFBiz > Issue Type: Improvement > Components: content, framework >Affects Versions: Upcoming Branch >Reporter: Chenghu Shan >Assignee: Michael Brohl >Priority: Trivial > Fix For: Upcoming Branch > > > Many standard recurring actions are currently logged at the INFO level. These > include actions such as creating a certain number of screens via > ScreenFactory, loading a controller in a certain amount of time via > ConfigXMLReader or setting default values via ModelService. > We should bump them down to VERBOSE level to reduce the amount of log > cluttering. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OFBIZ-12830) Reduction of recurring INFO logs
[ https://issues.apache.org/jira/browse/OFBIZ-12830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-12830: - Assignee: (was: Michael Brohl) > Reduction of recurring INFO logs > > > Key: OFBIZ-12830 > URL: https://issues.apache.org/jira/browse/OFBIZ-12830 > Project: OFBiz > Issue Type: Improvement > Components: content, framework >Affects Versions: Upcoming Branch >Reporter: Chenghu Shan >Priority: Trivial > Fix For: Upcoming Branch > > > Many standard recurring actions are currently logged at the INFO level. These > include actions such as creating a certain number of screens via > ScreenFactory, loading a controller in a certain amount of time via > ConfigXMLReader or setting default values via ModelService. > We should bump them down to VERBOSE level to reduce the amount of log > cluttering. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12842) UtilHttp.getPathInfoOnlyParameterMap should be public
[ https://issues.apache.org/jira/browse/OFBIZ-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748102#comment-17748102 ] ASF subversion and git services commented on OFBIZ-12842: - Commit 3f7776159dc1285aeb054dbe5eaf5003449bf687 in ofbiz-framework's branch refs/heads/trunk from Cheng Hu Shan [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3f7776159d ] Improved: getPathInfoOnlyParameterMap should be public (OFBIZ-12842) > UtilHttp.getPathInfoOnlyParameterMap should be public > - > > Key: OFBIZ-12842 > URL: https://issues.apache.org/jira/browse/OFBIZ-12842 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: Chenghu Shan >Assignee: Michael Brohl >Priority: Minor > > The method UtilHttp.getPathInfoOnlyParameterMap should be public. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12842) UtilHttp.getPathInfoOnlyParameterMap should be public
[ https://issues.apache.org/jira/browse/OFBIZ-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-12842. - Fix Version/s: Upcoming Branch Resolution: Implemented Thanks [~cshan] > UtilHttp.getPathInfoOnlyParameterMap should be public > - > > Key: OFBIZ-12842 > URL: https://issues.apache.org/jira/browse/OFBIZ-12842 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: Chenghu Shan >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > > The method UtilHttp.getPathInfoOnlyParameterMap should be public. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12841) GenericDelegator.findList should return unmodifiable list when using cache
[ https://issues.apache.org/jira/browse/OFBIZ-12841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-12841. - Fix Version/s: Upcoming Branch Resolution: Fixed Thanks [~cshan] > GenericDelegator.findList should return unmodifiable list when using cache > -- > > Key: OFBIZ-12841 > URL: https://issues.apache.org/jira/browse/OFBIZ-12841 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Upcoming Branch >Reporter: Chenghu Shan >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > > The findList method in GenericDelegator may return different results for the > same search parameters when using caching if list operations are used on the > returned list. This is because the actual cacheList is returned instead of an > unmodifiable copy. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] mbrohl merged pull request #659: Improved: getPathInfoOnlyParameterMap should be public (OFBIZ-12842)
mbrohl merged PR #659: URL: https://github.com/apache/ofbiz-framework/pull/659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (OFBIZ-12842) UtilHttp.getPathInfoOnlyParameterMap should be public
[ https://issues.apache.org/jira/browse/OFBIZ-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-12842: - Assignee: Michael Brohl (was: Chenghu Shan) > UtilHttp.getPathInfoOnlyParameterMap should be public > - > > Key: OFBIZ-12842 > URL: https://issues.apache.org/jira/browse/OFBIZ-12842 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: Chenghu Shan >Assignee: Michael Brohl >Priority: Minor > > The method UtilHttp.getPathInfoOnlyParameterMap should be public. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OFBIZ-12841) GenericDelegator.findList should return unmodifiable list when using cache
[ https://issues.apache.org/jira/browse/OFBIZ-12841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-12841: - Assignee: Michael Brohl > GenericDelegator.findList should return unmodifiable list when using cache > -- > > Key: OFBIZ-12841 > URL: https://issues.apache.org/jira/browse/OFBIZ-12841 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Upcoming Branch >Reporter: Chenghu Shan >Assignee: Michael Brohl >Priority: Minor > > The findList method in GenericDelegator may return different results for the > same search parameters when using caching if list operations are used on the > returned list. This is because the actual cacheList is returned instead of an > unmodifiable copy. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] mbrohl merged pull request #658: Bugfix: findList method should return unmodifiable list (OFBIZ-12841)
mbrohl merged PR #658: URL: https://github.com/apache/ofbiz-framework/pull/658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12829) Improvements for ContentWorker methods and view-entities
[ https://issues.apache.org/jira/browse/OFBIZ-12829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748096#comment-17748096 ] Michael Brohl commented on OFBIZ-12829: --- Looks good to me, any objections to merge? > Improvements for ContentWorker methods and view-entities > > > Key: OFBIZ-12829 > URL: https://issues.apache.org/jira/browse/OFBIZ-12829 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Upcoming Branch >Reporter: Chenghu Shan >Assignee: Michael Brohl >Priority: Minor > > Adds additional methods to ContentWorker: > * New method findAlternateLocalContents to find all alternate locale > contents instead of just one specific. > * Overloaded methods of findAlternateLocalContents and > findAlternateLocalContent to enable/disable cache use. > * These methods are no longer case sensitive when comparing localeStrings > Changes to view-entites ProductContentAndInfo and > ProductCategoryContentAndInfo: > * Both now use an outer join instead of inner join between DataResource and > Content, because there may be a Content object without a DataResource for its > locale but with alternate locale content objects associated to it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] mbrohl commented on pull request #643: Improvements for ContentWorker methods and view-entities (OFBIZ-12829)
mbrohl commented on PR #643: URL: https://github.com/apache/ofbiz-framework/pull/643#issuecomment-1653419334 Looks good to me, any objections to merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (OFBIZ-12829) Improvements for ContentWorker methods and view-entities
[ https://issues.apache.org/jira/browse/OFBIZ-12829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-12829: - Assignee: Michael Brohl (was: Chenghu Shan) > Improvements for ContentWorker methods and view-entities > > > Key: OFBIZ-12829 > URL: https://issues.apache.org/jira/browse/OFBIZ-12829 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Upcoming Branch >Reporter: Chenghu Shan >Assignee: Michael Brohl >Priority: Minor > > Adds additional methods to ContentWorker: > * New method findAlternateLocalContents to find all alternate locale > contents instead of just one specific. > * Overloaded methods of findAlternateLocalContents and > findAlternateLocalContent to enable/disable cache use. > * These methods are no longer case sensitive when comparing localeStrings > Changes to view-entites ProductContentAndInfo and > ProductCategoryContentAndInfo: > * Both now use an outer join instead of inner join between DataResource and > Content, because there may be a Content object without a DataResource for its > locale but with alternate locale content objects associated to it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #659: Improved: getPathInfoOnlyParameterMap should be public (OFBIZ-12842)
sonarcloud[bot] commented on PR #659: URL: https://github.com/apache/ofbiz-framework/pull/659#issuecomment-1653373001 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=659) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=659=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=659=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=659=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=659=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=659=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=659=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=659=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=659=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=659=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=659=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=659=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=659=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=659) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=659=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748075#comment-17748075 ] Jacques Le Roux commented on OFBIZ-12813: - Ah, thanks Michael, it's all clear > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Wiebke Paetzold >Priority: Major > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748074#comment-17748074 ] Jacques Le Roux commented on OFBIZ-12813: - Apart this question, it's OK with me. As you certainly know we can get a patch from a PR, [here|https://patch-diff.githubusercontent.com/raw/apache/ofbiz-framework/pull/653.patch]. The same I used with Eclipse. But, as can be seen above, the patch generated by GH from the PR is too complex to be interpreted by Eclipse. Same using git apply after saving the patch locally. Actually it's seems to be the same process. After reviewing half manually with GH web UI yesterday, I used [this trick|https://gist.github.com/juanca/5fd799c5b094e3e4f8b709cd101d7403] to load all diffs. Even doing so, of course it's too much work. I finally paginated the rest with only random reviews. After these reviews, as the PR comes from a script, I believe it's OK. I did not notice any weird cases. So please merge and push :) > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Wiebke Paetzold >Priority: Major > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #658: Bugfix: findList method should return unmodifiable list (OFBIZ-12841)
sonarcloud[bot] commented on PR #658: URL: https://github.com/apache/ofbiz-framework/pull/658#issuecomment-1653340234 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=658) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=658=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=658=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=658=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=658=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=658=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=658=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=658=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=658=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=658=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=658=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=658=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=658=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=658) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=658=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747913#comment-17747913 ] Michael Brohl commented on OFBIZ-12813: --- return is a reserved word and cannot be used for package names. > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Wiebke Paetzold >Priority: Major > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-10194) ContentWrapper empty string result breaks simple FTL null check and default syntax
[
https://issues.apache.org/jira/browse/OFBIZ-10194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747911#comment-17747911
]
Michael Brohl commented on OFBIZ-10194:
---
This looks good to me an is field tested in custom projects for some time now.
Any objections to merge?
> ContentWrapper empty string result breaks simple FTL null check and default
> syntax
> --
>
> Key: OFBIZ-10194
> URL: https://issues.apache.org/jira/browse/OFBIZ-10194
> Project: OFBiz
> Issue Type: Bug
> Components: content, order, party, product
>Affects Versions: 16.11.04
>Reporter: Martin Becker
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBiz-10194_ContentWrappers.patch
>
>
> Since the changes to the ContentWrappers from Ticket
> https://issues.apache.org/jira/browse/OFBIZ-6701 the result for non existing
> content is an empty string instead of NULL.
> Aside from my opinion, that this is generally a bad design preferred by those
> who do not like to check for null values within their code, this behavior
> breaks the simple FTL syntax for using an alternate (default) value for a non
> existing content, retrieved by a ContentWrapper like this:
> {code:java}
> <#assign categoryName = categoryContentWrapper.get("CATEGORY_NAME",
> "string")!category.internalName?default(category.productCategoryId) />{code}
> Basically this was done to get the non-existing-content cached within the
> *.content.rendered cache and let the simple condition
> {code:java}
> if (cachedValue != null){code}
> after a cache.get() respect this empty value. With a simple change to the
> condition to
> {code:java}
> if (cachedValue != null || cache.containsKey(cacheKey)){code}
> it is also possible to cache and successfully retrieve NULL values from the
> cache.
> I observed this now during an upgrade of OFBiz 12 based application code to
> the current OFBiz release.
> Besides this I did following refactorings consistently for all ContentWrapper
> implementations to reduce code redundancy:
> * centralized default mimeTypeId retrieval (static Interface method in
> ContentWrapper)
> * centralized encoding of result string via UtilEncoder (static Interface
> method in ContentWrapper)
> * centralized/generalized candidate field value retrieval (static Interface
> method in ContentWrapper)
> * harmonized content cache name to „xyz.content.rendered“, some wrappers did
> not use the „.rendered“ suffix in their cache name
> * fixed some missing useCache parameter use in EntityQuery…cache()… calls
> For Category and Product ContentWrapper I updated the parameter handling of
> the central getXyzContentAsText method where both, productId and product
> GenericValue are given but no check is performed, if both are matching if
> both are given (bad parameter signature, by the way). Now the product GV is
> looked up, if a productId is given, and the productId is used from a given
> product GV always, not only if it is missing. The drawback is, that there
> will always be a lookup for Product/ProductCategory GV, even if a content
> entry could be found with the productId/productCategoryId only. On the other
> hand, the GV is always part of the content rendering input context, currently
> it is missing there, if only a ID is given as parameter, again not really
> consistent.
> I did not wanted to change this for all content wrappers directly before
> getting a feedback for it, even if it would be more consistent to have a
> content rendering context with a product GV as input, independent of the
> original call parameters productId and/or product GV.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [ofbiz-framework] mbrohl commented on pull request #654: Improved: ContentWrapper empty string result breaks simple FTL null check and default syntax (OFBIZ-10194)
mbrohl commented on PR #654: URL: https://github.com/apache/ofbiz-framework/pull/654#issuecomment-1653325215 This looks good to me an is field tested in custom projects for some time now. Any objections to merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12840) Missing Getter in ShoppingCart and ConfigXMLReader
[ https://issues.apache.org/jira/browse/OFBIZ-12840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747897#comment-17747897 ] ASF subversion and git services commented on OFBIZ-12840: - Commit 2eae767e4026359dadac9870044d6eccafef61bd in ofbiz-framework's branch refs/heads/trunk from Cheng Hu Shan [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=2eae767e40 ] Improved: Added missing getter/setter (OFBIZ-12840) > Missing Getter in ShoppingCart and ConfigXMLReader > -- > > Key: OFBIZ-12840 > URL: https://issues.apache.org/jira/browse/OFBIZ-12840 > Project: OFBiz > Issue Type: Improvement > Components: framework, order >Affects Versions: Upcoming Branch >Reporter: Chenghu Shan >Assignee: Michael Brohl >Priority: Minor > > Some attributes are still missing getters. They should be added. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] cshan-ecomify opened a new pull request, #659: Improved: getPathInfoOnlyParameterMap should be public (OFBIZ-12842)
cshan-ecomify opened a new pull request, #659: URL: https://github.com/apache/ofbiz-framework/pull/659 Improved: getPathInfoOnlyParameterMap should be public (OFBIZ-12842) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (OFBIZ-12840) Missing Getter in ShoppingCart and ConfigXMLReader
[ https://issues.apache.org/jira/browse/OFBIZ-12840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-12840. - Fix Version/s: Upcoming Branch Resolution: Implemented Thanks [~cshan] > Missing Getter in ShoppingCart and ConfigXMLReader > -- > > Key: OFBIZ-12840 > URL: https://issues.apache.org/jira/browse/OFBIZ-12840 > Project: OFBiz > Issue Type: Improvement > Components: framework, order >Affects Versions: Upcoming Branch >Reporter: Chenghu Shan >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > > Some attributes are still missing getters. They should be added. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] mbrohl merged pull request #657: Improved: Added missing getter/setter (OFBIZ-12840)
mbrohl merged PR #657: URL: https://github.com/apache/ofbiz-framework/pull/657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] mbrohl closed pull request #652: Improved: Refactoring groovy folder structure and package declaration (OFBIZ-12813)
mbrohl closed pull request #652: Improved: Refactoring groovy folder structure and package declaration (OFBIZ-12813) URL: https://github.com/apache/ofbiz-framework/pull/652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (OFBIZ-12842) UtilHttp.getPathInfoOnlyParameterMap should be public
Chenghu Shan created OFBIZ-12842: Summary: UtilHttp.getPathInfoOnlyParameterMap should be public Key: OFBIZ-12842 URL: https://issues.apache.org/jira/browse/OFBIZ-12842 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Upcoming Branch Reporter: Chenghu Shan Assignee: Chenghu Shan The method UtilHttp.getPathInfoOnlyParameterMap should be public. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OFBIZ-12840) Missing Getter in ShoppingCart and ConfigXMLReader
[ https://issues.apache.org/jira/browse/OFBIZ-12840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-12840: - Assignee: Michael Brohl (was: Chenghu Shan) > Missing Getter in ShoppingCart and ConfigXMLReader > -- > > Key: OFBIZ-12840 > URL: https://issues.apache.org/jira/browse/OFBIZ-12840 > Project: OFBiz > Issue Type: Improvement > Components: framework, order >Affects Versions: Upcoming Branch >Reporter: Chenghu Shan >Assignee: Michael Brohl >Priority: Minor > > Some attributes are still missing getters. They should be added. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12841) GenericDelegator.findList should return unmodifiable list when using cache
[ https://issues.apache.org/jira/browse/OFBIZ-12841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747890#comment-17747890 ] Chenghu Shan commented on OFBIZ-12841: -- Pullrequest: [https://github.com/apache/ofbiz-framework/pull/658] I messed up the commit message. The pull request is not automatically added here. > GenericDelegator.findList should return unmodifiable list when using cache > -- > > Key: OFBIZ-12841 > URL: https://issues.apache.org/jira/browse/OFBIZ-12841 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Upcoming Branch >Reporter: Chenghu Shan >Priority: Minor > > The findList method in GenericDelegator may return different results for the > same search parameters when using caching if list operations are used on the > returned list. This is because the actual cacheList is returned instead of an > unmodifiable copy. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #657: Improved: Added missing getter/setter (OFBIZ-12840)
sonarcloud[bot] commented on PR #657: URL: https://github.com/apache/ofbiz-framework/pull/657#issuecomment-1653289977 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=657) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=657=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=657=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=657=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=657=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=657=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=657=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=657=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=657=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=657=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=657=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=657=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=657=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=657) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=657=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] cshan-ecomify opened a new pull request, #658: Bugfix: findList method should return unmodifiable list (OFBIZ -12841)
cshan-ecomify opened a new pull request, #658: URL: https://github.com/apache/ofbiz-framework/pull/658 Bugfix: GenericDelegator.findList method should return unmodifiable list (OFBIZ -12841) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747887#comment-17747887 ] Jacques Le Roux commented on OFBIZ-12813: - Hi Wiebke, I have a question : why order/return was renamed order/orderReturn? > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Wiebke Paetzold >Priority: Major > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12841) GenericDelegator.findList should return unmodifiable list when using cache
Chenghu Shan created OFBIZ-12841: Summary: GenericDelegator.findList should return unmodifiable list when using cache Key: OFBIZ-12841 URL: https://issues.apache.org/jira/browse/OFBIZ-12841 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Upcoming Branch Reporter: Chenghu Shan The findList method in GenericDelegator may return different results for the same search parameters when using caching if list operations are used on the returned list. This is because the actual cacheList is returned instead of an unmodifiable copy. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] cshan-ecomify opened a new pull request, #657: Improved: Added missing getter/setter (OFBIZ-12840)
cshan-ecomify opened a new pull request, #657: URL: https://github.com/apache/ofbiz-framework/pull/657 Improved: Added missing getter/setter in Shoppingcart.java and ConfigXMLReader.java (OFBIZ-12840) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747871#comment-17747871 ] Jacques Le Roux edited comment on OFBIZ-12813 at 7/27/23 9:15 AM: -- Hi Wiebke, Don't worry I don't need help on Eclipse. I'm still checking things and will come back to you soon... Anyway in case you would be gone I can push the PR for you. was (Author: jacques.le.roux): Hi Wiebke, Don't worry I don't need help on Eclipse. I'm still checking things and will come back to you soon... > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Wiebke Paetzold >Priority: Major > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747871#comment-17747871 ] Jacques Le Roux commented on OFBIZ-12813: - Hi Wiebke, Don't worry I don't need help on Eclipse. I'm still checking things and will come back to you soon... > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Wiebke Paetzold >Priority: Major > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747843#comment-17747843 ] Wiebke Paetzold commented on OFBIZ-12813: - Hi [~jleroux] , unfortunately I can not help you with your Eclipse issue, because before I started the restructuring I created a feature branch of the trunk and after the restructuring OFBIZ ran error free with me. Since I'm going on vacation I would like to close this ticket before, so that the state is not outdated again and merge conflicts with the trunk arise. Deepak has already given his ok and both the TestIntegration and the test (these are executed during the build) run error free. Do you see a chance from your side to give an ok here as soon as possible ? > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Wiebke Paetzold >Priority: Major > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12802) Extending calculateProductPrice (custom) Service and ShoppingCart / OrderItem to deliver/hold an individual discountRate value
[ https://issues.apache.org/jira/browse/OFBIZ-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Wolf updated OFBIZ-12802: Description: Background is the communication of an individually (informally) calculated discount rate from the price calculation to the OrderItem, with easy access to it (because of this not via the orderItemPriceInfos substructure). Extending ProductPrice.calculateProductPrice Service (all in PriceServices.java and services_pricepromo.xml): * Addition of additional context information "productStoreGroupId" and "partyId" to the call parameters of a "customMethodName" price-calc-service * Obtaining the fields discountRate and listPrice from calling a "customMethodName" price-calc-service * discountRate as Result Field * Retaining the bypassing of the OFBiz Standard PriceRules based on the presence of a ListPrice (only that it can now also come from the "customMethodName", therefore slightly changed decision logic) Extending ShoppingCart/Item, OrderItem Entity: * Transport original discount rate from custom price calculation over cart to order to have the correct rate instead of back-calculating it from unitPrice and unitListPrice was: Extending ProductPrice.calculateProductPrice Service (all in PriceServices.java and services_pricepromo.xml): * Addition of additional context information "productStoreGroupId" and "partyId" to the call parameters of a "customMethodName" price-calc-service * Obtaining the fields discountRate and listPrice from calling a "customMethodName" price-calc-service * discountRate as Result Field * Retaining the bypassing of the OFBiz Standard PriceRules based on the presence of a ListPrice (only that it can now also come from the "customMethodName", therefore slightly changed decision logic) Extending ShoppingCart/Item, OrderItem Entity: * Transport original discount rate from custom price calculation over cart to order to have the correct rate instead of back-calculating it from unitPrice and unitListPrice Background is the communication of an individually (informally) calculated discount rate from the price calculation to the OrderItem, with easy access to it (because of this not via the orderItemPriceInfos substructure). > Extending calculateProductPrice (custom) Service and ShoppingCart / OrderItem > to deliver/hold an individual discountRate value > -- > > Key: OFBIZ-12802 > URL: https://issues.apache.org/jira/browse/OFBIZ-12802 > Project: OFBiz > Issue Type: New Feature >Reporter: Adrian Wolf >Priority: Minor > > Background is the communication of an individually (informally) calculated > discount rate from the price calculation to the OrderItem, with easy access > to it (because of this not via the orderItemPriceInfos substructure). > > Extending ProductPrice.calculateProductPrice Service (all in > PriceServices.java and services_pricepromo.xml): > * Addition of additional context information "productStoreGroupId" and > "partyId" to the call parameters of a "customMethodName" price-calc-service > * Obtaining the fields discountRate and listPrice from calling a > "customMethodName" price-calc-service > * discountRate as Result Field > * Retaining the bypassing of the OFBiz Standard PriceRules based on the > presence of a ListPrice (only that it can now also come from the > "customMethodName", therefore slightly changed decision logic) > Extending ShoppingCart/Item, OrderItem Entity: > * Transport original discount rate from custom price calculation over cart > to order to have the correct rate instead of back-calculating it from > unitPrice and unitListPrice -- This message was sent by Atlassian Jira (v8.20.10#820010)
