[jira] [Closed] (OFBIZ-10785) Upgrade jquery-validation plugin from 1.17.0 to 1.19.0

2019-01-09 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-10785. - > Upgrade jquery-validation plugin from 1.17.0 to 1.19.0 >

[jira] [Resolved] (OFBIZ-10785) Upgrade jquery-validation plugin from 1.17.0 to 1.19.0

2019-01-09 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma resolved OFBIZ-10785. --- Resolution: Done Fix Version/s: 18.12.01 > Upgrade jquery-validation plugin from

[jira] [Comment Edited] (OFBIZ-10785) Upgrade jquery-validation plugin from 1.17.0 to 1.19.0

2019-01-09 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739104#comment-16739104 ] Aditya Sharma edited comment on OFBIZ-10785 at 1/10/19 6:17 AM: Changes

[jira] [Updated] (OFBIZ-10785) Upgrade jquery-validation plugin from 1.17.0 to 1.19.0

2019-01-09 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10785: -- Affects Version/s: Release Branch 18.12 > Upgrade jquery-validation plugin from 1.17.0 to

[jira] [Commented] (OFBIZ-10785) Upgrade jquery-validation plugin from 1.17.0 to 1.19.0

2019-01-09 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739104#comment-16739104 ] Aditya Sharma commented on OFBIZ-10785: --- Changes can also be backported to R18.12 Done for

[jira] [Commented] (OFBIZ-10785) Upgrade jquery-validation plugin from 1.17.0 to 1.19.0

2019-01-09 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739099#comment-16739099 ] Aditya Sharma commented on OFBIZ-10785: --- Done for trunk at r1850921. Converted file

[jira] [Created] (OFBIZ-10785) Upgrade jquery-validation plugin from 1.17.0 to 1.19.0

2019-01-09 Thread Aditya Sharma (JIRA)
Aditya Sharma created OFBIZ-10785: - Summary: Upgrade jquery-validation plugin from 1.17.0 to 1.19.0 Key: OFBIZ-10785 URL: https://issues.apache.org/jira/browse/OFBIZ-10785 Project: OFBiz

[jira] [Created] (OFBIZ-10782) Replace jQuery-Timepicker-Addon with flatpickr.js

2019-01-08 Thread Aditya Sharma (JIRA)
Aditya Sharma created OFBIZ-10782: - Summary: Replace jQuery-Timepicker-Addon with flatpickr.js Key: OFBIZ-10782 URL: https://issues.apache.org/jira/browse/OFBIZ-10782 Project: OFBiz Issue

[jira] [Resolved] (OFBIZ-10758) Replace jQuery.bind() with jQuery.on()

2019-01-07 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma resolved OFBIZ-10758. --- Resolution: Done Fix Version/s: 18.12.01 > Replace jQuery.bind() with jQuery.on() >

[jira] [Closed] (OFBIZ-10758) Replace jQuery.bind() with jQuery.on()

2019-01-07 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-10758. - > Replace jQuery.bind() with jQuery.on() > -- > >

[jira] [Commented] (OFBIZ-10758) Replace jQuery.bind() with jQuery.on()

2019-01-07 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736747#comment-16736747 ] Aditya Sharma commented on OFBIZ-10758: --- Found following plugins with instances: Fancybox jsTree

[jira] [Commented] (OFBIZ-10758) Replace jQuery.bind() with jQuery.on()

2019-01-07 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736745#comment-16736745 ] Aditya Sharma commented on OFBIZ-10758: --- Done for all instances in custom code for R18.12 at 

[jira] [Commented] (OFBIZ-10758) Replace jQuery.bind() with jQuery.on()

2019-01-07 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736735#comment-16736735 ] Aditya Sharma commented on OFBIZ-10758: --- Done for all instances in custom code for trunk at 

[jira] [Updated] (OFBIZ-10758) Replace jQuery.bind() with jQuery.on()

2019-01-07 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10758: -- Affects Version/s: Release Branch 18.12 > Replace jQuery.bind() with jQuery.on() >

[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods

2019-01-03 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732768#comment-16732768 ] Aditya Sharma commented on OFBIZ-10725: --- Done for all classes directly under

[jira] [Updated] (OFBIZ-10682) When using Select2 for multiple selects the field is too narrow in "no results" case

2019-01-01 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10682: -- Affects Version/s: Release Branch 18.12 > When using Select2 for multiple selects the field

[jira] [Closed] (OFBIZ-10682) When using Select2 for multiple selects the field is too narrow in "no results" case

2019-01-01 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-10682. - > When using Select2 for multiple selects the field is too narrow in "no > results" case >

[jira] [Commented] (OFBIZ-10682) When using Select2 for multiple selects the field is too narrow in "no results" case

2019-01-01 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731767#comment-16731767 ] Aditya Sharma commented on OFBIZ-10682: --- done for 18.12 at r1850149. > When using Select2 for

[jira] [Commented] (OFBIZ-10682) When using Select2 for multiple selects the field is too narrow in "no results" case

2019-01-01 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731765#comment-16731765 ] Aditya Sharma commented on OFBIZ-10682: --- Done for trunk at r1850148. Set width to 50% instead as

[jira] [Created] (OFBIZ-10759) Replace document.write() occurrences with some legitimate code

2018-12-31 Thread Aditya Sharma (JIRA)
Aditya Sharma created OFBIZ-10759: - Summary: Replace document.write() occurrences with some legitimate code Key: OFBIZ-10759 URL: https://issues.apache.org/jira/browse/OFBIZ-10759 Project: OFBiz

[jira] [Created] (OFBIZ-10758) Replace jQuery.bind() with jQuery.on()

2018-12-31 Thread Aditya Sharma (JIRA)
Aditya Sharma created OFBIZ-10758: - Summary: Replace jQuery.bind() with jQuery.on() Key: OFBIZ-10758 URL: https://issues.apache.org/jira/browse/OFBIZ-10758 Project: OFBiz Issue Type:

[jira] [Closed] (OFBIZ-10728) Refactor boolean returns for UtilValidate methods

2018-12-31 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-10728. - > Refactor boolean returns for UtilValidate methods >

[jira] [Commented] (OFBIZ-10728) Refactor boolean returns for UtilValidate methods

2018-12-31 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731314#comment-16731314 ] Aditya Sharma commented on OFBIZ-10728: --- done for trunk at r1850043. > Refactor boolean returns

[jira] [Comment Edited] (OFBIZ-10728) Refactor boolean returns for UtilValidate methods

2018-12-31 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731314#comment-16731314 ] Aditya Sharma edited comment on OFBIZ-10728 at 12/31/18 12:58 PM: -- done

[jira] [Commented] (OFBIZ-10682) When using Select2 for multiple selects the field is too narrow in "no results" case

2018-12-31 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731236#comment-16731236 ] Aditya Sharma commented on OFBIZ-10682: --- Added solution patch. We can fix a specific width for 

[jira] [Updated] (OFBIZ-10682) When using Select2 for multiple selects the field is too narrow in "no results" case

2018-12-31 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10682: -- Attachment: OFBIZ-10682.patch > When using Select2 for multiple selects the field is too

[jira] [Assigned] (OFBIZ-10682) When using Select2 for multiple selects the field is too narrow in "no results" case

2018-12-31 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reassigned OFBIZ-10682: - Assignee: Aditya Sharma > When using Select2 for multiple selects the field is too

[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods

2018-12-28 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730268#comment-16730268 ] Aditya Sharma commented on OFBIZ-10725: --- Done for all classes under

[jira] [Closed] (OFBIZ-10732) Refactor boolean returns for TemporalExpression methods

2018-12-26 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-10732. - No more instances, hence closing. > Refactor boolean returns for TemporalExpression methods >

[jira] [Commented] (OFBIZ-10732) Refactor boolean returns for TemporalExpression methods

2018-12-26 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728932#comment-16728932 ] Aditya Sharma commented on OFBIZ-10732: --- done for trunk at R1849742. > Refactor boolean returns

[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods

2018-12-26 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728930#comment-16728930 ] Aditya Sharma commented on OFBIZ-10725: --- Improves code in methods: isPrimaryKey() of GenericEntity

[jira] [Closed] (OFBIZ-10726) Refactor boolean returns for UtilHttp methods

2018-12-25 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-10726. - > Refactor boolean returns for UtilHttp methods > -- >

[jira] [Commented] (OFBIZ-10726) Refactor boolean returns for UtilHttp methods

2018-12-25 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728878#comment-16728878 ] Aditya Sharma commented on OFBIZ-10726: --- Done for trunk at R1849738. No more instances. >

[jira] [Closed] (OFBIZ-10745) Refactor boolean returns for ShoppingCart methods

2018-12-24 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-10745. - > Refactor boolean returns for ShoppingCart methods >

[jira] [Commented] (OFBIZ-10745) Refactor boolean returns for ShoppingCart methods

2018-12-24 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728398#comment-16728398 ] Aditya Sharma commented on OFBIZ-10745: --- Improves code in isPaymentMethodType() and

[jira] [Commented] (OFBIZ-10745) Refactor boolean returns for ShoppingCart methods

2018-12-24 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728325#comment-16728325 ] Aditya Sharma commented on OFBIZ-10745: --- Makes Sense [~jacques.le.roux]. Thanks for sharing :)  >

[jira] [Commented] (OFBIZ-10726) Refactor boolean returns for UtilHttp methods

2018-12-24 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728318#comment-16728318 ] Aditya Sharma commented on OFBIZ-10726: --- Added a patch that improves code in

[jira] [Updated] (OFBIZ-10726) Refactor boolean returns for UtilHttp methods

2018-12-24 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10726: -- Attachment: OFBIZ-10726.patch > Refactor boolean returns for UtilHttp methods >

[jira] [Commented] (OFBIZ-10726) Refactor boolean returns for UtilHttp methods

2018-12-24 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728269#comment-16728269 ] Aditya Sharma commented on OFBIZ-10726: --- Done for trunk at R1849675 > Refactor boolean returns

[jira] [Commented] (OFBIZ-10728) Refactor boolean returns for UtilValidate methods

2018-12-24 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728222#comment-16728222 ] Aditya Sharma commented on OFBIZ-10728: --- Added a patch that improves code in isTime(). > Refactor

[jira] [Commented] (OFBIZ-10728) Refactor boolean returns for UtilValidate methods

2018-12-23 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728218#comment-16728218 ] Aditya Sharma commented on OFBIZ-10728: --- Committed for trunk at R1849673. Thanks Suraj Khurana

[jira] [Updated] (OFBIZ-10728) Refactor boolean returns for UtilValidate methods

2018-12-23 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10728: -- Attachment: OFBIZ-10728.patch > Refactor boolean returns for UtilValidate methods >

[jira] [Commented] (OFBIZ-10745) Refactor boolean returns for ShoppingCart methods

2018-12-23 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728213#comment-16728213 ] Aditya Sharma commented on OFBIZ-10745: --- Added a new patch that improves code in

[jira] [Updated] (OFBIZ-10745) Refactor boolean returns for ShoppingCart methods

2018-12-23 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10745: -- Attachment: OFBIZ-10745.patch > Refactor boolean returns for ShoppingCart methods >

[jira] [Commented] (OFBIZ-10745) Refactor boolean returns for ShoppingCart methods

2018-12-23 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728196#comment-16728196 ] Aditya Sharma commented on OFBIZ-10745: --- Done for trunk at R1849672. Thanks Suraj Khurana and

[jira] [Closed] (OFBIZ-10721) Remove all the fk dependencies from stats entities to the business entities

2018-12-22 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-10721. - > Remove all the fk dependencies from stats entities to the business entities >

[jira] [Commented] (OFBIZ-10721) Remove all the fk dependencies from stats entities to the business entities

2018-12-22 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727362#comment-16727362 ] Aditya Sharma commented on OFBIZ-10721: --- Done for R16.11 at  r1849541. Thanks Jacques Le Roux and

[jira] [Commented] (OFBIZ-9089) Unit test case for service - createProductFeatureType

2018-12-22 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727359#comment-16727359 ] Aditya Sharma commented on OFBIZ-9089: -- Thanks [~yogesh.naroliya] for the patch. I will commit soon.

[jira] [Assigned] (OFBIZ-9089) Unit test case for service - createProductFeatureType

2018-12-22 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reassigned OFBIZ-9089: Assignee: Aditya Sharma (was: Yogesh Naroliya) > Unit test case for service -

[jira] [Commented] (OFBIZ-10745) Refactor boolean returns for ShoppingCart methods

2018-12-22 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727351#comment-16727351 ] Aditya Sharma commented on OFBIZ-10745: --- Added a patch that improves code in isPinRequiredForGC().

[jira] [Updated] (OFBIZ-10745) Refactor boolean returns for ShoppingCart methods

2018-12-22 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10745: -- Attachment: OFBIZ-10745.patch > Refactor boolean returns for ShoppingCart methods >

[jira] [Created] (OFBIZ-10745) Refactor boolean returns for ShoppingCart methods

2018-12-22 Thread Aditya Sharma (JIRA)
Aditya Sharma created OFBIZ-10745: - Summary: Refactor boolean returns for ShoppingCart methods Key: OFBIZ-10745 URL: https://issues.apache.org/jira/browse/OFBIZ-10745 Project: OFBiz Issue

[jira] [Updated] (OFBIZ-9089) Unit test case for service - createProductFeatureType

2018-12-22 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-9089: - Fix Version/s: (was: 17.12.01) > Unit test case for service - createProductFeatureType >

[jira] [Closed] (OFBIZ-10724) Refactor ServiceUtil.isSuccess(), isError() and isFailure() methods

2018-12-22 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-10724. - > Refactor ServiceUtil.isSuccess(), isError() and isFailure() methods >

[jira] [Updated] (OFBIZ-10721) Remove all the fk dependencies from stats entities to the business entities

2018-12-22 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10721: -- Fix Version/s: (was: Upcoming Branch) > Remove all the fk dependencies from stats

[jira] [Reopened] (OFBIZ-10721) Remove all the fk dependencies from stats entities to the business entities

2018-12-22 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reopened OFBIZ-10721: --- My bad, closed by mistake I was updating OFBIZ-10724. > Remove all the fk dependencies from

[jira] [Closed] (OFBIZ-10721) Remove all the fk dependencies from stats entities to the business entities

2018-12-22 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-10721. - > Remove all the fk dependencies from stats entities to the business entities >

[jira] [Commented] (OFBIZ-10724) Refactor ServiceUtil.isSuccess(), isError() and isFailure() methods

2018-12-22 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727342#comment-16727342 ] Aditya Sharma commented on OFBIZ-10724: --- Done for trunk at r1849536. > Refactor

[jira] [Commented] (OFBIZ-9089) Unit test case for service - createProductFeatureType

2018-12-22 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727301#comment-16727301 ] Aditya Sharma commented on OFBIZ-9089: -- Looks good to me. Thanks Yogesh :)  Just a suggestion, as

[jira] [Created] (OFBIZ-10732) Refactor boolean returns for TemporalExpression methods

2018-12-21 Thread Aditya Sharma (JIRA)
Aditya Sharma created OFBIZ-10732: - Summary: Refactor boolean returns for TemporalExpression methods Key: OFBIZ-10732 URL: https://issues.apache.org/jira/browse/OFBIZ-10732 Project: OFBiz

[jira] [Commented] (OFBIZ-10732) Refactor boolean returns for TemporalExpression methods

2018-12-21 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727256#comment-16727256 ] Aditya Sharma commented on OFBIZ-10732: --- Added a patch that improves code in includesDate(). I

[jira] [Updated] (OFBIZ-10732) Refactor boolean returns for TemporalExpression methods

2018-12-21 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10732: -- Attachment: OFBIZ-10732.patch > Refactor boolean returns for TemporalExpression methods >

[jira] [Comment Edited] (OFBIZ-10728) Refactor boolean returns for UtilValidate methods

2018-12-21 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727243#comment-16727243 ] Aditya Sharma edited comment on OFBIZ-10728 at 12/22/18 6:06 AM: - Added

[jira] [Commented] (OFBIZ-10728) Refactor boolean returns for UtilValidate methods

2018-12-21 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727243#comment-16727243 ] Aditya Sharma commented on OFBIZ-10728: --- Added a patch that improves code in isGiftCard(). I will

[jira] [Updated] (OFBIZ-10728) Refactor boolean returns for UtilValidate methods

2018-12-21 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10728: -- Attachment: OFBIZ-10728.patch > Refactor boolean returns for UtilValidate methods >

[jira] [Created] (OFBIZ-10728) Refactor boolean returns for UtilValidate methods

2018-12-21 Thread Aditya Sharma (JIRA)
Aditya Sharma created OFBIZ-10728: - Summary: Refactor boolean returns for UtilValidate methods Key: OFBIZ-10728 URL: https://issues.apache.org/jira/browse/OFBIZ-10728 Project: OFBiz Issue

[jira] [Closed] (OFBIZ-9746) updateContentAssoc does not return success/error message to the UI.

2018-12-21 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-9746. > updateContentAssoc does not return success/error message to the UI. >

[jira] [Commented] (OFBIZ-10721) Remove all the fk dependencies from stats entities to the business entities

2018-12-21 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727235#comment-16727235 ] Aditya Sharma commented on OFBIZ-10721: --- Thanks Deepak for the info :). I will keep that in mind.

[jira] [Resolved] (OFBIZ-9746) updateContentAssoc does not return success/error message to the UI.

2018-12-21 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma resolved OFBIZ-9746. -- Resolution: Fixed Fix Version/s: 16.11.06 > updateContentAssoc does not return

[jira] [Commented] (OFBIZ-9746) updateContentAssoc does not return success/error message to the UI.

2018-12-21 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727225#comment-16727225 ] Aditya Sharma commented on OFBIZ-9746: -- This has been fixed for R16.11 at R1849517. Thanks Rohit

[jira] [Commented] (OFBIZ-10726) Refactor boolean returns for UtilHttp methods

2018-12-21 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726663#comment-16726663 ] Aditya Sharma commented on OFBIZ-10726: --- Added a patch that improves code in checkURLforSpiders().

[jira] [Updated] (OFBIZ-10726) Refactor boolean returns for UtilHttp methods

2018-12-21 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10726: -- Attachment: OFBIZ-10726.patch > Refactor boolean returns for UtilHttp methods >

[jira] [Updated] (OFBIZ-10724) Refactor ServiceUtil.isSuccess(), isError() and isFailure() methods

2018-12-21 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10724: -- Issue Type: Sub-task (was: Improvement) Parent: OFBIZ-10725 > Refactor

[jira] [Created] (OFBIZ-10726) Refactor boolean returns for UtilHttp methods

2018-12-21 Thread Aditya Sharma (JIRA)
Aditya Sharma created OFBIZ-10726: - Summary: Refactor boolean returns for UtilHttp methods Key: OFBIZ-10726 URL: https://issues.apache.org/jira/browse/OFBIZ-10726 Project: OFBiz Issue Type:

[jira] [Updated] (OFBIZ-10724) Refactor ServiceUtil.isSuccess(), isError() and isFailure() methods

2018-12-21 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10724: -- Description: Following lines for isSuccess(): {code:java} if (ServiceUtil.isError(results) ||

[jira] [Commented] (OFBIZ-10724) Refactor ServiceUtil.isSuccess(), isError() and isFailure() methods

2018-12-21 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726635#comment-16726635 ] Aditya Sharma commented on OFBIZ-10724: --- Updated the patch with instances of ServiceUtil methods.

[jira] [Updated] (OFBIZ-10724) Refactor ServiceUtil.isSuccess(), isError() and isFailure() methods

2018-12-21 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10724: -- Attachment: OFBIZ-10724.patch > Refactor ServiceUtil.isSuccess(), isError() and isFailure()

[jira] [Commented] (OFBIZ-10724) Refactor ServiceUtil.isSuccess() method

2018-12-20 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726461#comment-16726461 ] Aditya Sharma commented on OFBIZ-10724: --- Indeed.  I will commit in a day if no conflicts. Thanks

[jira] [Commented] (OFBIZ-1463) JUnit test case for various application components

2018-12-20 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725776#comment-16725776 ] Aditya Sharma commented on OFBIZ-1463: -- Makes sense Michael. IMO we can close these tickets with

[jira] [Updated] (OFBIZ-10724) Refactor ServiceUtil.isSuccess() method

2018-12-20 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10724: -- Attachment: OFBIZ-10724.patch > Refactor ServiceUtil.isSuccess() method >

[jira] [Created] (OFBIZ-10724) Refactor ServiceUtil.isSuccess() method

2018-12-20 Thread Aditya Sharma (JIRA)
Aditya Sharma created OFBIZ-10724: - Summary: Refactor ServiceUtil.isSuccess() method Key: OFBIZ-10724 URL: https://issues.apache.org/jira/browse/OFBIZ-10724 Project: OFBiz Issue Type:

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

2018-12-19 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724898#comment-16724898 ] Aditya Sharma commented on OFBIZ-10645: --- Thanks [~mthl] :) I will test with your changes and

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

2018-12-19 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724878#comment-16724878 ] Aditya Sharma commented on OFBIZ-10645: --- I will commit in a day if no conflicts. > Empty entity

[jira] [Commented] (OFBIZ-10721) Remove all the fk dependencies from stats entities to the business entities

2018-12-19 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724875#comment-16724875 ] Aditya Sharma commented on OFBIZ-10721: --- Done for R17.12 at r1849288. > Remove all the fk

[jira] [Updated] (OFBIZ-10721) Remove all the fk dependencies from stats entities to the business entities

2018-12-19 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10721: -- Affects Version/s: Release Branch 17.12 Release Branch 16.11 > Remove

[jira] [Updated] (OFBIZ-10721) Remove all the fk dependencies from stats entities to the business entities

2018-12-19 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10721: -- Fix Version/s: 17.12.01 > Remove all the fk dependencies from stats entities to the business

[jira] [Commented] (OFBIZ-10721) Remove all the fk dependencies from stats entities to the business entities

2018-12-19 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724808#comment-16724808 ] Aditya Sharma commented on OFBIZ-10721: --- Done for trunk at r1849275. Started a discussion on the

[jira] [Commented] (OFBIZ-10721) Remove all the fk dependencies from stats entities to the business entities

2018-12-18 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724708#comment-16724708 ] Aditya Sharma commented on OFBIZ-10721: --- Thanks [~deepak.dixit] for the review :) Changes that

[jira] [Commented] (OFBIZ-10721) Remove all the fk dependencies from stats entities to the business entities

2018-12-18 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724018#comment-16724018 ] Aditya Sharma commented on OFBIZ-10721: --- Thanks [~jacques.le.roux] for the review  :) I will

[jira] [Commented] (OFBIZ-10721) Remove all the fk dependencies from stats entities to the business entities

2018-12-17 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723705#comment-16723705 ] Aditya Sharma commented on OFBIZ-10721: --- Attached a patch. Removed relations of Party, ContactMech

[jira] [Created] (OFBIZ-10721) Remove all the fk dependencies from stats entities to the business entities

2018-12-17 Thread Aditya Sharma (JIRA)
Aditya Sharma created OFBIZ-10721: - Summary: Remove all the fk dependencies from stats entities to the business entities Key: OFBIZ-10721 URL: https://issues.apache.org/jira/browse/OFBIZ-10721

[jira] [Updated] (OFBIZ-10721) Remove all the fk dependencies from stats entities to the business entities

2018-12-17 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10721: -- Attachment: OFBIZ-10721.patch > Remove all the fk dependencies from stats entities to the

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

2018-12-17 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722984#comment-16722984 ] Aditya Sharma commented on OFBIZ-10645: --- Thanks [~jacques.le.roux] for the review :)  > Empty

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

2018-12-16 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722710#comment-16722710 ] Aditya Sharma commented on OFBIZ-10645: --- Hi [~jacques.le.roux] [~mthl] , I have updated the patch.

[jira] [Updated] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

2018-12-16 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10645: -- Attachment: OFBIZ-10645.patch > Empty entity name should not be allowed in entity definition

[jira] [Commented] (OFBIZ-9603) EntityListIterator Not Closed for Entity [PartyRoleAndContactMechDetail], caught in Finalize

2018-12-16 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722677#comment-16722677 ] Aditya Sharma commented on OFBIZ-9603: -- Thanks for the details [~jacques.le.roux] :) >

[jira] [Commented] (OFBIZ-9743) updateContent service does not return an error/success message

2018-12-16 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722681#comment-16722681 ] Aditya Sharma commented on OFBIZ-9743: -- Indeed. With OFBIZ-10625 being done we can close it. >

[jira] [Closed] (OFBIZ-9743) updateContent service does not return an error/success message

2018-12-16 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-9743. > updateContent service does not return an error/success message >

[jira] [Resolved] (OFBIZ-9743) updateContent service does not return an error/success message

2018-12-16 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma resolved OFBIZ-9743. -- Resolution: Fixed > updateContent service does not return an error/success message >

[jira] [Commented] (OFBIZ-10625) Convert updateContent and removeContent service to entity-auto

2018-12-16 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722676#comment-16722676 ] Aditya Sharma commented on OFBIZ-10625: --- Thanks Deepak :)  > Convert updateContent and

<    1   2   3   4   5   6   7   8   9   10   >