[jira] [Commented] (OFBIZ-6899) Overview of payment methods in party profile misses function to set company check payment

2016-09-03 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15460745#comment-15460745
 ] 

Jacques Le Roux commented on OFBIZ-6899:


Thanks Jagpreet, I indeed missed the OFBIZ-7377 reference. I'm adding relations 
from here, even if it's closed

> Overview of payment methods in party profile misses function to set company 
> check payment
> -
>
> Key: OFBIZ-6899
> URL: https://issues.apache.org/jira/browse/OFBIZ-6899
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting, order, party, specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Swapnil Shah
>  Labels: check, payment
> Fix For: Upcoming Branch
>
> Attachments: CC_1.png, CC_2.png, CC_3.png, CC_4.png, 
> OFBIZ-6899.patch, OFBIZ-6899.patch, OFBIZ-6899.patch
>
>
> The payment methods overview in the party profile shows various options to 
> define and create a payment method.
> However there is no option to create payment method for a company check



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8044) Consistent form name

2016-09-01 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455701#comment-15455701
 ] 

Jacques Le Roux commented on OFBIZ-8044:


Ouch! Too much things to open to review, I'll review the commits :)

> Consistent form name
> 
>
> Key: OFBIZ-8044
> URL: https://issues.apache.org/jira/browse/OFBIZ-8044
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Tanmay Muley
> Fix For: Trunk
>
>
> form-name should be in upper camel case as per best practice. There are few 
> places where form-names are in lower camel case. Need to fix these form-names 
> to maintain consistency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8109) Maximise the utilisation of the Label CommonType in various framework forms

2016-09-01 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455710#comment-15455710
 ] 

Jacques Le Roux commented on OFBIZ-8109:


I'm not sure about this one, for instance CommonGeoTypeId says more than 
CommonType

> Maximise the utilisation of the Label CommonType in various framework forms
> ---
>
> Key: OFBIZ-8109
> URL: https://issues.apache.org/jira/browse/OFBIZ-8109
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>  Labels: labels
> Attachments: OFBIZ-8109-framework-forms.patch
>
>
> Various forms in component(s) the framework stack use a TypeId variant. This 
> issue is about applying the CommonLabel label where it is possible in these 
> forms.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-7783) External library files are not in the OFBiz folder structure.

2016-08-30 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432332#comment-15432332
 ] 

Jacques Le Roux edited comment on OFBIZ-7783 at 8/30/16 9:16 PM:
-

Thanks Taher,

Before we discuss this more on the dev ML, just some points: 
# archiving the Gradle cache is not enough, because you can have not only OFBiz 
related libs in it, for instance on a dev machine
* which use Eclipse: Eclipse libs
* if Gradle is also used for other projects, unrelated OFBiz libs
* etc.
That's why I have decided to have a task like that (initially for OWASP)
# Using plugins is certainly more appealing, but
* I don't feel an issue to use jQuery plugins because it's just UI and if the 
plugin is not longer maintained we can still find solutions. Relying on 
external plugins for our build process is another matter. 
* I must say I just had a glance to the gradle-repositories-plugin but I wonder 
how it works, because on GitHub you get a zip with jar inside...

Now I have identified another reasons we migh need to extract and copy the 
external libs we use: if we decide to deliver binary releases. It's not 
mandatory but most TLPs do that. It can of course be done by a 3rd party and 
then it's another issue... This is in a relation with 
http://markmail.org/message/emnu6s5wu2yuyith


was (Author: jacques.le.roux):
Thanks Taher,

Before we discuss this more on the dev ML, just some points: 
# archiving the Gradle cache is not enough, because you can have not OFBiz 
related libs in it, for instance on a dev machine
* which use Eclipse: Eclipse libs
* if Gradle is also used for other projects, unrelated OFBiz libs
* etc.
That's why I have decided to have a task like that (initially for OWASP)
# Using plugins is certainly more appealing, but
* I don't feel an issue to use jQuery plugins because it's just UI and if the 
plugin is not longer maintained we can still find solutions. Relying on 
external plugins for our build process is another matter. 
* I must say I just had a glance to the gradle-repositories-plugin but I wonder 
how it works, because on GitHub you get a zip with jar inside...

Now I have identified another reasons we migh need to extract and copy the 
external libs we use: if we decide to deliver binary releases. It's not 
mandatory but most TLPs do that. It can of course be done by a 3rd party and 
then it's another issue... This is in a relation with 
http://markmail.org/message/emnu6s5wu2yuyith

> External library files are not in the OFBiz folder structure.
> -
>
> Key: OFBIZ-7783
> URL: https://issues.apache.org/jira/browse/OFBIZ-7783
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Pierre Smits
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> With the implementation of the external library download feature of 
> gradle/gradlew, the external libraries (jar files) are not in the folder 
> structure any more. 
> They should reside there, like before.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-2614) Problem in proceeding in Shark workflow in Ofbiz

2016-08-31 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-2614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15451332#comment-15451332
 ] 

Jacques Le Roux commented on OFBIZ-2614:


I'm very sorry to say that Adrian has passed on.

You will not find a way to use workflow in recent OFBiz version. But you might 
be interested by GrowErp (based on OFBiz) which uses Activiti (disclaimer I did 
not try it myself, just read about it).

> Problem in proceeding in Shark workflow in Ofbiz
> 
>
> Key: OFBIZ-2614
> URL: https://issues.apache.org/jira/browse/OFBIZ-2614
> Project: OFBiz
>  Issue Type: Wish
>  Components: Attic
>Affects Versions: Trunk
> Environment: Windows Xp
>Reporter: Pradeep Ruhil
> Fix For: Trunk
>
> Attachments: Fig A.JPG, Fig B.JPG, Fig C.JPG, Fig D.JPG
>
>
> Hi, 
> I am  working on Shark in OFBiz. I  have read all of the previous replies on 
> nabble mailing list regarding shark workflow , 
> but in any of the mails I didn't get a clear picture how can I use shark 
> workflow , as i want to use it 
> instead of ECAs and EDAs in OFBiz. 
> I have enabled the Shark Component. After enabling it I am able to see the 
> Shark Framework with three links: 
> 1.  XPDL Repositroy 
> 2.  Process List 
> 3.  WorkFlow List 
> I m attaching the screenshots for that which is(Fig A) 
> After that I clicked on XPDL Repository and Uploaded a ofbiz_test.xpdl and 
> succesfully completed that 
> (Fig B). 
> Now when i click on Process List link on the main page  i am able to see the 
> two workflow process defined in 
> the ofbiz_test.xpdl as shown in (Fig C) 
> And on clicking the workflow List link in didn't get anything there.(Fig D) 
> Now my problem is how to proceed further to implement workflow in OFBiz ? 
> Any help in this will be highly appreciated. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7930) Load the OWASP dependency checker Gradle plugin efficiently

2016-08-30 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448908#comment-15448908
 ] 

Jacques Le Roux commented on OFBIZ-7930:


Thanks Taher, much appreciated.

# 
https://github.com/jeremylong/dependency-check-gradle#what-if-my-project-includes-multiple-sub-project-how-can-i-use-this-plugin-for-each-of-them-including-the-root-project
# The purpose is two-fold. 
## To inform our users about possible vulnerabilities in our external 
dependencies
## To fix them as much as possible before exposing them to public
Committers are more concerned, but everybody can help
# I put it here 
https://cwiki.apache.org/confluence/display/OFBIZ/About+OWASP+Dependency+Check 
It's actually reports from versions in the svn repo
I want to have a report for each releases and even for each supported branches, 
including trunk of course. 
Once you have the report it's nice to publish it. But before it should be uised 
to fix possible vulnerabilities in our external dependencies. 
Note that the suppress file is needed because OWASP-DC report a lot of false 
positive initially. AFAIK there is no other such free tools.

> Load the OWASP dependency checker Gradle plugin efficiently
> ---
>
> Key: OFBIZ-7930
> URL: https://issues.apache.org/jira/browse/OFBIZ-7930
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> As I warned at 
> https://cwiki.apache.org/confluence/display/OFBIZ/About+OWASP+Dependency+Check
>  it's currently difficult to separate the OFBiz jars from other jars in the 
> .gradle\caches contains which may contain jars unrelated to OFBiz. Notably 
> Eclipse jars if you use the Gradle Eclipse task and more if you use Gradle 
> for other reasons than OFBiz.
> I did not find yet a way to avoid to have all external jars in .gradle\caches 
> and I wonder if it's even possible. What I would like to have is the external 
> jars mandatory for OFBiz to work in an isolated place. For instance a sub 
> folder of the main Gradle build folder. I picked $buildDir/externalJars.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7959) Enable the status selection for WorkEffort duplication

2016-08-31 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15451841#comment-15451841
 ] 

Jacques Le Roux commented on OFBIZ-7959:


Hi Florian,

I suggest this in EditWorkEffortDup
{code}
[... ]

[... ]

[... ]
{code}
The user can still force the Id to the value he wants, we just suggest the next 
possible automated Id

> Enable the status selection for WorkEffort duplication
> --
>
> Key: OFBIZ-7959
> URL: https://issues.apache.org/jira/browse/OFBIZ-7959
> Project: OFBiz
>  Issue Type: Improvement
>  Components: workeffort
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>Assignee: Nicolas Malin
>Priority: Minor
>  Labels: duplicate, status, workeffort
> Attachments: OFBIZ-7959.patch, OFBIZ-7959.patch
>
>
> It is possible to duplicate workeffort in the WorkEffort component 
> (https://localhost:8443/workeffort/control/EditWorkEffort?workEffortId=9000) 
> but the duplicated WorkEffort keeps the same status than the original one. So 
> when you duplicate a cancelled task, it is locked in the same state.
> We could adapt this service to allow the selection of the status for the new 
> workeffort. Of course, you should be able to select only status that are 
> relevant to the workeffort type. 
> A first solution is to get the currentStatusId of the workeffort to 
> duplicate. Then we can access to the linked statusTypeId. So we can retrieve 
> all status relevant and order them by sequenceId (that way the default value 
> is the first statuts of the sequence : created for the task).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7783) External library files are not in the OFBiz folder structure.

2016-08-30 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-7783:
--

Assignee: (was: Jacques Le Roux)

> External library files are not in the OFBiz folder structure.
> -
>
> Key: OFBIZ-7783
> URL: https://issues.apache.org/jira/browse/OFBIZ-7783
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Pierre Smits
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> With the implementation of the external library download feature of 
> gradle/gradlew, the external libraries (jar files) are not in the folder 
> structure any more. 
> They should reside there, like before.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7959) Enable the status selection for WorkEffort duplication

2016-08-31 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15452194#comment-15452194
 ] 

Jacques Le Roux commented on OFBIZ-7959:


I can answer to both of you at the same time. Yes, it's not a problem the only 
thing it does is indeed increasing the sequence id and, apart if you have 
constraint on serialised (not discontinued) workEffortIds, that should not be a 
problem. I mean in case you like to play with the F5 touch ;).

BTW sequenced-id-prefix element in minilang does the same but indeed in a 
transaction. So If we want to be totally secure it should be better in a 
service. This to avoid possible already used (in the meantime) workEffortIds, 
hence an entity creation rejection. But let's face it, you can put what you 
want there anyway. So I don't see that as a big deal, only a convenient way for 
users, if it fails try a new one, this can happen anyway...

> Enable the status selection for WorkEffort duplication
> --
>
> Key: OFBIZ-7959
> URL: https://issues.apache.org/jira/browse/OFBIZ-7959
> Project: OFBiz
>  Issue Type: Improvement
>  Components: workeffort
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>Assignee: Nicolas Malin
>Priority: Minor
>  Labels: duplicate, status, workeffort
> Attachments: OFBIZ-7959.patch, OFBIZ-7959.patch, OFBIZ-7959.patch
>
>
> It is possible to duplicate workeffort in the WorkEffort component 
> (https://localhost:8443/workeffort/control/EditWorkEffort?workEffortId=9000) 
> but the duplicated WorkEffort keeps the same status than the original one. So 
> when you duplicate a cancelled task, it is locked in the same state.
> We could adapt this service to allow the selection of the status for the new 
> workeffort. Of course, you should be able to select only status that are 
> relevant to the workeffort type. 
> A first solution is to get the currentStatusId of the workeffort to 
> duplicate. Then we can access to the linked statusTypeId. So we can retrieve 
> all status relevant and order them by sequenceId (that way the default value 
> is the first statuts of the sequence : created for the task).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6720) Rewrite multi-tenant support page in wiki

2016-09-08 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474566#comment-15474566
 ] 

Jacques Le Roux commented on OFBIZ-6720:


I still have this in my notes...

> Rewrite multi-tenant support page in wiki
> -
>
> Key: OFBIZ-6720
> URL: https://issues.apache.org/jira/browse/OFBIZ-6720
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>  Labels: multi-tenant
>
> See https://cwiki.apache.org/confluence/display/OFBIZ/Multitenancy+support



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8203) Attribute 'value-field' must appear on element 'entity-one'

2016-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477018#comment-15477018
 ] 

Jacques Le Roux commented on OFBIZ-8203:


bq.  but the result is put directly in the context map
You mean as you suggested above with the entity name, Capitalised?

> Attribute 'value-field' must appear on element 'entity-one'
> ---
>
> Key: OFBIZ-8203
> URL: https://issues.apache.org/jira/browse/OFBIZ-8203
> Project: OFBiz
>  Issue Type: Bug
>  Components: content, humanres
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>
> I have found 4 such issues:
> {code}
> XmlFileLoader: File 
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/content/ContentForms.xml
>  process error. Line: 235. Error message: cvc-complex-type.4: Attribute 
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File 
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/contentsetup/ContentSetupForms.xml
>  process error. Line: 217. Error message: cvc-complex-type.4: Attribute 
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File 
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/EmploymentAppForms.xml
>  process error. Line: 27. Error message: cvc-complex-type.4: Attribute 
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File 
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/PayGradeForms.xml
>  process error. Line: 65. Error message: cvc-complex-type.4: Attribute 
> 'value-field' must appear on element 'entity-one'.h
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-8231) Display of State/Province for non US entities in the customer's profile of ecommerce

2016-09-11 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-8231:
--

Assignee: Jacques Le Roux

> Display of State/Province for non US entities in the customer's profile of 
> ecommerce 
> -
>
> Key: OFBIZ-8231
> URL: https://issues.apache.org/jira/browse/OFBIZ-8231
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: fumiyoshi.to
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: 
> OFBIZ-8231_DisplayOfStateProvinceInCustomerProfile.patch, screenshot-1.png, 
> screenshot-2.png
>
>
> When I access url [https://localhost:8443/ecommerce/control/viewprofile}
> for my profile, State/Province display in addresses shows the geo-id, which 
> is fine for US entities where the GeoID is the state code, but for non-us 
> entities, the GeoID is offen something like CountryCode-StateCode, which 
> isn't very nice.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8118) Consistent menu names

2016-09-12 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483877#comment-15483877
 ] 

Jacques Le Roux commented on OFBIZ-8118:


I have not already spotted more issues in the commit and I hope those who 
worked on it will check, sorry if I was not clear enough.

> Consistent menu names
> -
>
> Key: OFBIZ-8118
> URL: https://issues.apache.org/jira/browse/OFBIZ-8118
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Tanmay Muley
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Menu-name should be in upper camel case as per best practice. There are few 
> places where menu-names are in lower camel case. Need to fix these to 
> maintain consistency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (OFBIZ-8118) Consistent menu names

2016-09-12 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-8118:


At r1760325 I fixed a bug introduced with one of the subtasks.

It's possible that there are more bugs like that (in screenlet, elsewere?) I 
did not check, I reopen for that, thanks!

> Consistent menu names
> -
>
> Key: OFBIZ-8118
> URL: https://issues.apache.org/jira/browse/OFBIZ-8118
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Tanmay Muley
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Menu-name should be in upper camel case as per best practice. There are few 
> places where menu-names are in lower camel case. Need to fix these to 
> maintain consistency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8118) Consistent menu names

2016-09-12 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483801#comment-15483801
 ] 

Jacques Le Roux commented on OFBIZ-8118:


It's our responsibility to fix bugs, I was fixing one when I stumbled upon the 
one I fixed at r1760325 
and I'm still working on the other !https://i.imgur.com/t0XHtgJ.gif!.

My priority at the moment is to fix the other bug not to create a new Jira. 
Feel free to create one or to close this one again and wait for a proof there 
were issues in r1760059.

> Consistent menu names
> -
>
> Key: OFBIZ-8118
> URL: https://issues.apache.org/jira/browse/OFBIZ-8118
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Tanmay Muley
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Menu-name should be in upper camel case as per best practice. There are few 
> places where menu-names are in lower camel case. Need to fix these to 
> maintain consistency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8118) Consistent menu names

2016-09-12 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484163#comment-15484163
 ] 

Jacques Le Roux commented on OFBIZ-8118:


Thanks Tanmay, so I think we can close again now, right?

> Consistent menu names
> -
>
> Key: OFBIZ-8118
> URL: https://issues.apache.org/jira/browse/OFBIZ-8118
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Tanmay Muley
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Menu-name should be in upper camel case as per best practice. There are few 
> places where menu-names are in lower camel case. Need to fix these to 
> maintain consistency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8179) Enhance DBCPConnectionFactory to implement a TransactionFactory and remove the geronimo component

2016-09-12 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484423#comment-15484423
 ] 

Jacques Le Roux commented on OFBIZ-8179:


Thanks Scott and Jacopo, this is the better compromise indeed.

> Enhance DBCPConnectionFactory to implement a TransactionFactory and remove 
> the geronimo component
> -
>
> Key: OFBIZ-8179
> URL: https://issues.apache.org/jira/browse/OFBIZ-8179
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacopo Cappellato
>Assignee: Jacopo Cappellato
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8179.patch, 
> TransactionConnectionFactory-before-after.png
>
>
> Made the DBCPConnectionFactory an implementation of TransactionFactory by 
> moving the code from the GeronimoTransactionFactory.
> With this change the geronimo component is no more required.
> Without any functional change, this design simplifies greatly the calls and 
> component dependencies because it removes a cyclic dependency between entity 
> and geronimo components (see diagram attached that explain the architecture 
> before and after this change).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8154) The entity description labels are considered not used by the Label Manager

2016-09-13 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15488186#comment-15488186
 ] 

Jacques Le Roux commented on OFBIZ-8154:


Current situation, still to check
{quote}
FormFieldTitle_???
FieldDescription.ProductStore.???
FieldDescription.ProdCatalog.???
HumanResServices.???
.portalPageName.???
ProductShipmentUomAbbreviation_???
ProductStoreGroup.productStoreGroupName.NA???
TemporalExpression_???

After WorkEffortWorkEffortIdEmpty

FormFieldTitle_timesheetPartyId x2
{quote}

> The entity description labels are considered not used by the Label Manager
> --
>
> Key: OFBIZ-8154
> URL: https://issues.apache.org/jira/browse/OFBIZ-8154
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> As I said in my r1759457 commit comment:
> bq. We have 5237 "Not Used Labels". I wondered if they were all real, I just 
> checked some an indeed, they were not used.  But there are also a huge bunch 
> of *.description.* labels which certainly make sense. I'll remove them from 
> the "Only Not Used Labels" result in another Jira I'll create
> Here is the promised Jira



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8154) The entity description labels are considered not used by the Label Manager

2016-09-14 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490060#comment-15490060
 ] 

Jacques Le Roux commented on OFBIZ-8154:


FieldDescription. is used in 2 places UtilHelpText.java (widget) 
WebToolsServices.java
HumanResServices. seems unused and should be removed
.portalPageName. is doubtful to be double checked
ProductShipmentUomAbbreviation_ used in PackOrder.ftl and WeightPackage.ftl
ProductStoreGroup.productStoreGroupName.NA not sure
TemporalExpression_ used in many place: ServiceDemoData.xml, 
ExpressionUiHelper.java, TempExprMaint.ftl and TemporalExpressions.java

Committed at revision: 1760668  


> The entity description labels are considered not used by the Label Manager
> --
>
> Key: OFBIZ-8154
> URL: https://issues.apache.org/jira/browse/OFBIZ-8154
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> As I said in my r1759457 commit comment:
> bq. We have 5237 "Not Used Labels". I wondered if they were all real, I just 
> checked some an indeed, they were not used.  But there are also a huge bunch 
> of *.description.* labels which certainly make sense. I'll remove them from 
> the "Only Not Used Labels" result in another Jira I'll create
> Here is the promised Jira



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8154) The entity description labels are considered not used by the Label Manager

2016-09-10 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15479501#comment-15479501
 ] 

Jacques Le Roux commented on OFBIZ-8154:


At r1760139, I commited a fix

We had 5237 "Not Used Labels". I wondered if they were all real. There is 
actually a huge bunch of *.description.* labels and alike which are certainly 
used, notably automatically by the widget dropdowns.
This commit removes them from the "Only Not Used Labels" result. Net result: 
from 5237 to decent 2188 "Not Used Labels", this begins to be useful...

It only begins because I removed from the "Not Used Labels" a number of other 
cases similar to the obvious *.description.* labels. those are
.transitionName.
.partyRelationshipName.
.geoName.
.categoryName.
.ProductPromoCondition..
.ProductPromoOperatorEquality..
.Example. // TODO check all is used here

But a number of others need to be verified, at least:
FormFieldTitle_???
FieldDescription.ProductStore.???
FieldDescription.ProdCatalog.???
HumanResServices.???
.portalPageName.???
ProductShipmentUomAbbreviation_???
ProductStoreGroup.productStoreGroupName._NA_???
TemporalExpression_???

After WorkEffortWorkEffortIdEmpty

FormFieldTitle_timesheetPartyId x2

> The entity description labels are considered not used by the Label Manager
> --
>
> Key: OFBIZ-8154
> URL: https://issues.apache.org/jira/browse/OFBIZ-8154
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> As I said in my r1759457 commit comment:
> bq. We have 5237 "Not Used Labels". I wondered if they were all real, I just 
> checked some an indeed, they were not used.  But there are also a huge bunch 
> of *.description.* labels which certainly make sense. I'll remove them from 
> the "Only Not Used Labels" result in another Jira I'll create
> Here is the promised Jira



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6985) New Theme sponsored by Provolve and Stannah

2016-09-10 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15479573#comment-15479573
 ] 

Jacques Le Roux commented on OFBIZ-6985:


Hi, what is the situation here?

> New Theme sponsored by Provolve and Stannah
> ---
>
> Key: OFBIZ-6985
> URL: https://issues.apache.org/jira/browse/OFBIZ-6985
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Upcoming Branch
>Reporter: Hans Bakker
>Priority: Minor
>
> This theme was created by a big ofbiz customer and contributed to the the 
> ofbiz community.
> A demo you can see in GrowERP:
> https://minimum.growerpdemo.com/backend/control/main?PASSWORD=ofbiz=admin



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state

2016-09-08 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474887#comment-15474887
 ] 

Jacques Le Roux commented on OFBIZ-8156:


Pierre, is it a disentanglement or a removing? The umbrella task speaks about 
moving things not removing them. Is it a 1st step?

> Disentangle Fedex solution from current integrated state
> 
>
> Key: OFBIZ-8156
> URL: https://issues.apache.org/jira/browse/OFBIZ-8156
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext, datamodel, order, product, 
> specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Minor
>  Labels: 3rdParty, integration, shipment
> Attachments: OFBIZ-8156-FedexRemoval.patch
>
>
> Disentanglement of the 3rd party shipment integration for FedEx gives the 
> OFBiz adopter more flexibility, reduces the default code base and offers the 
> project more opportunities with respect to attracting product specific 
> contributors, better code and faster release cycles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8138) $ gradlew testIntegration produces exceptions

2016-09-08 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15475091#comment-15475091
 ] 

Jacques Le Roux commented on OFBIZ-8138:


That would be most useful, yes!

> $ gradlew testIntegration produces exceptions
> -
>
> Key: OFBIZ-8138
> URL: https://issues.apache.org/jira/browse/OFBIZ-8138
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
> Environment: Development platform: lubuntu 16.04
> Java environment:
> java version "1.8.0_92"
> Java(TM) SE Runtime Environment (build 1.8.0_92-b14)
> Java HotSpot(TM) 64-Bit Server VM (build 25.92-b14, mixed mode)
> database: postgreSQL
>Reporter: Wai
> Attachments: test-results.tar.bz2
>
>
> run 'gradlew testIntegration' produces many exceptions
> console output...
> ...
> 2016-09-04 15:50:21,539 |main |TestRunContainer  
> |I| [JUNIT] : testClassNotFound starting...
> 2016-09-04 15:50:21,541 |main |TestRunContainer  
> |I| [JUNIT] : testClassNotFound finished.
> 2016-09-04 15:50:21,541 |main |TestRunContainer  
> |I| [JUNIT] : testArray starting...
> 2016-09-04 15:50:21,542 |main |Converters
> |W| *** No converter found, converting from [Ljava.lang.Object; to 
> org.apache.ofbiz.base.util.GeneralException. Please report this message to 
> the developer community so a suitable converter can be created. ***
> 2016-09-04 15:50:21,542 |main |Converters
> |W| *** No converter found, converting from [Ljava.lang.Object; to 
> java.util.Map. Please report this message to the developer community so a 
> suitable converter can be created. ***
> 2016-09-04 15:50:21,543 |main |Converters
> |W| *** No converter found, converting from [I to 
> org.apache.ofbiz.base.util.GeneralException. Please report this message to 
> the developer community so a suitable converter can be created. ***
> 2016-09-04 15:50:21,543 |main |Converters
> |W| *** No converter found, converting from [I to java.util.ArrayList. Please 
> report this message to the developer community so a suitable converter can be 
> created. ***
> 2016-09-04 15:50:21,543 |main |Converters
> |W| *** No converter found, converting from [I to java.util.Map. Please 
> report this message to the developer community so a suitable converter can be 
> created. ***
> 2016-09-04 15:50:21,543 |main |TestRunContainer  
> |I| [JUNIT] : testArray finished.
> 2016-09-04 15:50:21,543 |main |TestRunContainer  
> |I| [JUNIT] : testString starting...
> 2016-09-04 15:50:21,561 |main |Converters
> |W| *** No converter found, converting from java.lang.String to 
> org.apache.ofbiz.base.util.GeneralException. Please report this message to 
> the developer community so a suitable converter can be created. ***
> 2016-09-04 15:50:21,608 |main |UtilMisc  
> |W| Do not know what to do with the localeString [o], should be length 2, 5, 
> or greater than 6, returning null
> 2016-09-04 15:50:21,608 |main |ObjectType
> |W| Exception thrown while converting type: 
> org.apache.ofbiz.base.conversion.ConversionException: Could not convert o to 
> Locale: 
>   at 
> org.apache.ofbiz.base.conversion.MiscConverters$StringToLocale.convert(MiscConverters.java:238)
>  ~[ofbiz.jar:?]
>   at 
> org.apache.ofbiz.base.conversion.MiscConverters$StringToLocale.convert(MiscConverters.java:228)
>  ~[ofbiz.jar:?]
>   at 
> org.apache.ofbiz.base.util.ObjectType.simpleTypeConvert(ObjectType.java:550) 
> [ofbiz.jar:?]
>   at 
> org.apache.ofbiz.base.util.test.ObjectTypeTests.simpleTypeConvert(ObjectTypeTests.java:99)
>  [ofbiz.jar:?]
>   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8224) Removal of support for the Bean Scripting Framework (BSF)

2016-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477646#comment-15477646
 ] 

Jacques Le Roux commented on OFBIZ-8224:


+1 (voted also)

> Removal of support for the Bean Scripting Framework (BSF)
> -
>
> Key: OFBIZ-8224
> URL: https://issues.apache.org/jira/browse/OFBIZ-8224
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacopo Cappellato
>Assignee: Jacopo Cappellato
>Priority: Minor
> Attachments: bsf-removal.patch
>
>
> The attached patch removes the support for Bean Scripting Framework (BSF) 
> from the OFBiz framework: as far as I know no application code was using this 
> since several years and there are better and more modern tools nowadays.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8179) Enhance DBCPConnectionFactory to implement a TransactionFactory and remove the geronimo component

2016-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477817#comment-15477817
 ] 

Jacques Le Roux commented on OFBIZ-8179:


+1 after review (voted)

> Enhance DBCPConnectionFactory to implement a TransactionFactory and remove 
> the geronimo component
> -
>
> Key: OFBIZ-8179
> URL: https://issues.apache.org/jira/browse/OFBIZ-8179
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacopo Cappellato
>Assignee: Jacopo Cappellato
>Priority: Minor
> Attachments: OFBIZ-8179.patch, 
> TransactionConnectionFactory-before-after.png
>
>
> Made the DBCPConnectionFactory an implementation of TransactionFactory by 
> moving the code from the GeronimoTransactionFactory.
> With this change the geronimo component is no more required.
> Without any functional change, this design simplifies greatly the calls and 
> component dependencies because it removes a cyclic dependency between entity 
> and geronimo components (see diagram attached that explain the architecture 
> before and after this change).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8174) The OFBiz logo of wiki pages is huge when having the page in preview mode

2016-09-08 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474892#comment-15474892
 ] 

Jacques Le Roux commented on OFBIZ-8174:


Maybe we should use the same than Sharan used here (in Jira)?

> The OFBiz logo of wiki pages is huge when having the page in preview mode
> -
>
> Key: OFBIZ-8174
> URL: https://issues.apache.org/jira/browse/OFBIZ-8174
> Project: OFBiz
>  Issue Type: Improvement
>  Components: Confluence
>Reporter: Pierre Smits
>Priority: Trivial
>  Labels: wiki
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8174) The OFBiz logo of wiki pages is huge when having the page in preview mode

2016-09-08 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474893#comment-15474893
 ] 

Jacques Le Roux commented on OFBIZ-8174:


I think so also because in Confluence the logos are better when they are round

> The OFBiz logo of wiki pages is huge when having the page in preview mode
> -
>
> Key: OFBIZ-8174
> URL: https://issues.apache.org/jira/browse/OFBIZ-8174
> Project: OFBiz
>  Issue Type: Improvement
>  Components: Confluence
>Reporter: Pierre Smits
>Priority: Trivial
>  Labels: wiki
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8153) LabelManager doesn't search .groovy files

2016-09-08 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474681#comment-15474681
 ] 

Jacques Le Roux commented on OFBIZ-8153:


Thanks Pierre, I'll double check that

> LabelManager doesn't search .groovy files
> -
>
> Key: OFBIZ-8153
> URL: https://issues.apache.org/jira/browse/OFBIZ-8153
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>
> There are over 60 labels used in groovy files. These don't get reflected in 
> the counts of the label manager and in the search for labels not used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8153) LabelManager doesn't search .groovy files

2016-09-08 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-8153.
--
   Resolution: Fixed
Fix Version/s: Release Branch 13.07
   Release Branch 14.12
   Release Branch 15.12
   Upcoming Branch

Thanks for report Pierre,

I committed a fix in
trunk r1759941
R15.12, R14.12, R13.07 r1759942

My previous patch was non sense, this commit uses the already existing 
findUiLabelMapInFile so should do the work rightly.

> LabelManager doesn't search .groovy files
> -
>
> Key: OFBIZ-8153
> URL: https://issues.apache.org/jira/browse/OFBIZ-8153
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch, Release Branch 15.12, Release Branch 
> 14.12, Release Branch 13.07
>
>
> There are over 60 labels used in groovy files. These don't get reflected in 
> the counts of the label manager and in the search for labels not used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (OFBIZ-5522) Introduce websocket usage

2016-09-08 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-5522:
---
Comment: was deleted

(was: It's actually disabled, not removed, I just learnt.)

> Introduce websocket usage
> -
>
> Key: OFBIZ-5522
> URL: https://issues.apache.org/jira/browse/OFBIZ-5522
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> After a discussion with Ean, was suggested (draft here):
> You need a service that lets you "subscribe" a widget to an entity and
> then propagate change events to the widget as the entity is modified.
> A generic mechanism like that could eventually expand to be a general
> purpose "data bound widgets" system that mostly looks like the existing
> system but magically reflects updates.
> Could be used with/for
> * The entity cache and webforms to automatically update views when data 
> changes. 
> * Replaces the current system notes
> * Create a dashboard type pages  (to be discussed futher)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state

2016-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15476089#comment-15476089
 ] 

Jacques Le Roux commented on OFBIZ-8156:


If you have the thread link that would help, TIA.

> Disentangle Fedex solution from current integrated state
> 
>
> Key: OFBIZ-8156
> URL: https://issues.apache.org/jira/browse/OFBIZ-8156
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext, datamodel, order, product, 
> specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Minor
>  Labels: 3rdParty, integration, shipment
> Attachments: OFBIZ-8156-FedexRemoval.patch
>
>
> Disentanglement of the 3rd party shipment integration for FedEx gives the 
> OFBiz adopter more flexibility, reduces the default code base and offers the 
> project more opportunities with respect to attracting product specific 
> contributors, better code and faster release cycles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8202) Use try-with-resources statement wherever it's possible

2016-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15476153#comment-15476153
 ] 

Jacques Le Roux commented on OFBIZ-8202:


Next step is to have EntityListIterator to implement AutoCloseable, fortunately 
it has a clean close() method, so it's more about where it's used...

> Use try-with-resources statement wherever it's possible
> ---
>
> Key: OFBIZ-8202
> URL: https://issues.apache.org/jira/browse/OFBIZ-8202
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> This is a non functional change task.
> I have already commited some such changes for OFBIZ-8115 and at r1759082



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (OFBIZ-5522) Introduce websocket usage

2016-09-08 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-5522:
---
Comment: was deleted

(was: That's really cool. I would be interested in seeing more graphs of 
different information you pull from these logs.
http://fifacoingenerators.com
http://mobilestrikehacktools.com/
http://monsterlegendshackx.com/)

> Introduce websocket usage
> -
>
> Key: OFBIZ-5522
> URL: https://issues.apache.org/jira/browse/OFBIZ-5522
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> After a discussion with Ean, was suggested (draft here):
> You need a service that lets you "subscribe" a widget to an entity and
> then propagate change events to the widget as the entity is modified.
> A generic mechanism like that could eventually expand to be a general
> purpose "data bound widgets" system that mostly looks like the existing
> system but magically reflects updates.
> Could be used with/for
> * The entity cache and webforms to automatically update views when data 
> changes. 
> * Replaces the current system notes
> * Create a dashboard type pages  (to be discussed futher)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (OFBIZ-5522) Introduce websocket usage

2016-09-08 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-5522:
---
Comment: was deleted

(was: Jacob,

Wait, I'm confused, you speak about 
bq. using rivet
bq.  system on a Windows Server 2008
which makes sense here

But then you put a link which does not make sens. Is this spam? W/o answer I'll 
drop your comment and ask infra to deactivate your account.)

> Introduce websocket usage
> -
>
> Key: OFBIZ-5522
> URL: https://issues.apache.org/jira/browse/OFBIZ-5522
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> After a discussion with Ean, was suggested (draft here):
> You need a service that lets you "subscribe" a widget to an entity and
> then propagate change events to the widget as the entity is modified.
> A generic mechanism like that could eventually expand to be a general
> purpose "data bound widgets" system that mostly looks like the existing
> system but magically reflects updates.
> Could be used with/for
> * The entity cache and webforms to automatically update views when data 
> changes. 
> * Replaces the current system notes
> * Create a dashboard type pages  (to be discussed futher)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-8202) Use try-with-resources statement wherever it's possible

2016-09-09 Thread Jacques Le Roux (JIRA)
Jacques Le Roux created OFBIZ-8202:
--

 Summary: Use try-with-resources statement wherever it's possible
 Key: OFBIZ-8202
 URL: https://issues.apache.org/jira/browse/OFBIZ-8202
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
Priority: Trivial
 Fix For: Upcoming Branch


This is a non functional change task.

I have already commited some such changes for OFBIZ-8115 and at r1759082



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-5522) Introduce websocket usage

2016-09-08 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144381#comment-15144381
 ] 

Jacques Le Roux edited comment on OFBIZ-5522 at 9/9/16 5:50 AM:


Note: we can't prevent an user to create an account and spam. 

If you find spam here (happens often) simply delete the comment and ask the 
[infra team on HipChat|https://apache.hipchat.com/chat/room/669587] to 
deactivate the sending account.



was (Author: jacques.le.roux):
We can't prevent an user to create an account and spam. I asked Gavin to remove 
the account. It was done at 10h58 (my hour) :)


> Introduce websocket usage
> -
>
> Key: OFBIZ-5522
> URL: https://issues.apache.org/jira/browse/OFBIZ-5522
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> After a discussion with Ean, was suggested (draft here):
> You need a service that lets you "subscribe" a widget to an entity and
> then propagate change events to the widget as the entity is modified.
> A generic mechanism like that could eventually expand to be a general
> purpose "data bound widgets" system that mostly looks like the existing
> system but magically reflects updates.
> Could be used with/for
> * The entity cache and webforms to automatically update views when data 
> changes. 
> * Replaces the current system notes
> * Create a dashboard type pages  (to be discussed futher)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (OFBIZ-5522) Introduce websocket usage

2016-09-08 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-5522:
---
Comment: was deleted

(was: If this persist, we should consider blocking this?)

> Introduce websocket usage
> -
>
> Key: OFBIZ-5522
> URL: https://issues.apache.org/jira/browse/OFBIZ-5522
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> After a discussion with Ean, was suggested (draft here):
> You need a service that lets you "subscribe" a widget to an entity and
> then propagate change events to the widget as the entity is modified.
> A generic mechanism like that could eventually expand to be a general
> purpose "data bound widgets" system that mostly looks like the existing
> system but magically reflects updates.
> Could be used with/for
> * The entity cache and webforms to automatically update views when data 
> changes. 
> * Replaces the current system notes
> * Create a dashboard type pages  (to be discussed futher)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-8136) No States/Provinces Exist when Request a New Account

2016-09-10 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-8136:
---
Issue Type: Improvement  (was: Bug)

Thanks, I have changed as an improvement

> No States/Provinces Exist when Request a New Account
> 
>
> Key: OFBIZ-8136
> URL: https://issues.apache.org/jira/browse/OFBIZ-8136
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework, specialpurpose/ecommerce
>Affects Versions: Trunk
> Environment: Windows10
> java version "1.8.0_101"
>Reporter: fumiyoshi.to
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Trunk
>
> Attachments: Image 010.png, NoStatesProvincesExist.png, 
> OFBIZ-8136_NoStatesProvincesExists.patch
>
>
> When I choose Japan in new customer screen, no states/province exists 
> occerred, and I cannot register as a customer through ecommerce.
> It is because of no data exist for Japan in CountryAddressFormat[GeoData.xml].
>  requireStateProvinceId="" requirePostalCode="" postalCodeRegex="\d{3}-\d{4}" 
> hasPostalCodeExt="" requirePostalCodeExt="" addressFormat=""/>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8231) Display of State/Province for non US entities in the customer's profile of ecommerce

2016-09-12 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484618#comment-15484618
 ] 

Jacques Le Roux commented on OFBIZ-8231:


BTW the null exceptions happened when using a French address: we don't use 
PROVINCE in addresses (we have departments and we use COUNTY for that which is 
not exactly the same, but anyway)

> Display of State/Province for non US entities in the customer's profile of 
> ecommerce 
> -
>
> Key: OFBIZ-8231
> URL: https://issues.apache.org/jira/browse/OFBIZ-8231
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: fumiyoshi.to
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: 
> OFBIZ-8231_DisplayOfStateProvinceInCustomerProfile.patch, screenshot-1.png, 
> screenshot-2.png
>
>
> When I access url [https://localhost:8443/ecommerce/control/viewprofile}
> for my profile, State/Province display in addresses shows the geo-id, which 
> is fine for US entities where the GeoID is the state code, but for non-us 
> entities, the GeoID is offen something like CountryCode-StateCode, which 
> isn't very nice.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-8241) Put notsoserial in Attic

2016-09-12 Thread Jacques Le Roux (JIRA)
Jacques Le Roux created OFBIZ-8241:
--

 Summary: Put notsoserial in Attic
 Key: OFBIZ-8241
 URL: https://issues.apache.org/jira/browse/OFBIZ-8241
 Project: OFBiz
  Issue Type: Task
  Components: Attic
Affects Versions: Trunk
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: Upcoming Branch


With the new release we decided to get rid of notsoserial. I'll also update the 
related wiki page.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-8242) postalAddressHtmlFormatter in PartyScreens.xml does not work properly.

2016-09-13 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-8242:
--

Assignee: Jacques Le Roux

> postalAddressHtmlFormatter in PartyScreens.xml does not work properly.
> --
>
> Key: OFBIZ-8242
> URL: https://issues.apache.org/jira/browse/OFBIZ-8242
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: fumiyoshi.to
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: 
> OFBIZ-8242_postalAddressHtmlFormatterNotWorkProperly.patch
>
>
> When I added a postal address template into application [party] for Japan, it 
> does not work properly.
> I found the value of addressTemplatePath in the screen of 
> postalAddressHtmlFormatter
> is wrong in file PartyScreens.xml.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8242) postalAddressHtmlFormatter in PartyScreens.xml does not work properly.

2016-09-13 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487134#comment-15487134
 ] 

Jacques Le Roux commented on OFBIZ-8242:


Thanks fumiyoshi.to

You patch is in trunk at revision: 1760535  

I'll wait FishEye to update for backporting (to avoid tree paths issues) and 
closing

> postalAddressHtmlFormatter in PartyScreens.xml does not work properly.
> --
>
> Key: OFBIZ-8242
> URL: https://issues.apache.org/jira/browse/OFBIZ-8242
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: fumiyoshi.to
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: 
> OFBIZ-8242_postalAddressHtmlFormatterNotWorkProperly.patch
>
>
> When I added a postal address template into application [party] for Japan, it 
> does not work properly.
> I found the value of addressTemplatePath in the screen of 
> postalAddressHtmlFormatter
> is wrong in file PartyScreens.xml.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8114) The "Only Not Used Labels" option of the Label Manager is broken

2016-09-15 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494291#comment-15494291
 ] 

Jacques Le Roux commented on OFBIZ-8114:


This is a pain to backport, even in R15.12, so I'll not

BTW at r1759573 I removed webtools.properties


> The "Only Not Used Labels" option of the Label Manager is broken
> 
>
> Key: OFBIZ-8114
> URL: https://issues.apache.org/jira/browse/OFBIZ-8114
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
>
> This is due to the introduction of ServiceUtil.getResource() at r1757979 for 
> OFBIZ-7912



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7957) RateAmount is not found when the level is 'WorkEffort'

2016-09-15 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495421#comment-15495421
 ] 

Jacques Le Roux commented on OFBIZ-7957:


HI Florian, I did not test your patch, but after review I think it's a good 
idea to proceed this way. Taher suggested SECAs, but I think it was more in a 
general way and I agree with what he said. In this case it's only about 
workeffort-rate-amouts so the domain is "siloed" and it's OK to use services 
called by services.

If nobody disagree I'll commit your patch soon.

> RateAmount is not found when the level is 'WorkEffort'
> --
>
> Key: OFBIZ-7957
> URL: https://issues.apache.org/jira/browse/OFBIZ-7957
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>  Labels: accounting, level, rate, rateAmount, workeffort
> Attachments: OFBIZ-7957.patch
>
>
> When you create a RateAmount, you can determine for which WorkEffort it 
> should apply. But when this RateAmount is retrieved for a specific 
> WorkEffort, it fails to find the good RateAmount.
> The problem comes from the check done to retrieve the RateAmount at a 
> WorkEffort level. This is the used check : 
> {code}
> 
>  from-field="parameters.rateTypeId"/>
>  from-field="parameters.partyId"/>
>  from-field="parameters.workEffortId"/>
>  from-field="parameters.periodTypeId"/>
>  from-field="parameters.rateCurrencyUomId"/>
> 
>  
> {code}
> In this 'entity-and', the partyId is set as a constraint. But it is possible 
> to enable a special RateAmount only for a WorkEffort without regarding the 
> partyId.
> I think we have 2 options here :
> - Remove the partyId constraint but then the retrieving may be less accurate
> - Make the retrieving more accurate by checking first the WorkEffort, then 
> from the retrieved list, check if the partyId matches and finally from this 
> second retrieval, check if the emplPositionTypeId match. At the end, we would 
> have the most accurate RateAmount.
> What do you think of it ?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8154) The entity description labels are considered not used by the Label Manager

2016-09-15 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495480#comment-15495480
 ] 

Jacques Le Roux commented on OFBIZ-8154:


It's a pity, because of the translations, but the labels starting by 
"HumanResServices.", which dates from pre Apache era, are not used OOTB, so I 
removed them 
.portalPageName. is used by demo data
ProductStoreGroup.productStoreGroupName.NA is used as data by 
ProductTypeData.xml
FormFieldTitle_timesheetPartyId in ProjectMgrUiLabels.xml seems an error. As it 
duplicates the same in AccountingUiLabels.xml, which is accurate, I remove it 
from ProjectMgrUiLabels

Committed at revision: 1760995  

We have now only 1838 (instead of 5237 initially) "Not Used Labels". 
Still to consider: the labels following WorkEffortWorkEffortIdEmpty in the list 
returned by the "Not Used Labels" options

> The entity description labels are considered not used by the Label Manager
> --
>
> Key: OFBIZ-8154
> URL: https://issues.apache.org/jira/browse/OFBIZ-8154
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> As I said in my r1759457 commit comment:
> bq. We have 5237 "Not Used Labels". I wondered if they were all real, I just 
> checked some an indeed, they were not used.  But there are also a huge bunch 
> of *.description.* labels which certainly make sense. I'll remove them from 
> the "Only Not Used Labels" result in another Jira I'll create
> Here is the promised Jira



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-6866) Add links to edit/delete a term, for instance from the list

2016-09-16 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-6866:
--

Assignee: Jacques Le Roux

> Add links to edit/delete a term, for instance from the list
> ---
>
> Key: OFBIZ-6866
> URL: https://issues.apache.org/jira/browse/OFBIZ-6866
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6866-InvoiceScreens.xml.patch, OFBIZ-6866.patch, 
> OFBIZ-6866.patch
>
>
> Currently in UI there is no way to edit nor delete a term



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7957) RateAmount is not found when the level is 'WorkEffort'

2016-09-16 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-7957:
--

Assignee: Jacques Le Roux

> RateAmount is not found when the level is 'WorkEffort'
> --
>
> Key: OFBIZ-7957
> URL: https://issues.apache.org/jira/browse/OFBIZ-7957
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>Assignee: Jacques Le Roux
>  Labels: accounting, level, rate, rateAmount, workeffort
> Attachments: OFBIZ-7957.patch
>
>
> When you create a RateAmount, you can determine for which WorkEffort it 
> should apply. But when this RateAmount is retrieved for a specific 
> WorkEffort, it fails to find the good RateAmount.
> The problem comes from the check done to retrieve the RateAmount at a 
> WorkEffort level. This is the used check : 
> {code}
> 
>  from-field="parameters.rateTypeId"/>
>  from-field="parameters.partyId"/>
>  from-field="parameters.workEffortId"/>
>  from-field="parameters.periodTypeId"/>
>  from-field="parameters.rateCurrencyUomId"/>
> 
>  
> {code}
> In this 'entity-and', the partyId is set as a constraint. But it is possible 
> to enable a special RateAmount only for a WorkEffort without regarding the 
> partyId.
> I think we have 2 options here :
> - Remove the partyId constraint but then the retrieving may be less accurate
> - Make the retrieving more accurate by checking first the WorkEffort, then 
> from the retrieved list, check if the partyId matches and finally from this 
> second retrieval, check if the emplPositionTypeId match. At the end, we would 
> have the most accurate RateAmount.
> What do you think of it ?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8079) persian calendar problem

2016-09-16 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495530#comment-15495530
 ] 

Jacques Le Roux commented on OFBIZ-8079:


Hi Ali,

Would you help using this answer 
https://stackoverflow.com/questions/23385434/a-good-date-converter-for-jalali-calendar-in-java#answer-23386074
 ?
Disclaimer: I did not check our code on this subject

> persian calendar problem 
> -
>
> Key: OFBIZ-8079
> URL: https://issues.apache.org/jira/browse/OFBIZ-8079
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Release Branch 14.12
>Reporter: ali sohrabi
>
> I set ma locale to fa-IR and Time zone to Iran Standard time, but still all 
> calendars are gregorian, but it must be (shamsi/jalali) persian calendar 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6866) Add links to edit/delete a term, for instance from the list

2016-09-16 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495576#comment-15495576
 ] 

Jacques Le Roux commented on OFBIZ-6866:


HI Florian,

There is no definition for the deleteInvoiceTerm service 
bq. Erreur lors de l'appel de l'événement: 
org.apache.ofbiz.webapp.event.EventHandlerException: Problems getting the 
service model (Cannot locate service by name (deleteInvoiceTerm))

And I don't see how you can edit an invoice-term

Thanks for you work so far :)

> Add links to edit/delete a term, for instance from the list
> ---
>
> Key: OFBIZ-6866
> URL: https://issues.apache.org/jira/browse/OFBIZ-6866
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6866-InvoiceScreens.xml.patch, OFBIZ-6866.patch, 
> OFBIZ-6866.patch
>
>
> Currently in UI there is no way to edit nor delete a term



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6866) Add links to edit/delete a term, for instance from the list

2016-09-16 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495581#comment-15495581
 ] 

Jacques Le Roux commented on OFBIZ-6866:


Ah, and also your patch has a small quirk, a line misses so it does not apply 
in 1st hand

> Add links to edit/delete a term, for instance from the list
> ---
>
> Key: OFBIZ-6866
> URL: https://issues.apache.org/jira/browse/OFBIZ-6866
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6866-InvoiceScreens.xml.patch, OFBIZ-6866.patch, 
> OFBIZ-6866.patch
>
>
> Currently in UI there is no way to edit nor delete a term



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8203) Attribute 'value-field' must appear on element 'entity-one'

2016-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15476410#comment-15476410
 ] 

Jacques Le Roux commented on OFBIZ-8203:


Also else the value-field would not have been made required


> Attribute 'value-field' must appear on element 'entity-one'
> ---
>
> Key: OFBIZ-8203
> URL: https://issues.apache.org/jira/browse/OFBIZ-8203
> Project: OFBiz
>  Issue Type: Bug
>  Components: content, humanres
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>
> I have found 4 such issues:
> {code}
> XmlFileLoader: File 
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/content/ContentForms.xml
>  process error. Line: 235. Error message: cvc-complex-type.4: Attribute 
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File 
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/contentsetup/ContentSetupForms.xml
>  process error. Line: 217. Error message: cvc-complex-type.4: Attribute 
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File 
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/EmploymentAppForms.xml
>  process error. Line: 27. Error message: cvc-complex-type.4: Attribute 
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File 
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/PayGradeForms.xml
>  process error. Line: 65. Error message: cvc-complex-type.4: Attribute 
> 'value-field' must appear on element 'entity-one'.h
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8203) Attribute 'value-field' must appear on element 'entity-one'

2016-09-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15476404#comment-15476404
 ] 

Jacques Le Roux commented on OFBIZ-8203:


Since this is not documented in the XSD I suppose it does not work like that, 
but could please check?

> Attribute 'value-field' must appear on element 'entity-one'
> ---
>
> Key: OFBIZ-8203
> URL: https://issues.apache.org/jira/browse/OFBIZ-8203
> Project: OFBiz
>  Issue Type: Bug
>  Components: content, humanres
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>
> I have found 4 such issues:
> {code}
> XmlFileLoader: File 
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/content/ContentForms.xml
>  process error. Line: 235. Error message: cvc-complex-type.4: Attribute 
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File 
> file:/C:/projectASF-Mars/ofbiz/applications/content/widget/contentsetup/ContentSetupForms.xml
>  process error. Line: 217. Error message: cvc-complex-type.4: Attribute 
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File 
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/EmploymentAppForms.xml
>  process error. Line: 27. Error message: cvc-complex-type.4: Attribute 
> 'value-field' must appear on element 'entity-one'.
> XmlFileLoader: File 
> file:/C:/projectASF-Mars/ofbiz/applications/humanres/widget/forms/PayGradeForms.xml
>  process error. Line: 65. Error message: cvc-complex-type.4: Attribute 
> 'value-field' must appear on element 'entity-one'.h
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8118) Consistent menu names

2016-09-12 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-8118.
--

> Consistent menu names
> -
>
> Key: OFBIZ-8118
> URL: https://issues.apache.org/jira/browse/OFBIZ-8118
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Tanmay Muley
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Menu-name should be in upper camel case as per best practice. There are few 
> places where menu-names are in lower camel case. Need to fix these to 
> maintain consistency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8241) Put notsoserial in Attic

2016-09-13 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-8241.
--
Resolution: Done

Done at r1760484 

> Put notsoserial in Attic
> 
>
> Key: OFBIZ-8241
> URL: https://issues.apache.org/jira/browse/OFBIZ-8241
> Project: OFBiz
>  Issue Type: Task
>  Components: Attic
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> With the new release we decided to get rid of notsoserial. I'll also update 
> the related wiki page.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8321) Labels cache clearing no longer works

2016-09-24 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15518520#comment-15518520
 ] 

Jacques Le Roux commented on OFBIZ-8321:


Works also in pre-Gradle version 

> Labels cache clearing no longer works
> -
>
> Key: OFBIZ-8321
> URL: https://issues.apache.org/jira/browse/OFBIZ-8321
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
> Fix For: Upcoming Branch
>
>
> While working on OFBIZ-7798 I noticed an issue with labels cache clearing. It 
> still works correctly in R15.12, I did not test between.
> To test it, load a page with a label, change the label in file, clear all 
> caches in webtools, the new label value should appear, it does not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-7317) Net Before Overhead Report is not working

2016-09-30 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535608#comment-15535608
 ] 

Jacques Le Roux edited comment on OFBIZ-7317 at 9/30/16 10:14 AM:
--

Thanks Rohit, I did not check further, but are not the "B2CStore" data also 
needed by the Product Demand Report?
http://svn.apache.org/viewvc?view=revision=902719


was (Author: jacques.le.roux):
Thanks Rohit, I did not check further, but are not the "B2CStore" also needed 
by the Product Demand Report?
http://svn.apache.org/viewvc?view=revision=902719

>  Net Before Overhead Report is not working
> --
>
> Key: OFBIZ-7317
> URL: https://issues.apache.org/jira/browse/OFBIZ-7317
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order, specialpurpose/birt
>Reporter: Rohit Koushal
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-7317.patch
>
>
>  Net Before Overhead Report is not working
> Screen : 
> https://ofbiz-vm.apache.org:8443/ordermgr/control/OrderPurchaseReportOptions
> Section : Net Before Overhead Report 
> Getting error like 
> {code}
>[java] 
> org.eclipse.birt.report.engine.api.impl.ParameterValidationException: The 
> type of parameter "DateYear" is expected as "integer", not "java.lang.String".
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask.validateParameterValueType(EngineTask.java:940)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask.validateAbstractScalarParameter(EngineTask.java:862)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask.access$0(EngineTask.java:789)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask$ParameterValidationVisitor.visitScalarParameter(EngineTask.java:706)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask$ParameterVisitor.visit(EngineTask.java:1531)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask.doValidateParameters(EngineTask.java:692)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.RunAndRenderTask.doRun(RunAndRenderTask.java:95)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.RunAndRenderTask.run(RunAndRenderTask.java:77)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at org.ofbiz.birt.BirtWorker.exportReport(BirtWorker.java:143) 
> ~[ofbiz-birt.jar:?]
>  [java]   at 
> org.ofbiz.birt.webapp.view.BirtViewHandler.render(BirtViewHandler.java:118) 
> ~[ofbiz-birt.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:1001) 
> ~[ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:653) 
> ~[ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:213) 
> [ofbiz-webapp.jar:?]
>  [java]   at javax.servlet.http.HttpServlet.service(HttpServlet.java:622) 
> [servlet-api-3.1.jar:?]
>  [java]   at javax.servlet.http.HttpServlet.service(HttpServlet.java:729) 
> [servlet-api-3.1.jar:?]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:323) 
> [ofbiz-webapp.jar:?]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:212)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:106)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:502)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:141) 
> [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 

[jira] [Commented] (OFBIZ-7317) Net Before Overhead Report is not working

2016-09-30 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535608#comment-15535608
 ] 

Jacques Le Roux commented on OFBIZ-7317:


Thanks Rohit, I did not check further, but are not the "B2CStore" also needed 
by the Product Demand Report?
http://svn.apache.org/viewvc?view=revision=902719

>  Net Before Overhead Report is not working
> --
>
> Key: OFBIZ-7317
> URL: https://issues.apache.org/jira/browse/OFBIZ-7317
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order, specialpurpose/birt
>Reporter: Rohit Koushal
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-7317.patch
>
>
>  Net Before Overhead Report is not working
> Screen : 
> https://ofbiz-vm.apache.org:8443/ordermgr/control/OrderPurchaseReportOptions
> Section : Net Before Overhead Report 
> Getting error like 
> {code}
>[java] 
> org.eclipse.birt.report.engine.api.impl.ParameterValidationException: The 
> type of parameter "DateYear" is expected as "integer", not "java.lang.String".
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask.validateParameterValueType(EngineTask.java:940)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask.validateAbstractScalarParameter(EngineTask.java:862)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask.access$0(EngineTask.java:789)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask$ParameterValidationVisitor.visitScalarParameter(EngineTask.java:706)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask$ParameterVisitor.visit(EngineTask.java:1531)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.EngineTask.doValidateParameters(EngineTask.java:692)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.RunAndRenderTask.doRun(RunAndRenderTask.java:95)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at 
> org.eclipse.birt.report.engine.api.impl.RunAndRenderTask.run(RunAndRenderTask.java:77)
>  ~[org.eclipse.birt.runtime_4.3.1.v20130918-1142.jar:?]
>  [java]   at org.ofbiz.birt.BirtWorker.exportReport(BirtWorker.java:143) 
> ~[ofbiz-birt.jar:?]
>  [java]   at 
> org.ofbiz.birt.webapp.view.BirtViewHandler.render(BirtViewHandler.java:118) 
> ~[ofbiz-birt.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:1001) 
> ~[ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:653) 
> ~[ofbiz-webapp.jar:?]
>  [java]   at 
> org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:213) 
> [ofbiz-webapp.jar:?]
>  [java]   at javax.servlet.http.HttpServlet.service(HttpServlet.java:622) 
> [servlet-api-3.1.jar:?]
>  [java]   at javax.servlet.http.HttpServlet.service(HttpServlet.java:729) 
> [servlet-api-3.1.jar:?]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:323) 
> [ofbiz-webapp.jar:?]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:212)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:106)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:502)
>  [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:141) 
> [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:79) 
> [tomcat-8.0.33-catalina.jar:8.0.33]
>  [java]   at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:88)
>  

[jira] [Closed] (OFBIZ-8344) Maybe not issue. MD5 Does not match for OFBiz 13.07.03 zip. PGP, I think, is OK, though.

2016-10-05 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-8344.
--
Resolution: Not A Problem

I just checked (again I did already when we released: 
http://markmail.org/message/2meraou36tpuzzpa) it's OK with me: !Image 016.png!

> Maybe not issue. MD5 Does not match for OFBiz 13.07.03 zip. PGP, I think, is 
> OK, though.
> 
>
> Key: OFBIZ-8344
> URL: https://issues.apache.org/jira/browse/OFBIZ-8344
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 13.07
>Reporter: Mariella Malapi
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: Image 016.png
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-8344) Maybe not issue. MD5 Does not match for OFBiz 13.07.03 zip. PGP, I think, is OK, though.

2016-10-05 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-8344:
---
Attachment: Image 016.png

> Maybe not issue. MD5 Does not match for OFBiz 13.07.03 zip. PGP, I think, is 
> OK, though.
> 
>
> Key: OFBIZ-8344
> URL: https://issues.apache.org/jira/browse/OFBIZ-8344
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 13.07
>Reporter: Mariella Malapi
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: Image 016.png
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-8344) Maybe not issue. MD5 Does not match for OFBiz 13.07.03 zip. PGP, I think, is OK, though.

2016-10-05 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-8344:
--

Assignee: Jacques Le Roux

> Maybe not issue. MD5 Does not match for OFBiz 13.07.03 zip. PGP, I think, is 
> OK, though.
> 
>
> Key: OFBIZ-8344
> URL: https://issues.apache.org/jira/browse/OFBIZ-8344
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 13.07
>Reporter: Mariella Malapi
>Assignee: Jacques Le Roux
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-8345) popup calendar fails for ecomseo et ecommerce

2016-10-06 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-8345:
---
Summary: popup calendar fails for ecomseo et ecommerce  (was: popup 
calendar fails for ecomseo)

> popup calendar fails for ecomseo et ecommerce
> -
>
> Key: OFBIZ-8345
> URL: https://issues.apache.org/jira/browse/OFBIZ-8345
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Wai
>
> go to https://localhost:8443/ecomseo/editShoppingList
> create a new shopping list
> make changes to "Shopping List Reorder" pane by clicking on date icon.
> nothing happens



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (OFBIZ-6212) Accounting reports fail

2016-10-07 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-6212:


Hi Deepak, I reopen, here all the reports but the 1st fail for
https://localhost:8443/accounting/control/FinancialSummaryReportOptions?organizationPartyId=Company
with "Unknown request"

> Accounting reports fail
> ---
>
> Key: OFBIZ-6212
> URL: https://issues.apache.org/jira/browse/OFBIZ-6212
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, specialpurpose/birt
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6212-1.patch
>
>
> Below are the issues:
> 1).  
> http://demo-trunk-ofbiz.apache.org/accounting/control/FinancialSummaryReportOptions?organizationPartyId=Company
> 1st report: groovy file error, others miss request-maps
> 2). http://demo-trunk-ofbiz.apache.org/accounting/control/TrialBalance
> {noformat}
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> org.ofbiz.widget.renderer.ScreenRenderException:
> Error rendering screen 
> [component://accounting/widget/ReportFinancialSummaryScreens.xml#TrialBalance]:
>  java.lang.IllegalArgumentException:
> Error calling service with name getPartyAccountingPreferences: 
> org.ofbiz.service.ServiceValidationException:
> Le paramètre requis suivant manque : 
> [getPartyAccountingPreferences.organizationPartyId]
> {noformat}
> 3).
> The followings are Birt issues
> 
> http://demo-trunk-ofbiz.apache.org/accounting/control/IncomeStatement?organizationPartyId=Company
>  (PFD export)
> 
> http://demo-trunk-ofbiz.apache.org/accounting/control/BalanceSheet?organizationPartyId=Company
>  (PFD export)
> They work in stable demo, there is no Birt there
> 
> http://demo-stable-ofbiz.apache.org/accounting/control/IncomeStatement?organizationPartyId=Company
>  (PFD export)
> 
> http://demo-stable-ofbiz.apache.org/accounting/control/BalanceSheet?organizationPartyId=Company
>  (PFD export)
> These issues should be addressed separately in sub-tasks each, I have not 
> time to do that yet...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-6212) Accounting financial summary reports fail

2016-10-07 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1997#comment-1997
 ] 

Jacques Le Roux edited comment on OFBIZ-6212 at 10/7/16 7:10 PM:
-

Each time re-test what I did in OFBIZ-6639 description and above I find that 
most of the PDF reports don't work, it's depressing :/


was (Author: jacques.le.roux):
Each time re-test what I did in OFBIZ-6639 description I find that most of the 
PDF reports don't work, it's depressing :/

> Accounting  financial summary reports fail
> --
>
> Key: OFBIZ-6212
> URL: https://issues.apache.org/jira/browse/OFBIZ-6212
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, specialpurpose/birt
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6212-1.patch
>
>
> Below are the issues:
> 1).  
> http://demo-trunk-ofbiz.apache.org/accounting/control/FinancialSummaryReportOptions?organizationPartyId=Company
> 1st report: groovy file error, others miss request-maps
> 2). http://demo-trunk-ofbiz.apache.org/accounting/control/TrialBalance
> {noformat}
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> org.ofbiz.widget.renderer.ScreenRenderException:
> Error rendering screen 
> [component://accounting/widget/ReportFinancialSummaryScreens.xml#TrialBalance]:
>  java.lang.IllegalArgumentException:
> Error calling service with name getPartyAccountingPreferences: 
> org.ofbiz.service.ServiceValidationException:
> Le paramètre requis suivant manque : 
> [getPartyAccountingPreferences.organizationPartyId]
> {noformat}
> 3).
> The followings are Birt issues
> 
> http://demo-trunk-ofbiz.apache.org/accounting/control/IncomeStatement?organizationPartyId=Company
>  (PFD export)
> 
> http://demo-trunk-ofbiz.apache.org/accounting/control/BalanceSheet?organizationPartyId=Company
>  (PFD export)
> They work in stable demo, there is no Birt there
> 
> http://demo-stable-ofbiz.apache.org/accounting/control/IncomeStatement?organizationPartyId=Company
>  (PFD export)
> 
> http://demo-stable-ofbiz.apache.org/accounting/control/BalanceSheet?organizationPartyId=Company
>  (PFD export)
> These issues should be addressed separately in sub-tasks each, I have not 
> time to do that yet...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (OFBIZ-6638) TrialBalance PDF export fails

2016-10-07 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-6638:


HI Arun, Rohit, could you please check because even after closing a time period 
its PDF export does not work here, thanks.

> TrialBalance PDF export fails
> -
>
> Key: OFBIZ-6638
> URL: https://issues.apache.org/jira/browse/OFBIZ-6638
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Jacques Le Roux
>Assignee: Arun Patidar
> Fix For: Trunk, 14.12.01, 15.12.01
>
> Attachments: OFBIZ-6638.patch
>
>
> # Get to 
> http://demo-trunk-ofbiz.apache.org/accounting/control/TrialBalance?organizationPartyId=Company
> #pick a "Custom Time Period Id" (default works also)
> #Submit
> Then the CSV export works but not the PDF, this in trunk demo.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6212) Accounting financial summary reports fail

2016-10-07 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1997#comment-1997
 ] 

Jacques Le Roux commented on OFBIZ-6212:


Each time re-test what I did in OFBIZ-6639 description I find that most of the 
PDF reports don't work, it's depressing :/

> Accounting  financial summary reports fail
> --
>
> Key: OFBIZ-6212
> URL: https://issues.apache.org/jira/browse/OFBIZ-6212
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, specialpurpose/birt
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6212-1.patch
>
>
> Below are the issues:
> 1).  
> http://demo-trunk-ofbiz.apache.org/accounting/control/FinancialSummaryReportOptions?organizationPartyId=Company
> 1st report: groovy file error, others miss request-maps
> 2). http://demo-trunk-ofbiz.apache.org/accounting/control/TrialBalance
> {noformat}
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> org.ofbiz.widget.renderer.ScreenRenderException:
> Error rendering screen 
> [component://accounting/widget/ReportFinancialSummaryScreens.xml#TrialBalance]:
>  java.lang.IllegalArgumentException:
> Error calling service with name getPartyAccountingPreferences: 
> org.ofbiz.service.ServiceValidationException:
> Le paramètre requis suivant manque : 
> [getPartyAccountingPreferences.organizationPartyId]
> {noformat}
> 3).
> The followings are Birt issues
> 
> http://demo-trunk-ofbiz.apache.org/accounting/control/IncomeStatement?organizationPartyId=Company
>  (PFD export)
> 
> http://demo-trunk-ofbiz.apache.org/accounting/control/BalanceSheet?organizationPartyId=Company
>  (PFD export)
> They work in stable demo, there is no Birt there
> 
> http://demo-stable-ofbiz.apache.org/accounting/control/IncomeStatement?organizationPartyId=Company
>  (PFD export)
> 
> http://demo-stable-ofbiz.apache.org/accounting/control/BalanceSheet?organizationPartyId=Company
>  (PFD export)
> These issues should be addressed separately in sub-tasks each, I have not 
> time to do that yet...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-6212) Accounting reports fail

2016-10-07 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1943#comment-1943
 ] 

Jacques Le Roux edited comment on OFBIZ-6212 at 10/7/16 6:59 PM:
-

Hi Deepak, I reopen, here all the financial summary reports but the 1st fail for
https://localhost:8443/accounting/control/FinancialSummaryReportOptions?organizationPartyId=Company
with "Unknown request"


was (Author: jacques.le.roux):
Hi Deepak, I reopen, here all the reports but the 1st fail for
https://localhost:8443/accounting/control/FinancialSummaryReportOptions?organizationPartyId=Company
with "Unknown request"

> Accounting reports fail
> ---
>
> Key: OFBIZ-6212
> URL: https://issues.apache.org/jira/browse/OFBIZ-6212
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, specialpurpose/birt
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6212-1.patch
>
>
> Below are the issues:
> 1).  
> http://demo-trunk-ofbiz.apache.org/accounting/control/FinancialSummaryReportOptions?organizationPartyId=Company
> 1st report: groovy file error, others miss request-maps
> 2). http://demo-trunk-ofbiz.apache.org/accounting/control/TrialBalance
> {noformat}
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> org.ofbiz.widget.renderer.ScreenRenderException:
> Error rendering screen 
> [component://accounting/widget/ReportFinancialSummaryScreens.xml#TrialBalance]:
>  java.lang.IllegalArgumentException:
> Error calling service with name getPartyAccountingPreferences: 
> org.ofbiz.service.ServiceValidationException:
> Le paramètre requis suivant manque : 
> [getPartyAccountingPreferences.organizationPartyId]
> {noformat}
> 3).
> The followings are Birt issues
> 
> http://demo-trunk-ofbiz.apache.org/accounting/control/IncomeStatement?organizationPartyId=Company
>  (PFD export)
> 
> http://demo-trunk-ofbiz.apache.org/accounting/control/BalanceSheet?organizationPartyId=Company
>  (PFD export)
> They work in stable demo, there is no Birt there
> 
> http://demo-stable-ofbiz.apache.org/accounting/control/IncomeStatement?organizationPartyId=Company
>  (PFD export)
> 
> http://demo-stable-ofbiz.apache.org/accounting/control/BalanceSheet?organizationPartyId=Company
>  (PFD export)
> These issues should be addressed separately in sub-tasks each, I have not 
> time to do that yet...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6212) Accounting financial summary reports fail

2016-10-07 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1976#comment-1976
 ] 

Jacques Le Roux commented on OFBIZ-6212:


I wonder if we should not get rid of all these always failing Birt reports!

> Accounting  financial summary reports fail
> --
>
> Key: OFBIZ-6212
> URL: https://issues.apache.org/jira/browse/OFBIZ-6212
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, specialpurpose/birt
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6212-1.patch
>
>
> Below are the issues:
> 1).  
> http://demo-trunk-ofbiz.apache.org/accounting/control/FinancialSummaryReportOptions?organizationPartyId=Company
> 1st report: groovy file error, others miss request-maps
> 2). http://demo-trunk-ofbiz.apache.org/accounting/control/TrialBalance
> {noformat}
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> org.ofbiz.widget.renderer.ScreenRenderException:
> Error rendering screen 
> [component://accounting/widget/ReportFinancialSummaryScreens.xml#TrialBalance]:
>  java.lang.IllegalArgumentException:
> Error calling service with name getPartyAccountingPreferences: 
> org.ofbiz.service.ServiceValidationException:
> Le paramètre requis suivant manque : 
> [getPartyAccountingPreferences.organizationPartyId]
> {noformat}
> 3).
> The followings are Birt issues
> 
> http://demo-trunk-ofbiz.apache.org/accounting/control/IncomeStatement?organizationPartyId=Company
>  (PFD export)
> 
> http://demo-trunk-ofbiz.apache.org/accounting/control/BalanceSheet?organizationPartyId=Company
>  (PFD export)
> They work in stable demo, there is no Birt there
> 
> http://demo-stable-ofbiz.apache.org/accounting/control/IncomeStatement?organizationPartyId=Company
>  (PFD export)
> 
> http://demo-stable-ofbiz.apache.org/accounting/control/BalanceSheet?organizationPartyId=Company
>  (PFD export)
> These issues should be addressed separately in sub-tasks each, I have not 
> time to do that yet...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7995) Not able to create customer

2016-10-09 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7995.
--
   Resolution: Fixed
Fix Version/s: Release Branch 14.12
   Release Branch 15.12
   Upcoming Branch

> Not able to create customer
> ---
>
> Key: OFBIZ-7995
> URL: https://issues.apache.org/jira/browse/OFBIZ-7995
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Reporter: Padmavati Rawat
> Fix For: Upcoming Branch, Release Branch 15.12, Release Branch 
> 14.12
>
> Attachments: Passwordfieldmissing.png
>
>
> Steps:
> 1. Login at ofbiz-trunk, and navigate on Party.
> 2. Select create customer in create field.
> 3. Fill all mandatory details and click on save button.
> Expected:
> The Customer should create successfully, if all mandatory fields are filled.
> Actual:
> 'Missing password' error showing on screen as there are no fileds found for 
> password on page.
> Screen shot attached for references.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7995) Not able to create customer

2016-10-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15559607#comment-15559607
 ] 

Jacques Le Roux commented on OFBIZ-7995:


Thank you Florian, Pierre and Pawan, now closed

> Not able to create customer
> ---
>
> Key: OFBIZ-7995
> URL: https://issues.apache.org/jira/browse/OFBIZ-7995
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Reporter: Padmavati Rawat
> Fix For: Release Branch 14.12, Upcoming Branch, Release Branch 
> 15.12
>
> Attachments: Passwordfieldmissing.png
>
>
> Steps:
> 1. Login at ofbiz-trunk, and navigate on Party.
> 2. Select create customer in create field.
> 3. Fill all mandatory details and click on save button.
> Expected:
> The Customer should create successfully, if all mandatory fields are filled.
> Actual:
> 'Missing password' error showing on screen as there are no fileds found for 
> password on page.
> Screen shot attached for references.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-5802) Contact.ftl generates errors when accessed anonymously

2016-10-06 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-5802:
---
Issue Type: Bug  (was: Sub-task)
Parent: (was: OFBIZ-2330)

> Contact.ftl generates errors when accessed anonymously
> --
>
> Key: OFBIZ-5802
> URL: https://issues.apache.org/jira/browse/OFBIZ-5802
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Release Branch 11.04, Release Branch 12.04, Release 
> Branch 13.07, Trunk
>Reporter: Pierre Smits
>  Labels: portal, portalPage, portlet, profile
>
> When accessing a screen that delivers the PartyProfile portalpage as an 
> anonymous user, the Contact portlet (which renders contact.ftl) shows a lot 
> of errors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5802) Contact.ftl generates errors when accessed anonymously

2016-10-06 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552460#comment-15552460
 ] 

Jacques Le Roux commented on OFBIZ-5802:


This is unrelated to OFBIZ-2330, so not a subtask of it (just converted to a 
plain issue). We need more elements to be able to work on this issue which is 
partly external

> Contact.ftl generates errors when accessed anonymously
> --
>
> Key: OFBIZ-5802
> URL: https://issues.apache.org/jira/browse/OFBIZ-5802
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Release Branch 11.04, Release Branch 12.04, Release 
> Branch 13.07, Trunk
>Reporter: Pierre Smits
>  Labels: portal, portalPage, portlet, profile
>
> When accessing a screen that delivers the PartyProfile portalpage as an 
> anonymous user, the Contact portlet (which renders contact.ftl) shows a lot 
> of errors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8154) The entity description labels are considered not used by the Label Manager

2016-10-07 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15554580#comment-15554580
 ] 

Jacques Le Roux commented on OFBIZ-8154:


Ouch, this is very tedious now and I'd appreciate some help, else this will 
remain open a long time I guess...

Nevertheless, at r1763695 and r1763701 and I have kept labels wich are actually 
used or are useful even if empty.

Now I was removing really unused labels, but I feel it's a pity to do so. I 
guess most of them are from pre Apache era and were really never used but since 
then the community filled the l10n parts and it does not hurt to not remove 
them. I speak for instance about:
{code}
Index: OrderErrorUiLabels.xml
===
--- OrderErrorUiLabels.xml  (revision 1763694)
+++ OrderErrorUiLabels.xml  (working copy)
@@ -5119,16 +5119,6 @@
 在添加到购物车之前请配置产品
 在添加到購物車之前請配置產品
 
-
-Fehler: Eine Abhängigkeit zu einem anderen 
Merkmal konnte nicht aufgelöst werden.
-Error: a dependency to another feature has not 
been resolved.
-Erreur : une dépendance envers une autre option 
n'a pu être résolue.
-エラー: 別の機能への依存関係が解消していません
-Erro: uma dependência de outra funcionalidade 
não foi resolvida
-Lỗi xảy ra: một phụ thuộc (dependency) vào tính 
năng khác (feature) chưa được xử lý
-错误:尚未解决对另一个特性的依赖。
-錯誤:尚未解決對另一個特性的依賴。
-
 
 ادخل المبلغ قبل الإضافة إلى العربة
 Geben sie einen Betrag vor dem Hinzufügen zum 
Warenkorb ein
@@ -5183,23 +5173,6 @@
 没有传递产品信息,没有向购物车添加任何明细。
 沒有傳遞產品資訊,沒有向購物車添加任何明細。
 
-
-الإعدادات غير صالحة
-Konfiguration ist nicht gültig
-Configuration Is Not Valid
-La configuración no es válida
-La configuration n'est pas valide
-Configurazione Non E' Valida
-設定が正しくありません
-A configuração não é válida
-Configurarea Nu este Valida
-Неверная конфигурация
-ไม่มีค่าองค์ประกอบ
-Cấu hình tùy chọn không hợp lệ
-配置无效
-配置无效
-配置無效
-
 
 Dezimalmenge ist nicht erlaubt.
 Quantity in decimal is not allowed.
@@ -5244,23 +5217,6 @@
 把 ${totalQuantity} 明细添加到购物车。
 把 ${totalQuantity} 明細添加到購物車。
 
-
-لم تحدد إتفاقية للإضافة من.
-Kein Vertrag angegeben, aus dem hinzugefügt 
werden kann.
-No agreement specified to add from.
-No se ha indicado un acuerdo del que se pueda 
añadir.
-Aucun accord spécifié à partir duquel 
ajouter.
-Nessun contratto specificato da 
aggiungere.
-追加元の同意が指定されていません。
-Nenhum acordo especificado como fonte da 
adição.
-Nici-un contract specificat de  adaugat.
-Не указаны договора.
-ไม่ระบุสัญญาจากการเพิ่ม
-Không có thỏa thuận nào để thêm vào.
-没有指定要添加进来的合同。
-没有指定的协议被加入
-沒有指定要添加進來的合同。
-
 
 المبلغ يجب أن يكون رقم موجب
 Der Betrag muss eine positive Zahl sein
@@ -5302,40 +5258,6 @@
 没有指定的分类被加入
 沒有指定要添加進來的分類。
 
-
-لا يمكن إضافة السلعة ${productId} إلى 
العربة
-Produkt ${productId} konnte dem Warenkorb NICHT 
hinzugefügt werden.
-Could NOT add product ${productId} to 
cart.
-No se puede añadir el producto ${productId} al 
carro.
-Impossible d'ajouter l'article ${productId} au 
panier.
-NON è Possibile aggiungere prodotto ${productId} 
al carrello.
-製品 ${productId} を買い物かごに追加できません。
-Não foi possível adicionar produto 
${productId}
-Nu este Posibila adaugare produs ${productId} in 
cos.
-Не смог добавить продукт ${productId} в 
корзину.
-ไม่สามารถเพิ่มสินค้า ${productId} 
ลงตระกร้า
-Không thể thêm sản phẩm ${productId} vào giỏ 
hàng.
-不能把产品 ${productId} 添加到购物车。
-不能加入产品 ${productId} 到购物车.
-不能把產品 ${productId} 添加到購物車。
-
-
-لا يمكن المرور للإتفاقية ${agreementId} {read 
error}: ${message}.
-Konnte Vertrag nicht holen mit der Vertrag ID 
${agreementId} (Lesefehler): ${message}
-Could not get agreement through ${agreementId} 
{read error}: ${message}.
-No se pudo obtener el acuerdo con ${agreementId} 
{read error}: ${message}.
-Impossible d'obtenir un accord par ${agreementId} 
{read error} : ${message}.
-Non è possibile leggere il contratto attraverso 
${agreementId} {read error}: ${message}.
-同意を取得できません ${agreementId} {読み込みエラー}: 
${message}。
-Não foi possível obter acordo através do 
Acordo ${agreementId} {read error} : ${message}.
-Nu este posibila Citirea contractului prin  
${agreementId} {read error}: ${message}.
-Не смог получить договор в результате 
${agreementId} {read error}: ${message}.
-ไม่สามารถรับข้อสัญญาเนื่องจาก ${agreementId} 

[jira] [Updated] (OFBIZ-8154) Some labels are considered not used by the Label Manager

2016-10-07 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-8154:
---
Summary: Some labels are considered not used by the Label Manager  (was: 
The entity description labels are considered not used by the Label Manager)

> Some labels are considered not used by the Label Manager
> 
>
> Key: OFBIZ-8154
> URL: https://issues.apache.org/jira/browse/OFBIZ-8154
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> As I said in my r1759457 commit comment:
> bq. We have 5237 "Not Used Labels". I wondered if they were all real, I just 
> checked some an indeed, they were not used.  But there are also a huge bunch 
> of *.description.* labels which certainly make sense. I'll remove them from 
> the "Only Not Used Labels" result in another Jira I'll create
> Here is the promised Jira



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-8154) The entity description labels are considered not used by the Label Manager

2016-10-07 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-8154:
--

Assignee: (was: Jacques Le Roux)

> The entity description labels are considered not used by the Label Manager
> --
>
> Key: OFBIZ-8154
> URL: https://issues.apache.org/jira/browse/OFBIZ-8154
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> As I said in my r1759457 commit comment:
> bq. We have 5237 "Not Used Labels". I wondered if they were all real, I just 
> checked some an indeed, they were not used.  But there are also a huge bunch 
> of *.description.* labels which certainly make sense. I'll remove them from 
> the "Only Not Used Labels" result in another Jira I'll create
> Here is the promised Jira



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-8154) Some labels are considered not used by the Label Manager

2016-10-07 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-8154:
--

Assignee: (was: Jacques Le Roux)

> Some labels are considered not used by the Label Manager
> 
>
> Key: OFBIZ-8154
> URL: https://issues.apache.org/jira/browse/OFBIZ-8154
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> As I said in my r1759457 commit comment:
> bq. We have 5237 "Not Used Labels". I wondered if they were all real, I just 
> checked some an indeed, they were not used.  But there are also a huge bunch 
> of *.description.* labels which certainly make sense. I'll remove them from 
> the "Only Not Used Labels" result in another Jira I'll create
> Here is the promised Jira



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-8348) cannot edit shopping list for ecommerce and ecomseo

2016-10-07 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-8348.
--
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Thanks Wai for report, Pawan for patch

Collaboration at its best :)

Pawan your patch is in trunk r1763686  

I don't backport, you can't even get to editShoppingList in R14 & 15, you 
always get stuck to login page. At least that's what I got locally, and I'm fed 
up of shawing the yak, see: I don't even put my favourite gif :(


> cannot edit shopping list for ecommerce and ecomseo
> ---
>
> Key: OFBIZ-8348
> URL: https://issues.apache.org/jira/browse/OFBIZ-8348
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8348.patch
>
>
> go to https://localhost:8443/ecomseo
> login as DemoCustomer
> go to https://localhost:8443/ecomseo/editShoppingList
> create 2 shopping lists
> ofbiz shows the 2 shopping list. but you cannot select the first shopping 
> list for editing



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-8345) popup calendar fails for ecomseo et ecommerce

2016-10-06 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-8345:
--

Assignee: Jacques Le Roux

> popup calendar fails for ecomseo et ecommerce
> -
>
> Key: OFBIZ-8345
> URL: https://issues.apache.org/jira/browse/OFBIZ-8345
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Jacques Le Roux
>
> go to https://localhost:8443/ecomseo/editShoppingList
> create a new shopping list
> make changes to "Shopping List Reorder" pane by clicking on date icon.
> nothing happens



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8345) popup calendar fails for ecomseo et ecommerce

2016-10-06 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551816#comment-15551816
 ] 

Jacques Le Roux commented on OFBIZ-8345:


Thanks for report Wai.

This is not specific to ecomseo and exists also in ecommerce. 

It seems to be due to a regression introduced with 
http://svn.apache.org/viewvc?view=revision=1721092

But when I (only) revert those 2 lines I get this error:
bq. Type check failed for field [createShoppingListRecurrence.startDateTime]; 
expected type is [Timestamp]; actual type is [java.util.LinkedList]

Could you please continue from this?

Note: also in ecomseo and ecommerce you can't can't edit a shopping list (top 
"Edit" button). It works at 
https://localhost:8443/partymgr/control/updateShoppingList. Could you please 
create another Jira for that?

> popup calendar fails for ecomseo et ecommerce
> -
>
> Key: OFBIZ-8345
> URL: https://issues.apache.org/jira/browse/OFBIZ-8345
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Jacques Le Roux
>
> go to https://localhost:8443/ecomseo/editShoppingList
> create a new shopping list
> make changes to "Shopping List Reorder" pane by clicking on date icon.
> nothing happens



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8348) cannot edit shopping list for ecommerce and ecomseo

2016-10-07 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15554959#comment-15554959
 ] 

Jacques Le Roux commented on OFBIZ-8348:


A small improvement has been done at r1763754

> cannot edit shopping list for ecommerce and ecomseo
> ---
>
> Key: OFBIZ-8348
> URL: https://issues.apache.org/jira/browse/OFBIZ-8348
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8348.patch
>
>
> go to https://localhost:8443/ecomseo
> login as DemoCustomer
> go to https://localhost:8443/ecomseo/editShoppingList
> create 2 shopping lists
> ofbiz shows the 2 shopping list. but you cannot select the first shopping 
> list for editing



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8337) Refactor and simplify the startup sequence in OFBiz

2016-10-05 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549641#comment-15549641
 ] 

Jacques Le Roux commented on OFBIZ-8337:


Was http://svn.apache.org/viewvc?rev=1076529=rev on HipChat

> Refactor and simplify the startup sequence in OFBiz
> ---
>
> Key: OFBIZ-8337
> URL: https://issues.apache.org/jira/browse/OFBIZ-8337
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base, start
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>Priority: Minor
>
> The startup sequence in OFBiz is highly complex and requires improvements on 
> multiple levels including:
> - The entire classpath buildup logic and 
> org.apache.ofbiz.base.start.Classpath needs to be removed. The original idea 
> of classpath isolation between the components created many more problems than 
> it solved, and right now the classpath construction is the responsibility of 
> the build system.
> - The custom classloader needs to be removed as well together with the 
> classpath mentioned above.
> - The StartupLoader interface should remove the start() method and just have 
> two methods, load and unload.
> - The startup sequence should have only one StartupLoader, not an array of 
> startup loaders. This StartupLoader (implemented as ContainerLoader) is the 
> only class responsible for bootstrapping OFBiz
> - The ContainerLoader needs to be completely refactored, not only to remove 
> the start() method but also to cleanup the very messy logic currently 
> residing there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8337) Refactor and simplify the startup sequence in OFBiz

2016-10-08 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15557680#comment-15557680
 ] 

Jacques Le Roux commented on OFBIZ-8337:


Hi Taher,

Thanks for the details. I reviewed, I like it, nice code. I agree about 
removing old/unused stuff.

I tested, all is OK with me, notably ofbizBackground and terminateOfbiz.

> Refactor and simplify the startup sequence in OFBiz
> ---
>
> Key: OFBIZ-8337
> URL: https://issues.apache.org/jira/browse/OFBIZ-8337
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base, start
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-8337.patch
>
>
> The startup sequence in OFBiz is highly complex and requires improvements on 
> multiple levels including:
> - The entire classpath buildup logic and 
> org.apache.ofbiz.base.start.Classpath needs to be removed. The original idea 
> of classpath isolation between the components created many more problems than 
> it solved, and right now the classpath construction is the responsibility of 
> the build system.
> - The custom classloader needs to be removed as well together with the 
> classpath mentioned above.
> - The StartupLoader interface should remove the start() method and just have 
> two methods, load and unload.
> - The startup sequence should have only one StartupLoader, not an array of 
> startup loaders. This StartupLoader (implemented as ContainerLoader) is the 
> only class responsible for bootstrapping OFBiz
> - The ContainerLoader needs to be completely refactored, not only to remove 
> the start() method but also to cleanup the very messy logic currently 
> residing there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8056) Maximise the utilisation of the Label CommonProduct in various accounting forms

2016-09-21 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509669#comment-15509669
 ] 

Jacques Le Roux commented on OFBIZ-8056:


That we have already discussed it and don't seem to agree. So we could possibly 
create a thread in dev ML, as you suggested, to discuss it again or let this as 
is. To be frank, my goal was to close all subtask (so this one included) after 
Pierre himself closed the main task as "Works for me", not sure it was irony or 
not.

> Maximise the utilisation of the Label CommonProduct in various accounting 
> forms
> ---
>
> Key: OFBIZ-8056
> URL: https://issues.apache.org/jira/browse/OFBIZ-8056
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Minor
>  Labels: labels
> Attachments: OFBIZ-8056-accounting-CommonProduct.patch
>
>
> There are many forms in the accounting component referencing the product. 
> This issue is about applying the CommonProduct label where it is possible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6467) Disentangle themes

2016-09-19 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-6467.
--
Resolution: Not A Problem

This has been abandonned it seems

> Disentangle themes
> --
>
> Key: OFBIZ-6467
> URL: https://issues.apache.org/jira/browse/OFBIZ-6467
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: Bootstrap theme
>Reporter: Pierre Smits
>
> Currently in the branch the two bootstrap styles (Basic and yellow 'Sunrise) 
> are entwined. The effect is that when changes are implemented in one theme 
> they alter the user experience in the other theme.
> It would be better to disentangle the 2 styles into separate themes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6437) Drop-down menus should be defined explicitly

2016-09-19 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-6437.
--
Resolution: Not A Problem

Since the Boostrap seems to have been abandonned this issues no longer stands

> Drop-down menus should be defined explicitly
> 
>
> Key: OFBIZ-6437
> URL: https://issues.apache.org/jira/browse/OFBIZ-6437
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Bootstrap theme
>Reporter: Pierre Smits
>  Labels: drop-down, menu
>
> Currently when a menu has the same name as a menu item in the applications 
> main (appbar) menu and it has TabBar in its name, it is automatically 
> regarded as a dropdown menu.
> See: menu-item in app of catalog:
> {code}
>  target="ListShipmentMethodTypes"/>
> {code}
> and the menu:
> {code}
>  extends-resource="component://common/widget/CommonMenus.xml">
>  title="${uiLabelMap.ProductShipmentMethodTypes}">
> 
> 
>  title="${uiLabelMap.ProductQuantityBreaks}">
> 
> 
>  title="${uiLabelMap.ProductCarrierShipmentMethods}">
> 
> 
> 
> {code}
> This shouldn't be the default behaviour. Drop-down menus should be associated 
> explicitly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6466) Lookup modal window is overlapped by top menu

2016-09-19 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-6466.
--
Resolution: Not A Problem

Since the Boostrap seems to have been abandonned this issues no longer stands

> Lookup modal window is overlapped by top menu
> -
>
> Key: OFBIZ-6466
> URL: https://issues.apache.org/jira/browse/OFBIZ-6466
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: Bootstrap theme
>Reporter: Pierre Smits
> Attachments: Screen Shot 2015-06-06 at 14.30.50.png
>
>
> When opening a lookup window (modal window) the top menu is on top of the 
> modal window.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8293) Remove redundant backend themes

2016-09-19 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503156#comment-15503156
 ] 

Jacques Le Roux commented on OFBIZ-8293:


Here are some discussions you find when looking for "remove theme", I think 
here we really need a new fresh start and not look back.
http://markmail.org/message/boqhok57dzp3zwpe
http://markmail.org/message/34z2a4n3nzymv3bu
http://markmail.org/message/ovdjzmlwn2udqvpm
http://markmail.org/message/lu6uy67oqkydedvl
http://markmail.org/thread/lu6uy67oqkydedvl
We can find much more related discussion, but nothing happened, it's time!

> Remove redundant backend themes
> ---
>
> Key: OFBIZ-8293
> URL: https://issues.apache.org/jira/browse/OFBIZ-8293
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> We already already discussed several times on dev ML to reduce the number of 
> OOTB backend themes and we globally agreed about doing so.
> These themes are still working so we will move them to Attic from where 
> (using svn history) they can be fetch to create expected plugins (tough I'm 
> not sure we can yet create theme-plugins but this is expected)
> If nobody disagree I'll do so in few days...
> BTW the themes I expect to remove in a 1st phase are:
> # bizzness time, still not complete after several years see OFBIZ-2398
> # BlueLight, it's subsumed by Tomahawk which is the last variant of this 
> group and more complete
> # Dropping Crumbs, it's subsumed by Tomahawk which is the last variant of 
> this group and more complete
> # 3 instances of Rainbow Stone, we need to collectively decide which ones



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-8293) Remove redundant backend themes

2016-09-19 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-8293:
---
Description: 
We already already discussed several times on dev ML to reduce the number of 
OOTB backend themes and we globally agreed about doing so.

These themes are still working so we will move them to Attic from where (using 
svn history) they can be fetch to create expected plugins (tough I'm not sure 
we can yet create theme-plugins but this is expected)

If nobody disagree I'll do so in few days...

BTW the themes I expect to remove in a 1st phase are:
# bizzness time, still not complete after several years see OFBIZ-2398
# BlueLight, it's subsumed by Tomahawk which the last variants and more complete
# Dropping Crumbs, it's subsumed by Tomahawk which the last variants and more 
complete
# 3 instances of Rainbow Stone, we need to collectively decide which ones


  was:
We already already discussed several times on dev ML to reduce the number of 
OOTB themes and we globally agreed about doing so.

These themes are still working so we will move them to Attic from where (using 
svn history) they can be fetch to create expected plugins (tough I'm not sure 
we can yet create theme-plugins but this is expected)

If nobody disagree I'll do so in few days...

BTW the themes I expect to remove in a 1st phase are:



> Remove redundant backend themes
> ---
>
> Key: OFBIZ-8293
> URL: https://issues.apache.org/jira/browse/OFBIZ-8293
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> We already already discussed several times on dev ML to reduce the number of 
> OOTB backend themes and we globally agreed about doing so.
> These themes are still working so we will move them to Attic from where 
> (using svn history) they can be fetch to create expected plugins (tough I'm 
> not sure we can yet create theme-plugins but this is expected)
> If nobody disagree I'll do so in few days...
> BTW the themes I expect to remove in a 1st phase are:
> # bizzness time, still not complete after several years see OFBIZ-2398
> # BlueLight, it's subsumed by Tomahawk which the last variants and more 
> complete
> # Dropping Crumbs, it's subsumed by Tomahawk which the last variants and more 
> complete
> # 3 instances of Rainbow Stone, we need to collectively decide which ones



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8293) Remove redundant backend themes

2016-09-19 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503142#comment-15503142
 ] 

Jacques Le Roux commented on OFBIZ-8293:


You were too fast with your comment, we crossed online :)

I'll look for the discussion on the dev ML...

> Remove redundant backend themes
> ---
>
> Key: OFBIZ-8293
> URL: https://issues.apache.org/jira/browse/OFBIZ-8293
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> We already already discussed several times on dev ML to reduce the number of 
> OOTB backend themes and we globally agreed about doing so.
> These themes are still working so we will move them to Attic from where 
> (using svn history) they can be fetch to create expected plugins (tough I'm 
> not sure we can yet create theme-plugins but this is expected)
> If nobody disagree I'll do so in few days...
> BTW the themes I expect to remove in a 1st phase are:
> # bizzness time, still not complete after several years see OFBIZ-2398
> # BlueLight, it's subsumed by Tomahawk which the last variants and more 
> complete
> # Dropping Crumbs, it's subsumed by Tomahawk which the last variants and more 
> complete
> # 3 instances of Rainbow Stone, we need to collectively decide which ones



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-8293) Remove redundant backend themes

2016-09-19 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503160#comment-15503160
 ] 

Jacques Le Roux edited comment on OFBIZ-8293 at 9/19/16 11:34 AM:
--

If we need votes, let's go. I think we need at least one for removing "3 
instances of Rainbow Stone" anyway


was (Author: jacques.le.roux):
If we need votes, let's go. I think xe need at least one for removing "3 
instances of Rainbow Stone" anyway

> Remove redundant backend themes
> ---
>
> Key: OFBIZ-8293
> URL: https://issues.apache.org/jira/browse/OFBIZ-8293
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> We already already discussed several times on dev ML to reduce the number of 
> OOTB backend themes and we globally agreed about doing so.
> These themes are still working so we will move them to Attic from where 
> (using svn history) they can be fetch to create expected plugins (tough I'm 
> not sure we can yet create theme-plugins but this is expected)
> If nobody disagree I'll do so in few days...
> BTW the themes I expect to remove in a 1st phase are:
> # bizzness time, still not complete after several years see OFBIZ-2398
> # BlueLight, it's subsumed by Tomahawk which is the last variant of this 
> group and more complete
> # Dropping Crumbs, it's subsumed by Tomahawk which is the last variant of 
> this group and more complete
> # 3 instances of Rainbow Stone, we need to collectively decide which ones



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8293) Remove redundant backend themes

2016-09-19 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503160#comment-15503160
 ] 

Jacques Le Roux commented on OFBIZ-8293:


If we need votes, let's go. I think xe need at least one for removing "3 
instances of Rainbow Stone" anyway

> Remove redundant backend themes
> ---
>
> Key: OFBIZ-8293
> URL: https://issues.apache.org/jira/browse/OFBIZ-8293
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> We already already discussed several times on dev ML to reduce the number of 
> OOTB backend themes and we globally agreed about doing so.
> These themes are still working so we will move them to Attic from where 
> (using svn history) they can be fetch to create expected plugins (tough I'm 
> not sure we can yet create theme-plugins but this is expected)
> If nobody disagree I'll do so in few days...
> BTW the themes I expect to remove in a 1st phase are:
> # bizzness time, still not complete after several years see OFBIZ-2398
> # BlueLight, it's subsumed by Tomahawk which is the last variant of this 
> group and more complete
> # Dropping Crumbs, it's subsumed by Tomahawk which is the last variant of 
> this group and more complete
> # 3 instances of Rainbow Stone, we need to collectively decide which ones



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-8293) Remove redundant themes

2016-09-19 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-8293:
---
Description: 
We already already discussed several times on dev ML to reduce the number of 
OOTB themes and we globally agreed about doing so.

These themes are still working so we will move them to Attic from where (using 
svn history) they can be fetch to create expected plugins (tough I'm not sure 
we can yet create theme-plugins but this is expected)

If nobody disagree I'll do so in few days...

BTW the themes I expect to remove in a 1st phase are:


  was:
We already already discussed several times on dev ML to reduce the number of 
OOTB themes and we globally agreed about doing so.

These themes are still working so we will move them to Attic from where (using 
svn history) they can be fetch to create expected plugins (tough I'm not sure 
we can yet create theme-plugins but this is expected)

If nobody disagree I'll do so in few days...


> Remove redundant themes
> ---
>
> Key: OFBIZ-8293
> URL: https://issues.apache.org/jira/browse/OFBIZ-8293
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> We already already discussed several times on dev ML to reduce the number of 
> OOTB themes and we globally agreed about doing so.
> These themes are still working so we will move them to Attic from where 
> (using svn history) they can be fetch to create expected plugins (tough I'm 
> not sure we can yet create theme-plugins but this is expected)
> If nobody disagree I'll do so in few days...
> BTW the themes I expect to remove in a 1st phase are:



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-8293) Remove redundant backend themes

2016-09-19 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-8293:
---
Summary: Remove redundant backend themes  (was: Remove redundant themes)

> Remove redundant backend themes
> ---
>
> Key: OFBIZ-8293
> URL: https://issues.apache.org/jira/browse/OFBIZ-8293
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> We already already discussed several times on dev ML to reduce the number of 
> OOTB themes and we globally agreed about doing so.
> These themes are still working so we will move them to Attic from where 
> (using svn history) they can be fetch to create expected plugins (tough I'm 
> not sure we can yet create theme-plugins but this is expected)
> If nobody disagree I'll do so in few days...
> BTW the themes I expect to remove in a 1st phase are:



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-8293) Remove redundant backend themes

2016-09-19 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-8293:
---
Description: 
We already already discussed several times on dev ML to reduce the number of 
OOTB backend themes and we globally agreed about doing so.

These themes are still working so we will move them to Attic from where (using 
svn history) they can be fetch to create expected plugins (tough I'm not sure 
we can yet create theme-plugins but this is expected)

If nobody disagree I'll do so in few days...

BTW the themes I expect to remove in a 1st phase are:
# bizzness time, still not complete after several years see OFBIZ-2398
# BlueLight, it's subsumed by Tomahawk which is the last variant of this group 
and more complete
# Dropping Crumbs, it's subsumed by Tomahawk which is the last variant of this 
group and more complete
# 3 instances of Rainbow Stone, we need to collectively decide which ones


  was:
We already already discussed several times on dev ML to reduce the number of 
OOTB backend themes and we globally agreed about doing so.

These themes are still working so we will move them to Attic from where (using 
svn history) they can be fetch to create expected plugins (tough I'm not sure 
we can yet create theme-plugins but this is expected)

If nobody disagree I'll do so in few days...

BTW the themes I expect to remove in a 1st phase are:
# bizzness time, still not complete after several years see OFBIZ-2398
# BlueLight, it's subsumed by Tomahawk which the last variants and more complete
# Dropping Crumbs, it's subsumed by Tomahawk which the last variants and more 
complete
# 3 instances of Rainbow Stone, we need to collectively decide which ones



> Remove redundant backend themes
> ---
>
> Key: OFBIZ-8293
> URL: https://issues.apache.org/jira/browse/OFBIZ-8293
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> We already already discussed several times on dev ML to reduce the number of 
> OOTB backend themes and we globally agreed about doing so.
> These themes are still working so we will move them to Attic from where 
> (using svn history) they can be fetch to create expected plugins (tough I'm 
> not sure we can yet create theme-plugins but this is expected)
> If nobody disagree I'll do so in few days...
> BTW the themes I expect to remove in a 1st phase are:
> # bizzness time, still not complete after several years see OFBIZ-2398
> # BlueLight, it's subsumed by Tomahawk which is the last variant of this 
> group and more complete
> # Dropping Crumbs, it's subsumed by Tomahawk which is the last variant of 
> this group and more complete
> # 3 instances of Rainbow Stone, we need to collectively decide which ones



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8293) Remove redundant backend themes

2016-09-20 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507026#comment-15507026
 ] 

Jacques Le Roux commented on OFBIZ-8293:


Why one theme only? How can users test the theme change with only one theme? 

> Remove redundant backend themes
> ---
>
> Key: OFBIZ-8293
> URL: https://issues.apache.org/jira/browse/OFBIZ-8293
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> We already already discussed several times on dev ML to reduce the number of 
> OOTB backend themes and we globally agreed about doing so.
> These themes are still working so we will move them to Attic from where 
> (using svn history) they can be fetch to create expected plugins (tough I'm 
> not sure we can yet create theme-plugins but this is expected)
> If nobody disagree I'll do so in few days...
> BTW the themes I expect to remove in a 1st phase are:
> # bizzness time, still not complete after several years see OFBIZ-2398
> # BlueLight, it's subsumed by Tomahawk which is the last variant of this 
> group and more complete
> # Dropping Crumbs, it's subsumed by Tomahawk which is the last variant of 
> this group and more complete
> # 3 instances of Rainbow Stone, we need to collectively decide which ones



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8056) Maximise the utilisation of the Label CommonProduct in various accounting forms

2016-09-21 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509758#comment-15509758
 ] 

Jacques Le Roux commented on OFBIZ-8056:


Please help yourself. BTW what do you think about the main task resolution with 
"Works for me?"

> Maximise the utilisation of the Label CommonProduct in various accounting 
> forms
> ---
>
> Key: OFBIZ-8056
> URL: https://issues.apache.org/jira/browse/OFBIZ-8056
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Minor
>  Labels: labels
> Attachments: OFBIZ-8056-accounting-CommonProduct.patch
>
>
> There are many forms in the accounting component referencing the product. 
> This issue is about applying the CommonProduct label where it is possible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6711) Have configuration options regarding widgets

2016-09-21 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509681#comment-15509681
 ] 

Jacques Le Roux commented on OFBIZ-6711:


What I said in my 2 last comments there. There are some Jiras entangled and we 
need to begin by the starting point.

> Have configuration options regarding widgets
> 
>
> Key: OFBIZ-6711
> URL: https://issues.apache.org/jira/browse/OFBIZ-6711
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS, ALL COMPONENTS
>Reporter: Pierre Smits
> Attachments: OFBIZ-6711-widget.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-8056) Maximise the utilisation of the Label CommonProduct in various accounting forms

2016-09-21 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509669#comment-15509669
 ] 

Jacques Le Roux edited comment on OFBIZ-8056 at 9/21/16 12:20 PM:
--

That we have already discussed it and don't seem to agree. So we could possibly 
create a thread in dev ML, as you suggested, to discuss it again or let this as 
is. To be frank, my goal was to close all subtasks (so this one included) after 
Pierre himself closed the main task as "Works for me", not sure it was irony or 
not.


was (Author: jacques.le.roux):
That we have already discussed it and don't seem to agree. So we could possibly 
create a thread in dev ML, as you suggested, to discuss it again or let this as 
is. To be frank, my goal was to close all subtask (so this one included) after 
Pierre himself closed the main task as "Works for me", not sure it was irony or 
not.

> Maximise the utilisation of the Label CommonProduct in various accounting 
> forms
> ---
>
> Key: OFBIZ-8056
> URL: https://issues.apache.org/jira/browse/OFBIZ-8056
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Minor
>  Labels: labels
> Attachments: OFBIZ-8056-accounting-CommonProduct.patch
>
>
> There are many forms in the accounting component referencing the product. 
> This issue is about applying the CommonProduct label where it is possible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-8301) The state dropdown not ordered alphabetically on the create/edit address screen of related components

2016-09-21 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-8301:
---
Attachment: Image4.png

Sorry Supatthra, but after applying you patch I still see UK (GBR) "states" 
still unsorted at some point: !Image4.png!

> The state dropdown not ordered alphabetically on the create/edit address 
> screen of related components
> -
>
> Key: OFBIZ-8301
> URL: https://issues.apache.org/jira/browse/OFBIZ-8301
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Supatthra Nawicha
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Trunk
>
> Attachments: Image4.png, OFBIZ-8301.patch
>
>
> I have found this issue when I try to create a new customer from the party 
> manager. Then I try to select the state of UK but I see the state is not 
> order alphabetically. 
> I have check on the getAssociatedStateList service and it provide the 
> listOrderBy parameter for order the value on the state dropdown but the 
> getDependentDropdownValues function on javascript does not send the 
> listOrderBy parameter to the service. 
> {code:title=framework/common/src/main/java/org/apache/ofbiz/common/CommonWorkers.java|borderStyle=solid}
> public static List getAssociatedStateList(Delegator delegator, 
> String country, String listOrderBy) {
> if (UtilValidate.isEmpty(country)) {
> // Load the system default country
> country = EntityUtilProperties.getPropertyValue("general", 
> "country.geo.id.default", delegator);
> }
> if (UtilValidate.isEmpty(listOrderBy)) {
> listOrderBy = "geoId";
> }
> List sortList = UtilMisc.toList(listOrderBy);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default

2016-09-18 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15500896#comment-15500896
 ] 

Jacques Le Roux edited comment on OFBIZ-8250 at 9/18/16 12:23 PM:
--

My point is we just need to add ignore_missing=true in #include directives in 
footers and ignore this patch.

http://freemarker.org/docs/ref_directive_include.html


was (Author: jacques.le.roux):
My point is we just need to add ignore_missing="true" in #include directives in 
footers and ignore this patch.

http://freemarker.org/docs/ref_directive_include.html

> SvnInfo.ftl and GitInfo.ftl are not generated by default
> 
>
> Key: OFBIZ-8250
> URL: https://issues.apache.org/jira/browse/OFBIZ-8250
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8250-2.patch, OFBIZ-8250.patch
>
>
> The two files are not generated which results in an FTL stacktrace in the 
> footer of the backend applications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (OFBIZ-7117) LookupAccount search screen 'Find' button redirect to Lookup Group

2016-09-18 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-7117:
---
Comment: was deleted

(was: BTW should we not close?)

> LookupAccount search screen 'Find' button redirect to Lookup Group
> --
>
> Key: OFBIZ-7117
> URL: https://issues.apache.org/jira/browse/OFBIZ-7117
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>Assignee: Nicolas Malin
>Priority: Minor
>
> How to reproduce :
> 1) Go to a person party profile : i.e. 
> https://localhost:8443/partymgr/control/viewprofile?partyId=admin
> 2) Click on 'Create New' from the 'List Related Accounts' section
> 3) Click on the 'Look up button' (for searching through the account party id)
> 4) Notice the title of the pop-up : "Lookup Party with the role Account" and 
> the limited number of result.Lookup Party with the role Account.
> 5) Click on the 'Find' button (empty search)
> 6) Notice the new title "Lookup Group" and the new set of result
> Root of the behaviour :
> In "ofbiz/applications/party/widget/partymgr/LookupScreens.xml", there is the 
> definition of the "LookupAccount" screen. This screen is the pop-up showing 
> up when you click on the 'Lookup button' . It includes two forms :
> {code} location="component://party/widget/partymgr/LookupForms.xml"/>{code}
> and
> {code} location="component://party/widget/partymgr/LookupForms.xml"/>{code}
> The first one, is the one used for the search when you click on the 'Find' 
> button. By looking at this form's code, we can see that its target is the 
> "LookupPartyGroup" screen. So when you click on the 'Find' button, a 
> different screen is loaded and the title and the behaviour of the pop-up is 
> modified. This screen is composed from the two same forms than the original 
> one.
> Solution ? :
> I don't know if it's possible to overload the target of a form when it's 
> called but if it is possible, then we may call the same form with the target 
> "LookupAccount". If not, I think we need to create another form with the 
> target "LookupAccount".
> Thanks,
> Florian



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


<    1   2   3   4   5   6   7   8   9   10   >