[jira] [Assigned] (OFBIZ-12005) Edit supplier product is not consistent

2020-10-04 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-12005:
--

Assignee: Akash Jain

> Edit supplier product is not consistent
> ---
>
> Key: OFBIZ-12005
> URL: https://issues.apache.org/jira/browse/OFBIZ-12005
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Major
>
> Edit supplier product is not consistent (Catalog > Product > Suppliers); 
> either there should be editable fields or open separate form with editable 
> fields when click on Edit button.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-12010) Tags page improvements

2020-10-04 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-12010:
--

Assignee: Akash Jain

> Tags page improvements
> --
>
> Key: OFBIZ-12010
> URL: https://issues.apache.org/jira/browse/OFBIZ-12010
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
>
> Improvements on Tags page (Catalog > Product > Tags),
>  * back button is missing
>  * New virtual product option should available same as new product option



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-12013) Create button should be removed from create screen of various Catalog features

2020-09-26 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-12013:
--

Assignee: Akash Jain  (was: Kirti Arora)

> Create button should be removed from create screen of various Catalog features
> --
>
> Key: OFBIZ-12013
> URL: https://issues.apache.org/jira/browse/OFBIZ-12013
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product/catalog
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12013) Create button should be removed from create screen of various Catalog features

2020-09-12 Thread Akash Jain (Jira)
Akash Jain created OFBIZ-12013:
--

 Summary: Create button should be removed from create screen of 
various Catalog features
 Key: OFBIZ-12013
 URL: https://issues.apache.org/jira/browse/OFBIZ-12013
 Project: OFBiz
  Issue Type: Sub-task
  Components: product/catalog
Reporter: Akash Jain
Assignee: Akash Jain






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12012) Display image for image category content

2020-09-12 Thread Akash Jain (Jira)
Akash Jain created OFBIZ-12012:
--

 Summary: Display image for image category content
 Key: OFBIZ-12012
 URL: https://issues.apache.org/jira/browse/OFBIZ-12012
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Reporter: Akash Jain
Assignee: Akash Jain


Image should be shown for image category content into Update Category Content 
Assoc (Catalog > Categories > Content) 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-12003) Missing image upload option in creating product image content

2020-09-12 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194731#comment-17194731
 ] 

Akash Jain edited comment on OFBIZ-12003 at 9/12/20, 1:03 PM:
--

Hello [~jleroux], sorry for less detail. Here is the steps,
 # Go to Catalog > Product > Content
 # Select 'Image' product content type in Create New Product Content and click 
'Prepare Create' button

Edit Product Content form will open. Here image upload option is missing 
(available for other image product content type, like, Image - Additional View 
1)


was (Author: akash.jain):
Hello [~jleroux], sorry for less details. Here is the steps,
 # Go to Catalog > Product > Content
 # Select 'Image' product content type in Create New Product Content and click 
'Prepare Create' button

Edit Product Content form will open. Here image upload option is missing 
(available for other image product content type, like, Image - Additional View 
1)

> Missing image upload option in creating product image content 
> --
>
> Key: OFBIZ-12003
> URL: https://issues.apache.org/jira/browse/OFBIZ-12003
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Major
>
> Missing image/file upload option when creating image content for product.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12003) Missing image upload option in creating product image content

2020-09-12 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194731#comment-17194731
 ] 

Akash Jain commented on OFBIZ-12003:


Hello [~jleroux], sorry for less details. Here is the steps,
 # Go to Catalog > Product > Content
 # Select 'Image' product content type in Create New Product Content and click 
'Prepare Create' button

Edit Product Content form will open. Here image upload option is missing 
(available for other image product content type, like, Image - Additional View 
1)

> Missing image upload option in creating product image content 
> --
>
> Key: OFBIZ-12003
> URL: https://issues.apache.org/jira/browse/OFBIZ-12003
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Major
>
> Missing image/file upload option when creating image content for product.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12003) Missing image upload option in creating product image content

2020-09-12 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-12003:
---
Description: Missing image/file upload option when creating image content 
for product.
Environment: (was: Missing image/file upload option when creating image 
content for product.)

> Missing image upload option in creating product image content 
> --
>
> Key: OFBIZ-12003
> URL: https://issues.apache.org/jira/browse/OFBIZ-12003
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Major
>
> Missing image/file upload option when creating image content for product.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12011) Error in creating category image content

2020-09-12 Thread Akash Jain (Jira)
Akash Jain created OFBIZ-12011:
--

 Summary: Error in creating category image content
 Key: OFBIZ-12011
 URL: https://issues.apache.org/jira/browse/OFBIZ-12011
 Project: OFBiz
  Issue Type: Bug
  Components: product
Reporter: Akash Jain
Assignee: Akash Jain


Getting error when creating image content (Catalog > Categories > Content) for 
category.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12007) Product Page depends on ecommerce plugin

2020-09-12 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-12007.
--
Resolution: Duplicate

> Product Page depends on ecommerce plugin
> 
>
> Key: OFBIZ-12007
> URL: https://issues.apache.org/jira/browse/OFBIZ-12007
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Major
>
> Product Page is depend on ecommerce plugin; if ecommerce plugin not available 
> then showing error.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-12007) Product Page depends on ecommerce plugin

2020-09-12 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-12007:
--

Assignee: Akash Jain

> Product Page depends on ecommerce plugin
> 
>
> Key: OFBIZ-12007
> URL: https://issues.apache.org/jira/browse/OFBIZ-12007
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Major
>
> Product Page is depend on ecommerce plugin; if ecommerce plugin not available 
> then showing error.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12009) No Tags on New Virtual Product page

2020-09-12 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-12009:
---
Description: Tags option should not be available on new virtual product 
(Catalog > Product > New Virtual Product) page.  (was: Tags option should not 
be available on new virtual product page.)

> No Tags on New Virtual Product page
> ---
>
> Key: OFBIZ-12009
> URL: https://issues.apache.org/jira/browse/OFBIZ-12009
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
>
> Tags option should not be available on new virtual product (Catalog > Product 
> > New Virtual Product) page.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12008) New Virtual Product option is missing on new product

2020-09-12 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-12008:
---
Description: New virtual product option is missing on new product (Catalog 
> Product > New Product) page.  (was: New virtual product option is missing on 
new product page.)

> New Virtual Product option is missing on new product
> 
>
> Key: OFBIZ-12008
> URL: https://issues.apache.org/jira/browse/OFBIZ-12008
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
>
> New virtual product option is missing on new product (Catalog > Product > New 
> Product) page.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12010) Tags page improvements

2020-09-12 Thread Akash Jain (Jira)
Akash Jain created OFBIZ-12010:
--

 Summary: Tags page improvements
 Key: OFBIZ-12010
 URL: https://issues.apache.org/jira/browse/OFBIZ-12010
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Reporter: Akash Jain


Improvements on Tags page (Catalog > Product > Tags),
 * back button is missing
 * New virtual product option should available same as new product option



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12009) No Tags on New Virtual Product page

2020-09-12 Thread Akash Jain (Jira)
Akash Jain created OFBIZ-12009:
--

 Summary: No Tags on New Virtual Product page
 Key: OFBIZ-12009
 URL: https://issues.apache.org/jira/browse/OFBIZ-12009
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Reporter: Akash Jain
Assignee: Akash Jain


Tags option should not be available on new virtual product page.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12008) New Virtual Product option is missing on new product

2020-09-12 Thread Akash Jain (Jira)
Akash Jain created OFBIZ-12008:
--

 Summary: New Virtual Product option is missing on new product
 Key: OFBIZ-12008
 URL: https://issues.apache.org/jira/browse/OFBIZ-12008
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Reporter: Akash Jain
Assignee: Akash Jain


New virtual product option is missing on new product page.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12007) Product Page depends on ecommerce plugin

2020-09-12 Thread Akash Jain (Jira)
Akash Jain created OFBIZ-12007:
--

 Summary: Product Page depends on ecommerce plugin
 Key: OFBIZ-12007
 URL: https://issues.apache.org/jira/browse/OFBIZ-12007
 Project: OFBiz
  Issue Type: Bug
  Components: product
Reporter: Akash Jain


Product Page is depend on ecommerce plugin; if ecommerce plugin not available 
then showing error.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12006) Error in Product Party

2020-09-12 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-12006:
---
Attachment: Product_Party_Error.png

> Error in Product Party
> --
>
> Key: OFBIZ-12006
> URL: https://issues.apache.org/jira/browse/OFBIZ-12006
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Major
> Attachments: Product_Party_Error.png
>
>
> Error when creating parties for product, attached screen-shot for the same.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12006) Error in Product Party

2020-09-12 Thread Akash Jain (Jira)
Akash Jain created OFBIZ-12006:
--

 Summary: Error in Product Party
 Key: OFBIZ-12006
 URL: https://issues.apache.org/jira/browse/OFBIZ-12006
 Project: OFBiz
  Issue Type: Bug
  Components: product
Reporter: Akash Jain
Assignee: Akash Jain


Error when creating parties for product, attached screen-shot for the same.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12005) Edit supplier product is not consistent

2020-09-12 Thread Akash Jain (Jira)
Akash Jain created OFBIZ-12005:
--

 Summary: Edit supplier product is not consistent
 Key: OFBIZ-12005
 URL: https://issues.apache.org/jira/browse/OFBIZ-12005
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Reporter: Akash Jain


Edit supplier product is not consistent (Catalog > Product > Suppliers); either 
there should be editable fields or open separate form with editable fields when 
click on Edit button.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12004) Display image for image product content

2020-09-12 Thread Akash Jain (Jira)
Akash Jain created OFBIZ-12004:
--

 Summary: Display image for image product content
 Key: OFBIZ-12004
 URL: https://issues.apache.org/jira/browse/OFBIZ-12004
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Reporter: Akash Jain
Assignee: Akash Jain


Image should be shown for image content into Edit Product Content (Catalog > 
Product > Content) 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12003) Missing image upload option in creating product image content

2020-09-12 Thread Akash Jain (Jira)
Akash Jain created OFBIZ-12003:
--

 Summary: Missing image upload option in creating product image 
content 
 Key: OFBIZ-12003
 URL: https://issues.apache.org/jira/browse/OFBIZ-12003
 Project: OFBiz
  Issue Type: Bug
  Components: product
 Environment: Missing image/file upload option when creating image 
content for product.
Reporter: Akash Jain
Assignee: Akash Jain






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-8429) Unit test case for service - createSimpleTextContent

2020-09-09 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-8429:
-

Assignee: (was: Akash Jain)

> Unit test case for service - createSimpleTextContent
> 
>
> Key: OFBIZ-8429
> URL: https://issues.apache.org/jira/browse/OFBIZ-8429
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Tanmay Muley
>Priority: Minor
>
> Unit test case for service - createSimpleTextContent



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-8538) Unit test case for service - updateSimpleTextContent

2020-09-09 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-8538:
-

Assignee: (was: Akash Jain)

> Unit test case for service - updateSimpleTextContent
> 
>
> Key: OFBIZ-8538
> URL: https://issues.apache.org/jira/browse/OFBIZ-8538
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Akash Jain
>Priority: Minor
> Fix For: Trunk
>
>
> Unit test case for service - updateSimpleTextContent



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-8428) Unit test case for service - updateEmailContent

2020-09-09 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-8428:
-

Assignee: (was: Akash Jain)

> Unit test case for service - updateEmailContent
> ---
>
> Key: OFBIZ-8428
> URL: https://issues.apache.org/jira/browse/OFBIZ-8428
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Tanmay Muley
>Priority: Minor
>
> Unit test case for service - updateEmailContent



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-8427) Unit test case for service - createEmailContent

2020-09-09 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-8427:
-

Assignee: (was: Akash Jain)

> Unit test case for service - createEmailContent
> ---
>
> Key: OFBIZ-8427
> URL: https://issues.apache.org/jira/browse/OFBIZ-8427
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Tanmay Muley
>Priority: Minor
>
> Unit test case for service - createEmailContent



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-7714) Introduce a quick way for adding Purchase Price agreements with Suppliers for any specific product from Catalog

2020-09-09 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-7714:
-

Assignee: Akash Jain

> Introduce a quick way for adding Purchase Price agreements with Suppliers for 
> any specific product from Catalog
> ---
>
> Key: OFBIZ-7714
> URL: https://issues.apache.org/jira/browse/OFBIZ-7714
> Project: OFBiz
>  Issue Type: New Feature
>  Components: product
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
>Assignee: Akash Jain
>Priority: Major
> Attachments: PPA.png
>
>
> Currently new pricing agreements creation takes user to Accounting app where 
> it is quite an long and arduous process. And many a times a buyer or 
> procurement users doesn't have direct accounting permission in case quick 
> pricing agreement needs to be placed with Supplier for specific product(s).
> We can provide a quick option from Catalog >> Product >> Agreement screen 
> over "Purchase" section that could unfold as follows:
> # Have a 'Create Price Agreement' link/button on the 'Purchases' Panel and 
> hitting this link could ask user to enter following very basic parameters:
> #- Party Id From (Default it to facility's owner party id)
> #- Party Id To (show list of suppliers like we show at the time of Purchase 
> Order entry screen)
> #- From Date (default it to show as now() timestamp)
> #- Through Date
> #- Description
> #- Price
> #- Currency
> #- Supplier Product Id
> # Upon successful submission of above details system should create Agreement 
> and AgreementItem & SupplierProduct between Supplier and organization by 
> passing following default values:
> #- Role Type Id From = 'Internal Organization'
> #- Role Type Id To = ''Supplier"
> #- Agreement Type Id = 'Purchase'
> #- Agreement Item Type Id = 'Pricing'
> #- Product Id= ''
> Please refer to attached screenshot for reference placeholder
> !PPA.png|thumbnail!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-6939) Improve primary category association on product creation and update

2020-09-09 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-6939:
-

Assignee: Akash Jain

> Improve primary category association on product creation and update
> ---
>
> Key: OFBIZ-6939
> URL: https://issues.apache.org/jira/browse/OFBIZ-6939
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Akash Jain
>Priority: Major
>
> Currently when the user creates a product and wants to set the primary 
> category he is hindered by the aspect that no category associations exists 
> (as it is a new product). The user must first save the product, and then set 
> on or more categories before he can set the primary category. This takes the 
> user 3 actions:
> * create and save the product
> * create and save a category association
> * update and save the product
> It would deliver a better user experience when the user could select any of 
> the available categories when he creates a new product, and then the system 
> would create the category association when the product is saved.
> Also when the user changes the primary category the system should check 
> whether a category association exists and if not create a new one.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-10350) use of oversized images OOTB --> Products --> Content

2020-09-09 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-10350:
--

Assignee: Akash Jain

> use of oversized images OOTB --> Products --> Content
> -
>
> Key: OFBIZ-10350
> URL: https://issues.apache.org/jira/browse/OFBIZ-10350
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Assignee: Akash Jain
>Priority: Minor
>
> Hi,
>  
> the "Content" tab of product management screen in OOTB displays very large 
> images in a small constrained areas.
> Eg:
> In screen
> [https://demo-stable.ofbiz.apache.org/catalog/control/EditProductContent?productId=GZ-1000]
>  
> there are 2 photos in "Override Simple Fields" section. Both the images are 
> linked
> to respective sizes which is OK. However for display also the image source is
> set as the respective size which IMHO will load larger images  unnecessarily .
> I feel all the thumbs can be created using the same "small" sized image and 
> they can be  linked to  respective sizes ( which is happening already).
> The same problem is more pronounced in "Add Additional Images" section as the 
> thumbnails are linked to the "original" size itself ( which can be huge). I 
> feel there  also theycan/should be linked to the small size.
>  
> regds
> mallah.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11997) redundant line in themes. don't know the consequences.

2020-09-06 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-11997:
--

Assignee: Akash Jain

> redundant line in themes. don't know the consequences.
> --
>
> Key: OFBIZ-11997
> URL: https://issues.apache.org/jira/browse/OFBIZ-11997
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Alex Bodnaru
>Assignee: Akash Jain
>Priority: Major
>  Labels: patch
> Attachments: p-typo.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> one line is duplicated. please remove



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11970) Add to cart is not working for products with selectable features

2020-09-06 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-11970:
--

Assignee: Akash Jain

> Add to cart is not working for products with selectable features
> 
>
> Key: OFBIZ-11970
> URL: https://issues.apache.org/jira/browse/OFBIZ-11970
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Ravi Lodhi
>Assignee: Akash Jain
>Priority: Major
> Attachments: addToCartProductWithVariantExplosionError.png
>
>
> Issue-1: Steps to regenerate:
> 1. Visit the [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main].
>  2. Select the "Giant Widget with feature explosion" from the Popular 
> Categories section on home page. You will be redirected to product detail 
> page.
>  3. Select color and size from the respective dropdowns and click on Add To 
> Cart button.
>  4. Product is not getting added in cart.
> Error on browser console:
> {code:java}
> getJs?name=ProductDetail:52 Uncaught TypeError: Cannot read property 'value' 
> of undefined
>  at addItem (getJs?name=ProductDetail:52)
>  at :1:12
> addItem @ getJs?name=ProductDetail:52
> (anonymous) @ VM1370:1
> {code}
>  
>  
> Expected: Product should be added successfully.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11972) wrong quote marks

2020-09-06 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-11972:
--

Assignee: Akash Jain

> wrong quote marks
> -
>
> Key: OFBIZ-11972
> URL: https://issues.apache.org/jira/browse/OFBIZ-11972
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Assignee: Akash Jain
>Priority: Major
> Attachments: p-typo.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11975) products loaded from xml file don't show in category

2020-09-06 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-11975:
--

Assignee: Akash Jain

> products loaded from xml file don't show in category
> 
>
> Key: OFBIZ-11975
> URL: https://issues.apache.org/jira/browse/OFBIZ-11975
> Project: OFBiz
>  Issue Type: Bug
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Alex Bodnaru
>Assignee: Akash Jain
>Priority: Major
> Attachments: variantinfojs-data.xml
>
>
> i loaded the attached xml (in admin).
> the product (wg3-) shows in the product search in admin.
> it also shows in keyword search in ecomseo.
> the attached file is my example, it loads without error messages.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11986) createPartyGroupRoleAndContactMechs service not working

2020-09-06 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-11986:
--

Assignee: Akash Jain

> createPartyGroupRoleAndContactMechs service not working
> ---
>
> Key: OFBIZ-11986
> URL: https://issues.apache.org/jira/browse/OFBIZ-11986
> Project: OFBiz
>  Issue Type: Bug
>  Components: sfa
>Affects Versions: Trunk
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Major
>
> While researched on ticket OFBIZ-11896 identified that groovy version of 
> createPartyGroupRoleAndContactMechs service (converted from mini lang at rev 
> 8af7cf877583acf100d1229260e62fe7f4c92563 ) is not working. Identify these two 
> reasons,
>  # resolvePartyGroupMap called incorrectly
>  # resolvePostalAddressMap and resolveTelecomNumberMap implemented 
> incorrectly as 'postalAddress' and 'telecomNumber' map processor not 
> available into PartyMapProcs.xml.
> There may be more reasons along with these two reasons.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11582) Required fields for party content upload are not checked

2020-09-06 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-11582:
--

Assignee: Akash Jain

> Required fields for party content upload are not checked
> 
>
> Key: OFBIZ-11582
> URL: https://issues.apache.org/jira/browse/OFBIZ-11582
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Akash Jain
>Priority: Major
>
> I noticed that the purpose and the file to upload fields are no longer 
> required. I guess it's because this no longer works 
> http://svn.apache.org/viewvc?view=revision=1087254. Is then the 
> "required error" CSS class missing?
> It works well in old demo (R13) and somehow in stable (R16). I was lost 
> somehow since...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-9790) Billing account entity does not have support to manage the history of contact mech

2020-09-06 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-9790:
-

Assignee: Akash Jain

> Billing account entity does not have support to manage the history of contact 
> mech
> --
>
> Key: OFBIZ-9790
> URL: https://issues.apache.org/jira/browse/OFBIZ-9790
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Vaibhav Jain
>Assignee: Akash Jain
>Priority: Major
>
> Billing account entity has a field named "contactMechId".
> Actual:
> 1. We can update the postal address of billing account but we do not have the 
> history of a postal address.
> 2. If contact mech of billing account is updated then we do not have the 
> history of last billing account contact mech.
> Expected :
> 1. We should have the history of billing account.
> 2. we can introduce new entity "BillingAccountContactMech" where we can 
> manage the history of billing account contact mech.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11897) Create new Find User Login screen

2020-09-06 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-11897:
--

Assignee: Akash Jain

> Create new Find User Login screen 
> --
>
> Key: OFBIZ-11897
> URL: https://issues.apache.org/jira/browse/OFBIZ-11897
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Akash Jain
>Priority: Minor
>
> Implement new Find User Login screen under webtools/security to facilitate 
> webtools users to find appropriate user login with search parameters.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-10311) Able to change Payment with Received Status to Void

2020-09-06 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-10311:
--

Assignee: Akash Jain

> Able to change Payment with Received Status to Void
> ---
>
> Key: OFBIZ-10311
> URL: https://issues.apache.org/jira/browse/OFBIZ-10311
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
> Environment: https://demo-trunk.ofbiz.apache.org
>Reporter: Aayush jain
>Assignee: Akash Jain
>Priority: Major
>
> Steps:
> 1. Open URL 
> [https://demo-trunk.ofbiz.apache.org/accounting/control/findPayments]
> 2. Navigate to Find Payment 
> 3. Check for Payment with Received Status
> 4. Change the status to void
> Actual Result:
> Status changed successfully
> Expected Result:
> A void transaction is a debit or credit card purchase that is canceled after 
> it has been authorized but before it has been settled. A void transaction 
> does not appear on the customer's account statement, though it might appear 
> in a list of pending transactions when the customer checks their account 
> online.
> Refunds. You can only refund a transaction with a Settling or Settled status. 
> If you need to cancel a transaction that has an Authorized, Submitted for 
> Settlement, or Settlement Pending status, you may be able to issue a void 
> instead. ... PayPal transactions can only be refunded within 180 days of 
> receiving payment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11168) Issue in creating promotion action

2020-09-06 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-11168:
--

Assignee: Akash Jain

> Issue in creating promotion action
> --
>
> Key: OFBIZ-11168
> URL: https://issues.apache.org/jira/browse/OFBIZ-11168
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 18.12, Trunk
>Reporter: Lalit Dashora
>Assignee: Akash Jain
>Priority: Major
> Attachments: customMethodID.png
>
>
> Steps to replicate:
> 1. Navigate to create promotion screen and create a promotion.
> 2. Add a promotion rule.
> 3. Add condition of cart sub-total greater than zero. Create condition.
> 4. In action select X product at Y price and also add the amount.
> 5. Click on create action button.
> 6. System is throwing error as below:
> The Following Errors Occurred:
> Error doing entity-auto operation for entity ProductPromoAction in service 
> createProductPromoAction: org.apache.ofbiz.entity.GenericEntityException: 
> org.apache.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:ProductPromoAction][amount,null()][createdStamp,2019-08-24 
> 09:25:00.139(java.sql.Timestamp)][createdTxStamp,2019-08-24 
> 09:25:00.086(java.sql.Timestamp)][customMethodId,[, 
> PPA_PROD_AMDISC](java.lang.String)][lastUpdatedStamp,2019-08-24 
> 09:25:00.139(java.sql.Timestamp)][lastUpdatedTxStamp,2019-08-24 
> 09:25:00.086(java.sql.Timestamp)][orderAdjustmentTypeId,PROMOTION_ADJUSTMENT(java.lang.String)][partyId,null()][productId,null()][productPromoActionSeqId,10003(java.lang.String)][productPromoId,1(java.lang.String)][productPromoRuleId,1(java.lang.String)][quantity,500(java.math.BigDecimal)][serviceName,null()][useCartQuantity,N(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO 
> OFBIZ.PRODUCT_PROMO_ACTION (PRODUCT_PROMO_ID, PRODUCT_PROMO_RULE_ID, 
> PRODUCT_PROMO_ACTION_SEQ_ID, PRODUCT_PROMO_ACTION_ENUM_ID, CUSTOM_METHOD_ID, 
> ORDER_ADJUSTMENT_TYPE_ID, SERVICE_NAME, QUANTITY, AMOUNT, PRODUCT_ID, 
> PARTY_ID, USE_CART_QUANTITY, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, 
> CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 
> ?, ?, ?, ?) (INSERT on table 'PRODUCT_PROMO_ACTION' caused a violation of 
> foreign key constraint 'PROD_PRACT_CMET' for key ([, PPA_PROD_AMDISC]). The 
> statement has been rolled back.)) (Error while inserting: 
> [GenericEntity:ProductPromoAction][amount,null()][createdStamp,2019-08-24 
> 09:25:00.139(java.sql.Timestamp)][createdTxStamp,2019-08-24 
> 09:25:00.086(java.sql.Timestamp)][customMethodId,[, 
> PPA_PROD_AMDISC](java.lang.String)][lastUpdatedStamp,2019-08-24 
> 09:25:00.139(java.sql.Timestamp)][lastUpdatedTxStamp,2019-08-24 
> 09:25:00.086(java.sql.Timestamp)][orderAdjustmentTypeId,PROMOTION_ADJUSTMENT(java.lang.String)][partyId,null()][productId,null()][productPromoActionSeqId,10003(java.lang.String)][productPromoId,1(java.lang.String)][productPromoRuleId,1(java.lang.String)][quantity,500(java.math.BigDecimal)][serviceName,null()][useCartQuantity,N(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO 
> OFBIZ.PRODUCT_PROMO_ACTION (PRODUCT_PROMO_ID, PRODUCT_PROMO_RULE_ID, 
> PRODUCT_PROMO_ACTION_SEQ_ID, PRODUCT_PROMO_ACTION_ENUM_ID, CUSTOM_METHOD_ID, 
> ORDER_ADJUSTMENT_TYPE_ID, SERVICE_NAME, QUANTITY, AMOUNT, PRODUCT_ID, 
> PARTY_ID, USE_CART_QUANTITY, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, 
> CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 
> ?, ?, ?, ?) (INSERT on table 'PRODUCT_PROMO_ACTION' caused a violation of 
> foreign key constraint 'PROD_PRACT_CMET' for key ([, PPA_PROD_AMDISC]). The 
> statement has been rolled back.)))



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-10845) Product Search Constraint on CountBy...methods

2020-09-06 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-10845:
--

Assignee: Akash Jain

> Product Search Constraint on CountBy...methods
> --
>
> Key: OFBIZ-10845
> URL: https://issues.apache.org/jira/browse/OFBIZ-10845
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release 
> Branch 15.12, Release Branch 16.11, Release Branch 18.12, Release Branch 
> 17.12, Trunk
>Reporter: Ingo Wolfmayr
>Assignee: Akash Jain
>Priority: Minor
>  Labels: search
> Fix For: Release Branch 13.07, Release Branch 14.12, Release 
> Branch 15.12
>
> Attachments: SearchCount.patch
>
>
> If a search constraint like featuresId or categorieId is applied, the 
> CountBy...methods in the ProductSearchSession fail.
> Error: mainProductId field is missing.
> Attached is a patch that fixes the problem.
> *Test:*
>  # Enable LayeredNavigation function in ecommerce module.
>  # Add feature "TEXT_BLACK" to product GZ-1000 as standard feature
>  # Add "ProductSearchSession.searchAddConstraint(new 
> ProductSearch.FeatureConstraint("TEXT_BLACK", true), session);" in 
> LayeredNavigation.groovy before "result = 
> ProductSearchSession.getProductSearchResult(request, delegator, 
> prodCatalogId);"
>  # Navigate to the product via category menu.
>  # --> GZ-1000 should not be visible + no error message



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-10612) Cannot bill to clients that are not Groups

2020-09-06 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-10612:
--

Assignee: Akash Jain

> Cannot bill to clients that are not Groups
> --
>
> Key: OFBIZ-10612
> URL: https://issues.apache.org/jira/browse/OFBIZ-10612
> Project: OFBiz
>  Issue Type: Bug
>  Components: projectmgr
>Affects Versions: 16.11.05
>Reporter: Greg Finlayson
>Assignee: Akash Jain
>Priority: Major
> Attachments: image-2018-10-22-00-44-07-313.png, image.png
>
>
> I cannot bill a project to a client which is not a group
> !image-2018-10-22-00-44-07-313.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-10230) Add agreement management on OrderItemPriceInfo

2020-09-06 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-10230:
--

Assignee: Akash Jain

> Add agreement management on OrderItemPriceInfo
> --
>
> Key: OFBIZ-10230
> URL: https://issues.apache.org/jira/browse/OFBIZ-10230
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Akash Jain
>Priority: Major
> Attachments: OFBIZ-10230.patch
>
>
> When you create an order with an agreement, OrderItemPriceInfo didn't record 
> that the price came from the agreement.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-9339) adding product to purchase order auto assigned PRODUCT_ORDER_ITEM

2020-09-01 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-9339:
--
Priority: Major  (was: Minor)

> adding product to purchase order auto assigned PRODUCT_ORDER_ITEM
> -
>
> Key: OFBIZ-9339
> URL: https://issues.apache.org/jira/browse/OFBIZ-9339
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Akash Jain
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9339.patch
>
>
> When creating a purchase order. Adding an product without specifying the 
> "Item Type" is automatically given value of PRODUCT_ORDER_ITEM. The permitted 
> values should be: ASSET_ORDER_ITEM, SUPPLIES_ORDER_ITEM, INVENTORY_ORDER_ITEM 
> (as shown in the dropdown)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-9339) adding product to purchase order auto assigned PRODUCT_ORDER_ITEM

2020-09-01 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-9339.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

Thanks, [~mbrohl] and [~adityasharma]!

> adding product to purchase order auto assigned PRODUCT_ORDER_ITEM
> -
>
> Key: OFBIZ-9339
> URL: https://issues.apache.org/jira/browse/OFBIZ-9339
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9339.patch
>
>
> When creating a purchase order. Adding an product without specifying the 
> "Item Type" is automatically given value of PRODUCT_ORDER_ITEM. The permitted 
> values should be: ASSET_ORDER_ITEM, SUPPLIES_ORDER_ITEM, INVENTORY_ORDER_ITEM 
> (as shown in the dropdown)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-9339) adding product to purchase order auto assigned PRODUCT_ORDER_ITEM

2020-09-01 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188563#comment-17188563
 ] 

Akash Jain commented on OFBIZ-9339:
---

Thanks, [~jleroux]!

I also like the second option, attached patch for the same.

> adding product to purchase order auto assigned PRODUCT_ORDER_ITEM
> -
>
> Key: OFBIZ-9339
> URL: https://issues.apache.org/jira/browse/OFBIZ-9339
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-9339.patch
>
>
> When creating a purchase order. Adding an product without specifying the 
> "Item Type" is automatically given value of PRODUCT_ORDER_ITEM. The permitted 
> values should be: ASSET_ORDER_ITEM, SUPPLIES_ORDER_ITEM, INVENTORY_ORDER_ITEM 
> (as shown in the dropdown)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-9339) adding product to purchase order auto assigned PRODUCT_ORDER_ITEM

2020-09-01 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-9339:
--
Attachment: OFBIZ-9339.patch

> adding product to purchase order auto assigned PRODUCT_ORDER_ITEM
> -
>
> Key: OFBIZ-9339
> URL: https://issues.apache.org/jira/browse/OFBIZ-9339
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-9339.patch
>
>
> When creating a purchase order. Adding an product without specifying the 
> "Item Type" is automatically given value of PRODUCT_ORDER_ITEM. The permitted 
> values should be: ASSET_ORDER_ITEM, SUPPLIES_ORDER_ITEM, INVENTORY_ORDER_ITEM 
> (as shown in the dropdown)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-9339) adding product to purchase order auto assigned PRODUCT_ORDER_ITEM

2020-09-01 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-9339:
--
Issue Type: Improvement  (was: Bug)
  Priority: Minor  (was: Major)

> adding product to purchase order auto assigned PRODUCT_ORDER_ITEM
> -
>
> Key: OFBIZ-9339
> URL: https://issues.apache.org/jira/browse/OFBIZ-9339
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Akash Jain
>Priority: Minor
>
> When creating a purchase order. Adding an product without specifying the 
> "Item Type" is automatically given value of PRODUCT_ORDER_ITEM. The permitted 
> values should be: ASSET_ORDER_ITEM, SUPPLIES_ORDER_ITEM, INVENTORY_ORDER_ITEM 
> (as shown in the dropdown)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-10302) Display/functionality improvement in findParty of OOTB regarding classification group

2020-09-01 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-10302.
--
Fix Version/s: 17.12.05
   18.12.01
   Resolution: Fixed

Fixed two issues along with improvement reported,
 # Search not working if multiple Classification Group selected.
 # Classification Group not showing in search result.

> Display/functionality  improvement in findParty of OOTB regarding 
> classification group
> --
>
> Key: OFBIZ-10302
> URL: https://issues.apache.org/jira/browse/OFBIZ-10302
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Assignee: Akash Jain
>Priority: Minor
> Fix For: 18.12.01, 17.12.05
>
> Attachments: OFBIZ-10302.patch, OFBIZ-10302.patch, Screenshot 
> 2018-03-21 23-18-40.png, Screenshot 2018-03-21 23-19-06.png
>
>
> If a classification Group exists in system the multi-select dropdown only 
> displays the 
> type id of classification not the description of the classification group. 
> Additionally there seems to be a defect that this filter does not really work
> at all.
>  
> regds
> -- mallah.
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-7249) Error on removing scrum members

2020-09-01 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-7249.
-
Fix Version/s: 17.12.05
   18.12.01
   Resolution: Fixed

> Error on removing scrum members
> ---
>
> Key: OFBIZ-7249
> URL: https://issues.apache.org/jira/browse/OFBIZ-7249
> Project: OFBiz
>  Issue Type: Bug
>  Components: scrum
>Affects Versions: Release Branch 14.12, Release Branch 15.12, Trunk
>Reporter: Anurag Chandak
>Assignee: Akash Jain
>Priority: Major
> Fix For: 18.12.01, 17.12.05
>
> Attachments: OFBIZ-7249.patch, OFBIZ-7249.patch
>
>
> Steps to regenerate:
> - Go to Scrum --> Administration --> Scrum Members
> - Try to remove only those scrum members whose party and role type are 
> similar to product members
> - The following error is shown:
> {code}
> The Following Errors Occurred:
> Error:Error doing entity-auto operation for entity PartyRole in service 
> deletePartyRole: org.ofbiz.entity.GenericEntityException: 
> org.ofbiz.entity.GenericDataSourceException: Exception while deleting the 
> following entity: 
> [GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
>  (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE 
> WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a 
> violation of foreign key constraint 'PROD_RLE_PTYRLE' for key 
> (SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)) (Exception 
> while deleting the following entity: 
> [GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
>  (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE 
> WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a 
> violation of foreign key constraint 'PROD_RLE_PTYRLE' for key 
> (SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)))
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-7249) Error on removing scrum members

2020-09-01 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188330#comment-17188330
 ] 

Akash Jain commented on OFBIZ-7249:
---

Thanks, [~nmalin] and [~jleroux]!

> Error on removing scrum members
> ---
>
> Key: OFBIZ-7249
> URL: https://issues.apache.org/jira/browse/OFBIZ-7249
> Project: OFBiz
>  Issue Type: Bug
>  Components: scrum
>Affects Versions: Release Branch 14.12, Release Branch 15.12, Trunk
>Reporter: Anurag Chandak
>Assignee: Akash Jain
>Priority: Major
> Attachments: OFBIZ-7249.patch, OFBIZ-7249.patch
>
>
> Steps to regenerate:
> - Go to Scrum --> Administration --> Scrum Members
> - Try to remove only those scrum members whose party and role type are 
> similar to product members
> - The following error is shown:
> {code}
> The Following Errors Occurred:
> Error:Error doing entity-auto operation for entity PartyRole in service 
> deletePartyRole: org.ofbiz.entity.GenericEntityException: 
> org.ofbiz.entity.GenericDataSourceException: Exception while deleting the 
> following entity: 
> [GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
>  (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE 
> WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a 
> violation of foreign key constraint 'PROD_RLE_PTYRLE' for key 
> (SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)) (Exception 
> while deleting the following entity: 
> [GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
>  (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE 
> WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a 
> violation of foreign key constraint 'PROD_RLE_PTYRLE' for key 
> (SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)))
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-9419) Remove ProductStoreWorker dependencies on ecommerce email screen forms

2020-09-01 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-9419.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> Remove ProductStoreWorker dependencies on ecommerce email screen forms
> --
>
> Key: OFBIZ-9419
> URL: https://issues.apache.org/jira/browse/OFBIZ-9419
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Taher Alkhateeb
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9419.patch
>
>
> The 
> [ProductStoreWorker|http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/store/ProductStoreWorker.java]
>  has dependencies on ecommerce as shown in below code snippet. This whole 
> logic must be removed properly.
> Also, we need to implement a minimal email screen just to be able to test 
> email functionality with a minimal template.
> {code}
> private static Map defaultProductStoreEmailScreenLocation 
> = new HashMap();
> static {
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_CONFIRM", 
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderConfirmNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_COMPLETE", 
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderCompleteNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_BACKORDER", 
> "component://ecommerce/widget/EmailOrderScreens.xml#BackorderNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_CHANGE", 
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderChangeNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_PAYRETRY", 
> "component://ecommerce/widget/EmailOrderScreens.xml#PaymentRetryNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_ACCEPT", 
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnAccept");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_COMPLETE", 
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnComplete");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_CANCEL", 
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnCancel");
> defaultProductStoreEmailScreenLocation.put("PRDS_GC_PURCHASE", 
> "component://ecommerce/widget/EmailGiftCardScreens.xml#GiftCardPurchase");
> defaultProductStoreEmailScreenLocation.put("PRDS_GC_RELOAD", 
> "component://ecommerce/widget/EmailGiftCardScreens.xml#GiftCardReload");
> defaultProductStoreEmailScreenLocation.put("PRDS_QUO_CONFIRM", 
> "component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteSimple");
> defaultProductStoreEmailScreenLocation.put("PRDS_PWD_RETRIEVE", 
> "component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail");
> defaultProductStoreEmailScreenLocation.put("PRDS_TELL_FRIEND", 
> "component://ecommerce/widget/EmailProductScreens.xml#TellFriend");
> defaultProductStoreEmailScreenLocation.put("PRDS_CUST_REGISTER", 
> "component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail");
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10302) Display/functionality improvement in findParty of OOTB regarding classification group

2020-09-01 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188268#comment-17188268
 ] 

Akash Jain commented on OFBIZ-10302:


Updated ticket type to Bug, because, Find Party not working if search with 
multiple Classification Groups.

> Display/functionality  improvement in findParty of OOTB regarding 
> classification group
> --
>
> Key: OFBIZ-10302
> URL: https://issues.apache.org/jira/browse/OFBIZ-10302
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-10302.patch, OFBIZ-10302.patch, Screenshot 
> 2018-03-21 23-18-40.png, Screenshot 2018-03-21 23-19-06.png
>
>
> If a classification Group exists in system the multi-select dropdown only 
> displays the 
> type id of classification not the description of the classification group. 
> Additionally there seems to be a defect that this filter does not really work
> at all.
>  
> regds
> -- mallah.
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10302) Display/functionality improvement in findParty of OOTB regarding classification group

2020-09-01 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-10302:
---
Issue Type: Bug  (was: Improvement)

> Display/functionality  improvement in findParty of OOTB regarding 
> classification group
> --
>
> Key: OFBIZ-10302
> URL: https://issues.apache.org/jira/browse/OFBIZ-10302
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-10302.patch, OFBIZ-10302.patch, Screenshot 
> 2018-03-21 23-18-40.png, Screenshot 2018-03-21 23-19-06.png
>
>
> If a classification Group exists in system the multi-select dropdown only 
> displays the 
> type id of classification not the description of the classification group. 
> Additionally there seems to be a defect that this filter does not really work
> at all.
>  
> regds
> -- mallah.
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-9339) adding product to purchase order auto assigned PRODUCT_ORDER_ITEM

2020-08-31 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187976#comment-17187976
 ] 

Akash Jain commented on OFBIZ-9339:
---

I researched around it and confirm that PRODUCT_ORDER_ITEM will be default if 
order item type not selected for purchase order. So, there are two ways to fix 
this issue either add 'PRODUCT_ORDER_ITEM' as an option in drop-down or simply 
show a tooltip, like, PRODUCT_ORDER_ITEM will be default / Default value will 
be PRODUCT_ORDER_ITEM / similar...

> adding product to purchase order auto assigned PRODUCT_ORDER_ITEM
> -
>
> Key: OFBIZ-9339
> URL: https://issues.apache.org/jira/browse/OFBIZ-9339
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Akash Jain
>Priority: Major
>
> When creating a purchase order. Adding an product without specifying the 
> "Item Type" is automatically given value of PRODUCT_ORDER_ITEM. The permitted 
> values should be: ASSET_ORDER_ITEM, SUPPLIES_ORDER_ITEM, INVENTORY_ORDER_ITEM 
> (as shown in the dropdown)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-7249) Error on removing scrum members

2020-08-31 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187935#comment-17187935
 ] 

Akash Jain commented on OFBIZ-7249:
---

Attached patch to fix reported issue.

> Error on removing scrum members
> ---
>
> Key: OFBIZ-7249
> URL: https://issues.apache.org/jira/browse/OFBIZ-7249
> Project: OFBiz
>  Issue Type: Bug
>  Components: scrum
>Affects Versions: Release Branch 14.12, Release Branch 15.12, Trunk
>Reporter: Anurag Chandak
>Assignee: Akash Jain
>Priority: Major
> Attachments: OFBIZ-7249.patch, OFBIZ-7249.patch
>
>
> Steps to regenerate:
> - Go to Scrum --> Administration --> Scrum Members
> - Try to remove only those scrum members whose party and role type are 
> similar to product members
> - The following error is shown:
> {code}
> The Following Errors Occurred:
> Error:Error doing entity-auto operation for entity PartyRole in service 
> deletePartyRole: org.ofbiz.entity.GenericEntityException: 
> org.ofbiz.entity.GenericDataSourceException: Exception while deleting the 
> following entity: 
> [GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
>  (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE 
> WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a 
> violation of foreign key constraint 'PROD_RLE_PTYRLE' for key 
> (SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)) (Exception 
> while deleting the following entity: 
> [GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
>  (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE 
> WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a 
> violation of foreign key constraint 'PROD_RLE_PTYRLE' for key 
> (SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)))
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-7249) Error on removing scrum members

2020-08-31 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-7249:
--
Attachment: OFBIZ-7249.patch

> Error on removing scrum members
> ---
>
> Key: OFBIZ-7249
> URL: https://issues.apache.org/jira/browse/OFBIZ-7249
> Project: OFBiz
>  Issue Type: Bug
>  Components: scrum
>Affects Versions: Release Branch 14.12, Release Branch 15.12, Trunk
>Reporter: Anurag Chandak
>Assignee: Akash Jain
>Priority: Major
> Attachments: OFBIZ-7249.patch, OFBIZ-7249.patch
>
>
> Steps to regenerate:
> - Go to Scrum --> Administration --> Scrum Members
> - Try to remove only those scrum members whose party and role type are 
> similar to product members
> - The following error is shown:
> {code}
> The Following Errors Occurred:
> Error:Error doing entity-auto operation for entity PartyRole in service 
> deletePartyRole: org.ofbiz.entity.GenericEntityException: 
> org.ofbiz.entity.GenericDataSourceException: Exception while deleting the 
> following entity: 
> [GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
>  (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE 
> WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a 
> violation of foreign key constraint 'PROD_RLE_PTYRLE' for key 
> (SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)) (Exception 
> while deleting the following entity: 
> [GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
>  (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE 
> WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a 
> violation of foreign key constraint 'PROD_RLE_PTYRLE' for key 
> (SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)))
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10302) Display/functionality improvement in findParty of OOTB regarding classification group

2020-08-30 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187274#comment-17187274
 ] 

Akash Jain commented on OFBIZ-10302:


Yes, that's true :)

I checked on R17 instance and there is also multi search. So, I think multi 
value dropdown is fine, it will search for single value as well.

Thanks, [~jleroux]!

> Display/functionality  improvement in findParty of OOTB regarding 
> classification group
> --
>
> Key: OFBIZ-10302
> URL: https://issues.apache.org/jira/browse/OFBIZ-10302
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-10302.patch, OFBIZ-10302.patch, Screenshot 
> 2018-03-21 23-18-40.png, Screenshot 2018-03-21 23-19-06.png
>
>
> If a classification Group exists in system the multi-select dropdown only 
> displays the 
> type id of classification not the description of the classification group. 
> Additionally there seems to be a defect that this filter does not really work
> at all.
>  
> regds
> -- mallah.
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-9419) Remove ProductStoreWorker dependencies on ecommerce email screen forms

2020-08-30 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187243#comment-17187243
 ] 

Akash Jain edited comment on OFBIZ-9419 at 8/30/20, 4:45 PM:
-

If ProductStoreEmailSetting data setup properly and added bodyScreenLocation 
correctly then there is no need of 
ProductStoreWorker.getDefaultProductStoreEmailScreenLocation method which used 
a Map to get screen location (hardcoded). Also, there are total 36 rows of 
ProductStoreEmailSetting table and put only 14 hardcoded screen location into 
Map.

I think we are good to remove 
ProductStoreWorker.getDefaultProductStoreEmailScreenLocation method, attached 
patch for the same.

If we want to go with 
ProductStoreWorker.getDefaultProductStoreEmailScreenLocation method then should 
to handle it properly, like,
 – create SystemProperty data for all emailTypes to get screen location instead 
of hardcoded them
 – take care of it for all 36 emailTypes instead 14 emailTypes only

I will remove ProductStoreWorker.getDefaultProductStoreEmailScreenLocation 
method as attached patch soon, thanks!


was (Author: akash.jain):
If ProductStoreEmailSetting data setup properly and added bodyScreenLocation 
correctly then there is no need of 
ProductStoreWorker.getDefaultProductStoreEmailScreenLocation method which used 
a Map to get screen location (hardcoded). Also, there are total 36 rows of 
ProductStoreEmailSetting table and put only 14 hardcoded screen location into 
Map.

I think we are good to remove 
ProductStoreWorker.getDefaultProductStoreEmailScreenLocation method, attached 
patch for the same.

If we want to go with 
ProductStoreWorker.getDefaultProductStoreEmailScreenLocation method then should 
to handle it properly, like,
-- create SystemProperty data for all emailTypes to get screen location instead 
of hardcoded them
-- take care of it for all 36 emailTypes instead 14 emailTypes only

Please put your valuable thoughts else I will remove 
ProductStoreWorker.getDefaultProductStoreEmailScreenLocation method as attached 
patch, thanks!

> Remove ProductStoreWorker dependencies on ecommerce email screen forms
> --
>
> Key: OFBIZ-9419
> URL: https://issues.apache.org/jira/browse/OFBIZ-9419
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Taher Alkhateeb
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-9419.patch
>
>
> The 
> [ProductStoreWorker|http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/store/ProductStoreWorker.java]
>  has dependencies on ecommerce as shown in below code snippet. This whole 
> logic must be removed properly.
> Also, we need to implement a minimal email screen just to be able to test 
> email functionality with a minimal template.
> {code}
> private static Map defaultProductStoreEmailScreenLocation 
> = new HashMap();
> static {
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_CONFIRM", 
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderConfirmNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_COMPLETE", 
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderCompleteNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_BACKORDER", 
> "component://ecommerce/widget/EmailOrderScreens.xml#BackorderNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_CHANGE", 
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderChangeNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_PAYRETRY", 
> "component://ecommerce/widget/EmailOrderScreens.xml#PaymentRetryNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_ACCEPT", 
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnAccept");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_COMPLETE", 
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnComplete");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_CANCEL", 
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnCancel");
> defaultProductStoreEmailScreenLocation.put("PRDS_GC_PURCHASE", 
> "component://ecommerce/widget/EmailGiftCardScreens.xml#GiftCardPurchase");
> defaultProductStoreEmailScreenLocation.put("PRDS_GC_RELOAD", 
> "component://ecommerce/widget/EmailGiftCardScreens.xml#GiftCardReload");
> defaultProductStoreEmailScreenLocation.put("PRDS_QUO_CONFIRM", 
> "component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteSimple");
> defaultProductStoreEmailScreenLocation.put("PRDS_PWD_RETRIEVE", 
> "component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail");
> defaultProductStoreEmailScreenLocation.put("PRDS_TELL_FRIEND", 
> 

[jira] [Commented] (OFBIZ-9419) Remove ProductStoreWorker dependencies on ecommerce email screen forms

2020-08-30 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187243#comment-17187243
 ] 

Akash Jain commented on OFBIZ-9419:
---

If ProductStoreEmailSetting data setup properly and added bodyScreenLocation 
correctly then there is no need of 
ProductStoreWorker.getDefaultProductStoreEmailScreenLocation method which used 
a Map to get screen location (hardcoded). Also, there are total 36 rows of 
ProductStoreEmailSetting table and put only 14 hardcoded screen location into 
Map.

I think we are good to remove 
ProductStoreWorker.getDefaultProductStoreEmailScreenLocation method, attached 
patch for the same.

If we want to go with 
ProductStoreWorker.getDefaultProductStoreEmailScreenLocation method then should 
to handle it properly, like,
-- create SystemProperty data for all emailTypes to get screen location instead 
of hardcoded them
-- take care of it for all 36 emailTypes instead 14 emailTypes only

Please put your valuable thoughts else I will remove 
ProductStoreWorker.getDefaultProductStoreEmailScreenLocation method as attached 
patch, thanks!

> Remove ProductStoreWorker dependencies on ecommerce email screen forms
> --
>
> Key: OFBIZ-9419
> URL: https://issues.apache.org/jira/browse/OFBIZ-9419
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Taher Alkhateeb
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-9419.patch
>
>
> The 
> [ProductStoreWorker|http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/store/ProductStoreWorker.java]
>  has dependencies on ecommerce as shown in below code snippet. This whole 
> logic must be removed properly.
> Also, we need to implement a minimal email screen just to be able to test 
> email functionality with a minimal template.
> {code}
> private static Map defaultProductStoreEmailScreenLocation 
> = new HashMap();
> static {
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_CONFIRM", 
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderConfirmNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_COMPLETE", 
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderCompleteNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_BACKORDER", 
> "component://ecommerce/widget/EmailOrderScreens.xml#BackorderNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_CHANGE", 
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderChangeNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_PAYRETRY", 
> "component://ecommerce/widget/EmailOrderScreens.xml#PaymentRetryNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_ACCEPT", 
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnAccept");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_COMPLETE", 
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnComplete");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_CANCEL", 
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnCancel");
> defaultProductStoreEmailScreenLocation.put("PRDS_GC_PURCHASE", 
> "component://ecommerce/widget/EmailGiftCardScreens.xml#GiftCardPurchase");
> defaultProductStoreEmailScreenLocation.put("PRDS_GC_RELOAD", 
> "component://ecommerce/widget/EmailGiftCardScreens.xml#GiftCardReload");
> defaultProductStoreEmailScreenLocation.put("PRDS_QUO_CONFIRM", 
> "component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteSimple");
> defaultProductStoreEmailScreenLocation.put("PRDS_PWD_RETRIEVE", 
> "component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail");
> defaultProductStoreEmailScreenLocation.put("PRDS_TELL_FRIEND", 
> "component://ecommerce/widget/EmailProductScreens.xml#TellFriend");
> defaultProductStoreEmailScreenLocation.put("PRDS_CUST_REGISTER", 
> "component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail");
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-9419) Remove ProductStoreWorker dependencies on ecommerce email screen forms

2020-08-30 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-9419:
--
Attachment: OFBIZ-9419.patch

> Remove ProductStoreWorker dependencies on ecommerce email screen forms
> --
>
> Key: OFBIZ-9419
> URL: https://issues.apache.org/jira/browse/OFBIZ-9419
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Taher Alkhateeb
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-9419.patch
>
>
> The 
> [ProductStoreWorker|http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/store/ProductStoreWorker.java]
>  has dependencies on ecommerce as shown in below code snippet. This whole 
> logic must be removed properly.
> Also, we need to implement a minimal email screen just to be able to test 
> email functionality with a minimal template.
> {code}
> private static Map defaultProductStoreEmailScreenLocation 
> = new HashMap();
> static {
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_CONFIRM", 
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderConfirmNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_COMPLETE", 
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderCompleteNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_BACKORDER", 
> "component://ecommerce/widget/EmailOrderScreens.xml#BackorderNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_CHANGE", 
> "component://ecommerce/widget/EmailOrderScreens.xml#OrderChangeNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_ODR_PAYRETRY", 
> "component://ecommerce/widget/EmailOrderScreens.xml#PaymentRetryNotice");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_ACCEPT", 
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnAccept");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_COMPLETE", 
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnComplete");
> defaultProductStoreEmailScreenLocation.put("PRDS_RTN_CANCEL", 
> "component://ecommerce/widget/EmailReturnScreens.xml#ReturnCancel");
> defaultProductStoreEmailScreenLocation.put("PRDS_GC_PURCHASE", 
> "component://ecommerce/widget/EmailGiftCardScreens.xml#GiftCardPurchase");
> defaultProductStoreEmailScreenLocation.put("PRDS_GC_RELOAD", 
> "component://ecommerce/widget/EmailGiftCardScreens.xml#GiftCardReload");
> defaultProductStoreEmailScreenLocation.put("PRDS_QUO_CONFIRM", 
> "component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteSimple");
> defaultProductStoreEmailScreenLocation.put("PRDS_PWD_RETRIEVE", 
> "component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail");
> defaultProductStoreEmailScreenLocation.put("PRDS_TELL_FRIEND", 
> "component://ecommerce/widget/EmailProductScreens.xml#TellFriend");
> defaultProductStoreEmailScreenLocation.put("PRDS_CUST_REGISTER", 
> "component://securityext/widget/EmailSecurityScreens.xml#PasswordEmail");
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-10878) Get billing party by parent invoice type

2020-08-30 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-10878.
--
Fix Version/s: Upcoming Branch
   Resolution: Implemented

Committed patch with changes.

> Get billing party by parent invoice type
> 
>
> Key: OFBIZ-10878
> URL: https://issues.apache.org/jira/browse/OFBIZ-10878
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Ingo Wolfmayr
>Assignee: Akash Jain
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: InvoiceworkerImprove.patch
>
>
> The fallback to get the billing party uses the invoicetypeId form the invoice.
> SALES_INVOICE & PURCHASE_INVOICE
> I would propose to use match it against the parentInvoiceTypeID from 
> INVOICE_TYPE
> CUST_RTN_INVOICE a.s.o. will then work as well.
> Patch is attached. Nothing complicated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11929) Fix Literals comparisons with variable to avoid NPE

2020-08-30 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-11929.
--
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> Fix Literals comparisons with variable to avoid NPE
> ---
>
> Key: OFBIZ-11929
> URL: https://issues.apache.org/jira/browse/OFBIZ-11929
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11929_framework.patch, OFBIZ-11929_plugins.patch
>
>
> With respect to our previous effort to fix the inconsistent string 
> comparisons[OFBIZ-9254], we are now creating a new ticket to continue this 
> effort.
> In this ticket, we will cover all the remaining constants comparison with 
> variable that might lead to an NPE.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-10237) The leads which are converted is displayed on the Find lead page.

2020-08-30 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-10237.
--
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> The leads which are converted is displayed on the Find lead page.
> -
>
> Key: OFBIZ-10237
> URL: https://issues.apache.org/jira/browse/OFBIZ-10237
> Project: OFBiz
>  Issue Type: Improvement
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Rubia Elza Joshep
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10237.patch
>
>
> Steps to regenerate:
> 1) Open URL 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads|http://example.com/]
> 2) Create a lead. Check for the lead in Find lead page.
> 3) Convert the lead by clicking on "Create Lead" button. The lead is 
> successfully converted to contact/ Account.
> Actual: The lead which is converted is displayed on the Find lead page.
> Expected: Since the lead is converted to contact/Account it should not be 
> displayed on the Find lead page.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10237) The leads which are converted is displayed on the Find lead page.

2020-08-30 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-10237:
---
Issue Type: Improvement  (was: Bug)
  Priority: Minor  (was: Major)

> The leads which are converted is displayed on the Find lead page.
> -
>
> Key: OFBIZ-10237
> URL: https://issues.apache.org/jira/browse/OFBIZ-10237
> Project: OFBiz
>  Issue Type: Improvement
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Rubia Elza Joshep
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-10237.patch
>
>
> Steps to regenerate:
> 1) Open URL 
> [https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads|http://example.com/]
> 2) Create a lead. Check for the lead in Find lead page.
> 3) Convert the lead by clicking on "Create Lead" button. The lead is 
> successfully converted to contact/ Account.
> Actual: The lead which is converted is displayed on the Find lead page.
> Expected: Since the lead is converted to contact/Account it should not be 
> displayed on the Find lead page.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10302) Display/functionality improvement in findParty of OOTB regarding classification group

2020-08-29 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187095#comment-17187095
 ] 

Akash Jain commented on OFBIZ-10302:


I think Classification Group should be single dropdown instead multi value 
dropdown. If yes, then I will update the patch accordingly. If fine with multi 
value dropdown then attached patch will work.

> Display/functionality  improvement in findParty of OOTB regarding 
> classification group
> --
>
> Key: OFBIZ-10302
> URL: https://issues.apache.org/jira/browse/OFBIZ-10302
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-10302.patch, OFBIZ-10302.patch, Screenshot 
> 2018-03-21 23-18-40.png, Screenshot 2018-03-21 23-19-06.png
>
>
> If a classification Group exists in system the multi-select dropdown only 
> displays the 
> type id of classification not the description of the classification group. 
> Additionally there seems to be a defect that this filter does not really work
> at all.
>  
> regds
> -- mallah.
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10302) Display/functionality improvement in findParty of OOTB regarding classification group

2020-08-29 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-10302:
---
Attachment: OFBIZ-10302.patch

> Display/functionality  improvement in findParty of OOTB regarding 
> classification group
> --
>
> Key: OFBIZ-10302
> URL: https://issues.apache.org/jira/browse/OFBIZ-10302
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-10302.patch, OFBIZ-10302.patch, Screenshot 
> 2018-03-21 23-18-40.png, Screenshot 2018-03-21 23-19-06.png
>
>
> If a classification Group exists in system the multi-select dropdown only 
> displays the 
> type id of classification not the description of the classification group. 
> Additionally there seems to be a defect that this filter does not really work
> at all.
>  
> regds
> -- mallah.
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10302) Display/functionality improvement in findParty of OOTB regarding classification group

2020-08-29 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187090#comment-17187090
 ] 

Akash Jain commented on OFBIZ-10302:


Attached patch to fix reported issue. Along with that also fixed an issue, 
Classification Group not showing in the search result.

> Display/functionality  improvement in findParty of OOTB regarding 
> classification group
> --
>
> Key: OFBIZ-10302
> URL: https://issues.apache.org/jira/browse/OFBIZ-10302
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-10302.patch, Screenshot 2018-03-21 23-18-40.png, 
> Screenshot 2018-03-21 23-19-06.png
>
>
> If a classification Group exists in system the multi-select dropdown only 
> displays the 
> type id of classification not the description of the classification group. 
> Additionally there seems to be a defect that this filter does not really work
> at all.
>  
> regds
> -- mallah.
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10302) Display/functionality improvement in findParty of OOTB regarding classification group

2020-08-29 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-10302:
---
Attachment: OFBIZ-10302.patch

> Display/functionality  improvement in findParty of OOTB regarding 
> classification group
> --
>
> Key: OFBIZ-10302
> URL: https://issues.apache.org/jira/browse/OFBIZ-10302
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-10302.patch, Screenshot 2018-03-21 23-18-40.png, 
> Screenshot 2018-03-21 23-19-06.png
>
>
> If a classification Group exists in system the multi-select dropdown only 
> displays the 
> type id of classification not the description of the classification group. 
> Additionally there seems to be a defect that this filter does not really work
> at all.
>  
> regds
> -- mallah.
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-9350) Deprecate Mini Lang

2020-08-29 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187049#comment-17187049
 ] 

Akash Jain commented on OFBIZ-9350:
---

Hello Team,

We should  proper testing before attaching and committing patch for converting 
mini lang to groovy. Its very critical job and introducing bugs in existing 
functionality. Here are two bugs (there may be more) identified due to 
converting mini lang to groovy, OFBIZ-11986 and OFBIZ-11896.

Its a nice addition, but, need proper testing, thanks!

> Deprecate Mini Lang
> ---
>
> Key: OFBIZ-9350
> URL: https://issues.apache.org/jira/browse/OFBIZ-9350
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: documentation, refactoring
>
> According to the proposal thread in [1] we decided to deprecate mini lang.
> This issue tracks the next steps proposed in the aformentioned thread, namely:
> 1. create a Wiki page for the documentation and description of the migration 
> process and how mini lang will be replaced.
> 2. prominently state in the Wiki that minilang will be deprecated, e.g. in [2]
> 3. put deprecation tags in the corresponding code
> 4. kindly ask contributors with open patches written in mini lang to replace 
> them by Groovy code [3]
> 5. start an initiative to replace existing mini lang code with Groovy code 
> where applicable. This needs some more planning and discussion which parts 
> we'll like to replace with Groovy code and which parts will better be 
> replaced by some kind of DSL. A good starting point can be [4][5][6].
> [1] 
> [https://lists.apache.org/thread.html/253b41060a295b8ab68bc78763cc129fc74b712cf776f8716022097f@%3Cdev.ofbiz.apache.org%3E]
>  [2] 
> [https://cwiki.apache.org/confluence/display/OFBADMIN/Mini+Language+-+minilang+-+simple-method+-+Reference]
>  [3] does anyone know a way to batch comment Jira issues like it is possible 
> in Redmine?
>  [4] 
> [https://cwiki.apache.org/confluence/display/OFBIZ/Groovy+DSL+for+OFBiz+business+logic]
>  [5] 
> [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Tutorial+-+A+Beginners+Development+Guide]
>  [6] [https://cwiki.apache.org/confluence/display/OFBIZ/Coding+Conventions]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11896) Quick Add Lead does not work without group name

2020-08-29 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-11896.
--
Fix Version/s: Upcoming Branch
   Resolution: Fixed

> Quick Add Lead does not work without group name
> ---
>
> Key: OFBIZ-11896
> URL: https://issues.apache.org/jira/browse/OFBIZ-11896
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing/sfa
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11896.patch
>
>
> Steps:
>  # Go to [https://demo-trunk.ofbiz.apache.org/sfa/control/main]
>  # Try to add lead with FirstName and LastName
>  # See error on screen



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11896) Quick Add Lead does not work without group name

2020-08-29 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187045#comment-17187045
 ] 

Akash Jain commented on OFBIZ-11896:


Its working as expected on R17 and R18. This issue is generated when converting 
createLead service from mini lang to groovy.

> Quick Add Lead does not work without group name
> ---
>
> Key: OFBIZ-11896
> URL: https://issues.apache.org/jira/browse/OFBIZ-11896
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing/sfa
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-11896.patch
>
>
> Steps:
>  # Go to [https://demo-trunk.ofbiz.apache.org/sfa/control/main]
>  # Try to add lead with FirstName and LastName
>  # See error on screen



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-9802) PDF creation fails in sendOrderConfirmation service

2020-08-29 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187043#comment-17187043
 ] 

Akash Jain commented on OFBIZ-9802:
---

Thanks, [~jleroux] !

I already verified on R17 and R18; it's working as expected on all the 
instances.

> PDF creation fails in sendOrderConfirmation service
> ---
>
> Key: OFBIZ-9802
> URL: https://issues.apache.org/jira/browse/OFBIZ-9802
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Akash Jain
>Priority: Major
> Fix For: Upcoming Branch
>
>
> After Nicolas fixed OFBIZ-9798, I faced another issue in 
> sendOrderConfirmation:
> {code}
> 2017-10-03 11:32:09,318 |OFBiz-JobQueue-0 |EmailServices 
> |E| Error rendering PDF attachment for email: 
> org.apache.fop.apps.FOPException: org.apache.fop.fo.ValidationException: 
> Document is
> empty (something might be wrong with your XSLT stylesheet).
> javax.xml.transform.TransformerException: 
> org.apache.fop.fo.ValidationException: Document is empty (something might be 
> wrong with your XSLT stylesheet).
> org.apache.fop.apps.FOPException: org.apache.fop.fo.ValidationException: 
> Document is empty (something might be wrong with your XSLT stylesheet).
>at 
> org.apache.ofbiz.webapp.view.ApacheFopWorker.transform(ApacheFopWorker.java:176)
>  ~[ofbiz.jar:?]
>  at 
> org.apache.ofbiz.common.email.EmailServices.sendMailFromScreen(EmailServices.java:558)
>  [ofbiz.jar:?]
> at sun.reflect.GeneratedMethodAccessor215.invoke(Unknown Source) 
> ~[?:?]
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_112]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_112]
>  at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:396)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:227)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>  [ofbiz.jar:?]
>  at 
> org.apache.ofbiz.order.order.OrderServices.sendOrderNotificationScreen(OrderServices.java:2680)
>  [ofbiz.jar:?]
>at 
> org.apache.ofbiz.order.order.OrderServices.sendOrderConfirmNotification(OrderServices.java:2510)
>  [ofbiz.jar:?]
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_112]
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_112]
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_112]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_112]
>  at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:396)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:227)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>  [ofbiz.jar:?]
>  at 
> org.apache.ofbiz.service.job.GenericServiceJob.exec(GenericServiceJob.java:70)
>  [ofbiz.jar:?]
> at org.apache.ofbiz.service.job.AbstractJob.run(AbstractJob.java:87) 
> [ofbiz.jar:?]
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [?:1.8.0_112]
>at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [?:1.8.0_112]
>at java.lang.Thread.run(Thread.java:745) [?:1.8.0_112]
> Caused by: javax.xml.transform.TransformerException: 
> org.apache.fop.fo.ValidationException: Document is empty (something might be 
> wrong with your XSLT stylesheet).
>  at 
> org.apache.xalan.transformer.TransformerIdentityImpl.transform(TransformerIdentityImpl.java:501)
>  ~[xalan-2.7.0.jar:?]
>at 
> org.apache.ofbiz.webapp.view.ApacheFopWorker.transform(ApacheFopWorker.java:174)
>  ~[ofbiz.jar:?]
>  ... 25 more
> Caused by: org.apache.fop.fo.ValidationException: Document is empty 
> (something might be wrong with your XSLT stylesheet).
>   at 
> 

[jira] [Closed] (OFBIZ-11424) createPartyContent not working

2020-08-29 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-11424.
--
Fix Version/s: (was: Upcoming Branch)
   Resolution: Cannot Reproduce

Thanks, [~jleroux]!

> createPartyContent not working
> --
>
> Key: OFBIZ-11424
> URL: https://issues.apache.org/jira/browse/OFBIZ-11424
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Akash Jain
>Priority: Major
>
> go to Party -> search -> select any PartyId -> Party Content
> Create will produce the following error:
> "The Following Errors Occurred:
> layoutEvents.no_files_uploaded"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-9759) Fiscal Gl type is reflecting twice in drop-down of Cost Centers.

2020-08-29 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187017#comment-17187017
 ] 

Akash Jain commented on OFBIZ-9759:
---

Thanks, [~jleroux]!

> Fiscal Gl type is reflecting twice in drop-down of Cost Centers.
> 
>
> Key: OFBIZ-9759
> URL: https://issues.apache.org/jira/browse/OFBIZ-9759
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
> Environment: 
> https://ofbiz-trunk.hotwaxsystems.com/accounting/control/GlAccountBalanceByCostCenter?organizationPartyId=Company
>Reporter: Tejas Khanna
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9759.patch
>
>
> Steps to reproduce:
> 1. Select Accounting from Applications.
> 2. Select Organization GL Settings from Accounting Manager.
> 3. Click on accounting.
> 4. Click on Reports
> 5. Select Cost Centers
> 6. Choose Fiscal Gl Type drop-down.
> Actual result: on selecting Gl Type from drop-down, selected Gl Type is 
> reflecting twice.
> Expected result: Selected value should come only once in drop-down after 
> report generation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-9759) Fiscal Gl type is reflecting twice in drop-down of Cost Centers.

2020-08-29 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-9759.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> Fiscal Gl type is reflecting twice in drop-down of Cost Centers.
> 
>
> Key: OFBIZ-9759
> URL: https://issues.apache.org/jira/browse/OFBIZ-9759
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
> Environment: 
> https://ofbiz-trunk.hotwaxsystems.com/accounting/control/GlAccountBalanceByCostCenter?organizationPartyId=Company
>Reporter: Tejas Khanna
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9759.patch
>
>
> Steps to reproduce:
> 1. Select Accounting from Applications.
> 2. Select Organization GL Settings from Accounting Manager.
> 3. Click on accounting.
> 4. Click on Reports
> 5. Select Cost Centers
> 6. Choose Fiscal Gl Type drop-down.
> Actual result: on selecting Gl Type from drop-down, selected Gl Type is 
> reflecting twice.
> Expected result: Selected value should come only once in drop-down after 
> report generation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-9802) PDF creation fails in sendOrderConfirmation service

2020-08-29 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187012#comment-17187012
 ] 

Akash Jain commented on OFBIZ-9802:
---

Hello [~jleroux], I placed order from front end and getting order confirmation 
email (with attachment) properly without getting reported error.

> PDF creation fails in sendOrderConfirmation service
> ---
>
> Key: OFBIZ-9802
> URL: https://issues.apache.org/jira/browse/OFBIZ-9802
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Akash Jain
>Priority: Major
>
> After Nicolas fixed OFBIZ-9798, I faced another issue in 
> sendOrderConfirmation:
> {code}
> 2017-10-03 11:32:09,318 |OFBiz-JobQueue-0 |EmailServices 
> |E| Error rendering PDF attachment for email: 
> org.apache.fop.apps.FOPException: org.apache.fop.fo.ValidationException: 
> Document is
> empty (something might be wrong with your XSLT stylesheet).
> javax.xml.transform.TransformerException: 
> org.apache.fop.fo.ValidationException: Document is empty (something might be 
> wrong with your XSLT stylesheet).
> org.apache.fop.apps.FOPException: org.apache.fop.fo.ValidationException: 
> Document is empty (something might be wrong with your XSLT stylesheet).
>at 
> org.apache.ofbiz.webapp.view.ApacheFopWorker.transform(ApacheFopWorker.java:176)
>  ~[ofbiz.jar:?]
>  at 
> org.apache.ofbiz.common.email.EmailServices.sendMailFromScreen(EmailServices.java:558)
>  [ofbiz.jar:?]
> at sun.reflect.GeneratedMethodAccessor215.invoke(Unknown Source) 
> ~[?:?]
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_112]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_112]
>  at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:396)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:227)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>  [ofbiz.jar:?]
>  at 
> org.apache.ofbiz.order.order.OrderServices.sendOrderNotificationScreen(OrderServices.java:2680)
>  [ofbiz.jar:?]
>at 
> org.apache.ofbiz.order.order.OrderServices.sendOrderConfirmNotification(OrderServices.java:2510)
>  [ofbiz.jar:?]
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_112]
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_112]
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_112]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_112]
>  at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:396)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:227)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>  [ofbiz.jar:?]
>  at 
> org.apache.ofbiz.service.job.GenericServiceJob.exec(GenericServiceJob.java:70)
>  [ofbiz.jar:?]
> at org.apache.ofbiz.service.job.AbstractJob.run(AbstractJob.java:87) 
> [ofbiz.jar:?]
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [?:1.8.0_112]
>at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [?:1.8.0_112]
>at java.lang.Thread.run(Thread.java:745) [?:1.8.0_112]
> Caused by: javax.xml.transform.TransformerException: 
> org.apache.fop.fo.ValidationException: Document is empty (something might be 
> wrong with your XSLT stylesheet).
>  at 
> org.apache.xalan.transformer.TransformerIdentityImpl.transform(TransformerIdentityImpl.java:501)
>  ~[xalan-2.7.0.jar:?]
>at 
> org.apache.ofbiz.webapp.view.ApacheFopWorker.transform(ApacheFopWorker.java:174)
>  ~[ofbiz.jar:?]
>  ... 25 more
> Caused by: org.apache.fop.fo.ValidationException: Document is empty 
> (something might be wrong with your XSLT stylesheet).
>   at 
> 

[jira] [Created] (OFBIZ-11986) createPartyGroupRoleAndContactMechs service not working

2020-08-28 Thread Akash Jain (Jira)
Akash Jain created OFBIZ-11986:
--

 Summary: createPartyGroupRoleAndContactMechs service not working
 Key: OFBIZ-11986
 URL: https://issues.apache.org/jira/browse/OFBIZ-11986
 Project: OFBiz
  Issue Type: Bug
  Components: sfa
Affects Versions: Trunk
Reporter: Akash Jain


While researched on ticket OFBIZ-11896 identified that groovy version of 
createPartyGroupRoleAndContactMechs service (converted from mini lang at rev 
8af7cf877583acf100d1229260e62fe7f4c92563 ) is not working. Identify these two 
reasons,
 # resolvePartyGroupMap called incorrectly
 # resolvePostalAddressMap and resolveTelecomNumberMap implemented incorrectly 
as 'postalAddress' and 'telecomNumber' map processor not available into 
PartyMapProcs.xml.

There may be more reasons along with these two reasons.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11896) Quick Add Lead does not work without group name

2020-08-28 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186576#comment-17186576
 ] 

Akash Jain commented on OFBIZ-11896:


Attached patch to fix reported issue.

> Quick Add Lead does not work without group name
> ---
>
> Key: OFBIZ-11896
> URL: https://issues.apache.org/jira/browse/OFBIZ-11896
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing/sfa
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-11896.patch
>
>
> Steps:
>  # Go to [https://demo-trunk.ofbiz.apache.org/sfa/control/main]
>  # Try to add lead with FirstName and LastName
>  # See error on screen



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11896) Quick Add Lead does not work without group name

2020-08-28 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-11896:
---
Attachment: OFBIZ-11896.patch

> Quick Add Lead does not work without group name
> ---
>
> Key: OFBIZ-11896
> URL: https://issues.apache.org/jira/browse/OFBIZ-11896
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing/sfa
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-11896.patch
>
>
> Steps:
>  # Go to [https://demo-trunk.ofbiz.apache.org/sfa/control/main]
>  # Try to add lead with FirstName and LastName
>  # See error on screen



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-9759) Fiscal Gl type is reflecting twice in drop-down of Cost Centers.

2020-08-27 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185928#comment-17185928
 ] 

Akash Jain commented on OFBIZ-9759:
---

Reported issue has been fixed, I think we are good to close this issue.

> Fiscal Gl type is reflecting twice in drop-down of Cost Centers.
> 
>
> Key: OFBIZ-9759
> URL: https://issues.apache.org/jira/browse/OFBIZ-9759
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
> Environment: 
> https://ofbiz-trunk.hotwaxsystems.com/accounting/control/GlAccountBalanceByCostCenter?organizationPartyId=Company
>Reporter: Tejas Khanna
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-9759.patch
>
>
> Steps to reproduce:
> 1. Select Accounting from Applications.
> 2. Select Organization GL Settings from Accounting Manager.
> 3. Click on accounting.
> 4. Click on Reports
> 5. Select Cost Centers
> 6. Choose Fiscal Gl Type drop-down.
> Actual result: on selecting Gl Type from drop-down, selected Gl Type is 
> reflecting twice.
> Expected result: Selected value should come only once in drop-down after 
> report generation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11424) createPartyContent not working

2020-08-27 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185920#comment-17185920
 ] 

Akash Jain commented on OFBIZ-11424:


I verified reported issue with various scenarios, able to create product 
content with all scenarios. I think we are good to close this issue.

> createPartyContent not working
> --
>
> Key: OFBIZ-11424
> URL: https://issues.apache.org/jira/browse/OFBIZ-11424
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Akash Jain
>Priority: Major
> Fix For: Upcoming Branch
>
>
> go to Party -> search -> select any PartyId -> Party Content
> Create will produce the following error:
> "The Following Errors Occurred:
> layoutEvents.no_files_uploaded"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-10532) Default value flags not working for configurable and variant products at the time of order entry

2020-08-27 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-10532.
--
Fix Version/s: 17.12.05
   18.12.01
   Resolution: Fixed

> Default value flags not working for configurable and variant products at the 
> time of order entry
> 
>
> Key: OFBIZ-10532
> URL: https://issues.apache.org/jira/browse/OFBIZ-10532
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Assignee: Akash Jain
>Priority: Major
> Fix For: 18.12.01, 17.12.05
>
> Attachments: OFBIZ-10532.patch
>
>
> On adding configurable/variant products to the cart, default value flags i.e. 
> 'Use as default desired delivery date for next entry' and 'Use as default 
> comment for next entry' are not working. Flags are working fine for simple 
> products. Below are the steps to regenerate the issue:
> 1) Log in to 'ordermgr' with credentials admin/ofbiz.
> 2) Click on the 'Order Entry' menu.
> 3) In the 'Sales Order' section enter the values and click on the 'Continue' 
> link.
> 4) Leave the fields on the next page as it is and click on the 'Continue' 
> link.
> 5) Select any configurable product (e.g. pizza) or variant (e.g. WG-9943) and 
> enter quantity.
> 6) Enter the 'Desired Delivery Date' and click on the adjacent checkbox 'Use 
> as default desired delivery date for next entry'.
> 7) Enter the 'Comment' and click on the adjacent checkbox 'Use as default 
> comment for next entry'.
> 8) Click on the 'Add To Cart' button. You will be landed on the next screen 
> for selecting the variant or configuring the product.
> 9) After configuration click on 'Add To Cart' button again. 
> Item will be added to cart but the default values will not be available for 
> the next entry. This feature is working fine for the simple products like 
> Tiny Gizmo (Tiny Gizmo).
> Most probably values are not getting persisted on the second screen for 
> variants and configurable products and it is causing the issue.
>  
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-8539) Unit test case for service - createTopic

2020-08-26 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-8539.
-
Resolution: Invalid

> Unit test case for service - createTopic
> 
>
> Key: OFBIZ-8539
> URL: https://issues.apache.org/jira/browse/OFBIZ-8539
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
>
> Unit test case for service - createTopic



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (OFBIZ-8539) Unit test case for service - createTopic

2020-08-26 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reopened OFBIZ-8539:
---

> Unit test case for service - createTopic
> 
>
> Key: OFBIZ-8539
> URL: https://issues.apache.org/jira/browse/OFBIZ-8539
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
>
> Unit test case for service - createTopic



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-8539) Unit test case for service - createTopic

2020-08-26 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-8539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185091#comment-17185091
 ] 

Akash Jain commented on OFBIZ-8539:
---

This service has been removed. We are good to close this ticket.

> Unit test case for service - createTopic
> 
>
> Key: OFBIZ-8539
> URL: https://issues.apache.org/jira/browse/OFBIZ-8539
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Trunk
>
>
> Unit test case for service - createTopic



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-8539) Unit test case for service - createTopic

2020-08-26 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-8539.
-
Fix Version/s: (was: Trunk)
   Resolution: Implemented

> Unit test case for service - createTopic
> 
>
> Key: OFBIZ-8539
> URL: https://issues.apache.org/jira/browse/OFBIZ-8539
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
>
> Unit test case for service - createTopic



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-8540) Unit test case for service - checkContentAssocIds

2020-08-26 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-8540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185089#comment-17185089
 ] 

Akash Jain commented on OFBIZ-8540:
---

This service has been removed. We are good to close this ticket.

> Unit test case for service - checkContentAssocIds
> -
>
> Key: OFBIZ-8540
> URL: https://issues.apache.org/jira/browse/OFBIZ-8540
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Trunk
>
>
> Unit test case for service - checkContentAssocIds



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-8540) Unit test case for service - checkContentAssocIds

2020-08-26 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-8540.
-
Fix Version/s: (was: Trunk)
   Resolution: Invalid

> Unit test case for service - checkContentAssocIds
> -
>
> Key: OFBIZ-8540
> URL: https://issues.apache.org/jira/browse/OFBIZ-8540
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
>
> Unit test case for service - checkContentAssocIds



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-8580) Unit test case for service - deleteProductCategory

2020-08-26 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-8580.
-
Fix Version/s: (was: Trunk)
   Resolution: Invalid

> Unit test case for service - deleteProductCategory
> --
>
> Key: OFBIZ-8580
> URL: https://issues.apache.org/jira/browse/OFBIZ-8580
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
>
> Unit test case for service - deleteProductCategory



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-8580) Unit test case for service - deleteProductCategory

2020-08-26 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-8580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185088#comment-17185088
 ] 

Akash Jain commented on OFBIZ-8580:
---

Not found 'deleteProductCategory' service. I think we are good to close this 
ticket.

> Unit test case for service - deleteProductCategory
> --
>
> Key: OFBIZ-8580
> URL: https://issues.apache.org/jira/browse/OFBIZ-8580
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Trunk
>
>
> Unit test case for service - deleteProductCategory



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-8547) Unit test case for service - getContent

2020-08-26 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-8547.
-
Fix Version/s: (was: Trunk)
   Upcoming Branch
   Resolution: Implemented

> Unit test case for service - getContent
> ---
>
> Key: OFBIZ-8547
> URL: https://issues.apache.org/jira/browse/OFBIZ-8547
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8547.patch
>
>
> Unit test case for service - getContent



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10532) Default value flags not working for configurable and variant products at the time of order entry

2020-08-25 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184806#comment-17184806
 ] 

Akash Jain commented on OFBIZ-10532:


Attached patch to fix reported issue.

> Default value flags not working for configurable and variant products at the 
> time of order entry
> 
>
> Key: OFBIZ-10532
> URL: https://issues.apache.org/jira/browse/OFBIZ-10532
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Assignee: Akash Jain
>Priority: Major
> Attachments: OFBIZ-10532.patch
>
>
> On adding configurable/variant products to the cart, default value flags i.e. 
> 'Use as default desired delivery date for next entry' and 'Use as default 
> comment for next entry' are not working. Flags are working fine for simple 
> products. Below are the steps to regenerate the issue:
> 1) Log in to 'ordermgr' with credentials admin/ofbiz.
> 2) Click on the 'Order Entry' menu.
> 3) In the 'Sales Order' section enter the values and click on the 'Continue' 
> link.
> 4) Leave the fields on the next page as it is and click on the 'Continue' 
> link.
> 5) Select any configurable product (e.g. pizza) or variant (e.g. WG-9943) and 
> enter quantity.
> 6) Enter the 'Desired Delivery Date' and click on the adjacent checkbox 'Use 
> as default desired delivery date for next entry'.
> 7) Enter the 'Comment' and click on the adjacent checkbox 'Use as default 
> comment for next entry'.
> 8) Click on the 'Add To Cart' button. You will be landed on the next screen 
> for selecting the variant or configuring the product.
> 9) After configuration click on 'Add To Cart' button again. 
> Item will be added to cart but the default values will not be available for 
> the next entry. This feature is working fine for the simple products like 
> Tiny Gizmo (Tiny Gizmo).
> Most probably values are not getting persisted on the second screen for 
> variants and configurable products and it is causing the issue.
>  
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10532) Default value flags not working for configurable and variant products at the time of order entry

2020-08-25 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-10532:
---
Sprint: OFBiz Community Day (Aug 2020)
Issue Type: Bug  (was: New Feature)

> Default value flags not working for configurable and variant products at the 
> time of order entry
> 
>
> Key: OFBIZ-10532
> URL: https://issues.apache.org/jira/browse/OFBIZ-10532
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Assignee: Akash Jain
>Priority: Major
> Attachments: OFBIZ-10532.patch
>
>
> On adding configurable/variant products to the cart, default value flags i.e. 
> 'Use as default desired delivery date for next entry' and 'Use as default 
> comment for next entry' are not working. Flags are working fine for simple 
> products. Below are the steps to regenerate the issue:
> 1) Log in to 'ordermgr' with credentials admin/ofbiz.
> 2) Click on the 'Order Entry' menu.
> 3) In the 'Sales Order' section enter the values and click on the 'Continue' 
> link.
> 4) Leave the fields on the next page as it is and click on the 'Continue' 
> link.
> 5) Select any configurable product (e.g. pizza) or variant (e.g. WG-9943) and 
> enter quantity.
> 6) Enter the 'Desired Delivery Date' and click on the adjacent checkbox 'Use 
> as default desired delivery date for next entry'.
> 7) Enter the 'Comment' and click on the adjacent checkbox 'Use as default 
> comment for next entry'.
> 8) Click on the 'Add To Cart' button. You will be landed on the next screen 
> for selecting the variant or configuring the product.
> 9) After configuration click on 'Add To Cart' button again. 
> Item will be added to cart but the default values will not be available for 
> the next entry. This feature is working fine for the simple products like 
> Tiny Gizmo (Tiny Gizmo).
> Most probably values are not getting persisted on the second screen for 
> variants and configurable products and it is causing the issue.
>  
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10532) Default value flags not working for configurable and variant products at the time of order entry

2020-08-25 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-10532:
---
Attachment: OFBIZ-10532.patch

> Default value flags not working for configurable and variant products at the 
> time of order entry
> 
>
> Key: OFBIZ-10532
> URL: https://issues.apache.org/jira/browse/OFBIZ-10532
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Assignee: Akash Jain
>Priority: Major
> Attachments: OFBIZ-10532.patch
>
>
> On adding configurable/variant products to the cart, default value flags i.e. 
> 'Use as default desired delivery date for next entry' and 'Use as default 
> comment for next entry' are not working. Flags are working fine for simple 
> products. Below are the steps to regenerate the issue:
> 1) Log in to 'ordermgr' with credentials admin/ofbiz.
> 2) Click on the 'Order Entry' menu.
> 3) In the 'Sales Order' section enter the values and click on the 'Continue' 
> link.
> 4) Leave the fields on the next page as it is and click on the 'Continue' 
> link.
> 5) Select any configurable product (e.g. pizza) or variant (e.g. WG-9943) and 
> enter quantity.
> 6) Enter the 'Desired Delivery Date' and click on the adjacent checkbox 'Use 
> as default desired delivery date for next entry'.
> 7) Enter the 'Comment' and click on the adjacent checkbox 'Use as default 
> comment for next entry'.
> 8) Click on the 'Add To Cart' button. You will be landed on the next screen 
> for selecting the variant or configuring the product.
> 9) After configuration click on 'Add To Cart' button again. 
> Item will be added to cart but the default values will not be available for 
> the next entry. This feature is working fine for the simple products like 
> Tiny Gizmo (Tiny Gizmo).
> Most probably values are not getting persisted on the second screen for 
> variants and configurable products and it is causing the issue.
>  
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11924) Issues with additional image on ecommerce

2020-08-25 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-11924:
---
Sprint: OFBiz Community Day (Aug 2020)

> Issues with additional image on ecommerce
> -
>
> Key: OFBIZ-11924
> URL: https://issues.apache.org/jira/browse/OFBIZ-11924
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Akash Jain
>Priority: Minor
> Attachments: Add1.jpg, Add2.jpg, Add3.jpg, Image2.1.png, Image2.2.png
>
>
> Following issues were found:
>  
> #1) Additional image uploaded for product is not displayed (if product 
> already has additional image)
> Steps to regenerate:
>  * Download additional images attached in the ticket
>  * Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductContent?productId=WG-5569]
>  * Browse additional images that are downloaded in the earlier step
>  * Click on upload button
>  * Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/ecomseo/product/Tiny-Chrome-Widget-WG-5569.html]
>  
> Actual: Uploaded additional images are not displayed
>  
> Expected: Uploaded additional image should be displayed on ecommerce
>  
> Note: This issue is product specific, for product: Tiny Chrome Widget (Id: 
> WG-5569), uploaded additional images are not displayed. But for product: Nan 
> Gizmo (Id: GZ-1001), uploaded additional images are displayed
>  
> #2) UI issue on ecommerce when additional images are uploaded for product
> Steps to regenerate:
>  * Download additional images attached in the ticket
>  * Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductContent?productId=GZ-1001]
>  * Browse additional images that are downloaded in the earlier step
>  * Click on upload button
>  * Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/ecomseo/product/Nan-Gizmo-GZ-1001.html]
>  
> Actual: Please refer attachment: Image2.1
> Expected: Please refer attachment: Image 2.2



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11981) Additional images not showing correctly on product detail page

2020-08-25 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-11981:
---
Sprint: OFBiz Community Day (Aug 2020)

> Additional images not showing correctly on product detail page
> --
>
> Key: OFBIZ-11981
> URL: https://issues.apache.org/jira/browse/OFBIZ-11981
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11981.patch, OFBIZ-11981.png
>
>
> Additional images not showing correctly on product detail page, attached 
> screen-shot.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11920) Distorted Final Checkout Review page when Credit card is selected as Payment option

2020-08-25 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-11920:
---
Sprint: OFBiz Community Day (Aug 2020)

> Distorted Final Checkout Review page when Credit card is selected as Payment 
> option
> ---
>
> Key: OFBIZ-11920
> URL: https://issues.apache.org/jira/browse/OFBIZ-11920
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 17.12
>Reporter: Rashi Dhagat
>Assignee: Akash Jain
>Priority: Minor
> Fix For: 18.12.01, 17.12.05
>
> Attachments: DistortedUI.png, OFBIZ-11920.patch, OFBIZ-11920.patch
>
>
> Steps to regenerate:
>  1. Open URL [https://demo-trunk.ofbiz.apache.org/ecomseo/ 
> |https://demo-trunk.ofbiz.apache.org/ecomseo/]
> 2. Add item in the cart
> 3. Click on Quick Checkout 
> 4. Click on checkout under Checkout Without Login section
> 5. Enter details
> 6. Select Payment Option as Credit Card
> Actual: Final Checkout Review page Is distorted
> Please refer to the attachment.
> !DistortedUI.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11982) Expired product images showing on product detail page

2020-08-25 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-11982:
---
Sprint: OFBiz Community Day (Aug 2020)

> Expired product images showing on product detail page
> -
>
> Key: OFBIZ-11982
> URL: https://issues.apache.org/jira/browse/OFBIZ-11982
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11982.patch
>
>
> Expired product images showing in sliding box on product detail page.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11924) Issues with additional image on ecommerce

2020-08-25 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-11924.
--
Resolution: Won't Fix

I think we are good to close this issue.

> Issues with additional image on ecommerce
> -
>
> Key: OFBIZ-11924
> URL: https://issues.apache.org/jira/browse/OFBIZ-11924
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Akash Jain
>Priority: Minor
> Attachments: Add1.jpg, Add2.jpg, Add3.jpg, Image2.1.png, Image2.2.png
>
>
> Following issues were found:
>  
> #1) Additional image uploaded for product is not displayed (if product 
> already has additional image)
> Steps to regenerate:
>  * Download additional images attached in the ticket
>  * Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductContent?productId=WG-5569]
>  * Browse additional images that are downloaded in the earlier step
>  * Click on upload button
>  * Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/ecomseo/product/Tiny-Chrome-Widget-WG-5569.html]
>  
> Actual: Uploaded additional images are not displayed
>  
> Expected: Uploaded additional image should be displayed on ecommerce
>  
> Note: This issue is product specific, for product: Tiny Chrome Widget (Id: 
> WG-5569), uploaded additional images are not displayed. But for product: Nan 
> Gizmo (Id: GZ-1001), uploaded additional images are displayed
>  
> #2) UI issue on ecommerce when additional images are uploaded for product
> Steps to regenerate:
>  * Download additional images attached in the ticket
>  * Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductContent?productId=GZ-1001]
>  * Browse additional images that are downloaded in the earlier step
>  * Click on upload button
>  * Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/ecomseo/product/Nan-Gizmo-GZ-1001.html]
>  
> Actual: Please refer attachment: Image2.1
> Expected: Please refer attachment: Image 2.2



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11982) Expired product images showing on product detail page

2020-08-25 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-11982.
--
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> Expired product images showing on product detail page
> -
>
> Key: OFBIZ-11982
> URL: https://issues.apache.org/jira/browse/OFBIZ-11982
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11982.patch
>
>
> Expired product images showing in sliding box on product detail page.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


  1   2   3   4   5   6   7   8   >