[jira] [Commented] (OFBIZ-7664) Inconsistencies on the title and the label on button of create forms.
[ https://issues.apache.org/jira/browse/OFBIZ-7664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936478#comment-16936478 ] Swapnil M Mane commented on OFBIZ-7664: --- [~jleroux] and team IMO, we should close this task. > Inconsistencies on the title and the label on button of create forms. > - > > Key: OFBIZ-7664 > URL: https://issues.apache.org/jira/browse/OFBIZ-7664 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Rahul bhammarker >Assignee: Rahul bhammarker >Priority: Minor > > There are inconsistencies in the form title and the action label on the the > button of create forms such as Catalog > Products > New Product > the form title is "Edit Product" and the button label is "Create Product". > There are various fomrs like this in other components. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11038) Unable to view a PartyContent on view profile page of a party
[ https://issues.apache.org/jira/browse/OFBIZ-11038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane updated OFBIZ-11038: --- Sprint: (was: OFBiz Community Day (Aug 2019)) > Unable to view a PartyContent on view profile page of a party > - > > Key: OFBIZ-11038 > URL: https://issues.apache.org/jira/browse/OFBIZ-11038 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: Error_message.png, OFBIZ-11038.patch, > PartyContent_View.png > > > * Go to [partymgr|https://demo-trunk.ofbiz.apache.org/partymgr/control/main] > * Search any party(e.g. DemoCustomer) > * Go to the [party > profile|https://demo-trunk.ofbiz.apache.org/partymgr/control/viewprofile?partyId=DemoCustomer] > page > * Go to Party Content section on the page and upload a file > * Select a purpose(Logo Image Url) and click on the Upload button > * After uploading success message will be displayed as Party data object > created successfully. > * Then view button will be displayed under the Party Content section, click > on the view button to view the image uploaded. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (OFBIZ-11180) Service parameter default-value attribut can support flexible string
[
https://issues.apache.org/jira/browse/OFBIZ-11180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922415#comment-16922415
]
Swapnil M Mane commented on OFBIZ-11180:
:D Nice, thanks [~soledad], this is better and beautiful ;)!
> Service parameter default-value attribut can support flexible string
>
>
> Key: OFBIZ-11180
> URL: https://issues.apache.org/jira/browse/OFBIZ-11180
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-11180.patch
>
>
> When you define a service with default-value, you can't set simple dynamic
> resolution for the value.
> The idea is to extend the default-value attribut on service parameter to
> support the FlexibleStringExpander syntax and realize the expand on service
> context.
> Example :
> {code:java}
> engine="entity-auto" invoke="create" auth="true">
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (OFBIZ-11180) Service parameter default-value attribut can support flexible string
[
https://issues.apache.org/jira/browse/OFBIZ-11180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921975#comment-16921975
]
Swapnil M Mane commented on OFBIZ-11180:
Looks good addition to me as well, +1
Very small suggestion, can we rename 'now' variable name to 'nowTimestamp' to
maintain consistency.
Thanks!
> Service parameter default-value attribut can support flexible string
>
>
> Key: OFBIZ-11180
> URL: https://issues.apache.org/jira/browse/OFBIZ-11180
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-11180.patch
>
>
> When you define a service with default-value, you can't set simple dynamic
> resolution for the value.
> The idea is to extend the default-value attribut on service parameter to
> support the FlexibleStringExpander syntax and realize the expand on service
> context.
> Example :
> {code:java}
> engine="entity-auto" invoke="create" auth="true">
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919287#comment-16919287 ] Swapnil M Mane commented on OFBIZ-10145: Kudos, thanks so much everyone! :) > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01, 16.11.06, Upcoming Branch, 18.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat, > init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch, release-16.11-without-gradlew.patch, > release-16.11-without-gradlew.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (OFBIZ-10729) Add subscribe email on website mailing list page
[ https://issues.apache.org/jira/browse/OFBIZ-10729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917442#comment-16917442 ] Swapnil M Mane commented on OFBIZ-10729: Thanks you [~adityasharma] and [~jacques.le.roux]. Here are my thoughts on this. 1. I will also prefer the SubscribeMailingList-Top-Alt.png 2. We can update the instructions in "Alternate Steps:" section as follows (taken reference from [here|https://apache.org/foundation/mailinglists.html]) To subscribe to any of the following lists, please follow the steps below * Send an email to the appropriate address (see below) user-subscr...@ofbiz.apache.org dev-subscr...@ofbiz.apache.org commits-subscr...@ofbiz.apache.org notifications-subscr...@ofbiz.apache.org * You will receive an email from mailing list manager program (EZMLM); either a confirmation request or an error message (e.g. if you are not subscribed) * Reply to the confirmation message * Congratulations! You are now subscribed 3. Just want to know the thoughts of community, Should we make alternate steps as main steps? Since alternate steps are not having any dependency on the email client setup on machine. 4. I think, there is no need to add the Aternative steps, "Alternately, please send ..." in the mid section (SubscribeMailingList-Mid.png). Thanks! > Add subscribe email on website mailing list page > > > Key: OFBIZ-10729 > URL: https://issues.apache.org/jira/browse/OFBIZ-10729 > Project: OFBiz > Issue Type: Improvement > Components: site >Reporter: Deepak Dixit >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-10729-Alt.patch, OFBIZ-10729.patch, > OFBIZ-10729.patch, SubscribeMailingList-Mid.png, > SubscribeMailingList-Top-Alt.png, SubscribeMailingList-bottom.png, > SubscribeMailingList.png, SubscribeMailingList.png, > SubscribeMailingListAlt-1.png, SubscribeMailingListAlt-2.png > > > As per current implementation, we have a link of lists.apache.org for > subscribing mailing list, > When a user visited lists.apache.org website it has the option to subscribe, > this tries to open email client, if no email client setup on a user machine, > so its difficult to subscribe. > We can add an alternate option as well along with lists.apache.org link. A > simple text with subscribe email address. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (OFBIZ-11176) Find order screen can't make a search without ship to country
[ https://issues.apache.org/jira/browse/OFBIZ-11176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane updated OFBIZ-11176: --- Sprint: OFBiz Community Day (Aug 2019) > Find order screen can't make a search without ship to country > - > > Key: OFBIZ-11176 > URL: https://issues.apache.org/jira/browse/OFBIZ-11176 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk, Release Branch 18.12 >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Fix For: Upcoming Branch, Release Branch 18.12 > > Attachments: OFBIZ-11176.patch, Screenshot from 2019-08-27 > 09-49-41.png > > > When you search orders on the standard screen [1] you can't unselect a > country. > !Screenshot from 2019-08-27 09-49-41.png! > The problem come from the populate country list by countries.ftl who select > by default a country without possibility to escape it. > The patch [^OFBIZ-11176.patch] solve it with adding a possibility to escape > auto select. > If you found a better solution, I'm open ;) > [1] https://demo-trunk.ofbiz.apache.org/ordermgr/control/findorders -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (OFBIZ-10976) Unable to add product to cart when user enter detail in Tell-A-Friend link.
[ https://issues.apache.org/jira/browse/OFBIZ-10976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane updated OFBIZ-10976: --- Description: *Step to reproduce* 1. Login with valid username and password. 2. Navigate to ecommerce. 3. Select a product and click on link Tell-A-Friend. 4. Enter detail in Tell-A-Friend window. 5. Click on link add to cart link. *Actual Result:* Error message is displayed as "Tell a friend sorry". *Screen print attached* *Note - Email validation is not added in Tell-A-Friend window.* was: *Step to reproduce* 1. Login with valid username and password. 2. Navigate to ecommerce. 3. Select a product and click on link Tell-A-Friend. 4. Enter detail in Tell-A-Friend window. 5. Click on link add to cart link. *Actual Result:* Error message is displayed as "Tell a friend sorry". *Screen print attached* *Note - Email validation is not added in Tell-A-Friend window.* > Unable to add product to cart when user enter detail in Tell-A-Friend link. > --- > > Key: OFBIZ-10976 > URL: https://issues.apache.org/jira/browse/OFBIZ-10976 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Ashish Sharma >Assignee: Swapnil M Mane >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10976.patch, OFBIZ-10976.png > > > *Step to reproduce* > 1. Login with valid username and password. > 2. Navigate to ecommerce. > 3. Select a product and click on link Tell-A-Friend. > 4. Enter detail in Tell-A-Friend window. > 5. Click on link add to cart link. > *Actual Result:* Error message is displayed as "Tell a friend sorry". > *Screen print attached* > *Note - Email validation is not added in Tell-A-Friend window.* -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (OFBIZ-10976) Unable to add product to cart when user enter detail in Tell-A-Friend link.
[ https://issues.apache.org/jira/browse/OFBIZ-10976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane updated OFBIZ-10976: --- Sprint: OFBiz Community Day (May 2019), OFBiz Community Day (Aug 2019) (was: OFBiz Community Day (May 2019)) > Unable to add product to cart when user enter detail in Tell-A-Friend link. > --- > > Key: OFBIZ-10976 > URL: https://issues.apache.org/jira/browse/OFBIZ-10976 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Ashish Sharma >Assignee: Swapnil M Mane >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10976.patch, OFBIZ-10976.png > > > *Step to reproduce* > 1. Login with valid username and password. > 2. Navigate to ecommerce. > 3. Select a product and click on link Tell-A-Friend. > 4. Enter detail in Tell-A-Friend window. > 5. Click on link add to cart link. > *Actual Result:* Error message is displayed as "Tell a friend sorry". > *Screen print attached* > *Note - Email validation is not added in Tell-A-Friend window.* -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903813#comment-16903813
]
Swapnil M Mane edited comment on OFBIZ-10145 at 8/9/19 11:26 AM:
-
Hi [~jacopoc],
Thanks for the patch.
I followed the steps mentioned above with patch applied, and everything works
well (got no error) for me.
Although I got this 'default JVM option' in my gradlew file
{code:java}
DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
{code}
But it don't create any issue.
I am using Gradle 5.5.1 and Mac OS X 10.14.3.
Thanks!
was (Author: swapnilmmane):
Hi [~jacopoc],
Thanks for the patch.
I followed the steps mentioned above with patch applied, and everything works
well (got no error) for me.
Although I got this 'default JVM option' in my gradlew file
{code:java}
DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
{code}
But it don't create any issue.
I am using Gradle 5.5.1 and Mac OS X 10.14.3.
Thanks!
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch,
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch,
> gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch,
> init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat,
> init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch,
> init-gradlew-readme.patch, release-16.11-without-gradlew.patch,
> release-16.11-without-gradlew.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903813#comment-16903813
]
Swapnil M Mane edited comment on OFBIZ-10145 at 8/9/19 11:26 AM:
-
Hi [~jacopoc],
Thanks for the patch.
I followed the steps mentioned above with patch applied, and everything works
well (got no error) for me.
Although I got this 'default JVM option' in my gradlew file
{code:java}
DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
{code}
But it don't create any issue.
I am using Gradle 5.5.1 and Mac OS X 10.14.3.
Thanks!
was (Author: swapnilmmane):
Hi [~jacopoc],
Thanks for the patch.
I followed the steps mentioned above with patch applied, and everything works
well (got no error) for me.
Thanks!
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch,
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch,
> gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch,
> init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat,
> init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch,
> init-gradlew-readme.patch, release-16.11-without-gradlew.patch,
> release-16.11-without-gradlew.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903813#comment-16903813 ] Swapnil M Mane commented on OFBIZ-10145: Hi [~jacopoc], Thanks for the patch. I followed the steps mentioned above with patch applied, and everything works well (got no error) for me. Thanks! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat, > init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch, release-16.11-without-gradlew.patch, > release-16.11-without-gradlew.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870277#comment-16870277
]
Swapnil M Mane commented on OFBIZ-10145:
Thanks [~jacques.le.roux] for your comments, all the points makes sense to me :)
As you already mentioned,
{quote}the user must have an Internet connexion
{quote}
This is only the point we need to think on, let's see what are the thoughts our
fellow team members.
Thanks!
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch,
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch,
> gradlew.bat.patch, init-gradle-wrapper-R16.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradlew-readme-R16.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme.patch, init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10971) Use ReturnContactMech entity
[ https://issues.apache.org/jira/browse/OFBIZ-10971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane reassigned OFBIZ-10971: -- Assignee: (was: Swapnil M Mane) > Use ReturnContactMech entity > > > Key: OFBIZ-10971 > URL: https://issues.apache.org/jira/browse/OFBIZ-10971 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Vaibhav Jain >Priority: Major > > Use ReturnContactMech entity to capture the contactMech information of > parties involved in a return like OrderContactMech is used of orders -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10971) Use ReturnContactMech entity
[ https://issues.apache.org/jira/browse/OFBIZ-10971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane reassigned OFBIZ-10971: -- Assignee: Swapnil M Mane > Use ReturnContactMech entity > > > Key: OFBIZ-10971 > URL: https://issues.apache.org/jira/browse/OFBIZ-10971 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Vaibhav Jain >Assignee: Swapnil M Mane >Priority: Major > > Use ReturnContactMech entity to capture the contactMech information of > parties involved in a return like OrderContactMech is used of orders -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-11057) modify exampledemodata.xml
[
https://issues.apache.org/jira/browse/OFBIZ-11057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Swapnil M Mane closed OFBIZ-11057.
--
Resolution: Not A Problem
Assignee: Swapnil M Mane
Fix Version/s: (was: 18.12.01)
> modify exampledemodata.xml
> --
>
> Key: OFBIZ-11057
> URL: https://issues.apache.org/jira/browse/OFBIZ-11057
> Project: OFBiz
> Issue Type: Test
> Components: ALL PLUGINS
>Affects Versions: 18.12.01
>Reporter: alain
>Assignee: Swapnil M Mane
>Priority: Minor
>
> make test to add the line in the file exampledemodata.xml:
> {color:#ff}<{color}{color:#80}StatusItem{color}
> {color:#ff}description{color}{color:#ff}="New"{color}
> {color:#ff}sequenceId{color}{color:#ff}="07"{color}
> {color:#ff}statusCode{color}{color:#ff}="NEW"{color}
> {color:#ff}statusId{color}{color:#ff}="EXST_NEW"{color}
> {color:#ff}statusTypeId{color}{color:#ff}="EXAMPLE_STATUS"{color}{color:#ff}/>{color}
>
> but I don't see this item in the list of status type ?
> some thing more to update ?
> thx start evaluation of this interface
> Alain
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-11057) modify exampledemodata.xml
[
https://issues.apache.org/jira/browse/OFBIZ-11057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870181#comment-16870181
]
Swapnil M Mane commented on OFBIZ-11057:
Hello [~maussion],
Welcome to Apache OFBiz ecosystem.
OFBiz Jira is not the right place for asking your queries. It for tracking bugs
and improvement in OFBiz.
Please ask your questions/queries on the user mailing list -
(u...@ofbiz.apache.org). You will get wider audience support there.
Please subscribe to the mailing list before posting your question.
For more detail, refer Apache OFBiz mailing list [1]
I am closing this issue, please post your queries on the user mailing list
along with details.
[1] [https://ofbiz.apache.org/mailing-lists.html]
Thanks!
> modify exampledemodata.xml
> --
>
> Key: OFBIZ-11057
> URL: https://issues.apache.org/jira/browse/OFBIZ-11057
> Project: OFBiz
> Issue Type: Test
> Components: ALL PLUGINS
>Affects Versions: 18.12.01
>Reporter: alain
>Priority: Minor
> Fix For: 18.12.01
>
>
> make test to add the line in the file exampledemodata.xml:
> {color:#ff}<{color}{color:#80}StatusItem{color}
> {color:#ff}description{color}{color:#ff}="New"{color}
> {color:#ff}sequenceId{color}{color:#ff}="07"{color}
> {color:#ff}statusCode{color}{color:#ff}="NEW"{color}
> {color:#ff}statusId{color}{color:#ff}="EXST_NEW"{color}
> {color:#ff}statusTypeId{color}{color:#ff}="EXAMPLE_STATUS"{color}{color:#ff}/>{color}
>
> but I don't see this item in the list of status type ?
> some thing more to update ?
> thx start evaluation of this interface
> Alain
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-11061) UI issue on contactus page of ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-11061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane closed OFBIZ-11061. -- Resolution: Fixed Fix Version/s: 17.12.01 Thanks for [~arpit.mor] for reporting the issue. And thanks [~SASIKANTBISWAL] for providing patch, your patch is committed in trunk at rev #1861824 release18.12 at rev #1861826 release17.12 at rev #1861827 release16.11 is not concern. Thanks! > UI issue on contactus page of ecommerce > --- > > Key: OFBIZ-11061 > URL: https://issues.apache.org/jira/browse/OFBIZ-11061 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Swapnil M Mane >Priority: Minor > Fix For: 17.12.01 > > Attachments: Image1.1.png, Image1.2.png, Image1.3.png, > OFBIZ-11061.patch > > > Steps to regenerate: > * Navigate to [https://demo-trunk.ofbiz.apache.org/ecomseo/] > * Click on Login > * Enter valid username and password > * Click on login button > * Click on Contact Us > Actual: From, subject and message label are not displayed properly on some > resolution. Please refer attachment: Image1.1, Image1.2, Image1.3 > Note: This issue is resolution specific if you are unable to generate the > issue then increase the resolution of your screen or zoom in the page on > browser -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-11114) Atleast one phone number validation not working while creating new customer using party manager
[ https://issues.apache.org/jira/browse/OFBIZ-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870146#comment-16870146 ] Swapnil M Mane edited comment on OFBIZ-4 at 6/22/19 8:52 AM: - Hello [~arpit.mor] , Thanks for your concern but it doesn't seems as bug to me because user can create the phone number of customer later (after creating customer) from party profile screen. Please refer 'Contact Information' section on party profile screen for more details. And yes, IMO, we can think on what to do with 'At least one phone number is required below' message. Thanks! was (Author: swapnilmmane): Hello [~arpit.mor] , Thanks for your concern but it doesn't seems as bug to me because user can create the phone number of customer later (after creating customer) from party profile screen. Please refer 'Contact Information' section on party profile screen for more details. Thanks! > Atleast one phone number validation not working while creating new customer > using party manager > --- > > Key: OFBIZ-4 > URL: https://issues.apache.org/jira/browse/OFBIZ-4 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk, Release Branch 16.11 >Reporter: Arpit Mor >Assignee: Swapnil M Mane >Priority: Major > > Steps to regenerate: > # Login to the URL: > [https://demo-trunk.ofbiz.apache.org/partymgr/control/NewCustomer] > # Enter first name, last name > # Enter shipping address > # Do not enter any phone number (like home phone, work phone, fax, mobile) > # Enter email address > # Enter username > # Enter password > # Confirm password > # Click on save button > Actual: User is created without phone number > Expected: The page displays the message that “At least one phone number is > required below” but the user can be created without any phone number. Hence, > either atleast one phone is required validation should work > OR > “At least one phone number is required below” message should be removed if > user can be created without any phone number -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11114) Atleast one phone number validation not working while creating new customer using party manager
[ https://issues.apache.org/jira/browse/OFBIZ-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870146#comment-16870146 ] Swapnil M Mane commented on OFBIZ-4: Hello [~arpit.mor] , Thanks for your concern but it doesn't seems as bug to me because user can create the phone number of customer later (after creating customer) from party profile screen. Please refer 'Contact Information' section on party profile screen for more details. Thanks! > Atleast one phone number validation not working while creating new customer > using party manager > --- > > Key: OFBIZ-4 > URL: https://issues.apache.org/jira/browse/OFBIZ-4 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk, Release Branch 16.11 >Reporter: Arpit Mor >Assignee: Swapnil M Mane >Priority: Major > > Steps to regenerate: > # Login to the URL: > [https://demo-trunk.ofbiz.apache.org/partymgr/control/NewCustomer] > # Enter first name, last name > # Enter shipping address > # Do not enter any phone number (like home phone, work phone, fax, mobile) > # Enter email address > # Enter username > # Enter password > # Confirm password > # Click on save button > Actual: User is created without phone number > Expected: The page displays the message that “At least one phone number is > required below” but the user can be created without any phone number. Hence, > either atleast one phone is required validation should work > OR > “At least one phone number is required below” message should be removed if > user can be created without any phone number -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-11114) Atleast one phone number validation not working while creating new customer using party manager
[ https://issues.apache.org/jira/browse/OFBIZ-4?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane reassigned OFBIZ-4: -- Assignee: Swapnil M Mane > Atleast one phone number validation not working while creating new customer > using party manager > --- > > Key: OFBIZ-4 > URL: https://issues.apache.org/jira/browse/OFBIZ-4 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk, Release Branch 16.11 >Reporter: Arpit Mor >Assignee: Swapnil M Mane >Priority: Major > > Steps to regenerate: > # Login to the URL: > [https://demo-trunk.ofbiz.apache.org/partymgr/control/NewCustomer] > # Enter first name, last name > # Enter shipping address > # Do not enter any phone number (like home phone, work phone, fax, mobile) > # Enter email address > # Enter username > # Enter password > # Confirm password > # Click on save button > Actual: User is created without phone number > Expected: The page displays the message that “At least one phone number is > required below” but the user can be created without any phone number. Hence, > either atleast one phone is required validation should work > OR > “At least one phone number is required below” message should be removed if > user can be created without any phone number -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-11061) UI issue on contactus page of ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-11061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane reassigned OFBIZ-11061: -- Assignee: Swapnil M Mane (was: Sasikant Biswal) > UI issue on contactus page of ecommerce > --- > > Key: OFBIZ-11061 > URL: https://issues.apache.org/jira/browse/OFBIZ-11061 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Swapnil M Mane >Priority: Minor > Attachments: Image1.1.png, Image1.2.png, Image1.3.png, > OFBIZ-11061.patch > > > Steps to regenerate: > * Navigate to [https://demo-trunk.ofbiz.apache.org/ecomseo/] > * Click on Login > * Enter valid username and password > * Click on login button > * Click on Contact Us > Actual: From, subject and message label are not displayed properly on some > resolution. Please refer attachment: Image1.1, Image1.2, Image1.3 > Note: This issue is resolution specific if you are unable to generate the > issue then increase the resolution of your screen or zoom in the page on > browser -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869382#comment-16869382 ] Swapnil M Mane edited comment on OFBIZ-10145 at 6/21/19 10:56 AM: -- Thanks so much [~jacques.le.roux] and [~soledad], this work is going in great direction :) I think, we should also have existance check for gradle-wrapper.properties file. Here is the patch [^OFBIZ-10145_wrapper_properties_check.patch] for same, please have a look. Also, I am thinking about the use case, how we will change the gradle-wrapper.jar and gradle-wrapper.properties on user's machine when we upgrade our Gradle version in trunk. E.g. currently we are using Gradle v5.0 on the trunk, in future when we upgrade the Gradle to next version let say v5.4.1. In this case, the gradle-wrapper.jar and gradle-wrapper.properties will be not be updated on user's machine because as per our script it will only check the files with name (gradle-wrapper.jar and gradle-wrapper.properties) should exist in OFBiz_Root/gradle/wrapper directory. And the script will found the old files in OFBiz_Root/gradle/wrapper directory, thus will not download the new jar and properties files. Please let me know if I am missing anything. Thanks! was (Author: swapnilmmane): Thanks so much [~jacques.le.roux] and [~soledad], this work is going in great direction :) I think, we should also have existance check for gradle-wrapper.properties file. Here is the patch [^OFBIZ-10145_wrapper_properties_check.patch] for same, please have a look. Thanks! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869382#comment-16869382 ] Swapnil M Mane commented on OFBIZ-10145: Thanks so much [~jacques.le.roux] and [~soledad], this work is going in great direction :) I think, we should also have existance check for gradle-wrapper.properties file. Here is the patch [^OFBIZ-10145_wrapper_properties_check.patch] for same, please have a look. Thanks! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane updated OFBIZ-10145: --- Attachment: OFBIZ-10145_wrapper_properties_check.patch > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10639) Cookie Consent In E-Commerce
[ https://issues.apache.org/jira/browse/OFBIZ-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865319#comment-16865319 ] Swapnil M Mane commented on OFBIZ-10639: Thanks Deepak for your contribution, and everyone for participating in the discussion. Dear [~deepak.nigam], I have applied the patch and everything is working as expected. As the above comments and suggestions resolved, we are good to commit it. I am unassigning this ticket and would like to see your commits in action. Once again, many congratulations on your new role, happy committing :-) Thanks! > Cookie Consent In E-Commerce > > > Key: OFBIZ-10639 > URL: https://issues.apache.org/jira/browse/OFBIZ-10639 > Project: OFBiz > Issue Type: New Feature > Components: ecommerce >Affects Versions: Trunk >Reporter: Deepak Nigam >Assignee: Swapnil M Mane >Priority: Minor > Attachments: OFBIZ-10639.patch, OFBIZ-10639.patch > > > As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] > The Cookie Law is a piece of privacy legislation that requires websites to > get consent from visitors to store or retrieve any information on their > computer, smartphone or tablet. It was designed to protect online privacy, by > making consumers aware of how information about them is collected and used > online, and give them a choice to allow it or not. > > The EU Cookie Legislation began as a directive from the European Union. Some > variation on the policy has since been adopted by all countries within the EU. > > The EU Cookie Legislation requires 4 actions from website owners who use > cookies: > 1. When someone visits your website, you need to let them know that your > site uses cookies. > 2. You need to provide detailed information regarding how that cookie data > will be utilized. > 3. You need to provide visitors with some means of accepting or refusing the > use of cookies in your site. > 4. If they refuse, you need to ensure that cookies will not be placed on > their machine. > > For more information about EU cookie policy, please visit > [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm]. > > As this crucial feature is missing in OFBiz E-Commerce application, we > should work towards its implementation. There are numerous open-source jQuery > plugins available which we can use. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10639) Cookie Consent In E-Commerce
[ https://issues.apache.org/jira/browse/OFBIZ-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane reassigned OFBIZ-10639: -- Assignee: (was: Swapnil M Mane) > Cookie Consent In E-Commerce > > > Key: OFBIZ-10639 > URL: https://issues.apache.org/jira/browse/OFBIZ-10639 > Project: OFBiz > Issue Type: New Feature > Components: ecommerce >Affects Versions: Trunk >Reporter: Deepak Nigam >Priority: Minor > Attachments: OFBIZ-10639.patch, OFBIZ-10639.patch > > > As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] > The Cookie Law is a piece of privacy legislation that requires websites to > get consent from visitors to store or retrieve any information on their > computer, smartphone or tablet. It was designed to protect online privacy, by > making consumers aware of how information about them is collected and used > online, and give them a choice to allow it or not. > > The EU Cookie Legislation began as a directive from the European Union. Some > variation on the policy has since been adopted by all countries within the EU. > > The EU Cookie Legislation requires 4 actions from website owners who use > cookies: > 1. When someone visits your website, you need to let them know that your > site uses cookies. > 2. You need to provide detailed information regarding how that cookie data > will be utilized. > 3. You need to provide visitors with some means of accepting or refusing the > use of cookies in your site. > 4. If they refuse, you need to ensure that cookies will not be placed on > their machine. > > For more information about EU cookie policy, please visit > [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm]. > > As this crucial feature is missing in OFBiz E-Commerce application, we > should work towards its implementation. There are numerous open-source jQuery > plugins available which we can use. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859169#comment-16859169 ] Swapnil M Mane edited comment on OFBIZ-10145 at 6/8/19 10:05 AM: - Thank you [~jacques.le.roux], I like the suggestion of calling init-gradle-wrapper script from both gradlew and gradlew.bat script. In this way, life our users will became easy, no action will be required from their side. And as you nicely mentioned we need to make sure we are handling the 'init-gradle-wrapper' script always while upgrading the gradle. Just I am not sure about recommendation for customizing the Gradle Wrapper file. Let's see what are the thoughts our fellow team members. Thanks! was (Author: swapnilmmane): Thank you [~jacques.le.roux], I like the suggestion of calling init-gradle-wrapper script from both gradlew and gradlew.bat script. In this way, life our users will became easy, no action will be required from their side. And as you nicely mentioned we need to make sure we are handling the 'init-gradle-wrapper' script always while upgrading the gradle. Let's see what are the thoughts our fellow team members. Thanks! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859169#comment-16859169 ] Swapnil M Mane commented on OFBIZ-10145: Thank you [~jacques.le.roux], I like the suggestion of calling init-gradle-wrapper script from both gradlew and gradlew.bat script. In this way, life our users will became easy, no action will be required from their side. And as you nicely mentioned we need to make sure we are handling the 'init-gradle-wrapper' script always while upgrading the gradle. Let's see what are the thoughts our fellow team members. Thanks! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858591#comment-16858591
]
Swapnil M Mane commented on OFBIZ-10145:
Hi [~jacques.le.roux] ,
Thank you for your efforts. :)
I see no harm in copying gradle-wrapper.jar and gradle-wrapper.properties from
our repository. (let's see what others say)
Based on your input, our updated script will look someting like this.
{code:java}
OFBIZ_HOME="$(pwd)"
GRADLE_WRAPPER_OFBIZ_PATH="$OFBIZ_HOME/gradle/"
WRAPPER_URL="http://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper/trunk/gradle-wrapper.jar;
WRAPPER_PROPERTIES_URL="http://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper/trunk/gradle-wrapper.properties;
whereIsBinary() {
whereis $1 | grep /
}
if [ ! -d "$GRADLE_WRAPPER_OFBIZ_PATH" ]; then
echo "Location seems to be incorrect, please run the 'sh
gradle/init-gradle-wrapper.sh' script from Apache OFBiz root.";
exit -1;
fi
if [ -n "$(whereIsBinary curl)" ]; then
GET_CMD="curl -o";
elif [ -n "$(whereIsBinary wget)" ]; then
GET_CMD="wget -O";
else
echo "No command curl or wget found, please install yourself.";
exit -1
fi
$GET_CMD "gradle/wrapper/gradle-wrapper.jar" $WRAPPER_URL
$GET_CMD "gradle/wrapper/gradle-wrapper.properties" $WRAPPER_PROPERTIES_URL
{code}
[~jacques.le.roux], [~soledad] and team,
Please feel free to share your thoughts on this updated script.
Thanks!
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch,
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857454#comment-16857454 ] Swapnil M Mane commented on OFBIZ-10145: Thank you [~jacopoc] for your comment. Hello team, We are using Gradle version 2.13 in R16. Added the [^init-gradle-wrapper-R16.sh] script for the same. I have tested it on my machine and everything is working expected. Also, markdown is used R16, update the README.md README.md.html files [^init-gradlew-readme-R16.patch] with the instruction. (Thanks [~jacques.le.roux] for your help in this) Please have a look. Thanks! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane updated OFBIZ-10145: --- Attachment: init-gradlew-readme-R16.patch init-gradle-wrapper-R16.sh > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10639) Cookie Consent In E-Commerce
[ https://issues.apache.org/jira/browse/OFBIZ-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane reassigned OFBIZ-10639: -- Assignee: Swapnil M Mane (was: Deepak Nigam) > Cookie Consent In E-Commerce > > > Key: OFBIZ-10639 > URL: https://issues.apache.org/jira/browse/OFBIZ-10639 > Project: OFBiz > Issue Type: New Feature > Components: ecommerce >Affects Versions: Trunk >Reporter: Deepak Nigam >Assignee: Swapnil M Mane >Priority: Minor > Attachments: OFBIZ-10639.patch > > > As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] > The Cookie Law is a piece of privacy legislation that requires websites to > get consent from visitors to store or retrieve any information on their > computer, smartphone or tablet. It was designed to protect online privacy, by > making consumers aware of how information about them is collected and used > online, and give them a choice to allow it or not. > > The EU Cookie Legislation began as a directive from the European Union. Some > variation on the policy has since been adopted by all countries within the EU. > > The EU Cookie Legislation requires 4 actions from website owners who use > cookies: > 1. When someone visits your website, you need to let them know that your > site uses cookies. > 2. You need to provide detailed information regarding how that cookie data > will be utilized. > 3. You need to provide visitors with some means of accepting or refusing the > use of cookies in your site. > 4. If they refuse, you need to ensure that cookies will not be placed on > their machine. > > For more information about EU cookie policy, please visit > [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm]. > > As this crucial feature is missing in OFBiz E-Commerce application, we > should work towards its implementation. There are numerous open-source jQuery > plugins available which we can use. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10976) Unable to add product to cart when user enter detail in Tell-A-Friend link.
[ https://issues.apache.org/jira/browse/OFBIZ-10976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane reassigned OFBIZ-10976: -- Assignee: Swapnil M Mane (was: Rohit Hukkeri) > Unable to add product to cart when user enter detail in Tell-A-Friend link. > --- > > Key: OFBIZ-10976 > URL: https://issues.apache.org/jira/browse/OFBIZ-10976 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Ashish Sharma >Assignee: Swapnil M Mane >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10976.patch, OFBIZ-10976.png > > > *Step to reproduce* > 1. Login with valid username and password. > 2. Navigate to ecommerce. > 3. Select a product and click on link Tell-A-Friend. > 4. Enter detail in Tell-A-Friend window. > 5. Click on link add to cart link. > *Actual Result:* Error message is displayed as "Tell a friend sorry". > *Screen print attached* > *Note - Email validation is not added in Tell-A-Friend window.* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854299#comment-16854299 ] Swapnil M Mane commented on OFBIZ-10145: Hi [~jacques.le.roux], I liked the idea :) > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-7189) Forgot password new password reset email content is not understandable.
[
https://issues.apache.org/jira/browse/OFBIZ-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Swapnil M Mane closed OFBIZ-7189.
-
Resolution: Duplicate
Fixed under the ticket OFBIZ-8321 at rev #1764261
> Forgot password new password reset email content is not understandable.
> ---
>
> Key: OFBIZ-7189
> URL: https://issues.apache.org/jira/browse/OFBIZ-7189
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Release Branch 14.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Swapnil M Mane
>Priority: Major
>
> New password email content is not understandable. Please refer:
> {code}
> SecurityExtThisEmailIsInResponseToYourRequestToHave SecurityExtANew
> SecurityExtPasswordSentToYou.
> SecurityExtNewPasswordMssgEncryptionOn "jupZW"
> {code}
> The problem is missing UiLabels. I will provide patch for it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-7189) Forgot password new password reset email content is not understandable.
[
https://issues.apache.org/jira/browse/OFBIZ-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850927#comment-16850927
]
Swapnil M Mane commented on OFBIZ-7189:
---
Hello [~amardeepsj],
Thanks for reporting the issue.
The issue was not related to missing UI labels but the typo in defining the
resource (EmailPasswordUiLabels) for property-map.
{code:xml}
{code}
It is fixed by [~jacques.le.roux] at rev #1764261 under the OFBIZ-8321
{code:xml}
{code}
thus, closing the ticket.
Thanks [~jacques.le.roux]!
> Forgot password new password reset email content is not understandable.
> ---
>
> Key: OFBIZ-7189
> URL: https://issues.apache.org/jira/browse/OFBIZ-7189
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Release Branch 14.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Swapnil M Mane
>Priority: Major
>
> New password email content is not understandable. Please refer:
> {code}
> SecurityExtThisEmailIsInResponseToYourRequestToHave SecurityExtANew
> SecurityExtPasswordSentToYou.
> SecurityExtNewPasswordMssgEncryptionOn "jupZW"
> {code}
> The problem is missing UiLabels. I will provide patch for it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-7189) Forgot password new password reset email content is not understandable.
[
https://issues.apache.org/jira/browse/OFBIZ-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Swapnil M Mane reassigned OFBIZ-7189:
-
Assignee: Swapnil M Mane (was: Aman Agrawal)
> Forgot password new password reset email content is not understandable.
> ---
>
> Key: OFBIZ-7189
> URL: https://issues.apache.org/jira/browse/OFBIZ-7189
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Release Branch 14.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Swapnil M Mane
>Priority: Major
>
> New password email content is not understandable. Please refer:
> {code}
> SecurityExtThisEmailIsInResponseToYourRequestToHave SecurityExtANew
> SecurityExtPasswordSentToYou.
> SecurityExtNewPasswordMssgEncryptionOn "jupZW"
> {code}
> The problem is missing UiLabels. I will provide patch for it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850793#comment-16850793 ] Swapnil M Mane commented on OFBIZ-10145: +1, thanks! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme-R17.1.patch, > init-gradlew-readme.patch, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-8808) JUnit test case for Creating a Retrun Header
[ https://issues.apache.org/jira/browse/OFBIZ-8808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane reassigned OFBIZ-8808: - Assignee: (was: Swapnil M Mane) > JUnit test case for Creating a Retrun Header > > > Key: OFBIZ-8808 > URL: https://issues.apache.org/jira/browse/OFBIZ-8808 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Priority: Minor > Attachments: OFBIZ-8808.patch, OFBIZ-8808.patch > > > Unit test case for service - createReturnHeader -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10992) No pre-filled value while selecting "facilityId To" on Transfer Inventory Item screen
[ https://issues.apache.org/jira/browse/OFBIZ-10992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane closed OFBIZ-10992. -- Resolution: Fixed Fix Version/s: 16.11.06 > No pre-filled value while selecting "facilityId To" on Transfer Inventory > Item screen > - > > Key: OFBIZ-10992 > URL: https://issues.apache.org/jira/browse/OFBIZ-10992 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Aishwary Shrivastava >Assignee: Swapnil M Mane >Priority: Minor > Fix For: 16.11.06 > > Attachments: NewFacility.png, OFBIZ-10992.patch, > TransferInventoryItem.png > > > While creating Transfer Inventory Item from the warehouse, there are no > prefiled values in selecting FacilityId To. > Steps to regenerate: > # Go to Facilities. > # Select Inventory Xfers option. > # Create Transfer Inventory Item from any Warehouse. > # Navigate to Transfer Inventory overview screen > e.g. link > https://localhost:8443/facility/control/TransferInventoryItem?inventoryTransferId=10001 > # 'Facility Id To' link is not redirecting to correct facility > Attached the screenshots for creating new inventory item transfer screen and > new facility screen. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10992) No pre-filled value while selecting "facilityId To" on Transfer Inventory Item screen
[ https://issues.apache.org/jira/browse/OFBIZ-10992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849759#comment-16849759 ] Swapnil M Mane edited comment on OFBIZ-10992 at 5/28/19 2:20 PM: - Thank you [~pawan.verma] and [~aishwary] for your contribution. Your patch is committed in trunk at rev 1860274 release18.12 at rev 1860275 release17.12 at rev 1860276 release16.11 at rev 1860277 Thanks! was (Author: swapnilmmane): Thank you [~pawan.verma] and [~aishwary] for your contribution. Your patch is committed in trunk at rev 1860274 release18.12 at rev 1860275 release17.12 at rev 1860276 Thanks! > No pre-filled value while selecting "facilityId To" on Transfer Inventory > Item screen > - > > Key: OFBIZ-10992 > URL: https://issues.apache.org/jira/browse/OFBIZ-10992 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Aishwary Shrivastava >Assignee: Swapnil M Mane >Priority: Minor > Attachments: NewFacility.png, OFBIZ-10992.patch, > TransferInventoryItem.png > > > While creating Transfer Inventory Item from the warehouse, there are no > prefiled values in selecting FacilityId To. > Steps to regenerate: > # Go to Facilities. > # Select Inventory Xfers option. > # Create Transfer Inventory Item from any Warehouse. > # Navigate to Transfer Inventory overview screen > e.g. link > https://localhost:8443/facility/control/TransferInventoryItem?inventoryTransferId=10001 > # 'Facility Id To' link is not redirecting to correct facility > Attached the screenshots for creating new inventory item transfer screen and > new facility screen. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10992) No pre-filled value while selecting "facilityId To" on Transfer Inventory Item screen
[ https://issues.apache.org/jira/browse/OFBIZ-10992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane updated OFBIZ-10992: --- Description: While creating Transfer Inventory Item from the warehouse, there are no prefiled values in selecting FacilityId To. Steps to regenerate: # Go to Facilities. # Select Inventory Xfers option. # Create Transfer Inventory Item from any Warehouse. # Navigate to Transfer Inventory overview screen e.g. link https://localhost:8443/facility/control/TransferInventoryItem?inventoryTransferId=10001 # 'Facility Id To' link is not redirecting to correct facility Attached the screenshots for creating new inventory item transfer screen and new facility screen. was: While creating Transfer Inventory Item from warehouse, there are no prefiled values in selecting FacilityId To. Steps to regenerate: # Go to Facilities. # Select Inventory Xfers. # Create Transfer Inventory Item From any Warehouse. # Fill values in the feilds. # Try to click on FacilityIdTo field Attached the screenshots for creating new inventory item transfer screen and new facility screen. > No pre-filled value while selecting "facilityId To" on Transfer Inventory > Item screen > - > > Key: OFBIZ-10992 > URL: https://issues.apache.org/jira/browse/OFBIZ-10992 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Aishwary Shrivastava >Assignee: Swapnil M Mane >Priority: Minor > Attachments: NewFacility.png, OFBIZ-10992.patch, > TransferInventoryItem.png > > > While creating Transfer Inventory Item from the warehouse, there are no > prefiled values in selecting FacilityId To. > Steps to regenerate: > # Go to Facilities. > # Select Inventory Xfers option. > # Create Transfer Inventory Item from any Warehouse. > # Navigate to Transfer Inventory overview screen > e.g. link > https://localhost:8443/facility/control/TransferInventoryItem?inventoryTransferId=10001 > # 'Facility Id To' link is not redirecting to correct facility > Attached the screenshots for creating new inventory item transfer screen and > new facility screen. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10992) No pre-filled value while selecting "facilityId To" on Transfer Inventory Item screen
[ https://issues.apache.org/jira/browse/OFBIZ-10992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849759#comment-16849759 ] Swapnil M Mane commented on OFBIZ-10992: Thank you [~pawan.verma] and [~aishwary] for your contribution. Your patch is committed in trunk at rev 1860274 release18.12 at rev 1860275 release17.12 at rev 1860276 Thanks! > No pre-filled value while selecting "facilityId To" on Transfer Inventory > Item screen > - > > Key: OFBIZ-10992 > URL: https://issues.apache.org/jira/browse/OFBIZ-10992 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Aishwary Shrivastava >Assignee: Swapnil M Mane >Priority: Minor > Attachments: NewFacility.png, OFBIZ-10992.patch, > TransferInventoryItem.png > > > While creating Transfer Inventory Item from warehouse, there are no prefiled > values in selecting FacilityId To. > Steps to regenerate: > # Go to Facilities. > # Select Inventory Xfers. > # Create Transfer Inventory Item From any Warehouse. > # Fill values in the feilds. > # Try to click on FacilityIdTo field > Attached the screenshots for creating new inventory item transfer screen and > new facility screen. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849460#comment-16849460 ] Swapnil M Mane commented on OFBIZ-10145: Thank you [~soledad], looks good to me! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848625#comment-16848625
]
Swapnil M Mane edited comment on OFBIZ-10145 at 5/27/19 5:41 AM:
-
Thanks [~jacques.le.roux], you are correct for R17 Gradle release should be
3.2.1 (I have done the suggested change in script and uploaded it again)
Hello [~soledad] and team,
I have done the following changes in script, please have a look
For R17 - [^init-gradle-wrapper.sh]
For R18 and trunk - [^init-gradle-wrapper-trunk-and-18.sh]
1.) Since we are putting the script at location $OFBIZ_HOME/gradle, I have
changed the GRADLE_WRAPPER_OFBIZ_PATH from
{code:java}
$OFBIZ_HOME/gradle/wrapper/{code}
to
{code:java}
$OFBIZ_HOME/gradle/{code}
otherwise script was giving the message "Location seems to be incorrect",
even when run from OFBiz root.
2.) Changed the Gradle release to 3.2.1 for R17.
3.) Done some improvements in messages which is to be shown to the user.
Please have a look and let me know your thoughts.
Thanks!
was (Author: swapnilmmane):
Thanks [~jacques.le.roux], you are correct for R17 Gradle release should be
3.2.1 (I have done the suggested change in script and uploaded it again)
Hello [~soledad] and team,
I have done the following changes in script, please have a look
1.) Since we are putting the script at location $OFBIZ_HOME/gradle, I have
changed the GRADLE_WRAPPER_OFBIZ_PATH from
{code:java}
$OFBIZ_HOME/gradle/wrapper/{code}
to
{code:java}
$OFBIZ_HOME/gradle/{code}
otherwise script was giving the message "Location seems to be incorrect",
even when run from OFBiz root.
2.) Changed the Gradle release to 3.2.1 for R17.
3.) Done some improvements in messages which is to be shown to the user.
Please have a look and let me know your thoughts.
Thanks!
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848625#comment-16848625
]
Swapnil M Mane commented on OFBIZ-10145:
Thanks [~jacques.le.roux], you are correct for R17 Gradle release should be
3.2.1 (I have done the suggested change in script and uploaded it again)
Hello [~soledad] and team,
I have done the following changes in script, please have a look
1.) Since we are putting the script at location $OFBIZ_HOME/gradle, I have
changed the GRADLE_WRAPPER_OFBIZ_PATH from
{code:java}
$OFBIZ_HOME/gradle/wrapper/{code}
to
{code:java}
$OFBIZ_HOME/gradle/{code}
otherwise script was giving the message "Location seems to be incorrect",
even when run from OFBiz root.
2.) Changed the Gradle release to 3.2.1 for R17.
3.) Done some improvements in messages which is to be shown to the user.
Please have a look and let me know your thoughts.
Thanks!
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane updated OFBIZ-10145: --- Attachment: init-gradle-wrapper.sh init-gradle-wrapper-trunk-and-18.sh > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11062) Wrong page title displayed on contact us page of ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848157#comment-16848157 ] Swapnil M Mane commented on OFBIZ-11062: Thank you [~ayushirathod44] for your contribution. I see some console log and merge conflict in your patch, can you please fix it. Thanks! > Wrong page title displayed on contact us page of ecommerce > -- > > Key: OFBIZ-11062 > URL: https://issues.apache.org/jira/browse/OFBIZ-11062 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk, Release Branch 16.11 >Reporter: Arpit Mor >Priority: Minor > Attachments: Image1.png, OFBIZ-11062.patch > > > Steps to regenerate: > * Navigate to [https://demo-trunk.ofbiz.apache.org/ecomseo/] or > [https://demo-stable.ofbiz.apache.org/ecommerce/control/main] > * Click on Login > * Enter valid username and password > * Click on login button > * Click on Contact Us > Actual: Page title displays Login. Please refer attachment: Image1 > Expected: Page title should not display Login as the user is already logged > in. It should display somthing like Contact Us -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11014) StringUtil cleanup
[
https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848129#comment-16848129
]
Swapnil M Mane commented on OFBIZ-11014:
Thank you!
> StringUtil cleanup
> --
>
> Key: OFBIZ-11014
> URL: https://issues.apache.org/jira/browse/OFBIZ-11014
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11014_0001-Remove-useless-StringUtil-join-overload.patch,
> OFBIZ-11014_0002-Rewrite-StringUtil-join-method.patch,
> OFBIZ-11014_0003-Remove-unused-StringUtil-append-method.patch,
> OFBIZ-11014_0004-Remove-unused-StringUtil-split-overload.patch,
> OFBIZ-11014_0005-Inline-StringUtil-quoteStrList-method.patch,
> OFBIZ-11014_0006-Remove-unused-StringUtil-strToMap-overload.patch,
> OFBIZ-11014_0007-Remove-unused-StringUtil-mapToStr-method.patch,
> OFBIZ-11014_0008-Remove-unused-StringUtil-convertChar-method.patch,
> OFBIZ-11014_0009-Remove-unused-StringUtil-removeNumeric-meth.patch,
> OFBIZ-11014_0010-Remove-unused-StringUtil-collapseNewlines-m.patch,
> OFBIZ-11014_0011-Remove-unused-StringUtil-collapseSpaces-met.patch,
> OFBIZ-11014_0012-Remove-unused-StringUtil-collapseCharacter.patch,
> OFBIZ-11014_0013-Remove-unused-StringUtil-appendTo-methods.patch,
> OFBIZ-11014_0014-Turn-StringUtilTests-into-a-unit-test.patch
>
>
> {{StringUtil}} contains stuff that is not useful with recent version of Java.
> For example the {{StringUtil#split}} method could be replaced by the
> {{String#split}} method. As a consequence {{StringUtil}} should be cleaned up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-8808) JUnit test case for Creating a Retrun Header
[ https://issues.apache.org/jira/browse/OFBIZ-8808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane reassigned OFBIZ-8808: - Assignee: Swapnil M Mane (was: Yogesh Naroliya) > JUnit test case for Creating a Retrun Header > > > Key: OFBIZ-8808 > URL: https://issues.apache.org/jira/browse/OFBIZ-8808 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Swapnil M Mane >Priority: Minor > Attachments: OFBIZ-8808.patch, OFBIZ-8808.patch > > > Unit test case for service - createReturnHeader -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11014) StringUtil cleanup
[
https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848119#comment-16848119
]
Swapnil M Mane commented on OFBIZ-11014:
Dear [~mthl] ,
Thanks so much for your contribution, highly appriciated.
As you know, we are celebrating OFBiz community days event from 24th – 28th May.
Can you please set the Sprint of this ticket (and also in the other tickets) to
"OFBiz Community Day (May 2019)".
This will helps us track and report on the work done during the Community Days.
Please let me know if you need any help from myside.
Thank you!
> StringUtil cleanup
> --
>
> Key: OFBIZ-11014
> URL: https://issues.apache.org/jira/browse/OFBIZ-11014
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11014_0001-Remove-useless-StringUtil-join-overload.patch,
> OFBIZ-11014_0002-Rewrite-StringUtil-join-method.patch,
> OFBIZ-11014_0003-Remove-unused-StringUtil-append-method.patch,
> OFBIZ-11014_0004-Remove-unused-StringUtil-split-overload.patch,
> OFBIZ-11014_0005-Inline-StringUtil-quoteStrList-method.patch,
> OFBIZ-11014_0006-Remove-unused-StringUtil-strToMap-overload.patch,
> OFBIZ-11014_0007-Remove-unused-StringUtil-mapToStr-method.patch,
> OFBIZ-11014_0008-Remove-unused-StringUtil-convertChar-method.patch,
> OFBIZ-11014_0009-Remove-unused-StringUtil-removeNumeric-meth.patch,
> OFBIZ-11014_0010-Remove-unused-StringUtil-collapseNewlines-m.patch,
> OFBIZ-11014_0011-Remove-unused-StringUtil-collapseSpaces-met.patch,
> OFBIZ-11014_0012-Remove-unused-StringUtil-collapseCharacter.patch,
> OFBIZ-11014_0013-Remove-unused-StringUtil-appendTo-methods.patch,
> OFBIZ-11014_0014-Turn-StringUtilTests-into-a-unit-test.patch
>
>
> {{StringUtil}} contains stuff that is not useful with recent version of Java.
> For example the {{StringUtil#split}} method could be replaced by the
> {{String#split}} method. As a consequence {{StringUtil}} should be cleaned up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10982) Blank page rendering on the screen on clicking add to cart
[ https://issues.apache.org/jira/browse/OFBIZ-10982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane reassigned OFBIZ-10982: -- Assignee: Swapnil M Mane > Blank page rendering on the screen on clicking add to cart > -- > > Key: OFBIZ-10982 > URL: https://issues.apache.org/jira/browse/OFBIZ-10982 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Padmavati Rawat >Assignee: Swapnil M Mane >Priority: Major > > Steps: > 1. Visit the https://demo-trunk.ofbiz.apache.org/ecommerce/control/main > 2. Check the Quick Reorder section showing on the page. > 3. The recently ordered products will be displayed in the section. > 4. Click on Add to Cart link and check the functionality. > Actual: > On clicking Add to Cart link blank page rendering on the screen. > Please refer screenshot: -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-7594) Unable to delete a survey in project component
[ https://issues.apache.org/jira/browse/OFBIZ-7594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane updated OFBIZ-7594: -- Sprint: OFBiz Community Day (May 2019) > Unable to delete a survey in project component > -- > > Key: OFBIZ-7594 > URL: https://issues.apache.org/jira/browse/OFBIZ-7594 > Project: OFBiz > Issue Type: Bug > Components: projectmgr >Affects Versions: Release Branch 17.12 >Reporter: Deepak Baghel >Assignee: Swapnil M Mane >Priority: Major > > Step to regenerate > 1. Login into project component. > 2. Go to the task section. > 3. Find the task. > 4. Go to the any of the task from the list. > 5. Then go to surveys section > 6. Try to delete the survey, if any exist. > 7. Surveys are unable to delete. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-7594) Unable to delete a survey in project component
[ https://issues.apache.org/jira/browse/OFBIZ-7594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane closed OFBIZ-7594. - Resolution: Fixed Fix Version/s: 17.12.01 > Unable to delete a survey in project component > -- > > Key: OFBIZ-7594 > URL: https://issues.apache.org/jira/browse/OFBIZ-7594 > Project: OFBiz > Issue Type: Bug > Components: projectmgr >Affects Versions: Release Branch 17.12 >Reporter: Deepak Baghel >Assignee: Swapnil M Mane >Priority: Major > Fix For: 17.12.01 > > > Step to regenerate > 1. Login into project component. > 2. Go to the task section. > 3. Find the task. > 4. Go to the any of the task from the list. > 5. Then go to surveys section > 6. Try to delete the survey, if any exist. > 7. Surveys are unable to delete. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7594) Unable to delete a survey in project component
[ https://issues.apache.org/jira/browse/OFBIZ-7594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848114#comment-16848114 ] Swapnil M Mane commented on OFBIZ-7594: --- Thank you [~suraj.khurana] and [~pierresmits] for sharing your thoughts. Dear [~deepak.baghel] , Hope you understand the comments shared above, I am proceeding to close this ticket. Thanks! > Unable to delete a survey in project component > -- > > Key: OFBIZ-7594 > URL: https://issues.apache.org/jira/browse/OFBIZ-7594 > Project: OFBiz > Issue Type: Bug > Components: projectmgr >Affects Versions: Trunk >Reporter: Deepak Baghel >Assignee: Swapnil M Mane >Priority: Major > > Step to regenerate > 1. Login into project component. > 2. Go to the task section. > 3. Find the task. > 4. Go to the any of the task from the list. > 5. Then go to surveys section > 6. Try to delete the survey, if any exist. > 7. Surveys are unable to delete. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-7594) Unable to delete a survey in project component
[ https://issues.apache.org/jira/browse/OFBIZ-7594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane updated OFBIZ-7594: -- Affects Version/s: (was: Trunk) Release Branch 17.12 > Unable to delete a survey in project component > -- > > Key: OFBIZ-7594 > URL: https://issues.apache.org/jira/browse/OFBIZ-7594 > Project: OFBiz > Issue Type: Bug > Components: projectmgr >Affects Versions: Release Branch 17.12 >Reporter: Deepak Baghel >Assignee: Swapnil M Mane >Priority: Major > > Step to regenerate > 1. Login into project component. > 2. Go to the task section. > 3. Find the task. > 4. Go to the any of the task from the list. > 5. Then go to surveys section > 6. Try to delete the survey, if any exist. > 7. Surveys are unable to delete. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7594) Unable to delete a survey in project component
[
https://issues.apache.org/jira/browse/OFBIZ-7594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848113#comment-16848113
]
Swapnil M Mane commented on OFBIZ-7594:
---
Hello team,
The following error is generated on deleting the survey associated with the
task.
{code:java}
Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException:
Problems getting the service model (Cannot locate service by name
(deleteWorkEffortSurveyAppl)){code}
On exploration I found, In the refactoring work done under OFBIZ-8408, the
deleteWorkEffortSurveyAppl service was removed.
Added the deleteWorkEffortSurveyAppl service, previously it was in written in
the simple engine, converted it to entity-auto.
Committed this change
In trunk at rev #1859931
In release18.12 at rev #1859933
In release17.12 at rev #1859935
> Unable to delete a survey in project component
> --
>
> Key: OFBIZ-7594
> URL: https://issues.apache.org/jira/browse/OFBIZ-7594
> Project: OFBiz
> Issue Type: Bug
> Components: projectmgr
>Affects Versions: Trunk
>Reporter: Deepak Baghel
>Assignee: Swapnil M Mane
>Priority: Major
>
> Step to regenerate
> 1. Login into project component.
> 2. Go to the task section.
> 3. Find the task.
> 4. Go to the any of the task from the list.
> 5. Then go to surveys section
> 6. Try to delete the survey, if any exist.
> 7. Surveys are unable to delete.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-7594) Unable to delete a survey in project component
[ https://issues.apache.org/jira/browse/OFBIZ-7594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane reassigned OFBIZ-7594: - Assignee: Swapnil M Mane (was: Deepak Baghel) > Unable to delete a survey in project component > -- > > Key: OFBIZ-7594 > URL: https://issues.apache.org/jira/browse/OFBIZ-7594 > Project: OFBiz > Issue Type: Bug > Components: projectmgr >Affects Versions: Trunk >Reporter: Deepak Baghel >Assignee: Swapnil M Mane >Priority: Major > > Step to regenerate > 1. Login into project component. > 2. Go to the task section. > 3. Find the task. > 4. Go to the any of the task from the list. > 5. Then go to surveys section > 6. Try to delete the survey, if any exist. > 7. Surveys are unable to delete. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847571#comment-16847571 ] Swapnil M Mane edited comment on OFBIZ-10145 at 5/24/19 2:02 PM: - As discussed over the OFBiz Slack chat group, documented the process to initializing gradle wrapper in README.adoc for Linux based OS, please refer [^init-gradlew-readme.patch] file. Added TODO note for MS Windows OS, as time allows [~jacques.le.roux] will help us here, thanks so much Jacques! :) Thanks! was (Author: swapnilmmane): As discussed over the OFBiz Slack chat group, documented the process to initializing gradle wrapper in README.adoc for Linux based OS, please refer init-gradlew-readme.patch file. Added TODO note for MS Windows OS, as time allows [~jacques.le.roux] will help us here, thanks so much Jacques! :) Thanks! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847571#comment-16847571 ] Swapnil M Mane commented on OFBIZ-10145: As discussed over the OFBiz Slack chat group, documented the process to initializing gradle wrapper in README.adoc for Linux based OS, please refer init-gradlew-readme.patch file. Added TODO note for MS Windows OS, as time allows [~jacques.le.roux] will help us here, thanks so much Jacques! :) Thanks! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane updated OFBIZ-10145: --- Attachment: init-gradlew-readme.patch > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847378#comment-16847378
]
Swapnil M Mane commented on OFBIZ-10145:
+1 to commit, I have tested both the scripts on trunk and release17. Everything
is working as expected for me.
Thank you [~soledad] for your work and everyone for your comments.
[~soledad]
Just a small improvement, since now we are removing the corrupt archive, we
should change the message
from
{code}
echo "\nThe gradle-5.0-bin.zip file is corrupted.\nPlease remove this file from
$OFBIZ_HOME/runtime/tmp location and run the script again."
{code}
to
{code}
echo "\nThe gradle-5.0-bin.zip file was corrupted thus it is removed from
$OFBIZ_HOME/runtime/tmp location.\nNow please run the script again."
{code}
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10992) No pre-filled value while selecting "facilityId To" on Transfer Inventory Item screen
[ https://issues.apache.org/jira/browse/OFBIZ-10992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane updated OFBIZ-10992: --- Sprint: Community Day (May 2019) > No pre-filled value while selecting "facilityId To" on Transfer Inventory > Item screen > - > > Key: OFBIZ-10992 > URL: https://issues.apache.org/jira/browse/OFBIZ-10992 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Aishwary Shrivastava >Assignee: Swapnil M Mane >Priority: Minor > Attachments: NewFacility.png, OFBIZ-10992.patch, > TransferInventoryItem.png > > > While creating Transfer Inventory Item from warehouse, there are no prefiled > values in selecting FacilityId To. > Steps to regenerate: > # Go to Facilities. > # Select Inventory Xfers. > # Create Transfer Inventory Item From any Warehouse. > # Fill values in the feilds. > # Try to click on FacilityIdTo field > Attached the screenshots for creating new inventory item transfer screen and > new facility screen. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10833) CMS add content not working
[ https://issues.apache.org/jira/browse/OFBIZ-10833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831413#comment-16831413 ] Swapnil M Mane commented on OFBIZ-10833: Thanks [~jacques.le.roux]! > CMS add content not working > --- > > Key: OFBIZ-10833 > URL: https://issues.apache.org/jira/browse/OFBIZ-10833 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk, 17.12.01 >Reporter: Ingo Wolfmayr >Assignee: Swapnil M Mane >Priority: Major > Fix For: 17.12.01, 18.12.01 > > Attachments: LogCreateContent.txt, OFBIZ-10833.patch, > cms_addImage.patch > > > On demo: content --> "CmsSite" --> CMS: > Right click on one of the items to add "New Long Text" or "Image". > After saving the new content: > Edit WebSite CMS For: [] > "There is no Content PUBLISH_POINT for this WebSite!" > Having the same problem on a 17.12 local installation. > h1. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10833) CMS add content not working
[ https://issues.apache.org/jira/browse/OFBIZ-10833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830969#comment-16830969 ] Swapnil M Mane commented on OFBIZ-10833: Dear [~jacques.le.roux] , I have committed the patch which I uploaded for fixing the issue in which the parameters are not available to the next response type when form of enctype="multipart/form-data" type is submitted. I commit the change since this was the issue at our framework and needs to fix. But as mentioned by [~iwolf] in above comments, his problem doesn't fixed with this patch. I think, we should wait for him to confirm that his issue is resolve and then we can proceed to close this issue. WDYT? Thanks! > CMS add content not working > --- > > Key: OFBIZ-10833 > URL: https://issues.apache.org/jira/browse/OFBIZ-10833 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk, 17.12.01 >Reporter: Ingo Wolfmayr >Assignee: Swapnil M Mane >Priority: Major > Fix For: 17.12.01, 18.12.01 > > Attachments: LogCreateContent.txt, OFBIZ-10833.patch, > cms_addImage.patch > > > On demo: content --> "CmsSite" --> CMS: > Right click on one of the items to add "New Long Text" or "Image". > After saving the new content: > Edit WebSite CMS For: [] > "There is no Content PUBLISH_POINT for this WebSite!" > Having the same problem on a 17.12 local installation. > h1. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829422#comment-16829422
]
Swapnil M Mane commented on OFBIZ-10145:
Thanks, everyone for detailed discussion.
Loved your work [~soledad] ! :)
Here are my inputs and details on minor issue I faced
+*Issue faced:*+
The whereis -b $1 | grep / command in my machine is giving following error
{code:java}
whereis: illegal option -- b
usage: whereis program [...]{code}
I am using Mac, here are details of my OS
*macOS Mojave*
*Version 10.14.3 (18D109)*
I can understand that we used -b to search only for binaries in the script.
I also checked the manual of whereis command on mac using command
{code:java}
man whereis{code}
It also don't show -b option for whereis command on mac. (I know it generally
works for Linux based OS).
So, to fix this, I removed the -b option from whereis command in script.
After this everything works like charm for me.
Is anybody faced the same issue on the Mac?
+*Suggestion/Improvement:*+
When I run the script the first time (after above fix), it starts downloading
gradle. Now before completing the download, I mistakenly stop the downloading
by terminating the download process.
After this, I run the *init-gradle-wrapper-trunk-and-18.sh* script *again*.
But this time I got following error
{code:java}
Archive: gradle-5.0-bin.zip
End-of-central-directory signature not found. Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive. In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip: cannot find zipfile directory in one of gradle-5.0-bin.zip or
gradle-5.0-bin.zip.zip, and cannot find gradle-5.0-bin.zip.ZIP, period.
init-gradle-wrapper-trunk-and-18.sh: line 63:
./runtime/tmp/gradle-5.0/bin/gradle: No such file or directory{code}
Since my *gradle-5.0-bin.zip* was corrupted because I stoped the download
process in between.
The command
{code:java}
unzip gradle-5.0-bin.zip{code}
throws the above error.
To fix this, I removed the corrupted file and run the script again,and
everything worked as expected.
We can do an improvement here, after running the command *unzip
gradle-5.0-bin.zip*
If it fails, we can show the message to the user to remove the corrupted file
and run the script again.
Here is suggested code improvement
{code:java}
unzip $GRADLE_ZIP_RELEASE;
if [ $? -eq 0 ]; then
cd ../..
./runtime/tmp/$GRADLE_RELEASE/bin/$CMD_INIT_WRAPPER
else
echo "\nThe gradle-5.0-bin.zip file is corrupted.\nPlease remove this file
from
$OFBIZ_HOME/runtime/tmp location and run the script again."
fi{code}
Please feel free to share your thoughts on this.
Nice work [~soledad] , thanks again!
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-10994) Hello3:Error while loading seed data
[ https://issues.apache.org/jira/browse/OFBIZ-10994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane closed OFBIZ-10994. -- Resolution: Not A Problem Assignee: Swapnil M Mane > Hello3:Error while loading seed data > > > Key: OFBIZ-10994 > URL: https://issues.apache.org/jira/browse/OFBIZ-10994 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Release Branch 15.12 >Reporter: Arshitha k m >Assignee: Swapnil M Mane >Priority: Major > > hello, > I am new to OFBiz, I have completed hello1 and hello2, and currently facing > an issue to load seed data, using URL and text both generating the same error. > The Following Errors Occurred: > ERROR: parsing file: ERROR parsing Entity Xml file: org.xml.sax.SAXException: > A transaction error occurred reading > dataorg.ofbiz.entity.GenericEntityException: > org.ofbiz.entity.GenericEntityException: > org.ofbiz.entity.GenericEntityException: Error while inserting: > [GenericEntity:HelloHobby][createdStamp,2019-04-29 > 12:08:55.606(java.sql.Timestamp)][createdTxStamp,2019-04-29 > 12:08:55.154(java.sql.Timestamp)][description,Reading(java.lang.String)][helloHobbyId,READING(java.lang.String)][lastUpdatedStamp,2019-04-29 > 12:08:55.606(java.sql.Timestamp)][lastUpdatedTxStamp,2019-04-29 > 12:08:55.154(java.sql.Timestamp)] (SQL Exception while executing the > following:INSERT INTO OFBIZ.HELLO_HOBBY (HELLO_HOBBY_ID, DESCRIPTION, > LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) > VALUES (?, ?, ?, ?, ?, ?) (Column 'HELLO_PERSON_ID' cannot accept a NULL > value.)) > I tryed to import in to HelloPerson and that was successful. > Can you please help me to fix the trouble. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10993) error while loading seeddata
[ https://issues.apache.org/jira/browse/OFBIZ-10993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane closed OFBIZ-10993. -- Resolution: Not A Problem Assignee: Swapnil M Mane > error while loading seeddata > > > Key: OFBIZ-10993 > URL: https://issues.apache.org/jira/browse/OFBIZ-10993 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Reporter: Arshitha k m >Assignee: Swapnil M Mane >Priority: Major > > hi, > I am new to OFBiz .completed hello1and hello2 .currentlyfacing an issue to > import the seed data .iam getting an error as shown below, > The Following Errors Occurred: > ERROR: parsing file: ERROR parsing Entity Xml file: org.xml.sax.SAXException: > A transaction error occurred reading > dataorg.ofbiz.entity.GenericEntityException: > org.ofbiz.entity.GenericEntityException: > org.ofbiz.entity.GenericEntityException: Error while inserting: > [GenericEntity:HelloHobby][createdStamp,2019-04-29 > 12:08:55.606(java.sql.Timestamp)][createdTxStamp,2019-04-29 > 12:08:55.154(java.sql.Timestamp)][description,Reading(java.lang.String)][helloHobbyId,READING(java.lang.String)][lastUpdatedStamp,2019-04-29 > 12:08:55.606(java.sql.Timestamp)][lastUpdatedTxStamp,2019-04-29 > 12:08:55.154(java.sql.Timestamp)] (SQL Exception while executing the > following:INSERT INTO OFBIZ.HELLO_HOBBY (HELLO_HOBBY_ID, DESCRIPTION, > LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) > VALUES (?, ?, ?, ?, ?, ?) (Column 'HELLO_PERSON_ID' cannot accept a NULL > value.)) > tried to load seed data to the HelloPerson ,and that was successfull, > can you please help me to fix the trouble. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10993) error while loading seeddata
[ https://issues.apache.org/jira/browse/OFBIZ-10993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828969#comment-16828969 ] Swapnil M Mane commented on OFBIZ-10993: This query seems specific to the developer mailing list - (d...@ofbiz.apache.org) Please subscribe to the dev mailing list [1] before posting your question. [1] https://ofbiz.apache.org/mailing-lists.html Thanks! > error while loading seeddata > > > Key: OFBIZ-10993 > URL: https://issues.apache.org/jira/browse/OFBIZ-10993 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Reporter: Arshitha k m >Priority: Major > > hi, > I am new to OFBiz .completed hello1and hello2 .currentlyfacing an issue to > import the seed data .iam getting an error as shown below, > The Following Errors Occurred: > ERROR: parsing file: ERROR parsing Entity Xml file: org.xml.sax.SAXException: > A transaction error occurred reading > dataorg.ofbiz.entity.GenericEntityException: > org.ofbiz.entity.GenericEntityException: > org.ofbiz.entity.GenericEntityException: Error while inserting: > [GenericEntity:HelloHobby][createdStamp,2019-04-29 > 12:08:55.606(java.sql.Timestamp)][createdTxStamp,2019-04-29 > 12:08:55.154(java.sql.Timestamp)][description,Reading(java.lang.String)][helloHobbyId,READING(java.lang.String)][lastUpdatedStamp,2019-04-29 > 12:08:55.606(java.sql.Timestamp)][lastUpdatedTxStamp,2019-04-29 > 12:08:55.154(java.sql.Timestamp)] (SQL Exception while executing the > following:INSERT INTO OFBIZ.HELLO_HOBBY (HELLO_HOBBY_ID, DESCRIPTION, > LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) > VALUES (?, ?, ?, ?, ?, ?) (Column 'HELLO_PERSON_ID' cannot accept a NULL > value.)) > tried to load seed data to the HelloPerson ,and that was successfull, > can you please help me to fix the trouble. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10994) Hello3:Error while loading seed data
[ https://issues.apache.org/jira/browse/OFBIZ-10994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828975#comment-16828975 ] Swapnil M Mane commented on OFBIZ-10994: Hi [~Arshithakmanaf], As mentioned in comments of OFBIZ-10993 Please don't create JIRA tickets for your queries, mailing lists are appropriate for this kind of things. I request you to please read this comment again https://issues.apache.org/jira/browse/OFBIZ-10993?focusedCommentId=16828966=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16828966 And please avoid creating these types of issues in OFBiz Jira. Thanks! > Hello3:Error while loading seed data > > > Key: OFBIZ-10994 > URL: https://issues.apache.org/jira/browse/OFBIZ-10994 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Release Branch 15.12 >Reporter: Arshitha k m >Priority: Major > > hello, > I am new to OFBiz, I have completed hello1 and hello2, and currently facing > an issue to load seed data, using URL and text both generating the same error. > The Following Errors Occurred: > ERROR: parsing file: ERROR parsing Entity Xml file: org.xml.sax.SAXException: > A transaction error occurred reading > dataorg.ofbiz.entity.GenericEntityException: > org.ofbiz.entity.GenericEntityException: > org.ofbiz.entity.GenericEntityException: Error while inserting: > [GenericEntity:HelloHobby][createdStamp,2019-04-29 > 12:08:55.606(java.sql.Timestamp)][createdTxStamp,2019-04-29 > 12:08:55.154(java.sql.Timestamp)][description,Reading(java.lang.String)][helloHobbyId,READING(java.lang.String)][lastUpdatedStamp,2019-04-29 > 12:08:55.606(java.sql.Timestamp)][lastUpdatedTxStamp,2019-04-29 > 12:08:55.154(java.sql.Timestamp)] (SQL Exception while executing the > following:INSERT INTO OFBIZ.HELLO_HOBBY (HELLO_HOBBY_ID, DESCRIPTION, > LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) > VALUES (?, ?, ?, ?, ?, ?) (Column 'HELLO_PERSON_ID' cannot accept a NULL > value.)) > I tryed to import in to HelloPerson and that was successful. > Can you please help me to fix the trouble. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10993) error while loading seeddata
[ https://issues.apache.org/jira/browse/OFBIZ-10993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828966#comment-16828966 ] Swapnil M Mane commented on OFBIZ-10993: Hello Arshitha, Welcome to Apache OFBiz ecosystem. OFBiz Jira is not the right place for asking your queries. It for tracking bugs and improvement in OFBiz. Please ask your questions/queries on the user mailing list - (u...@ofbiz.apache.org). You will get wider audience support there. Please subscribe to the mailing list before posting your question. For more detail, refer Apache OFBiz mailing list [1] I am closing this issue, please post your queries on the user mailing list along with details. [1] https://ofbiz.apache.org/mailing-lists.html Thanks! > error while loading seeddata > > > Key: OFBIZ-10993 > URL: https://issues.apache.org/jira/browse/OFBIZ-10993 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Reporter: Arshitha k m >Priority: Major > > hi, > I am new to OFBiz .completed hello1and hello2 .currentlyfacing an issue to > import the seed data .iam getting an error as shown below, > The Following Errors Occurred: > ERROR: parsing file: ERROR parsing Entity Xml file: org.xml.sax.SAXException: > A transaction error occurred reading > dataorg.ofbiz.entity.GenericEntityException: > org.ofbiz.entity.GenericEntityException: > org.ofbiz.entity.GenericEntityException: Error while inserting: > [GenericEntity:HelloHobby][createdStamp,2019-04-29 > 12:08:55.606(java.sql.Timestamp)][createdTxStamp,2019-04-29 > 12:08:55.154(java.sql.Timestamp)][description,Reading(java.lang.String)][helloHobbyId,READING(java.lang.String)][lastUpdatedStamp,2019-04-29 > 12:08:55.606(java.sql.Timestamp)][lastUpdatedTxStamp,2019-04-29 > 12:08:55.154(java.sql.Timestamp)] (SQL Exception while executing the > following:INSERT INTO OFBIZ.HELLO_HOBBY (HELLO_HOBBY_ID, DESCRIPTION, > LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) > VALUES (?, ?, ?, ?, ?, ?) (Column 'HELLO_PERSON_ID' cannot accept a NULL > value.)) > tried to load seed data to the HelloPerson ,and that was successfull, > can you please help me to fix the trouble. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10966) JSON entity data import and export utility
[
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827975#comment-16827975
]
Swapnil M Mane commented on OFBIZ-10966:
+1 [~jayansh], looking forward on this, thanks!
> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Reporter: Jayansh Shinde
>Priority: Minor
>
> Currently, we support import/export entity data in XML format.
> Nowadays JSON is widely used in industry, we can have support for JSON
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
>
> {code}
> {code:java}
> {“Party”:
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>
> *Import Design*
> The import service will perform following operations:
> 1.) Validate the input JSON data (I am in process of exploring the way for
> this)
> 2.) On successful validation, convert JSON to OFBiz's entity model
> (GenericValue)
> 3.) The GenericValue will be inserted in database by some handler class for
> e.g we can write JsonDataHandler, it will convert given JSON to
> List, and finally write it to database (Similar pattern is used
> in XML import).
>
> *Export Design*
> Based on existing XML pattern the writeXmlText method of GenericEntity class
> write the exported data in XML format.
> In the similar way, we can implement writeJsonText to export data in JSON
> format.
> Please free feel to share your thought.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10958) Service createProductFeature ignores passed productFeatureId
[
https://issues.apache.org/jira/browse/OFBIZ-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827971#comment-16827971
]
Swapnil M Mane commented on OFBIZ-10958:
;)
> Service createProductFeature ignores passed productFeatureId
>
>
> Key: OFBIZ-10958
> URL: https://issues.apache.org/jira/browse/OFBIZ-10958
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Swapnil M Mane
>Priority: Minor
> Fix For: 16.11.06
>
> Attachments: OFBIZ-10958_Fix_createProductFeature.patch
>
>
> Service "createProductFeature" ignores passed productFeatureId caused by
> overwritten output parameter. If I do following changes, this problem
> disappears.
> original:
> {code:xml}
> default-entity-name="ProductFeature" auth="true">
> Create a ProductFeature record
>
> optional="false"/>
>
>
>
> {code}
> Fix:
> {code:xml}
> default-entity-name="ProductFeature" auth="true">
> Create a ProductFeature record
>
> optional="true"/>
>
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-10958) Service createProductFeature ignores passed productFeatureId
[
https://issues.apache.org/jira/browse/OFBIZ-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Swapnil M Mane closed OFBIZ-10958.
--
Resolution: Fixed
Fix Version/s: 16.11.06
> Service createProductFeature ignores passed productFeatureId
>
>
> Key: OFBIZ-10958
> URL: https://issues.apache.org/jira/browse/OFBIZ-10958
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Swapnil M Mane
>Priority: Minor
> Fix For: 16.11.06
>
> Attachments: OFBIZ-10958_Fix_createProductFeature.patch
>
>
> Service "createProductFeature" ignores passed productFeatureId caused by
> overwritten output parameter. If I do following changes, this problem
> disappears.
> original:
> {code:xml}
> default-entity-name="ProductFeature" auth="true">
> Create a ProductFeature record
>
> optional="false"/>
>
>
>
> {code}
> Fix:
> {code:xml}
> default-entity-name="ProductFeature" auth="true">
> Create a ProductFeature record
>
> optional="true"/>
>
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10958) Service createProductFeature ignores passed productFeatureId
[
https://issues.apache.org/jira/browse/OFBIZ-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827962#comment-16827962
]
Swapnil M Mane commented on OFBIZ-10958:
Thank you [~uHeidfeld] for reporting the issue and provide the patch, it is
highly appreciated!
I have committed your code in
trunk at rev #1858319
release18.12 at rev #1858320
release17.12 at rev #1858321
release16.11 at rev #1858322
Along with this, I have done some exploration, here are my finding (adding here
just for informational purpose and future reference)
Here we can't make the changes mentioned below, because, for *optional* field's
value, invokeCreate method (internally calling isIn and IsOut methods of
ModelParam) of EntityAutoEngine.java consider the attribute (override) defined
at last for parameters with the same name.
i.e. for below example, optional value for productFeatureId for mode IN will
be false (but it is defined true)
{code}
{code}
Due to this, isSinglePkIn (in invokeCreate method) field got false value, and
the system will auto-generate the productFeatureId and ignore the user's input.
Similarly, we can't write in this way
{code}
{code}
Because in this case, isSinglePkOut (in invokeCreate method) field got false
value, and again the system will auto-generate the productFeatureId and ignore
the user's input.
Thanks!
> Service createProductFeature ignores passed productFeatureId
>
>
> Key: OFBIZ-10958
> URL: https://issues.apache.org/jira/browse/OFBIZ-10958
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Swapnil M Mane
>Priority: Minor
> Attachments: OFBIZ-10958_Fix_createProductFeature.patch
>
>
> Service "createProductFeature" ignores passed productFeatureId caused by
> overwritten output parameter. If I do following changes, this problem
> disappears.
> original:
> {code:xml}
> default-entity-name="ProductFeature" auth="true">
> Create a ProductFeature record
>
> optional="false"/>
>
>
>
> {code}
> Fix:
> {code:xml}
> default-entity-name="ProductFeature" auth="true">
> Create a ProductFeature record
>
> optional="true"/>
>
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10992) No pre-filled value while selecting "facilityId To" on Transfer Inventory Item screen
[ https://issues.apache.org/jira/browse/OFBIZ-10992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane reassigned OFBIZ-10992: -- Assignee: Swapnil M Mane (was: Aishwary Shrivastava) > No pre-filled value while selecting "facilityId To" on Transfer Inventory > Item screen > - > > Key: OFBIZ-10992 > URL: https://issues.apache.org/jira/browse/OFBIZ-10992 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Aishwary Shrivastava >Assignee: Swapnil M Mane >Priority: Minor > Attachments: NewFacility.png, OFBIZ-10992.patch, > TransferInventoryItem.png > > > While creating Transfer Inventory Item from warehouse, there are no prefiled > values in selecting FacilityId To. > Steps to regenerate: > # Go to Facilities. > # Select Inventory Xfers. > # Create Transfer Inventory Item From any Warehouse. > # Fill values in the feilds. > # Try to click on FacilityIdTo field > Attached the screenshots for creating new inventory item transfer screen and > new facility screen. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10965) Error while checkout from WebPOS
[ https://issues.apache.org/jira/browse/OFBIZ-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane reassigned OFBIZ-10965: -- Assignee: Swapnil M Mane > Error while checkout from WebPOS > - > > Key: OFBIZ-10965 > URL: https://issues.apache.org/jira/browse/OFBIZ-10965 > Project: OFBiz > Issue Type: Bug > Components: webpos >Affects Versions: 17.12.01 >Reporter: Padmavati Rawat >Assignee: Swapnil M Mane >Priority: Major > Attachments: Errorwhilecheckout.png, OFBIZ-10965 > > > Steps: > 1. Login to the POS Terminal. > 2. Add item to the cart. > 3. Set payment by pay cash "F3 PAY CASH" > 4. click on checkout key "F8 CHECKOUT" > Actual: > System showing an error on the cart section while checkout. > Expected: > The order should be successfully placed. > Please refer screenshot: -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10356) Display of entities in text input field for Product Name
[
https://issues.apache.org/jira/browse/OFBIZ-10356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827622#comment-16827622
]
Swapnil M Mane commented on OFBIZ-10356:
Thank you [~rmallah], [~jacques.le.roux] and [~ankit.joshi] !
> Display of entities in text input field for Product Name
>
>
> Key: OFBIZ-10356
> URL: https://issues.apache.org/jira/browse/OFBIZ-10356
> Project: OFBiz
> Issue Type: Bug
> Components: product
>Reporter: Rajesh Kumar Mallah
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments: OFBIZ-10356.patch
>
>
> In the url:
> https://demo-stable.ofbiz.apache.org/catalog/control/EditProductContent?productId=GZ-1006-1
> the "Product Name" under "Override Simple Fields" is unnecessarily
> expressed in entity format . The string displayed in product name
> field is:{code}"Open Gizmo LGPL" {code} it could have been a
> simple "Open Gizmo (LGPL)"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-10039) HTML code is shown on hover the product, listed under 'Featured Products' section
[ https://issues.apache.org/jira/browse/OFBIZ-10039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane closed OFBIZ-10039. -- Resolution: Cannot Reproduce > HTML code is shown on hover the product, listed under 'Featured Products' > section > - > > Key: OFBIZ-10039 > URL: https://issues.apache.org/jira/browse/OFBIZ-10039 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Swapnil M Mane >Assignee: Swapnil M Mane >Priority: Minor > Attachments: hover-featured-product.png > > > On hover the products listed under the 'Featured Products' section, the HTML > code is shown. > Please refer the attached screenshot for the more details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (OFBIZ-10039) HTML code is shown on hover the product, listed under 'Featured Products' section
[ https://issues.apache.org/jira/browse/OFBIZ-10039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane reopened OFBIZ-10039: > HTML code is shown on hover the product, listed under 'Featured Products' > section > - > > Key: OFBIZ-10039 > URL: https://issues.apache.org/jira/browse/OFBIZ-10039 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Swapnil M Mane >Assignee: Swapnil M Mane >Priority: Minor > Attachments: hover-featured-product.png > > > On hover the products listed under the 'Featured Products' section, the HTML > code is shown. > Please refer the attached screenshot for the more details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10039) HTML code is shown on hover the product, listed under 'Featured Products' section
[ https://issues.apache.org/jira/browse/OFBIZ-10039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane closed OFBIZ-10039. -- Resolution: Fixed > HTML code is shown on hover the product, listed under 'Featured Products' > section > - > > Key: OFBIZ-10039 > URL: https://issues.apache.org/jira/browse/OFBIZ-10039 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Swapnil M Mane >Assignee: Swapnil M Mane >Priority: Minor > Attachments: hover-featured-product.png > > > On hover the products listed under the 'Featured Products' section, the HTML > code is shown. > Please refer the attached screenshot for the more details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10039) HTML code is shown on hover the product, listed under 'Featured Products' section
[ https://issues.apache.org/jira/browse/OFBIZ-10039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827507#comment-16827507 ] Swapnil M Mane commented on OFBIZ-10039: It seems this issue is fixed in other refactoring work of bootstrap. Everything is now working as expected, thus closing the ticket. Thanks! > HTML code is shown on hover the product, listed under 'Featured Products' > section > - > > Key: OFBIZ-10039 > URL: https://issues.apache.org/jira/browse/OFBIZ-10039 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Swapnil M Mane >Assignee: Swapnil M Mane >Priority: Minor > Attachments: hover-featured-product.png > > > On hover the products listed under the 'Featured Products' section, the HTML > code is shown. > Please refer the attached screenshot for the more details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10039) HTML code is shown on hover the product, listed under 'Featured Products' section
[ https://issues.apache.org/jira/browse/OFBIZ-10039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane reassigned OFBIZ-10039: -- Assignee: Swapnil M Mane > HTML code is shown on hover the product, listed under 'Featured Products' > section > - > > Key: OFBIZ-10039 > URL: https://issues.apache.org/jira/browse/OFBIZ-10039 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Swapnil M Mane >Assignee: Swapnil M Mane >Priority: Minor > Attachments: hover-featured-product.png > > > On hover the products listed under the 'Featured Products' section, the HTML > code is shown. > Please refer the attached screenshot for the more details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10720) How to integrate OfBiz framework with spring micro service
[ https://issues.apache.org/jira/browse/OFBIZ-10720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826952#comment-16826952 ] Swapnil M Mane commented on OFBIZ-10720: Hi [~vemulabujji] , I am closing this ticket. As mentioned above, please use mailing list to ask your questions. Thanks! > How to integrate OfBiz framework with spring micro service > -- > > Key: OFBIZ-10720 > URL: https://issues.apache.org/jira/browse/OFBIZ-10720 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: 16.11.05 >Reporter: Bojjanna >Assignee: Swapnil M Mane >Priority: Major > > Dear, > I would like to integrate the OfBiz framework with Spring micro service. > Please help to provide best solution,how i can invoke the OfBiz server from > my application. > > Thanks > Vemula > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10720) How to integrate OfBiz framework with spring micro service
[ https://issues.apache.org/jira/browse/OFBIZ-10720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane closed OFBIZ-10720. -- Resolution: Invalid > How to integrate OfBiz framework with spring micro service > -- > > Key: OFBIZ-10720 > URL: https://issues.apache.org/jira/browse/OFBIZ-10720 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: 16.11.05 >Reporter: Bojjanna >Assignee: Swapnil M Mane >Priority: Major > > Dear, > I would like to integrate the OfBiz framework with Spring micro service. > Please help to provide best solution,how i can invoke the OfBiz server from > my application. > > Thanks > Vemula > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10720) How to integrate OfBiz framework with spring micro service
[ https://issues.apache.org/jira/browse/OFBIZ-10720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane reassigned OFBIZ-10720: -- Assignee: Swapnil M Mane > How to integrate OfBiz framework with spring micro service > -- > > Key: OFBIZ-10720 > URL: https://issues.apache.org/jira/browse/OFBIZ-10720 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: 16.11.05 >Reporter: Bojjanna >Assignee: Swapnil M Mane >Priority: Major > > Dear, > I would like to integrate the OfBiz framework with Spring micro service. > Please help to provide best solution,how i can invoke the OfBiz server from > my application. > > Thanks > Vemula > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10237) The leads which are converted is displayed on the Find lead page.
[ https://issues.apache.org/jira/browse/OFBIZ-10237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane reassigned OFBIZ-10237: -- Assignee: Swapnil M Mane > The leads which are converted is displayed on the Find lead page. > - > > Key: OFBIZ-10237 > URL: https://issues.apache.org/jira/browse/OFBIZ-10237 > Project: OFBiz > Issue Type: Bug >Reporter: Rubia Elza Joshep >Assignee: Swapnil M Mane >Priority: Major > Attachments: OFBIZ-10237.patch > > > Steps to regenerate: > 1) Open URL > [https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads|http://example.com/] > 2) Create a lead. Check for the lead in Find lead page. > 3) Convert the lead by clicking on "Create Lead" button. The lead is > successfully converted to contact/ Account. > Actual: The lead which is converted is displayed on the Find lead page. > Expected: Since the lead is converted to contact/Account it should not be > displayed on the Find lead page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10749) Unable to submit set Billing form in order manager when payment method is EFT
[ https://issues.apache.org/jira/browse/OFBIZ-10749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane reassigned OFBIZ-10749: -- Assignee: Swapnil M Mane > Unable to submit set Billing form in order manager when payment method is EFT > - > > Key: OFBIZ-10749 > URL: https://issues.apache.org/jira/browse/OFBIZ-10749 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Swapnil M Mane >Priority: Major > Attachments: 1-SetCustomer.png, 10-ConsoleError.png, 2-Continue.png, > 3-AddProduct.png, 4-QuickFinalizeOrder.png, 5-EftAccount.png, > 6-TelecomNumber.png, 7-Address.png, 8-EFT.png, 9-BillingAddress.png, > OFBIZ-10749.patch > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main] > # Click on order entry > # Set customer and click on continue (Please refer attachment: 1-SetCustomer) > # Click continue on Enter Order Currency, Agreements, and Ship Dates page > (Please refer attachment: 2-Continue) > # Add product and click on Quick Finalize Order (Please refer attachment: > 3-AddProduct) > # On Quick Finalize Order page select UPS Air and click on EFT Account > (Please refer attachment: 4-QuickFinalizeOrder) > # Enter account details but do not select billing address and click on Save > button(Please refer attachment: 5-EftAccount) > # Add phone and email address and click on continue (Please refer > attachment: 6-TelecomNumber) > # Enter address (Please refer attachment: 7-Address) > # Click continue on Sales Order : Order Entry Order Terms page > # Select Electronic Fund Transfer on Sales Order : Order Entry Payment > Settings and click continue (Please refer attachment: 8-EFT) > # Enter billing address and click on continue (Please refer attachment: > 9-BillingAddress) > Actual: Unable to Submit form and error message was displayed on console > (Please refer attachment: 10-ConsoleError) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10958) Service createProductFeature ignores passed productFeatureId
[
https://issues.apache.org/jira/browse/OFBIZ-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Swapnil M Mane reassigned OFBIZ-10958:
--
Assignee: Swapnil M Mane (was: Ulrich Heidfeld)
> Service createProductFeature ignores passed productFeatureId
>
>
> Key: OFBIZ-10958
> URL: https://issues.apache.org/jira/browse/OFBIZ-10958
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Swapnil M Mane
>Priority: Minor
> Attachments: OFBIZ-10958_Fix_createProductFeature.patch
>
>
> Service "createProductFeature" ignores passed productFeatureId caused by
> overwritten output parameter. If I do following changes, this problem
> disappears.
> original:
> {code:xml}
> default-entity-name="ProductFeature" auth="true">
> Create a ProductFeature record
>
> optional="false"/>
>
>
>
> {code}
> Fix:
> {code:xml}
> default-entity-name="ProductFeature" auth="true">
> Create a ProductFeature record
>
> optional="true"/>
>
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10833) CMS add content not working
[ https://issues.apache.org/jira/browse/OFBIZ-10833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824981#comment-16824981 ] Swapnil M Mane commented on OFBIZ-10833: Fixed the issue in which the parameters are not available to the next response type when form of enctype="multipart/form-data" type is submitted. Changes committed in trunk at rev 1858035 release18.12 at rev 1858036 release17.12 at rev 1858037 Issue does not exist in release16.11 Thanks! > CMS add content not working > --- > > Key: OFBIZ-10833 > URL: https://issues.apache.org/jira/browse/OFBIZ-10833 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk, 17.12.01 >Reporter: Ingo Wolfmayr >Assignee: Swapnil M Mane >Priority: Major > Attachments: LogCreateContent.txt, OFBIZ-10833.patch, > cms_addImage.patch > > > On demo: content --> "CmsSite" --> CMS: > Right click on one of the items to add "New Long Text" or "Image". > After saving the new content: > Edit WebSite CMS For: [] > "There is no Content PUBLISH_POINT for this WebSite!" > Having the same problem on a 17.12 local installation. > h1. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10939) @Override annotations should be used when possible
[ https://issues.apache.org/jira/browse/OFBIZ-10939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823691#comment-16823691 ] Swapnil M Mane edited comment on OFBIZ-10939 at 4/23/19 5:26 AM: - Hi [~mthl] , On cursory view, the patch looks good to me, +1 to proceed with this change. Thanks for your work! was (Author: swapnilmmane): Hi [~mthl] , On cursery view, the patch looks good to me, +1 to proceed with this change. Thanks for your work! > @Override annotations should be used when possible > -- > > Key: OFBIZ-10939 > URL: https://issues.apache.org/jira/browse/OFBIZ-10939 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10939_Use-the-Override-annotation.patch > > > The ‘@Override’ annotation helps readers to understand that the method > at hand is overriding a super class or implementing an interface. > Additionally it allows the compiler to check if the methods annotated > with ‘@Override’ are actually implementing an abstract method. > Using that annotation makes ‘@see foo.bar.ParentClass#myMethod’ > comments useless. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10939) @Override annotations should be used when possible
[ https://issues.apache.org/jira/browse/OFBIZ-10939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823691#comment-16823691 ] Swapnil M Mane commented on OFBIZ-10939: Hi [~mthl] , On cursery view, the patch looks good to me, +1 to proceed with this change. Thanks for your work! > @Override annotations should be used when possible > -- > > Key: OFBIZ-10939 > URL: https://issues.apache.org/jira/browse/OFBIZ-10939 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10939_Use-the-Override-annotation.patch > > > The ‘@Override’ annotation helps readers to understand that the method > at hand is overriding a super class or implementing an interface. > Additionally it allows the compiler to check if the methods annotated > with ‘@Override’ are actually implementing an abstract method. > Using that annotation makes ‘@see foo.bar.ParentClass#myMethod’ > comments useless. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4690) If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.
[ https://issues.apache.org/jira/browse/OFBIZ-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821944#comment-16821944 ] Swapnil M Mane commented on OFBIZ-4690: --- The change of calling 'cancelPicklistAndItems' action service in sync mode is committed in trunk at rev 1857813 release18.12 at rev 1857814 release17.12 at rev 1857815 release16.11 at rev 1857816 Thanks! > If Picklist is Cancelled than all the PicklistItem related to that PicklistId > should also get Cancel. > -- > > Key: OFBIZ-4690 > URL: https://issues.apache.org/jira/browse/OFBIZ-4690 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Release 10.04, Release Branch 11.04, Trunk >Reporter: Ankit Jain >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-4690.patch > > > If Picklist is Cancelled than all the PicklistItem related to that PicklistId > should also get Cancel. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4690) If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.
[ https://issues.apache.org/jira/browse/OFBIZ-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821919#comment-16821919 ] Swapnil M Mane commented on OFBIZ-4690: --- Thank you [~jacques.le.roux] ! > If Picklist is Cancelled than all the PicklistItem related to that PicklistId > should also get Cancel. > -- > > Key: OFBIZ-4690 > URL: https://issues.apache.org/jira/browse/OFBIZ-4690 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Release 10.04, Release Branch 11.04, Trunk >Reporter: Ankit Jain >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-4690.patch > > > If Picklist is Cancelled than all the PicklistItem related to that PicklistId > should also get Cancel. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4690) If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.
[ https://issues.apache.org/jira/browse/OFBIZ-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821809#comment-16821809 ] Swapnil M Mane commented on OFBIZ-4690: --- Dear [~jacques.le.roux], Thanks for your comment. Should I proceed to change the calling of 'cancelPicklistAndItems' action service in sync mode. Thanks! > If Picklist is Cancelled than all the PicklistItem related to that PicklistId > should also get Cancel. > -- > > Key: OFBIZ-4690 > URL: https://issues.apache.org/jira/browse/OFBIZ-4690 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Release 10.04, Release Branch 11.04, Trunk >Reporter: Ankit Jain >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-4690.patch > > > If Picklist is Cancelled than all the PicklistItem related to that PicklistId > should also get Cancel. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10932) Updating an OrderItem loses supplierProductId
[ https://issues.apache.org/jira/browse/OFBIZ-10932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821677#comment-16821677 ] Swapnil M Mane commented on OFBIZ-10932: Good catch, thanks [~paul_foxworthy]. The patch looks good to me and working as expected. > Updating an OrderItem loses supplierProductId > - > > Key: OFBIZ-10932 > URL: https://issues.apache.org/jira/browse/OFBIZ-10932 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, 17.12.01, 18.12.01 >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Minor > Labels: order, order_item > Fix For: Trunk, 17.12.01, 18.12.01 > > Attachments: > OFBIZ-10932_Preserve_supplierProductId_when_updating_OrderItem.patch > > > When you edit on order item, the details are reloaded into a shopping cart > and after editing the order is updated from the cart. At present the > supplierProductId for the order item is not read into the cart. > > Try this in the demo site: > Product GZ-1000 has several suppliers, including BigSupplier > Order-Order Entry > In Purchase Order, choose BigSupplier, click Continue > In "Enter Order, Agreements and Ship Dates", click Continue > In Create Purchase Order, enter Product ID of GZ-1000 and Quantity of 500 > Click Finalize Order > Click Continue several times to reach Purchase Order: Order Confirmation > Click Create Order > Note Purchase Order number. When I did this, it was 1 > Applications - Web Tools > Click Entity Data Maintenance > In Filter by Entity Name, choose OrderItem, click Apply > Click OrderItem in the Entity Name column > Enter Purchase Order number, e.g. 1 > Scroll down and click Search > Observe that the OrderItem has a SupplierProductId of BKGZ_1000 as you'd > expect > Applications - Order - Find Order > Enter Order ID (e.g. 1) and click Find > In Actions, click Edit Items > Change Unit Price from 3.75 to 4.00, check checkbox next to Unit Price, and > click Update Selected Items > Return to Entity Data Maintenance in the Web Tools, and find the OrderItem > for the purchase order again > You'll see that the SupplierProductId has been lost > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10377) Missing oldStatusId in error when no status valid change record found
[ https://issues.apache.org/jira/browse/OFBIZ-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane closed OFBIZ-10377. -- Resolution: Fixed Fix Version/s: 16.11.06 > Missing oldStatusId in error when no status valid change record found > - > > Key: OFBIZ-10377 > URL: https://issues.apache.org/jira/browse/OFBIZ-10377 > Project: OFBiz > Issue Type: Improvement >Reporter: Lalit Dashora >Assignee: Swapnil M Mane >Priority: Major > Fix For: 16.11.06 > > Attachments: StatusIssue.patch > > > If no transaction for status valid change is found, OldStatusId is missing on > the console while showing error. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-6892) new action expire for service engine entity-auto
[ https://issues.apache.org/jira/browse/OFBIZ-6892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805647#comment-16805647 ] Swapnil M Mane commented on OFBIZ-6892: --- Thanks [~lalit.dashora], OFBIZ-10377 is taken care. > new action expire for service engine entity-auto > > > Key: OFBIZ-6892 > URL: https://issues.apache.org/jira/browse/OFBIZ-6892 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Fix For: 16.11.01 > > Attachments: OFBIZ-6892.patch > > > Relate to the thread > http://ofbiz.135035.n4.nabble.com/entity-auto-and-cancel-operation-td4676929.html > on the dev mailing list, I load the patch to manage the action expire. > When you call *expire* on a entity : > * if a date field is present on service attribute, OFBiz try to expire it > with the given value or with now date > * else try to expire thruDate field > * else try to expire *ThruDate or thru*Date field > The patch contains the new action, a code refactoring to separate each action > on dedicate function and unit test associate. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10377) Missing oldStatusId in error when no status valid change record found
[ https://issues.apache.org/jira/browse/OFBIZ-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805645#comment-16805645 ] Swapnil M Mane commented on OFBIZ-10377: Thanks [~lalit.dashora] for your contibution. You patch is committed in trunk at rev 1856598 release18.12 at rev 1856599 release17.12 at rev 1856600 release16.11 at rev 1856601 I also face the similar issue and debug it, here are few notes on issue and steps to test (commenting for futur reference) Issue: In the case of entity auto service, when an invalid status change is performed, the error message doesn't show the current status of the item from which the user is changing the status. e.g. Change the status of 'In Progress' marketing campaign to 'Planned' 1.) Navigate to https://demo-trunk.ofbiz.apache.org/marketing/control/FindMarketingCampaign 2.) Select any 'In Progress' marketing campaign 3.) Change status to 'Planned' The error shown is: Error: status change from [] to [MKTG_CAMP_PLANNED] is not allowed. After the above commits, this issue is fixed. Thanks! > Missing oldStatusId in error when no status valid change record found > - > > Key: OFBIZ-10377 > URL: https://issues.apache.org/jira/browse/OFBIZ-10377 > Project: OFBiz > Issue Type: Improvement >Reporter: Lalit Dashora >Assignee: Swapnil M Mane >Priority: Major > Attachments: StatusIssue.patch > > > If no transaction for status valid change is found, OldStatusId is missing on > the console while showing error. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
