[jira] [Commented] (OFBIZ-10691) Refactoring ‘EntityCondition’

2018-12-28 Thread Gil Portenseigne (JIRA) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-10691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730275#comment-16730275
 ] 

Gil Portenseigne commented on OFBIZ-10691:
--

Thanks Mathieu, I did review a last time and tested the application. I did not 
see any issue. I'll communicate on dev mailing list and will commit that 
without squashing next week.

> Refactoring ‘EntityCondition’
> -
>
> Key: OFBIZ-10691
> URL: https://issues.apache.org/jira/browse/OFBIZ-10691
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10691_0001-Remove-EntityConditionBase-class.patch, 
> OFBIZ-10691_0002-Turn-EntityCondition-into-an-interface.patch, 
> OFBIZ-10691_0003-Rename-EntityConditionFunction-class-into-EntityNotC.patch, 
> OFBIZ-10691_0004-Rewrite-EntityConditionList-class.patch, 
> OFBIZ-10691_0005-Rewrite-EntityFieldMap-class.patch, 
> OFBIZ-10691_0006-Rewrite-EntityWhereString-class.patch, 
> OFBIZ-10691_0007-Rewrite-EntityDateFilterCondition-class.patch, 
> OFBIZ-10691_0008-Rewrite-EntityExpr-class.patch, 
> OFBIZ-10691_0009-Rewrite-EntityConditionListBase-class.patch
>
>
> The {{EntityConditionBase}} class hierarchy is abusing inheritance in order 
> to share code between {{EntityCondition}}, {{EntityOperator}}, and 
> {{EntityConditionValue}}. Additionally it contains some dead code and some 
> poorly documented classes/methods.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-10691) Refactoring ‘EntityCondition’

2018-12-19 Thread Mathieu Lirzin (JIRA) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-10691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724805#comment-16724805
 ] 

Mathieu Lirzin commented on OFBIZ-10691:


I have rebased the patches on {{trunk}}.

Exceptionally a {{serialVersionUID}} has been used instead of suppressing the 
"serial" warning for the {{EntityCondition}} interface to satisfy both Eclipse 
and {{javac}} linting features which disagree regarding the necessity of using 
the {{@SuppressWarnings}} annotation in the case of interfaces extending 
{{Serializable}}.

> Refactoring ‘EntityCondition’
> -
>
> Key: OFBIZ-10691
> URL: https://issues.apache.org/jira/browse/OFBIZ-10691
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10691_0001-Remove-EntityConditionBase-class.patch, 
> OFBIZ-10691_0002-Turn-EntityCondition-into-an-interface.patch, 
> OFBIZ-10691_0003-Rename-EntityConditionFunction-class-into-EntityNotC.patch, 
> OFBIZ-10691_0004-Rewrite-EntityConditionList-class.patch, 
> OFBIZ-10691_0005-Rewrite-EntityFieldMap-class.patch, 
> OFBIZ-10691_0006-Rewrite-EntityWhereString-class.patch, 
> OFBIZ-10691_0007-Rewrite-EntityDateFilterCondition-class.patch, 
> OFBIZ-10691_0008-Rewrite-EntityExpr-class.patch, 
> OFBIZ-10691_0009-Rewrite-EntityConditionListBase-class.patch
>
>
> The {{EntityConditionBase}} class hierarchy is abusing inheritance in order 
> to share code between {{EntityCondition}}, {{EntityOperator}}, and 
> {{EntityConditionValue}}. Additionally it contains some dead code and some 
> poorly documented classes/methods.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-10691) Refactoring ‘EntityCondition’

2018-12-04 Thread Mathieu Lirzin (JIRA) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-10691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709379#comment-16709379
 ] 

Mathieu Lirzin commented on OFBIZ-10691:


I have included a series of patches to improve the current situation.  Those 
patches are meant to be applied in order and if they were to be committed I 
don't recommend squashing them since The resulting diff would become quite 
unreadable.  The rationale for each patch is included at the top of the file.

> Refactoring ‘EntityCondition’
> -
>
> Key: OFBIZ-10691
> URL: https://issues.apache.org/jira/browse/OFBIZ-10691
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10691_0001-Remove-EntityConditionBase-class.patch, 
> OFBIZ-10691_0002-Turn-EntityCondition-into-an-interface.patch, 
> OFBIZ-10691_0003-Rename-EntityConditionFunction-class-into-EntityNotC.patch, 
> OFBIZ-10691_0004-Rewrite-EntityConditionList-class.patch, 
> OFBIZ-10691_0005-Rewrite-EntityFieldMap-class.patch, 
> OFBIZ-10691_0006-Rewrite-EntityWhereString-class.patch, 
> OFBIZ-10691_0007-Rewrite-EntityDateFilterCondition-class.patch, 
> OFBIZ-10691_0008-Rewrite-EntityExpr-class.patch, 
> OFBIZ-10691_0009-Rewrite-EntityConditionListBase-class.patch
>
>
> The {{EntityConditionBase}} class hierarchy is abusing inheritance in order 
> to share code between {{EntityCondition}}, {{EntityOperator}}, and 
> {{EntityConditionValue}}. Additionally it contains some dead code and some 
> poorly documented classes/methods.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)