[jira] [Commented] (OFBIZ-11319) processorder is submitted as GET instead of POST

2020-01-18 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018648#comment-17018648
 ] 

Jacques Le Roux commented on OFBIZ-11319:
-

Great, thanks James!

> processorder is submitted as GET instead of POST
> 
>
> Key: OFBIZ-11319
> URL: https://issues.apache.org/jira/browse/OFBIZ-11319
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch, Release Branch 17.12, Release Branch 
> 18.12
>
> Attachments: OFBIZ-11319_Plugins.patch, OFBIZ-11319_Plugins.patch
>
>
> During checkout of shopping cart, it is observed that the processorder of the 
> form action is submitted as GET which is incorrect. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11319) processorder is submitted as GET instead of POST

2020-01-18 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018642#comment-17018642
 ] 

James Yong commented on OFBIZ-11319:


Thanks [~jleroux] for the guidance on backporting the code.

The changes are backported to release 18.12 & 17.12.

> processorder is submitted as GET instead of POST
> 
>
> Key: OFBIZ-11319
> URL: https://issues.apache.org/jira/browse/OFBIZ-11319
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11319_Plugins.patch, OFBIZ-11319_Plugins.patch
>
>
> During checkout of shopping cart, it is observed that the processorder of the 
> form action is submitted as GET which is incorrect. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11319) processorder is submitted as GET instead of POST

2020-01-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018641#comment-17018641
 ] 

ASF subversion and git services commented on OFBIZ-11319:
-

Commit a183733775b82b2f853b16420328d87847d37744 in ofbiz-plugins's branch 
refs/heads/release17.12 from James Yong
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=a183733 ]

Fixed: processorder is submitted as GET instead of POST

(OFBIZ-11319)

During checkout of shopping cart, it is observed that the processorder of the 
form action is submitted as GET which is incorrect.

Thanks: Jacques for the review


> processorder is submitted as GET instead of POST
> 
>
> Key: OFBIZ-11319
> URL: https://issues.apache.org/jira/browse/OFBIZ-11319
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11319_Plugins.patch, OFBIZ-11319_Plugins.patch
>
>
> During checkout of shopping cart, it is observed that the processorder of the 
> form action is submitted as GET which is incorrect. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11319) processorder is submitted as GET instead of POST

2020-01-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018639#comment-17018639
 ] 

ASF subversion and git services commented on OFBIZ-11319:
-

Commit 4b7a3b378965f1162be9037ef0bd58e5bf0f47b5 in ofbiz-plugins's branch 
refs/heads/release18.12 from James Yong
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=4b7a3b3 ]

Fixed: processorder is submitted as GET instead of POST

(OFBIZ-11319)

During checkout of shopping cart, it is observed that the processorder of the 
form action is submitted as GET which is incorrect.

Thanks: Jacques for the review


> processorder is submitted as GET instead of POST
> 
>
> Key: OFBIZ-11319
> URL: https://issues.apache.org/jira/browse/OFBIZ-11319
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11319_Plugins.patch, OFBIZ-11319_Plugins.patch
>
>
> During checkout of shopping cart, it is observed that the processorder of the 
> form action is submitted as GET which is incorrect. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11319) processorder is submitted as GET instead of POST

2020-01-14 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014917#comment-17014917
 ] 

Jacques Le Roux commented on OFBIZ-11319:
-

bq. I would suggest to leave those task files for reference until we have a 
replacement. 
No problem with me.

> processorder is submitted as GET instead of POST
> 
>
> Key: OFBIZ-11319
> URL: https://issues.apache.org/jira/browse/OFBIZ-11319
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11319_Plugins.patch, OFBIZ-11319_Plugins.patch
>
>
> During checkout of shopping cart, it is observed that the processorder of the 
> form action is submitted as GET which is incorrect. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11319) processorder is submitted as GET instead of POST

2020-01-14 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014916#comment-17014916
 ] 

Jacques Le Roux commented on OFBIZ-11319:
-

Hi James,

With Git you have not a separation by repos for branches like with Svn. 

When you clone https://gitbox.apache.org/repos/asf/ofbiz-framework.git you also 
get the R17 and R18 branches locally. 
This certainly explains it better than me : 
https://git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell ;)

So you simply {{[git checkout|https://git-scm.com/docs/git-checkout]}} (ie move 
a file pointer) the branch you want to backport too and then you {{[git 
cherry-pick|https://git-scm.com/docs/git-cherry-pick]}} the commit/s you want 
to backport from the trunk. And then you commit/push if you don't get 
conflicts, which are fortunately more rare with Git than Svn.

As I'm a big fan of UI tools, and I'm most of the time on Windows mostly for 
this reason, I use ToirtoiseGit for that. But the principle is the same.

I think this is a good simple example for you to familiarize with this process 
:) Don't hesitate If you need more help.

> processorder is submitted as GET instead of POST
> 
>
> Key: OFBIZ-11319
> URL: https://issues.apache.org/jira/browse/OFBIZ-11319
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11319_Plugins.patch, OFBIZ-11319_Plugins.patch
>
>
> During checkout of shopping cart, it is observed that the processorder of the 
> form action is submitted as GET which is incorrect. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11319) processorder is submitted as GET instead of POST

2020-01-13 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014382#comment-17014382
 ] 

James Yong commented on OFBIZ-11319:


Hi Jacques,

With regard to backporting the patch, do I also use Git?
What are the Git URLs for the OFBiz releases? 

> processorder is submitted as GET instead of POST
> 
>
> Key: OFBIZ-11319
> URL: https://issues.apache.org/jira/browse/OFBIZ-11319
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11319_Plugins.patch, OFBIZ-11319_Plugins.patch
>
>
> During checkout of shopping cart, it is observed that the processorder of the 
> form action is submitted as GET which is incorrect. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11319) processorder is submitted as GET instead of POST

2020-01-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014369#comment-17014369
 ] 

ASF subversion and git services commented on OFBIZ-11319:
-

Commit ffb54c218080e2083d4c0aa81e988765084db8f7 in ofbiz-plugins's branch 
refs/heads/trunk from James Yong
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=ffb54c2 ]

Fixed: processorder is submitted as GET instead of POST

(OFBIZ-11319)

During checkout of shopping cart, it is observed that the processorder of the 
form action is submitted as GET which is incorrect.

Thanks: Jacques for the review


> processorder is submitted as GET instead of POST
> 
>
> Key: OFBIZ-11319
> URL: https://issues.apache.org/jira/browse/OFBIZ-11319
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11319_Plugins.patch, OFBIZ-11319_Plugins.patch
>
>
> During checkout of shopping cart, it is observed that the processorder of the 
> form action is submitted as GET which is incorrect. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11319) processorder is submitted as GET instead of POST

2020-01-13 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014351#comment-17014351
 ] 

James Yong commented on OFBIZ-11319:


I would suggest to leave those task files for reference until we have a 
replacement. 
There are newer bpm workflow engines under Apache licensing and also support 
orchestration of web services.

Updated the patch for anonymous checkout of shopping cart.

> processorder is submitted as GET instead of POST
> 
>
> Key: OFBIZ-11319
> URL: https://issues.apache.org/jira/browse/OFBIZ-11319
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11319_Plugins.patch, OFBIZ-11319_Plugins.patch
>
>
> During checkout of shopping cart, it is observed that the processorder of the 
> form action is submitted as GET instead of POST 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11319) processorder is submitted as GET instead of POST

2020-01-12 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013674#comment-17013674
 ] 

Jacques Le Roux commented on OFBIZ-11319:
-

We have a form with a get method in OrderTaskList.ftl. It's used in 
OrderTaskScreens.xml, but it's not used OOTB because there are no entries in 
any controller. In OrderTaskScreens.xml it's only suggested to add entries in 
the order controller. This dates from [deprecation of the old workflow 
engine|http://svn.apache.org/viewvc?view=revision=665981] and I guess 
should be neglected, if not better, removed in order to clarify and clean code.


> processorder is submitted as GET instead of POST
> 
>
> Key: OFBIZ-11319
> URL: https://issues.apache.org/jira/browse/OFBIZ-11319
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11319_Plugins.patch
>
>
> During checkout of shopping cart, it is observed that the processorder of the 
> form action is submitted as GET instead of POST 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11319) processorder is submitted as GET instead of POST

2020-01-12 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013672#comment-17013672
 ] 

Jacques Le Roux commented on OFBIZ-11319:
-

Hi James,

Thanks for this fix, I checked there are no other alike cases. Please commit 
and backport, thanks.

> processorder is submitted as GET instead of POST
> 
>
> Key: OFBIZ-11319
> URL: https://issues.apache.org/jira/browse/OFBIZ-11319
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11319_Plugins.patch
>
>
> During checkout of shopping cart, it is observed that the processorder of the 
> form action is submitted as GET instead of POST 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)