[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state
[ https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492863#comment-15492863 ] Jacques Le Roux commented on OFBIZ-8156: SInce there are 2 parts, maybe we could rename this Jira remove and add a link to another Jira where the new stuff would be put in. Unfotunately Jira does not allow more than 1 level for subtasks. Else we could also have an umbrella subtask named disentangle which would group the 2 others. > Disentangle Fedex solution from current integrated state > > > Key: OFBIZ-8156 > URL: https://issues.apache.org/jira/browse/OFBIZ-8156 > Project: OFBiz > Issue Type: Sub-task > Components: commonext, datamodel, order, product, > specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Labels: 3rdParty, integration, shipment > Attachments: OFBIZ-8156-FedexRemoval.patch > > > Disentanglement of the 3rd party shipment integration for FedEx gives the > OFBiz adopter more flexibility, reduces the default code base and offers the > project more opportunities with respect to attracting product specific > contributors, better code and faster release cycles. > Requirements of the disentangled solution: > * should not need a separate entity to capture configuration elements > * configuration should be contained in the component. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state
[ https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492832#comment-15492832 ] Taher Alkhateeb commented on OFBIZ-8156: Oh and for completeness, this is an area ripe for good refactoring, we can perhaps remove ALL shipment methods outside the framework into specialized plugins. So we can move Fedex, USPS, UPS and DHL each as a separate OFBiz plugin that hides away the implementation details. This, in my opinion, is a much cleaner and more modular approach that allows thriving and even adding more shipment methods without complexity at the framework level. > Disentangle Fedex solution from current integrated state > > > Key: OFBIZ-8156 > URL: https://issues.apache.org/jira/browse/OFBIZ-8156 > Project: OFBiz > Issue Type: Sub-task > Components: commonext, datamodel, order, product, > specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Labels: 3rdParty, integration, shipment > Attachments: OFBIZ-8156-FedexRemoval.patch > > > Disentanglement of the 3rd party shipment integration for FedEx gives the > OFBiz adopter more flexibility, reduces the default code base and offers the > project more opportunities with respect to attracting product specific > contributors, better code and faster release cycles. > Requirements of the disentangled solution: > * should not need a separate entity to capture configuration elements > * configuration should be contained in the component. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state
[ https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492834#comment-15492834 ] Pierre Smits commented on OFBIZ-8156: - I will help you both with this issue. > Disentangle Fedex solution from current integrated state > > > Key: OFBIZ-8156 > URL: https://issues.apache.org/jira/browse/OFBIZ-8156 > Project: OFBiz > Issue Type: Sub-task > Components: commonext, datamodel, order, product, > specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Labels: 3rdParty, integration, shipment > Attachments: OFBIZ-8156-FedexRemoval.patch > > > Disentanglement of the 3rd party shipment integration for FedEx gives the > OFBiz adopter more flexibility, reduces the default code base and offers the > project more opportunities with respect to attracting product specific > contributors, better code and faster release cycles. > Requirements of the disentangled solution: > * should not need a separate entity to capture configuration elements > * configuration should be contained in the component. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state
[ https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492823#comment-15492823 ] Taher Alkhateeb commented on OFBIZ-8156: I gave you an explanation below of the meaning of the word, so I won't repeat myself here. Now, with respect to the comments above, what I can see is that the API for fedex is deprecated, but the bulk of your patch is removing settings, labels and standard services. In my opinion, this is not a clean approach, and a redesign should be favoured over blunt removal. the parts that are deprecated can be removed (I still need to study the code, but I think most of it is not related) and other parts need to be refactored. > Disentangle Fedex solution from current integrated state > > > Key: OFBIZ-8156 > URL: https://issues.apache.org/jira/browse/OFBIZ-8156 > Project: OFBiz > Issue Type: Sub-task > Components: commonext, datamodel, order, product, > specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Labels: 3rdParty, integration, shipment > Attachments: OFBIZ-8156-FedexRemoval.patch > > > Disentanglement of the 3rd party shipment integration for FedEx gives the > OFBiz adopter more flexibility, reduces the default code base and offers the > project more opportunities with respect to attracting product specific > contributors, better code and faster release cycles. > Requirements of the disentangled solution: > * should not need a separate entity to capture configuration elements > * configuration should be contained in the component. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state
[ https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492775#comment-15492775 ] Michael Brohl commented on OFBIZ-8156: -- Neither do I. > Disentangle Fedex solution from current integrated state > > > Key: OFBIZ-8156 > URL: https://issues.apache.org/jira/browse/OFBIZ-8156 > Project: OFBiz > Issue Type: Sub-task > Components: commonext, datamodel, order, product, > specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Labels: 3rdParty, integration, shipment > Attachments: OFBIZ-8156-FedexRemoval.patch > > > Disentanglement of the 3rd party shipment integration for FedEx gives the > OFBiz adopter more flexibility, reduces the default code base and offers the > project more opportunities with respect to attracting product specific > contributors, better code and faster release cycles. > Requirements of the disentangled solution: > * should not need a separate entity to capture configuration elements > * configuration should be contained in the component. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state
[ https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492776#comment-15492776 ] Michael Brohl commented on OFBIZ-8156: -- Neither do I. > Disentangle Fedex solution from current integrated state > > > Key: OFBIZ-8156 > URL: https://issues.apache.org/jira/browse/OFBIZ-8156 > Project: OFBiz > Issue Type: Sub-task > Components: commonext, datamodel, order, product, > specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Labels: 3rdParty, integration, shipment > Attachments: OFBIZ-8156-FedexRemoval.patch > > > Disentanglement of the 3rd party shipment integration for FedEx gives the > OFBiz adopter more flexibility, reduces the default code base and offers the > project more opportunities with respect to attracting product specific > contributors, better code and faster release cycles. > Requirements of the disentangled solution: > * should not need a separate entity to capture configuration elements > * configuration should be contained in the component. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state
[ https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492727#comment-15492727 ] Pierre Smits commented on OFBIZ-8156: - I am not working this issue. > Disentangle Fedex solution from current integrated state > > > Key: OFBIZ-8156 > URL: https://issues.apache.org/jira/browse/OFBIZ-8156 > Project: OFBiz > Issue Type: Sub-task > Components: commonext, datamodel, order, product, > specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Labels: 3rdParty, integration, shipment > Attachments: OFBIZ-8156-FedexRemoval.patch > > > Disentanglement of the 3rd party shipment integration for FedEx gives the > OFBiz adopter more flexibility, reduces the default code base and offers the > project more opportunities with respect to attracting product specific > contributors, better code and faster release cycles. > Requirements of the disentangled solution: > * should not need a separate entity to capture configuration elements > * configuration should be contained in the component. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state
[ https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492720#comment-15492720 ] Michael Brohl commented on OFBIZ-8156: -- The issue title and also some of your comments for a 2nd part are a bit misleading. I'd recommend to change the issue to "Remove Fedex solution" to make this clear. I had a look at the past discussions and agree that the non-working solution should be removed. > Disentangle Fedex solution from current integrated state > > > Key: OFBIZ-8156 > URL: https://issues.apache.org/jira/browse/OFBIZ-8156 > Project: OFBiz > Issue Type: Sub-task > Components: commonext, datamodel, order, product, > specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Labels: 3rdParty, integration, shipment > Attachments: OFBIZ-8156-FedexRemoval.patch > > > Disentanglement of the 3rd party shipment integration for FedEx gives the > OFBiz adopter more flexibility, reduces the default code base and offers the > project more opportunities with respect to attracting product specific > contributors, better code and faster release cycles. > Requirements of the disentangled solution: > * should not need a separate entity to capture configuration elements > * configuration should be contained in the component. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state
[ https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492623#comment-15492623 ] Michael Brohl commented on OFBIZ-8156: -- I think we should wait for the 2nd part for the whole picture before taking any action here. > Disentangle Fedex solution from current integrated state > > > Key: OFBIZ-8156 > URL: https://issues.apache.org/jira/browse/OFBIZ-8156 > Project: OFBiz > Issue Type: Sub-task > Components: commonext, datamodel, order, product, > specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Labels: 3rdParty, integration, shipment > Attachments: OFBIZ-8156-FedexRemoval.patch > > > Disentanglement of the 3rd party shipment integration for FedEx gives the > OFBiz adopter more flexibility, reduces the default code base and offers the > project more opportunities with respect to attracting product specific > contributors, better code and faster release cycles. > Requirements of the disentangled solution: > * should not need a separate entity to capture configuration elements > * configuration should be contained in the component. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state
[ https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492575#comment-15492575 ] Pierre Smits commented on OFBIZ-8156: - Please read the comments provided earlier. For an explanation regarding disentanglement see http://www.merriam-webster.com/dictionary/disentangle > Disentangle Fedex solution from current integrated state > > > Key: OFBIZ-8156 > URL: https://issues.apache.org/jira/browse/OFBIZ-8156 > Project: OFBiz > Issue Type: Sub-task > Components: commonext, datamodel, order, product, > specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Labels: 3rdParty, integration, shipment > Attachments: OFBIZ-8156-FedexRemoval.patch > > > Disentanglement of the 3rd party shipment integration for FedEx gives the > OFBiz adopter more flexibility, reduces the default code base and offers the > project more opportunities with respect to attracting product specific > contributors, better code and faster release cycles. > Requirements of the disentangled solution: > * should not need a separate entity to capture configuration elements > * configuration should be contained in the component. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state
[ https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490053#comment-15490053 ] Taher Alkhateeb commented on OFBIZ-8156: Hello, In reviewing the patch for this work, I notice that you only focus on removing Fedex. Why only Fedex? The system supports DHL, UPS, USPS but all the removal I'm seeing is only for Fedex. I also note that this does not look like a disentanglement to me (no redesign) but rather just removal of Fedex specific data, labels, widgets and code. So my questions are: - Why only fedex, and leaving other shipment methods intact? - What do you mean by disentanglement? > Disentangle Fedex solution from current integrated state > > > Key: OFBIZ-8156 > URL: https://issues.apache.org/jira/browse/OFBIZ-8156 > Project: OFBiz > Issue Type: Sub-task > Components: commonext, datamodel, order, product, > specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Labels: 3rdParty, integration, shipment > Attachments: OFBIZ-8156-FedexRemoval.patch > > > Disentanglement of the 3rd party shipment integration for FedEx gives the > OFBiz adopter more flexibility, reduces the default code base and offers the > project more opportunities with respect to attracting product specific > contributors, better code and faster release cycles. > Requirements of the disentangled solution: > * should not need a separate entity to capture configuration elements > * configuration should be contained in the component. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state
[ https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15476089#comment-15476089 ] Jacques Le Roux commented on OFBIZ-8156: If you have the thread link that would help, TIA. > Disentangle Fedex solution from current integrated state > > > Key: OFBIZ-8156 > URL: https://issues.apache.org/jira/browse/OFBIZ-8156 > Project: OFBiz > Issue Type: Sub-task > Components: commonext, datamodel, order, product, > specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Labels: 3rdParty, integration, shipment > Attachments: OFBIZ-8156-FedexRemoval.patch > > > Disentanglement of the 3rd party shipment integration for FedEx gives the > OFBiz adopter more flexibility, reduces the default code base and offers the > project more opportunities with respect to attracting product specific > contributors, better code and faster release cycles. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state
[ https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15476061#comment-15476061 ] Pierre Smits commented on OFBIZ-8156: - There isn't clarity within the project about where to move it too. But the code has to get out of where it is now. So this is just a part. Furthermore, I doubt whether the code is even working. Last insightful references in MLs were around 2012 and these weren't complements, and the reactions from community members didn't make me have faith. > Disentangle Fedex solution from current integrated state > > > Key: OFBIZ-8156 > URL: https://issues.apache.org/jira/browse/OFBIZ-8156 > Project: OFBiz > Issue Type: Sub-task > Components: commonext, datamodel, order, product, > specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Labels: 3rdParty, integration, shipment > Attachments: OFBIZ-8156-FedexRemoval.patch > > > Disentanglement of the 3rd party shipment integration for FedEx gives the > OFBiz adopter more flexibility, reduces the default code base and offers the > project more opportunities with respect to attracting product specific > contributors, better code and faster release cycles. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state
[ https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474887#comment-15474887 ] Jacques Le Roux commented on OFBIZ-8156: Pierre, is it a disentanglement or a removing? The umbrella task speaks about moving things not removing them. Is it a 1st step? > Disentangle Fedex solution from current integrated state > > > Key: OFBIZ-8156 > URL: https://issues.apache.org/jira/browse/OFBIZ-8156 > Project: OFBiz > Issue Type: Sub-task > Components: commonext, datamodel, order, product, > specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Labels: 3rdParty, integration, shipment > Attachments: OFBIZ-8156-FedexRemoval.patch > > > Disentanglement of the 3rd party shipment integration for FedEx gives the > OFBiz adopter more flexibility, reduces the default code base and offers the > project more opportunities with respect to attracting product specific > contributors, better code and faster release cycles. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state
[ https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470413#comment-15470413 ] Taher Alkhateeb commented on OFBIZ-8156: I would recommend setting priority as minor as per [JIRA guidelines|https://cwiki.apache.org/confluence/display/OFBIZ/Guidelines+for+Using+Jira] which are under development. I think nothing qualifies beyond Minor for Trunk given its expected instability. > Disentangle Fedex solution from current integrated state > > > Key: OFBIZ-8156 > URL: https://issues.apache.org/jira/browse/OFBIZ-8156 > Project: OFBiz > Issue Type: Sub-task > Components: commonext, datamodel, order, product, > specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Critical > Labels: 3rdParty, integration, shipment > > Disentanglement of the 3rd party shipment integration for FedEx gives the > OFBiz adopter more flexibility, reduces the default code base and offers the > project more opportunities with respect to attracting product specific > contributors, better code and faster release cycles. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state
[ https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470386#comment-15470386 ] Pierre Smits commented on OFBIZ-8156: - Setting the priority to 'critical' as this impacts: * services in other components * datamodel > Disentangle Fedex solution from current integrated state > > > Key: OFBIZ-8156 > URL: https://issues.apache.org/jira/browse/OFBIZ-8156 > Project: OFBiz > Issue Type: Sub-task > Components: commonext, datamodel, order, product, > specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Critical > Labels: 3rdParty, integration, shipment > > Disentanglement of the 3rd party shipment integration for FedEx gives the > OFBiz adopter more flexibility, reduces the default code base and offers the > project more opportunities with respect to attracting product specific > contributors, better code and faster release cycles. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
