[GitHub] incubator-rya issue #293: RYA-491 Repackaged reusable Mongo DB test code int...
Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/293 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/745/ ---
[jira] [Commented] (RYA-491) Create the rya.test.mongo project.
[ https://issues.apache.org/jira/browse/RYA-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453252#comment-16453252 ] ASF GitHub Bot commented on RYA-491: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/293 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/745/ > Create the rya.test.mongo project. > -- > > Key: RYA-491 > URL: https://issues.apache.org/jira/browse/RYA-491 > Project: Rya > Issue Type: Improvement >Affects Versions: 4.0.0 >Reporter: Kevin Chilton >Assignee: Kevin Chilton >Priority: Major > Fix For: 4.0.0 > > > This is a project that will contain all code required to stand up and work > with an embedded instance of Mongo DB to test Rya. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] incubator-rya issue #293: RYA-491 Repackaged reusable Mongo DB test code int...
Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/293 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/744/ ---
[jira] [Commented] (RYA-491) Create the rya.test.mongo project.
[ https://issues.apache.org/jira/browse/RYA-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453243#comment-16453243 ] ASF GitHub Bot commented on RYA-491: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/293 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/744/ > Create the rya.test.mongo project. > -- > > Key: RYA-491 > URL: https://issues.apache.org/jira/browse/RYA-491 > Project: Rya > Issue Type: Improvement >Affects Versions: 4.0.0 >Reporter: Kevin Chilton >Assignee: Kevin Chilton >Priority: Major > Fix For: 4.0.0 > > > This is a project that will contain all code required to stand up and work > with an embedded instance of Mongo DB to test Rya. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RYA-491) Create the rya.test.mongo project.
[ https://issues.apache.org/jira/browse/RYA-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453076#comment-16453076 ] ASF GitHub Bot commented on RYA-491: Github user kchilton2 commented on the issue: https://github.com/apache/incubator-rya/pull/293 Updated. > Create the rya.test.mongo project. > -- > > Key: RYA-491 > URL: https://issues.apache.org/jira/browse/RYA-491 > Project: Rya > Issue Type: Improvement >Affects Versions: 4.0.0 >Reporter: Kevin Chilton >Assignee: Kevin Chilton >Priority: Major > Fix For: 4.0.0 > > > This is a project that will contain all code required to stand up and work > with an embedded instance of Mongo DB to test Rya. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] incubator-rya issue #293: RYA-491 Repackaged reusable Mongo DB test code int...
Github user kchilton2 commented on the issue: https://github.com/apache/incubator-rya/pull/293 Updated. ---
[jira] [Commented] (RYA-491) Create the rya.test.mongo project.
[
https://issues.apache.org/jira/browse/RYA-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452767#comment-16452767
]
ASF GitHub Bot commented on RYA-491:
Github user kchilton2 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/293#discussion_r184151567
--- Diff:
dao/mongodb.rya/src/test/java/org/apache/rya/mongodb/aggregation/PipelineQueryIT.java
---
@@ -423,28 +423,28 @@ public void testRequiredTimestamp() throws Exception {
+ " ?A rdfs:subClassOf ?B .\n"
+ " ?B rdfs:subClassOf ?A .\n"
+ "}";
-List varNames = Arrays.asList("A", "B");
-Multiset expectedSolutions = HashMultiset.create();
+final List varNames = Arrays.asList("A", "B");
+final Multiset expectedSolutions =
HashMultiset.create();
expectedSolutions.add(new ListBindingSet(varNames, person,
FOAF.PERSON));
expectedSolutions.add(new ListBindingSet(varNames, FOAF.PERSON,
person));
expectedSolutions.add(new ListBindingSet(varNames, thing,
OWL.THING));
expectedSolutions.add(new ListBindingSet(varNames, OWL.THING,
thing));
// Prepare query and convert to pipeline
-QueryRoot queryTree = new QueryRoot(PARSER.parseQuery(query,
null).getTupleExpr());
-SparqlToPipelineTransformVisitor visitor = new
SparqlToPipelineTransformVisitor(getRyaCollection());
+final QueryRoot queryTree = new QueryRoot(PARSER.parseQuery(query,
null).getTupleExpr());
+final SparqlToPipelineTransformVisitor visitor = new
SparqlToPipelineTransformVisitor(getRyaCollection());
queryTree.visit(visitor);
Assert.assertTrue(queryTree.getArg() instanceof
AggregationPipelineQueryNode);
-AggregationPipelineQueryNode pipelineNode =
(AggregationPipelineQueryNode) queryTree.getArg();
+final AggregationPipelineQueryNode pipelineNode =
(AggregationPipelineQueryNode) queryTree.getArg();
// Extend the pipeline by requiring a timestamp of zero (should
have no effect)
pipelineNode.requireSourceTimestamp(0);
-Multiset solutions = HashMultiset.create();
+final Multiset solutions = HashMultiset.create();
CloseableIteration iter =
pipelineNode.evaluate(new QueryBindingSet());
while (iter.hasNext()) {
solutions.add(iter.next());
}
Assert.assertEquals(expectedSolutions, solutions);
// Extend the pipeline by requiring a future timestamp (should
produce no results)
-long delta = 1000 * 60 * 60 * 24;
+final long delta = 1000 * 60 * 60 * 24;
--- End diff --
I'm not messing with classes that already exist except to deal with my
repackaging.
> Create the rya.test.mongo project.
> --
>
> Key: RYA-491
> URL: https://issues.apache.org/jira/browse/RYA-491
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Kevin Chilton
>Assignee: Kevin Chilton
>Priority: Major
> Fix For: 4.0.0
>
>
> This is a project that will contain all code required to stand up and work
> with an embedded instance of Mongo DB to test Rya.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RYA-491) Create the rya.test.mongo project.
[
https://issues.apache.org/jira/browse/RYA-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452766#comment-16452766
]
ASF GitHub Bot commented on RYA-491:
Github user kchilton2 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/293#discussion_r184151510
--- Diff:
dao/mongodb.rya/src/test/java/org/apache/rya/mongodb/MongoDBRyaDAO2IT.java ---
@@ -40,11 +40,11 @@
/**
* Integration tests the methods of {@link MongoDBRyaDAO}.
*/
-public class MongoDBRyaDAO2IT extends MongoITBase {
+public class MongoDBRyaDAO2IT extends MongoRyaITBase {
--- End diff --
I'm not messing with classes that already exist except to deal with my
repackaging.
> Create the rya.test.mongo project.
> --
>
> Key: RYA-491
> URL: https://issues.apache.org/jira/browse/RYA-491
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Kevin Chilton
>Assignee: Kevin Chilton
>Priority: Major
> Fix For: 4.0.0
>
>
> This is a project that will contain all code required to stand up and work
> with an embedded instance of Mongo DB to test Rya.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] incubator-rya pull request #293: RYA-491 Repackaged reusable Mongo DB test c...
Github user kchilton2 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/293#discussion_r184151510
--- Diff:
dao/mongodb.rya/src/test/java/org/apache/rya/mongodb/MongoDBRyaDAO2IT.java ---
@@ -40,11 +40,11 @@
/**
* Integration tests the methods of {@link MongoDBRyaDAO}.
*/
-public class MongoDBRyaDAO2IT extends MongoITBase {
+public class MongoDBRyaDAO2IT extends MongoRyaITBase {
--- End diff --
I'm not messing with classes that already exist except to deal with my
repackaging.
---
[GitHub] incubator-rya pull request #293: RYA-491 Repackaged reusable Mongo DB test c...
Github user kchilton2 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/293#discussion_r184151567
--- Diff:
dao/mongodb.rya/src/test/java/org/apache/rya/mongodb/aggregation/PipelineQueryIT.java
---
@@ -423,28 +423,28 @@ public void testRequiredTimestamp() throws Exception {
+ " ?A rdfs:subClassOf ?B .\n"
+ " ?B rdfs:subClassOf ?A .\n"
+ "}";
-List varNames = Arrays.asList("A", "B");
-Multiset expectedSolutions = HashMultiset.create();
+final List varNames = Arrays.asList("A", "B");
+final Multiset expectedSolutions =
HashMultiset.create();
expectedSolutions.add(new ListBindingSet(varNames, person,
FOAF.PERSON));
expectedSolutions.add(new ListBindingSet(varNames, FOAF.PERSON,
person));
expectedSolutions.add(new ListBindingSet(varNames, thing,
OWL.THING));
expectedSolutions.add(new ListBindingSet(varNames, OWL.THING,
thing));
// Prepare query and convert to pipeline
-QueryRoot queryTree = new QueryRoot(PARSER.parseQuery(query,
null).getTupleExpr());
-SparqlToPipelineTransformVisitor visitor = new
SparqlToPipelineTransformVisitor(getRyaCollection());
+final QueryRoot queryTree = new QueryRoot(PARSER.parseQuery(query,
null).getTupleExpr());
+final SparqlToPipelineTransformVisitor visitor = new
SparqlToPipelineTransformVisitor(getRyaCollection());
queryTree.visit(visitor);
Assert.assertTrue(queryTree.getArg() instanceof
AggregationPipelineQueryNode);
-AggregationPipelineQueryNode pipelineNode =
(AggregationPipelineQueryNode) queryTree.getArg();
+final AggregationPipelineQueryNode pipelineNode =
(AggregationPipelineQueryNode) queryTree.getArg();
// Extend the pipeline by requiring a timestamp of zero (should
have no effect)
pipelineNode.requireSourceTimestamp(0);
-Multiset solutions = HashMultiset.create();
+final Multiset solutions = HashMultiset.create();
CloseableIteration iter =
pipelineNode.evaluate(new QueryBindingSet());
while (iter.hasNext()) {
solutions.add(iter.next());
}
Assert.assertEquals(expectedSolutions, solutions);
// Extend the pipeline by requiring a future timestamp (should
produce no results)
-long delta = 1000 * 60 * 60 * 24;
+final long delta = 1000 * 60 * 60 * 24;
--- End diff --
I'm not messing with classes that already exist except to deal with my
repackaging.
---
[jira] [Commented] (RYA-491) Create the rya.test.mongo project.
[
https://issues.apache.org/jira/browse/RYA-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452764#comment-16452764
]
ASF GitHub Bot commented on RYA-491:
Github user kchilton2 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/293#discussion_r184151234
--- Diff: pom.xml ---
@@ -381,6 +458,26 @@ under the License.
rya.indexing.pcj
${project.version}
+
+org.apache.rya
+rya.kafka.connect.parent
--- End diff --
Yep, not sure how that got in there.
> Create the rya.test.mongo project.
> --
>
> Key: RYA-491
> URL: https://issues.apache.org/jira/browse/RYA-491
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Kevin Chilton
>Assignee: Kevin Chilton
>Priority: Major
> Fix For: 4.0.0
>
>
> This is a project that will contain all code required to stand up and work
> with an embedded instance of Mongo DB to test Rya.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] incubator-rya pull request #293: RYA-491 Repackaged reusable Mongo DB test c...
Github user kchilton2 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/293#discussion_r184151234
--- Diff: pom.xml ---
@@ -381,6 +458,26 @@ under the License.
rya.indexing.pcj
${project.version}
+
+org.apache.rya
+rya.kafka.connect.parent
--- End diff --
Yep, not sure how that got in there.
---
[jira] [Commented] (RYA-491) Create the rya.test.mongo project.
[
https://issues.apache.org/jira/browse/RYA-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452759#comment-16452759
]
ASF GitHub Bot commented on RYA-491:
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/293#discussion_r184127031
--- Diff:
dao/mongodb.rya/src/test/java/org/apache/rya/mongodb/aggregation/PipelineQueryIT.java
---
@@ -423,28 +423,28 @@ public void testRequiredTimestamp() throws Exception {
+ " ?A rdfs:subClassOf ?B .\n"
+ " ?B rdfs:subClassOf ?A .\n"
+ "}";
-List varNames = Arrays.asList("A", "B");
-Multiset expectedSolutions = HashMultiset.create();
+final List varNames = Arrays.asList("A", "B");
+final Multiset expectedSolutions =
HashMultiset.create();
expectedSolutions.add(new ListBindingSet(varNames, person,
FOAF.PERSON));
expectedSolutions.add(new ListBindingSet(varNames, FOAF.PERSON,
person));
expectedSolutions.add(new ListBindingSet(varNames, thing,
OWL.THING));
expectedSolutions.add(new ListBindingSet(varNames, OWL.THING,
thing));
// Prepare query and convert to pipeline
-QueryRoot queryTree = new QueryRoot(PARSER.parseQuery(query,
null).getTupleExpr());
-SparqlToPipelineTransformVisitor visitor = new
SparqlToPipelineTransformVisitor(getRyaCollection());
+final QueryRoot queryTree = new QueryRoot(PARSER.parseQuery(query,
null).getTupleExpr());
+final SparqlToPipelineTransformVisitor visitor = new
SparqlToPipelineTransformVisitor(getRyaCollection());
queryTree.visit(visitor);
Assert.assertTrue(queryTree.getArg() instanceof
AggregationPipelineQueryNode);
-AggregationPipelineQueryNode pipelineNode =
(AggregationPipelineQueryNode) queryTree.getArg();
+final AggregationPipelineQueryNode pipelineNode =
(AggregationPipelineQueryNode) queryTree.getArg();
// Extend the pipeline by requiring a timestamp of zero (should
have no effect)
pipelineNode.requireSourceTimestamp(0);
-Multiset solutions = HashMultiset.create();
+final Multiset solutions = HashMultiset.create();
CloseableIteration iter =
pipelineNode.evaluate(new QueryBindingSet());
while (iter.hasNext()) {
solutions.add(iter.next());
}
Assert.assertEquals(expectedSolutions, solutions);
// Extend the pipeline by requiring a future timestamp (should
produce no results)
-long delta = 1000 * 60 * 60 * 24;
+final long delta = 1000 * 60 * 60 * 24;
--- End diff --
Maybe change to TimeUnit.DAYS.toMillis(1);
> Create the rya.test.mongo project.
> --
>
> Key: RYA-491
> URL: https://issues.apache.org/jira/browse/RYA-491
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Kevin Chilton
>Assignee: Kevin Chilton
>Priority: Major
> Fix For: 4.0.0
>
>
> This is a project that will contain all code required to stand up and work
> with an embedded instance of Mongo DB to test Rya.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RYA-491) Create the rya.test.mongo project.
[
https://issues.apache.org/jira/browse/RYA-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452761#comment-16452761
]
ASF GitHub Bot commented on RYA-491:
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/293#discussion_r184128364
--- Diff:
dao/mongodb.rya/src/test/java/org/apache/rya/mongodb/MongoDBRyaDAO2IT.java ---
@@ -40,11 +40,11 @@
/**
* Integration tests the methods of {@link MongoDBRyaDAO}.
*/
-public class MongoDBRyaDAO2IT extends MongoITBase {
+public class MongoDBRyaDAO2IT extends MongoRyaITBase {
--- End diff --
Is this class needed? Looks like MongoDBRyaDAOIT has the same tests and a
few more and includes visibility.
> Create the rya.test.mongo project.
> --
>
> Key: RYA-491
> URL: https://issues.apache.org/jira/browse/RYA-491
> Project: Rya
> Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Kevin Chilton
>Assignee: Kevin Chilton
>Priority: Major
> Fix For: 4.0.0
>
>
> This is a project that will contain all code required to stand up and work
> with an embedded instance of Mongo DB to test Rya.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] incubator-rya pull request #293: RYA-491 Repackaged reusable Mongo DB test c...
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/293#discussion_r184127031
--- Diff:
dao/mongodb.rya/src/test/java/org/apache/rya/mongodb/aggregation/PipelineQueryIT.java
---
@@ -423,28 +423,28 @@ public void testRequiredTimestamp() throws Exception {
+ " ?A rdfs:subClassOf ?B .\n"
+ " ?B rdfs:subClassOf ?A .\n"
+ "}";
-List varNames = Arrays.asList("A", "B");
-Multiset expectedSolutions = HashMultiset.create();
+final List varNames = Arrays.asList("A", "B");
+final Multiset expectedSolutions =
HashMultiset.create();
expectedSolutions.add(new ListBindingSet(varNames, person,
FOAF.PERSON));
expectedSolutions.add(new ListBindingSet(varNames, FOAF.PERSON,
person));
expectedSolutions.add(new ListBindingSet(varNames, thing,
OWL.THING));
expectedSolutions.add(new ListBindingSet(varNames, OWL.THING,
thing));
// Prepare query and convert to pipeline
-QueryRoot queryTree = new QueryRoot(PARSER.parseQuery(query,
null).getTupleExpr());
-SparqlToPipelineTransformVisitor visitor = new
SparqlToPipelineTransformVisitor(getRyaCollection());
+final QueryRoot queryTree = new QueryRoot(PARSER.parseQuery(query,
null).getTupleExpr());
+final SparqlToPipelineTransformVisitor visitor = new
SparqlToPipelineTransformVisitor(getRyaCollection());
queryTree.visit(visitor);
Assert.assertTrue(queryTree.getArg() instanceof
AggregationPipelineQueryNode);
-AggregationPipelineQueryNode pipelineNode =
(AggregationPipelineQueryNode) queryTree.getArg();
+final AggregationPipelineQueryNode pipelineNode =
(AggregationPipelineQueryNode) queryTree.getArg();
// Extend the pipeline by requiring a timestamp of zero (should
have no effect)
pipelineNode.requireSourceTimestamp(0);
-Multiset solutions = HashMultiset.create();
+final Multiset solutions = HashMultiset.create();
CloseableIteration iter =
pipelineNode.evaluate(new QueryBindingSet());
while (iter.hasNext()) {
solutions.add(iter.next());
}
Assert.assertEquals(expectedSolutions, solutions);
// Extend the pipeline by requiring a future timestamp (should
produce no results)
-long delta = 1000 * 60 * 60 * 24;
+final long delta = 1000 * 60 * 60 * 24;
--- End diff --
Maybe change to TimeUnit.DAYS.toMillis(1);
---
[GitHub] incubator-rya pull request #293: RYA-491 Repackaged reusable Mongo DB test c...
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/293#discussion_r184128364
--- Diff:
dao/mongodb.rya/src/test/java/org/apache/rya/mongodb/MongoDBRyaDAO2IT.java ---
@@ -40,11 +40,11 @@
/**
* Integration tests the methods of {@link MongoDBRyaDAO}.
*/
-public class MongoDBRyaDAO2IT extends MongoITBase {
+public class MongoDBRyaDAO2IT extends MongoRyaITBase {
--- End diff --
Is this class needed? Looks like MongoDBRyaDAOIT has the same tests and a
few more and includes visibility.
---
[GitHub] incubator-rya pull request #293: RYA-491 Repackaged reusable Mongo DB test c...
Github user ejwhite922 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/293#discussion_r184149352
--- Diff: pom.xml ---
@@ -381,6 +458,26 @@ under the License.
rya.indexing.pcj
${project.version}
+
+org.apache.rya
+rya.kafka.connect.parent
--- End diff --
Don't think these belong in this PR.
---
[jira] [Commented] (RYA-443) Implement a single node query manager
[ https://issues.apache.org/jira/browse/RYA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452575#comment-16452575 ] ASF GitHub Bot commented on RYA-443: Github user ejwhite922 closed the pull request at: https://github.com/apache/incubator-rya/pull/282 > Implement a single node query manager > - > > Key: RYA-443 > URL: https://issues.apache.org/jira/browse/RYA-443 > Project: Rya > Issue Type: Task >Reporter: Andrew Smith >Assignee: Kevin Chilton >Priority: Major > > We need an application that watches the QueryChangeLog to see when the > isActive state of queries changes and then reacts to the state change. If > isActive goes to true, the system must start processing the query. If it is > false, then it must stop processing the query. This application needs to > start when the host machine starts. We plan to support CentOS 7. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] incubator-rya pull request #282: RYA-443 Fixed Rya Streams Query Manager RPM...
Github user ejwhite922 closed the pull request at: https://github.com/apache/incubator-rya/pull/282 ---
[jira] [Commented] (RYA-443) Implement a single node query manager
[ https://issues.apache.org/jira/browse/RYA-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452526#comment-16452526 ] ASF GitHub Bot commented on RYA-443: Github user kchilton2 commented on the issue: https://github.com/apache/incubator-rya/pull/282 Eric, please close this. > Implement a single node query manager > - > > Key: RYA-443 > URL: https://issues.apache.org/jira/browse/RYA-443 > Project: Rya > Issue Type: Task >Reporter: Andrew Smith >Assignee: Kevin Chilton >Priority: Major > > We need an application that watches the QueryChangeLog to see when the > isActive state of queries changes and then reacts to the state change. If > isActive goes to true, the system must start processing the query. If it is > false, then it must stop processing the query. This application needs to > start when the host machine starts. We plan to support CentOS 7. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] incubator-rya issue #282: RYA-443 Fixed Rya Streams Query Manager RPM versio...
Github user kchilton2 commented on the issue: https://github.com/apache/incubator-rya/pull/282 Eric, please close this. ---
