[jira] [Commented] (RYA-151) Rya Test Bed
[
https://issues.apache.org/jira/browse/RYA-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490751#comment-15490751
]
ASF GitHub Bot commented on RYA-151:
Github user amihalik commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/85#discussion_r78775502
--- Diff: extras/rya.benchmark/pom.xml ---
@@ -0,0 +1,250 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+
+rya.extras
+org.apache.rya
+3.2.10-SNAPSHOT
+
+
+4.0.0
+rya.benchmark
+
+Apache Rya Benchmarks
+
+
+
+
+org.openjdk.jmh
+jmh-core
+${jmh.version}
+
+
+org.openjdk.jmh
+jmh-generator-annprocess
+${jmh.version}
+provided
+
+
+
+org.apache.rya
+rya.indexing
+
+
+
+com.google.code.findbugs
+jsr305
+3.0.1
+
+
+
+com.google.guava
+guava
+
+
+
+junit
+junit
+test
+
+
+
+org.apache.accumulo
+accumulo-minicluster
+${accumulo.version}
+test
+
+
+
+
+
+UTF-8
+
+
+1.13
+
+
+1.8
+
+
+benchmarks
+
+
+
+
+
+src/main/xsd
+
+
+
+
+
+org.apache.maven.plugins
--- End diff --
Sorry for my terse comment. These should be defined in the parent POM:
1. Versions for dependencies should be defined as parameters (e.g. like
you've done with jmh.version). You should also do this for maven plug-ins
(e.g. you haven't done this for maven-clean-plugin).
2. Dependencies (and plug-ins) and their versions should be defined in the
DependenciesManagement (and pluginManagement) sections of the root pom.
3. The root pom should be the only pom to define the java versions.
Subprojects shouldn't be using the maven-compiler-plugin to define their own
versions of java.
4. You have some nice plug-ins that should be moved to the root pom as well
(e.g. license-maven-plugin). I think @DLotts is working on this, so there's no
need for you to modify that here.
> Rya Test Bed
>
>
> Key: RYA-151
> URL: https://issues.apache.org/jira/browse/RYA-151
> Project: Rya
> Issue Type: Wish
> Components: clients, dao
>Reporter: Puja Valiyil
>Assignee: Kevin Chilton
>
> It would be nice if there was a test bed checked in with Rya that could be
> used for benchmark testing. This test bed should include options for
> uploading data to a rya instance, then issuing some benchmark queries (and
> timing them in a way that everyone agrees is sound). It could be a command
> line tool. It should be dao agnostic (work on either mongo, accumulo, etc.).
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (RYA-151) Rya Test Bed
[
https://issues.apache.org/jira/browse/RYA-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489134#comment-15489134
]
ASF GitHub Bot commented on RYA-151:
Github user kchilton2 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/85#discussion_r78677753
--- Diff: extras/rya.benchmark/pom.xml ---
@@ -0,0 +1,250 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+
+rya.extras
+org.apache.rya
+3.2.10-SNAPSHOT
+
+
+4.0.0
+rya.benchmark
+
+Apache Rya Benchmarks
+
+
+
+
+org.openjdk.jmh
+jmh-core
+${jmh.version}
+
+
+org.openjdk.jmh
+jmh-generator-annprocess
+${jmh.version}
+provided
+
+
+
+org.apache.rya
+rya.indexing
+
+
+
+com.google.code.findbugs
+jsr305
+3.0.1
+
+
+
+com.google.guava
+guava
+
+
+
+junit
+junit
+test
+
+
+
+org.apache.accumulo
+accumulo-minicluster
+${accumulo.version}
+test
+
+
+
+
+
+UTF-8
+
+
+1.13
+
+
+1.8
+
+
+benchmarks
+
+
+
+
+
+src/main/xsd
+
+
+
+
+
+org.apache.maven.plugins
--- End diff --
Which part specifically?
> Rya Test Bed
>
>
> Key: RYA-151
> URL: https://issues.apache.org/jira/browse/RYA-151
> Project: Rya
> Issue Type: Wish
> Components: clients, dao
>Reporter: Puja Valiyil
>Assignee: Kevin Chilton
>
> It would be nice if there was a test bed checked in with Rya that could be
> used for benchmark testing. This test bed should include options for
> uploading data to a rya instance, then issuing some benchmark queries (and
> timing them in a way that everyone agrees is sound). It could be a command
> line tool. It should be dao agnostic (work on either mongo, accumulo, etc.).
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (RYA-151) Rya Test Bed
[ https://issues.apache.org/jira/browse/RYA-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489132#comment-15489132 ] ASF GitHub Bot commented on RYA-151: Github user kchilton2 commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/85#discussion_r78677735 --- Diff: extras/indexing/src/main/java/mvm/rya/indexing/external/PrecomputedJoinStorageSupplier.java --- @@ -27,6 +27,7 @@ import com.google.common.base.Optional; import com.google.common.base.Supplier; +import cern.colt.Arrays; --- End diff -- That's likely a mistake. Good catch. > Rya Test Bed > > > Key: RYA-151 > URL: https://issues.apache.org/jira/browse/RYA-151 > Project: Rya > Issue Type: Wish > Components: clients, dao >Reporter: Puja Valiyil >Assignee: Kevin Chilton > > It would be nice if there was a test bed checked in with Rya that could be > used for benchmark testing. This test bed should include options for > uploading data to a rya instance, then issuing some benchmark queries (and > timing them in a way that everyone agrees is sound). It could be a command > line tool. It should be dao agnostic (work on either mongo, accumulo, etc.). > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RYA-151) Rya Test Bed
[
https://issues.apache.org/jira/browse/RYA-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15488985#comment-15488985
]
ASF GitHub Bot commented on RYA-151:
Github user amihalik commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/85#discussion_r78671939
--- Diff: extras/rya.benchmark/pom.xml ---
@@ -0,0 +1,250 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+
+rya.extras
+org.apache.rya
+3.2.10-SNAPSHOT
+
+
+4.0.0
+rya.benchmark
+
+Apache Rya Benchmarks
+
+
+
+
+org.openjdk.jmh
+jmh-core
+${jmh.version}
--- End diff --
These versions should be defined in the root pom as properties and in the
root pom's plug-in management section
> Rya Test Bed
>
>
> Key: RYA-151
> URL: https://issues.apache.org/jira/browse/RYA-151
> Project: Rya
> Issue Type: Wish
> Components: clients, dao
>Reporter: Puja Valiyil
>Assignee: Kevin Chilton
>
> It would be nice if there was a test bed checked in with Rya that could be
> used for benchmark testing. This test bed should include options for
> uploading data to a rya instance, then issuing some benchmark queries (and
> timing them in a way that everyone agrees is sound). It could be a command
> line tool. It should be dao agnostic (work on either mongo, accumulo, etc.).
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (RYA-151) Rya Test Bed
[
https://issues.apache.org/jira/browse/RYA-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15488982#comment-15488982
]
ASF GitHub Bot commented on RYA-151:
Github user amihalik commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/85#discussion_r78671763
--- Diff: extras/rya.benchmark/pom.xml ---
@@ -0,0 +1,250 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+
+rya.extras
+org.apache.rya
+3.2.10-SNAPSHOT
+
+
+4.0.0
+rya.benchmark
+
+Apache Rya Benchmarks
+
+
+
+
+org.openjdk.jmh
+jmh-core
+${jmh.version}
+
+
+org.openjdk.jmh
+jmh-generator-annprocess
+${jmh.version}
+provided
+
+
+
+org.apache.rya
+rya.indexing
+
+
+
+com.google.code.findbugs
+jsr305
+3.0.1
+
+
+
+com.google.guava
+guava
+
+
+
+junit
+junit
+test
+
+
+
+org.apache.accumulo
+accumulo-minicluster
+${accumulo.version}
+test
+
+
+
+
+
+UTF-8
+
+
+1.13
+
+
+1.8
+
+
+benchmarks
+
+
+
+
+
+src/main/xsd
+
+
+
+
+
+org.apache.maven.plugins
--- End diff --
this should be define in the project's root pom
> Rya Test Bed
>
>
> Key: RYA-151
> URL: https://issues.apache.org/jira/browse/RYA-151
> Project: Rya
> Issue Type: Wish
> Components: clients, dao
>Reporter: Puja Valiyil
>Assignee: Kevin Chilton
>
> It would be nice if there was a test bed checked in with Rya that could be
> used for benchmark testing. This test bed should include options for
> uploading data to a rya instance, then issuing some benchmark queries (and
> timing them in a way that everyone agrees is sound). It could be a command
> line tool. It should be dao agnostic (work on either mongo, accumulo, etc.).
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (RYA-151) Rya Test Bed
[ https://issues.apache.org/jira/browse/RYA-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467957#comment-15467957 ] ASF GitHub Bot commented on RYA-151: Github user kchilton2 closed the pull request at: https://github.com/apache/incubator-rya/pull/68 > Rya Test Bed > > > Key: RYA-151 > URL: https://issues.apache.org/jira/browse/RYA-151 > Project: Rya > Issue Type: Wish > Components: clients, dao >Reporter: Puja Valiyil >Assignee: Kevin Chilton > > It would be nice if there was a test bed checked in with Rya that could be > used for benchmark testing. This test bed should include options for > uploading data to a rya instance, then issuing some benchmark queries (and > timing them in a way that everyone agrees is sound). It could be a command > line tool. It should be dao agnostic (work on either mongo, accumulo, etc.). > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RYA-151) Rya Test Bed
[ https://issues.apache.org/jira/browse/RYA-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438179#comment-15438179 ] ASF GitHub Bot commented on RYA-151: Github user amihalik commented on the issue: https://github.com/apache/incubator-rya/pull/68 Please change this to point to the apache master branch. > Rya Test Bed > > > Key: RYA-151 > URL: https://issues.apache.org/jira/browse/RYA-151 > Project: Rya > Issue Type: Wish > Components: clients, dao >Reporter: Puja Valiyil >Assignee: Kevin Chilton > > It would be nice if there was a test bed checked in with Rya that could be > used for benchmark testing. This test bed should include options for > uploading data to a rya instance, then issuing some benchmark queries (and > timing them in a way that everyone agrees is sound). It could be a command > line tool. It should be dao agnostic (work on either mongo, accumulo, etc.). > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (RYA-151) Rya Test Bed
[
https://issues.apache.org/jira/browse/RYA-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426900#comment-15426900
]
ASF GitHub Bot commented on RYA-151:
Github user amihalik commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/68#discussion_r75355985
--- Diff:
extras/rya.benchmark/src/test/java/org/apache/rya/benchmark/query/BenchmarkQueriesReaderIT.java
---
@@ -0,0 +1,55 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.rya.benchmark.query;
+
+import static org.junit.Assert.assertEquals;
+
+import java.io.ByteArrayInputStream;
+import java.io.InputStream;
+
+import javax.xml.bind.JAXBException;
+
+import
org.apache.rya.benchmark.query.QueryBenchmark.BenchmarkQueriesReader;
+import org.junit.Test;
+import org.xml.sax.SAXException;
+
+import com.google.common.base.Charsets;
+
+/**
+ * Tests the methods of {@link BenchmarkQueriesReader}.
+ */
+public class BenchmarkQueriesReaderIT {
+
+@Test
+public void load() throws JAXBException, SAXException {
+// Unmarshal some XML.
+final String xml =
+"\n" +
+"\n" +
+"" +
--- End diff --
We should have query level granularity for the benchmark (i.e. we should
have timing results for each query in the benchmark), so that we can have
pretty graphs like this:
Also, it would be nice if the benchmark printed out the name of the query
for the results. So we can have a table like this:
(Note: I ripped off these graphics from Roshan's Paper)
> Rya Test Bed
>
>
> Key: RYA-151
> URL: https://issues.apache.org/jira/browse/RYA-151
> Project: Rya
> Issue Type: Wish
> Components: clients, dao
>Reporter: Puja Valiyil
>Assignee: Kevin Chilton
>
> It would be nice if there was a test bed checked in with Rya that could be
> used for benchmark testing. This test bed should include options for
> uploading data to a rya instance, then issuing some benchmark queries (and
> timing them in a way that everyone agrees is sound). It could be a command
> line tool. It should be dao agnostic (work on either mongo, accumulo, etc.).
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (RYA-151) Rya Test Bed
[
https://issues.apache.org/jira/browse/RYA-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426879#comment-15426879
]
ASF GitHub Bot commented on RYA-151:
Github user kchilton2 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/68#discussion_r75354404
--- Diff:
extras/rya.benchmark/src/test/java/org/apache/rya/benchmark/query/BenchmarkQueriesReaderIT.java
---
@@ -0,0 +1,55 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.rya.benchmark.query;
+
+import static org.junit.Assert.assertEquals;
+
+import java.io.ByteArrayInputStream;
+import java.io.InputStream;
+
+import javax.xml.bind.JAXBException;
+
+import
org.apache.rya.benchmark.query.QueryBenchmark.BenchmarkQueriesReader;
+import org.junit.Test;
+import org.xml.sax.SAXException;
+
+import com.google.common.base.Charsets;
+
+/**
+ * Tests the methods of {@link BenchmarkQueriesReader}.
+ */
+public class BenchmarkQueriesReaderIT {
+
+@Test
+public void load() throws JAXBException, SAXException {
+// Unmarshal some XML.
+final String xml =
+"\n" +
+"\n" +
+"" +
--- End diff --
What do you want to do with those attributes? If they aren't used within
the benchmark, that sort of information could easily just be XML comments.
{code}
{code}
> Rya Test Bed
>
>
> Key: RYA-151
> URL: https://issues.apache.org/jira/browse/RYA-151
> Project: Rya
> Issue Type: Wish
> Components: clients, dao
>Reporter: Puja Valiyil
>Assignee: Kevin Chilton
>
> It would be nice if there was a test bed checked in with Rya that could be
> used for benchmark testing. This test bed should include options for
> uploading data to a rya instance, then issuing some benchmark queries (and
> timing them in a way that everyone agrees is sound). It could be a command
> line tool. It should be dao agnostic (work on either mongo, accumulo, etc.).
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (RYA-151) Rya Test Bed
[
https://issues.apache.org/jira/browse/RYA-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426397#comment-15426397
]
ASF GitHub Bot commented on RYA-151:
Github user amihalik commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/68#discussion_r75303476
--- Diff:
extras/rya.benchmark/src/test/java/org/apache/rya/benchmark/query/BenchmarkQueriesReaderIT.java
---
@@ -0,0 +1,55 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.rya.benchmark.query;
+
+import static org.junit.Assert.assertEquals;
+
+import java.io.ByteArrayInputStream;
+import java.io.InputStream;
+
+import javax.xml.bind.JAXBException;
+
+import
org.apache.rya.benchmark.query.QueryBenchmark.BenchmarkQueriesReader;
+import org.junit.Test;
+import org.xml.sax.SAXException;
+
+import com.google.common.base.Charsets;
+
+/**
+ * Tests the methods of {@link BenchmarkQueriesReader}.
+ */
+public class BenchmarkQueriesReaderIT {
+
+@Test
+public void load() throws JAXBException, SAXException {
+// Unmarshal some XML.
+final String xml =
+"\n" +
+"\n" +
+"" +
--- End diff --
Can we add attributes to this? for instance
```xml
```
> Rya Test Bed
>
>
> Key: RYA-151
> URL: https://issues.apache.org/jira/browse/RYA-151
> Project: Rya
> Issue Type: Wish
> Components: clients, dao
>Reporter: Puja Valiyil
>Assignee: Kevin Chilton
>
> It would be nice if there was a test bed checked in with Rya that could be
> used for benchmark testing. This test bed should include options for
> uploading data to a rya instance, then issuing some benchmark queries (and
> timing them in a way that everyone agrees is sound). It could be a command
> line tool. It should be dao agnostic (work on either mongo, accumulo, etc.).
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
