[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2670: One suggestion about the implementation in the "SQLSegmentsExtractorEngine.extract()" method.

terrymanu commented on issue #2670: One suggestion about the implementation in the "SQLSegmentsExtractorEngine.extract()" method. URL: https://github.com/apache/incubator-shardingsphere/issues/2670#issuecomment-509098870 Good idea, can you provide a pull request to do it?

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2671: sharding-proxy是否可以同sharding-jdbc公用同一个zk上的配置？

terrymanu closed issue #2671: sharding-proxy是否可以同sharding-jdbc公用同一个zk上的配置？ URL: https://github.com/apache/incubator-shardingsphere/issues/2671 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2671: sharding-proxy是否可以同sharding-jdbc公用同一个zk上的配置？

terrymanu commented on issue #2671: sharding-proxy是否可以同sharding-jdbc公用同一个zk上的配置？ URL: https://github.com/apache/incubator-shardingsphere/issues/2671#issuecomment-509098147 **For English only**, other languages will not accept. ---

[GitHub] [incubator-shardingsphere] sunbufu commented on issue #2666: Fixes #2629

sunbufu commented on issue #2666: Fixes #2629 URL: https://github.com/apache/incubator-shardingsphere/pull/2666#issuecomment-509087320 You are right, ShardingRule is meaningless with a null ShardingRuleConfig. So, we need a judge in ShardingRule's constructor. and I notice there may throw

[GitHub] [incubator-shardingsphere] tuohai666 commented on a change in pull request #2668: add `getValueByColumnType` method

tuohai666 commented on a change in pull request #2668: add `getValueByColumnType` method URL: https://github.com/apache/incubator-shardingsphere/pull/2668#discussion_r300927416 ## File path: sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/s

[GitHub] [incubator-shardingsphere] tuohai666 commented on a change in pull request #2668: add `getValueByColumnType` method

tuohai666 commented on a change in pull request #2668: add `getValueByColumnType` method URL: https://github.com/apache/incubator-shardingsphere/pull/2668#discussion_r300927416 ## File path: sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/s

[GitHub] [incubator-shardingsphere] sunbufu commented on a change in pull request #2668: add `getValueByColumnType` method

sunbufu commented on a change in pull request #2668: add `getValueByColumnType` method URL: https://github.com/apache/incubator-shardingsphere/pull/2668#discussion_r300925257 ## File path: sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/sql

[GitHub] [incubator-shardingsphere] sunbufu commented on a change in pull request #2668: add `getValueByColumnType` method

sunbufu commented on a change in pull request #2668: add `getValueByColumnType` method URL: https://github.com/apache/incubator-shardingsphere/pull/2668#discussion_r300924997 ## File path: sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/sql

[GitHub] [incubator-shardingsphere] sunbufu commented on a change in pull request #2668: add `getValueByColumnType` method

sunbufu commented on a change in pull request #2668: add `getValueByColumnType` method URL: https://github.com/apache/incubator-shardingsphere/pull/2668#discussion_r300925257 ## File path: sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/sql

[GitHub] [incubator-shardingsphere] sunbufu commented on a change in pull request #2668: add `getValueByColumnType` method

sunbufu commented on a change in pull request #2668: add `getValueByColumnType` method URL: https://github.com/apache/incubator-shardingsphere/pull/2668#discussion_r300924997 ## File path: sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/sql

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2666: Fixes #2629

tristaZero commented on issue #2666: Fixes #2629 URL: https://github.com/apache/incubator-shardingsphere/pull/2666#issuecomment-509077891 Hi, Considering user will create ShardingRule to create ShardingDataSource, i think it is better to judge whether null == shardingRuleConfig, but do you

[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #2666: Fixes #2629

tristaZero edited a comment on issue #2666: Fixes #2629 URL: https://github.com/apache/incubator-shardingsphere/pull/2666#issuecomment-509077891 Hi, Considering user will create ShardingRule to create ShardingDataSource, i think it is better to judge whether null == shardingRuleConfig, but

[GitHub] [incubator-shardingsphere] tuohai666 commented on a change in pull request #2668: add `getValueByColumnType` method

tuohai666 commented on a change in pull request #2668: add `getValueByColumnType` method URL: https://github.com/apache/incubator-shardingsphere/pull/2668#discussion_r300919723 ## File path: sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/s

[GitHub] [incubator-shardingsphere] core1942 opened a new issue #2671: sharding-proxy是否可以同sharding-jdbc公用同一个zk上的配置？

core1942 opened a new issue #2671: sharding-proxy是否可以同sharding-jdbc公用同一个zk上的配置？ URL: https://github.com/apache/incubator-shardingsphere/issues/2671 sharding-proxy是否可以同sharding-jdbc公用同一个zk上的配置？ 如果可以的话是否只需要配置sharding-proxy的server.yaml中的orchestration配置，其他配置文件直接置空就行了？但目前我这样做回抛NullPointerExce

[GitHub] [incubator-shardingsphere] wgy8283335 opened a new issue #2670: One suggestion about the implementation in the "SQLSegmentsExtractorEngine.extract()" method.

wgy8283335 opened a new issue #2670: One suggestion about the implementation in the "SQLSegmentsExtractorEngine.extract()" method. URL: https://github.com/apache/incubator-shardingsphere/issues/2670 ## One suggestion about the implementation in the "SQLSegmentsExtractorEngine.extract()" me

[GitHub] [incubator-shardingsphere] AlbertTao commented on issue #2600: why can't we see 4.0.0-RC2 on search.maven.org？

AlbertTao commented on issue #2600: why can't we see 4.0.0-RC2 on search.maven.org？ URL: https://github.com/apache/incubator-shardingsphere/issues/2600#issuecomment-509065872 But I found some tags also publish to maven repository. ![image](https://user-images.githubusercontent.com/6252

[GitHub] [incubator-shardingsphere] tuohai666 commented on a change in pull request #2669: fix 'Unsupported data type:boolean' ShardingException

tuohai666 commented on a change in pull request #2669: fix 'Unsupported data type:boolean' ShardingException URL: https://github.com/apache/incubator-shardingsphere/pull/2669#discussion_r300908537 ## File path: sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphe

[GitHub] [incubator-shardingsphere] AlbertTao commented on issue #2600: why can't we see 4.0.0-RC2 on search.maven.org？

AlbertTao commented on issue #2600: why can't we see 4.0.0-RC2 on search.maven.org？ URL: https://github.com/apache/incubator-shardingsphere/issues/2600#issuecomment-509062862 Oh, it's only a tag. That's confuse me at first. -

[GitHub] [incubator-shardingsphere] wgy8283335 commented on issue #1951: Optimization of table metadata initialization

wgy8283335 commented on issue #1951: Optimization of table metadata initialization URL: https://github.com/apache/incubator-shardingsphere/issues/1951#issuecomment-509062384 @tristaZero @terrymanu. Does this issue still need a volunteer? ---

[GitHub] [incubator-shardingsphere] AlbertTao edited a comment on issue #2600: why can't we see 4.0.0-RC2 on search.maven.org？

AlbertTao edited a comment on issue #2600: why can't we see 4.0.0-RC2 on search.maven.org？ URL: https://github.com/apache/incubator-shardingsphere/issues/2600#issuecomment-509062284 ![image](https://user-images.githubusercontent.com/6252580/60780123-c3354200-a16f-11e9-91af-e41a6e473aa2.pn

[GitHub] [incubator-shardingsphere] AlbertTao commented on issue #2600: why can't we see 4.0.0-RC2 on search.maven.org？

AlbertTao commented on issue #2600: why can't we see 4.0.0-RC2 on search.maven.org？ URL: https://github.com/apache/incubator-shardingsphere/issues/2600#issuecomment-509062284  D

[GitHub] [incubator-shardingsphere] Saisimon opened a new pull request #2669: fix 'Unsupported data type:boolean' ShardingException

Saisimon opened a new pull request #2669: fix 'Unsupported data type:boolean' ShardingException URL: https://github.com/apache/incubator-shardingsphere/pull/2669 Fixes #2604 Changes proposed in this pull request: - ResultSetUtil#convertNumberValue support boolean type - Add un

[GitHub] [incubator-shardingsphere] wangzhengxi commented on issue #2652: Sharding-Proxy4.0.0-RC1 Not available 。The download address is http://mirrors.tuna.tsinghua.edu.cn/apache/incubator/sharding

wangzhengxi commented on issue #2652: Sharding-Proxy4.0.0-RC1 Not available 。The download address is http://mirrors.tuna.tsinghua.edu.cn/apache/incubator/shardingsphere/4.0.0-RC1/apache-shardingsphere-incubating-4.0.0-RC1-sharding-proxy-bin.tar.gz URL: https://github.com/apache/incubator-shard

[GitHub] [incubator-shardingsphere] sunbufu commented on issue #2600: why can't we see 4.0.0-RC2 on search.maven.org？

sunbufu commented on issue #2600: why can't we see 4.0.0-RC2 on search.maven.org？ URL: https://github.com/apache/incubator-shardingsphere/issues/2600#issuecomment-509060965 > @terrymanu Still could not find 4.0.0-RC2 on search.maven.org Still not release, please focus on [sharding

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2601: Verify the shardingRule at the beginning

tuohai666 commented on issue #2601: Verify the shardingRule at the beginning URL: https://github.com/apache/incubator-shardingsphere/issues/2601#issuecomment-509058928 Of course, please go through #2597 first, after that let's discuss the rules.

[GitHub] [incubator-shardingsphere] AlbertTao edited a comment on issue #2600: why can't we see 4.0.0-RC2 on search.maven.org？

AlbertTao edited a comment on issue #2600: why can't we see 4.0.0-RC2 on search.maven.org？ URL: https://github.com/apache/incubator-shardingsphere/issues/2600#issuecomment-509057650 @terrymanu Still could not find 4.0.0-RC2 on search.maven.org

[GitHub] [incubator-shardingsphere] AlbertTao commented on issue #2600: why can't we see 4.0.0-RC2 on search.maven.org？

AlbertTao commented on issue #2600: why can't we see 4.0.0-RC2 on search.maven.org？ URL: https://github.com/apache/incubator-shardingsphere/issues/2600#issuecomment-509057650 Still could not find 4.0.0-RC2 on search.maven.org --

[GitHub] [incubator-shardingsphere] KomachiSion closed issue #2664: ResultSetReturnedDatabaseMetaData.getActualTableNamePattern() has a NullPointerException

KomachiSion closed issue #2664: ResultSetReturnedDatabaseMetaData.getActualTableNamePattern() has a NullPointerException URL: https://github.com/apache/incubator-shardingsphere/issues/2664 This is an automated message from

[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #2664: ResultSetReturnedDatabaseMetaData.getActualTableNamePattern() has a NullPointerException

KomachiSion commented on issue #2664: ResultSetReturnedDatabaseMetaData.getActualTableNamePattern() has a NullPointerException URL: https://github.com/apache/incubator-shardingsphere/issues/2664#issuecomment-509044763 duplicate with #2527