[GitHub] [incubator-shardingsphere] coveralls commented on issue #4838: update contributor guide for en

2020-03-18 Thread GitBox
coveralls commented on issue #4838: update contributor guide for en URL: https://github.com/apache/incubator-shardingsphere/pull/4838#issuecomment-601002552 ## Pull Request Test Coverage Report for [Build 2157](https://coveralls.io/builds/29463267) * **0** of **0** changed or

[GitHub] [incubator-shardingsphere] JasonKing168 closed pull request #4839: 4875

2020-03-18 Thread GitBox
JasonKing168 closed pull request #4839: 4875 URL: https://github.com/apache/incubator-shardingsphere/pull/4839 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-shardingsphere] JasonKing168 opened a new pull request #4839: 4875

2020-03-18 Thread GitBox
JasonKing168 opened a new pull request #4839: 4875 URL: https://github.com/apache/incubator-shardingsphere/pull/4839 Fixes #ISSUSE_ID. Changes proposed in this pull request: - - - This is an automated

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4838: update contributor guide for en

2020-03-18 Thread GitBox
tristaZero merged pull request #4838: update contributor guide for en URL: https://github.com/apache/incubator-shardingsphere/pull/4838 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4838: update contributor guide for en

2020-03-18 Thread GitBox
terrymanu opened a new pull request #4838: update contributor guide for en URL: https://github.com/apache/incubator-shardingsphere/pull/4838 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4837: update Submit Pull Request guide

2020-03-18 Thread GitBox
terrymanu merged pull request #4837: update Submit Pull Request guide URL: https://github.com/apache/incubator-shardingsphere/pull/4837 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] terrymanu closed issue #4836: update Submit Pull Request guide

2020-03-18 Thread GitBox
terrymanu closed issue #4836: update Submit Pull Request guide URL: https://github.com/apache/incubator-shardingsphere/issues/4836 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4834: Test case of ZookeeperProperties

2020-03-18 Thread GitBox
terrymanu commented on issue #4834: Test case of ZookeeperProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4834#issuecomment-600994155 @ruanjiehui Thank you, you can finish other test cases if you interested.

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4834: Test case of ZookeeperProperties

2020-03-18 Thread GitBox
terrymanu merged pull request #4834: Test case of ZookeeperProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4834 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] terrymanu closed issue #4785: Check uniformed with all actual tables' meta data in once when loading them

2020-03-18 Thread GitBox
terrymanu closed issue #4785: Check uniformed with all actual tables' meta data in once when loading them URL: https://github.com/apache/incubator-shardingsphere/issues/4785 This is an automated message from the Apache Git

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them

2020-03-18 Thread GitBox
terrymanu merged pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them URL: https://github.com/apache/incubator-shardingsphere/pull/4826 This is an automated message

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4837: update Submit Pull Request guide

2020-03-18 Thread GitBox
coveralls commented on issue #4837: update Submit Pull Request guide URL: https://github.com/apache/incubator-shardingsphere/pull/4837#issuecomment-600992517 ## Pull Request Test Coverage Report for [Build 10384](https://coveralls.io/builds/29462751) * **0** of **0** changed or

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them

2020-03-18 Thread GitBox
coveralls edited a comment on issue #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them URL: https://github.com/apache/incubator-shardingsphere/pull/4826#issuecomment-600560207 ## Pull Request Test Coverage Report for [Build

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them

2020-03-18 Thread GitBox
codecov-io edited a comment on issue #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them URL: https://github.com/apache/incubator-shardingsphere/pull/4826#issuecomment-600731385 #

[GitHub] [incubator-shardingsphere] geomonlin edited a comment on issue #4836: update Submit Pull Request guide

2020-03-18 Thread GitBox
geomonlin edited a comment on issue #4836: update Submit Pull Request guide URL: https://github.com/apache/incubator-shardingsphere/issues/4836#issuecomment-600980258 @tristaZero Hi, this is a Submit Pull Request guide, hope can help me review. thx.

[GitHub] [incubator-shardingsphere] fantacy2001 commented on issue #4832: insert...ON DUPLICATE KEY UPDATE error

2020-03-18 Thread GitBox
fantacy2001 commented on issue #4832: insert...ON DUPLICATE KEY UPDATE error URL: https://github.com/apache/incubator-shardingsphere/issues/4832#issuecomment-600983114 > @fantacy2001 > Hi how about sharding rule configuration? only split db

[GitHub] [incubator-shardingsphere] geomonlin commented on issue #4836: update Submit Pull Request guide

2020-03-18 Thread GitBox
geomonlin commented on issue #4836: update Submit Pull Request guide URL: https://github.com/apache/incubator-shardingsphere/issues/4836#issuecomment-600980258 @tristaZero Hi, this is a Submit Pull Request guide, hope you can help me review. thx.

[GitHub] [incubator-shardingsphere] geomonlin opened a new pull request #4837: update Submit Pull Request guide

2020-03-18 Thread GitBox
geomonlin opened a new pull request #4837: update Submit Pull Request guide URL: https://github.com/apache/incubator-shardingsphere/pull/4837 Fixes #4836. This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] geomonlin opened a new issue #4836: update Submit Pull Request guide

2020-03-18 Thread GitBox
geomonlin opened a new issue #4836: update Submit Pull Request guide URL: https://github.com/apache/incubator-shardingsphere/issues/4836 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] JasonKing168 commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them

2020-03-18 Thread GitBox
JasonKing168 commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them URL: https://github.com/apache/incubator-shardingsphere/pull/4826#discussion_r394781414 ## File path:

[GitHub] [incubator-shardingsphere] JasonKing168 commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them

2020-03-18 Thread GitBox
JasonKing168 commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them URL: https://github.com/apache/incubator-shardingsphere/pull/4826#discussion_r394780998 ## File path:

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4834: Test case of ZookeeperProperties

2020-03-18 Thread GitBox
coveralls commented on issue #4834: Test case of ZookeeperProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4834#issuecomment-600977995 ## Pull Request Test Coverage Report for [Build 10381](https://coveralls.io/builds/29462046) * **0** of **0** changed or

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4825: orchestration mode code optimization .

2020-03-18 Thread GitBox
tristaZero commented on issue #4825: orchestration mode code optimization . URL: https://github.com/apache/incubator-shardingsphere/pull/4825#issuecomment-600974093 It is rather work-hard coding and reviewing from the thread of comments. Reviewing carefully @kimmking and polishing with

[GitHub] [incubator-shardingsphere] wangjing112 opened a new issue #4835: interface PreciseShardingAlgorithm.doSharding this param PreciseShardingValue type error

2020-03-18 Thread GitBox
wangjing112 opened a new issue #4835: interface PreciseShardingAlgorithm.doSharding this param PreciseShardingValue type error URL: https://github.com/apache/incubator-shardingsphere/issues/4835 sharding-jdbc 4.0.0-RC2 ### my own sharding def: ` public class

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4825: orchestration mode code optimization .

2020-03-18 Thread GitBox
coveralls edited a comment on issue #4825: orchestration mode code optimization . URL: https://github.com/apache/incubator-shardingsphere/pull/4825#issuecomment-600536871 ## Pull Request Test Coverage Report for [Build 10380](https://coveralls.io/builds/29461682) * **7** of **10**

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4825: orchestration mode code optimization .

2020-03-18 Thread GitBox
tristaZero merged pull request #4825: orchestration mode code optimization . URL: https://github.com/apache/incubator-shardingsphere/pull/4825 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4825: orchestration mode code optimization .

2020-03-18 Thread GitBox
codecov-io edited a comment on issue #4825: orchestration mode code optimization . URL: https://github.com/apache/incubator-shardingsphere/pull/4825#issuecomment-600566986 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr=h1) Report > Merging

[GitHub] [incubator-shardingsphere] wangjing112 commented on issue #4707: proxy-4.0.1 return wrong result when use varchar type in hibernate.

2020-03-18 Thread GitBox
wangjing112 commented on issue #4707: proxy-4.0.1 return wrong result when use varchar type in hibernate. URL: https://github.com/apache/incubator-shardingsphere/issues/4707#issuecomment-600967267 > Is there any connection between the log you provided and the exception you faced.

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4825: orchestration mode code optimization .

2020-03-18 Thread GitBox
coveralls edited a comment on issue #4825: orchestration mode code optimization . URL: https://github.com/apache/incubator-shardingsphere/pull/4825#issuecomment-600536871 ## Pull Request Test Coverage Report for [Build 10378](https://coveralls.io/builds/29461242) * **6** of **9**

[GitHub] [incubator-shardingsphere] ruanjiehui opened a new pull request #4834: Test case of ZookeeperProperties

2020-03-18 Thread GitBox
ruanjiehui opened a new pull request #4834: Test case of ZookeeperProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4834 Fixes #4820 Changes proposed in this pull request: - Test case of ZookeeperProperties

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4832: insert...ON DUPLICATE KEY UPDATE error

2020-03-18 Thread GitBox
tristaZero commented on issue #4832: insert...ON DUPLICATE KEY UPDATE error URL: https://github.com/apache/incubator-shardingsphere/issues/4832#issuecomment-600960581 @fantacy2001 Hi how about sharding rule configuration?

[GitHub] [incubator-shardingsphere] geomonlin edited a comment on issue #4776: Add start-index and stop-index assertion for ParameterMarkerExpression

2020-03-18 Thread GitBox
geomonlin edited a comment on issue #4776: Add start-index and stop-index assertion for ParameterMarkerExpression URL: https://github.com/apache/incubator-shardingsphere/issues/4776#issuecomment-600960430 > @geomonlin Hi Any progress made? Hi. This is basically over. Will submit

[GitHub] [incubator-shardingsphere] geomonlin commented on issue #4776: Add start-index and stop-index assertion for ParameterMarkerExpression

2020-03-18 Thread GitBox
geomonlin commented on issue #4776: Add start-index and stop-index assertion for ParameterMarkerExpression URL: https://github.com/apache/incubator-shardingsphere/issues/4776#issuecomment-600960430 > @geomonlin Hi Any progress made? This is basically over. Will submit later.

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4776: Add start-index and stop-index assertion for ParameterMarkerExpression

2020-03-18 Thread GitBox
tristaZero commented on issue #4776: Add start-index and stop-index assertion for ParameterMarkerExpression URL: https://github.com/apache/incubator-shardingsphere/issues/4776#issuecomment-600959663 @geomonlin Hi Any progress made?

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4707: proxy-4.0.1 return error varchar in use hibernate.

2020-03-18 Thread GitBox
tristaZero commented on issue #4707: proxy-4.0.1 return error varchar in use hibernate. URL: https://github.com/apache/incubator-shardingsphere/issues/4707#issuecomment-600959269 Is there any connection between the log you provided and the exception you faced.

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4707: proxy-4.0.1 return error varchar in use hibernate.

2020-03-18 Thread GitBox
tristaZero commented on issue #4707: proxy-4.0.1 return error varchar in use hibernate. URL: https://github.com/apache/incubator-shardingsphere/issues/4707#issuecomment-600958860 @wangjiang112, Hi, Please Abide by the Apache community rule to involve in English.

[GitHub] [incubator-shardingsphere] tristaZero closed issue #4711: request for support tidb

2020-03-18 Thread GitBox
tristaZero closed issue #4711: request for support tidb URL: https://github.com/apache/incubator-shardingsphere/issues/4711 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4711: request for support tidb

2020-03-18 Thread GitBox
tristaZero commented on issue #4711: request for support tidb URL: https://github.com/apache/incubator-shardingsphere/issues/4711#issuecomment-600956392 @yinkaihuang Hi Sorry, this issue has not received any reply from you for more than 7 days. So we have to close it.

[GitHub] [incubator-shardingsphere] kimmking commented on issue #4778: Optimize configuration structure of config center

2020-03-18 Thread GitBox
kimmking commented on issue #4778: Optimize configuration structure of config center URL: https://github.com/apache/incubator-shardingsphere/issues/4778#issuecomment-600956475 proxy -> proxies is better. This is an

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them

2020-03-18 Thread GitBox
kimmking commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them URL: https://github.com/apache/incubator-shardingsphere/pull/4826#discussion_r394754580 ## File path:

[GitHub] [incubator-shardingsphere] meAsky commented on issue #4820: Add test cases for TypedProperties implementation

2020-03-18 Thread GitBox
meAsky commented on issue #4820: Add test cases for TypedProperties implementation URL: https://github.com/apache/incubator-shardingsphere/issues/4820#issuecomment-600952435 I want to try the ApolloProperties test cases @terrymanu

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4825: orchestration mode code optimization .

2020-03-18 Thread GitBox
coveralls edited a comment on issue #4825: orchestration mode code optimization . URL: https://github.com/apache/incubator-shardingsphere/pull/4825#issuecomment-600536871 ## Pull Request Test Coverage Report for [Build 10374](https://coveralls.io/builds/29460260) * **7** of **13**

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4825: orchestration mode code optimization .

2020-03-18 Thread GitBox
codecov-io edited a comment on issue #4825: orchestration mode code optimization . URL: https://github.com/apache/incubator-shardingsphere/pull/4825#issuecomment-600566986 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr=h1) Report > Merging

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them

2020-03-18 Thread GitBox
coveralls edited a comment on issue #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them URL: https://github.com/apache/incubator-shardingsphere/pull/4826#issuecomment-600560207 ## Pull Request Test Coverage Report for [Build

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4833: adjust threadpool size in asyncLoad

2020-03-18 Thread GitBox
coveralls edited a comment on issue #4833: adjust threadpool size in asyncLoad URL: https://github.com/apache/incubator-shardingsphere/pull/4833#issuecomment-600759944 ## Pull Request Test Coverage Report for [Build 10372](https://coveralls.io/builds/29451204) * **0** of **3**

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4833: adjust threadpool size in asyncLoad

2020-03-18 Thread GitBox
coveralls commented on issue #4833: adjust threadpool size in asyncLoad URL: https://github.com/apache/incubator-shardingsphere/pull/4833#issuecomment-600759944 ## Pull Request Test Coverage Report for [Build 2155](https://coveralls.io/builds/29450379) * **0** of **3** **(0.0%)**

[GitHub] [incubator-shardingsphere] kimmking opened a new pull request #4833: adjust threadpool size in asyncLoad

2020-03-18 Thread GitBox
kimmking opened a new pull request #4833: adjust threadpool size in asyncLoad URL: https://github.com/apache/incubator-shardingsphere/pull/4833 Changes proposed in this pull request: - adjust threadpool size in asyncLoad

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them

2020-03-18 Thread GitBox
coveralls edited a comment on issue #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them URL: https://github.com/apache/incubator-shardingsphere/pull/4826#issuecomment-600560207 ## Pull Request Test Coverage Report for [Build

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them

2020-03-18 Thread GitBox
codecov-io commented on issue #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them URL: https://github.com/apache/incubator-shardingsphere/pull/4826#issuecomment-600731385 #

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4789: ref 4671

2020-03-18 Thread GitBox
coveralls commented on issue #4789: ref 4671 URL: https://github.com/apache/incubator-shardingsphere/pull/4789#issuecomment-600724973 ## Pull Request Test Coverage Report for [Build 10370](https://coveralls.io/builds/29448691) * **0** of **45** **(0.0%)** changed or added

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them

2020-03-18 Thread GitBox
coveralls edited a comment on issue #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them URL: https://github.com/apache/incubator-shardingsphere/pull/4826#issuecomment-600560207 ## Pull Request Test Coverage Report for [Build

[GitHub] [incubator-shardingsphere] JasonKing168 commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them

2020-03-18 Thread GitBox
JasonKing168 commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them URL: https://github.com/apache/incubator-shardingsphere/pull/4826#discussion_r394413198 ## File path:

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them

2020-03-18 Thread GitBox
kimmking commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them URL: https://github.com/apache/incubator-shardingsphere/pull/4826#discussion_r394399489 ## File path:

[GitHub] [incubator-shardingsphere] fantacy2001 opened a new issue #4832: insert...ON DUPLICATE KEY UPDATE error

2020-03-18 Thread GitBox
fantacy2001 opened a new issue #4832: insert...ON DUPLICATE KEY UPDATE error URL: https://github.com/apache/incubator-shardingsphere/issues/4832 when execute sql that likes follow INSERT INTO stock_age ( tenant_id, warehouse_no, sku_no, lot_no, package_no,

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them

2020-03-18 Thread GitBox
kimmking commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them URL: https://github.com/apache/incubator-shardingsphere/pull/4826#discussion_r394397062 ## File path:

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4825: orchestration mode code optimization .

2020-03-18 Thread GitBox
kimmking commented on a change in pull request #4825: orchestration mode code optimization . URL: https://github.com/apache/incubator-shardingsphere/pull/4825#discussion_r394396209 ## File path:

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4825: orchestration mode code optimization .

2020-03-18 Thread GitBox
coveralls edited a comment on issue #4825: orchestration mode code optimization . URL: https://github.com/apache/incubator-shardingsphere/pull/4825#issuecomment-600536871 ## Pull Request Test Coverage Report for [Build 10366](https://coveralls.io/builds/29445688) * **13** of

[GitHub] [incubator-shardingsphere] JasonKing168 commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them

2020-03-18 Thread GitBox
JasonKing168 commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them URL: https://github.com/apache/incubator-shardingsphere/pull/4826#discussion_r394342909 ## File path:

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them

2020-03-18 Thread GitBox
terrymanu commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them URL: https://github.com/apache/incubator-shardingsphere/pull/4826#discussion_r394331149 ## File path:

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them

2020-03-18 Thread GitBox
terrymanu commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them URL: https://github.com/apache/incubator-shardingsphere/pull/4826#discussion_r394331664 ## File path:

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them

2020-03-18 Thread GitBox
terrymanu commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them URL: https://github.com/apache/incubator-shardingsphere/pull/4826#discussion_r394329483 ## File path:

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them

2020-03-18 Thread GitBox
terrymanu commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them URL: https://github.com/apache/incubator-shardingsphere/pull/4826#discussion_r394332106 ## File path:

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them

2020-03-18 Thread GitBox
terrymanu commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them URL: https://github.com/apache/incubator-shardingsphere/pull/4826#discussion_r394330227 ## File path:

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them

2020-03-18 Thread GitBox
terrymanu commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once when loading them URL: https://github.com/apache/incubator-shardingsphere/pull/4826#discussion_r394330908 ## File path:

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4831: Revert "adjust threadpool size in asyncLoad"

2020-03-18 Thread GitBox
tristaZero merged pull request #4831: Revert "adjust threadpool size in asyncLoad" URL: https://github.com/apache/incubator-shardingsphere/pull/4831 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4828: adjust threadpool size in asyncLoad

2020-03-18 Thread GitBox
terrymanu commented on issue #4828: adjust threadpool size in asyncLoad URL: https://github.com/apache/incubator-shardingsphere/pull/4828#issuecomment-600606833 Invalid for break test This is an automated message from the

[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4831: Revert "adjust threadpool size in asyncLoad"

2020-03-18 Thread GitBox
terrymanu opened a new pull request #4831: Revert "adjust threadpool size in asyncLoad" URL: https://github.com/apache/incubator-shardingsphere/pull/4831 Reverts apache/incubator-shardingsphere#4828 This is an automated

[GitHub] [incubator-shardingsphere] terrymanu closed issue #4830: Exception“Must have sharding column with subquery” when use nonesharding

2020-03-18 Thread GitBox
terrymanu closed issue #4830: Exception“Must have sharding column with subquery” when use nonesharding URL: https://github.com/apache/incubator-shardingsphere/issues/4830 This is an automated message from the Apache Git

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4830: Exception“Must have sharding column with subquery” when use nonesharding

2020-03-18 Thread GitBox
terrymanu commented on issue #4830: Exception“Must have sharding column with subquery” when use nonesharding URL: https://github.com/apache/incubator-shardingsphere/issues/4830#issuecomment-600604676 Duplicate with #4722

[GitHub] [incubator-shardingsphere] kimmking commented on issue #4820: Add test cases for TypedProperties implementation

2020-03-18 Thread GitBox
kimmking commented on issue #4820: Add test cases for TypedProperties implementation URL: https://github.com/apache/incubator-shardingsphere/issues/4820#issuecomment-600602837 > I want to try the ZookeeperProperties test cases @terrymanu Nice, anything could be discussed about

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once…

2020-03-18 Thread GitBox
kimmking commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once… URL: https://github.com/apache/incubator-shardingsphere/pull/4826#discussion_r394317715 ## File path:

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once…

2020-03-18 Thread GitBox
kimmking commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once… URL: https://github.com/apache/incubator-shardingsphere/pull/4826#discussion_r394316299 ## File path:

[GitHub] [incubator-shardingsphere] libinglong commented on issue #3097: Unknown system variable 'query_cache_size'

2020-03-18 Thread GitBox
libinglong commented on issue #3097: Unknown system variable 'query_cache_size' URL: https://github.com/apache/incubator-shardingsphere/issues/3097#issuecomment-600599894 I have compiled the latest matser branch (commit id 932358b4f445a6a0e102def50db45d23e87bcc3a),but the

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4825: orchestration mode code optimization .

2020-03-18 Thread GitBox
kimmking commented on a change in pull request #4825: orchestration mode code optimization . URL: https://github.com/apache/incubator-shardingsphere/pull/4825#discussion_r394315244 ## File path:

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4825: orchestration mode code optimization .

2020-03-18 Thread GitBox
kimmking commented on a change in pull request #4825: orchestration mode code optimization . URL: https://github.com/apache/incubator-shardingsphere/pull/4825#discussion_r394314389 ## File path:

[GitHub] [incubator-shardingsphere] dongzl edited a comment on issue #4317: Use encrypt-raw-jdbc-example fails because of "Unsupport SQL of " error

2020-03-18 Thread GitBox
dongzl edited a comment on issue #4317: Use encrypt-raw-jdbc-example fails because of "Unsupport SQL of " error URL: https://github.com/apache/incubator-shardingsphere/issues/4317#issuecomment-600591780 Hi @ppourali , I want to solve this problem, but I try the 4.0.0-RC3, 4.0.0, 4.0.1

[GitHub] [incubator-shardingsphere] linyuliang opened a new issue #4830: Exception“Must have sharding column with subquery” when use nonesharding

2020-03-18 Thread GitBox
linyuliang opened a new issue #4830: Exception“Must have sharding column with subquery” when use nonesharding URL: https://github.com/apache/incubator-shardingsphere/issues/4830 ## Bug Report ### Which version of ShardingSphere did you use?

[GitHub] [incubator-shardingsphere] dongzl commented on issue #4317: Use encrypt-raw-jdbc-example fails because of "Unsupport SQL of " error

2020-03-18 Thread GitBox
dongzl commented on issue #4317: Use encrypt-raw-jdbc-example fails because of "Unsupport SQL of " error URL: https://github.com/apache/incubator-shardingsphere/issues/4317#issuecomment-600591780 Hi @ppourali , I want to solve this problem, but I try the 4.0.0-RC3, 4.0.0, 4.0.1 and the

[GitHub] [incubator-shardingsphere] JasonKing168 commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once…

2020-03-18 Thread GitBox
JasonKing168 commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once… URL: https://github.com/apache/incubator-shardingsphere/pull/4826#discussion_r394294123 ## File path:

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4825: orchestration mode code optimization .

2020-03-18 Thread GitBox
coveralls edited a comment on issue #4825: orchestration mode code optimization . URL: https://github.com/apache/incubator-shardingsphere/pull/4825#issuecomment-600536871 ## Pull Request Test Coverage Report for [Build 10358](https://coveralls.io/builds/29442574) * **7** of **13**

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4825: orchestration mode code optimization .

2020-03-18 Thread GitBox
codecov-io commented on issue #4825: orchestration mode code optimization . URL: https://github.com/apache/incubator-shardingsphere/pull/4825#issuecomment-600566986 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr=h1) Report > Merging

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4826: issue-4785: Check uniformed with all actual tables' meta data in once…

2020-03-18 Thread GitBox
coveralls commented on issue #4826: issue-4785: Check uniformed with all actual tables' meta data in once… URL: https://github.com/apache/incubator-shardingsphere/pull/4826#issuecomment-600560207 ## Pull Request Test Coverage Report for [Build 10352](https://coveralls.io/builds/29442116)

[GitHub] [incubator-shardingsphere] JasonKing168 commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once…

2020-03-18 Thread GitBox
JasonKing168 commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once… URL: https://github.com/apache/incubator-shardingsphere/pull/4826#discussion_r394265128 ## File path:

[GitHub] [incubator-shardingsphere] JasonKing168 commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once…

2020-03-18 Thread GitBox
JasonKing168 commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once… URL: https://github.com/apache/incubator-shardingsphere/pull/4826#discussion_r394262437 ## File path:

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once…

2020-03-18 Thread GitBox
terrymanu commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once… URL: https://github.com/apache/incubator-shardingsphere/pull/4826#discussion_r394260250 ## File path:

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once…

2020-03-18 Thread GitBox
terrymanu commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once… URL: https://github.com/apache/incubator-shardingsphere/pull/4826#discussion_r394258755 ## File path:

[GitHub] [incubator-shardingsphere] phoema commented on issue #4810: Abount Exception [Can not find owner from table.]

2020-03-18 Thread GitBox
phoema commented on issue #4810: Abount Exception [Can not find owner from table.] URL: https://github.com/apache/incubator-shardingsphere/issues/4810#issuecomment-600554584 SQL parse throws NullPointerException may be it can be a test case. SELECT RES.*, (

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4828: adjust threadpool size in asyncLoad

2020-03-18 Thread GitBox
terrymanu merged pull request #4828: adjust threadpool size in asyncLoad URL: https://github.com/apache/incubator-shardingsphere/pull/4828 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] kimmking opened a new issue #4681: orchestration-refactoring phase 1

2020-03-18 Thread GitBox
kimmking opened a new issue #4681: orchestration-refactoring phase 1 URL: https://github.com/apache/incubator-shardingsphere/issues/4681 According to https://github.com/apache/incubator-shardingsphere/issues/4522 , orchestration-refactoring begin now. 1.orchestration-refactoring phase 1

[GitHub] [incubator-shardingsphere] tuohai666 merged pull request #4829: Move orchestration config to orchestration module

2020-03-18 Thread GitBox
tuohai666 merged pull request #4829: Move orchestration config to orchestration module URL: https://github.com/apache/incubator-shardingsphere/pull/4829 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4829: Move orchestration config to orchestration module

2020-03-18 Thread GitBox
terrymanu opened a new pull request #4829: Move orchestration config to orchestration module URL: https://github.com/apache/incubator-shardingsphere/pull/4829 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] tuohai666 closed pull request #4827: #4460, fix order by string column exception

2020-03-18 Thread GitBox
tuohai666 closed pull request #4827: #4460, fix order by string column exception URL: https://github.com/apache/incubator-shardingsphere/pull/4827 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] kimmking opened a new pull request #4828: adjust threadpool size in asyncLoad

2020-03-18 Thread GitBox
kimmking opened a new pull request #4828: adjust threadpool size in asyncLoad URL: https://github.com/apache/incubator-shardingsphere/pull/4828 Changes proposed in this pull request: - adjust threadpool size in asyncLoad

[GitHub] [incubator-shardingsphere] yu199195 opened a new pull request #4825: orchestration mode code optimization .

2020-03-18 Thread GitBox
yu199195 opened a new pull request #4825: orchestration mode code optimization . URL: https://github.com/apache/incubator-shardingsphere/pull/4825 this is orchestration mode code optimization . This is an automated

[GitHub] [incubator-shardingsphere] tuohai666 opened a new pull request #4827: #4460, fix order by string column exception

2020-03-18 Thread GitBox
tuohai666 opened a new pull request #4827: #4460, fix order by string column exception URL: https://github.com/apache/incubator-shardingsphere/pull/4827 Fixes #4460. This is an automated message from the Apache Git

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4825: orchestration mode code optimization .

2020-03-18 Thread GitBox
coveralls commented on issue #4825: orchestration mode code optimization . URL: https://github.com/apache/incubator-shardingsphere/pull/4825#issuecomment-600536871 ## Pull Request Test Coverage Report for [Build 10349](https://coveralls.io/builds/29440789) * **8** of **12**

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2884: Repeated column when use encrypt with JPA + Springboot

2020-03-18 Thread GitBox
terrymanu commented on issue #2884: Repeated column when use encrypt with JPA + Springboot URL: https://github.com/apache/incubator-shardingsphere/issues/2884#issuecomment-600536158 Fixed at #3340 This is an automated

[GitHub] [incubator-shardingsphere] yu199195 closed pull request #4825: orchestration mode code optimization .

2020-03-18 Thread GitBox
yu199195 closed pull request #4825: orchestration mode code optimization . URL: https://github.com/apache/incubator-shardingsphere/pull/4825 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] yu199195 opened a new pull request #4825: orchestration mode code optimization .

2020-03-18 Thread GitBox
yu199195 opened a new pull request #4825: orchestration mode code optimization . URL: https://github.com/apache/incubator-shardingsphere/pull/4825 this is orchestration mode code optimization . This is an automated

[GitHub] [incubator-shardingsphere] yu199195 closed pull request #4825: orchestration mode code optimization .

2020-03-18 Thread GitBox
yu199195 closed pull request #4825: orchestration mode code optimization . URL: https://github.com/apache/incubator-shardingsphere/pull/4825 This is an automated message from the Apache Git Service. To respond to the

  1   2   >