[GitHub] [incubator-shardingsphere] TaoZhiMLND commented on issue #1977: make key-generator and encryptor strategy as a spring bean on spring namespace

2020-03-25 Thread GitBox
TaoZhiMLND commented on issue #1977: make key-generator and encryptor strategy as a spring bean on spring namespace URL: https://github.com/apache/incubator-shardingsphere/issues/1977#issuecomment-603988361 After the discussion with @cherrylzhao, we decide make key-generator as a spring

[GitHub] [incubator-shardingsphere] TaoZhiMLND opened a new pull request #4945: make key-generator as a spring bean on spring namespace.

2020-03-25 Thread GitBox
TaoZhiMLND opened a new pull request #4945: make key-generator as a spring bean on spring namespace. URL: https://github.com/apache/incubator-shardingsphere/pull/4945 Fixes #1977. Changes proposed in this pull request: - [✓] change `shardingNamespace.xml` configuration. - [✓]

[GitHub] [incubator-shardingsphere] sebbASF commented on issue #4902: Disclaimer - incorrect text

2020-03-25 Thread GitBox
sebbASF commented on issue #4902: Disclaimer - incorrect text URL: https://github.com/apache/incubator-shardingsphere/issues/4902#issuecomment-603983923 Thanks, looks good now This is an automated message from the Apache Git

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4945: make key-generator as a spring bean on spring namespace.

2020-03-25 Thread GitBox
kimmking commented on a change in pull request #4945: make key-generator as a spring bean on spring namespace. URL: https://github.com/apache/incubator-shardingsphere/pull/4945#discussion_r398255595 ## File path:

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4945: make key-generator as a spring bean on spring namespace.

2020-03-25 Thread GitBox
kimmking commented on a change in pull request #4945: make key-generator as a spring bean on spring namespace. URL: https://github.com/apache/incubator-shardingsphere/pull/4945#discussion_r398255632 ## File path:

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4945: make key-generator as a spring bean on spring namespace.

2020-03-25 Thread GitBox
kimmking commented on a change in pull request #4945: make key-generator as a spring bean on spring namespace. URL: https://github.com/apache/incubator-shardingsphere/pull/4945#discussion_r398255615 ## File path:

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4945: make key-generator as a spring bean on spring namespace.

2020-03-25 Thread GitBox
kimmking commented on a change in pull request #4945: make key-generator as a spring bean on spring namespace. URL: https://github.com/apache/incubator-shardingsphere/pull/4945#discussion_r398256450 ## File path:

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4945: make key-generator as a spring bean on spring namespace.

2020-03-25 Thread GitBox
kimmking commented on a change in pull request #4945: make key-generator as a spring bean on spring namespace. URL: https://github.com/apache/incubator-shardingsphere/pull/4945#discussion_r398257053 ## File path:

[incubator-shardingsphere-benchmark] branch master updated: for performance

2020-03-25 Thread zhangyonglun
This is an automated email from the ASF dual-hosted git repository. zhangyonglun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-shardingsphere-benchmark.git The following commit(s) were added to refs/heads/master by this push: new e65f96e for

[GitHub] [incubator-shardingsphere] kimmking commented on issue #4945: make key-generator as a spring bean on spring namespace.

2020-03-25 Thread GitBox
kimmking commented on issue #4945: make key-generator as a spring bean on spring namespace. URL: https://github.com/apache/incubator-shardingsphere/pull/4945#issuecomment-604166533 fix ut first This is an automated message

[GitHub] [incubator-shardingsphere] nevereverever commented on issue #4946: To terryManu

2020-03-25 Thread GitBox
nevereverever commented on issue #4946: To terryManu URL: https://github.com/apache/incubator-shardingsphere/issues/4946#issuecomment-604165480 @terrymanu This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] nevereverever opened a new issue #4946: To terryManu

2020-03-25 Thread GitBox
nevereverever opened a new issue #4946: To terryManu URL: https://github.com/apache/incubator-shardingsphere/issues/4946 Dear terryManu: I've been using sharding proxy for two months,and try to use it in the project.I reported some questions,some of them were closed before they were

[GitHub] [incubator-shardingsphere] nevereverever commented on issue #4946: To terryManu

2020-03-25 Thread GitBox
nevereverever commented on issue #4946: To terryManu URL: https://github.com/apache/incubator-shardingsphere/issues/4946#issuecomment-604184246 @kimmking 1.when using '' ,it print: ```java [DEBUG] 09:37:18.846 [pool-7-thread-1] c.p.p.s.r.s.SimpleHashShardingAlgorithm -

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #4946: To terryManu

2020-03-25 Thread GitBox
terrymanu edited a comment on issue #4946: To terryManu URL: https://github.com/apache/incubator-shardingsphere/issues/4946#issuecomment-604207517 Thank you the feedback. It is better to send mailing list for this issue. I think we have already provide the reason before issue closed,

[GitHub] [incubator-shardingsphere] menghaoranss opened a new pull request #4950: Update UI documents

2020-03-25 Thread GitBox
menghaoranss opened a new pull request #4950: Update UI documents URL: https://github.com/apache/incubator-shardingsphere/pull/4950 Fixes #4933 . Changes proposed in this pull request: - add `config-center.cn.md` and `config-center.en.md` - modify `registry-center.cn.md`

[GitHub] [incubator-shardingsphere] Akigaze commented on issue #4947: Is there any way to traverse tables in the specified order by Schema & Table Route

2020-03-25 Thread GitBox
Akigaze commented on issue #4947: Is there any way to traverse tables in the specified order by Schema & Table Route URL: https://github.com/apache/incubator-shardingsphere/issues/4947#issuecomment-604226757 Here is my sharding rule ```java public class CreatedTimeShardingAlgorithm

[GitHub] [incubator-shardingsphere] ssxlulu commented on issue #4910: how to integerating sharding and non-sharding transaction with xa

2020-03-25 Thread GitBox
ssxlulu commented on issue #4910: how to integerating sharding and non-sharding transaction with xa URL: https://github.com/apache/incubator-shardingsphere/issues/4910#issuecomment-604237131 You can use Begin ... COMMIT around your sqls. Like this: ``` BEGIN; UPDATE TABLE

[GitHub] [incubator-shardingsphere] ma1562013338 commented on issue #4760: Setting SQL timeout time in mybatis does not take effect after sharding- JDBC 4.0.0-RC2 is used

2020-03-25 Thread GitBox
ma1562013338 commented on issue #4760: Setting SQL timeout time in mybatis does not take effect after sharding- JDBC 4.0.0-RC2 is used URL: https://github.com/apache/incubator-shardingsphere/issues/4760#issuecomment-604177958 @terrymanu I hope the timeout time set by mybatis is valid.

[GitHub] [incubator-shardingsphere] kimmking commented on issue #4947: Is there any way to traverse tables in the specified order by Schema & Table Route

2020-03-25 Thread GitBox
kimmking commented on issue #4947: Is there any way to traverse tables in the specified order by Schema & Table Route URL: https://github.com/apache/incubator-shardingsphere/issues/4947#issuecomment-604178039 `select * from t_msg where business_key=? and created_time = now() `

[GitHub] [incubator-shardingsphere] wuguowei19880907 closed issue #4930: why sharding has many unsupported operation

2020-03-25 Thread GitBox
wuguowei19880907 closed issue #4930: why sharding has many unsupported operation URL: https://github.com/apache/incubator-shardingsphere/issues/4930 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] wuguowei19880907 commented on issue #4930: why sharding has many unsupported operation

2020-03-25 Thread GitBox
wuguowei19880907 commented on issue #4930: why sharding has many unsupported operation URL: https://github.com/apache/incubator-shardingsphere/issues/4930#issuecomment-604181037 ok,thanks This is an automated message from

[GitHub] [incubator-shardingsphere] wuguowei19880907 opened a new pull request #4952: Add operations on cursors to EncryptResultSet(Suitable for a single data source) by originalResultSet

2020-03-25 Thread GitBox
wuguowei19880907 opened a new pull request #4952: Add operations on cursors to EncryptResultSet(Suitable for a single data source) by originalResultSet URL: https://github.com/apache/incubator-shardingsphere/pull/4952 Add operations on cursors to EncryptResultSet(Suitable for a single

[GitHub] [incubator-shardingsphere] nevereverever commented on issue #4946: To terryManu

2020-03-25 Thread GitBox
nevereverever commented on issue #4946: To terryManu URL: https://github.com/apache/incubator-shardingsphere/issues/4946#issuecomment-604185702 By the way,I know using long values is not a good way to use it in mysql,I tend to use `batch`,but this is to restore `mybatis foreach`.

[GitHub] [incubator-shardingsphere] menghaoranss commented on issue #4944: UI module feature discuss

2020-03-25 Thread GitBox
menghaoranss commented on issue #4944: UI module feature discuss URL: https://github.com/apache/incubator-shardingsphere/issues/4944#issuecomment-604194656 @pkwenda The UI module is being optimized continuously, and there are still many problems to be solved. If you are interested in

[GitHub] [incubator-shardingsphere] Akigaze commented on issue #4947: Is there any way to traverse tables in the specified order by Schema & Table Route

2020-03-25 Thread GitBox
Akigaze commented on issue #4947: Is there any way to traverse tables in the specified order by Schema & Table Route URL: https://github.com/apache/incubator-shardingsphere/issues/4947#issuecomment-604198433 @kimmking Thanks for you answer. I am sorry I had missed some information in

[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #4916: add tableReferences in selectStatement

2020-03-25 Thread GitBox
tristaZero commented on a change in pull request #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916#discussion_r398298231 ## File path:

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4946: To terryManu

2020-03-25 Thread GitBox
terrymanu commented on issue #4946: To terryManu URL: https://github.com/apache/incubator-shardingsphere/issues/4946#issuecomment-604209000 The title of the issue is not user friendly and maybe no value for other users. This project is not my personal project, we just face to all

[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #4916: add tableReferences in selectStatement

2020-03-25 Thread GitBox
tristaZero commented on a change in pull request #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916#discussion_r398298401 ## File path:

[GitHub] [incubator-shardingsphere] kimmking opened a new pull request #4949: revise faq documents

2020-03-25 Thread GitBox
kimmking opened a new pull request #4949: revise faq documents URL: https://github.com/apache/incubator-shardingsphere/pull/4949 Changes proposed in this pull request: - revise faq documents This is an automated

[GitHub] [incubator-shardingsphere] kimmking commented on issue #4947: Is there any way to traverse tables in the specified order by Schema & Table Route

2020-03-25 Thread GitBox
kimmking commented on issue #4947: Is there any way to traverse tables in the specified order by Schema & Table Route URL: https://github.com/apache/incubator-shardingsphere/issues/4947#issuecomment-604215177 can you show your sharding rule

[GitHub] [incubator-shardingsphere] ssxlulu commented on issue #4936: execute statement what is "create database testName" error in sharding-proxy module

2020-03-25 Thread GitBox
ssxlulu commented on issue #4936: execute statement what is "create database testName" error in sharding-proxy module URL: https://github.com/apache/incubator-shardingsphere/issues/4936#issuecomment-604234467 For now, shardng-proxy can not support create database syntax.

[GitHub] [incubator-shardingsphere] cherrylzhao opened a new pull request #4951: using ShardingTransactionTypeScanner to create proxy bean which include transaction type annotation

2020-03-25 Thread GitBox
cherrylzhao opened a new pull request #4951: using ShardingTransactionTypeScanner to create proxy bean which include transaction type annotation URL: https://github.com/apache/incubator-shardingsphere/pull/4951 - ShardingTransactionTypeScanner scanner will create proxy automatically

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4951: using ShardingTransactionTypeScanner to create proxy bean which include transaction type annotation

2020-03-25 Thread GitBox
coveralls commented on issue #4951: using ShardingTransactionTypeScanner to create proxy bean which include transaction type annotation URL: https://github.com/apache/incubator-shardingsphere/pull/4951#issuecomment-604242002 ## Pull Request Test Coverage Report for [Build

[GitHub] [incubator-shardingsphere] kimmking commented on issue #4946: To terryManu

2020-03-25 Thread GitBox
kimmking commented on issue #4946: To terryManu URL: https://github.com/apache/incubator-shardingsphere/issues/4946#issuecomment-604173268 Hi, @nevereverever thx for your attention. 1. What this log actually print: >

[GitHub] [incubator-shardingsphere] menghaoranss opened a new pull request #4948: for issue#4933 update ui documents

2020-03-25 Thread GitBox
menghaoranss opened a new pull request #4948: for issue#4933 update ui documents URL: https://github.com/apache/incubator-shardingsphere/pull/4948 Fixes #4933 . Changes proposed in this pull request: - add `config-center.cn.md` and `config-center.en.md` - modify

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4946: To terryManu

2020-03-25 Thread GitBox
terrymanu commented on issue #4946: To terryManu URL: https://github.com/apache/incubator-shardingsphere/issues/4946#issuecomment-604207517 Thank you the feedback. It is better to send mailing list for this issue. I think we have already provide the reason before issue closed, and we

[GitHub] [incubator-shardingsphere] menghaoranss closed pull request #4948: for issue#4933 update ui documents

2020-03-25 Thread GitBox
menghaoranss closed pull request #4948: for issue#4933 update ui documents URL: https://github.com/apache/incubator-shardingsphere/pull/4948 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4949: revise faq documents

2020-03-25 Thread GitBox
terrymanu merged pull request #4949: revise faq documents URL: https://github.com/apache/incubator-shardingsphere/pull/4949 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-shardingsphere] Akigaze opened a new issue #4947: Is there any way to traverse tables in the specified order by Schema & Table Route

2020-03-25 Thread GitBox
Akigaze opened a new issue #4947: Is there any way to traverse tables in the specified order by Schema & Table Route URL: https://github.com/apache/incubator-shardingsphere/issues/4947 ## Question **logic table:** t_msg (**column:** created_time (*sharding key*), version,

[GitHub] [incubator-shardingsphere] ma1562013338 edited a comment on issue #4760: Setting SQL timeout time in mybatis does not take effect after sharding- JDBC 4.0.0-RC2 is used

2020-03-25 Thread GitBox
ma1562013338 edited a comment on issue #4760: Setting SQL timeout time in mybatis does not take effect after sharding- JDBC 4.0.0-RC2 is used URL: https://github.com/apache/incubator-shardingsphere/issues/4760#issuecomment-604177958 @terrymanu I hope the timeout time set by mybatis is

[GitHub] [incubator-shardingsphere] kimmking commented on issue #4944: UI module feature discuss

2020-03-25 Thread GitBox
kimmking commented on issue #4944: UI module feature discuss URL: https://github.com/apache/incubator-shardingsphere/issues/4944#issuecomment-604178648 Can you try a go, submit several PRs to make it better? This is an

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4911: translatedocker-compos.md document to chinese

2020-03-25 Thread GitBox
kimmking commented on a change in pull request #4911: translatedocker-compos.md document to chinese URL: https://github.com/apache/incubator-shardingsphere/pull/4911#discussion_r398302474 ## File path: examples/docker/docker-compose-zh.md ## @@ -0,0 +1,18 @@ +##

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4911: translatedocker-compos.md document to chinese

2020-03-25 Thread GitBox
kimmking commented on a change in pull request #4911: translatedocker-compos.md document to chinese URL: https://github.com/apache/incubator-shardingsphere/pull/4911#discussion_r398303282 ## File path: examples/docker/docker-compose-zh.md ## @@ -0,0 +1,18 @@ +##

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4911: translatedocker-compos.md document to chinese

2020-03-25 Thread GitBox
kimmking commented on a change in pull request #4911: translatedocker-compos.md document to chinese URL: https://github.com/apache/incubator-shardingsphere/pull/4911#discussion_r398302305 ## File path: examples/docker/docker-compose-zh.md ## @@ -0,0 +1,18 @@ +##

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4911: translatedocker-compos.md document to chinese

2020-03-25 Thread GitBox
kimmking commented on a change in pull request #4911: translatedocker-compos.md document to chinese URL: https://github.com/apache/incubator-shardingsphere/pull/4911#discussion_r398302001 ## File path: examples/docker/docker-compose-zh.md ## @@ -0,0 +1,18 @@ +##

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4950: Update UI documents

2020-03-25 Thread GitBox
terrymanu merged pull request #4950: Update UI documents URL: https://github.com/apache/incubator-shardingsphere/pull/4950 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-shardingsphere] terrymanu closed issue #4933: Update UI documents

2020-03-25 Thread GitBox
terrymanu closed issue #4933: Update UI documents URL: https://github.com/apache/incubator-shardingsphere/issues/4933 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-shardingsphere] fantacy2001 commented on issue #4861: two tables left join with different routing rules are not supported

2020-03-25 Thread GitBox
fantacy2001 commented on issue #4861: two tables left join with different routing rules are not supported URL: https://github.com/apache/incubator-shardingsphere/issues/4861#issuecomment-604187682 > What is your sharding rule configuration? sharding rule: in the

[GitHub] [incubator-shardingsphere] terrymanu closed issue #4946: To terryManu

2020-03-25 Thread GitBox
terrymanu closed issue #4946: To terryManu URL: https://github.com/apache/incubator-shardingsphere/issues/4946 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4916: add tableReferences in selectStatement

2020-03-25 Thread GitBox
tristaZero merged pull request #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4943: sync examples for orchestartion refactoring

2020-03-25 Thread GitBox
coveralls edited a comment on issue #4943: sync examples for orchestartion refactoring URL: https://github.com/apache/incubator-shardingsphere/pull/4943#issuecomment-603813755 ## Pull Request Test Coverage Report for [Build 10576](https://coveralls.io/builds/29606391) * **0** of

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4942: revise documents for orchestrationrefactoring

2020-03-25 Thread GitBox
coveralls edited a comment on issue #4942: revise documents for orchestrationrefactoring URL: https://github.com/apache/incubator-shardingsphere/pull/4942#issuecomment-603802980 ## Pull Request Test Coverage Report for [Build 10575](https://coveralls.io/builds/29605893) * **0** of

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4943: sync examples for orchestartion refactoring

2020-03-25 Thread GitBox
terrymanu merged pull request #4943: sync examples for orchestartion refactoring URL: https://github.com/apache/incubator-shardingsphere/pull/4943 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4942: revise documents for orchestration refactoring

2020-03-25 Thread GitBox
terrymanu merged pull request #4942: revise documents for orchestration refactoring URL: https://github.com/apache/incubator-shardingsphere/pull/4942 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4940: release cached transaction for BASE transaction type in proxy

2020-03-25 Thread GitBox
terrymanu merged pull request #4940: release cached transaction for BASE transaction type in proxy URL: https://github.com/apache/incubator-shardingsphere/pull/4940 This is an automated message from the Apache Git Service.

[GitHub] [incubator-shardingsphere] pkwenda opened a new issue #4944: UI module feature discuss

2020-03-25 Thread GitBox
pkwenda opened a new issue #4944: UI module feature discuss URL: https://github.com/apache/incubator-shardingsphere/issues/4944 ## Feature Request **For English only**, other languages will not accept. Please pay attention on issues you submitted, because we maybe need more

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4943: sync examples for orchestartion refactoring

2020-03-25 Thread GitBox
coveralls commented on issue #4943: sync examples for orchestartion refactoring URL: https://github.com/apache/incubator-shardingsphere/pull/4943#issuecomment-603813755 ## Pull Request Test Coverage Report for [Build 2236](https://coveralls.io/builds/29605451) * **0** of **0**

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4932: Add sharding scaling english documents

2020-03-25 Thread GitBox
terrymanu merged pull request #4932: Add sharding scaling english documents URL: https://github.com/apache/incubator-shardingsphere/pull/4932 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4927: sync config-shadow.yaml to sharding-distribution

2020-03-25 Thread GitBox
coveralls edited a comment on issue #4927: sync config-shadow.yaml to sharding-distribution URL: https://github.com/apache/incubator-shardingsphere/pull/4927#issuecomment-603657266 ## Pull Request Test Coverage Report for [Build 2226](https://coveralls.io/builds/29598796) * **0**

[GitHub] [incubator-shardingsphere] jingshanglu commented on a change in pull request #4916: add tableReferences in selectStatement

2020-03-25 Thread GitBox
jingshanglu commented on a change in pull request #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916#discussion_r397625686 ## File path:

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4927: sync config-shadow.yaml to sharding-distribution

2020-03-25 Thread GitBox
coveralls commented on issue #4927: sync config-shadow.yaml to sharding-distribution URL: https://github.com/apache/incubator-shardingsphere/pull/4927#issuecomment-603657266 ## Pull Request Test Coverage Report for [Build 10545](https://coveralls.io/builds/29598766) * **0** of

[GitHub] [incubator-shardingsphere] jingshanglu commented on a change in pull request #4916: add tableReferences in selectStatement

2020-03-25 Thread GitBox
jingshanglu commented on a change in pull request #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916#discussion_r397625373 ## File path:

[GitHub] [incubator-shardingsphere] jingshanglu commented on a change in pull request #4916: add tableReferences in selectStatement

2020-03-25 Thread GitBox
jingshanglu commented on a change in pull request #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916#discussion_r397625442 ## File path:

[GitHub] [incubator-shardingsphere] jingshanglu commented on a change in pull request #4916: add tableReferences in selectStatement

2020-03-25 Thread GitBox
jingshanglu commented on a change in pull request #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916#discussion_r397628231 ## File path:

[GitHub] [incubator-shardingsphere] jingshanglu commented on a change in pull request #4916: add tableReferences in selectStatement

2020-03-25 Thread GitBox
jingshanglu commented on a change in pull request #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916#discussion_r397628231 ## File path:

[GitHub] [incubator-shardingsphere] jingshanglu commented on a change in pull request #4916: add tableReferences in selectStatement

2020-03-25 Thread GitBox
jingshanglu commented on a change in pull request #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916#discussion_r397629048 ## File path:

[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #4928: Make official website prominent in Apache way.

2020-03-25 Thread GitBox
tristaZero opened a new issue #4928: Make official website prominent in Apache way. URL: https://github.com/apache/incubator-shardingsphere/issues/4928 The following todo list to make website prominent in Apache way, and also it is time to make website more friendly for users and

[GitHub] [incubator-shardingsphere] ssxlulu commented on issue #3849: Add datasources check before start scaling job

2020-03-25 Thread GitBox
ssxlulu commented on issue #3849: Add datasources check before start scaling job URL: https://github.com/apache/incubator-shardingsphere/issues/3849#issuecomment-603658407 Now, we haven't have good method for PostgreSQL's privilege check. We need replication privilege for PostgreSQL's

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4916: add tableReferences in selectStatement

2020-03-25 Thread GitBox
codecov-io edited a comment on issue #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916#issuecomment-603157625 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4916?src=pr=h1) Report > Merging

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4916: add tableReferences in selectStatement

2020-03-25 Thread GitBox
coveralls edited a comment on issue #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916#issuecomment-603160941 ## Pull Request Test Coverage Report for [Build 10546](https://coveralls.io/builds/29599123) * **0** of **62**

[GitHub] [incubator-shardingsphere] pkwenda commented on issue #4921: Is this UI module available ?

2020-03-25 Thread GitBox
pkwenda commented on issue #4921: Is this UI module available ? URL: https://github.com/apache/incubator-shardingsphere/issues/4921#issuecomment-603714874 I have a question. Why YamlTableRuleConfiguration.java not have `defaultKeyGenerator` and `defaultDatabaseStrategy` field ?

[GitHub] [incubator-shardingsphere] pkwenda commented on issue #4921: Is this UI module available ?

2020-03-25 Thread GitBox
pkwenda commented on issue #4921: Is this UI module available ? URL: https://github.com/apache/incubator-shardingsphere/issues/4921#issuecomment-603716428 I can run, and i can find info at zookeeper now ! thank you very much @SanmuWangZJU

[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request #4932: Add sharding scaling english documents

2020-03-25 Thread GitBox
KomachiSion opened a new pull request #4932: Add sharding scaling english documents URL: https://github.com/apache/incubator-shardingsphere/pull/4932 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-shardingsphere] menghaoranss opened a new issue #4933: Update UI documents

2020-03-25 Thread GitBox
menghaoranss opened a new issue #4933: Update UI documents URL: https://github.com/apache/incubator-shardingsphere/issues/4933 - [ ] 1. Add `Config Center` menu below `4.1 Sharding-UI/4.4.1 Manual` after `Build` - [ ] 2. Add `Config Center` page and add some descriptions about `Config

[GitHub] [incubator-shardingsphere] edidada commented on issue #4911: translatedocker-compos.md document to chinese

2020-03-25 Thread GitBox
edidada commented on issue #4911: translatedocker-compos.md document to chinese URL: https://github.com/apache/incubator-shardingsphere/pull/4911#issuecomment-603737780 > @edidada we should modify the request changes. @kimmking I have modify it

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4922: Test case of OrchestrationProperties and NacosProperties

2020-03-25 Thread GitBox
codecov-io edited a comment on issue #4922: Test case of OrchestrationProperties and NacosProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4922#issuecomment-603669858 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4922?src=pr=h1) Report

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4922: Test case of OrchestrationProperties and NacosProperties

2020-03-25 Thread GitBox
coveralls edited a comment on issue #4922: Test case of OrchestrationProperties and NacosProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4922#issuecomment-603671090 ## Pull Request Test Coverage Report for [Build 10559](https://coveralls.io/builds/29602216)

[GitHub] [incubator-shardingsphere] terrymanu opened a new issue #4935: Pluggable for rewrite module

2020-03-25 Thread GitBox
terrymanu opened a new issue #4935: Pluggable for rewrite module URL: https://github.com/apache/incubator-shardingsphere/issues/4935 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-shardingsphere] terrymanu closed issue #4868: Pluggable for route module

2020-03-25 Thread GitBox
terrymanu closed issue #4868: Pluggable for route module URL: https://github.com/apache/incubator-shardingsphere/issues/4868 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #4862: using "" will route to all datanode

2020-03-25 Thread GitBox
terrymanu edited a comment on issue #4862: using "" will route to all datanode URL: https://github.com/apache/incubator-shardingsphere/issues/4862#issuecomment-603712234 What is content in the class `org.apache.shardingsphere.sharding.rules.standard.SimpleHashShardingAlgorithm`?

[GitHub] [incubator-shardingsphere] ruanjiehui commented on issue #4922: Test case of OrchestrationProperties and NacosProperties

2020-03-25 Thread GitBox
ruanjiehui commented on issue #4922: Test case of OrchestrationProperties and NacosProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4922#issuecomment-603717123 When edit on github website,if I need add an empty line at tail of file,I should add two empty lines.

[GitHub] [incubator-shardingsphere] terrymanu closed issue #4660: can sharding-integration-test cover sharding-proxy ?

2020-03-25 Thread GitBox
terrymanu closed issue #4660: can sharding-integration-test cover sharding-proxy ? URL: https://github.com/apache/incubator-shardingsphere/issues/4660 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4660: can sharding-integration-test cover sharding-proxy ?

2020-03-25 Thread GitBox
terrymanu commented on issue #4660: can sharding-integration-test cover sharding-proxy ? URL: https://github.com/apache/incubator-shardingsphere/issues/4660#issuecomment-603717305 Closed because nobody interest with it for now.

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4760: Setting SQL timeout time in mybatis does not take effect after sharding- JDBC 4.0.0-RC2 is used

2020-03-25 Thread GitBox
terrymanu commented on issue #4760: Setting SQL timeout time in mybatis does not take effect after sharding- JDBC 4.0.0-RC2 is used URL: https://github.com/apache/incubator-shardingsphere/issues/4760#issuecomment-603716903 @ma1562013338 Can you provide a design? Then we can discuss

[GitHub] [incubator-shardingsphere] wuguowei19880907 commented on issue #4930: why sharding has many unsupported operation

2020-03-25 Thread GitBox
wuguowei19880907 commented on issue #4930: why sharding has many unsupported operation URL: https://github.com/apache/incubator-shardingsphere/issues/4930#issuecomment-603717708 I actually want to know why these unsupported APIs throw exceptions instead of calling native APIs to support

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4924: Test case of EtcdProperties

2020-03-25 Thread GitBox
coveralls edited a comment on issue #4924: Test case of EtcdProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4924#issuecomment-603372219 ## Pull Request Test Coverage Report for [Build 10556](https://coveralls.io/builds/29601480) * **0** of **0** changed or

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4922: Test case of OrchestrationProperties and NacosProperties

2020-03-25 Thread GitBox
coveralls edited a comment on issue #4922: Test case of OrchestrationProperties and NacosProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4922#issuecomment-603671090 ## Pull Request Test Coverage Report for [Build 2229](https://coveralls.io/builds/29601629)

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4932: Add sharding scaling english documents

2020-03-25 Thread GitBox
coveralls commented on issue #4932: Add sharding scaling english documents URL: https://github.com/apache/incubator-shardingsphere/pull/4932#issuecomment-603737119 ## Pull Request Test Coverage Report for [Build 2230](https://coveralls.io/builds/29601907) * **0** of **0** changed

[GitHub] [incubator-shardingsphere] minli04g opened a new pull request #4934: Remove Chinese in the English document. (#4913)

2020-03-25 Thread GitBox
minli04g opened a new pull request #4934: Remove Chinese in the English document. (#4913) URL: https://github.com/apache/incubator-shardingsphere/pull/4934 Fixes #4913. Changes proposed in this pull request: - Remove Chinese in the English document.

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4934: Remove Chinese in the English document. (#4913)

2020-03-25 Thread GitBox
tristaZero merged pull request #4934: Remove Chinese in the English document. (#4913) URL: https://github.com/apache/incubator-shardingsphere/pull/4934 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4934: Remove Chinese in the English document. (#4913)

2020-03-25 Thread GitBox
tristaZero commented on issue #4934: Remove Chinese in the English document. (#4913) URL: https://github.com/apache/incubator-shardingsphere/pull/4934#issuecomment-603745190 @minli04g Thanks for your contribution to the community. :-)

[GitHub] [incubator-shardingsphere] tristaZero closed issue #4913: The diagram in English document contains Chinese characters.

2020-03-25 Thread GitBox
tristaZero closed issue #4913: The diagram in English document contains Chinese characters. URL: https://github.com/apache/incubator-shardingsphere/issues/4913 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4913: The diagram in English document contains Chinese characters.

2020-03-25 Thread GitBox
tristaZero commented on issue #4913: The diagram in English document contains Chinese characters. URL: https://github.com/apache/incubator-shardingsphere/issues/4913#issuecomment-603745729 The doc was updated by #4934, and the remaining one is to update the image.

[GitHub] [incubator-shardingsphere] minli04g opened a new issue #4913: The diagram in English document contains Chinese characters.

2020-03-25 Thread GitBox
minli04g opened a new issue #4913: The diagram in English document contains Chinese characters. URL: https://github.com/apache/incubator-shardingsphere/issues/4913 ## Bug Report https://shardingsphere.apache.org/document/current/en/features/sharding/principle/rewrite/

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4922: Test case of OrchestrationProperties and NacosProperties

2020-03-25 Thread GitBox
coveralls commented on issue #4922: Test case of OrchestrationProperties and NacosProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4922#issuecomment-603671090 ## Pull Request Test Coverage Report for [Build 10547](https://coveralls.io/builds/29599464) *

[GitHub] [incubator-shardingsphere] kimmking opened a new pull request #4929: optimize schema

2020-03-25 Thread GitBox
kimmking opened a new pull request #4929: optimize schema URL: https://github.com/apache/incubator-shardingsphere/pull/4929 Changes proposed in this pull request: - optimize schema implements This is an automated

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4916: add tableReferences in selectStatement

2020-03-25 Thread GitBox
coveralls edited a comment on issue #4916: add tableReferences in selectStatement URL: https://github.com/apache/incubator-shardingsphere/pull/4916#issuecomment-603160941 ## Pull Request Test Coverage Report for [Build 10548](https://coveralls.io/builds/29599766) * **0** of **69**

[GitHub] [incubator-shardingsphere] ruanjiehui commented on issue #4922: Test case of OrchestrationProperties and NacosProperties

2020-03-25 Thread GitBox
ruanjiehui commented on issue #4922: Test case of OrchestrationProperties and NacosProperties URL: https://github.com/apache/incubator-shardingsphere/pull/4922#issuecomment-603681910 @kimmking Thank you for pointing it out,I fix them.

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4929: optimize schema

2020-03-25 Thread GitBox
coveralls commented on issue #4929: optimize schema URL: https://github.com/apache/incubator-shardingsphere/pull/4929#issuecomment-603683464 ## Pull Request Test Coverage Report for [Build 2227](https://coveralls.io/builds/29599968) * **0** of **9** **(0.0%)** changed or added

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4929: optimize schema

2020-03-25 Thread GitBox
codecov-io commented on issue #4929: optimize schema URL: https://github.com/apache/incubator-shardingsphere/pull/4929#issuecomment-603683240 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4929?src=pr=h1) Report > Merging

  1   2   >