[GitHub] [incubator-shardingsphere] shaoyifan commented on issue #3973: 4.0.0 dosen't support LocalDateTime
shaoyifan commented on issue #3973: 4.0.0 dosen't support LocalDateTime URL: https://github.com/apache/incubator-shardingsphere/issues/3973#issuecomment-574536867 > oh yes, ShardingSphere will upgrade JDK's version in 5.x, #3097 . When will 5. X be released？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl commented on issue #3973: 4.0.0 dosen't support LocalDateTime
dongzl commented on issue #3973: 4.0.0 dosen't support LocalDateTime URL: https://github.com/apache/incubator-shardingsphere/issues/3973#issuecomment-574535274 oh yes, ShardingSphere will upgrade JDK's version in 5.x, #3097 . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] shaoyifan commented on issue #3973: 4.0.0 dosen't support LocalDateTime
shaoyifan commented on issue #3973: 4.0.0 dosen't support LocalDateTime URL: https://github.com/apache/incubator-shardingsphere/issues/3973#issuecomment-574533142 > Hi @shaoyifan , ShardingSphere can work well on jdk 8, what's your problem. yes，it can works well ，but sometimes，our project some entity may use java.time.LocalDateTime instead of java.util.Date，but I found ShardingResultSet dont has any method to parse LocalDateTime ，because 4.0.0 base on java7。 LocalDateTime since 1.8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl edited a comment on issue #3973: 4.0.0 dosen't support LocalDateTime
dongzl edited a comment on issue #3973: 4.0.0 dosen't support LocalDateTime URL: https://github.com/apache/incubator-shardingsphere/issues/3973#issuecomment-574529362 Hi @shaoyifan , ShardingSphere can work well on jdk 8, what's your problem. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl commented on issue #3973: 4.0.0 dosen't support LocalDateTime
dongzl commented on issue #3973: 4.0.0 dosen't support LocalDateTime URL: https://github.com/apache/incubator-shardingsphere/issues/3973#issuecomment-574529362 Hi @shaoyifan , ShardingSphere work well on jdk 8, what's your problem. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] ette9844 opened a new issue #3987: How to handle JNDI datasource in spring namespace?
ette9844 opened a new issue #3987: How to handle JNDI datasource in spring namespace? URL: https://github.com/apache/incubator-shardingsphere/issues/3987 I understood that sharding-sphere supports JNDI datasource in spring-boot-starter. But the project I'm working on is based on spring framework. So I should handle JNDI datasource in spring namespace. How to handle JNDI datasource at spring namespace? I couldn't find about it on your documentation page. If there's no features about it, I would like to know that there's any plan to make feature of it or not. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yuxuejimo commented on issue #3930: sharding-jdbc4 scan some tables in all_tab_columns.but the current user does not have permission.then throws the Exception:Table
yuxuejimo commented on issue #3930: sharding-jdbc4 scan some tables in all_tab_columns.but the current user does not have permission.then throws the Exception:Table or view does not exist URL: https://github.com/apache/incubator-shardingsphere/issues/3930#issuecomment-574521905 The reason for this problem is that the T4CConnection in ojdbc7.jar does not implement the getSchema() method, so it scans the tables of other owners. Please show the version of ojdbc.jar used for testing. Thank you This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3969: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
terrymanu merged pull request #3969: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol URL: https://github.com/apache/incubator-shardingsphere/pull/3969 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3968: Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
terrymanu closed issue #3968: Ambiguous description of COM_STMT_EXECUTE in MySQL protocol URL: https://github.com/apache/incubator-shardingsphere/issues/3968 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] shaoyifan commented on issue #3973: 4.0.0 dosen't support LocalDateTime
shaoyifan commented on issue #3973: 4.0.0 dosen't support LocalDateTime URL: https://github.com/apache/incubator-shardingsphere/issues/3973#issuecomment-574512580 4.0.0 base on java 7， so can`t support LocalDateTime This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3986: Change directory
terrymanu merged pull request #3986: Change directory URL: https://github.com/apache/incubator-shardingsphere/pull/3986 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3986: Change directory
coveralls commented on issue #3986: Change directory URL: https://github.com/apache/incubator-shardingsphere/pull/3986#issuecomment-574501152 ## Pull Request Test Coverage Report for [Build 1378](https://coveralls.io/builds/28115591) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **65.961%** --- | Totals | [](https://coveralls.io/builds/28115591) | | :-- | --: | | Change from base [Build 687](https://coveralls.io/builds/28115398): | 0.0% | | Covered Lines: | 10813 | | Relevant Lines: | 16393 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] longjy commented on issue #3959: Get ciphertext column as a string
longjy commented on issue #3959: Get ciphertext column as a string URL: https://github.com/apache/incubator-shardingsphere/pull/3959#issuecomment-574499466 After verification, mysql is not a varchar field type, getString will not have a type exception. The Encryptor class decrypt method returns an Object type. Can the user do a type conversion here and return the expected type This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3977: The sharding-JDBC non-sharding policy, NoneShardingStrategy, does not work in yml
KomachiSion commented on issue #3977: The sharding-JDBC non-sharding policy, NoneShardingStrategy, does not work in yml URL: https://github.com/apache/incubator-shardingsphere/issues/3977#issuecomment-574496158 Why do you set sub configure for none strategy? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #3973: 4.0.0 dosen't support LocalDateTime
tuohai666 commented on issue #3973: 4.0.0 dosen't support LocalDateTime URL: https://github.com/apache/incubator-shardingsphere/issues/3973#issuecomment-574494870 Hi @shuohao, Thanks for your report. Can you answer these questions? ### Which version of ShardingSphere did you use? ### Which project did you use? Sharding-JDBC or Sharding-Proxy? ### Expected behavior ### Actual behavior ### Reason analyze (If you can) ### Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc. ### Example codes for reproduce this issue (such as a github link). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #3972: Determine if there is an encryption requirement according to all SQL tables
tristaZero edited a comment on issue #3972: Determine if there is an encryption requirement according to all SQL tables URL: https://github.com/apache/incubator-shardingsphere/pull/3972#issuecomment-574494561 @longjy Hi sir, thanks for your PR. what you modified appears reasonable, however could you add one unit test to verify our conclusion? My suggestion is to new one unit test or add test for `EncryptStatementTest` or `EncryptPreparedStatementTest`. :-) Look forward to your reply, thx. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3972: Determine if there is an encryption requirement according to all SQL tables
tristaZero commented on issue #3972: Determine if there is an encryption requirement according to all SQL tables URL: https://github.com/apache/incubator-shardingsphere/pull/3972#issuecomment-574494561 @longjy Hi sir, thanks for your PR. what you modified appears reasonable, however could you add one unit test to verify our conclusion? My suggestion is to new one unit test or add test for `EncryptStatementTest` or `EncryptPreparedStatementTest`. :-) Look forward your reply, thx. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #3922: Optimize model of ColumnMetaData
cherrylzhao commented on issue #3922: Optimize model of ColumnMetaData URL: https://github.com/apache/incubator-shardingsphere/issues/3922#issuecomment-57449 I have sent a mail to dev mailing list [ [DISCUSS] Optimize model of ColumnMetaData](https://lists.apache.org/thread.html/r17a6755569a787f34b917cd06a49895365d50c72f7c3ae6704044c76%40%3Cdev.shardingsphere.apache.org%3E) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #3986: Change directory
tristaZero opened a new pull request #3986: Change directory URL: https://github.com/apache/incubator-shardingsphere/pull/3986 #3914 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3970: Got many warn message: com.mysql.jdbc.jdbc2.optional.MysqlXAException: Undetermined error occurred in the underlying Connection
terrymanu commented on issue #3970: Got many warn message: com.mysql.jdbc.jdbc2.optional.MysqlXAException: Undetermined error occurred in the underlying Connection - check your data for consistency URL: https://github.com/apache/incubator-shardingsphere/issues/3970#issuecomment-574490484 What is your version? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3985: Merge parer branch to dev
terrymanu merged pull request #3985: Merge parer branch to dev URL: https://github.com/apache/incubator-shardingsphere/pull/3985 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas commented on issue #3856: Parse `ON DUPLICATE KEY UPDATE xxx= VALUES(xxx)` error
SteNicholas commented on issue #3856: Parse `ON DUPLICATE KEY UPDATE xxx= VALUES(xxx)` error URL: https://github.com/apache/incubator-shardingsphere/issues/3856#issuecomment-574484477 > Hi, is there any update about this issue ? @SteNicholas @terrymanu Sorry for the delay, and today I would validate the SQL. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3985: Merge parer branch to dev
coveralls commented on issue #3985: Merge parer branch to dev URL: https://github.com/apache/incubator-shardingsphere/pull/3985#issuecomment-574482690 ## Pull Request Test Coverage Report for [Build 1376](https://coveralls.io/builds/28114544) * **0** of **43** **(0.0%)** changed or added relevant lines in **9** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage decreased (**-0.2%**) to **65.961%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/visitor/SQLVisitorEngine.java](https://coveralls.io/builds/28114544/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fvisitor%2FSQLVisitorEngine.java#L42) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLParserEntry.java](https://coveralls.io/builds/28114544/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLParserEntry.java#L51) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/OracleParserEntry.java](https://coveralls.io/builds/28114544/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FOracleParserEntry.java#L51) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/PostgreSQLParserEntry.java](https://coveralls.io/builds/28114544/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FPostgreSQLParserEntry.java#L51) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-sql92/src/main/java/org/apache/shardingsphere/sql/parser/SQL92ParserEntry.java](https://coveralls.io/builds/28114544/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sql92%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FSQL92ParserEntry.java#L51) | 0 | 1 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/SQLServerParserEntry.java](https://coveralls.io/builds/28114544/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FSQLServerParserEntry.java#L51) | 0 | 1 | 0.0% | [sharding-sql-test/src/main/java/org/apache/shardingsphere/test/sql/loader/visitor/VisitorSQLCasesRegistry.java](https://coveralls.io/builds/28114544/source?filename=sharding-sql-test%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Ftest%2Fsql%2Floader%2Fvisitor%2FVisitorSQLCasesRegistry.java#L30) | 0 | 5 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/visitor/SQLVisitorFactory.java](https://coveralls.io/builds/28114544/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fvisitor%2FSQLVisitorFactory.java#L42) | 0 | 7 | 0.0% | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28114544/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L42) | 0 | 25 | 0.0% | Totals | [](https://coveralls.io/builds/28114544) | | :-- | --: | | Change from base [Build 686](https://coveralls.io/builds/28102358): | -0.2% | | Covered Lines: | 10813 | | Relevant Lines: | 16393 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] guanxiaochen commented on issue #234: Welcome to leave your company's info(欢迎使用ShardingSphere的公司在此登记)
guanxiaochen commented on issue #234: Welcome to leave your company's info(欢迎使用ShardingSphere的公司在此登记) URL: https://github.com/apache/incubator-shardingsphere/issues/234#issuecomment-574480301 会通教育科技 https://willclass.com This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] guanxiaochen edited a comment on issue #234: Welcome to leave your company's info(欢迎使用ShardingSphere的公司在此登记)
guanxiaochen edited a comment on issue #234: Welcome to leave your company's info(欢迎使用ShardingSphere的公司在此登记) URL: https://github.com/apache/incubator-shardingsphere/issues/234#issuecomment-574480301 会通教育 https://willclass.com This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] huangqinghe removed a comment on issue #3703: Could the loading default db table while application start be optimized?
huangqinghe removed a comment on issue #3703: Could the loading default db table while application start be optimized? URL: https://github.com/apache/incubator-shardingsphere/issues/3703#issuecomment-574250098 @CatDogZ How to rewrite the class "TableMetaDataInitializer"? Please give me some advice This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #3985: Merge parer branch to dev
tristaZero opened a new pull request #3985: Merge parer branch to dev URL: https://github.com/apache/incubator-shardingsphere/pull/3985 #3914 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] avalon566 merged pull request #3984: Use new sharding-core package to fix compile error
avalon566 merged pull request #3984: Use new sharding-core package to fix compile error URL: https://github.com/apache/incubator-shardingsphere/pull/3984 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request #3984: Use new sharding-core package to fixx
KomachiSion opened a new pull request #3984: Use new sharding-core package to fixx URL: https://github.com/apache/incubator-shardingsphere/pull/3984 Fixes #ISSUSE_ID. Changes proposed in this pull request: - - - This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #3959: Get ciphertext column as a string
terrymanu edited a comment on issue #3959: Get ciphertext column as a string URL: https://github.com/apache/incubator-shardingsphere/pull/3959#issuecomment-574468461 The code you modified ```java (String) mergedResult.getValue(columnIndex, String.class) ``` It is still use getString from original ResultSet. Is it correct if your type of field is BigDecimal? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3959: Get ciphertext column as a string
terrymanu commented on issue #3959: Get ciphertext column as a string URL: https://github.com/apache/incubator-shardingsphere/pull/3959#issuecomment-574468461 The code you modify ```java (String) mergedResult.getValue(columnIndex, String.class) ``` It is still use getString from original ResultSet. Is it correct if your type of field is BigDecimal? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] longjy edited a comment on issue #3959: Get ciphertext column as a string
longjy edited a comment on issue #3959: Get ciphertext column as a string
URL:
https://github.com/apache/incubator-shardingsphere/pull/3959#issuecomment-574232873
> Hi, I am still want ask the same question. I just copy my comment from
#3934
>
> I have a little confuse, why force get value from ResultSet by String type?
> I can't get the point, what is the issue in original code?
If the BigDecimal field is encrypted, the database will store string. In
general, ORM will directly get BigDecimal according to the java bean field
type. The original code may have a new BigDecimal ("ciphertext") situation and
throw an exception
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3983: check file format
terrymanu merged pull request #3983: check file format URL: https://github.com/apache/incubator-shardingsphere/pull/3983 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero closed pull request #3966: Sharding parser 5.x
tristaZero closed pull request #3966: Sharding parser 5.x URL: https://github.com/apache/incubator-shardingsphere/pull/3966 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] orangeyts commented on issue #234: Welcome to leave your company's info(欢迎使用ShardingSphere的公司在此登记)
orangeyts commented on issue #234: Welcome to leave your company's info(欢迎使用ShardingSphere的公司在此登记) URL: https://github.com/apache/incubator-shardingsphere/issues/234#issuecomment-574465229 谛达诺科技 http://www.didano.com/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] avalon566 merged pull request #3982: Upgrade to 5.0.0-RC1-SNAPSHOT and Synchronize main branch
avalon566 merged pull request #3982: Upgrade to 5.0.0-RC1-SNAPSHOT and Synchronize main branch URL: https://github.com/apache/incubator-shardingsphere/pull/3982 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl commented on issue #3852: shardingjdcb 4.0.0-rc2 cannot convert sqlserver timestamp field
dongzl commented on issue #3852: shardingjdcb 4.0.0-rc2 cannot convert sqlserver timestamp field URL: https://github.com/apache/incubator-shardingsphere/issues/3852#issuecomment-574463554 This problem has been fixed on 4.0.0-RC3 version, The 4.0.0-RC2 data masking cause this bug. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] joewee commented on issue #3856: Parse `ON DUPLICATE KEY UPDATE xxx= VALUES(xxx)` error
joewee commented on issue #3856: Parse `ON DUPLICATE KEY UPDATE xxx= VALUES(xxx)` error URL: https://github.com/apache/incubator-shardingsphere/issues/3856#issuecomment-574463572 Hi, is there any update about this issue ? @SteNicholas @terrymanu This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #3983: check file format
tristaZero opened a new pull request #3983: check file format URL: https://github.com/apache/incubator-shardingsphere/pull/3983 #3914 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request #3982: Upgrade to 5.0.0-RC1-SNAPSHOT and Synchronize main branch
KomachiSion opened a new pull request #3982: Upgrade to 5.0.0-RC1-SNAPSHOT and Synchronize main branch URL: https://github.com/apache/incubator-shardingsphere/pull/3982 Changes proposed in this pull request: - Upgrade to 5.0.0-RC1-SNAPSHOT - Synchronize main branch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-shardingsphere-benchmark] branch master updated: for performance
This is an automated email from the ASF dual-hosted git repository.
zhaoyanan pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/incubator-shardingsphere-benchmark.git
The following commit(s) were added to refs/heads/master by this push:
new 0479288 for performance
0479288 is described below
commit 0479288616807e56fe4847bd788b4dd25936e9fc
Author: nancyzrh
AuthorDate: Wed Jan 15 09:03:16 2020 +0800
for performance
---
report/jtl_json/full_route_test.json| 2 +-
report/jtl_json/master_slave_encrypt_sharding_test.json | 2 +-
report/jtl_json/master_slave_test.json | 2 +-
report/jtl_json/single_route_test.json | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/report/jtl_json/full_route_test.json
b/report/jtl_json/full_route_test.json
index 1a7f0c3..c936e95 100644
--- a/report/jtl_json/full_route_test.json
+++ b/report/jtl_json/full_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_encrypt_sharding_test.json
b/report/jtl_json/master_slave_encrypt_sharding_test.json
index f95ceb9..5d88667 100644
--- a/report/jtl_json/master_slave_encrypt_sharding_test.json
+++ b/report/jtl_json/master_slave_encrypt_sharding_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_test.json
b/report/jtl_json/master_slave_test.json
index c8f3665..76b1378 100644
--- a/report/jtl_json/master_slave_test.json
+++ b/report/jtl_json/master_slave_test.json
@@ -1 +1 @@
-{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
+{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
diff --git a/report/jtl_json/single_route_test.json
b/report/jtl_json/single_route_test.json
index 546a40e..f1f4890 100644
--- a/report/jtl_json/single_route_test.json
+++ b/report/jtl_json/single_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [], "type":
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3305: Fix bug 3303
coveralls edited a comment on issue #3305: Fix bug 3303 URL: https://github.com/apache/incubator-shardingsphere/pull/3305#issuecomment-543053363 ## Pull Request Test Coverage Report for [Build 685](https://coveralls.io/builds/26368353) * **3** of **3** **(100.0%)** changed or added relevant lines in **1** file are covered. * **118** unchanged lines in **22** files lost coverage. * Overall coverage increased (+**0.002%**) to **67.861%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/EncryptPreparedStatement.java](https://coveralls.io/builds/26368353/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FEncryptPreparedStatement.java#L300) | 1 | 42.5% | | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/MasterSlaveStatement.java](https://coveralls.io/builds/26368353/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FMasterSlaveStatement.java#L208) | 1 | 10.2% | | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingStatement.java](https://coveralls.io/builds/26368353/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FShardingStatement.java#L311) | 1 | 40.32% | | [sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/postgresql/packet/command/query/binary/bind/protocol/PostgreSQLStringBinaryProtocolValue.java](https://coveralls.io/builds/26368353/source?filename=sharding-proxy%2Fsharding-proxy-transport%2Fsharding-proxy-transport-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ftransport%2Fpostgresql%2Fpacket%2Fcommand%2Fquery%2Fbinary%2Fbind%2Fprotocol%2FPostgreSQLStringBinaryProtocolValue.java#L49) | 1 | 0.0% | | [sharding-ui/sharding-ui-backend/src/main/java/org/apache/shardingsphere/ui/security/UserAuthenticationService.java](https://coveralls.io/builds/26368353/source?filename=sharding-ui%2Fsharding-ui-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fui%2Fsecurity%2FUserAuthenticationService.java#L68) | 1 | 0.0% | | [sharding-ui/sharding-ui-backend/src/main/java/org/apache/shardingsphere/ui/util/ConfigurationYamlConverter.java](https://coveralls.io/builds/26368353/source?filename=sharding-ui%2Fsharding-ui-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fui%2Futil%2FConfigurationYamlConverter.java#L118) | 1 | 0.0% | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/StatementExecutorWrapper.java](https://coveralls.io/builds/26368353/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FStatementExecutorWrapper.java#L132) | 2 | 2.38% | | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-core/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/command/CommandExecutorTask.java](https://coveralls.io/builds/26368353/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fcommand%2FCommandExecutorTask.java#L101) | 2 | 0.0% | | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/MasterSlavePreparedStatement.java](https://coveralls.io/builds/26368353/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FMasterSlavePreparedStatement.java#L176) | 3 | 6.49% | | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/text/query/MySQLComQueryPacketExecutor.java](https://coveralls.io/builds/26368353/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Ftext%2Fquery%2FMySQLComQueryPacketExecutor.java#L123) | 3 | 0.0% | | Totals | [](https://coveralls.io/builds/26368353) | | :-- | --: | | Change from base [Build 484](https://coveralls.io/builds/26366191): | 0.002% | | Covered Lines: | 11305 | | Relevant Lines: | 16659 | --- # -
[GitHub] [incubator-shardingsphere] huangqinghe edited a comment on issue #3703: Could the loading default db table while application start be optimized?
huangqinghe edited a comment on issue #3703: Could the loading default db table while application start be optimized? URL: https://github.com/apache/incubator-shardingsphere/issues/3703#issuecomment-574250098 @CatDogZ How to rewrite the class "TableMetaDataInitializer"? Please give me some advice This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] huangqinghe commented on issue #3703: Could the loading default db table while application start be optimized?
huangqinghe commented on issue #3703: Could the loading default db table while application start be optimized? URL: https://github.com/apache/incubator-shardingsphere/issues/3703#issuecomment-574250098 How to rewrite the class "TableMetaDataInitializer"? Please give me some advice This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] zzeverglow closed issue #3852: shardingjdcb 4.0.0-rc2 cannot convert sqlserver timestamp field
zzeverglow closed issue #3852: shardingjdcb 4.0.0-rc2 cannot convert sqlserver timestamp field URL: https://github.com/apache/incubator-shardingsphere/issues/3852 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas merged pull request #3981: Recover INSERT SQL parser test cases for Oracle
SteNicholas merged pull request #3981: Recover INSERT SQL parser test cases for Oracle URL: https://github.com/apache/incubator-shardingsphere/pull/3981 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #3981: Recover INSERT SQL parser test cases for Oracle
terrymanu opened a new pull request #3981: Recover INSERT SQL parser test cases for Oracle URL: https://github.com/apache/incubator-shardingsphere/pull/3981 For #3947. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] longjy commented on issue #3959: Get ciphertext column as a string
longjy commented on issue #3959: Get ciphertext column as a string
URL:
https://github.com/apache/incubator-shardingsphere/pull/3959#issuecomment-574232873
> Hi, I am still want ask the same question. I just copy my comment from
#3934
>
> I have a little confuse, why force get value from ResultSet by String type?
> I can't get the point, what is the issue in original code?
If the BigDecimal field is encrypted, the database will store string. In
general, ORM will directly get BigDecimal according to the java bean field
type. The original code may have a new BigDecimal ("ciphertext") situation and
throw an exception
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas merged pull request #3980: Rename parser SQL test cases xml file name
SteNicholas merged pull request #3980: Rename parser SQL test cases xml file name URL: https://github.com/apache/incubator-shardingsphere/pull/3980 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #3980: Rename parser SQL test cases xml file name
terrymanu opened a new pull request #3980: Rename parser SQL test cases xml file name URL: https://github.com/apache/incubator-shardingsphere/pull/3980 For #3947. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] beijing-penguin opened a new issue #3979: make incubator-shardingsphere first initialization run faster
beijing-penguin opened a new issue #3979: make incubator-shardingsphere first initialization run faster URL: https://github.com/apache/incubator-shardingsphere/issues/3979 ## Feature Request **For English only**, other languages will not accept. Please pay attention on issues you submitted, because we maybe need more details. If no response **more than 7 days** and we cannot make decision by current information, we will **close it**. Please answer these questions before submitting your issue. Thanks! ### Is your feature request related to a problem? #3681 ### Describe the feature you would like. Using multithreading make load tablemeta faster and eliminate some duplicate loads This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yanyzy merged pull request #3978: Refactor parser test cases for table assert
yanyzy merged pull request #3978: Refactor parser test cases for table assert URL: https://github.com/apache/incubator-shardingsphere/pull/3978 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #431: refine "Finish the Release"
terrymanu merged pull request #431: refine "Finish the Release" URL: https://github.com/apache/incubator-shardingsphere-doc/pull/431 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #3978: Refactor parser test cases for table assert
terrymanu opened a new pull request #3978: Refactor parser test cases for table assert URL: https://github.com/apache/incubator-shardingsphere/pull/3978 For #3947 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #3959: Get ciphertext column as a string
terrymanu edited a comment on issue #3959: Get ciphertext column as a string URL: https://github.com/apache/incubator-shardingsphere/pull/3959#issuecomment-574212590 Hi, I am still want ask the same question. I just copy my comment from #3934 I have a little confuse, why force get value from ResultSet by String type? I can't get the point, what is the issue in original code? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3959: Get ciphertext column as a string
terrymanu commented on issue #3959: Get ciphertext column as a string URL: https://github.com/apache/incubator-shardingsphere/pull/3959#issuecomment-574212590 Hi, I am still want ask the question. I just copy my comment from #3934 I have a little confuse, why force get value from ResultSet by String type? I can't get the point, what is the issue in original code? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3976: Oracle insert statement bugfix
terrymanu merged pull request #3976: Oracle insert statement bugfix URL: https://github.com/apache/incubator-shardingsphere/pull/3976 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3962: Oracle insert statement encrypt bug of version 4.0.0
terrymanu closed issue #3962: Oracle insert statement encrypt bug of version 4.0.0 URL: https://github.com/apache/incubator-shardingsphere/issues/3962 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3975: Oracle insert statement bugfix
terrymanu merged pull request #3975: Oracle insert statement bugfix URL: https://github.com/apache/incubator-shardingsphere/pull/3975 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] devefx opened a new issue #3977: The sharding-JDBC non-sharding policy, NoneShardingStrategy, does not work in yml
devefx opened a new issue #3977: The sharding-JDBC non-sharding policy,
NoneShardingStrategy, does not work in yml
URL: https://github.com/apache/incubator-shardingsphere/issues/3977
## Bug Report
**For English only**, other languages will not accept.
Before report a bug, make sure you have:
- Searched open and closed [GitHub
issues](https://github.com/apache/incubator-shardingsphere/issues).
- Read documentation: [ShardingSphere
Doc](https://shardingsphere.apache.org/document/current/en/overview).
Please pay attention on issues you submitted, because we maybe need more
details.
If no response **more than 7 days** and we cannot reproduce it on current
information, we will **close it**.
Please answer these questions before submitting your issue. Thanks!
### Which version of ShardingSphere did you use?
4.0.0
### Which project did you use? Sharding-JDBC or Sharding-Proxy?
Sharding-JDBC
### Expected behavior
```yml
my_table:
database-strategy:
none:
any: 1
```
```java
public class YamlShardingStrategyConfiguration implements YamlConfiguration {
private YamlStandardShardingStrategyConfiguration standard;
private YamlComplexShardingStrategyConfiguration complex;
private YamlHintShardingStrategyConfiguration hint;
private YamlInlineShardingStrategyConfiguration inline;
private YamlNoneShardingStrategyConfiguration none; // no null
}
```
### Actual behavior
```java
public class YamlShardingStrategyConfiguration implements YamlConfiguration {
private YamlStandardShardingStrategyConfiguration standard;
private YamlComplexShardingStrategyConfiguration complex;
private YamlHintShardingStrategyConfiguration hint;
private YamlInlineShardingStrategyConfiguration inline;
private YamlNoneShardingStrategyConfiguration none; // is null
}
```
### Reason analyze (If you can)
`org.apache.shardingsphere.core.yaml.config.sharding.strategy.YamlNoneShardingStrategyConfiguration`
There must be a field, like `private boolean enabled;`
```yml
my_table:
database-strategy:
none:
enabled: true
```
### Steps to reproduce the behavior, such as: SQL to execute, sharding rule
configuration, when exception occur etc.
### Example codes for reproduce this issue (such as a github link).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[incubator-shardingsphere-benchmark] branch master updated: for performance
This is an automated email from the ASF dual-hosted git repository.
zhaoyanan pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/incubator-shardingsphere-benchmark.git
The following commit(s) were added to refs/heads/master by this push:
new 7bd8ff7 for performance
7bd8ff7 is described below
commit 7bd8ff786bc955c65dcd2b8d4d228fc5e1a396be
Author: nancyzrh
AuthorDate: Tue Jan 14 21:06:25 2020 +0800
for performance
---
report/jtl_json/full_route_test.json| 2 +-
report/jtl_json/master_slave_encrypt_sharding_test.json | 2 +-
report/jtl_json/master_slave_test.json | 2 +-
report/jtl_json/single_route_test.json | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/report/jtl_json/full_route_test.json
b/report/jtl_json/full_route_test.json
index 24d636a..1a7f0c3 100644
--- a/report/jtl_json/full_route_test.json
+++ b/report/jtl_json/full_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_encrypt_sharding_test.json
b/report/jtl_json/master_slave_encrypt_sharding_test.json
index 7cc5626..f95ceb9 100644
--- a/report/jtl_json/master_slave_encrypt_sharding_test.json
+++ b/report/jtl_json/master_slave_encrypt_sharding_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_test.json
b/report/jtl_json/master_slave_test.json
index b5f1fe6..c8f3665 100644
--- a/report/jtl_json/master_slave_test.json
+++ b/report/jtl_json/master_slave_test.json
@@ -1 +1 @@
-{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
+{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
diff --git a/report/jtl_json/single_route_test.json
b/report/jtl_json/single_route_test.json
index 3d954ac..546a40e 100644
--- a/report/jtl_json/single_route_test.json
+++ b/report/jtl_json/single_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [], "type":
[GitHub] [incubator-shardingsphere] SteNicholas commented on issue #3922: Optimize model of ColumnMetaData
SteNicholas commented on issue #3922: Optimize model of ColumnMetaData URL: https://github.com/apache/incubator-shardingsphere/issues/3922#issuecomment-574157270 > agree with @SteNicholas metadata should be a infrastructure service for ShardingSphere, we should provide a uniform interface for initialization, read, refreshing instead of distinguish with whether sharding or not. it seems that it will be a big refactor for sharding-jdbc & sharding-proxy. > assume that task list is as below > > * [ ] investigate the usage of current metadata, clarify the function list of metadata (SQLParse, Route,Rewrite etc) > * [ ] design a MetaData Model & MetaData Sevice, at first only consider about storing in memory > * [ ] then consider about migrating to zookeeper or other registration > > @terrymanu is it ok for that @cherrylzhao Could u please send dev email group for discussion of this problem? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas opened a new pull request #3976: Oracle insert statement bugfix
SteNicholas opened a new pull request #3976: Oracle insert statement bugfix URL: https://github.com/apache/incubator-shardingsphere/pull/3976 Fixes #3962. `InsertValuesExtractor` could extract column segements by `InsertValuesClause` rule, but oracle insert statement `insertValuesClause` lack of `columnNames` , which cause encrypt problem for extracting column segements. Changes proposed in this pull request: - Put columnNames into insertValuesClause. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas opened a new pull request #3975: Oracle insert statement bugfix
SteNicholas opened a new pull request #3975: Oracle insert statement bugfix URL: https://github.com/apache/incubator-shardingsphere/pull/3975 Fixes #3962. `InsertValuesExtractor` could extract column segements by `InsertValuesClause` rule, but oracle insert statement `insertValuesClause` lack of `columnNames` , which cause encrypt problem for extracting column segements. Changes proposed in this pull request: - Put columnNames into insertValuesClause. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas closed pull request #3974: Oracle insert statement bugfix
SteNicholas closed pull request #3974: Oracle insert statement bugfix URL: https://github.com/apache/incubator-shardingsphere/pull/3974 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] SteNicholas opened a new pull request #3974: Oracle insert statement bugfix
SteNicholas opened a new pull request #3974: Oracle insert statement bugfix URL: https://github.com/apache/incubator-shardingsphere/pull/3974 Fixes #3962. `InsertValuesExtractor` could extract column segements by `InsertValuesClause` rule, but oracle insert statement `insertValuesClause` lack of `columnNames `, which cause encrypt problem for extracting column segements. Changes proposed in this pull request: - Put `columnNames` into `insertValuesClause`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] shuohao opened a new issue #3973: 4.0.0 dosen't support LocalDateTime
shuohao opened a new issue #3973: 4.0.0 dosen't support LocalDateTime URL: https://github.com/apache/incubator-shardingsphere/issues/3973  befort 4.0.0 version like 4.0.0-RC3 it's worked well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] longjy opened a new pull request #3972: Determine if there is an encryption requirement according to all SQL tables
longjy opened a new pull request #3972: Determine if there is an encryption requirement according to all SQL tables URL: https://github.com/apache/incubator-shardingsphere/pull/3972 Only modified here, but it is not clear whether only the first table was judged for other reasons before seehttps://github.com/apache/incubator-shardingsphere/issues/3971 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #3914: Optimization for Sharing Parser with Antlr Visitor
tristaZero edited a comment on issue #3914: Optimization for Sharing Parser with Antlr Visitor URL: https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-574108748 ## Here is instruction ### Tasks 1. Add rule visitors in `MySQLVisitor.java` based on g4 files[1]. 2. Check whether rule name in g4 files is appropriate or not. 3. Add parsed integrated test for your **new main rule visitor**. ### Task details 1. Add rule visitors * Since `MySQLVisitor.java` extends `MySQLStatementBaseVisitor.java`, you should overwrite `visitRuleName(ctx)` from `MySQLStatementBaseVisitor` referring to rules in g4 files. * When adding `visitRuleName(ctx)`, you should put it below the corresponding note generally named `xxx.g4` and keep its order same with where it is in `xxx.g4` file. * What we need after parsing is those classes implement `SQLStatemnt` interface, so you should parse all necessary rules (add necessary rule visitors) making up `the main rules` in `MySQLStatement.g4`, and then fill necessary `segments` to `xxxSQLStatemnt`. 2.Check rule name * If we do not care one rule (do not add visitor for it), its name should end up with `_` in g4 file. For instance, we do not add visitor for `IDENTIFIER_` in `baseRule.g4`. * Otherwise this rule name should not contain `_` in the end. * If existing rule name does not accord with the above rules, please fix it. 3. Add parsed integrated test When you successfully add `one main rule visitor`, adding parsed integrated test for it is necessary. * Copy sql case you need from `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/sharding/` to `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/visitor/` (Please note to keep the same directory). * Copy the corresponding sql parsed result from `./incubator-shardingsphere/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sharding/` to ` ./incubator-shardingsphere/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/visitor/` (Please note to keep the same directory). * Run `org.apache.shardingsphere.sql.parser.integrate.engine.visitor.VisitorParameterizedParsingTest`. * If there is no sql case you need in `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/sharding/`, please record it to this issue[2]. P.S, my suggestion is to easily test its parsed result previously. ### Examples 1. Current functions in `org.apache.shardingsphere.sql.parser.MySQLVisitor` could provide examples for you. 2. You could learn more about the parsed integrated test from test entrance `org.apache.shardingsphere.sql.parser.integrate.engine.visitor.VisitorParameterizedParsingTest`. ### Notice 1. This guideline applies to `OracleVisitor`, `PostrgreSQLVisitor`, `SQLServerVisitor` and `SQL92Visitor` as well. [1] DALStatement.g4, DCLStatement.g4, DDLStatement.g4, DMLStatement.g4, TCLStatement.g4 and StoreProcedure.g4 [2] https://github.com/apache/incubator-shardingsphere/issues/3967 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #3914: Optimization for Sharing Parser with Antlr Visitor
tristaZero edited a comment on issue #3914: Optimization for Sharing Parser with Antlr Visitor URL: https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-574108748 ## Here is instruction ### Tasks 1. Add rule visitors in `MySQLVisitor.java` based on g4 files[1]. 2. Check whether rule name in g4 files is appropriate or not. 3. Add parsed integrated test for your **new main rule visitor**. ### Task details 1. Add rule visitors * Since `MySQLVisitor.java` extends `MySQLStatementBaseVisitor.java`, you should overwrite `visitRuleName(ctx)` from `MySQLStatementBaseVisitor` referring to rules in g4 files. * When adding `visitRuleName(ctx)`, you should put it below the corresponding note generally named `xxx.g4` and keep its order same with where it is in `xxx.g4` file. * What we need after parsing is those classes implement `SQLStatemnt` interface, so you should parse all necessary rules (add necessary rule visitors) making up `the main rules` in `MySQLStatement.g4`, and then fill necessary `segments` to `xxxSQLStatemnt`. 2.Check rule name * If we do not care one rule (do not add visitor for it), its name should end up with `_` in g4 file. For instance, we do not add visitor for `IDENTIFIER_` in `baseRule.g4`. * Otherwise this rule name should not contain `_` in the end. * If existing rule name does not accord with the above rules, please fix it. 3. Add parsed integrated test When you successfully add `one main rule visitor`, adding parsed integrated test for it is necessary. * Copy sql case you need from `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/sharding/` to `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/visitor/` (`Please note to keep the same directory`). * Copy the corresponding sql parsed result from `./incubator-shardingsphere/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sharding/` to ` ./incubator-shardingsphere/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/visitor/` (`Please note to keep the same directory`). * Run `org.apache.shardingsphere.sql.parser.integrate.engine.visitor.VisitorParameterizedParsingTest`. * If there is no sql case you need in `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/sharding/`, please record it to this issue[2]. P.S, my suggestion is to easily test its parsed result previously. ### Examples 1. Current functions in `org.apache.shardingsphere.sql.parser.MySQLVisitor` could provide examples for you. 2. You could learn more the parsed integrated test from test entrance `org.apache.shardingsphere.sql.parser.integrate.engine.visitor.VisitorParameterizedParsingTest`. ### Notice 1. This guideline applys to `OracleVisitor`, `PostrgreSQLVisitor`, `SQLServerVisitor` and `SQL92Visitor` as well. [1] DALStatement.g4, DCLStatement.g4, DDLStatement.g4, DMLStatement.g4, TCLStatement.g4 and StoreProcedure.g4 [2] https://github.com/apache/incubator-shardingsphere/issues/3967 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #3914: Optimization for Sharing Parser with Antlr Visitor
tristaZero edited a comment on issue #3914: Optimization for Sharing Parser with Antlr Visitor URL: https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-574108748 ## Here is instruction ### Tasks 1. Add rule visitors in `MySQLVisitor.java` based on g4 files[1]. 2. Check whether rule name in g4 files is appropriate or not. 3. Add parsed integrated test for your **new main rule visitor**. ### Task details 1. Add rule visitors 1.1 Since `MySQLVisitor.java` extends `MySQLStatementBaseVisitor.java`, you should overwrite `visitRuleName(ctx)` from `MySQLStatementBaseVisitor` referring to rules in g4 files. 1.2 When adding `visitRuleName(ctx)`, you should put it below the corresponding note generally named `xxx.g4` and keep its order same with where it is in `xxx.g4` file. 1.3 What we need after parsing is those classes implement `SQLStatemnt` interface, so you should parse all necessary rules (add necessary rule visitors) making up `the main rules` in `MySQLStatement.g4`, and then fill necessary `segments` to `xxxSQLStatemnt`. 2.Check rule name 2.1 If we do not care one rule (do not add visitor for it), its name should end up with `_` in g4 file. For instance, we do not add visitor for `IDENTIFIER_` in `baseRule.g4`. 2.2 Otherwise this rule name should not contain `_` in the end. 2.3 If existing rule name does not accord with the above rules, please fix it. 3. Add parsed integrated test When you successfully add `one main rule visitor`, adding parsed integrated test for it is necessary. 3.1 Copy sql case you need from `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/sharding/` to `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/visitor/` (`Please note to keep the same directory`). 3.2 Copy the corresponding sql parsed result from `./incubator-shardingsphere/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sharding/` to ` ./incubator-shardingsphere/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/visitor/` (`Please note to keep the same directory`). 3.3 Run `org.apache.shardingsphere.sql.parser.integrate.engine.visitor.VisitorParameterizedParsingTest`. 3.4 If there is no sql case you need in `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/sharding/`, please record it to this issue[2]. P.S, my suggestion is to easily test its parsed result previously. ### Examples 1. Current functions in `org.apache.shardingsphere.sql.parser.MySQLVisitor` could provide examples for you. 2. You could learn more the parsed integrated test from test entrance `org.apache.shardingsphere.sql.parser.integrate.engine.visitor.VisitorParameterizedParsingTest`. ### Notice 1. This guideline applys to `OracleVisitor`, `PostrgreSQLVisitor`, `SQLServerVisitor` and `SQL92Visitor` as well. [1] DALStatement.g4, DCLStatement.g4, DDLStatement.g4, DMLStatement.g4, TCLStatement.g4 and StoreProcedure.g4 [2] https://github.com/apache/incubator-shardingsphere/issues/3967 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #3914: Optimization for Sharing Parser with Antlr Visitor
tristaZero edited a comment on issue #3914: Optimization for Sharing Parser with Antlr Visitor URL: https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-574108748 ## Here is instruction ### Tasks 1. Add rule visitors in `MySQLVisitor.java` based on g4 files[1]. 2. Check whether rule name in g4 files is appropriate or not. 3. Add parsed integrated test for your **new main rule visitor**. ### Task details 1. Add rule visitors 1.1 Since `MySQLVisitor.java` extends `MySQLStatementBaseVisitor.java`, you should overwrite `visitRuleName(ctx)` from `MySQLStatementBaseVisitor` referring to rules in g4 files. 1.2 When adding `visitRuleName(ctx)`, you should put it below the corresponding note generally named `xxx.g4` and keep its order same with where it is in `xxx.g4` file. 1.3 What we need after parsing is those classes implement `SQLStatemnt` interface, so you should parse all necessary rules (add necessary rule visitors) making up `the main rules` in `MySQLStatement.g4`, and then fill necessary `segments` to `xxxSQLStatemnt`. 2.Check rule name 2.1 If we do not care one rule (do not add visitor for it), its name should end up with `_` in g4 file. For instance, we do not add visitor for `IDENTIFIER_` in `baseRule.g4`. 2.2 Otherwise this rule name should not contain `_` in the end. 2.3 If existing rule name does not accord with the above rules, please fix it. 3. Add parsed integrated test When you successfully add `one main rule visitor`, adding parsed integrated test for it is necessary. 3.1 Copy sql case you need from `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/sharding/` to `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/visitor/` (`Please note to keep the same directory`). 3.2 Copy the corresponding sql parsed result from `./incubator-shardingsphere/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sharding/` to ` ./incubator-shardingsphere/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/visitor/` (`Please note to keep the same directory`). 3.3 Run `org.apache.shardingsphere.sql.parser.integrate.engine.visitor.VisitorParameterizedParsingTest`. 3.4 If there is no sql case you need in `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/sharding/`, please record it to this issue[2]. P.S, my suggestion is to easily test its parsed result previously. ### Examples 1. Current functions in `org.apache.shardingsphere.sql.parser.MySQLVisitor` could provide examples for you. 2. You could learn more the parsed integrated test from test entrance `org.apache.shardingsphere.sql.parser.integrate.engine.visitor.VisitorParameterizedParsingTest`. ### Notice 1. This guideline applys to `OracleVisitor`, `PostrgreSQLVisitor`, `SQLServerVisitor` and `SQL92Visitor` as well. [1] DALStatement.g4, DCLStatement.g4, DDLStatement.g4, DMLStatement.g4, TCLStatement.g4 and StoreProcedure.g4 [2] https://github.com/apache/incubator-shardingsphere/issues/3967 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3914: Optimization for Sharing Parser with Antlr Visitor
tristaZero commented on issue #3914: Optimization for Sharing Parser with Antlr Visitor URL: https://github.com/apache/incubator-shardingsphere/issues/3914#issuecomment-574108748 ## Here is instruction ### Tasks: 1. Add rule visitors in `MySQLVisitor.java` based on g4 files[1]. 2. Check whether rule name in g4 files is appropriate or not. 3. Add parsed integrated test for your **new main rule visitor**. ### Task detail: 1. Add rule visitors 1.1 Since `MySQLVisitor.java` extends `MySQLStatementBaseVisitor.java`, you should overwrite `visitRuleName(ctx)` from `MySQLStatementBaseVisitor` referring to rules in g4 files. 1.2 When adding `visitRuleName(ctx)`, you should put it below the corresponding note generally named `xxx.g4` and keep its order same with where it is in `xxx.g4` file. 1.3 What we need after parsing is those classes implement `SQLStatemnt` interface, so you should parse all necessary rules (add necessary rule visitors) making up `the main rules` in `MySQLStatement.g4`, and then fill necessary `segments` to `xxxSQLStatemnt`. 2.Check rule name 2.1 If we do not care one rule (do not add visitor for it), its name should end up with `_` in g4 file. For instance, we do not add visitor for `IDENTIFIER_` in `baseRule.g4`. 2.2 Otherwise this rule name should not contain `_` in the end. 2.3 If existing rule name does not accord with the above rules, please fix it. 3. Add parsed integrated test When you successfully add `one main rule visitor`, adding parsed integrated test for it is necessary. 3.1 Copy sql case you need from `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/sharding/` to `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/visitor/` (`Please note to keep the same directory`). 3.2 Copy the corresponding sql parsed result from `./incubator-shardingsphere/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sharding/` to ` ./incubator-shardingsphere/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/visitor/` (`Please note to keep the same directory`). 3.3 Run `org.apache.shardingsphere.sql.parser.integrate.engine.visitor.VisitorParameterizedParsingTest`. 3.4 If there is no sql case you need in `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/sharding/`, please record it to this issue[2]. P.S, my suggestion is to easily test its parsed result previously. ### Examples 1. Current functions in `org.apache.shardingsphere.sql.parser.MySQLVisitor` could provide examples for you. 2. You could learn more the parsed integrated test from test entrance `org.apache.shardingsphere.sql.parser.integrate.engine.visitor.VisitorParameterizedParsingTest`. ### Notice 1. This guideline applys to `OracleVisitor`, `PostrgreSQLVisitor`, `SQLServerVisitor` and `SQL92Visitor` as well. [1] DALStatement.g4, DCLStatement.g4, DDLStatement.g4, DMLStatement.g4, TCLStatement.g4 and StoreProcedure.g4 [2] https://github.com/apache/incubator-shardingsphere/issues/3967 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] longjy commented on issue #3971: Why does the encrypted table only judge the first one, maybe left join encrypt table, and then judge that there is no encrypted tab
longjy commented on issue #3971: Why does the encrypted table only judge the first one, maybe left join encrypt table, and then judge that there is no encrypted table URL: https://github.com/apache/incubator-shardingsphere/issues/3971#issuecomment-574097667 sqlStatementContext.getTablesContext().getSingleTableName() maybe return non-encrypted table This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] longjy opened a new issue #3971: Why does the encrypted table only judge the first one, maybe left join encrypt table, and then judge that there is no encrypted tab
longjy opened a new issue #3971: Why does the encrypted table only judge the
first one, maybe left join encrypt table, and then judge that there is no
encrypted table
URL: https://github.com/apache/incubator-shardingsphere/issues/3971
org.apache.shardingsphere.encrypt.rewrite.token.generator.impl.EncryptProjectionTokenGenerator#generateSQLTokens
@Override
public Collection generateSQLTokens(final
SQLStatementContext sqlStatementContext) {
Collection result = new LinkedList<>();
Optional selectItemsSegment =
sqlStatementContext.getSqlStatement().findSQLSegment(SelectItemsSegment.class);
Preconditions.checkState(selectItemsSegment.isPresent());
String tableName =
sqlStatementContext.getTablesContext().getSingleTableName();
Optional encryptTable =
getEncryptRule().findEncryptTable(tableName);
if (!encryptTable.isPresent()) {
return Collections.emptyList();
}
for (SelectItemSegment each :
selectItemsSegment.get().getSelectItems()) {
if (isEncryptLogicColumn(each, encryptTable.get())) {
result.add(generateSQLToken((ColumnSelectItemSegment) each,
tableName));
}
}
return result;
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] longzhihun opened a new issue #3970: Got many warn message: com.mysql.jdbc.jdbc2.optional.MysqlXAException: Undetermined error occurred in the underlying Connection
longzhihun opened a new issue #3970: Got many warn message: com.mysql.jdbc.jdbc2.optional.MysqlXAException: Undetermined error occurred in the underlying Connection - check your data for consistency URL: https://github.com/apache/incubator-shardingsphere/issues/3970 I get many warn messages when i running sharding proxy standalone, message information: > com.mysql.jdbc.jdbc2.optional.MysqlXAException: Undetermined error occurred in the underlying Connection - check your data for consistency at com.mysql.jdbc.jdbc2.optional.MysqlXAConnection.mapXAExceptionFromSQLException(MysqlXAConnection.java:586) at com.mysql.jdbc.jdbc2.optional.MysqlXAConnection.recover(MysqlXAConnection.java:316) at com.mysql.jdbc.jdbc2.optional.SuspendableXAConnection.recover(SuspendableXAConnection.java:155) at com.atomikos.datasource.xa.RecoveryScan.recoverXids(RecoveryScan.java:32) at com.atomikos.recovery.xa.XaResourceRecoveryManager.retrievePreparedXidsFromXaResource(XaResourceRecoveryManager.java:158) at com.atomikos.recovery.xa.XaResourceRecoveryManager.recover(XaResourceRecoveryManager.java:67) at com.atomikos.datasource.xa.XATransactionalResource.recover(XATransactionalResource.java:449) at com.atomikos.icatch.imp.TransactionServiceImp.performRecovery(TransactionServiceImp.java:490) at com.atomikos.icatch.imp.TransactionServiceImp.access$000(TransactionServiceImp.java:56) at com.atomikos.icatch.imp.TransactionServiceImp$1.alarm(TransactionServiceImp.java:471) at com.atomikos.timing.PooledAlarmTimer.notifyListeners(PooledAlarmTimer.java:95) at com.atomikos.timing.PooledAlarmTimer.run(PooledAlarmTimer.java:82) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:748) Caused by: com.mysql.jdbc.exceptions.jdbc4.CommunicationsException: Communications link failure at sun.reflect.GeneratedConstructorAccessor32.newInstance(Unknown Source) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at com.mysql.jdbc.Util.handleNewInstance(Util.java:425) at com.mysql.jdbc.SQLError.createCommunicationsException(SQLError.java:990) at com.mysql.jdbc.MysqlIO.send(MysqlIO.java:3751) at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2512) at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2683) at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2491) at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2449) at com.mysql.jdbc.StatementImpl.executeQuery(StatementImpl.java:1381) at com.mysql.jdbc.jdbc2.optional.MysqlXAConnection.recover(MysqlXAConnection.java:295) ... 13 common frames omitted Caused by: java.net.SocketException: Broken pipe (Write failed) at java.net.SocketOutputStream.socketWrite0(Native Method) at java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:111) at java.net.SocketOutputStream.write(SocketOutputStream.java:155) at java.io.BufferedOutputStream.flushBuffer(BufferedOutputStream.java:82) at java.io.BufferedOutputStream.flush(BufferedOutputStream.java:140) at com.mysql.jdbc.MysqlIO.send(MysqlIO.java:3733) ... 19 common frames omitted What're the meanings of the warning messages. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 opened a new pull request #3969: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
tuohai666 opened a new pull request #3969: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol URL: https://github.com/apache/incubator-shardingsphere/pull/3969 Fixes #3968. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 opened a new issue #3968: Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
tuohai666 opened a new issue #3968: Ambiguous description of COM_STMT_EXECUTE in MySQL protocol URL: https://github.com/apache/incubator-shardingsphere/issues/3968 The description of COM_STMT_EXECUTE command like this:  What if the **num-params** equals 0? Implementation of Connector/J like this:  While Implementation of sysbench like this:  The former have 1 more byte than latter:  Sharding-Proxy's command handler only support Connector/J's implementation for now, so access sysbench will be failed. We need to support all two implementations. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #3967: More parsed integrated tests are needed.
tristaZero opened a new issue #3967: More parsed integrated tests are needed. URL: https://github.com/apache/incubator-shardingsphere/issues/3967 We found there should be more parsed integrated tests along with refacting sharding parser. Here is the list of them, **DAL** - [ ] Show table status `from sharding_db` `like t_order`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #3966: Sharding parser 5.x
tristaZero opened a new pull request #3966: Sharding parser 5.x URL: https://github.com/apache/incubator-shardingsphere/pull/3966 #3914 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
