[GitHub] [incubator-shardingsphere] betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements
betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521883965 OK. I understand what you said. The current situation is : - The highest Openstracing version supported by Skywalking is 0.30.0 - The lowest Openstracing version supported by jaeger is 0.31.0 - There is no directy support from Zipkin,but I seems like 0.31.0 will by supported by Changing some code from Brave. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements
betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521611015 There is no 'ActiveSpan' in io.opentracing:0.31.0. The shardingsphere where throw an Exception because we use that with io.opentracing:0.30.0 in our dev version. Like below: `java.lang.NoClassDefFoundError: io/opentracing/ActiveSpan` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements
betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521565698 @tuohai666 I tested it for SkyWalking with sharding-jdbc and sharding-proxy. But the Zipkin client Brave does not have default implements for Opentracing. I have try my hard to convert brave to Opentracing, but still have some methods can not convert success.I have change nothing in using Opentracing,just provide a SPI for getting a Opentracing Tracer. Do you have any suggestions for me? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements
betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521160526 Not yet. I just have tested success for unit tests. I will test that later. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements
betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-520160038 should I add SkywalkingTracer as default implement? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements
betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-520152044 I would like try to do this in a few days. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
