[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5054: BugFix: x-le tag format in GraphQL plugin

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5054: URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&el=h1) Report > Merging [#5054](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&e

[GitHub] [skywalking] EvanLjp commented on a change in pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
EvanLjp commented on a change in pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#discussion_r451276365 ## File path: oap-server/server-configuration/configuration-configmap/src/main/java/org/apache/skywalking/oap/server/configuration/configmap/ConfigurationConf

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5054: BugFix: x-le tag format in GraphQL plugin

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5054: URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&el=h1) Report > Merging [#5054](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5054: BugFix: x-le tag format in GraphQL plugin

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5054: URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&el=h1) Report > Merging [#5054](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5054: BugFix: x-le tag format in GraphQL plugin

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5054: URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&el=h1) Report > Merging [#5054](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5054: BugFix: x-le tag format in GraphQL plugin

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5054: URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&el=h1) Report > Merging [#5054](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5054: BugFix: x-le tag format in GraphQL plugin

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5054: URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&el=h1) Report > Merging [#5054](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5054: BugFix: x-le tag format in GraphQL plugin

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5054: URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&el=h1) Report > Merging [#5054](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5054: BugFix: x-le tag format in GraphQL plugin

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5054: URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&el=h1) Report > Merging [#5054](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5054: BugFix: x-le tag format in GraphQL plugin

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5054: URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&el=h1) Report > Merging [#5054](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5054: BugFix: x-le tag format in GraphQL plugin

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5054: URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&el=h1) Report > Merging [#5054](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5054: BugFix: x-le tag format in GraphQL plugin

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5054: URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&el=h1) Report > Merging [#5054](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5054: BugFix: x-le tag format in GraphQL plugin

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5054: URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&el=h1) Report > Merging [#5054](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5054: BugFix: x-le tag format in GraphQL plugin

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5054: URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&el=h1) Report > Merging [#5054](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5054: BugFix: x-le tag format in GraphQL plugin

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5054: URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&el=h1) Report > Merging [#5054](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5054: BugFix: x-le tag format in GraphQL plugin

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5054: URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5054: BugFix: x-le tag format in GraphQL plugin

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5054: URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5054: BugFix: x-le tag format in GraphQL plugin

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5054: URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&el=h1) Report > Merging [#5054](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&e

[GitHub] [skywalking] codecov[bot] commented on pull request #5054: BugFix: x-le tag format in GraphQL plugin

2020-07-07 Thread GitBox
codecov[bot] commented on pull request #5054: URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&el=h1) Report > Merging [#5054](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr&el=desc)

[GitHub] [skywalking] kezhenxu94 opened a new pull request #5054: BugFix: x-le tag format in GraphQL plugin

2020-07-07 Thread GitBox
kezhenxu94 opened a new pull request #5054: URL: https://github.com/apache/skywalking/pull/5054 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance - Related iss

[GitHub] [skywalking] kangswx opened a new issue #5053: After 12:00 p.m., data writing to elasticsearch failed

2020-07-07 Thread GitBox
kangswx opened a new issue #5053: URL: https://github.com/apache/skywalking/issues/5053 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improve

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5030: support Graphql Logic endpoint

2020-07-07 Thread GitBox
wu-sheng commented on a change in pull request #5030: URL: https://github.com/apache/skywalking/pull/5030#discussion_r451269460 ## File path: test/plugin/scenarios/graphql-9.x-scenario/config/expectedData.yaml ## @@ -0,0 +1,92 @@ +# Licensed to the Apache Software Foundation (A

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5030: support Graphql Logic endpoint

2020-07-07 Thread GitBox
kezhenxu94 commented on a change in pull request #5030: URL: https://github.com/apache/skywalking/pull/5030#discussion_r451265299 ## File path: test/plugin/scenarios/graphql-9.x-scenario/config/expectedData.yaml ## @@ -0,0 +1,92 @@ +# Licensed to the Apache Software Foundation

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5030: support Graphql Logic endpoint

2020-07-07 Thread GitBox
kezhenxu94 commented on a change in pull request #5030: URL: https://github.com/apache/skywalking/pull/5030#discussion_r451264775 ## File path: test/plugin/scenarios/graphql-9.x-scenario/config/expectedData.yaml ## @@ -0,0 +1,92 @@ +# Licensed to the Apache Software Foundation

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5030: support Graphql Logic endpoint

2020-07-07 Thread GitBox
wu-sheng commented on a change in pull request #5030: URL: https://github.com/apache/skywalking/pull/5030#discussion_r451259451 ## File path: test/plugin/scenarios/graphql-9.x-scenario/config/expectedData.yaml ## @@ -0,0 +1,92 @@ +# Licensed to the Apache Software Foundation (A

[GitHub] [skywalking] snpcp commented on issue #5052: skywalking-webapp shows that the call duration of the trace is incorrect

2020-07-07 Thread GitBox
snpcp commented on issue #5052: URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655257930 Thanks your help me, The issue is cause by children span time must be greater than parent span time. I'm a beginner, I'm sorry to bother you. Thanks again for your help. --

[GitHub] [skywalking] wu-sheng edited a comment on issue #5052: skywalking-webapp shows that the call duration of the trace is incorrect

2020-07-07 Thread GitBox
wu-sheng edited a comment on issue #5052: URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655255387 Children span start time is before the parent start time, which could only be caused by the target app OS clock issue. ---

[GitHub] [skywalking] wu-sheng commented on issue #5052: skywalking-webapp shows that the call duration of the trace is incorrect

2020-07-07 Thread GitBox
wu-sheng commented on issue #5052: URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655255387 Children span end time is before the parent start time, which could only be caused by the target app OS clock issue.

[GitHub] [skywalking] snpcp commented on issue #5052: skywalking-webapp shows that the call duration of the trace is incorrect

2020-07-07 Thread GitBox
snpcp commented on issue #5052: URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655255193 This is a correct request, but still has the 90s problem. ``` JSON { "data": { "trace": { "spans": [ { "traceId": "1594177138929.157

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5030: support Graphql Logic endpoint

2020-07-07 Thread GitBox
kezhenxu94 commented on a change in pull request #5030: URL: https://github.com/apache/skywalking/pull/5030#discussion_r451256316 ## File path: apm-sniffer/apm-sdk-plugin/graphql-plugin/graphql-9.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/graphql/v9/GraphqlInterceptor.jav

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5030: support Graphql Logic endpoint

2020-07-07 Thread GitBox
kezhenxu94 commented on a change in pull request #5030: URL: https://github.com/apache/skywalking/pull/5030#discussion_r451256030 ## File path: test/plugin/scenarios/graphql-9.x-scenario/config/expectedData.yaml ## @@ -0,0 +1,92 @@ +# Licensed to the Apache Software Foundation

[GitHub] [skywalking] snpcp commented on issue #5052: skywalking-webapp shows that the call duration of the trace is incorrect

2020-07-07 Thread GitBox
snpcp commented on issue #5052: URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655254743 This is my request and response data. Why is there an error? Shouldn't our concern be that the data doesn't show up correctly. -

[GitHub] [skywalking] snpcp commented on issue #5052: skywalking-webapp shows that the call duration of the trace is incorrect

2020-07-07 Thread GitBox
snpcp commented on issue #5052: URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655254468 ![image](https://user-images.githubusercontent.com/47714378/86870470-07ed1380-c10b-11ea-9eed-9c77221c13cc.png)

[GitHub] [skywalking] wu-sheng commented on issue #5052: skywalking-webapp shows that the call duration of the trace is incorrect

2020-07-07 Thread GitBox
wu-sheng commented on issue #5052: URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655254373 ``` "startTime": 1594174262602, "endTime": 1594174174466, ``` You have data incorrectly. And this could be identified by yourself. --

[GitHub] [skywalking] snpcp commented on issue #5052: skywalking-webapp shows that the call duration of the trace is incorrect

2020-07-07 Thread GitBox
snpcp commented on issue #5052: URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655253717 Why did you close this issue? I have made it very clear that my OSS is ok This is an automated message from the Apac

[GitHub] [skywalking] snpcp commented on issue #5052: skywalking-webapp shows that the call duration of the trace is incorrect

2020-07-07 Thread GitBox
snpcp commented on issue #5052: URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655253129 This is my normal data, you see no more data inversion. ![image](https://user-images.githubusercontent.com/47714378/86870078-5221c500-c10a-11ea-92b0-d78be055e804.png) --

[GitHub] [skywalking] wu-sheng commented on issue #5052: skywalking-webapp shows that the call duration of the trace is incorrect

2020-07-07 Thread GitBox
wu-sheng commented on issue #5052: URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655253336 Please don't overload the OSS community with the issue you could check. We just help, rather than service. This

[GitHub] [skywalking] wu-sheng closed issue #5052: skywalking-webapp shows that the call duration of the trace is incorrect

2020-07-07 Thread GitBox
wu-sheng closed issue #5052: URL: https://github.com/apache/skywalking/issues/5052 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [skywalking] wu-sheng commented on issue #5052: skywalking-webapp shows that the call duration of the trace is incorrect

2020-07-07 Thread GitBox
wu-sheng commented on issue #5052: URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655252998 Look these two ``` 1594174262602 1594174174466 ``` You definitely are facing some OS clock differences. All the data get from your post. Please verify it more c

[GitHub] [skywalking] snpcp commented on issue #5052: skywalking-webapp shows that the call duration of the trace is incorrect

2020-07-07 Thread GitBox
snpcp commented on issue #5052: URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655251873 I slept in the my code for 10 seconds, The reason is that I want to check whether the 90s problem is caused by my duration is too small. ---

[GitHub] [skywalking] wu-sheng commented on issue #5052: skywalking-webapp shows that the call duration of the trace is incorrect

2020-07-07 Thread GitBox
wu-sheng commented on issue #5052: URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655250944 I found these two timestamp in your span ``` 1594174262602 1594174272610 ``` The difference is 10008ms, what is the issue?

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report > Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&e

[GitHub] [skywalking] snpcp commented on issue #5052: skywalking-webapp shows that the call duration of the trace is incorrect

2020-07-07 Thread GitBox
snpcp commented on issue #5052: URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655249110 The first line. ![image](https://user-images.githubusercontent.com/47714378/86868973-4a612100-c108-11ea-848a-5e5624c964c4.png) The second line. ![image](https://user-im

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report > Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&e

[GitHub] [skywalking] snpcp commented on issue #5052: skywalking-webapp shows that the call duration of the trace is incorrect

2020-07-07 Thread GitBox
snpcp commented on issue #5052: URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655248138 I'll make sure that's okay, you can look at the data That I've provided, and when the data goes into Skywalking, What we should care about is the data itself. Normally, the f

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
kezhenxu94 commented on a change in pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#discussion_r451248736 ## File path: oap-server/server-configuration/configuration-configmap/src/main/java/org/apache/skywalking/oap/server/configuration/configmap/ConfigurationC

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report > Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report > Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report > Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report > Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&e

[GitHub] [skywalking] wu-sheng commented on issue #5052: skywalking-webapp shows that the call duration of the trace is incorrect

2020-07-07 Thread GitBox
wu-sheng commented on issue #5052: URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655246382 What do you mean reversed? Have you checked your local env? Are ATG and User Servica Name deployed on different VMs? Do they have OS clock difference? --

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report > Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report > Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&e

[GitHub] [skywalking] snpcp commented on issue #5052: skywalking-webapp shows that the call duration of the trace is incorrect

2020-07-07 Thread GitBox
snpcp commented on issue #5052: URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655245709 There is another issue, TotalDuration's statistics seem to be reversed. ![image](https://user-images.githubusercontent.com/47714378/86868127-bb073e00-c106-11ea-9557-ac8f758b2521.p

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report > Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report > Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report > Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report > Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&e

[GitHub] [skywalking] wu-sheng commented on issue #5052: skywalking-webapp shows that the call duration of the trace is incorrect

2020-07-07 Thread GitBox
wu-sheng commented on issue #5052: URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655244891 @Fine0830 Could you take a look about this data visualization? This is an automated message from the Apache Git S

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report > Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&e

[GitHub] [skywalking] snpcp commented on issue #5052: skywalking-webapp shows that the call duration of the trace is incorrect

2020-07-07 Thread GitBox
snpcp commented on issue #5052: URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655244569 You can see that the call time is 90s instead of 10008ms. This is an automated message from the Apache Git Service.

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report > Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&e

[GitHub] [skywalking] snpcp commented on issue #5052: skywalking-webapp shows that the call duration of the trace is incorrect

2020-07-07 Thread GitBox
snpcp commented on issue #5052: URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655244331 ![image](https://user-images.githubusercontent.com/47714378/86867907-416f5000-c106-11ea-9185-230d727709c6.png)

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] snpcp opened a new issue #5052: skywalking-webapp shows that the call duration of the trace is incorrect

2020-07-07 Thread GitBox
snpcp opened a new issue #5052: URL: https://github.com/apache/skywalking/issues/5052 The maximum length of the call should be 10007ms, but 90s is instead, so the call length shown is incorrect. The response data of the trace obtained can be viewed through the network. This is

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5046: Add health checker module

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&el=h1) Report > Merging [#5046](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr&e

[skywalking] branch health-checker updated (5f97e24 -> 8d394cf)

2020-07-07 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch health-checker in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 5f97e24 Merge branch 'master' into health-checker add 42c8ceb add golang component id (#5050)

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5046: Add health checker module

2020-07-07 Thread GitBox
kezhenxu94 commented on a change in pull request #5046: URL: https://github.com/apache/skywalking/pull/5046#discussion_r451242194 ## File path: oap-server/server-storage-plugin/storage-jdbc-hikaricp-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/jdbc/h2/H2Storage

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] wu-sheng commented on issue #5051: 使用skywalking-webapp显示trace的调用时长不正确

2020-07-07 Thread GitBox
wu-sheng commented on issue #5051: URL: https://github.com/apache/skywalking/issues/5051#issuecomment-655236464 English only. And please provide well-formated information. This is an automated message from the Apache Git Serv

[GitHub] [skywalking] wu-sheng closed issue #5051: 使用skywalking-webapp显示trace的调用时长不正确

2020-07-07 Thread GitBox
wu-sheng closed issue #5051: URL: https://github.com/apache/skywalking/issues/5051 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] snpcp opened a new issue #5051: 使用skywalking-webapp显示trace的调用时长不正确

2020-07-07 Thread GitBox
snpcp opened a new issue #5051: URL: https://github.com/apache/skywalking/issues/5051 调用时长的时长图像应该显示最大为10007ms,但是却显示成为了90s,导致看到的调用时长显示不正确。 通过network查看到获取到的trace的响应数据。 { "data": { "trace": { "spans": [ { "traceId": "1594172755623.633498320.366

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] EvanLjp commented on a change in pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
EvanLjp commented on a change in pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#discussion_r451234306 ## File path: oap-server/server-configuration/configuration-configmap/src/main/java/org/apache/skywalking/oap/server/configuration/configmap/ConfigurationConf

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&el=h1) Report > Merging [#4959](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr&e

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
wu-sheng commented on a change in pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#discussion_r451231254 ## File path: oap-server/server-configuration/configuration-configmap/src/main/java/org/apache/skywalking/oap/server/configuration/configmap/ConfigurationCon

[GitHub] [skywalking] EvanLjp commented on a change in pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
EvanLjp commented on a change in pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#discussion_r451227086 ## File path: oap-server/server-configuration/configuration-configmap/src/main/java/org/apache/skywalking/oap/server/configuration/configmap/ConfigurationConf

[GitHub] [skywalking] EvanLjp commented on a change in pull request #4959: Configmap configuration

2020-07-07 Thread GitBox
EvanLjp commented on a change in pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#discussion_r451227147 ## File path: docs/en/setup/backend/dynamic-config.md ## @@ -102,3 +102,16 @@ configuration: appId: ${SW_CONFIG_APOLLO_APP_ID:skywalking} per

[GitHub] [skywalking-rocketbot-ui] arugal commented on pull request #325: add go component logo

2020-07-07 Thread GitBox
arugal commented on pull request #325: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/325#issuecomment-655215589 > The logos for Gear and Gin are rather big, both in file size and image size, we don't need that large image as logo I will try to compress the image size

[skywalking] branch master updated: add golang component id (#5050)

2020-07-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 42c8ceb add golang component id (#5050) 42

[GitHub] [skywalking] wu-sheng merged pull request #5050: add golang component id

2020-07-07 Thread GitBox
wu-sheng merged pull request #5050: URL: https://github.com/apache/skywalking/pull/5050 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5050: add golang component id

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5050: URL: https://github.com/apache/skywalking/pull/5050#issuecomment-654962810 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5050?src=pr&el=h1) Report > Merging [#5050](https://codecov.io/gh/apache/skywalking/pull/5050?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5050: add golang component id

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5050: URL: https://github.com/apache/skywalking/pull/5050#issuecomment-654962810 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5050?src=pr&el=h1) Report > Merging [#5050](https://codecov.io/gh/apache/skywalking/pull/5050?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5050: add golang component id

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5050: URL: https://github.com/apache/skywalking/pull/5050#issuecomment-654962810 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5050?src=pr&el=h1) Report > Merging [#5050](https://codecov.io/gh/apache/skywalking/pull/5050?src=pr&e

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5050: add golang component id

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5050: URL: https://github.com/apache/skywalking/pull/5050#issuecomment-654962810 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5050: add golang component id

2020-07-07 Thread GitBox
codecov[bot] edited a comment on pull request #5050: URL: https://github.com/apache/skywalking/pull/5050#issuecomment-654962810 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5050?src=pr&el=h1) Report > Merging [#5050](https://codecov.io/gh/apache/skywalking/pull/5050?src=pr&e

<    1   2   3   4   >