Re: [I] [Feature] Supporting remote write protocols for Prometheus or VictoriaMetrics [skywalking]

2023-12-16 Thread via GitHub
wu-sheng closed issue #11665: [Feature] Supporting remote write protocols for Prometheus or VictoriaMetrics URL: https://github.com/apache/skywalking/issues/11665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[I] [Feature] [skywalking]

2023-12-16 Thread via GitHub
kalosmark opened a new issue, #11665: URL: https://github.com/apache/skywalking/issues/11665 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description

Re: [PR] Add Pulsar configuration to determine the collection of message contents [skywalking-java]

2023-12-16 Thread via GitHub
wu-sheng commented on PR #657: URL: https://github.com/apache/skywalking-java/pull/657#issuecomment-1859046030 Any update about this/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] memory has been growing very slowly [skywalking]

2023-12-16 Thread via GitHub
wu-sheng closed issue #11664: memory has been growing very slowly URL: https://github.com/apache/skywalking/issues/11664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[I] memory has been growing very slowly [skywalking]

2023-12-16 Thread via GitHub
sanhe-qigai opened a new issue, #11664: URL: https://github.com/apache/skywalking/issues/11664 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description

Re: [I] [Bug] skywalking-client-js data is not present inside skywalking-ui browser dashboards [skywalking]

2023-12-16 Thread via GitHub
wu-sheng commented on issue #11662: URL: https://github.com/apache/skywalking/issues/11662#issuecomment-1858988624 > It may also be interesting to say in the doc why it is disabled by default in SPAs - for this I have no idea. @Fine0830 Could you confirm this when you have time? --

Re: [I] [Bug] skywalking-client-js data is not present inside skywalking-ui browser dashboards [skywalking]

2023-12-16 Thread via GitHub
marcanpilami commented on issue #11662: URL: https://github.com/apache/skywalking/issues/11662#issuecomment-1858909055 Thanks. However it may not be needed. If I manually add a call to `ClientMonitor.performance(ClientMonitor.customOptions);` just after `ClientMonitor.register(...)` it

Re: [PR] Fix error in re-transforming the jedis class [skywalking-java]

2023-12-16 Thread via GitHub
wu-sheng commented on PR #659: URL: https://github.com/apache/skywalking-java/pull/659#issuecomment-1858847351 I did a quick read on `JedisInstrumentationTest`. Generally, you could write mock classes in the agent repository, and redo the UTs, right? It doesn't need to be inside Jedis

Re: [I] [Bug] skywalking-client-js data is not present inside skywalking-ui browser dashboards [skywalking]

2023-12-16 Thread via GitHub
wu-sheng commented on issue #11662: URL: https://github.com/apache/skywalking/issues/11662#issuecomment-1858846993 If you could provide a reproducible demo, @Fine0830 may be able to have a look. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] [Bug] skywalking-client-js data is not present inside skywalking-ui browser dashboards [skywalking]

2023-12-16 Thread via GitHub
marcanpilami commented on issue #11662: URL: https://github.com/apache/skywalking/issues/11662#issuecomment-1858832202 Just to be sure I have changed my configuratin not to use FMP and with `autoTracePerf` explictely to true, no changes. ```js ClientMonitor.register({

Re: [I] [Bug] skywalking-client-js data is not present inside skywalking-ui browser dashboards [skywalking]

2023-12-16 Thread via GitHub
marcanpilami commented on issue #11662: URL: https://github.com/apache/skywalking/issues/11662#issuecomment-1858828480 The metrics do not seem to be sent. (when i look inside the browser dev tool network pane, there are only calls to `v3/segments`). This may be related to the fact I'm

Re: [PR] Fix error in re-transforming the jedis class [skywalking-java]

2023-12-16 Thread via GitHub
kylixs commented on PR #659: URL: https://github.com/apache/skywalking-java/pull/659#issuecomment-1858827715 > Then how do you prefer to test this? If there isn't a real agent running. I found it does not need to test in real agent, it just need test by re-transform the enhanced

Re: [I] [Bug] skywalking-client-js data is not present inside skywalking-ui browser dashboards [skywalking]

2023-12-16 Thread via GitHub
wu-sheng commented on issue #11662: URL: https://github.com/apache/skywalking/issues/11662#issuecomment-1858823406 Besides traces, the metrics should be reported as well, which should be able to create browser layer service. -- This is an automated message from the Apache Git Service. To

Re: [PR] Fix error in re-transforming the jedis class [skywalking-java]

2023-12-16 Thread via GitHub
wu-sheng commented on PR #659: URL: https://github.com/apache/skywalking-java/pull/659#issuecomment-1858822832 > Write a plugin test to test all plugin maybe difficult, it need to load many classes and some of them are conflicted. Then how do you prefer to test this? If there isn't a

Re: [PR] Fix error in re-transforming the jedis class [skywalking-java]

2023-12-16 Thread via GitHub
kylixs commented on PR #659: URL: https://github.com/apache/skywalking-java/pull/659#issuecomment-1858822255 Write a plugin test to test all plugin maybe difficult, it need to load many classes and some of them are conflicted. -- This is an automated message from the Apache Git Service.

[I] [Bug] skywalking-client-js data is not present inside skywalking-ui browser dashboards [skywalking]

2023-12-16 Thread via GitHub
marcanpilami opened a new issue, #11662: URL: https://github.com/apache/skywalking/issues/11662 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking

Re: [PR] Fix error in re-transforming the jedis class [skywalking-java]

2023-12-16 Thread via GitHub
wu-sheng commented on PR #659: URL: https://github.com/apache/skywalking-java/pull/659#issuecomment-1858819418 Yes, then this is a test scenario, I think you could write a plugin test to verify this. It doesn't matter it is about bytebuddy patch or not. -- This is an automated message

Re: [PR] Fix error in re-transforming the jedis class [skywalking-java]

2023-12-16 Thread via GitHub
kylixs commented on PR #659: URL: https://github.com/apache/skywalking-java/pull/659#issuecomment-1858818900 > Does this indicate, you are actually testing agent, rather than patch? Actually, test re-transforming of plugin -- This is an automated message from the Apache Git

Re: [PR] Fix error in re-transforming the jedis class [skywalking-java]

2023-12-16 Thread via GitHub
wu-sheng commented on PR #659: URL: https://github.com/apache/skywalking-java/pull/659#issuecomment-1858815070 > I want to create an abstract test class that makes it easy to test re-transform in a plug-in module, such as JedisInstrumentationTest. Because of using

Re: [PR] Fix error in re-transforming the jedis class [skywalking-java]

2023-12-16 Thread via GitHub
kylixs commented on PR #659: URL: https://github.com/apache/skywalking-java/pull/659#issuecomment-1858803936 I want to create an abstract test class that makes it easy to test re-transform in a plug-in module, such as JedisInstrumentationTest. Because of using

Re: [PR] Fix error in re-transforming the jedis class [skywalking-java]

2023-12-16 Thread via GitHub
kylixs commented on PR #659: URL: https://github.com/apache/skywalking-java/pull/659#issuecomment-1858803144 > I think this is a general change, rather than fixing Jedis, right? Yes, any class that enhances a method from a parent class will have a similar error. -- This is an

Re: [PR] Fix error in re-transforming the jedis class [skywalking-java]

2023-12-16 Thread via GitHub
wu-sheng commented on PR #659: URL: https://github.com/apache/skywalking-java/pull/659#issuecomment-1858795267 I think this is a general change, rather than fixing Jedis, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] Fix error in re-transforming the jedis class [skywalking-java]

2023-12-16 Thread via GitHub
kylixs opened a new pull request, #659: URL: https://github.com/apache/skywalking-java/pull/659 ### Fix error in re-transforming the jedis classr: https://github.com/apache/skywalking/issues/11651 - [x] Add a unit test to verify that the fix works. - [x] Explain briefly why

(skywalking-website) branch asf-site updated: deploy: 8a5a1768cf55ff8279bd3a90624df03559a47453

2023-12-16 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 240071cca1d deploy: