jichengzhi commented on PR #113:
URL: https://github.com/apache/skywalking-swck/pull/113#issuecomment-2055387082
> e2e needs to add into GHA control file, otherwise, it would not run in the
PR process.
Thanks! It's fixed in the latest commit.
--
This is an automated message from
jichengzhi commented on code in PR #113:
URL: https://github.com/apache/skywalking-swck/pull/113#discussion_r1565203673
##
test/e2e/skywalking-components-with-eventexporter.yaml:
##
@@ -0,0 +1,78 @@
+# Licensed to Apache Software Foundation (ASF) under one or more contributor
jichengzhi commented on code in PR #113:
URL: https://github.com/apache/skywalking-swck/pull/113#discussion_r1565203835
##
operator/controllers/operator/eventexporter_controller.go:
##
@@ -0,0 +1,218 @@
+// Licensed to Apache Software Foundation (ASF) under one or more
jichengzhi commented on code in PR #113:
URL: https://github.com/apache/skywalking-swck/pull/113#discussion_r1565173479
##
operator/controllers/operator/eventexporter_controller.go:
##
@@ -0,0 +1,218 @@
+// Licensed to Apache Software Foundation (ASF) under one or more
fgksgf commented on PR #113:
URL: https://github.com/apache/skywalking-swck/pull/113#issuecomment-2054642335
> ## RCQE-bot: Commit Quality Assessment
> I've carefully evaluated the recent commits, and here's the current state
of the commit quality:
>
> ### Metrics
> *
RCQE-bot commented on PR #113:
URL: https://github.com/apache/skywalking-swck/pull/113#issuecomment-2054621462
## RCQE-bot: Commit Quality Assessment
I've carefully evaluated the recent commits, and here's the current state of
the commit quality:
### Metrics
- Previous
ForestWang123 commented on issue #12100:
URL: https://github.com/apache/skywalking/issues/12100#issuecomment-2054534647
> The expectation behavior is, that if a span's references include at least
one parent that could be found in the current query result, other references
should only be
ForestWang123 commented on issue #12100:
URL: https://github.com/apache/skywalking/issues/12100#issuecomment-2054531927
> The expectation behavior is, that if a span's references include at least
one parent that could be found in the current query result, other references
should only be
wu-sheng commented on issue #12100:
URL: https://github.com/apache/skywalking/issues/12100#issuecomment-2054290692
The expectation behavior is, that if a span's references include at least
one parent that could be found in the current query result, other references
should only be visible
fgksgf commented on code in PR #113:
URL: https://github.com/apache/skywalking-swck/pull/113#discussion_r1565043518
##
test/e2e/skywalking-components-with-eventexporter.yaml:
##
@@ -0,0 +1,78 @@
+# Licensed to Apache Software Foundation (ASF) under one or more contributor
+#
wu-sheng opened a new issue, #12100:
URL: https://github.com/apache/skywalking/issues/12100
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no
similar feature requirement.
### Description
wu-sheng commented on PR #113:
URL: https://github.com/apache/skywalking-swck/pull/113#issuecomment-2054247894
e2e needs to add into GHA control file, otherwise, it would not run in the
PR process.
--
This is an automated message from the Apache Git Service.
To respond to the message,
jichengzhi commented on PR #113:
URL: https://github.com/apache/skywalking-swck/pull/113#issuecomment-2054246970
I added a simple e2e test case for `EventExporter` which tests whether the
pod events (`Pulled`, `Created`, `Started`) of the demo service is reported to
the `OAPServer`.
--
jichengzhi commented on code in PR #113:
URL: https://github.com/apache/skywalking-swck/pull/113#discussion_r1564785085
##
operator/controllers/operator/eventexporter_controller.go:
##
@@ -0,0 +1,210 @@
+// Licensed to Apache Software Foundation (ASF) under one or more
jichengzhi commented on code in PR #113:
URL: https://github.com/apache/skywalking-swck/pull/113#discussion_r1564784986
##
operator/apis/operator/v1alpha1/eventexporter_types.go:
##
@@ -0,0 +1,78 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
jichengzhi commented on code in PR #113:
URL: https://github.com/apache/skywalking-swck/pull/113#discussion_r1564720085
##
operator/apis/operator/v1alpha1/eventexporter_types.go:
##
@@ -0,0 +1,78 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new ee01ce878b chore: update comment of
wu-sheng merged PR #12099:
URL: https://github.com/apache/skywalking/pull/12099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tisonkun opened a new pull request, #12099:
URL: https://github.com/apache/skywalking/pull/12099
No longer extend from H2TableInstaller.
TRIVIAL AS IS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
fgksgf commented on code in PR #113:
URL: https://github.com/apache/skywalking-swck/pull/113#discussion_r1564601301
##
operator/controllers/operator/eventexporter_controller.go:
##
@@ -0,0 +1,210 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
20 matches
Mail list logo
