[GitHub] [skywalking] dmsolr commented on issue #4239: Provide influxdb as a new storage plugin

2020-02-16 Thread GitBox
dmsolr commented on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-586781392 > @dmsolr Please recheck. The ElasticSearch test fails agian. I don't find any change related to you. Please take a look, what is the issue.

[GitHub] [skywalking] dmsolr commented on issue #4239: Provide influxdb as a new storage plugin

2020-02-08 Thread GitBox
dmsolr commented on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-583774959 > All `proto` files under `test/e2e` should be removed, instead, add the protocol repository as submodule, just like what `e2e-ttl-es` does, o

[GitHub] [skywalking] dmsolr commented on issue #4239: Provide influxdb as a new storage plugin

2020-02-04 Thread GitBox
dmsolr commented on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-582234659 > The corresponding `yml` in `docker-entrypoint.sh` should be also updated Sorry, I don't understand. We need to update which file? @kez

[GitHub] [skywalking] dmsolr commented on issue #4239: Provide influxdb as a new storage plugin

2020-02-04 Thread GitBox
dmsolr commented on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-581879651 Thanks for your review and reminder, @wu-sheng and @kezhenxu94 I will fix them later.