kezhenxu94 commented on PR #127:
URL:
https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649552633
> @innerpeacez
>
> I'm ok with this. But I'm concerned that using `zk` instead of `zipkin`
might be confusing. Using 'index' would ensure the readability of these p
kezhenxu94 commented on PR #127:
URL:
https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649551697
I vote for not to use `index` function, using `.` is also friendly for
completion in IDEs。
--
This is an automated message from the Apache Git Service.
To respond to the
kezhenxu94 commented on PR #127:
URL:
https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649213683
> values.yaml
>
> ```
> oap:
> ports:
> # add more ports here if you need, for example
> # zabbix: 10051
> grpc: 11800
> rest: 128
kezhenxu94 commented on PR #127:
URL:
https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1649133355
> @kezhenxu94
>
> It works well now. But I think directly hardcoding the port number(like
`9141` and `9142`) in the file is not very graceful.
I agree, but I
kezhenxu94 commented on PR #127:
URL:
https://github.com/apache/skywalking-kubernetes/pull/127#issuecomment-1647872152
> However, there's one side effect for this env var to be set without
setting the port. The UI pod will throw an error complaining about the missing
port when initializing
