[GitHub] [skywalking] wu-sheng commented on a change in pull request #4325: Close leaked I/O stream and remove unused codes

2020-02-07 Thread GitBox
wu-sheng commented on a change in pull request #4325: Close leaked I/O stream and remove unused codes URL: https://github.com/apache/skywalking/pull/4325#discussion_r376367341 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

2020-02-07 Thread GitBox
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r376380480 ## File path: oap-server/server-bootstrap/src/main/resources/browser_analysis.oal ## @@ -16,72 +16,34 @@ * */

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

2020-02-07 Thread GitBox
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r376380061 ## File path: oap-server/oal-grammar/src/main/antlr4/org/apache/skywalking/oal/rt/grammar/OALLexer.g4 ## @@

[GitHub] [skywalking] dmsolr commented on a change in pull request #4239: Provide influxdb as a new storage plugin

2020-02-07 Thread GitBox
dmsolr commented on a change in pull request #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r376259790 ## File path:

[GitHub] [skywalking] dmsolr commented on a change in pull request #4239: Provide influxdb as a new storage plugin

2020-02-07 Thread GitBox
dmsolr commented on a change in pull request #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r376264109 ## File path:

[GitHub] [skywalking] dmsolr commented on a change in pull request #4239: Provide influxdb as a new storage plugin

2020-02-07 Thread GitBox
dmsolr commented on a change in pull request #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r376263409 ## File path:

[GitHub] [skywalking] GitHub-Yann opened a new issue #4324: There is no data shown in the dashboard

2020-02-07 Thread GitBox
GitHub-Yann opened a new issue #4324: There is no data shown in the dashboard URL: https://github.com/apache/skywalking/issues/4324 Please answer these questions before submitting your issue. - Why do you submit this issue? - [Y ] Question or discussion - [ ] Bug - [ ]

[GitHub] [skywalking] kezhenxu94 commented on issue #4272: Codes clean up plan and set up more strict code style rules

2020-02-07 Thread GitBox
kezhenxu94 commented on issue #4272: Codes clean up plan and set up more strict code style rules URL: https://github.com/apache/skywalking/issues/4272#issuecomment-583376855 If @JohnNiang or any other contributor is interested in this, feel free to leave a comment and open pull requests

[GitHub] [skywalking] arugal commented on issue #4325: Close leaked I/O stream and remove unused codes

2020-02-07 Thread GitBox
arugal commented on issue #4325: Close leaked I/O stream and remove unused codes URL: https://github.com/apache/skywalking/pull/4325#issuecomment-583372408 This is also unused code.

[GitHub] [skywalking] kezhenxu94 commented on issue #4325: Close leaked I/O stream and remove unused codes

2020-02-07 Thread GitBox
kezhenxu94 commented on issue #4325: Close leaked I/O stream and remove unused codes URL: https://github.com/apache/skywalking/pull/4325#issuecomment-583374609 > This is also unused code. > >

[GitHub] [skywalking] GitHub-Yann commented on issue #4324: There is no data shown in the dashboard

2020-02-07 Thread GitBox
GitHub-Yann commented on issue #4324: There is no data shown in the dashboard URL: https://github.com/apache/skywalking/issues/4324#issuecomment-583350430 I change the data range under the browser , the data is shown This is

[GitHub] [skywalking] GitHub-Yann closed issue #4324: There is no data shown in the dashboard

2020-02-07 Thread GitBox
GitHub-Yann closed issue #4324: There is no data shown in the dashboard URL: https://github.com/apache/skywalking/issues/4324 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] wu-sheng commented on issue #4325: Close leaked I/O stream and remove unused codes

2020-02-07 Thread GitBox
wu-sheng commented on issue #4325: Close leaked I/O stream and remove unused codes URL: https://github.com/apache/skywalking/pull/4325#issuecomment-583363484 Some wrong change? All tests are falling. This is an automated

[GitHub] [skywalking] kezhenxu94 opened a new pull request #4325: Close leaked I/O stream and remove unused codes

2020-02-07 Thread GitBox
kezhenxu94 opened a new pull request #4325: Close leaked I/O stream and remove unused codes URL: https://github.com/apache/skywalking/pull/4325 ### Motivation: Clean up unused codes and migrate to JDK8. ### Modifications: - Remove unused codes. - Close leaked

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4239: Provide influxdb as a new storage plugin

2020-02-07 Thread GitBox
wu-sheng commented on a change in pull request #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r376276636 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

2020-02-07 Thread GitBox
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r376390987 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

2020-02-07 Thread GitBox
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r376394711 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

2020-02-07 Thread GitBox
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r376394875 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

2020-02-07 Thread GitBox
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r376395370 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

2020-02-07 Thread GitBox
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r376390816 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

2020-02-07 Thread GitBox
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r376389078 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

2020-02-07 Thread GitBox
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r376395189 ## File path:

[GitHub] [skywalking-website] mrproliu opened a new pull request #78: add committer

2020-02-07 Thread GitBox
mrproliu opened a new pull request #78: add committer URL: https://github.com/apache/skywalking-website/pull/78 Add Han Liu as a new committer This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] codecov-io edited a comment on issue #4239: Provide influxdb as a new storage plugin

2020-02-07 Thread GitBox
codecov-io edited a comment on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-575965825 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4239?src=pr=h1) Report > Merging

[skywalking] branch master updated: Remove unused codes, close leaked I/O stream (#4325)

2020-02-07 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new f676aec Remove unused codes, close

[GitHub] [skywalking] kezhenxu94 merged pull request #4325: Close leaked I/O stream and remove unused codes

2020-02-07 Thread GitBox
kezhenxu94 merged pull request #4325: Close leaked I/O stream and remove unused codes URL: https://github.com/apache/skywalking/pull/4325 This is an automated message from the Apache Git Service. To respond to the message,

[skywalking-website] branch asf-site updated (5cf2065 -> 0d9a5a0)

2020-02-07 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. discard 5cf2065 Update asf-site new 0d9a5a0 Update asf-site This update added new revisions after

[GitHub] [skywalking-website] wu-sheng merged pull request #78: add committer

2020-02-07 Thread GitBox
wu-sheng merged pull request #78: add committer URL: https://github.com/apache/skywalking-website/pull/78 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[skywalking-website] branch master updated: add committer (#78)

2020-02-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new 27e6acb add committer (#78)

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4239: Provide influxdb as a new storage plugin

2020-02-07 Thread GitBox
wu-sheng commented on a change in pull request #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r376689951 ## File path: docs/en/setup/backend/backend-storage.md ## @@ -226,6 +227,27 @@ storage: All connection

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4239: Provide influxdb as a new storage plugin

2020-02-07 Thread GitBox
wu-sheng commented on a change in pull request #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r376689989 ## File path: docs/en/setup/backend/backend-storage.md ## @@ -226,6 +227,27 @@ storage: All connection