[GitHub] [skywalking] jadezhong removed a comment on issue #4292: Improve ES query performance

2020-02-11 Thread GitBox
jadezhong removed a comment on issue #4292: Improve ES query performance URL: https://github.com/apache/skywalking/pull/4292#issuecomment-584975530 ok ---原始邮件--- 发件人:"吴晟 Wu Sheng" 发送时间:2020年2月11日 星期二 下午3:28 收件人:"apache/skywalking" 抄送:"jadezhong";"Comment" 主题:Re:

[GitHub] [skywalking] jadezhong commented on issue #4292: Improve ES query performance

2020-02-11 Thread GitBox
jadezhong commented on issue #4292: Improve ES query performance URL: https://github.com/apache/skywalking/pull/4292#issuecomment-584978651 ok This is an automated message from the Apache Git Service. To respond to the

[skywalking] branch grpc_alarm updated (415b15d -> 9079ed0)

2020-02-11 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch grpc_alarm in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 415b15d fix add 9079ed0 fix No new revisions were added by this update. Summary of changes:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket

2020-02-11 Thread GitBox
wu-sheng commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#discussion_r378070209 ## File path:

[GitHub] [skywalking] jadezhong commented on issue #4292: Improve ES query performance

2020-02-11 Thread GitBox
jadezhong commented on issue #4292: Improve ES query performance URL: https://github.com/apache/skywalking/pull/4292#issuecomment-584975530 ok ---原始邮件--- 发件人:"吴晟 Wu Sheng" 发送时间:2020年2月11日 星期二 下午3:28 收件人:"apache/skywalking" 抄送:"jadezhong";"Comment" 主题:Re:

[GitHub] [skywalking] aderm commented on issue #4291: Improve ES query performance

2020-02-11 Thread GitBox
aderm commented on issue #4291: Improve ES query performance URL: https://github.com/apache/skywalking/issues/4291#issuecomment-585039094 agree, maybe can choose a suitable scenario for large data volumes. But for using filters, the occupation of ES-side resources has not been evaluated

[GitHub] [skywalking] mrproliu commented on issue #4104: [FEATURE] Performance profile at method level in production environment

2020-02-11 Thread GitBox
mrproliu commented on issue #4104: [FEATURE] Performance profile at method level in production environment URL: https://github.com/apache/skywalking/issues/4104#issuecomment-585067724 The UI design has been finished. - Add task model:

[GitHub] [skywalking] aderm commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket

2020-02-11 Thread GitBox
aderm commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#discussion_r378083903 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4239: Provide influxdb as a new storage plugin

2020-02-11 Thread GitBox
wu-sheng commented on a change in pull request #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r378009922 ## File path: .github/workflows/e2e.yaml ## @@ -39,19 +39,21 @@ jobs: ./mvnw --batch-mode

[GitHub] [skywalking] dengliming commented on issue #4352: About Upgrade 6.2.0 to 6.6.0 questions

2020-02-11 Thread GitBox
dengliming commented on issue #4352: About Upgrade 6.2.0 to 6.6.0 questions URL: https://github.com/apache/skywalking/issues/4352#issuecomment-585026276 Is there any way to solve this?And there is no official update documentation. @wu-sheng

[GitHub] [skywalking] dengliming edited a comment on issue #4352: About Upgrade 6.2.0 to 6.6.0 questions

2020-02-11 Thread GitBox
dengliming edited a comment on issue #4352: About Upgrade 6.2.0 to 6.6.0 questions URL: https://github.com/apache/skywalking/issues/4352#issuecomment-585026276 Is there any way to solve this?And there is no official upgrade documentation. @wu-sheng

[skywalking] branch grpc_alarm updated (0635bbe -> abaee0f)

2020-02-11 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch grpc_alarm in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 0635bbe fix. add e5366c0 Tag annotation supports returned expression (#4327) add abaee0f Merge

[GitHub] [skywalking] wu-sheng commented on issue #4327: Tag annotation supports returned expression

2020-02-11 Thread GitBox
wu-sheng commented on issue #4327: Tag annotation supports returned expression URL: https://github.com/apache/skywalking/pull/4327#issuecomment-585046372 Welcome to be 205th contributor of this repo. This is an automated

[GitHub] [skywalking] aderm commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket

2020-02-11 Thread GitBox
aderm commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#discussion_r378083903 ## File path:

[GitHub] [skywalking] JaredTan95 commented on a change in pull request #4344: supprt gRPC alarm hook.

2020-02-11 Thread GitBox
JaredTan95 commented on a change in pull request #4344: supprt gRPC alarm hook. URL: https://github.com/apache/skywalking/pull/4344#discussion_r377990396 ## File path:

[GitHub] [skywalking] JaredTan95 commented on a change in pull request #4344: supprt gRPC alarm hook.

2020-02-11 Thread GitBox
JaredTan95 commented on a change in pull request #4344: supprt gRPC alarm hook. URL: https://github.com/apache/skywalking/pull/4344#discussion_r377989703 ## File path:

[GitHub] [skywalking] wu-sheng commented on issue #4327: Tag annotation supports returned expression

2020-02-11 Thread GitBox
wu-sheng commented on issue #4327: Tag annotation supports returned expression URL: https://github.com/apache/skywalking/pull/4327#issuecomment-584990917 Look like CIs are failing. Please check locally before you push to the upstream. It will cause the CPU of CI resource pool, which will

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4239: Provide influxdb as a new storage plugin

2020-02-11 Thread GitBox
wu-sheng commented on a change in pull request #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r378012577 ## File path: .github/workflows/e2e.yaml ## @@ -39,19 +39,21 @@ jobs: ./mvnw --batch-mode

[skywalking] branch grpc_alarm updated (b63fda4 -> 0635bbe)

2020-02-11 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch grpc_alarm in repository https://gitbox.apache.org/repos/asf/skywalking.git. from b63fda4 fix empty settings. add 0635bbe fix. No new revisions were added by this update. Summary

[GitHub] [skywalking] dengliming opened a new issue #4352: About Upgrade 6.2.0 to 6.6.0 questions

2020-02-11 Thread GitBox
dengliming opened a new issue #4352: About Upgrade 6.2.0 to 6.6.0 questions URL: https://github.com/apache/skywalking/issues/4352 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ]

[GitHub] [skywalking] codecov-io edited a comment on issue #4344: supprt gRPC alarm hook.

2020-02-11 Thread GitBox
codecov-io edited a comment on issue #4344: supprt gRPC alarm hook. URL: https://github.com/apache/skywalking/pull/4344#issuecomment-584597339 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4344?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on issue #4344: supprt gRPC alarm hook.

2020-02-11 Thread GitBox
wu-sheng commented on issue #4344: supprt gRPC alarm hook. URL: https://github.com/apache/skywalking/pull/4344#issuecomment-585052587 @kezhenxu94 Recheck? This is an automated message from the Apache Git Service. To respond

[GitHub] [skywalking] JaredTan95 commented on a change in pull request #4344: supprt gRPC alarm hook.

2020-02-11 Thread GitBox
JaredTan95 commented on a change in pull request #4344: supprt gRPC alarm hook. URL: https://github.com/apache/skywalking/pull/4344#discussion_r377989703 ## File path:

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4327: Tag annotation supports returned expression

2020-02-11 Thread GitBox
kezhenxu94 commented on a change in pull request #4327: Tag annotation supports returned expression URL: https://github.com/apache/skywalking/pull/4327#discussion_r377997459 ## File path:

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4327: Tag annotation supports returned expression

2020-02-11 Thread GitBox
kezhenxu94 commented on a change in pull request #4327: Tag annotation supports returned expression URL: https://github.com/apache/skywalking/pull/4327#discussion_r377997300 ## File path:

[GitHub] [skywalking] wu-sheng commented on issue #4327: Tag annotation supports returned expression

2020-02-11 Thread GitBox
wu-sheng commented on issue #4327: Tag annotation supports returned expression URL: https://github.com/apache/skywalking/pull/4327#issuecomment-584980509 BTW, please check CIs why they are failing. This is an automated

[GitHub] [skywalking] dengliming opened a new issue #4351: Byte-buddy occurs exception when match type.

2020-02-11 Thread GitBox
dengliming opened a new issue #4351: Byte-buddy occurs exception when match type. URL: https://github.com/apache/skywalking/issues/4351 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ]

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4239: Provide influxdb as a new storage plugin

2020-02-11 Thread GitBox
wu-sheng commented on a change in pull request #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r378004330 ## File path: .github/workflows/e2e.yaml ## @@ -39,19 +39,21 @@ jobs: ./mvnw --batch-mode

[GitHub] [skywalking] wu-sheng commented on issue #4327: Tag annotation supports returned expression

2020-02-11 Thread GitBox
wu-sheng commented on issue #4327: Tag annotation supports returned expression URL: https://github.com/apache/skywalking/pull/4327#issuecomment-584985052 Once CI passed, the codes LGTM. Welcome. This is an automated message

[GitHub] [skywalking] wu-sheng commented on issue #4351: Byte-buddy occurs exception when match type.

2020-02-11 Thread GitBox
wu-sheng commented on issue #4351: Byte-buddy occurs exception when match type. URL: https://github.com/apache/skywalking/issues/4351#issuecomment-584993480 If `org.apache.commons.csv.CSVFormat` can't be found by ByteBuddy in the classpath, then this error shows up. But basically, this

[GitHub] [skywalking] wu-sheng closed issue #4351: Byte-buddy occurs exception when match type.

2020-02-11 Thread GitBox
wu-sheng closed issue #4351: Byte-buddy occurs exception when match type. URL: https://github.com/apache/skywalking/issues/4351 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [skywalking] dmsolr commented on a change in pull request #4239: Provide influxdb as a new storage plugin

2020-02-11 Thread GitBox
dmsolr commented on a change in pull request #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r378014958 ## File path: .github/workflows/e2e.yaml ## @@ -39,19 +39,21 @@ jobs: ./mvnw --batch-mode

[GitHub] [skywalking] dmsolr commented on a change in pull request #4239: Provide influxdb as a new storage plugin

2020-02-11 Thread GitBox
dmsolr commented on a change in pull request #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r378014946 ## File path: .github/workflows/e2e.yaml ## @@ -39,19 +39,21 @@ jobs: ./mvnw --batch-mode

[GitHub] [skywalking] wu-sheng commented on issue #4352: About Upgrade 6.2.0 to 6.6.0 questions

2020-02-11 Thread GitBox
wu-sheng commented on issue #4352: About Upgrade 6.2.0 to 6.6.0 questions URL: https://github.com/apache/skywalking/issues/4352#issuecomment-585027969 Read FAQ, doc is there. This is an automated message from the Apache Git

[GitHub] [skywalking] wu-sheng closed issue #4352: About Upgrade 6.2.0 to 6.6.0 questions

2020-02-11 Thread GitBox
wu-sheng closed issue #4352: About Upgrade 6.2.0 to 6.6.0 questions URL: https://github.com/apache/skywalking/issues/4352 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4344: supprt gRPC alarm hook.

2020-02-11 Thread GitBox
kezhenxu94 commented on a change in pull request #4344: supprt gRPC alarm hook. URL: https://github.com/apache/skywalking/pull/4344#discussion_r377996822 ## File path:

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4344: supprt gRPC alarm hook.

2020-02-11 Thread GitBox
kezhenxu94 commented on a change in pull request #4344: supprt gRPC alarm hook. URL: https://github.com/apache/skywalking/pull/4344#discussion_r377996414 ## File path:

[GitHub] [skywalking] wu-sheng commented on issue #4228: Support Browser protocol at OAP

2020-02-11 Thread GitBox
wu-sheng commented on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584992794 > For PV with JS error in specified time, If server can't know which errors belong to which PV now, we can add a parameter to mark in error logs.

[skywalking] branch grpc_alarm updated (9079ed0 -> b63fda4)

2020-02-11 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch grpc_alarm in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 9079ed0 fix add b63fda4 fix empty settings. No new revisions were added by this update. Summary of

[GitHub] [skywalking] kezhenxu94 merged pull request #4327: Tag annotation supports returned expression

2020-02-11 Thread GitBox
kezhenxu94 merged pull request #4327: Tag annotation supports returned expression URL: https://github.com/apache/skywalking/pull/4327 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] codecov-io edited a comment on issue #4327: Tag annotation supports returned expression

2020-02-11 Thread GitBox
codecov-io edited a comment on issue #4327: Tag annotation supports returned expression URL: https://github.com/apache/skywalking/pull/4327#issuecomment-583735666 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4327?src=pr=h1) Report > :exclamation: No coverage uploaded for

[skywalking] branch master updated: Tag annotation supports returned expression (#4327)

2020-02-11 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new e5366c0 Tag annotation supports

[GitHub] [skywalking] lxliuxuankb commented on issue #4327: Tag annotation supports returned expression

2020-02-11 Thread GitBox
lxliuxuankb commented on issue #4327: Tag annotation supports returned expression URL: https://github.com/apache/skywalking/pull/4327#issuecomment-585045240 thanks This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] codecov-io edited a comment on issue #4228: Support Browser protocol at OAP

2020-02-11 Thread GitBox
codecov-io edited a comment on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request

[GitHub] [skywalking] kezhenxu94 closed issue #4255: Support evaluation using the returned object

2020-02-11 Thread GitBox
kezhenxu94 closed issue #4255: Support evaluation using the returned object URL: https://github.com/apache/skywalking/issues/4255 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4344: supprt gRPC alarm hook.

2020-02-11 Thread GitBox
wu-sheng commented on a change in pull request #4344: supprt gRPC alarm hook. URL: https://github.com/apache/skywalking/pull/4344#discussion_r378059399 ## File path:

[GitHub] [skywalking] aderm commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket

2020-02-11 Thread GitBox
aderm commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#discussion_r378083903 ## File path:

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4344: supprt gRPC alarm hook.

2020-02-11 Thread GitBox
kezhenxu94 commented on a change in pull request #4344: supprt gRPC alarm hook. URL: https://github.com/apache/skywalking/pull/4344#discussion_r377988008 ## File path:

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4344: supprt gRPC alarm hook.

2020-02-11 Thread GitBox
kezhenxu94 commented on a change in pull request #4344: supprt gRPC alarm hook. URL: https://github.com/apache/skywalking/pull/4344#discussion_r377987571 ## File path:

[GitHub] [skywalking] aderm opened a new pull request #4353: Optimizing ES query performance reduces the scope of index queries th…

2020-02-11 Thread GitBox
aderm opened a new pull request #4353: Optimizing ES query performance reduces the scope of index queries th… URL: https://github.com/apache/skywalking/pull/4353 …rough precise queries Please answer these questions before submitting pull request - Why submit this pull

[GitHub] [skywalking] codecov-io edited a comment on issue #4344: supprt gRPC alarm hook.

2020-02-11 Thread GitBox
codecov-io edited a comment on issue #4344: supprt gRPC alarm hook. URL: https://github.com/apache/skywalking/pull/4344#issuecomment-584597339 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4344?src=pr=h1) Report > Merging

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4239: Provide influxdb as a new storage plugin

2020-02-11 Thread GitBox
kezhenxu94 commented on a change in pull request #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r378009081 ## File path: .github/workflows/e2e.yaml ## @@ -39,19 +39,21 @@ jobs: ./mvnw --batch-mode

[GitHub] [skywalking] Fine0830 edited a comment on issue #4228: Support Browser protocol at OAP

2020-02-11 Thread GitBox
Fine0830 edited a comment on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584989598 > @Fine0830 It is easy to say like that. Please take a look at the protocol, how to implement that? JS error has never been reported, we

[GitHub] [skywalking] kezhenxu94 closed issue #4343: [e2e] MySQL e2e test could pass even MySQL driver downloaded failure.

2020-02-11 Thread GitBox
kezhenxu94 closed issue #4343: [e2e] MySQL e2e test could pass even MySQL driver downloaded failure. URL: https://github.com/apache/skywalking/issues/4343 This is an automated message from the Apache Git Service. To respond

[GitHub] [skywalking] kezhenxu94 commented on issue #4343: [e2e] MySQL e2e test could pass even MySQL driver downloaded failure.

2020-02-11 Thread GitBox
kezhenxu94 commented on issue #4343: [e2e] MySQL e2e test could pass even MySQL driver downloaded failure. URL: https://github.com/apache/skywalking/issues/4343#issuecomment-584990302 The e2e still passed because the failure (download) stops the replacement of `application.yaml`, and it

[GitHub] [skywalking] Fine0830 commented on issue #4228: Support Browser protocol at OAP

2020-02-11 Thread GitBox
Fine0830 commented on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584989598 > @Fine0830 It is easy to say like that. Please take a look at the protocol, how to implement that? JS error has never been reported, we received

[GitHub] [skywalking] Fine0830 edited a comment on issue #4228: Support Browser protocol at OAP

2020-02-11 Thread GitBox
Fine0830 edited a comment on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584989598 > @Fine0830 It is easy to say like that. Please take a look at the protocol, how to implement that? JS error has never been reported, we

[GitHub] [skywalking] Fine0830 commented on issue #4228: Support Browser protocol at OAP

2020-02-11 Thread GitBox
Fine0830 commented on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584998594 @wu-sheng For error logs, if backend can't cache/persistent the context, how do we query error details. Error details are needed to analyse code

[GitHub] [skywalking] Fine0830 edited a comment on issue #4228: Support Browser protocol at OAP

2020-02-11 Thread GitBox
Fine0830 edited a comment on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584998594 @wu-sheng For error logs, if backend can't cache/persistent the context, how do we query error details? Error details are needed to analyse

[GitHub] [skywalking] wu-sheng commented on issue #4228: Support Browser protocol at OAP

2020-02-11 Thread GitBox
wu-sheng commented on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-585008534 > For error logs, if backend can't cache/persistent the context, how do we query error details? Error details are needed to analyse code error

[GitHub] [skywalking] codecov-io commented on issue #4353: Optimizing performance reduces es index queries scope by timebucket

2020-02-11 Thread GitBox
codecov-io commented on issue #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#issuecomment-585057389 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4353?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket

2020-02-11 Thread GitBox
wu-sheng commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#discussion_r378071809 ## File path:

[GitHub] [skywalking] wu-sheng commented on issue #4327: Tag annotation supports returned expression

2020-02-11 Thread GitBox
wu-sheng commented on issue #4327: Tag annotation supports returned expression URL: https://github.com/apache/skywalking/pull/4327#issuecomment-584539033 The strict format rule has been merged, please update this PR. This is

[GitHub] [skywalking] kezhenxu94 commented on issue #4337: Set up more strict code styles and fix existing issues

2020-02-11 Thread GitBox
kezhenxu94 commented on issue #4337: Set up more strict code styles and fix existing issues URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584543774 @apache/skywalking-committers please update the codes locally and reimport the `codeStyle.xml` into your IDEA, thanks :)

[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-11 Thread GitBox
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-584523278 Hi @wu-sheng Not only `my.cnf`, a `sharding-algorithm.jar` is necessary to be put into

[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-11 Thread GitBox
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-584533083 @wu-sheng Here is another news, ShardingSphere is planning to do some optimization for sharding

[GitHub] [skywalking] wu-sheng commented on issue #4344: supprt gRPC alarm hook.

2020-02-11 Thread GitBox
wu-sheng commented on issue #4344: supprt gRPC alarm hook. URL: https://github.com/apache/skywalking/pull/4344#issuecomment-584538031 The strict format rule has been merged, please update this PR. This is an automated message

[GitHub] [skywalking] wu-sheng commented on issue #4272: Codes clean up plan and set up more strict code style rules

2020-02-11 Thread GitBox
wu-sheng commented on issue #4272: Codes clean up plan and set up more strict code style rules URL: https://github.com/apache/skywalking/issues/4272#issuecomment-584537782 @kezhenxu94 Which things left here? As #4337 has been merged.

[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues

2020-02-11 Thread GitBox
wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584544649 @kezhenxu94 Send a notification mail to dev ml please. This

[GitHub] [skywalking] JaredTan95 merged pull request #4348: Add servingcloud.com to powered-by.md

2020-02-11 Thread GitBox
JaredTan95 merged pull request #4348: Add servingcloud.com to powered-by.md URL: https://github.com/apache/skywalking/pull/4348 This is an automated message from the Apache Git Service. To respond to the message, please log

[skywalking] branch master updated: Add servingcloud.com to powered-by.md (#4348)

2020-02-11 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new d2afdb1 Add servingcloud.com to

[GitHub] [skywalking] kezhenxu94 commented on issue #4272: Codes clean up plan and set up more strict code style rules

2020-02-11 Thread GitBox
kezhenxu94 commented on issue #4272: Codes clean up plan and set up more strict code style rules URL: https://github.com/apache/skywalking/issues/4272#issuecomment-584554649 > @kezhenxu94 Which things left here? As #4337 has been merged. Have updated the TODOs in the first comment

[skywalking] branch grpc_alarm updated (f81fd13 -> 2f5a4ee)

2020-02-11 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch grpc_alarm in repository https://gitbox.apache.org/repos/asf/skywalking.git. from f81fd13 Merge branch 'master' into grpc_alarm add 2f5a4ee revert submodule. No new revisions were

[GitHub] [skywalking] wu-sheng commented on issue #4228: Support Browser protocol at OAP

2020-02-11 Thread GitBox
wu-sheng commented on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584515547 @Fine0830 It is easy to say like that. Please take a look at the protocol, how to implement that? JS error has never been reported, we received

[GitHub] [skywalking] wu-sheng commented on issue #4347: How can I deploy skywalking 6.6 in k8s

2020-02-11 Thread GitBox
wu-sheng commented on issue #4347: How can I deploy skywalking 6.6 in k8s URL: https://github.com/apache/skywalking/issues/4347#issuecomment-584518460 Image yes, helm no. This is an automated message from the Apache Git

[GitHub] [skywalking] JCchenxiang commented on issue #4347: How can I deploy skywalking 6.6 in k8s

2020-02-11 Thread GitBox
JCchenxiang commented on issue #4347: How can I deploy skywalking 6.6 in k8s URL: https://github.com/apache/skywalking/issues/4347#issuecomment-584518949 I see,thanks This is an automated message from the Apache Git Service.

[GitHub] [skywalking] wu-sheng commented on issue #4347: How can I deploy skywalking 6.6 in k8s

2020-02-11 Thread GitBox
wu-sheng commented on issue #4347: How can I deploy skywalking 6.6 in k8s URL: https://github.com/apache/skywalking/issues/4347#issuecomment-584518632 It is a personal network issue, he couldn't test and then, he could not start the official apache release process.

[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-11 Thread GitBox
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-584534107 > There are some options > > 1. As you said, you could provide the source codes hosted in

[GitHub] [skywalking] wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin

2020-02-11 Thread GitBox
wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-584540142 The strict format rule has been merged, please update this PR. This is an

[GitHub] [skywalking] wu-sheng commented on issue #4228: Support Browser protocol at OAP

2020-02-11 Thread GitBox
wu-sheng commented on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584540175 The strict format rule has been merged, please update this PR. This is an automated

[skywalking] branch grpc_alarm updated (11f0ea1 -> f81fd13)

2020-02-11 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch grpc_alarm in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 11f0ea1 Merge commit '5b255ba3e3b50e0e0196b28cdca21dcd5c9c3da2' into grpc_alarm add d2afdb1 Add

[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-11 Thread GitBox
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-584594056 > Then the expected module will be

[GitHub] [skywalking] amogege opened a new pull request #4348: Update powered-by.md

2020-02-11 Thread GitBox
amogege opened a new pull request #4348: Update powered-by.md URL: https://github.com/apache/skywalking/pull/4348 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve performance

[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues

2020-02-11 Thread GitBox
wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584529280 Rechecked from locally, https://repo.maven.apache.org/maven2/io/github/openfeign/feign-core/9.2.0/feign-core-9.2.0.jar

[GitHub] [skywalking] tristaZero edited a comment on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-11 Thread GitBox
tristaZero edited a comment on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-584533083 @wu-sheng Here is another news, ShardingSphere is planning to do some optimization for

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-11 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-584534922 Then the expected module will be `oap-server/server-storage-plugin/storage-shardingsphere-algorithms`.

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-11 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-584523846 `sharding-algorithm.jar` needs to be taken care of differently. It is a binary distribution, so it can't

[GitHub] [skywalking] codecov-io commented on issue #4348: Add servingcloud.com to powered-by.md

2020-02-11 Thread GitBox
codecov-io commented on issue #4348: Add servingcloud.com to powered-by.md URL: https://github.com/apache/skywalking/pull/4348#issuecomment-584546193 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4348?src=pr=h1) Report > Merging

[GitHub] [skywalking] amogege opened a new pull request #4349: Update powered-by.md

2020-02-11 Thread GitBox
amogege opened a new pull request #4349: Update powered-by.md URL: https://github.com/apache/skywalking/pull/4349 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve performance

[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-11 Thread GitBox
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-584525495 > `sharding-algorithm.jar` needs to be taken care of differently. It is a binary distribution, so it

[GitHub] [skywalking] tristaZero edited a comment on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-11 Thread GitBox
tristaZero edited a comment on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-584525495 > `sharding-algorithm.jar` needs to be taken care of differently. It is a binary distribution,

[GitHub] [skywalking] amogege closed pull request #4349: Update powered-by.md

2020-02-11 Thread GitBox
amogege closed pull request #4349: Update powered-by.md URL: https://github.com/apache/skywalking/pull/4349 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [skywalking] amogege commented on issue #4348: Update powered-by.md

2020-02-11 Thread GitBox
amogege commented on issue #4348: Update powered-by.md URL: https://github.com/apache/skywalking/pull/4348#issuecomment-584525293 公司有登记过powered by This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] codecov-io edited a comment on issue #4348: Add servingcloud.com to powered-by.md

2020-02-11 Thread GitBox
codecov-io edited a comment on issue #4348: Add servingcloud.com to powered-by.md URL: https://github.com/apache/skywalking/pull/4348#issuecomment-584546193 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4348?src=pr=h1) Report > Merging

[GitHub] [skywalking] dmsolr opened a new pull request #4350: Fix code-style formatter

2020-02-11 Thread GitBox
dmsolr opened a new pull request #4350: Fix code-style formatter URL: https://github.com/apache/skywalking/pull/4350 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve

[GitHub] [skywalking] JCchenxiang commented on issue #4347: How can I deploy skywalking 6.6 in k8s

2020-02-11 Thread GitBox
JCchenxiang commented on issue #4347: How can I deploy skywalking 6.6 in k8s URL: https://github.com/apache/skywalking/issues/4347#issuecomment-584518033 You mean that the official doesn't provide 6.6 skywalking image now? Can you describe what is network issue in detail?

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-11 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-584524257 If this runs into the release process, it seems you need another repo? If that, I would like to ask you

[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues

2020-02-11 Thread GitBox
wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584531145 @kezhenxu94 Do you agree we should merge this than waiting the CI fails again and again because of network issue?

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-11 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-584530629 There are some options 1. As you said, you could provide the source codes hosted in SkyWalking main

[GitHub] [skywalking] wu-sheng merged pull request #4337: Set up more strict code styles and fix existing issues

2020-02-11 Thread GitBox
wu-sheng merged pull request #4337: Set up more strict code styles and fix existing issues URL: https://github.com/apache/skywalking/pull/4337 This is an automated message from the Apache Git Service. To respond to the

  1   2   >