codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr=h1)
Report
> Merging
snpcp commented on issue #5052:
URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655248138
I'll make sure that's okay, you can look at the data That I've provided, and
when the data goes into Skywalking, What we should care about is the data
itself.
Normally, the
kezhenxu94 commented on a change in pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#discussion_r451248736
##
File path:
codecov[bot] edited a comment on pull request #5054:
URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5054:
URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5054:
URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5054:
URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5054:
URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5054:
URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5054:
URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5054:
URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
snpcp commented on issue #5052:
URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655249110
The first line.
The second line.
codecov[bot] commented on pull request #5054:
URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr=h1)
Report
> Merging
[#5054](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr=desc) into
codecov[bot] edited a comment on pull request #5054:
URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5054:
URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5050:
URL: https://github.com/apache/skywalking/pull/5050#issuecomment-654962810
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5050?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5050:
URL: https://github.com/apache/skywalking/pull/5050#issuecomment-654962810
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5050?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5050:
URL: https://github.com/apache/skywalking/pull/5050#issuecomment-654962810
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5050?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5050:
URL: https://github.com/apache/skywalking/pull/5050#issuecomment-654962810
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5050?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5050:
URL: https://github.com/apache/skywalking/pull/5050#issuecomment-654962810
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5050?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5050:
URL: https://github.com/apache/skywalking/pull/5050#issuecomment-654962810
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5050?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr=h1)
Report
> Merging
wu-sheng commented on issue #5052:
URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655246382
What do you mean reversed? Have you checked your local env? Are ATG and User
Servica Name deployed on different VMs? Do they have OS clock difference?
kezhenxu94 opened a new pull request #5054:
URL: https://github.com/apache/skywalking/pull/5054
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5054:
URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5050:
URL: https://github.com/apache/skywalking/pull/5050#issuecomment-654962810
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5050?src=pr=h1)
Report
> Merging
wu-sheng commented on a change in pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#discussion_r451211434
##
File path: docs/en/setup/backend/dynamic-config.md
##
@@ -102,3 +102,16 @@ configuration:
appId: ${SW_CONFIG_APOLLO_APP_ID:skywalking}
wu-sheng commented on issue #5044:
URL: https://github.com/apache/skywalking/issues/5044#issuecomment-655203870
> dose that mean in 6.x version it is difficult to solve the problem?
Yes, it is hard. That is why we changed the design.
> in 8+,will all the operationame be
wu-sheng commented on issue #5052:
URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655250944
I found these two timestamp in your span
```
1594174262602
1594174272610
```
The difference is 10008ms, what is the issue?
kezhenxu94 commented on a change in pull request #5030:
URL: https://github.com/apache/skywalking/pull/5030#discussion_r451256316
##
File path:
wu-sheng commented on a change in pull request #5030:
URL: https://github.com/apache/skywalking/pull/5030#discussion_r451269460
##
File path: test/plugin/scenarios/graphql-9.x-scenario/config/expectedData.yaml
##
@@ -0,0 +1,92 @@
+# Licensed to the Apache Software Foundation
kangswx opened a new issue #5053:
URL: https://github.com/apache/skywalking/issues/5053
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [ ] Requirement
- [ ] Feature or performance
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #5050:
URL: https://github.com/apache/skywalking/pull/5050#issuecomment-654962810
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5050?src=pr=h1)
Report
> Merging
wu-sheng commented on a change in pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#discussion_r451211757
##
File path:
codecov[bot] edited a comment on pull request #5050:
URL: https://github.com/apache/skywalking/pull/5050#issuecomment-654962810
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5050?src=pr=h1)
Report
> Merging
wu-sheng commented on a change in pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#discussion_r451212002
##
File path: docs/en/setup/backend/dynamic-config.md
##
@@ -102,3 +102,16 @@ configuration:
appId: ${SW_CONFIG_APOLLO_APP_ID:skywalking}
codecov[bot] edited a comment on pull request #5050:
URL: https://github.com/apache/skywalking/pull/5050#issuecomment-654962810
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5050?src=pr=h1)
Report
> Merging
arugal commented on pull request #325:
URL:
https://github.com/apache/skywalking-rocketbot-ui/pull/325#issuecomment-655215589
> The logos for Gear and Gin are rather big, both in file size and image
size, we don't need that large image as logo
I will try to compress the image size
wu-sheng commented on a change in pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#discussion_r451231254
##
File path:
snpcp opened a new issue #5051:
URL: https://github.com/apache/skywalking/issues/5051
调用时长的时长图像应该显示最大为10007ms，但是却显示成为了90s，导致看到的调用时长显示不正确。
通过network查看到获取到的trace的响应数据。
{
"data": {
"trace": {
"spans": [
{
"traceId":
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
This is an automated message from the Apache Git Service.
To respond to the message, please log
snpcp commented on issue #5052:
URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655244331
snpcp commented on issue #5052:
URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655244569
You can see that the call time is 90s instead of 10008ms.
This is an automated message from the Apache Git Service.
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr=h1)
Report
> Merging
snpcp opened a new issue #5052:
URL: https://github.com/apache/skywalking/issues/5052
The maximum length of the call should be 10007ms, but 90s is instead, so the
call length shown is incorrect.
The response data of the trace obtained can be viewed through the network.
This
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr=h1)
Report
> Merging
snpcp commented on issue #5052:
URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655251873
I slept in the my code for 10 seconds, The reason is that I want to check
whether the 90s problem is caused by my duration is too small.
snpcp commented on issue #5052:
URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655255193
This is a correct request, but still has the 90s problem.
``` JSON
{
"data": {
"trace": {
"spans": [
{
"traceId":
wu-sheng edited a comment on issue #5052:
URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655255387
Children span start time is before the parent start time, which could only
be caused by the target app OS clock issue.
wu-sheng commented on issue #5052:
URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655255387
Children span end time is before the parent start time, which could only be
caused by the target app OS clock issue.
codecov[bot] edited a comment on pull request #5054:
URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5054:
URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5054:
URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5054?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5050:
URL: https://github.com/apache/skywalking/pull/5050#issuecomment-654962810
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5050?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
wu-sheng commented on issue #5051:
URL: https://github.com/apache/skywalking/issues/5051#issuecomment-655236464
English only. And please provide well-formated information.
This is an automated message from the Apache Git
wu-sheng closed issue #5051:
URL: https://github.com/apache/skywalking/issues/5051
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5046:
URL: https://github.com/apache/skywalking/pull/5046#issuecomment-654582409
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5046?src=pr=h1)
Report
> Merging
wu-sheng commented on issue #5052:
URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655254373
```
"startTime": 1594174262602,
"endTime": 1594174174466,
```
You have data incorrectly. And this could be identified by yourself.
kezhenxu94 commented on a change in pull request #5030:
URL: https://github.com/apache/skywalking/pull/5030#discussion_r451256030
##
File path: test/plugin/scenarios/graphql-9.x-scenario/config/expectedData.yaml
##
@@ -0,0 +1,92 @@
+# Licensed to the Apache Software Foundation
snpcp commented on issue #5052:
URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655254743
This is my request and response data. Why is there an error? Shouldn't our
concern be that the data doesn't show up correctly.
snpcp commented on issue #5052:
URL: https://github.com/apache/skywalking/issues/5052#issuecomment-655254468
kezhenxu94 commented on a change in pull request #5030:
URL: https://github.com/apache/skywalking/pull/5030#discussion_r451265299
##
File path: test/plugin/scenarios/graphql-9.x-scenario/config/expectedData.yaml
##
@@ -0,0 +1,92 @@
+# Licensed to the Apache Software Foundation
codecov[bot] edited a comment on pull request #5054:
URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #5054:
URL: https://github.com/apache/skywalking/pull/5054#issuecomment-655273886
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #5050:
URL: https://github.com/apache/skywalking/pull/5050#issuecomment-654962810
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5050?src=pr=h1)
Report
> Merging
codecov[bot] edited a comment on pull request #5050:
URL: https://github.com/apache/skywalking/pull/5050#issuecomment-654962810
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5050?src=pr=h1)
Report
> Merging
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 42c8ceb add golang component id (#5050)
wu-sheng merged pull request #5050:
URL: https://github.com/apache/skywalking/pull/5050
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
EvanLjp commented on a change in pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#discussion_r451227147
##
File path: docs/en/setup/backend/dynamic-config.md
##
@@ -102,3 +102,16 @@ configuration:
appId: ${SW_CONFIG_APOLLO_APP_ID:skywalking}
EvanLjp commented on a change in pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#discussion_r451227086
##
File path:
codecov[bot] edited a comment on pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1)
Report
> Merging
1 - 100 of 250 matches
Mail list logo
