[GitHub] [skywalking-python] kezhenxu94 commented on a change in pull request #38: Created venv builders for linux/windows and req flashers + use documentation

2020-07-17 Thread GitBox
kezhenxu94 commented on a change in pull request #38: URL: https://github.com/apache/skywalking-python/pull/38#discussion_r456237216 ## File path: requirements.txt ## @@ -0,0 +1,23 @@ +blindspin==2.0.1 +certifi==2020.6.20 +chardet==3.0.4 +colorama==0.4.3 +crayons==0.3.1

[GitHub] [skywalking] wu-sheng commented on issue #5116: happen error when use trace tookit to get traceid

2020-07-17 Thread GitBox
wu-sheng commented on issue #5116: URL: https://github.com/apache/skywalking/issues/5116#issuecomment-659897510 I can't see the SkyWalking error stack, could you highlight them? This is an automated message from the Apache

[GitHub] [skywalking] wu-sheng commented on issue #5116: happen error when use trace tookit to get traceid

2020-07-17 Thread GitBox
wu-sheng commented on issue #5116: URL: https://github.com/apache/skywalking/issues/5116#issuecomment-659972064 What do you do? This seems some classloader issue. This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] wu-sheng commented on issue #5116: happen error when use trace tookit to get traceid

2020-07-17 Thread GitBox
wu-sheng commented on issue #5116: URL: https://github.com/apache/skywalking/issues/5116#issuecomment-659980472 Then why the agent missed some classes? Have you changed the agent source codes? Or repackage by yourself? We haven't faced this issue in any test.

[GitHub] [skywalking-python] zkscpqm commented on a change in pull request #38: Created venv builders for linux/windows and req flashers + use documentation

2020-07-17 Thread GitBox
zkscpqm commented on a change in pull request #38: URL: https://github.com/apache/skywalking-python/pull/38#discussion_r456243797 ## File path: requirements.txt ## @@ -0,0 +1,23 @@ +blindspin==2.0.1 +certifi==2020.6.20 +chardet==3.0.4 +colorama==0.4.3 +crayons==0.3.1

[GitHub] [skywalking] research-sudo opened a new issue #5117: Inquiry About the Microservice Architecture Employed by `skywalking`

2020-07-17 Thread GitBox
research-sudo opened a new issue #5117: URL: https://github.com/apache/skywalking/issues/5117 I am a researcher investigating the open source projects that are designed by the microservice architectural style (https://martinfowler.com/microservices/). My preliminary investigation shows

[GitHub] [skywalking-python] zkscpqm commented on a change in pull request #38: Created venv builders for linux/windows and req flashers + use documentation

2020-07-17 Thread GitBox
zkscpqm commented on a change in pull request #38: URL: https://github.com/apache/skywalking-python/pull/38#discussion_r456244258 ## File path: requirements.txt ## @@ -0,0 +1,23 @@ +blindspin==2.0.1 +certifi==2020.6.20 +chardet==3.0.4 +colorama==0.4.3 +crayons==0.3.1

[GitHub] [skywalking-python] kezhenxu94 commented on a change in pull request #38: Created venv builders for linux/windows and req flashers + use documentation

2020-07-17 Thread GitBox
kezhenxu94 commented on a change in pull request #38: URL: https://github.com/apache/skywalking-python/pull/38#discussion_r456250154 ## File path: requirements.txt ## @@ -0,0 +1,23 @@ +blindspin==2.0.1 +certifi==2020.6.20 +chardet==3.0.4 +colorama==0.4.3 +crayons==0.3.1

[GitHub] [skywalking] killGC opened a new issue #5116: happen error when use trace tookit to get traceid

2020-07-17 Thread GitBox
killGC opened a new issue #5116: URL: https://github.com/apache/skywalking/issues/5116 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance

[GitHub] [skywalking-python] kezhenxu94 edited a comment on pull request #38: Created venv builders for linux/windows and req flashers + use documentation

2020-07-17 Thread GitBox
kezhenxu94 edited a comment on pull request #38: URL: https://github.com/apache/skywalking-python/pull/38#issuecomment-659899805 @zkscpqm and I found a dead lock in your scripts, `build_requirements_linux.sh` requires `venv`, but `venv` is set up in `setup_linux.sh`, while

[GitHub] [skywalking-python] kezhenxu94 commented on pull request #38: Created venv builders for linux/windows and req flashers + use documentation

2020-07-17 Thread GitBox
kezhenxu94 commented on pull request #38: URL: https://github.com/apache/skywalking-python/pull/38#issuecomment-659899805 @zkscpqm and I found a dead lock in your scripts, `build_requirements_linux.sh` requires `venv`, but `venv` is set up in `setup_linux.sh`, while `setup_linux.sh`

[GitHub] [skywalking] killGC commented on issue #5116: happen error when use trace tookit to get traceid

2020-07-17 Thread GitBox
killGC commented on issue #5116: URL: https://github.com/apache/skywalking/issues/5116#issuecomment-659927015 > I can't see the SkyWalking error stack, could you highlight them? this is ok? This is an automated

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5109: Fix issue 4965

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5109: URL: https://github.com/apache/skywalking/pull/5109#issuecomment-659387212 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5109?src=pr=h1) Report > Merging

[GitHub] [skywalking] killGC commented on issue #5116: happen error when use trace tookit to get traceid

2020-07-17 Thread GitBox
killGC commented on issue #5116: URL: https://github.com/apache/skywalking/issues/5116#issuecomment-659978163 get traceid by skywalking trace tookit at java program of application This is an automated message from the Apache

[GitHub] [skywalking] killGC commented on issue #5116: happen error when use trace tookit to get traceid

2020-07-17 Thread GitBox
killGC commented on issue #5116: URL: https://github.com/apache/skywalking/issues/5116#issuecomment-659991419 no, i don‘t do some change ,i open skywalking-agent.jar by WinRAR, i can see class 'StaticMethodsInter' at here

[GitHub] [skywalking] wu-sheng commented on issue #5116: happen error when use trace tookit to get traceid

2020-07-17 Thread GitBox
wu-sheng commented on issue #5116: URL: https://github.com/apache/skywalking/issues/5116#issuecomment-659997673 > log info about agent should log in skywalking-api.log file ,why my java program will output about agent core's information Agent has issue in the initialization stage,

[GitHub] [skywalking] wu-sheng closed issue #5116: happen error when use trace tookit to get traceid

2020-07-17 Thread GitBox
wu-sheng closed issue #5116: URL: https://github.com/apache/skywalking/issues/5116 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] wu-sheng commented on issue #5116: happen error when use trace tookit to get traceid

2020-07-17 Thread GitBox
wu-sheng commented on issue #5116: URL: https://github.com/apache/skywalking/issues/5116#issuecomment-659997403 Don't use WinRAR, don't untar the package in Windows. I noticed there are some issues that happened. Use Linux or Mac.

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] janecms opened a new issue #5118: Spring Cloud gateway : Why all endpoind is a fixed value “WEBFLUX.handle”

2020-07-17 Thread GitBox
janecms opened a new issue #5118: URL: https://github.com/apache/skywalking/issues/5118 Env list: - SkyWalking 6.6.0 - JRE8 - Spring cloud gateway 2.1.14 I Found all endpoint is the same value "WEBFLUX.handle" ` graphql queryEndpoints output: [ {

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] EvanLjp commented on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
EvanLjp commented on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660075856 so i cannot extension with service mode , i would be add a new extension interface ? This is an automated

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr=h1) Report > Merging

[GitHub] [skywalking] EvanLjp opened a new pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
EvanLjp opened a new pull request #5120: URL: https://github.com/apache/skywalking/pull/5120 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] New feature provided - Related issues

[GitHub] [skywalking] EvanLjp commented on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
EvanLjp commented on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660063968 I will add unit tests later, thanks for review first This is an automated message from the Apache Git

[GitHub] [skywalking] EvanLjp commented on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
EvanLjp commented on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660072780 fixing unit test,please wait for a moment This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[skywalking] branch zipkin updated: Add tests for Zipkin Context Manager.

2020-07-17 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch zipkin in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/zipkin by this push: new dbd97b5 Add tests for Zipkin Context

[GitHub] [skywalking] wu-sheng closed issue #5118: Spring Cloud gateway : Why all endpoind is a fixed value “WEBFLUX.handle”

2020-07-17 Thread GitBox
wu-sheng closed issue #5118: URL: https://github.com/apache/skywalking/issues/5118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] wu-sheng commented on issue #5118: Spring Cloud gateway : Why all endpoind is a fixed value “WEBFLUX.handle”

2020-07-17 Thread GitBox
wu-sheng commented on issue #5118: URL: https://github.com/apache/skywalking/issues/5118#issuecomment-660045350 Use 8.0, how do this is open sourced. Read the codes if want to understand something. This is an automated

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
wu-sheng commented on a change in pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#discussion_r456442911 ## File path:

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr=h1) Report > Merging

[GitHub] [skywalking] EvanLjp commented on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
EvanLjp commented on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660075197 > I think I mentioned before, neither service discovery tech should not be bounded in the agemt core level. If you want to contribute this feature, you need to put it as an

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] EvanLjp commented on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
EvanLjp commented on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-660092729 @wu-sheng already rename module + delete invalid file This is an automated message from the Apache Git

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-647428853 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4959?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng closed issue #4965: InstMethodsInter : class[class com.mysql.cj.jdbc.ClientPreparedStatement] before method[executeQuery] intercept java.lang.NullPointerException failu

2020-07-17 Thread GitBox
wu-sheng closed issue #4965: URL: https://github.com/apache/skywalking/issues/4965 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] wu-sheng merged pull request #5109: Fix issue 4965

2020-07-17 Thread GitBox
wu-sheng merged pull request #5109: URL: https://github.com/apache/skywalking/pull/5109 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[skywalking] branch master updated: Fix issue 4965 (#5109)

2020-07-17 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 62f7688 Fix issue 4965 (#5109) 62f7688 is

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5085: Include request method type in rest mapping annotations

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5085: URL: https://github.com/apache/skywalking/pull/5085#issuecomment-657074748 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5085?src=pr=h1) Report > Merging

[GitHub] [skywalking] suresh-pandi opened a new issue #5119: Inquiry: can we monitor db connection pool

2020-07-17 Thread GitBox
suresh-pandi opened a new issue #5119: URL: https://github.com/apache/skywalking/issues/5119 Please answer these questions before submitting your issue. - Why do you submit this issue? - [*] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on pull request #4959: Configmap configuration

2020-07-17 Thread GitBox
wu-sheng commented on pull request #4959: URL: https://github.com/apache/skywalking/pull/4959#issuecomment-660097268 By thinking the PR and Kafka transport PR, I prefer you work on a new PR. Introduce a new SPI service, called ConfigInitService. All plugins and core could provide their

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] killGC commented on issue #5116: happen error when use trace tookit to get traceid

2020-07-17 Thread GitBox
killGC commented on issue #5116: URL: https://github.com/apache/skywalking/issues/5116#issuecomment-659996040 log info about agent should log in skywalking-api.log file ,why my java program will output about agent core's information

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660068461 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5120?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
wu-sheng commented on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660074709 Don't change the backend serive url config, it will break many deployed system. Please don't do that. This

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4847: Provide kafka as collector/reporter

2020-07-17 Thread GitBox
codecov[bot] edited a comment on pull request #4847: URL: https://github.com/apache/skywalking/pull/4847#issuecomment-637517692 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4847?src=pr=h1) Report > Merging

[GitHub] [skywalking] EvanLjp commented on pull request #5120: Agent service discorvery

2020-07-17 Thread GitBox
EvanLjp commented on pull request #5120: URL: https://github.com/apache/skywalking/pull/5120#issuecomment-660080461 > The concern is, the default config changed. And new backend service path added. This would be very confused. How to write plugin doc would be an issue. how about

  1   2   3   4   >