[GitHub] [skywalking] Diyuzhou opened a new issue #5646: Performance Profiling task can not be removed from task list

2020-10-10 Thread GitBox
Diyuzhou opened a new issue #5646: URL: https://github.com/apache/skywalking/issues/5646 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ *] Bug - [ ] Requirement - [ ] Feature or performance

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5644?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5644?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5644?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] wu-sheng commented on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
wu-sheng commented on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706538819 > Thrift allows us to append any additional field in the Message even if the receiver doesn't deal with them. This data is going to be skipped while no one reads.

[skywalking-agent-test-tool] branch meter_agent_test updated: Add comments and NPE check

2020-10-10 Thread liuhan
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a commit to branch meter_agent_test in repository https://gitbox.apache.org/repos/asf/skywalking-agent-test-tool.git The following commit(s) were added to refs/heads/meter_agent_test by this push: new d1f0ed5

[GitHub] [skywalking] codecov[bot] commented on pull request #5647: Fix typo in ProfileTask.java

2020-10-10 Thread GitBox
codecov[bot] commented on pull request #5647: URL: https://github.com/apache/skywalking/pull/5647#issuecomment-706548831 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5647?src=pr=h1) Report > Merging [#5647](https://codecov.io/gh/apache/skywalking/pull/5647?src=pr=desc) into

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5647: Fix typo in ProfileTask.java

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5647: URL: https://github.com/apache/skywalking/pull/5647#issuecomment-706548831 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5647: Fix typo in ProfileTask.java

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5647: URL: https://github.com/apache/skywalking/pull/5647#issuecomment-706548831 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5647?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5647: Fix typo in ProfileTask.java

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5647: URL: https://github.com/apache/skywalking/pull/5647#issuecomment-706548831 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5647?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
wu-sheng commented on a change in pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#discussion_r502783142 ## File path: apm-sniffer/apm-sdk-plugin/thrift-plugin/src/main/java/org/apache/skywalking/apm/plugin/thrift/TBaseProcessorInterceptor.java ## @@

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
wu-sheng commented on a change in pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#discussion_r502783211 ## File path: apm-sniffer/apm-sdk-plugin/thrift-plugin/src/main/java/org/apache/skywalking/apm/plugin/thrift/client/TAsyncClientInterceptor.java ##

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
wu-sheng commented on a change in pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#discussion_r502783228 ## File path: apm-sniffer/apm-sdk-plugin/thrift-plugin/src/main/java/org/apache/skywalking/apm/plugin/thrift/client/TAsyncMethodCallInterceptor.java

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5644?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5644?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] Humbertzhang opened a new pull request #5647: Fix typo in ProfileTask.java

2020-10-10 Thread GitBox
Humbertzhang opened a new pull request #5647: URL: https://github.com/apache/skywalking/pull/5647 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance -

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5647: Fix typo in ProfileTask.java

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5647: URL: https://github.com/apache/skywalking/pull/5647#issuecomment-706548831 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5647?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5647: Fix typo in ProfileTask.java

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5647: URL: https://github.com/apache/skywalking/pull/5647#issuecomment-706548831 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5647?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5647: Fix typo in ProfileTask.java

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5647: URL: https://github.com/apache/skywalking/pull/5647#issuecomment-706548831 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5647?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5647: Fix typo in ProfileTask.java

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5647: URL: https://github.com/apache/skywalking/pull/5647#issuecomment-706548831 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5647?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5644?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5644?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5644?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng closed issue #5646: Performance Profiling task can not be removed from task list

2020-10-10 Thread GitBox
wu-sheng closed issue #5646: URL: https://github.com/apache/skywalking/issues/5646 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] wu-sheng commented on issue #5646: Performance Profiling task can not be removed from task list

2020-10-10 Thread GitBox
wu-sheng commented on issue #5646: URL: https://github.com/apache/skywalking/issues/5646#issuecomment-706538042 Why keep submitting things? I have replied in the previous one. This is an automated message from the Apache Git

[GitHub] [skywalking] Diyuzhou commented on issue #5646: Performance Profiling task can not be removed from task list

2020-10-10 Thread GitBox
Diyuzhou commented on issue #5646: URL: https://github.com/apache/skywalking/issues/5646#issuecomment-706537910 how can I remove useless tasks in task list. This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5644?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5644?src=pr=h1) Report > Merging

[GitHub] [skywalking-agent-test-tool] mrproliu opened a new pull request #25: Provide mock meter server and validate

2020-10-10 Thread GitBox
mrproliu opened a new pull request #25: URL: https://github.com/apache/skywalking-agent-test-tool/pull/25 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5647: Fix typo in ProfileTask.java

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5647: URL: https://github.com/apache/skywalking/pull/5647#issuecomment-706548831 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5647?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5647: Fix typo in ProfileTask.java

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5647: URL: https://github.com/apache/skywalking/pull/5647#issuecomment-706548831 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] wu-sheng merged pull request #5647: Fix typo in ProfileTask.java

2020-10-10 Thread GitBox
wu-sheng merged pull request #5647: URL: https://github.com/apache/skywalking/pull/5647 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[skywalking] branch master updated: Fix typo in ProfileTask.java (#5647)

2020-10-10 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new bde07d7 Fix typo in ProfileTask.java

[skywalking-agent-test-tool] branch meter_agent_test updated (d1f0ed5 -> 11bcb5b)

2020-10-10 Thread liuhan
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a change to branch meter_agent_test in repository https://gitbox.apache.org/repos/asf/skywalking-agent-test-tool.git. from d1f0ed5 Add comments and NPE check add 11bcb5b Add data description No new

[GitHub] [skywalking] muse-dev[bot] commented on a change in pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
muse-dev[bot] commented on a change in pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#discussion_r502782047 ## File path: apm-sniffer/apm-sdk-plugin/thrift-plugin/src/main/java/org/apache/skywalking/apm/plugin/thrift/wrapper/AsyncContext.java ## @@

[GitHub] [skywalking] muse-dev[bot] commented on a change in pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
muse-dev[bot] commented on a change in pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#discussion_r502782024 ## File path: apm-sniffer/apm-sdk-plugin/thrift-plugin/src/main/java/org/apache/skywalking/apm/plugin/thrift/wrapper/ServerInProtocolWrapper.java

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5644?src=pr=h1) Report > Merging

[GitHub] [skywalking] Diyuzhou commented on issue #5645: task list can not be removed

2020-10-10 Thread GitBox
Diyuzhou commented on issue #5645: URL: https://github.com/apache/skywalking/issues/5645#issuecomment-706537115 ![Screen Shot 2020-10-10 at 7 51 31 PM](https://user-images.githubusercontent.com/21288434/95654349-04b25b00-0b32-11eb-8cf9-6637faf2d413.png) here is the picture

[GitHub] [skywalking] wu-sheng commented on issue #5645: task list can not be removed

2020-10-10 Thread GitBox
wu-sheng commented on issue #5645: URL: https://github.com/apache/skywalking/issues/5645#issuecomment-706537068 What is the task list? Do you mean profiling task? If so, it will be removed according to record TTL This is

[GitHub] [skywalking] Diyuzhou commented on issue #5645: task list can not be removed

2020-10-10 Thread GitBox
Diyuzhou commented on issue #5645: URL: https://github.com/apache/skywalking/issues/5645#issuecomment-706537167 can not remove tasks in task list This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] wu-sheng closed issue #5645: task list can not be removed

2020-10-10 Thread GitBox
wu-sheng closed issue #5645: URL: https://github.com/apache/skywalking/issues/5645 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] Diyuzhou opened a new issue #5645: task list can not be removed

2020-10-10 Thread GitBox
Diyuzhou opened a new issue #5645: URL: https://github.com/apache/skywalking/issues/5645 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [* ] Requirement - [ ] Feature or performance

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5644?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5644?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5644?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5644?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5647: Fix typo in ProfileTask.java

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5647: URL: https://github.com/apache/skywalking/pull/5647#issuecomment-706548831 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5647?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5647: Fix typo in ProfileTask.java

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5647: URL: https://github.com/apache/skywalking/pull/5647#issuecomment-706548831 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5647?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5647: Fix typo in ProfileTask.java

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5647: URL: https://github.com/apache/skywalking/pull/5647#issuecomment-706548831 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5647?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5647: Fix typo in ProfileTask.java

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5647: URL: https://github.com/apache/skywalking/pull/5647#issuecomment-706548831 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5647?src=pr=h1) Report > Merging

[GitHub] [skywalking-nginx-lua] kezhenxu94 merged pull request #43: doc: set the correct code block type.

2020-10-10 Thread GitBox
kezhenxu94 merged pull request #43: URL: https://github.com/apache/skywalking-nginx-lua/pull/43 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5640: Add e2e test for python kafka report protocol

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5640: URL: https://github.com/apache/skywalking/pull/5640#issuecomment-706474876 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5640?src=pr=h1) Report > Merging

[skywalking-nginx-lua] branch master updated: doc: set the correct code block type. (#43)

2020-10-10 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-nginx-lua.git The following commit(s) were added to refs/heads/master by this push: new 47502fd doc: set the correct

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5640: Add e2e test for python kafka report protocol

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5640: URL: https://github.com/apache/skywalking/pull/5640#issuecomment-706474876 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] kezhenxu94 merged pull request #5640: Add E2E test for python Kafka report protocol

2020-10-10 Thread GitBox
kezhenxu94 merged pull request #5640: URL: https://github.com/apache/skywalking/pull/5640 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[skywalking] branch master updated: Add E2E test for python Kafka report protocol (#5640)

2020-10-10 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 3981538 Add E2E test for python Kafka

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on issue #364: question: is there a UI and skywalking version mapping table?

2020-10-10 Thread GitBox
wu-sheng commented on issue #364: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/364#issuecomment-706519785 No, we don't recommend it in this way. So, we don't provide the mapping table. Please use the same version. Note, even the agent is not compatible between 6.3.0

[GitHub] [skywalking-rocketbot-ui] wu-sheng closed issue #364: question: is there a UI and skywalking version mapping table?

2020-10-10 Thread GitBox
wu-sheng closed issue #364: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/364 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [skywalking-nginx-lua] wu-sheng commented on pull request #46: chore: load the base64 in `utils`, different ENV use different way.

2020-10-10 Thread GitBox
wu-sheng commented on pull request #46: URL: https://github.com/apache/skywalking-nginx-lua/pull/46#issuecomment-706519581 @membphis Release still has been processed by at least a committer. @moonming do you plan to help about this?

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5640: Add E2E test for python Kafka report protocol

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5640: URL: https://github.com/apache/skywalking/pull/5640#issuecomment-706474876 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5640?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5640: Add E2E test for python Kafka report protocol

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5640: URL: https://github.com/apache/skywalking/pull/5640#issuecomment-706474876 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5640?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng closed issue #5642: pxx指标是否存在并发问题

2020-10-10 Thread GitBox
wu-sheng closed issue #5642: URL: https://github.com/apache/skywalking/issues/5642 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] ieven opened a new issue #5642: pxx指标是否存在并发问题

2020-10-10 Thread GitBox
ieven opened a new issue #5642: URL: https://github.com/apache/skywalking/issues/5642 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance

[GitHub] [skywalking] wu-sheng commented on issue #5642: pxx指标是否存在并发问题

2020-10-10 Thread GitBox
wu-sheng commented on issue #5642: URL: https://github.com/apache/skywalking/issues/5642#issuecomment-706509112 Please use English on the Github. We provided mandarin channel already. This is an automated message from the

[GitHub] [skywalking] ieven opened a new issue #5643: Does the percentile metrics have concurrency problems

2020-10-10 Thread GitBox
ieven opened a new issue #5643: URL: https://github.com/apache/skywalking/issues/5643 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5637: Health check for InfluxDB

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5637: URL: https://github.com/apache/skywalking/pull/5637#issuecomment-706092448 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5637?src=pr=h1) Report > Merging

[GitHub] [skywalking] dmsolr opened a new pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
dmsolr opened a new pull request #5644: URL: https://github.com/apache/skywalking/pull/5644 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [ ] Improve performance - Related

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5644?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5644?src=pr=h1) Report > Merging

[GitHub] [skywalking] JackESong opened a new issue #5641: does Skywallking supports oracle?

2020-10-10 Thread GitBox
JackESong opened a new issue #5641: URL: https://github.com/apache/skywalking/issues/5641 does Skywallking supports oracle? This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] wu-sheng closed issue #5641: does Skywallking supports oracle?

2020-10-10 Thread GitBox
wu-sheng closed issue #5641: URL: https://github.com/apache/skywalking/issues/5641 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] wu-sheng commented on issue #5641: does Skywallking supports oracle?

2020-10-10 Thread GitBox
wu-sheng commented on issue #5641: URL: https://github.com/apache/skywalking/issues/5641#issuecomment-706497060 Read the supported list. Thanks. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking-nginx-lua] membphis opened a new pull request #43: doc: set the correct code block type.

2020-10-10 Thread GitBox
membphis opened a new pull request #43: URL: https://github.com/apache/skywalking-nginx-lua/pull/43 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5640: Add e2e test for python kafka report protocol

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5640: URL: https://github.com/apache/skywalking/pull/5640#issuecomment-706474876 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5640: Add e2e test for python kafka report protocol

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5640: URL: https://github.com/apache/skywalking/pull/5640#issuecomment-706474876 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5640?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5640: Add e2e test for python kafka report protocol

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5640: URL: https://github.com/apache/skywalking/pull/5640#issuecomment-706474876 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5640: Add e2e test for python kafka report protocol

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5640: URL: https://github.com/apache/skywalking/pull/5640#issuecomment-706474876 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5640: Add e2e test for python kafka report protocol

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5640: URL: https://github.com/apache/skywalking/pull/5640#issuecomment-706474876 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5640?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5640: Add e2e test for python kafka report protocol

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5640: URL: https://github.com/apache/skywalking/pull/5640#issuecomment-706474876 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5640?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5640: Add e2e test for python kafka report protocol

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5640: URL: https://github.com/apache/skywalking/pull/5640#issuecomment-706474876 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5640?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5640: Add e2e test for python kafka report protocol

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5640: URL: https://github.com/apache/skywalking/pull/5640#issuecomment-706474876 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5640?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on issue #5643: Does the percentile metrics have concurrency problems

2020-10-10 Thread GitBox
wu-sheng commented on issue #5643: URL: https://github.com/apache/skywalking/issues/5643#issuecomment-706514591 There is no concurrency case unless the OAP cluster is not stable. We have guaranteed that in the OAP core. No metrics with the same id should be updated from two threads at the

[GitHub] [skywalking] wu-sheng closed issue #5643: Does the percentile metrics have concurrency problems

2020-10-10 Thread GitBox
wu-sheng closed issue #5643: URL: https://github.com/apache/skywalking/issues/5643 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking-nginx-lua] moonming commented on pull request #45: chore: only expose the method of setting random seed.

2020-10-10 Thread GitBox
moonming commented on pull request #45: URL: https://github.com/apache/skywalking-nginx-lua/pull/45#issuecomment-706515976 LGTM. API gateway maybe already set seed, for example Apache APISIX. So we don't need to do this job again.

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5637: Health check for InfluxDB

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5637: URL: https://github.com/apache/skywalking/pull/5637#issuecomment-706092448 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5637?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5637: Health check for InfluxDB

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5637: URL: https://github.com/apache/skywalking/pull/5637#issuecomment-706092448 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5637?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5637: Health check for InfluxDB

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5637: URL: https://github.com/apache/skywalking/pull/5637#issuecomment-706092448 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5637?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5637: Health check for InfluxDB

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5637: URL: https://github.com/apache/skywalking/pull/5637#issuecomment-706092448 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking-rocketbot-ui] worldwalk opened a new issue #364: question: is there a UI and skywalking version mapping table?

2020-10-10 Thread GitBox
worldwalk opened a new issue #364: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/364 such as skywalking v6.3.0, can it use UI v7.0.0 or v8.0.0 ? thanks! This is an automated message from the Apache Git

[GitHub] [skywalking-nginx-lua] membphis opened a new pull request #47: doc: add prefix `prefix` when require Lua library .

2020-10-10 Thread GitBox
membphis opened a new pull request #47: URL: https://github.com/apache/skywalking-nginx-lua/pull/47 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5644?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov[bot] commented on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] commented on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5644?src=pr=h1) Report > Merging [#5644](https://codecov.io/gh/apache/skywalking/pull/5644?src=pr=desc) into

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5644: Provide Thrift Plugin

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#issuecomment-706531169 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5640: Add e2e test for python kafka report protocol

2020-10-10 Thread GitBox
codecov[bot] edited a comment on pull request #5640: URL: https://github.com/apache/skywalking/pull/5640#issuecomment-706474876 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5640?src=pr=h1) Report > Merging

[GitHub] [skywalking-nginx-lua] moonming commented on pull request #44: bugfix: `require` other libraries, missing `skywalking` parent folder.

2020-10-10 Thread GitBox
moonming commented on pull request #44: URL: https://github.com/apache/skywalking-nginx-lua/pull/44#issuecomment-706512761 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log

  1   2   >