[GitHub] [skywalking] a1vin-tian commented on a change in pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
a1vin-tian commented on a change in pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#discussion_r656799561 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java ## @@ -92,69 +105,111 @@

[GitHub] [skywalking] tangxqa closed pull request #7164: Update CHANGES.md

2021-06-23 Thread GitBox
tangxqa closed pull request #7164: URL: https://github.com/apache/skywalking/pull/7164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [skywalking] aoxls commented on issue #7161: [Client JS] headers could be null

2021-06-23 Thread GitBox
aoxls commented on issue #7161: URL: https://github.com/apache/skywalking/issues/7161#issuecomment-866569185 OK, I have submitted a pull request already, please review it. https://github.com/apache/skywalking-client-js/pull/61 -- This is an automated message from the Apache Git

[GitHub] [skywalking] a1vin-tian commented on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
a1vin-tian commented on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-866574790 1. The worst case of this change is that the executed `prepare requests` concurrently and then call `batchDAO.synchronous.` But it is also faster than before because

[GitHub] [skywalking] a1vin-tian commented on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
a1vin-tian commented on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-866575222 OK > Hi @a1vin-tian, generally the codes are good. Could you add some comments in the codes for helping readers in the future? > It is easier to read currently,

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] commented on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] commented on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] wu-sheng commented on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
wu-sheng commented on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866570841 Hi, please update changes.md in the root folder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [skywalking] tangxqa opened a new pull request #7164: Update CHANGES.md

2021-06-23 Thread GitBox
tangxqa opened a new pull request #7164: URL: https://github.com/apache/skywalking/pull/7164 Change CHANGES.md for pull request : Profile.duration in agent.config , but it's Profile.MAX_DURATION in Config.java - [ x ] If this pull request

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] enoch1024 commented on pull request #3715: [plugin]support log4j2 AsyncLogger

2021-06-23 Thread GitBox
enoch1024 commented on pull request #3715: URL: https://github.com/apache/skywalking/pull/3715#issuecomment-866646348 @wu-sheng @zhaoyuguang When I use `Log4jContextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector` to set async log , plugin still doesn't work. I

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] heihaozi opened a new issue #7165: When configuring a gateway without the agent installed in gateways.yml, can the topology be improved?

2021-06-23 Thread GitBox
heihaozi opened a new issue #7165: URL: https://github.com/apache/skywalking/issues/7165 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [x] Feature or performance

[skywalking-client-js] branch master updated: fix: headers update null to object (#61)

2021-06-23 Thread qiuxiafan
This is an automated email from the ASF dual-hosted git repository. qiuxiafan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-client-js.git The following commit(s) were added to refs/heads/master by this push: new a73c1d2 fix: headers update

[GitHub] [skywalking] Fine0830 closed issue #7161: [Client JS] headers could be null

2021-06-23 Thread GitBox
Fine0830 closed issue #7161: URL: https://github.com/apache/skywalking/issues/7161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [skywalking-client-js] Fine0830 merged pull request #61: fix: headers could be null

2021-06-23 Thread GitBox
Fine0830 merged pull request #61: URL: https://github.com/apache/skywalking-client-js/pull/61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[skywalking] branch master updated: Update agent.config (#7163)

2021-06-23 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 3541c32 Update agent.config (#7163)

[GitHub] [skywalking] wu-sheng commented on pull request #3715: [plugin]support log4j2 AsyncLogger

2021-06-23 Thread GitBox
wu-sheng commented on pull request #3715: URL: https://github.com/apache/skywalking/pull/3715#issuecomment-866650464 > @wu-sheng @zhaoyuguang When I use `Log4jContextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector` > to set async log , plugin still doesn't work.

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] dmsolr commented on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
dmsolr commented on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-83926 > Hi @a1vin-tian, generally the codes are good. Could you add some comments in the codes for helping readers in the future? > It is easier to read currently, but more

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[skywalking-website] branch asf-site updated: deploy: 8e85b6813f2e70795067717084150483244a063a

2021-06-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 80d515f deploy:

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] wu-sheng commented on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
wu-sheng commented on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-866678666 @a1vin-tian I am thinking about how to polish the codes in an easier way. 2 key points we need to think about. 1. Could you add an internal queue concept to avoid using

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking-client-js] aoxls opened a new pull request #61: fix: headers could be null

2021-06-23 Thread GitBox
aoxls opened a new pull request #61: URL: https://github.com/apache/skywalking-client-js/pull/61 https://github.com/apache/skywalking/issues/7161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7163: Update agent.config

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7163: URL: https://github.com/apache/skywalking/pull/7163#issuecomment-866610186 #

[GitHub] [skywalking] wu-sheng closed issue #7162: Profile.duration in agent.config , but it's Profile.MAX_DURATION in Config.java

2021-06-23 Thread GitBox
wu-sheng closed issue #7162: URL: https://github.com/apache/skywalking/issues/7162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [skywalking] wu-sheng merged pull request #7163: Update agent.config

2021-06-23 Thread GitBox
wu-sheng merged pull request #7163: URL: https://github.com/apache/skywalking/pull/7163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
codecov[bot] edited a comment on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-865497341 #

[GitHub] [skywalking-python] kezhenxu94 commented on a change in pull request #125: Python celery plugin

2021-06-23 Thread GitBox
kezhenxu94 commented on a change in pull request #125: URL: https://github.com/apache/skywalking-python/pull/125#discussion_r657115742 ## File path: skywalking/agent/__init__.py ## @@ -65,14 +76,40 @@ def __init(): __protocol = KafkaProtocol() plugins.install()

[GitHub] [skywalking] wu-sheng commented on a change in pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
wu-sheng commented on a change in pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#discussion_r657140729 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java ## @@ -92,73 +105,165 @@

[GitHub] [skywalking] wu-sheng commented on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
wu-sheng commented on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-866873762 You update `skywalking-ui` submodule incorrectly. Please make sure it is unchanged. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] wu-sheng commented on pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
wu-sheng commented on pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#issuecomment-866899323 @EvanLjp @dmsolr Could you check the latest codes, it should be easier to read. I have commented about what should be polished. -- This is an automated message from the

[GitHub] [skywalking] wu-sheng commented on a change in pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
wu-sheng commented on a change in pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#discussion_r657140148 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java ## @@ -92,73 +105,165 @@

[GitHub] [skywalking] wu-sheng commented on a change in pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
wu-sheng commented on a change in pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#discussion_r657139981 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java ## @@ -92,73 +105,165 @@

[GitHub] [skywalking] wu-sheng commented on a change in pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
wu-sheng commented on a change in pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#discussion_r657137813 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java ## @@ -92,73 +105,165 @@

[GitHub] [skywalking] wu-sheng commented on a change in pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
wu-sheng commented on a change in pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#discussion_r657171941 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java ## @@ -77,9 +83,16 @@ public

[GitHub] [skywalking] wu-sheng commented on a change in pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
wu-sheng commented on a change in pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#discussion_r657130616 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java ## @@ -92,73 +105,165 @@

[GitHub] [skywalking] wu-sheng commented on a change in pull request #7153: Support prepare and save metrics concurrency

2021-06-23 Thread GitBox
wu-sheng commented on a change in pull request #7153: URL: https://github.com/apache/skywalking/pull/7153#discussion_r657138206 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java ## @@ -92,73 +105,165 @@

  1   2   3   >