[GitHub] peng-yongsheng commented on issue #1029: 5.0-alpha skyworking ui some part nothing show.
peng-yongsheng commented on issue #1029: 5.0-alpha skyworking ui some part nothing show. URL: https://github.com/apache/incubator-skywalking/issues/1029#issuecomment-379522658 @50168383 Please, give me service_name index datas in Elasticsearch. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] 50168383 commented on issue #1029: 5.0-alpha skyworking ui some part nothing show.
50168383 commented on issue #1029: 5.0-alpha skyworking ui some part nothing show. URL: https://github.com/apache/incubator-skywalking/issues/1029#issuecomment-379521524  debuging, screenshot 。please check ! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1029: 5.0-alpha skyworking ui some part nothing show.
wu-sheng commented on issue #1029: 5.0-alpha skyworking ui some part nothing show. URL: https://github.com/apache/incubator-skywalking/issues/1029#issuecomment-379517921 This file is used for segment buffer. If exist some operation names, peer IPs are not registered yet. So, this file should not be problem, except no data consumed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] 50168383 commented on issue #1029: 5.0-alpha skyworking ui some part nothing show.
50168383 commented on issue #1029: 5.0-alpha skyworking ui some part nothing show. URL: https://github.com/apache/incubator-skywalking/issues/1029#issuecomment-379517532 I find buffer/data_20180408112823.sw this file-size increase always why ？ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] breakenknife commented on issue #991: cluster module no provider exists
breakenknife commented on issue #991: cluster module no provider exists URL: https://github.com/apache/incubator-skywalking/issues/991#issuecomment-379517232 你好,我在期待collecter的时候,也遇到了这个问题.请问是配置问题吗?怎么解决的.  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] 50168383 commented on issue #1028: 5.0-alpha , Can't find XMemcachedConstructorWithHostPortArgInterceptor
50168383 commented on issue #1028: 5.0-alpha , Can't find XMemcachedConstructorWithHostPortArgInterceptor URL: https://github.com/apache/incubator-skywalking/issues/1028#issuecomment-379514939 OK，I send pull request for a moment . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng opened a new issue #1047: Refactor the collector configuration initialization.
wu-sheng opened a new issue #1047: Refactor the collector configuration initialization. URL: https://github.com/apache/incubator-skywalking/issues/1047 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [x] Feature or performance improvement ### Requirement or improvement - Please describe about your requirements or improvement suggestions. Right now, the collector configuration initialization is based on properties from yaml, which is cool, but the type of each setting is based on yaml config too. And this cause some problems when I want to override some setting from system properties. In order not to trigger type cast exception, we have to set the default value in yaml, but expected to override, which is very weird. The second problem of current mechanism is we are using a lot of `x_y_z` in yaml, which is good if only yaml considered. But when we want to override from system env (failed before), we can't find the proper char to separate `module#provider#settingKey`. In system env, `_` is a tradition, so we need remove all `_` in existed settings, and forbid that in the future. I think if we use Setting-Object mapping mechanism would helps. Create an object and individual class for each provider, all fields use CamelCase naming and type sensitive . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #1046: Caffeine license
wu-sheng closed pull request #1046: Caffeine license URL: https://github.com/apache/incubator-skywalking/pull/1046 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/apm-dist/release-docs/LICENSE b/apm-dist/release-docs/LICENSE index a2cf644b4..223103e9f 100644 --- a/apm-dist/release-docs/LICENSE +++ b/apm-dist/release-docs/LICENSE @@ -286,6 +286,7 @@ The text of each license is also included at licenses/LICENSE-[project].txt. servo 0.10.1: https://github.com/Netflix/servo, Apache 2.0 validation-api 1.1.0.Final: http://beanvalidation.org/licensing/, Apache 2.0 zuul-core 1.3.0: https://github.com/Netflix/zuul, Apache 2.0 +ben-manes caffeine 2.6.2: https://github.com/ben-manes/caffeine, Apache 2.0 MIT licenses diff --git a/apm-dist/release-docs/licenses/LICENSE-caffeine.txt b/apm-dist/release-docs/licenses/LICENSE-caffeine.txt new file mode 100644 index 0..56ee3c8c4 --- /dev/null +++ b/apm-dist/release-docs/licenses/LICENSE-caffeine.txt @@ -0,0 +1,201 @@ +Apache License + Version 2.0, January 2004 +http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + "License" shall mean the terms and conditions for use, reproduction, + and distribution as defined by Sections 1 through 9 of this document. + + "Licensor" shall mean the copyright owner or entity authorized by + the copyright owner that is granting the License. + + "Legal Entity" shall mean the union of the acting entity and all + other entities that control, are controlled by, or are under common + control with that entity. For the purposes of this definition, + "control" means (i) the power, direct or indirect, to cause the + direction or management of such entity, whether by contract or + otherwise, or (ii) ownership of fifty percent (50%) or more of the + outstanding shares, or (iii) beneficial ownership of such entity. + + "You" (or "Your") shall mean an individual or Legal Entity + exercising permissions granted by this License. + + "Source" form shall mean the preferred form for making modifications, + including but not limited to software source code, documentation + source, and configuration files. + + "Object" form shall mean any form resulting from mechanical + transformation or translation of a Source form, including but + not limited to compiled object code, generated documentation, + and conversions to other media types. + + "Work" shall mean the work of authorship, whether in Source or + Object form, made available under the License, as indicated by a + copyright notice that is included in or attached to the work + (an example is provided in the Appendix below). + + "Derivative Works" shall mean any work, whether in Source or Object + form, that is based on (or derived from) the Work and for which the + editorial revisions, annotations, elaborations, or other modifications + represent, as a whole, an original work of authorship. For the purposes + of this License, Derivative Works shall not include works that remain + separable from, or merely link (or bind by name) to the interfaces of, + the Work and Derivative Works thereof. + + "Contribution" shall mean any work of authorship, including + the original version of the Work and any modifications or additions + to that Work or Derivative Works thereof, that is intentionally + submitted to Licensor for inclusion in the Work by the copyright owner + or by an individual or Legal Entity authorized to submit on behalf of + the copyright owner. For the purposes of this definition, "submitted" + means any form of electronic, verbal, or written communication sent + to the Licensor or its representatives, including but not limited to + communication on electronic mailing lists, source code control systems, + and issue tracking systems that are managed by, or on behalf of, the + Licensor for the purpose of discussing and improving the Work, but + excluding communication that is conspicuously marked or otherwise + designated in writing by the copyright owner as "Not a Contribution." + + "Contributor" shall mean Licensor and any individual or Legal Entity + on behalf of whom a Contribution has been received by Licensor and + subsequently incorporated within the Work. + + 2. Grant of Copyright License. Subject to the terms and conditions of + this License, each Contributor hereby
[GitHub] peng-yongsheng commented on issue #1046: Caffeine license
peng-yongsheng commented on issue #1046: Caffeine license URL: https://github.com/apache/incubator-skywalking/pull/1046#issuecomment-379512786 I had check the dependency tree in IDEA. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1046: Caffeine license
wu-sheng commented on issue #1046: Caffeine license URL: https://github.com/apache/incubator-skywalking/pull/1046#issuecomment-379512534 I rechecked here: http://search.maven.org/#artifactdetails%7Ccom.github.ben-manes.caffeine%7Ccaffeine%7C2.6.2%7C Look like there is no dependencies of dependencies. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng opened a new pull request #1046: Caffeine license
peng-yongsheng opened a new pull request #1046: Caffeine license URL: https://github.com/apache/incubator-skywalking/pull/1046 Please answer these questions before submitting pull request - Why submit this pull request? - [X] Document ___ ### New feature or improvement - Describe the details and related test reports. Caffeine license, Apache 2.0, no NOTICE file in repository which is https://github.com/ben-manes/caffeine. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hanahmily closed pull request #154: fix Field 'name' in type 'AppServerInfo' is undefined error in javascript
hanahmily closed pull request #154: fix Field 'name' in type 'AppServerInfo' is
undefined error in javascript
URL: https://github.com/apache/incubator-skywalking-ui/pull/154
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/models/application.js b/src/models/application.js
index 26b8fee..67a109a 100644
--- a/src/models/application.js
+++ b/src/models/application.js
@@ -36,7 +36,7 @@ const dataQuery = `
}
getServerThroughput(applicationId: $applicationId, duration: $duration,
topN: 10) {
key: id
- name
+ osName
callsPerSec
}
getApplicationTopology(applicationId: $applicationId, duration: $duration)
{
diff --git a/src/routes/Server/Server.js b/src/routes/Server/Server.js
index c176fb7..6469c79 100644
--- a/src/routes/Server/Server.js
+++ b/src/routes/Server/Server.js
@@ -87,7 +87,7 @@ export default class Server extends PureComponent {
query SearchServer($keyword: String!, $duration: Duration!) {
searchServer(keyword: $keyword, duration: $duration) {
key: id
- name
+ osName
host
pid
ipv4
@@ -111,7 +111,7 @@ export default class Server extends PureComponent {
{serverInfo.host}
{serverInfo.ipv4 ?
serverInfo.ipv4.join() : ''}
{serverInfo.pid}
- {serverInfo.name}
+ {serverInfo.osName}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wu-sheng opened a new issue #155: Wrong Unit in Server view.
wu-sheng opened a new issue #155: Wrong Unit in Server view.
URL: https://github.com/apache/incubator-skywalking-ui/issues/155
Based on GraphQL protocol:
```
# The gc trend represents the numbers of Garbage Collector execution
type GCTrend {
youngGC: [Int!]!
oldGC: [Int!]!
}
```
This value should ref to count, not time. So the Unit should be
`Calls`/`Count`, not `ms`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wu-sheng closed issue #153: License file
wu-sheng closed issue #153: License file URL: https://github.com/apache/incubator-skywalking-ui/issues/153 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #1045: Feature/1032
wu-sheng closed pull request #1045: Feature/1032
URL: https://github.com/apache/incubator-skywalking/pull/1045
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/apm-collector/apm-collector-analysis/analysis-metric/metric-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/metric/provider/worker/application/component/ApplicationComponentSpanListener.java
b/apm-collector/apm-collector-analysis/analysis-metric/metric-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/metric/provider/worker/application/component/ApplicationComponentSpanListener.java
index d6743d78c..6408b6e1e 100644
---
a/apm-collector/apm-collector-analysis/analysis-metric/metric-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/metric/provider/worker/application/component/ApplicationComponentSpanListener.java
+++
b/apm-collector/apm-collector-analysis/analysis-metric/metric-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/metric/provider/worker/application/component/ApplicationComponentSpanListener.java
@@ -77,7 +77,11 @@ public void parseEntry(SpanDecorator spanDecorator, int
applicationId, int insta
@Override
public void parseFirst(SpanDecorator spanDecorator, int applicationId, int
instanceId,
String segmentId) {
-timeBucket =
TimeBucketUtils.INSTANCE.getMinuteTimeBucket(spanDecorator.getStartTime());
+if (spanDecorator.getStartTimeMinuteTimeBucket() == 0) {
+long startTimeMinuteTimeBucket =
TimeBucketUtils.INSTANCE.getMinuteTimeBucket(spanDecorator.getStartTime());
+
spanDecorator.setStartTimeMinuteTimeBucket(startTimeMinuteTimeBucket);
+}
+timeBucket = spanDecorator.getStartTimeMinuteTimeBucket();
}
@Override public void build() {
diff --git
a/apm-collector/apm-collector-analysis/analysis-metric/metric-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/metric/provider/worker/application/mapping/ApplicationMappingSpanListener.java
b/apm-collector/apm-collector-analysis/analysis-metric/metric-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/metric/provider/worker/application/mapping/ApplicationMappingSpanListener.java
index 8f51fdb04..c0f2e8803 100644
---
a/apm-collector/apm-collector-analysis/analysis-metric/metric-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/metric/provider/worker/application/mapping/ApplicationMappingSpanListener.java
+++
b/apm-collector/apm-collector-analysis/analysis-metric/metric-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/metric/provider/worker/application/mapping/ApplicationMappingSpanListener.java
@@ -77,7 +77,11 @@ private ApplicationMappingSpanListener(ModuleManager
moduleManager) {
@Override
public void parseFirst(SpanDecorator spanDecorator, int applicationId, int
instanceId,
String segmentId) {
-timeBucket =
TimeBucketUtils.INSTANCE.getMinuteTimeBucket(spanDecorator.getStartTime());
+if (spanDecorator.getStartTimeMinuteTimeBucket() == 0) {
+long startTimeMinuteTimeBucket =
TimeBucketUtils.INSTANCE.getMinuteTimeBucket(spanDecorator.getStartTime());
+
spanDecorator.setStartTimeMinuteTimeBucket(startTimeMinuteTimeBucket);
+}
+timeBucket = spanDecorator.getStartTimeMinuteTimeBucket();
}
@Override public void build() {
diff --git
a/apm-collector/apm-collector-analysis/analysis-metric/metric-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/metric/provider/worker/global/GlobalTraceSpanListener.java
b/apm-collector/apm-collector-analysis/analysis-metric/metric-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/metric/provider/worker/global/GlobalTraceSpanListener.java
index 0bdd41441..a13e5e429 100644
---
a/apm-collector/apm-collector-analysis/analysis-metric/metric-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/metric/provider/worker/global/GlobalTraceSpanListener.java
+++
b/apm-collector/apm-collector-analysis/analysis-metric/metric-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/metric/provider/worker/global/GlobalTraceSpanListener.java
@@ -51,8 +51,13 @@
@Override
public void parseFirst(SpanDecorator spanDecorator, int applicationId, int
instanceId,
String segmentId) {
-this.timeBucket =
TimeBucketUtils.INSTANCE.getMinuteTimeBucket(spanDecorator.getStartTime());
this.segmentId = segmentId;
+
+if (spanDecorator.getStartTimeMinuteTimeBucket() == 0) {
+long startTimeMinuteTimeBucket =
TimeBucketUtils.INSTANCE.getMinuteTimeBucket(spanDecorator.getStartTime());
+
[GitHub] coveralls commented on issue #1045: Feature/1032
coveralls commented on issue #1045: Feature/1032 URL: https://github.com/apache/incubator-skywalking/pull/1045#issuecomment-379473655 [](https://coveralls.io/builds/16398947) Coverage increased (+0.1%) to 19.754% when pulling **81c991616b7124f09ae4e1692e4301fc9863898e on peng-yongsheng:feature/1032** into **4607128c4dbc094b35c468994ae93d33b78e9344 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wangmh commented on issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception
wangmh commented on issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception URL: https://github.com/apache/incubator-skywalking/issues/1044#issuecomment-379471160 i just test skywalking using grpc self's example code "Greeter code" https://github.com/grpc/grpc-java/blob/master/examples/src/main/java/io/grpc/examples/helloworld/HelloWorldClient.java This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #1032: Collector performance optimization
peng-yongsheng commented on issue #1032: Collector performance optimization
URL:
https://github.com/apache/incubator-skywalking/issues/1032#issuecomment-379450223
## Report digest
```
metric name: /persistence, avg: 372859, rate: 0, calls: 100039, total: 37(s)
metric name: /segment/parse, avg: 274427, rate: 0, calls: 56000, total: 15(s)
metric name: /persistence/get, avg: 2828750, rate: 0, calls: 4464, total:
12(s)
```
Those points could be a source of performance bottlenecks.
## Performance optimization
### Segment parse
Change cache component from Guava to Caffeine, [ Caffeine's
Benchmarks](https://github.com/ben-manes/caffeine/wiki/Benchmarks#read-100)
```
metric name: /persistence, avg: 194719, rate: 0, calls: 98341, total: 19(s)
metric name: /segment/parse, avg: 260367, rate: 0, calls: 56624, total: 14(s)
metric name: /persistence/get, avg: 1587150, rate: 0, calls: 4032, total:
6(s)
```
Make all the loggers class variable to have the static modifier.
```
Before:
/segment/parse
Avg=636584 (nanosecond), Success Rate=100%, Calls=14000,
Total=8912189125 (nanosecond)
After:
/segment/parse
Avg=524138 (nanosecond), Success Rate=100%, Calls=14097,
Total=7388775602 (nanosecond)
```
Time stamp format to time bucket performance optimization.
```
Before:
/segment/parse
Avg=557410 (nanosecond), Success Rate=100%, Calls=14139,
Total=7881231734 (nanosecond)
/utils/timeBucket/getSecondTimeBucket
Avg=9768 (nanosecond), Success Rate=100%, Calls=17417, Total=170135908
(nanosecond)
/utils/timeBucket/getMinuteTimeBucket
Avg=7384 (nanosecond), Success Rate=100%, Calls=82536, Total=609514865
(nanosecond)
After:
/segment/parse
Avg=503868 (nanosecond), Success Rate=100%, Calls=14085,
Total=7096993057 (nanosecond)
/utils/timeBucket/getSecondTimeBucket
Avg=13636 (nanosecond), Success Rate=100%, Calls=3664, Total=49964432
(nanosecond)
/utils/timeBucket/getMinuteTimeBucket
Avg=6148 (nanosecond), Success Rate=100%, Calls=27512, Total=169161105
(nanosecond)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wangmh commented on issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception
wangmh commented on issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception URL: https://github.com/apache/incubator-skywalking/issues/1044#issuecomment-379471160 i just test skywalking useing grpc self's example code "Greeter code" https://github.com/grpc/grpc-java/blob/master/examples/src/main/java/io/grpc/examples/helloworld/HelloWorldClient.java This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng opened a new pull request #1045: Feature/1032
peng-yongsheng opened a new pull request #1045: Feature/1032 URL: https://github.com/apache/incubator-skywalking/pull/1045 Please answer these questions before submitting pull request - Why submit this pull request? - [X] Improve performance - Related issues #1032 ___ ### New feature or improvement - Describe the details and related test reports. 1. Time stamp format to time bucket performance optimization. 2. Reduce the number of calls to the method named "getMinuteTimeBucket". ``` Before: /utils/timeBucket/getSecondTimeBucket Avg=9768 (nanosecond), Success Rate=100%, Calls=17417, Total=170135908 (nanosecond) /utils/timeBucket/getMinuteTimeBucket Avg=7384 (nanosecond), Success Rate=100%, Calls=82536, Total=609514865 (nanosecond) After: /utils/timeBucket/getSecondTimeBucket Avg=13636 (nanosecond), Success Rate=100%, Calls=3664, Total=49964432 (nanosecond) /utils/timeBucket/getMinuteTimeBucket Avg=6148 (nanosecond), Success Rate=100%, Calls=27512, Total=169161105 (nanosecond) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception
wu-sheng commented on issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception URL: https://github.com/apache/incubator-skywalking/issues/1044#issuecomment-379470742 @wangmh What is your way of using gRPC streaming? From the stack, I just know there is really no active span. Maybe bug, or maybe across thread. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wangmh opened a new issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception
wangmh opened a new issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception URL: https://github.com/apache/incubator-skywalking/issues/1044 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [# ] Bug - [ ] Requirement - [ ] Feature or performance improvement ### Bug - Which version of SkyWalking, OS and JRE? 5.0.0 alpha mac jdk 1.8 - Which company or project? http://hualala.com/ - What happen? ` 四月 07, 2018 2:55:18 下午 io.grpc.internal.SerializingExecutor run 严重: Exception while executing runnable io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1Closed@5cd81a9e java.lang.NullPointerException at org.apache.skywalking.apm.agent.core.context.ContextManager.activeSpan(ContextManager.java:163) at org.apache.skywalking.apm.agent.core.context.ContextManager.stopSpan(ContextManager.java:167) at org.apache.skywalking.apm.plugin.grpc.v1.CallServerInterceptor$ServerCallListener.onComplete(CallServerInterceptor.java:97) at io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.closed(ServerCallImpl.java:278) at io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1Closed.runInContext(ServerImpl.java:679) at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37) at io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:123) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745)` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1043: Feature/1032
coveralls commented on issue #1043: Feature/1032 URL: https://github.com/apache/incubator-skywalking/pull/1043#issuecomment-379467484 [](https://coveralls.io/builds/16398368) Coverage increased (+0.005%) to 19.658% when pulling **c8b1430f180a44643a5eee4a0b1e98308106ef60 on peng-yongsheng:feature/1032** into **b08309953ebf3ae987eb90d25d1f22593e28ea32 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #1032: Collector performance optimization
peng-yongsheng commented on issue #1032: Collector performance optimization
URL:
https://github.com/apache/incubator-skywalking/issues/1032#issuecomment-379450223
## Report digest
```
metric name: /persistence, avg: 372859, rate: 0, calls: 100039, total: 37(s)
metric name: /segment/parse, avg: 274427, rate: 0, calls: 56000, total: 15(s)
metric name: /persistence/get, avg: 2828750, rate: 0, calls: 4464, total:
12(s)
```
Those points could be a source of performance bottlenecks.
## Performance optimization
### Segment parse
Change cache component from Guava to Caffeine, [ Caffeine's
Benchmarks](https://github.com/ben-manes/caffeine/wiki/Benchmarks#read-100)
```
metric name: /persistence, avg: 194719, rate: 0, calls: 98341, total: 19(s)
metric name: /segment/parse, avg: 260367, rate: 0, calls: 56624, total: 14(s)
metric name: /persistence/get, avg: 1587150, rate: 0, calls: 4032, total:
6(s)
```
Make all the loggers class variable to have the static modifier.
```
Before:
/segment/parse
Avg=636584 (nanosecond), Success Rate=100%, Calls=14000,
Total=8912189125 (nanosecond)
After:
/segment/parse
Avg=524138 (nanosecond), Success Rate=100%, Calls=14097,
Total=7388775602 (nanosecond)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] peng-yongsheng opened a new pull request #1043: Feature/1032
peng-yongsheng opened a new pull request #1043: Feature/1032 URL: https://github.com/apache/incubator-skywalking/pull/1043 Please answer these questions before submitting pull request - Why submit this pull request? - [X] Improve performance - Related issues #1032 ___ ### New feature or improvement - Describe the details and related test reports. Make all the loggers class variable to have the static modifier. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #1032: Collector performance optimization
peng-yongsheng commented on issue #1032: Collector performance optimization
URL:
https://github.com/apache/incubator-skywalking/issues/1032#issuecomment-379450223
### Report digest
```
metric name: /persistence, avg: 372859, rate: 0, calls: 100039, total: 37(s)
metric name: /segment/parse, avg: 274427, rate: 0, calls: 56000, total: 15(s)
metric name: /persistence/get, avg: 2828750, rate: 0, calls: 4464, total:
12(s)
```
Those points could be a source of performance bottlenecks.
### Performance optimization
Segment parse
- Change cache component from Guava to Caffeine, [ Caffeine's
Benchmarks](https://github.com/ben-manes/caffeine/wiki/Benchmarks#read-100)
```
metric name: /persistence, avg: 194719, rate: 0, calls: 98341, total: 19(s)
metric name: /segment/parse, avg: 260367, rate: 0, calls: 56624, total: 14(s)
metric name: /persistence/get, avg: 1587150, rate: 0, calls: 4032, total:
6(s)
```
- Span listeners create
```
metric name: /segment/parse/createSpanListeners, avg: 26518, rate: 0, calls:
14066, total: 1.37(s)
metric name:
/segment/parse/createSpanListeners/serviceReferenceMetricSpanListener, avg:
20038, rate: 0, calls: 14066, total: 281(ms)
metric name:
/segment/parse/createSpanListeners/applicationComponentSpanListener, avg: 1550,
rate: 0, calls: 14066, total: 21(ms)
metric name:
/segment/parse/createSpanListeners/applicationMappingSpanListener, avg: 17050,
rate: 0, calls: 14066, total: 239(ms)
metric name: /segment/parse/createSpanListeners/instanceMappingSpanListener,
avg: 15595, rate: 0, calls: 14066, total: 219(ms)
metric name: /segment/parse/createSpanListeners/globalTraceSpanListener,
avg: 16881, rate: 0, calls: 14066, total: 237(ms)
metric name: /segment/parse/createSpanListeners/segmentDurationSpanListener,
avg: 16651, rate: 0, calls: 14066, total: 234(ms)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] peng-yongsheng commented on issue #1032: Collector performance optimization
peng-yongsheng commented on issue #1032: Collector performance optimization
URL:
https://github.com/apache/incubator-skywalking/issues/1032#issuecomment-379450223
### Report digest
```
metric name: /persistence, avg: 372859, rate: 0, calls: 100039, total: 37(s)
metric name: /segment/parse, avg: 274427, rate: 0, calls: 56000, total: 15(s)
metric name: /persistence/get, avg: 2828750, rate: 0, calls: 4464, total:
12(s)
```
Those points could be a source of performance bottlenecks.
### Performance optimization
Segment parse
- Change cache component from Guava to Caffeine, [ Caffeine's
Benchmarks](https://github.com/ben-manes/caffeine/wiki/Benchmarks#read-100)
```
metric name: /persistence, avg: 194719, rate: 0, calls: 98341, total: 19(s)
metric name: /segment/parse, avg: 260367, rate: 0, calls: 56624, total: 14(s)
metric name: /persistence/get, avg: 1587150, rate: 0, calls: 4032, total:
6(s)
```
- Span listeners create
```
metric name: /segment/parse/createSpanListeners, avg: 26518, rate: 0, calls:
98462, total: 2(s)
metric name:
/segment/parse/createSpanListeners/serviceReferenceMetricSpanListener, avg:
20038, rate: 0, calls: 14066, total: 281(ms)
metric name:
/segment/parse/createSpanListeners/applicationComponentSpanListener, avg: 1550,
rate: 0, calls: 14066, total: 21(ms)
metric name:
/segment/parse/createSpanListeners/applicationMappingSpanListener, avg: 17050,
rate: 0, calls: 14066, total: 239(ms)
metric name: /segment/parse/createSpanListeners/instanceMappingSpanListener,
avg: 15595, rate: 0, calls: 14066, total: 219(ms)
metric name: /segment/parse/createSpanListeners/globalTraceSpanListener,
avg: 16881, rate: 0, calls: 14066, total: 237(ms)
metric name: /segment/parse/createSpanListeners/segmentDurationSpanListener,
avg: 16651, rate: 0, calls: 14066, total: 234(ms)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] coveralls commented on issue #1042: Feature/1032
coveralls commented on issue #1042: Feature/1032 URL: https://github.com/apache/incubator-skywalking/pull/1042#issuecomment-379461069 [](https://coveralls.io/builds/16397815) Coverage remained the same at 19.653% when pulling **4bcd4ad41c9ebc377a29e1c3b99ad3c5413e on peng-yongsheng:feature/1032** into **cc655e143521d90c564176a739b9c30a9e86b0ae on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng opened a new pull request #1042: Feature/1032
peng-yongsheng opened a new pull request #1042: Feature/1032 URL: https://github.com/apache/incubator-skywalking/pull/1042 Please answer these questions before submitting pull request - Why submit this pull request? - [X] Improve performance - Related issues #1032 ___ ### New feature or improvement - Describe the details and related test reports. Add a new cache implementation by caffeine. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #1032: Collector performance optimization
peng-yongsheng commented on issue #1032: Collector performance optimization
URL:
https://github.com/apache/incubator-skywalking/issues/1032#issuecomment-379450223
### Report digest
```
metric name: /persistence, avg: 372859, rate: 0, calls: 100039, total: 37(s)
metric name: /segment/parse, avg: 274427, rate: 0, calls: 56000, total: 15(s)
metric name: /persistence/get, avg: 2828750, rate: 0, calls: 4464, total:
12(s)
```
Those points could be a source of performance bottlenecks.
### Performance optimization
Segment parse
- Change cache component from Guava to Caffeine, [ Caffeine's
Benchmarks](https://github.com/ben-manes/caffeine/wiki/Benchmarks#read-100)
```
metric name: /persistence, avg: 194719, rate: 0, calls: 98341, total: 19(s)
metric name: /segment/parse, avg: 260367, rate: 0, calls: 56624, total: 14(s)
metric name: /persistence/get, avg: 1587150, rate: 0, calls: 4032, total:
6(s)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] peng-yongsheng commented on issue #1032: Collector performance optimization
peng-yongsheng commented on issue #1032: Collector performance optimization
URL:
https://github.com/apache/incubator-skywalking/issues/1032#issuecomment-379450223
### Report digest
```
metric name: /persistence, avg: 372859, rate: 0, calls: 100039, total: 37(s)
metric name: /segment/parse, avg: 274427, rate: 0, calls: 56000, total: 15(s)
metric name: /persistence/get, avg: 2828750, rate: 0, calls: 4464, total:
12(s)
```
Those points could be a source of performance bottlenecks.
### Performance optimization
Segment parse
- Change cache component from Guava to Caffeine, [ Caffeine's
Benchmarks](https://github.com/ben-manes/caffeine/wiki/Benchmarks#read-100)
```
metric name: /persistence, avg: 194719, rate: 0, calls: 98341, total: 19(s)
metric name: /segment, avg: 257264, rate: 0, calls: 56520, total: 14(s)
metric name: /persistence/get, avg: 1587150, rate: 0, calls: 4032, total:
6(s)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] coveralls commented on issue #1041: Use collector instrument module to collect performance metrics report
coveralls commented on issue #1041: Use collector instrument module to collect performance metrics report URL: https://github.com/apache/incubator-skywalking/pull/1041#issuecomment-379455389 [](https://coveralls.io/builds/16397393) Coverage increased (+0.1%) to 19.653% when pulling **4eff313977daa34511fcd553d94a6a663da27730 on peng-yongsheng:feature/1032** into **c53d5088bf63ebd925ef466f9a45cae5c941722f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng opened a new pull request #1041: Use collector instrument module to collect performance metrics report
peng-yongsheng opened a new pull request #1041: Use collector instrument module
to collect performance metrics report
URL: https://github.com/apache/incubator-skywalking/pull/1041
Please answer these questions before submitting pull request
- Why submit this pull request?
- [X] Improve performance
- Related issues
#1032
### New feature or improvement
- Describe the details and related test reports.
1. Add the performance collection point.
1. Report formatter.
Report
```
metric name: /persistence, avg: 372859, rate: 0, calls: 100039, total: 37(s)
metric name: /segment/parse, avg: 274427, rate: 0, calls: 56000, total: 15(s)
metric name: /persistence/get, avg: 2828750, rate: 0, calls: 4464, total:
12(s)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] peng-yongsheng commented on issue #1032: Collector performance optimization
peng-yongsheng commented on issue #1032: Collector performance optimization
URL:
https://github.com/apache/incubator-skywalking/issues/1032#issuecomment-379450223
### Report digest
```
metric name: /persistence, avg: 372859, rate: 0, calls: 100039, total: 37(s)
metric name: /segment/parse, avg: 274427, rate: 0, calls: 56000, total: 15(s)
metric name: /persistence/get, avg: 2828750, rate: 0, calls: 4464, total:
12(s)
```
Those points could be a source of performance bottlenecks.
### Performance optimization
Segment parse
- Change cache component from Guava to Caffeine, [ Caffeine's
Benchmarks](https://github.com/ben-manes/caffeine/wiki/Benchmarks#read-100)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] peng-yongsheng closed pull request #1040: Update pom.xml
peng-yongsheng closed pull request #1040: Update pom.xml URL: https://github.com/apache/incubator-skywalking/pull/1040 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
